ChangeLog 1.11 MB
Newer Older
1 2 3 4 5
2011-03-30  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (syms_of_xdisp) <scroll-conservatively>: Document the
	threshold of 100 lines for never-recentering scrolling.

6 7 8 9 10 11
2011-03-29  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): When scrolling down aggressively,
	scroll one screen line less, to make sure we end up at the margin
	for fractions close to 1.

12 13 14 15 16 17 18 19 20
2011-03-28  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): When point is above the window, allow
	searching as far as scroll_max, or one screenful, to compute
	vertical distance from PT to the scroll margin position.  This
	prevents try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.

21 22 23 24 25 26 27
2011-03-27  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): Clean up the case of PT below the
	margin at bottom of window: scroll_max can no longer be INT_MAX.
	(redisplay_window): Find character position of margin and use
	that, rather than adding margin to PT.

28 29 30 31
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)
32
	(try_scrolling): Limit scrolling to 100 screen lines.
33 34 35 36 37
	(SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)
38 39 40
	(try_scrolling): When aggressive scrolling is in use, don't let
	point enter the opposite scroll margin as result of the scroll.
	(redisplay_window): Fix operator precedence in condition.
41

42 43
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

44 45 46 47 48 49 50
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

72 73 74 75 76
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

77 78 79 80 81 82 83 84
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

116 117 118 119 120
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

143 144 145 146 147 148 149 150 151 152 153 154 155 156 157
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
158
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
159 160
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
161
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
162

163 164
	Fix more problems found by GCC 4.5.2's static checks.

165 166 167 168
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

169 170 171
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
172
	of objects (Bug#8318).
173

174 175 176
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

177 178 179 180
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
181 182
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
183

184 185 186
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

187 188
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
189 190
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
191

Paul Eggert's avatar
Paul Eggert committed
192 193
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
194

Paul Eggert's avatar
Paul Eggert committed
195
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
196

197 198 199
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
200
	socklen_t is wider than int (Bug#8277).
201 202 203 204
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

205 206 207 208
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
209
	(Fmake_network_process): Define label "retry_connect" only if needed.
210
	(Fnetwork_interface_info): Fix pointer signedness.
211
	(process_send_signal): Add cast to avoid pointer signedness problem.
212
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
213
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
214

215 216 217 218 219 220 221 222 223 224 225 226
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

227
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
228
	(xftfont_open): Rename locals to avoid shadowing.
229

230
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
231 232
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
233
	(ftfont_list): Remove unused local.
234 235 236
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
237

238 239
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
240 241
	* xml.c (make_dom): Now static.

242 243
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
244 245
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
246
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
247 248
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
249

250 251 252 253 254 255 256
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

257 258
	* textprop.c (property_change_between_p): Remove; unused.

259 260
	* intervals.c (interval_start_pos): Now static.

261 262
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

263 264 265
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

266 267
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
268
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
269 270
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
271

272 273
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

274 275
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
276 277
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
278 279
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
280

281 282 283 284
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

285
	* callproc.c (call_process_cleanup): Now static.
286
	(relocate_fd): Rename locals to avoid shadowing.
287

288 289 290 291 292
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

293 294 295 296
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

297 298 299 300 301 302
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

303 304 305 306 307 308
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

309 310 311 312 313
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

314 315 316 317
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

318 319 320 321
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

322 323
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

324 325
	Fix more problems found by GCC 4.5.2's static checks.

326 327 328
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

329 330 331 332 333 334 335
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

336 337 338
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

339
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
340 341 342
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
343

344 345
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
346 347
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
348
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
349

350 351
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
352
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
353
	* unexec.h: New file.
354 355 356 357 358 359
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
360
	Change as necessary to match prototype in unexec.h.
361

362 363
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
364
	(back_comment, skip_chars): Mark vars as initialized.
365

366 367 368
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

369
	* lread.c (read1): Rewrite so as not to use empty "else".
370
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
371

372 373
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

374 375 376
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

377 378
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
379
	(font_sort_entities): Mark var as initialized.
380

381 382
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

383 384
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
385
	(font_parse_fcname): Remove unused vars.
386
	(font_delete_unmatched): Now static.
387
	(font_get_spec): Remove; unused.
388 389 390
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
391

392
	* fns.c (require_nesting_list, require_unwind): Now static.
393
	(Ffillarray): Rename locals to avoid shadowing.
394

395
	* floatfns.c (domain_error2): Define only if needed.
396
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
397

398 399 400
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

401
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
402
	(Fdefvar): Rewrite so as not to use empty "else".
403 404
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
405
	(Fdefvar): Rename locals to avoid shadowing.
406

407
	* callint.c (quotify_arg, quotify_args): Now static.
408
	(Fcall_interactively): Rename locals to avoid shadowing.
409
	Use const pointer when appropriate.
410

411 412 413 414
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
415 416 417
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
418 419 420
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
421
	(Ftranslate_region_internal): Mark var as initialized.
422

423 424 425
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

426 427 428
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

429 430
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
431
	(default_value, arithcompare, arith_driver, arith_error): Now static.
432
	(store_symval_forwarding): Rename local to avoid shadowing.
433 434
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
435
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
436

437
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
438 439
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
440 441
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
442 443 444 445 446
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
447
	(Fmemory_limit): Cast sbrk's returned value to char *.
448

449 450 451
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

452 453
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

454 455 456 457 458 459 460 461
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
462
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
463
	the race-condition problem in the old DOWNCASE.
464

465 466 467
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
468 469
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
470 471
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
472
	(regex_compile, re_match_2_internal): Mark locals as initialized.
473 474 475 476 477 478 479
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
480

481
	* search.c (boyer_moore): Rename locals to avoid shadowing.
482 483
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
484

485 486
	* search.c (simple_search): Remove unused var.

487 488 489 490
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

491 492
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

493 494 495 496
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
497
	(Fvertical_motion): Mark locals as initialized.
498

499
	* casefiddle.c (casify_object, casify_region): Now static.
500
	(casify_region): Mark local as initialized.
501

502 503
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

504 505 506 507 508 509 510 511 512
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
513 514 515
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

537 538
	* dired.c (directory_files_internal_unwind): Now static.

539 540 541
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
542 543 544
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
545
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
546 547
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
548 549
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
550

551
	* minibuf.c (choose_minibuf_frame_1): Now static.
552 553
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
554

555 556
	* marker.c (bytepos_to_charpos): Remove; unused.

557 558 559
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

560 561
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
562
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
563
	(copy_text): Remove unused local var.
564

565
	* filelock.c (within_one_second): Now static.
566
	(lock_file_1): Rename local to avoid shadowing.
567

568 569 570 571
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
572
	(switch_to_buffer_1): Now static.
573 574
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
575

576
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
577
	Fix pointer signedness issue.
578 579
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
580
	(MAXPATHLEN): Define only if needed.
581

582 583 584
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

585 586 587
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

588
	* sysdep.c (reset_io): Now static.
589
	(wait_for_termination_signal): Remove; unused.
590

591 592 593
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
594
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
595
	(DENSE_TABLE_SIZE): Remove; unused.
596 597 598
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
599

600 601 602
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
603 604 605 606 607
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
608
	(read_key_sequence, read_char): Mark locals as initialized.
609
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
610

611
	* keyboard.h (make_ctrl_char): New decl.
612 613
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
614

615 616
	* lisp.h (force_auto_save_soon): New decl.

617
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
618 619 620
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
621 622
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
623

624 625
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

626 627 628 629 630 631 632
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

633 634
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
635
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
636

637 638
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

639 640 641
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

642 643
	* print.c (print_preprocess): Don't forget font objects.

644 645 646 647
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

648 649 650 651 652
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

653 654 655 656 657 658 659 660
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
661
	(run_protected): Add extern declaration for waiting_for_input.
662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

678 679
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
680
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
681

682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

704 705 706 707 708
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

709 710
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
711 712
	Fix more problems found by GCC 4.5.2's static checks.

713 714
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
715 716
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
717 718
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
719 720 721 722 723
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
724 725 726
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
727

728 729
	* xgselect.c (xg_select): Remove unused var.

730 731 732
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
733
	(my_png_error, my_error_exit): Mark with NO_RETURN.
734

735
	* image.c (clear_image_cache): Now static.
736
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
737
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
738 739
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
740
	(gif_load): Fix pointer signedness.
741 742
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
743

Paul Eggert's avatar
Paul Eggert committed
744 745
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

746 747 748 749 750 751
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
752 753 754 755 756 757 758 759 760 761 762 763
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
764 765
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
766

767 768 769 770
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

771 772 773 774 775
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

776
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
777

778 779
	* fringe.c (update_window_fringes): Remove unused variables.

780 781 782
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

783 784
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
785
	* termcap.c [MSDOS]: Include "msdos.h".
786 787 788 789
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

790
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
791

792 793 794 795 796
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

797 798 799 800
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

801 802 803 804 805 806 807 808 809 810 811 812
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

813
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
814

815
	Fix some minor problems found by GCC 4.5.2's static checks.
816

817 818 819
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
820

821 822 823 824 825
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

826
	* fontset.c (free_realized_fontset): Now static.
827
	(Fset_fontset_font): Rename local to avoid shadowing.
828
	(fontset_font): Mark local as initialized.
829
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
830

831 832
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

833
	* xselect.c (x_disown_buffer_selections): Remove; not used.
834
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
835 836 837
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
838

839 840 841
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
842 843 844 845
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
846
	(Fx_create_frame): Add braces to silence GCC warning.
847
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
848 849
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
850 851 852 853
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
854

855 856
	* xterm.h (x_mouse_leave): New decl.

857 858
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
859 860
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
861
	(XTread_socket): Don't define label "out" unless it's used.
862
	Don't declare local "event" unless it's used.
863 864
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
865 866
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
867 868 869 870 871
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
872
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
873
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
874

875 876
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
877
	(tty_defined_color, merge_face_heights): Now static.
878
	(free_realized_faces_for_fontset): Remove; not used.
879 880
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
881 882
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
883

884
	* terminal.c (store_terminal_param): Now static.
885

886
	* xmenu.c (menu_highlight_callback): Now static.
887
	(set_frame_menubar): Remove unused local.
888
	(xmenu_show): Rename parameter to avoid shadowing.
889 890
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
891 892
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
893

894
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
895
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
896 897
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
898
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
899 900
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
901

Paul Eggert's avatar
Paul Eggert committed
902 903
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

904
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
905 906
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
907

908
	* window.c (display_buffer): Now static.
909 910
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
911 912
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
913
	* dispextern.h (bidi_dump_cached_states): Likewise.
914

915 916 917
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
918 919 920
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
921 922
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
923
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
924

925 926 927
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
928 929 930 931 932 933 934 935 936
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
937 938
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
939
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
940
	(decode_coding_object, encode_coding_object, detect_coding_system):
941 942
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
943 944
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
945
	this initialization is needed.  (Bug#8211)
946 947 948 949 950
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
951

952
	* category.c (hash_get_category_set): Remove unused local var.
953
	(copy_category_table): Now static, since it's not used elsewhere.
954
	* character.c (string_count_byte8): Likewise.
955

956 957 958
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

959 960
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
961 962
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
963
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
964

965
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
966
	(BIDI_BOB): Remove unused macro.
967

968 969
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
970
	* term.c (encode_terminal_code): Likewise.
971

972
	* term.c (encode_terminal_code): Now static.  Remove unused local.
973

Paul Eggert's avatar
Paul Eggert committed
974 975 976 977 978 979 980 981 982 983 984
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

985 986 987 988 989 990 991 992 993
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

994 995
	* term.c (term_mouse_position): Rename local to avoid shadowing.

996 997 998
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

999 1000 1001 1002
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

1003 1004 1005 1006 1007 1008
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043