ChangeLog 1.11 MB
Newer Older
1 2 3 4 5 6
2011-04-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't try to determine the character
	position of the scroll margin if the window start point w->startp
	is outside the buffer's accessible region.

7 8 9 10 11
2011-03-30  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (syms_of_xdisp) <scroll-conservatively>: Document the
	threshold of 100 lines for never-recentering scrolling.

12 13 14 15 16 17
2011-03-29  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): When scrolling down aggressively,
	scroll one screen line less, to make sure we end up at the margin
	for fractions close to 1.

18 19 20 21 22 23 24 25 26
2011-03-28  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): When point is above the window, allow
	searching as far as scroll_max, or one screenful, to compute
	vertical distance from PT to the scroll margin position.  This
	prevents try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.

27 28 29 30 31 32 33
2011-03-27  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_scrolling): Clean up the case of PT below the
	margin at bottom of window: scroll_max can no longer be INT_MAX.
	(redisplay_window): Find character position of margin and use
	that, rather than adding margin to PT.

34 35 36 37
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)
38
	(try_scrolling): Limit scrolling to 100 screen lines.
39 40 41 42 43
	(SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)
44 45 46
	(try_scrolling): When aggressive scrolling is in use, don't let
	point enter the opposite scroll margin as result of the scroll.
	(redisplay_window): Fix operator precedence in condition.
47

48 49
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

50 51 52 53 54 55 56
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

78 79 80 81 82
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

83 84 85 86 87 88 89 90
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

122 123 124 125 126
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

149 150 151 152 153 154 155 156 157 158 159 160 161 162 163
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
164
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
165 166
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
167
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
168

169 170
	Fix more problems found by GCC 4.5.2's static checks.

171 172 173 174
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

175 176 177
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
178
	of objects (Bug#8318).
179

180 181 182
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

183 184 185 186
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
187 188
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
189

190 191 192
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

193 194
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
195 196
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
197

Paul Eggert's avatar
Paul Eggert committed
198 199
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
200

Paul Eggert's avatar
Paul Eggert committed
201
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
202

203 204 205
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
206
	socklen_t is wider than int (Bug#8277).
207 208 209 210
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

211 212 213 214
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
215
	(Fmake_network_process): Define label "retry_connect" only if needed.
216
	(Fnetwork_interface_info): Fix pointer signedness.
217
	(process_send_signal): Add cast to avoid pointer signedness problem.
218
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
219
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
220

221 222 223 224 225 226 227 228 229 230 231 232
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

233
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
234
	(xftfont_open): Rename locals to avoid shadowing.
235

236
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
237 238
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
239
	(ftfont_list): Remove unused local.
240 241 242
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
243

244 245
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
246 247
	* xml.c (make_dom): Now static.

248 249
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
250 251
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
252
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
253 254
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
255

256 257 258 259 260 261 262
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

263 264
	* textprop.c (property_change_between_p): Remove; unused.

265 266
	* intervals.c (interval_start_pos): Now static.

267 268
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

269 270 271
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

272 273
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
274
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
275 276
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
277

278 279
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

280 281
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
282 283
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
284 285
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
286

287 288 289 290
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

291
	* callproc.c (call_process_cleanup): Now static.
292
	(relocate_fd): Rename locals to avoid shadowing.
293

294 295 296 297 298
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

299 300 301 302
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

303 304 305 306 307 308
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

309 310 311 312 313 314
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

315 316 317 318 319
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

320 321 322 323
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

324 325 326 327
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

328 329
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

330 331
	Fix more problems found by GCC 4.5.2's static checks.

332 333 334
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

335 336 337 338 339 340 341
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

342 343 344
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

345
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
346 347 348
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
349

350 351
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
352 353
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
354
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
355

356 357
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
358
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
359
	* unexec.h: New file.
360 361 362 363 364 365
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
366
	Change as necessary to match prototype in unexec.h.
367

368 369
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
370
	(back_comment, skip_chars): Mark vars as initialized.
371

372 373 374
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

375
	* lread.c (read1): Rewrite so as not to use empty "else".
376
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
377

378 379
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

380 381 382
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

383 384
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
385
	(font_sort_entities): Mark var as initialized.
386

387 388
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

389 390
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
391
	(font_parse_fcname): Remove unused vars.
392
	(font_delete_unmatched): Now static.
393
	(font_get_spec): Remove; unused.
394 395 396
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
397

398
	* fns.c (require_nesting_list, require_unwind): Now static.
399
	(Ffillarray): Rename locals to avoid shadowing.
400

401
	* floatfns.c (domain_error2): Define only if needed.
402
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
403

404 405 406
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

407
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
408
	(Fdefvar): Rewrite so as not to use empty "else".
409 410
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
411
	(Fdefvar): Rename locals to avoid shadowing.
412

413
	* callint.c (quotify_arg, quotify_args): Now static.
414
	(Fcall_interactively): Rename locals to avoid shadowing.
415
	Use const pointer when appropriate.
416

417 418 419 420
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
421 422 423
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
424 425 426
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
427
	(Ftranslate_region_internal): Mark var as initialized.
428

429 430 431
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

432 433 434
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

435 436
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
437
	(default_value, arithcompare, arith_driver, arith_error): Now static.
438
	(store_symval_forwarding): Rename local to avoid shadowing.
439 440
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
441
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
442

443
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
444 445
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
446 447
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
448 449 450 451 452
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
453
	(Fmemory_limit): Cast sbrk's returned value to char *.
454

455 456 457
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

458 459
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

460 461 462 463 464 465 466 467
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
468
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
469
	the race-condition problem in the old DOWNCASE.
470

471 472 473
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
474 475
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
476 477
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
478
	(regex_compile, re_match_2_internal): Mark locals as initialized.
479 480 481 482 483 484 485
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
486

487
	* search.c (boyer_moore): Rename locals to avoid shadowing.
488 489
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
490

491 492
	* search.c (simple_search): Remove unused var.

493 494 495 496
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

497 498
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

499 500 501 502
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
503
	(Fvertical_motion): Mark locals as initialized.
504

505
	* casefiddle.c (casify_object, casify_region): Now static.
506
	(casify_region): Mark local as initialized.
507

508 509
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

510 511 512 513 514 515 516 517 518
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
519 520 521
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

543 544
	* dired.c (directory_files_internal_unwind): Now static.

545 546 547
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
548 549 550
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
551
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
552 553
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
554 555
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
556

557
	* minibuf.c (choose_minibuf_frame_1): Now static.
558 559
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
560

561 562
	* marker.c (bytepos_to_charpos): Remove; unused.

563 564 565
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

566 567
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
568
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
569
	(copy_text): Remove unused local var.
570

571
	* filelock.c (within_one_second): Now static.
572
	(lock_file_1): Rename local to avoid shadowing.
573

574 575 576 577
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
578
	(switch_to_buffer_1): Now static.
579 580
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
581

582
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
583
	Fix pointer signedness issue.
584 585
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
586
	(MAXPATHLEN): Define only if needed.
587

588 589 590
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

591 592 593
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

594
	* sysdep.c (reset_io): Now static.
595
	(wait_for_termination_signal): Remove; unused.
596

597 598 599
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
600
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
601
	(DENSE_TABLE_SIZE): Remove; unused.
602 603 604
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
605

606 607 608
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
609 610 611 612 613
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
614
	(read_key_sequence, read_char): Mark locals as initialized.
615
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
616

617
	* keyboard.h (make_ctrl_char): New decl.
618 619
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
620

621 622
	* lisp.h (force_auto_save_soon): New decl.

623
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
624 625 626
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
627 628
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
629

630 631
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

632 633 634 635 636 637 638
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

639 640
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
641
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
642

643 644
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

645 646 647
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

648 649
	* print.c (print_preprocess): Don't forget font objects.

650 651 652 653
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

654 655 656 657 658
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

659 660 661 662 663 664 665 666
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
667
	(run_protected): Add extern declaration for waiting_for_input.
668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

684 685
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
686
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
687

688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

710 711 712 713 714
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

715 716
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
717 718
	Fix more problems found by GCC 4.5.2's static checks.

719 720
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
721 722
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
723 724
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
725 726 727 728 729
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
730 731 732
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
733

734 735
	* xgselect.c (xg_select): Remove unused var.

736 737 738
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
739
	(my_png_error, my_error_exit): Mark with NO_RETURN.
740

741
	* image.c (clear_image_cache): Now static.
742
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
743
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
744 745
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
746
	(gif_load): Fix pointer signedness.
747 748
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
749

Paul Eggert's avatar
Paul Eggert committed
750 751
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

752 753 754 755 756 757
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
758 759 760 761 762 763 764 765 766 767 768 769
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
770 771
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
772

773 774 775 776
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

777 778 779 780 781
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

782
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
783

784 785
	* fringe.c (update_window_fringes): Remove unused variables.

786 787 788
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

789 790
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
791
	* termcap.c [MSDOS]: Include "msdos.h".
792 793 794 795
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

796
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
797

798 799 800 801 802
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

803 804 805 806
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

807 808 809 810 811 812 813 814 815 816 817 818
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

819
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
820

821
	Fix some minor problems found by GCC 4.5.2's static checks.
822

823 824 825
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
826

827 828 829 830 831
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

832
	* fontset.c (free_realized_fontset): Now static.
833
	(Fset_fontset_font): Rename local to avoid shadowing.
834
	(fontset_font): Mark local as initialized.
835
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
836

837 838
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

839
	* xselect.c (x_disown_buffer_selections): Remove; not used.
840
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
841 842 843
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
844

845 846 847
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
848 849 850 851
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
852
	(Fx_create_frame): Add braces to silence GCC warning.
853
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
854 855
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
856 857 858 859
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
860

861 862
	* xterm.h (x_mouse_leave): New decl.

863 864
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
865 866
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
867
	(XTread_socket): Don't define label "out" unless it's used.
868
	Don't declare local "event" unless it's used.
869 870
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
871 872
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
873 874 875 876 877
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
878
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
879
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
880

881 882
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
883
	(tty_defined_color, merge_face_heights): Now static.
884
	(free_realized_faces_for_fontset): Remove; not used.
885 886
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
887 888
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
889

890
	* terminal.c (store_terminal_param): Now static.
891

892
	* xmenu.c (menu_highlight_callback): Now static.
893
	(set_frame_menubar): Remove unused local.
894
	(xmenu_show): Rename parameter to avoid shadowing.
895 896
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
897 898
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
899

900
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
901
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
902 903
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
904
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
905 906
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
907

Paul Eggert's avatar
Paul Eggert committed
908 909
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

910
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
911 912
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
913

914
	* window.c (display_buffer): Now static.
915 916
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
917 918
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
919
	* dispextern.h (bidi_dump_cached_states): Likewise.
920

921 922 923
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
924 925 926
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
927 928
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
929
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
930

931 932 933
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
934 935 936 937 938 939 940 941 942
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
943 944
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
945
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
946
	(decode_coding_object, encode_coding_object, detect_coding_system):
947 948
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
949 950
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
951
	this initialization is needed.  (Bug#8211)
952 953 954 955 956
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
957

958
	* category.c (hash_get_category_set): Remove unused local var.
959
	(copy_category_table): Now static, since it's not used elsewhere.
960
	* character.c (string_count_byte8): Likewise.
961

962 963 964
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

965 966
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
967 968
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
969
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
970

971
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
972
	(BIDI_BOB): Remove unused macro.
973

974 975
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
976
	* term.c (encode_terminal_code): Likewise.
977

978
	* term.c (encode_terminal_code): Now static.  Remove unused local.
979

Paul Eggert's avatar
Paul Eggert committed
980 981 982 983 984 985 986 987 988 989 990
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

991 992 993 994 995 996 997 998 999
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

1000 1001
	* term.c (term_mouse_position): Rename local to avoid shadowing.

1002 1003 1004
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

1005 1006 1007 1008
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

1009 1010 1011 1012 1013 1014
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036