ChangeLog 263 KB
Newer Older
1 2
2011-07-29  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.

5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
	* xselect.c: Integer and memory overflow issues.
	(X_LONG_SIZE, X_USHRT_MAX, X_ULONG_MAX): New macros.
	Use them to make the following changes clearer.
	(MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
	This change doesn't affect the value now, but it may help remind
	future maintainers not to raise the value too much later.
	(SELECTION_QUANTUM): Remove, replacing with ...
	(selection_quantum): ... new function, which avoids overflow.
	All uses changed.
	(struct selection_data.size): Now ptrdiff_t, not int, to avoid
	assumption that selection length fits in 'int'.
	(x_reply_selection_request, x_handle_selection_request)
	(x_get_window_property, receive_incremental_selection)
	(x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
	(lisp_data_to_selection_data, clean_local_selection_data):
	Use ptrdiff_t, not int, to record length of selection.
	(x_reply_selection_request, x_get_window_property)
	(receive_incremental_selection, x_property_data_to_lisp):
	Redo calculations to avoid overflow.
	(x_reply_selection_request): When sending hint, ceiling it at
	X_ULONG_MAX rather than relying on wraparound overflow to send
	something.
	(x_get_window_property, receive_incremental_selection)
	(lisp_data_to_selection_data, x_property_data_to_lisp):
	Check for size-calculation overflow.
	(x_get_window_property, receive_incremental_selection)
	(lisp_data_to_selection_data, Fx_register_dnd_atom):
	Don't store size until memory allocation succeeds.
	(x_get_window_property): Plug memory leak on memory exhaustion.
	Don't double-block input; malloc is safe here.  Don't assume 2**34
	- 4 fits in unsigned long.  Add an xassert to check
	XGetWindowProperty overflow.  Be more careful about overflow
	calculations, and distinguish size from memory overflow better.
	(receive_incremental_selection): When tracing, don't assume
	unsigned int is less than INT_MAX.
	(x_selection_data_to_lisp_data): Remove unnecessary (and in theory
	harmful) conversions of unsigned short to int.
	(lisp_data_to_selection_data): Don't assume that integers
	in the range -65535 through -1 fit in an X unsigned short.
	Don't assume that ULONG_MAX == X_ULONG_MAX.  Don't store into
	result parameters unless successful.  Rely on cons_to_unsigned
	to report problems with elements; the old code wasn't right anyway.
	(x_check_property_data): Check for int overflow; we cannot use
	a wider type due to X limits.
	(x_handle_dnd_message): Use unsigned int, to avoid int overflow.

51 52 53 54 55
	* xrdb.c: Integer and memory overflow issues.
	(magic_file_p): Plug memory leak on size overflow.
	(get_environ_db): Don't assume path length fits in int,
	as sprintf is limited to int lengths.

56 57 58
	* xgselect.c (xg_select): Check for size calculation overflow.
	Don't update size until alloc done.

59 60 61 62 63
	* xfns.c: Integer and memory overflow fixes.
	(x_encode_text, x_set_name_internal, Fx_change_window_property):
	Use ptrdiff_t, not int, to count sizes, since they can exceed
	INT_MAX in size.  Check for size calculation overflow.

64 65 66 67 68
	* xfaces.c: Integer and memory overflow fixes.
	(Finternal_make_lisp_face): Use ptrdiff_t, not int, for sizes.
	Check for size calculation overflow.
	(cache_face): Do not overflow in size calculation.

69 70 71 72 73
	* xdisp.c: Integer and memory overflow fixes.
	(store_mode_line_noprop_char, x_consider_frame_title):
	Use ptrdiff_t, not int, for sizes.
	(store_mode_line_noprop_char): Don't update size until alloc done.

74 75 76 77 78 79
	* tparam.c: Integer and memory overflow fixes.
	(tparam1): Use ptrdiff_t, not int, for sizes.
	Don't update size until alloc done.
	Redo size calculations to avoid overflow.
	Check for size calculation overflow.

80 81 82 83 84 85
	* termcap.c: Integer and memory overflow issues.
	(tgetent): Use ptrdiff_t, not int, to record results of
	subtracting pointers.
	(gobble_line): Check for overflow more carefully.  Don't update size
	until alloc done.

86 87 88 89 90 91 92 93 94 95 96
	* term.c: Integer and memory overflow issues.
	(max_frame_lines): Remove; unused.
	(encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
	not int.
	(encode_terminal_code, calculate_costs): Check for size
	calculation overflow.
	(encode_terminal_code): Use ptrdiff_t, not int, to record glyph
	table lengths and related sizes.  Don't update size until alloc
	done.  Redo calculations to avoid overflow.
	(calculate_costs): Don't bother calling xmalloc when xrealloc will do.

97 98 99 100 101
	* sysdep.c: Integer and memory overflow issues.
	(system_process_attributes): Use ptrdiff_t, not int, for command
	line length.  Do not attempt to address one before the beginning
	of an array, as that's not portable.

102 103 104 105
	* search.c: Integer and memory overflow fixes.
	(Freplace_match): Check for size calculation overflow.
	(Fset_match_data): Don't assume list lengths fit in 'int'.

106 107 108 109
	* scroll.c: Integer and memory overflow fixes.
	(do_line_insertion_deletion_costs): Check for size calculation overflow.
	Don't bother calling xmalloc when xrealloc will do.

110 111
	* region-cache.c (move_cache_gap): Check for size calculation overflow.

112 113 114
	* process.c (Fnetwork_interface_list): Check for overflow
	in size calculation.

115 116 117 118 119
	* nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
	Now ptrdiff_t, not int.
	* nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
	(ns_draw_fringe_bitmap): Rewrite to avoid overflow.

120 121 122
	* minibuf.c (read_minibuf_noninteractive): Don't leak memory
	on memory overflow.

123 124 125 126
	* macros.c: Integer and memory overflow fixes.
	(Fstart_kbd_macro): Don't update size until alloc done.
	(store_kbd_macro_char): Reorder multiplicands to avoid overflow.

127 128
	* lread.c (read1, init_obarray): Don't update size until alloc done.

129 130 131 132 133
	* keymap.c: Integer overflow fixes.
	(cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
	(current_minor_maps): Check for size calculation overflow.
	* keymap.h: Change prototypes to match the above.

134 135 136 137 138 139 140 141 142
	* keyboard.c: Integer and memory overflow fixes.
	(read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
	(read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
	(follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
	(read_char_minibuf_menu_prompt): Check for overflow in size
	calculations.  Don't update size until allocation succeeds.  Redo
	calculations to avoid overflow.
	* keyboard.h: Change prototypes to match the above.

143 144 145 146 147 148 149 150 151 152 153 154 155
	* image.c: Integer and memory overflow fixes.
	(RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
	now that they've been promoted to lisp.h.
	(x_allocate_bitmap_record, x_alloc_image_color)
	(make_image_cache, cache_image, xpm_load):
	Don't update size until alloc is done.
	(xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
	(x_detect_edges):
	Check for size calculation overflow.
	(ct_colors_allocated_max): New constant.
	(x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
	overflow.

Paul Eggert's avatar
Paul Eggert committed
156 157
2011-07-28  Paul Eggert  <eggert@cs.ucla.edu>

158 159 160 161 162 163 164 165 166 167 168 169 170
	* gtkutil.c: Integer overflow fixes.
	(get_utf8_string, xg_store_widget_in_map):
	Check for size-calculation overflow.
	(get_utf8_string): Use ptrdiff_t, not size_t, where either will
	do, as we prefer signed integers.
	(id_to_widget.max_size, id_to_widget.used)
	(xg_store_widget_in_map, xg_remove_widget_from_map)
	(xg_get_widget_from_map, xg_get_scroll_id_for_window)
	(xg_remove_scroll_bar, xg_update_scrollbar_pos):
	Use and return ptrdiff_t, not int.
	(xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
	* gtkutil.h: Change prototypes to match the above.

171 172 173 174
	* ftfont.c: Check for size overflow.
	(ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
	Check for integer overflow in size calculations.

175 176
	* fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.

177 178 179 180
	* frame.h (struct frame): Use int, not EMACS_INT, where int works.
	This is for the members text_lines, text_cols, total_lines, total_cols,
	where the system imposes an 'int' limit.

181 182 183 184 185
	* frame.c: Integer overflow fixes.
	(set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
	(x_figure_window_size): Check for integer overflow.
	(x_set_alpha): Do not assume XINT fits in int.

186 187 188 189
	* eval.c: Integer and memory overflow fixes.
	(init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
	(call_debugger, grow_specpdl): Redo calculations to avoid overflow.

190 191
	* emacs.c (main, sort_args): Check for size-calculation overflow.

192 193 194 195 196 197 198
	* editfns.c: Integer and memory overflow fixes.
	(set_time_zone_rule): Don't assume environment length fits in int.
	(message_length): Now ptrdiff_t, not int.
	(Fmessage_box): Don't update size until allocation succeeds.
	Don't assume message length fits in int.
	(Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.

199 200 201 202 203 204 205 206
	* doc.c: Integer and memory overflow fixes.
	(get_doc_string_buffer_size): Now ptrdiff_t, not int.
	(get_doc_string): Check for size calculation overflow.
	Don't update size until allocation succeeds.
	(get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
	EMACS_INT, where ptrdiff_t will do.
	(Fsubstitute_command_keys): Check for string overflow.

207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
	Integer and memory overflow fixes for display code.
	* dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
	* dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
	Check for overflow in size calculations.
	(line_draw_cost, realloc_glyph_pool, add_row_entry):
	Don't assume glyph table len fits in int.
	(struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
	(row_table_size): Now ptrdiff_t, not int.
	(scrolling_window): Avoid overflow in size calculations.
	Don't update size until allocation succeeds.
	* fns.c (concat): Check for overflow in size calculations.
	(next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
	* lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
	(NEXT_ALMOST_PRIME_LIMIT): New constant.

222 223 224
	* composite.c: Integer overflow fixes.
	(get_composition_id): Check for overflow in glyph length calculations.

225 226 227 228 229
	* coding.c: Integer and memory overflow fixes.
	(produce_chars): Redo buffer-overflow calculations to avoid
	unnecessary integer overflow.  Check for size overflow.
	(encode_coding_object): Don't update size until xmalloc succeeds.

230 231
	* character.c (Fstring): Check for size-calculation overflow.

232 233 234 235 236
	* ccl.c: Integer and memory overflow fixes.
	(Fccl_execute_on_string): Check for memory overflow.
	Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
	Redo buffer-overflow calculations to avoid integer overflow.

237 238
	* callproc.c (child_setup): Don't assume strlen fits in int.

239 240 241 242 243
	* buffer.c: Memory overflow fixes.
	(overlays_at, overlays_in, record_overlay_string, overlay_strings):
	Don't update size of array until after memory allocation succeeds,
	because xmalloc/xrealloc may not return.

Paul Eggert's avatar
Paul Eggert committed
244 245 246 247 248
	* bidi.c: Integer overflow fix.
	(bidi_shelve_header_size): New constant.
	(bidi_cache_ensure_space, bidi_shelve_cache): Use it.
	(bidi_cache_ensure_space): Avoid integer overflow when allocating.

249 250
2011-07-19  Paul Eggert  <eggert@cs.ucla.edu>

251 252 253 254 255 256 257 258 259 260 261
	Use ptrdiff_t for composition IDs.
	* character.c (lisp_string_width):
	* composite.c (composition_table_size, n_compositions)
	(get_composition_id, composition_gstring_from_id):
	* dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
	* xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
	* window.c (Frecenter):
	Use ptrdiff_t, not int, for composition IDs.
	* composite.c (get_composition_id): Check for integer overflow.
	* composite.h: Adjust prototypes to match the above changes.

262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
	Use ptrdiff_t for hash table indexes.
	* category.c (hash_get_category_set):
	* ccl.c (ccl_driver):
	* charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
	* coding.c (coding_system_charset_list, detect_coding_system):
	* coding.h (struct coding_system.id):
	* composite.c (get_composition_id, gstring_lookup_cache):
	* fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
	* image.c (xpm_get_color_table_h):
	* lisp.h (hash_lookup, hash_put):
	* minibuf.c (Ftest_completion):
	Use ptrdiff_t for hash table indexes, not int (which is too
	narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
	32-bit --with-wide-int hosts).

277 278 279 280
	* charset.c (Fdefine_charset_internal): Check for integer overflow.
	Add a FIXME comment about memory leaks.
	(syms_of_charset): Don't assume xmalloc returns.

281 282 283 284 285 286 287 288 289 290
	Don't assume that stated character widths fit in int.
	* character.c (Fchar_width, c_string_width, lisp_string_width):
	* character.h (CHAR_WIDTH):
	* indent.c (MULTIBYTE_BYTES_WIDTH):
	Use sanitize_char_width to avoid undefined and/or bad behavior
	with outlandish widths.
	* character.h (sanitize_tab_width): Renamed from sanitize_width,
	now that we have two such functions.  All uses changed.
	(sanitize_char_width): New inline function.

291 292 293 294 295 296 297 298
	Don't assume that tab-width fits in int.
	* character.h (sanitize_width): New inline function.
	(SANE_TAB_WIDTH): New macro.
	(ASCII_CHAR_WIDTH): Use it.
	* indent.c (sane_tab_width): Remove.  All uses replaced by
	SANE_TAB_WIDTH (current_buffer).
	* xdisp.c (init_iterator): Use SANE_TAB_WIDTH.

299 300 301
	* fileio.c: Integer overflow issues with file modes.
	(Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.

302 303 304 305
	* charset.c (read_hex): New arg OVERFLOW.  All uses changed.
	Remove unreachable code.
	(read_hex, load_charset_map_from_file): Check for integer overflow.

306 307 308 309 310 311
	* xterm.c: don't go over XClientMessageEvent limit
	(scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
	(x_send_scroll_bar_event): Likewise.  Check that the size does not
	exceed limits imposed by XClientMessageEvent, as well as the usual
	ptrdiff_t and size_t limits.

312 313 314 315 316 317 318 319 320 321 322 323 324
	* keyboard.c: Overflow, signedness and related fixes.
	(make_lispy_movement): Use same integer type in forward decl
	that is used in the definition.
	(read_key_sequence, keyremap_step):
	Change bufsize argument back to int, undoing my 2011-03-30 change.
	We prefer signed types, and int is wide enough here.
	(parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
	than TYPE_MAXIMUM (EMACS_INT) / 2.  Don't let the label size grow
	larger than STRING_BYTES_BOUND.  Use ptrdiff_t for Emacs string
	length, not size_t.  Use ptrdiff_t for index, not int.
	(keyremap_step, read_key_sequence): Redo bufsize check to avoid
	possibility of integer overflow.

325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
	Overflow, signedness and related fixes for images.

	* dispextern.h (struct it.stack[0].u.image.image_id)
	(struct_it.image_id, struct image.id, struct image_cache.size)
	(struct image_cache.used, struct image_cache.ref_count):
	* gtkutil.c (update_frame_tool_bar):
	* image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
	(Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
	(cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
	* nsmenu.m (update_frame_tool_bar):
	* xdisp.c (calc_pixel_width_or_height):
	* xfns.c (image_cache_refcount):
	Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
	on typical 64-bit hosts.

	* image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
	(x_bitmap_pixmap, x_create_x_image_and_pixmap):
	Omit unnecessary casts to int.
	(parse_image_spec): Check that integers fall into 'int' range
	when the callers expect that.
	(image_ascent): Redo ascent calculation to avoid int overflow.
	(clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
	(lookup_image): Remove unnecessary tests.
	(xbm_image_p): Locals are now of int, not EMACS_INT,
	since parse_image_check makes sure they fit into int.
	(png_load, gif_load, svg_load_image):
	Prefer int to unsigned where either will do.
	(tiff_handler): New function, combining the cores of the
	old tiff_error_handler and tiff_warning_handler.  This
	function is rewritten to use vsnprintf and thereby avoid
	stack buffer overflows.  It uses only the features of vsnprintf
	that are common to both POSIX and native Microsoft.
	(tiff_error_handler, tiff_warning_handler): Use it.
	(tiff_load, gif_load, imagemagick_load_image):
	Don't assume :index value fits in 'int'.
	(gif_load): Omit unnecessary cast to double, and avoid double-rounding.
	(imagemagick_load_image): Check that crop parameters fit into
	the integer types that MagickCropImage accepts.  Don't assume
	Vimagemagick_render_type has a nonnegative value.  Don't assume
	size_t fits in 'long'.
	(gs_load): Use printmax_t to print the widest integers possible.
	Check for integer overflow when computing image height and width.

Paul Eggert's avatar
Paul Eggert committed
368
2011-07-19  Paul Eggert  <eggert@cs.ucla.edu>
369

Paul Eggert's avatar
Paul Eggert committed
370
	Integer signedness and overflow and related fixes.  (Bug#9079)
Paul Eggert's avatar
Paul Eggert committed
371

372 373 374 375 376 377 378 379 380 381 382 383 384
	* bidi.c: Integer size and overflow fixes.
	(bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
	(bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
	(bidi_cache_find_level_change, bidi_cache_ensure_space)
	(bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
	(bidi_find_other_level_edge):
	Use ptrdiff_t instead of EMACS_INT where either will do.
	This works better on 32-bit hosts configured --with-wide-int.
	(bidi_cache_ensure_space): Check for size-calculation overflow.
	Use % rather than repeated addition, for better worst-case speed.
	Don't set bidi_cache_size until after xrealloc returns, because it
	might not return.
	(bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
385 386 387
	(bidi_cache_ensure_space): Also check that the bidi cache size
	does not exceed that of the largest Lisp string or buffer.  See Eli
	Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
388

389 390 391 392
	* alloc.c (__malloc_size_t): Remove.
	All uses replaced by size_t.  See Andreas Schwab's note
	<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.

393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411
	* image.c: Improve checking for integer overflow.
	(check_image_size): Assume that f is nonnull, since
	it is always nonnull in practice.  This is one less thing to
	worry about when checking for integer overflow later.
	(x_check_image_size): New function, which checks for integer
	overflow issues inside X.
	(x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
	This removes the need for a memory_full check.
	(xbm_image_p): Rewrite to avoid integer multiplication overflow.
	(Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
	(xbm_read_bitmap_data): Change locals back to 'int', since
	their values must fit in 'int'.
	(xpm_load_image, png_load, tiff_load):
	Invoke x_create_x_image_and_pixmap earlier,
	to avoid much needless work if the image is too large.
	(tiff_load): Treat overly large images as if
	x_create_x_image_and_pixmap failed, not as malloc failures.
	(gs_load): Use x_check_image_size.

Paul Eggert's avatar
Paul Eggert committed
412 413 414 415
	* gtkutil.c: Omit integer casts.
	(xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
	(xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.

416 417
	* image.c (png_load): Don't assume height * row_bytes fits in 'int'.

418 419 420 421
	* xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
	Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
	would wrongly return t on a 64-bit host.

422 423 424 425 426
	* dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
	The plain *_OVERFLOW macros run afoul of GCC bug 49705
	<http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
	and therefore cause GCC to emit a bogus diagnostic in some cases.

427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
	* image.c: Integer signedness and overflow and related fixes.
	This is not an exhaustive set of fixes, but it's time to
	record what I've got.
	(lookup_pixel_color, check_image_size): Remove redundant decls.
	(check_image_size): Don't assume that arbitrary EMACS_INT values
	fit in 'int', or that arbitrary 'double' values fit in 'int'.
	(x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
	(tiff_load, imagemagick_load_image):
	Check for overflow in size calculations.
	(x_create_x_image_and_pixmap): Remove unnecessary test for
	xmalloc returning NULL; that can't happen.
	(xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
	(xpm_color_bucket): Use better integer hashing function.
	(xpm_cache_color): Don't possibly over-allocate memory.
	(struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
	(gif_memory_source):
	Use ptrdiff_t, not int or size_t, to record sizes.
	(png_load): Don't assume values greater than 2**31 fit in 'int'.
	(our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
	either works, as we prefer signed integers.
	(tiff_read_from_memory, tiff_write_from_memory):
	Return tsize_t, not size_t, since that's what the TIFF API wants.
	(tiff_read_from_memory): Don't fail simply because the read would
	go past EOF; instead, return a short read.
	(tiff_load): Omit no-longer-needed casts.
	(Fimagemagick_types): Don't assume size fits into 'int'.

454 455 456 457 458 459 460 461 462 463
	Improve hashing quality when configured --with-wide-int.
	* fns.c (hash_string): New function, taken from sxhash_string.
	Do not discard information about ASCII character case; this
	discarding is no longer needed.
	(sxhash-string): Use it.  Change sig to match it.  Caller changed.
	* lisp.h: Declare it.
	* lread.c (hash_string): Remove, since we now use fns.c's version.
	The fns.c version returns a wider integer if --with-wide-int is
	specified, so this should help the quality of the hashing a bit.

464 465 466 467 468
	* emacs.c: Integer overflow minor fix.
	(heap_bss_diff): Now uprintmax_t, not unsigned long.  All used changed.
	Define only if GNU_LINUX.
	(main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.

469 470 471 472 473 474 475 476 477 478 479 480 481
	* dispnew.c: Integer signedness and overflow fixes.
	Remove unnecessary forward decls, that were a maintenance hassle.
	(history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
	All uses changed.
	(adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
	(scrolling_window): Use ptrdiff_t, not int, for byte count.
	(prepare_desired_row, line_draw_cost):
	Use int, not unsigned, where either works.
	(save_current_matrix, restore_current_matrix):
	Use ptrdiff_t, not size_t, where either works.
	(init_display): Check for overflow more accurately, and without
	relying on undefined behavior.

482 483 484 485 486 487 488 489 490 491
	* editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
	Remove, replacing with the new symbols in lisp.h.  All uses changed.
	* fileio.c (make_temp_name):
	* filelock.c (lock_file_1, lock_file):
	* xdisp.c (message_dolog):
	Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
	Use pMd etc. instead.
	* lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
	replacing the pWIDE etc. symbols removed from editfns.c.

492 493 494 495
	* keyboard.h (num_input_events): Now uintmax_t.
	This is (very slightly) less likely to mess up due to wraparound.
	All uses changed.

496 497 498 499 500
	* buffer.c: Integer signedness fixes.
	(alloc_buffer_text, enlarge_buffer_text):
	Use ptrdiff_t rather than size_t when either will do, as we prefer
	signed integers.

501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
	* alloc.c: Integer signedness and overflow fixes.
	Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
	(__malloc_size_t): Default to size_t, not to int.
	(pure_size, pure_bytes_used_before_overflow, stack_copy_size)
	(Fgarbage_collect, mark_object_loop_halt, mark_object):
	Prefer ptrdiff_t to size_t when either would do, as we prefer
	signed integers.
	(XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
	(xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
	Now const.  Initialize with values that are in range even if char
	is signed.
	(XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
	(xmalloc_put_size, xmalloc_get_size): New functions.  All uses changed.
	These functions do the right thing with sizes > 2**32.
	(check_depth): Now ptrdiff_t, not int.
	(overrun_check_malloc, overrun_check_realloc, overrun_check_free):
	Adjust to new way of storing sizes.  Check for size overflow bugs
	in rest of code.
	(STRING_BYTES_MAX): Adjust to new overheads.  The old code was
	slightly wrong anyway, as it missed one instance of
	XMALLOC_OVERRUN_CHECK_OVERHEAD.
	(refill_memory_reserve): Omit needless cast to size_t.
	(mark_object_loop_halt): Mark as externally visible.

525 526 527 528 529 530 531
	* xselect.c: Integer signedness and overflow fixes.
	(Fx_register_dnd_atom, x_handle_dnd_message):
	Use ptrdiff_t, not size_t, since we prefer signed.
	(Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
	* xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
	x_dnd_atoms_size and x_dnd_atoms_length.

532 533 534 535 536 537 538 539 540 541 542
	* doprnt.c: Prefer signed to unsigned when either works.
	* eval.c (verror):
	* doprnt.c (doprnt):
	* lisp.h (doprnt):
	* xdisp.c (vmessage):
	Use ptrdiff_t, not size_t, when using or implementing doprnt,
	since the sizes cannot exceed ptrdiff_t bounds anyway, and we
	prefer signed arithmetic to avoid comparison confusion.
	* doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
	but is a bit tricky.

543 544 545 546 547 548 549 550 551 552 553 554
	Assume freestanding C89 headers, string.h, stdlib.h.
	* data.c, doprnt.c, floatfns.c, print.c:
	Include float.h unconditionally.
	* gmalloc.c: Assume C89-at-least behavior for preprocessor,
	limits.h, stddef.h, string.h.  Use memset instead of 'flood'.
	* regex.c: Likewise for stddef.h, string.h.
	(ISASCII): Remove; can assume it returns 1 now.  All uses removed.
	* s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
	* s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
	(STDC_HEADERS): Remove obsolete defines.
	* sysdep.c: Include limits.h unconditionally.

Paul Eggert's avatar
Paul Eggert committed
555 556 557 558 559 560 561 562
	Assume support for memcmp, memcpy, memmove, memset.
	* lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
	* regex.c (memcmp, memcpy):
	Remove; we assume C89 now.

	* gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
	(__malloc_safe_bcopy): Remove; no longer needed.

Paul Eggert's avatar
Paul Eggert committed
563
	* lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
564 565 566
	Use EMACS_INT, not EMACS_UINT, for sizes.  The code works equally
	well either way, and we prefer signed to unsigned.

Paul Eggert's avatar
Paul Eggert committed
567 568 569 570 571 572 573 574 575 576 577 578 579
2011-07-19  Paul Eggert  <eggert@cs.ucla.edu>

	Port to OpenBSD.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
	and the surrounding thread.
	* minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
	rather than fgets, and retry after EINTR.  Otherwise, 'emacs
	--batch -f byte-compile-file' fails on OpenBSD if an inactivity
	timer goes off.
	* s/openbsd.h (BROKEN_SIGIO): Define.
	* unexelf.c (unexec) [__OpenBSD__]:
	Don't update the .mdebug section of the Alpha COFF symbol table.

580 581 582 583 584
2011-07-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* lread.c (syms_of_lread): Clarify when `lexical-binding' is used
	(bug#8460).

585 586
2011-07-18  Paul Eggert  <eggert@cs.ucla.edu>

587 588 589 590
	* fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
	This fixes some race conditions on the permissions of any newly
	created file.

591 592 593
	* alloc.c (valid_pointer_p): Use pipe, not open.
	This fixes some permissions issues when debugging.

594 595 596 597 598
	* fileio.c (Fcopy_file): Adjust mode if fchown fails.  (Bug#9002)
	If fchown fails to set both uid and gid, try to set just gid,
	as that is sometimes allowed.  Adjust the file's mode to eliminate
	setuid or setgid bits that are inappropriate if fchown fails.

599 600 601 602 603 604 605 606
2011-07-18  Stefan Monnier  <monnier@iro.umontreal.ca>

	* xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
	to compare Lisp_Objects.
	* gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
	global_gnutls_log_level, don't mistake it for a Lisp_Object.
	(init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.

607 608
2011-07-17  Andreas Schwab  <schwab@linux-m68k.org>

609 610 611
	* lread.c (read_integer): Unread even EOF character.
	(read1): Likewise.  Properly record start position of symbol.

612 613 614
	* lread.c (read1): Read `#:' as empty uninterned symbol if no
	symbol character follows.

615 616 617 618 619 620 621 622
2011-07-17  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Fcopy_file): Pacify gcc re fchown.  (Bug#9002)
	This works around a problem with the previous change to Fcopy_file.
	Recent glibc declares fchown with __attribute__((warn_unused_result)),
	and without this change, GCC might complain about discarding
	fchown's return value.

623 624 625 626
2011-07-16  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).

627 628 629 630
2011-07-16  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Fcopy_file): Don't diagnose fchown failures.  (Bug#9002)

631 632
2011-07-16  Lars Magne Ingebrigtsen  <larsi@gnus.org>

633 634 635
	* gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
	it's used from the C level.

636 637 638
	* process.c: Use the same condition for POLL_FOR_INPUT in both
	keyboard.c and process.c (bug#1858).

639 640 641 642 643
2011-07-09  Lawrence Mitchell  <wence@gmx.li>

	* gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
	(Fgnutls_boot): Use it.

644 645 646 647
2011-07-15  Andreas Schwab  <schwab@linux-m68k.org>

	* doc.c (Fsubstitute_command_keys): Revert last change.

648 649
2011-07-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

650 651 652 653
	* doc.c (Fsubstitute_command_keys): Clarify that \= really only
	quotes the next character, and doesn't affect other longer
	sequences (bug#8935).

654 655 656 657
	* lread.c (syms_of_lread): Clarify that is isn't only
	`eval-buffer' and `eval-defun' that's affected by
	`lexical-binding' (bug#8460).

658 659 660 661 662 663
2011-07-15  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (move_it_in_display_line_to): Fix vertical motion with
	bidi redisplay when a line includes both an image and is
	truncated.

664 665
2011-07-14  Paul Eggert  <eggert@cs.ucla.edu>

666 667 668 669 670 671 672
	Fix minor problems found by static checking.
	* bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
	(elsz): Now a signed constant, not a size_t var.  We prefer signed
	types to unsigned, to avoid integer comparison confusion.  Without
	this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
	"cannot optimize loop, the loop counter may overflow", a symptom
	of the confusion.
673
	* indent.c (Fvertical_motion): Mark locals as initialized.
674 675
	* xdisp.c (reseat_to_string): Fix pointer signedness issue.

676 677
2011-07-14  Lars Magne Ingebrigtsen  <larsi@gnus.org>

678 679 680
	* search.c (Fre_search_backward): Mention `case-fold-search' in
	all the re_search_* functions (bug#8138).

681 682 683
	* keyboard.c (Fopen_dribble_file): Document when the file is
	closed (bug#8056).

684 685
2011-07-14  Eli Zaretskii  <eliz@gnu.org>

686 687 688
	* bidi.c (bidi_dump_cached_states): Fix format of displaying
	bidi_cache_idx.

689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864
	Support bidi reordering of display and overlay strings.
	* xdisp.c (compute_display_string_pos)
	(compute_display_string_end): Accept additional argument STRING.
	(init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
	(reseat_to_string): Initialize bidi_it->string.s and
	bidi_it->string.schars.
	(Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
	NULL (avoids a crash in bidi_paragraph_init).  Initialize
	itb.string.lstring.
	(init_iterator): Call bidi_init_it only of a valid
	buffer position was specified.  Initialize paragraph_embedding to
	L2R.
	(reseat_to_string): Initialize the bidi iterator.
	(display_string): If we need to ignore text properties of
	LISP_STRING, set IT->stop_charpos to IT->end_charpos.  (The
	original value of -1 will not work with bidi.)
	(compute_display_string_pos): First arg is now struct
	`text_pos *'; all callers changed.  Support display properties on
	Lisp strings.
	(compute_display_string_end): Support display properties on Lisp
	strings.
	(init_iterator, reseat_1, reseat_to_string): Initialize the
	string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
	when iterating on a string not from display properties).
	(compute_display_string_pos, compute_display_string_end): Fix
	calculation of the object to scan.  Fixes an error when using
	arrow keys.
	(next_element_from_buffer): Don't abort when IT_CHARPOS is before
	base_level_stop; instead, set base_level_stop to BEGV.  Fixes
	crashes in vertical-motion.
	(next_element_from_buffer): Improve commentary for when
	the iterator is before prev_stop.
	(init_iterator): Initialize bidi_p from the default value of
	bidi-display-reordering, not from buffer-local value.  Use the
	buffer-local value only if initializing for buffer iteration.
	(handle_invisible_prop): Support invisible properties on strings
	that are being bidi-reordered.
	(set_iterator_to_next): Support bidi reordering of C strings and
	Lisp strings.
	(next_element_from_string): Support bidi reordering of Lisp
	strings.
	(handle_stop_backwards): Support Lisp strings as well.
	(display_string): Support display of R2L glyph rows.  Use
	IT_STRING_CHARPOS when displaying from a Lisp string.
	(init_iterator): Don't initialize it->bidi_p for strings
	here.
	(reseat_to_string): Initialize it->bidi_p for strings here.
	(next_element_from_string, next_element_from_c_string)
	(next_element_from_buffer): Add xassert's for correspondence
	between IT's object being iterated and it->bidi_it.string
	structure.
	(face_before_or_after_it_pos): Support bidi iteration.
	(next_element_from_c_string): Handle the case of the first string
	character that is not the first one in the visual order.
	(get_visually_first_element): New function, refactored from common
	parts of next_element_from_buffer, next_element_from_string, and
	next_element_from_c_string.
	(tool_bar_lines_needed, redisplay_tool_bar)
	(display_menu_bar): Force left-to-right direction.  Add a FIXME
	comment for making that be controlled by a user option.
	(push_it, pop_it): Save and restore the state of the
	bidi iterator.  Save and restore the bidi_p flag.
	(pop_it): Iterate out of display property for string iteration as
	well.
	(iterate_out_of_display_property): Support iteration over strings.
	(handle_single_display_spec): Set up it->bidi_it for iteration
	over a display string, and call bidi_init_it.
	(handle_single_display_spec, next_overlay_string)
	(get_overlay_strings_1, push_display_prop): Set up the bidi
	iterator for displaying display or overlay strings.
	(forward_to_next_line_start): Don't use the shortcut if
	bidi-iterating.
	(back_to_previous_visible_line_start): If handle_display_prop
	pushed the iterator stack, restore the internal state of the bidi
	iterator by calling bidi_pop_it same number of times.
	(reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
	and we are bidi-iterating, don't decrement the iterator position;
	instead, set the first_elt flag in the bidi iterator, to produce
	the same effect.
	(reseat_1): Remove redundant setting of string_from_display_prop_p.
	(push_display_prop): xassert that we are iterating a buffer.
	(push_it, pop_it): Save and restore paragraph_embedding member.
	(handle_single_display_spec, next_overlay_string)
	(get_overlay_strings_1, reseat_1, reseat_to_string)
	(push_display_prop): Set up the `unibyte' member of bidi_it.string
	correctly.  Don't assume unibyte strings are not bidi-reordered.
	(compute_display_string_pos)
	(compute_display_string_end): Fix handling the case of C string.
	(push_it, pop_it): Save and restore from_disp_prop_p.
	(handle_single_display_spec, push_display_prop): Set the
	from_disp_prop_p flag.
	(get_overlay_strings_1): Reset the from_disp_prop_p flag.
	(pop_it): Call iterate_out_of_display_property only if we are
	popping after iteration over a string that came from a display
	property.  Fix a typo in popping stretch info.  Add an assertion
	for verifying that the iterator position is in sync with the bidi
	iterator.
	(handle_single_display_spec, get_overlay_strings_1)
	(push_display_prop): Fix initialization of paragraph direction for
	string when that of the parent object is not yet determined.
	(reseat_1): Call bidi_init_it to resync the bidi
	iterator with IT's position.  (Bug#7616)
	(find_row_edges): If ROW->start.pos gives position
	smaller than min_pos, use it as ROW->minpos.  (Bug#7616)
	(handle_stop, back_to_previous_visible_line_start, reseat_1):
	Reset the from_disp_prop_p flag.
	(SAVE_IT, RESTORE_IT): New macros.
	(pos_visible_p, face_before_or_after_it_pos)
	(back_to_previous_visible_line_start)
	(move_it_in_display_line_to, move_it_in_display_line)
	(move_it_to, move_it_vertically_backward, move_it_by_lines)
	(try_scrolling, redisplay_window, display_line): Use them when
	saving a temporary copy of the iterator and restoring it back.
	(back_to_previous_visible_line_start, reseat_1)
	(init_iterator): Empty the bidi cache "stack".
	(move_it_in_display_line_to): If iterator ended up at
	EOL, but we never saw any buffer positions smaller than
	to_charpos, return MOVE_POS_MATCH_OR_ZV.  Fixes vertical cursor
	motion in bidi-reordered lines.
	(move_it_in_display_line_to): Record prev_method and prev_pos
	immediately before the call to set_iterator_to_next.  Fixes cursor
	motion in bidi-reordered lines with stretch glyphs and strings
	displayed in margins.  (Bug#8133) (Bug#8867)
	Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
	TO_CHARPOS.
	(pos_visible_p): Support positions in bidi-reordered lines.  Save
	and restore bidi cache.

	* bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
	(bidi_paragraph_info): Delete unused struct.
	(bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
	(bidi_cache_start): New variable.
	(bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
	to zero.
	(bidi_cache_fetch_state, bidi_cache_search)
	(bidi_cache_find_level_change, bidi_cache_iterator_state)
	(bidi_cache_find, bidi_peek_at_next_level)
	(bidi_level_of_next_char, bidi_find_other_level_edge)
	(bidi_move_to_visually_next): Compare cache index with
	bidi_cache_start rather than with zero.
	(bidi_fetch_char): Accept new argument STRING; all callers
	changed.  Support iteration over a string.  Support strings with
	display properties.  Support unibyte strings.  Fix the type of
	`len' according to what STRING_CHAR_AND_LENGTH expects.
	(bidi_paragraph_init, bidi_resolve_explicit_1)
	(bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next): Support
	iteration over a string.
	(bidi_set_sor_type, bidi_resolve_explicit_1)
	(bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
	can now be zero (for strings); special values 0 and -1 were
	changed to -1 and -2, respectively.
	(bidi_char_at_pos): New function.
	(bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
	Call it instead of FETCH_MULTIBYTE_CHAR.
	(bidi_move_to_visually_next): Abort if charpos or bytepos were not
	initialized to valid values.
	(bidi_init_it): Don't initialize charpos and bytepos with invalid
	values.
	(bidi_level_of_next_char): Allow the sentinel "position" to pass
	the test for valid cached positions.  Fix the logic for looking up
	the sentinel state in the cache.  GCPRO the Lisp string we are
	iterating.
	(bidi_push_it, bidi_pop_it): New functions.
	(bidi_initialize): Initialize the bidi cache start stack pointer.
	(bidi_cache_ensure_space): New function, refactored from part of
	bidi_cache_iterator_state.  Don't assume the required size is just
	one BIDI_CACHE_CHUNK away.
	(bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
	(bidi_count_bytes, bidi_char_at_pos): New functions.
	(bidi_cache_search): Don't assume bidi_cache_last_idx is
	always valid if bidi_cache_idx is valid.
	(bidi_cache_find_level_change): xassert that bidi_cache_last_idx
	is valid if it's going to be used.
	(bidi_shelve_cache, bidi_unshelve_cache): New functions.
	(bidi_cache_fetch_state, bidi_cache_search)
865 866 867 868 869
	(bidi_cache_find_level_change, bidi_cache_ensure_space)
	(bidi_cache_iterator_state, bidi_cache_find)
	(bidi_find_other_level_edge, bidi_cache_start_stack): All
	variables related to cache indices are now EMACS_INT.

870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892
	* dispextern.h (struct bidi_string_data): New structure.
	(struct bidi_it): New member `string'.  Make flag members be 1-bit
	fields, and put them last in the struct.
	(compute_display_string_pos, compute_display_string_end): Update
	prototypes.
	(bidi_push_it, bidi_pop_it): Add prototypes.
	(struct iterator_stack_entry): New members bidi_p,
	paragraph_embedding, and from_disp_prop_p.
	(struct it): Member bidi_p is now a bit field 1 bit wide.
	(bidi_shelve_cache, bidi_unshelve_cache): Declare
	prototypes.

	* .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
	(xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
	and vector-like objects.

	* dispnew.c (buffer_posn_from_coords): Save and restore the bidi
	cache around display iteration.

	* window.c (Fwindow_end, window_scroll_pixel_based)
	(displayed_window_lines, Frecenter): Save and restore the bidi
	cache around display iteration.

893 894 895 896 897
2011-07-14  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* editfns.c (Fdelete_region): Clarify the use of the named
	parameters (bug#6788).

898 899 900 901 902
2011-07-14  Martin Rudalics  <rudalics@gmx.at>

	* indent.c (Fvertical_motion): Set and restore w->pointm when
	saving and restoring the window's buffer (Bug#9006).

903 904 905 906 907
2011-07-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* editfns.c (Fstring_to_char): Clarify just what is returned
	(bug#6576).  Text by Eli Zaretskii.

908 909 910 911
2011-07-13  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).

912 913 914 915
2011-07-13  Eli Zaretskii  <eliz@gnu.org>

	* buffer.c (mmap_find): Fix a typo.

916 917 918 919 920 921 922 923 924 925 926 927
2011-07-13  Johan Bockgård  <bojohan@gnu.org>

	Fix execution of x selection hooks.
	* xselect.c (Qx_lost_selection_functions)
	(Qx_sent_selection_functions): New vars.
	(syms_of_xselect): DEFSYM them.
	(x_handle_selection_request): Pass Qx_sent_selection_functions
	rather than Vx_sent_selection_functions to Frun_hook_with_args.
	(x_handle_selection_clear,x_clear_frame_selections):
	Pass Qx_lost_selection_functions rather than
	Vx_lost_selection_functions to Frun_hook_with_args.

928 929
2011-07-13  Paul Eggert  <eggert@cs.ucla.edu>

930
	* buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
931 932
	The old code sometimes used this field without initializing it.

933 934 935 936
	* alloc.c (gc_sweep): Don't read past end of array.
	In theory, the old code could also have corrupted Emacs internals,
	though it'd be very unlikely.

937 938 939
2011-07-12  Andreas Schwab  <schwab@linux-m68k.org>

	* character.c (Fcharacterp): Don't advertise optional ignored
940
	argument.  (Bug#4026)
941

Lars Magne Ingebrigtsen's avatar
Lars Magne Ingebrigtsen committed
942 943
2011-07-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

944 945 946
	* keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
	key" (bug#4257).

Lars Magne Ingebrigtsen's avatar
Lars Magne Ingebrigtsen committed
947 948 949
	* window.c (Fset_window_start): Doc fix (bug#4199).
	(Fset_window_hscroll): Ditto.

950 951
2011-07-12  Paul Eggert  <eggert@cs.ucla.edu>

952
	Fix minor new problems caught by GCC 4.6.1.
953
	* term.c (init_tty): Remove unused local.
954
	* xsettings.c (store_monospaced_changed): Define this function only
955
	if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
956
	not used otherwise.
957

958 959 960 961
2011-07-12  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).

962 963
2011-07-11  Lars Magne Ingebrigtsen  <larsi@gnus.org>

964 965 966
	* xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
	are the mini-buffer and the echo area (bug#3320).

967 968 969
	* term.c (init_tty): Remove support for supdup, c10 and perq
	terminals, which are no longer supported (bug#1482).

970 971 972 973
2011-07-10  Johan Bockgård  <bojohan@gnu.org>

	* xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.

974 975 976 977 978
2011-07-10  Jan Djärv  <jan.h.d@swipnet.se>

	* xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
	for non-popups (Bug#3642).

Andreas Schwab's avatar
Andreas Schwab committed
979 980
2011-07-10  Andreas Schwab  <schwab@linux-m68k.org>

Andreas Schwab's avatar
Andreas Schwab committed
981
	* alloc.c (reset_malloc_hooks): Protoize.
Andreas Schwab's avatar
Andreas Schwab committed
982
	* buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
Andreas Schwab's avatar
Andreas Schwab committed
983 984
	(mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
	* cm.c (losecursor): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
985 986 987 988 989 990 991 992 993 994 995 996 997 998
	* data.c (fmod): Likewise.
	* dispnew.c (swap_glyphs_in_rows): Likewise.
	* emacs.c (memory_warning_signal): Likewise.
	* floatfns.c (float_error): Likewise.
	* font.c (check_gstring, check_otf_features, otf_tag_symbol)
	(otf_open, font_otf_capability, generate_otf_features)
	(font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
	Likewise.
	* image.c (pbm_read_file): Likewise.
	* indent.c (string_display_width): Likewise.
	* intervals.c (check_for_interval, search_for_interval)
	(inc_interval_count, count_intervals, root_interval)
	(adjust_intervals_for_insertion, make_new_interval): Likewise.
	* lread.c (defalias): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
999
	* ralloc.c (r_alloc_check): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015
	* regex.c (set_image_of_range_1, set_image_of_range)
	(regex_grow_registers): Likewise.
	* sysdep.c (strerror): Likewise.
	* termcap.c (valid_filename_p, tprint, main): Likewise.
	* tparam.c (main): Likewise.
	* unexhp9k800.c (run_time_remap, save_data_space)
	(update_file_ptrs, read_header, write_header, calculate_checksum)
	(copy_file, copy_rest, display_header): Likewise.
	* widget.c (mark_shell_size_user_specified, create_frame_gcs):
	Likewise.
	* xdisp.c (check_it): Likewise.
	* xfaces.c (register_color, unregister_color, unregister_colors):
	Likewise.
	* xfns.c (print_fontset_result): Likewise.
	* xrdb.c (member, fatal, main): Likewise.

1016 1017 1018 1019 1020 1021 1022 1023
2011-07-10  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking (Bug#9031).
	* chartab.c (char_table_set_range, map_sub_char_table):
	Remove unused locals.
	(uniprop_table): Now static.
	* composite.c (_work_char): Remove unused static var.

1024 1025 1026 1027
2011-07-09  Juanma Barranquero  <lekktu@gmail.com>

	* chartab.c (uniprop_table_uncompress): Remove unused local variable.

1028 1029 1030 1031
2011-07-09  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (qttip_cb): Remove code without function.

1032 1033 1034 1035
2011-07-09  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (pthread_sigmask): New stub.

Paul Eggert's avatar
Paul Eggert committed
1036
2011-07-08  Paul Eggert  <eggert@cs.ucla.edu>
1037

Paul Eggert's avatar
Paul Eggert committed
1038
	Use pthread_sigmask, not sigprocmask (Bug#9010).
1039 1040
	sigprocmask is portable only for single-threaded applications, and
	Emacs can be multi-threaded when it uses GTK.
1041 1042 1043 1044 1045 1046
	* Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
	(LIBES): Use it.
	* callproc.c (Fcall_process):
	* process.c (create_process):
	* sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
	Use pthread_sigmask, not sigprocmask.
1047

1048 1049 1050 1051 1052 1053
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
	(xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
	wrong (Bug#8591).

1054 1055
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
1056 1057 1058 1059
	* gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
	Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
	(xg_hide_tooltip): Fix comment.

1060 1061 1062 1063 1064 1065 1066
	* nsterm.m (initFrameFromEmacs): Don't use ns_return_types
	in registerServicesMenuSendTypes.
	(validRequestorForSendType): Don't check ns_return_types.

	* nsfns.m (Fx_open_connection): Put NSStringPboardType into
	ns_return_type.

1067 1068 1069 1070 1071
2011-07-08  Jason Rumney  <jasonr@gnu.org>

	* w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
	frame struct members of non-existent frames (Bug#6284).

1072 1073
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
	* nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
	variable firstTime not needed on OSX >= 10.6.
	(setPosition): setFloatValue:knobProportion: is deprecated on OSX
	>= 10.5.  Use setKnobProportion, setDoubleValue.

	* nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
	(MAC_OS_X_VERSION_10_5): Define if not defined.
	(EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
	(EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
	(EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.

	* nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
	cString and lossyCString on OSX >= 10.4

	* nsmenu.m (fillWithWidgetValue): Don't use depercated method
	sizeToFit on OSX >= 10.2.

	* nsimage.m (allocInitFromFile): Don't use deprecated method
	bestRepresentationForDevice on OSX >= 10.6.

	* nsfns.m (check_ns_display_info): Cast to long and use %ld in error
	to avoid warning.

	* emacs.c: Declare unexec_init_emacs_zone.

1099 1100
	* nsgui.h: Fix compiler warning about gnulib redefining verify.

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121
	* nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).

	* nsmenu.m (ns_update_menubar): Remove useless setDelegate call
	on svcsMenu (Bug#8842).

	* nsfns.m (Fx_open_connection): Remove NSStringPboardType from
	ns_return_types.
	(Fns_list_services): Just return Qnil on 10.6, code not working there.

	* nsterm.m (QUTF8_STRING): Declare.
	(initFrameFromEmacs): Call registerServicesMenuSendTypes.
	(validRequestorForSendType): Return type is (id).
	Change indexOfObjectIdenticalTo to indexOfObject.
	Check if we have local selection before returning self (Bug#8842).
	(writeSelectionToPasteboard): Put local selection into paste board
	if we have a local selection (Bug#8842).
	(syms_of_nsterm): DEFSYM QUTF8_STRING.

	* nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
	(ns_get_local_selection): Declare.

1122 1123
2011-07-07  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1124 1125 1126 1127
	* keymap.c (describe_map_tree): Don't insert a double newline at
	the end of the buffer (bug#1169) and return whether we inserted
	something.

1128 1129 1130
	* callint.c (Fcall_interactively): Change "reading args" to
	"providing args" to try to clarify what it does (bug#1010).

1131 1132 1133 1134 1135 1136 1137
2011-07-07  Kenichi Handa  <handa@m17n.org>

	* composite.c (composition_compute_stop_pos): Ignore a static
	composition starting before CHARPOS (Bug#8915).

	* xdisp.c (handle_composition_prop): Likewise.

1138 1139 1140 1141 1142
2011-07-07  Eli Zaretskii  <eliz@gnu.org>

	* term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
	(Bug#9015)

Kenichi Handa's avatar
Kenichi Handa committed
1143
2011-07-07  Kenichi Handa  <handa@m17n.org>
1144 1145 1146 1147 1148 1149 1150 1151 1152 1153

	* character.h (unicode_category_t): New enum type.

	* chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
	(Qchar_code_property_table): New variable.
	(UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
	(UNIPROP_COMPRESSED_FORM_P): New macros.
	(char_table_ascii): Uncompress the compressed values.
	(sub_char_table_ref): New arg is_uniprop.  Callers changed.
	Uncompress the compressed values.
1154
	(sub_char_table_ref_and_range): Likewise.
1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
	(char_table_ref_and_range): Uncompress the compressed values.
	(sub_char_table_set): New arg is_uniprop.  Callers changed.
	Uncompress the compressed values.
	(sub_char_table_set_range): Args changed.  Callers changed.
	(char_table_set_range): Adjuted for the above change.
	(map_sub_char_table): Delete args default_val and parent.  Add arg
	top.  Give decoded values to a Lisp function.
	(map_char_table): Adjusted for the above change.  Give decoded
	values to a Lisp function.  Gcpro more variables.
	(uniprop_table_uncompress)
	(uniprop_decode_value_run_length): New functions.
	(uniprop_decoder, uniprop_decoder_count): New variables.
	(uniprop_get_decoder, uniprop_encode_value_character)
	(uniprop_encode_value_run_length, uniprop_encode_value_numeric):
	New functions.
	(uniprop_encoder, uniprop_encoder_count): New variables.
	(uniprop_get_encoder, uniprop_table)
	(Funicode_property_table_internal, Fget_unicode_property_internal)
	(Fput_unicode_property_internal): New functions.
	(syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
	Sunicode_property_table_internal, Sget_unicode_property_internal,
	and Sput_unicode_property_internal. Defvar_lisp
	char-code-property-alist.

	* composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
	Vunicode_category_table.

	* font.c (font_range): Adjusted for the change of
	Vunicode_category_table.

1185 1186 1187 1188 1189
2011-07-07  Dan Nicolaescu  <dann@ics.uci.edu>

	* m/iris4d.h: Remove file, move contents ...
	* s/irix6-5.h: ... here.

1190 1191 1192
2011-07-06  Paul Eggert  <eggert@cs.ucla.edu>

	Remove unportable assumption about struct layout (Bug#8884).
1193 1194 1195
	* alloc.c (mark_buffer):
	* buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
	(clone_per_buffer_values): Don't assume that
1196 1197 1198 1199 1200 1201
	sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
	This isn't true in general, and it's particularly not true
	if Emacs is configured with --with-wide-int.
	* buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
	New macros, used in the buffer.c change.

1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233
2011-07-05  Jan Djärv  <jan.h.d@swipnet.se>

	* xsettings.c: Use both GConf and GSettings if both are available.
	(store_config_changed_event): Add comment.
	(dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
	(store_tool_bar_style_changed): New functions.
	(store_monospaced_changed): Add comment. Call dpyinfo_valid.
	(struct xsettings): Move font inside HAVE_XFT.
	(GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
	(GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
	Move inside HAVE_XFT.
	(something_changed_gsettingsCB): Renamed from something_changedCB.
	Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
	also.
	(GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
	(GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
	(something_changed_gconfCB): Renamed from something_changedCB.
	Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
	(parse_settings): Move check for font inside HAVE_XFT.
	(read_settings, apply_xft_settings): Add comment.
	(read_and_apply_settings): Add comment.  Call map_tool_bar_style and
	store_tool_bar_style_changed.  Move check for font inside HAVE_XFT and
	call store_font_name_changed.
	(xft_settings_event): Add comment.
	(init_gsettings): Add comment.  Get values for GSETTINGS_TOOL_BAR_STYLE
	and GSETTINGS_FONT_NAME.  Move check for fonts within HAVE_XFT.
	(init_gconf): Add comment.  Get values for GCONF_TOOL_BAR_STYLE
	and GCONF_FONT_NAME.  Move check for fonts within HAVE_XFT.
	(xsettings_initialize): Call init_gsettings last.
	(xsettings_get_system_font, xsettings_get_system_normal_font): Add
	comment.

1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245
2011-07-05  Paul Eggert  <eggert@cs.ucla.edu>

	Random fixes.  E.g., (random) never returned negative values.
	* fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
	subseconds part to the entropy, as that's a bit more random.
	Prefer signed to unsigned, since the signedness doesn't matter and
	in general we prefer signed.  When given a limit, use a
	denominator equal to INTMASK + 1, not to VALMASK + 1, because the
	latter isn't right if USE_2_TAGS_FOR_INTS.
	* sysdep.c (get_random): Return a value in the range 0..INTMASK,
	not 0..VALMASK.  Don't discard "excess" bits that random () returns.

1246 1247 1248 1249 1250 1251 1252 1253
2011-07-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* textprop.c (text_property_stickiness):
	Obey Vtext_property_default_nonsticky.
	(syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
	* w32fns.c (syms_of_w32fns):
	* xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.

1254 1255 1256 1257 1258
2011-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
	This is more efficient than Ffile_directory_p and avoids a minor race.

1259 1260
2011-07-04  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1261 1262 1263
	* buffer.c (Foverlay_put): Say what the return value is
	(bug#7835).

1264 1265 1266
	* fileio.c (barf_or_query_if_file_exists): Check first if the file
	is a directory before asking whether to use the file name
	(bug#7564).
1267 1268
	(barf_or_query_if_file_exists): Make the "File is a directory"
	error be more correct.
1269

1270 1271 1272 1273
	* fns.c (Frequire): Remove the mention of the .gz files, since
	that's installation-specific, but keep the mention of
	`get-load-suffixes'.

1274 1275 1276 1277 1278
2011-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	* editfns.c (Fformat_time_string): Don't assume strlen fits in int.
	Report string overflow if the output is too long.

1279 1280
2011-07-04  Juanma Barranquero  <lekktu@gmail.com>

1281 1282 1283 1284 1285
	* gnutls.c (Fgnutls_boot): Don't mention :verify-error.
	(syms_of_gnutls): Remove duplicate DEFSYM for
	Qgnutls_bootprop_verify_hostname_error, an error for
	Qgnutls_bootprop_verify_error (which is no longer used).

1286 1287 1288 1289
	* eval.c (find_handler_clause): Remove parameters `sig' and `data',
	unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca.  All callers changed.
	Also (re)move comments that are misplaced or no longer relevant.

1290 1291 1292 1293
2011-07-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).

1294 1295 1296 1297 1298
2011-07-03  Chong Yidong  <cyd@stupidchicken.com>

	* xfaces.c (Finternal_merge_in_global_face): Modify the foreground
	and background color parameters if they have been changed.

1299 1300 1301 1302
2011-07-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).

1303 1304
2011-07-03  Paul Eggert  <eggert@cs.ucla.edu>

1305 1306 1307
	* xsettings.c (SYSTEM_FONT): Define only when used.
	No need to define when HAVE_GSETTINGS || !HAVE_XFT.

1308 1309
	* keymap.c (access_keymap_1): Now static.

1310 1311 1312 1313 1314
2011-07-02  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (command_loop_1): If a down-mouse event is unbound,
	leave any prefix arg for the up event (Bug#1586).

1315 1316
2011-07-02  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1317 1318 1319
	* lread.c (syms_of_lread): Mention single symbols defined by
	`defvar' or `defconst' (bug#7154).

1320
	* fns.c (Frequire): Mention .el.gz files (bug#7314).
1321
	(Frequire): Mention get-load-suffixes.
1322

1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333
2011-07-02  Martin Rudalics  <rudalics@gmx.at>

	* window.h (window): Remove clone_number slot.
	* window.c (Fwindow_clone_number, Fset_window_clone_number):
	Remove.
	(make_parent_window, make_window, saved_window)
	(Fset_window_configuration, save_window_save): Don't deal with
	clone numbers.
	* buffer.c (Qclone_number): Remove declaration.
	(sort_overlays, overlay_strings): Don't deal with clone numbers.

1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
2011-07-02  Stefan Monnier  <monnier@iro.umontreal.ca>

	Add multiple inheritance to keymaps.
	* keymap.c (Fmake_composed_keymap): New function.
	(Fset_keymap_parent): Simplify.
	(fix_submap_inheritance): Remove.
	(access_keymap_1): New function extracted from access_keymap to handle
	embedded parents and handle lists of maps.
	(access_keymap): Use it.
	(Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
	(Fcopy_keymap): Handle embedded parents.
	(Fcommand_remapping, define_as_prefix): Simplify.
	(Fkey_binding): Simplify.
	(syms_of_keymap): Move minibuffer-local-completion-map,
	minibuffer-local-filename-completion-map,
	minibuffer-local-must-match-map, and
	minibuffer-local-filename-must-match-map to Elisp.
	(syms_of_keymap): Defsubr make-composed-keymap.
	* keyboard.c (menu_bar_items): Use map_keymap_canonical.
	(parse_menu_item): Trivial simplification.

1355 1356 1357 1358
2011-07-01  Glenn Morris  <rgm@gnu.org>

	* Makefile.in (SETTINGS_LIBS): Fix typo.

1359 1360 1361 1362 1363
2011-07-01  Kazuhiro Ito  <kzhr@d1.dion.ne.jp>  (tiny patch)

	* coding.c (Fencode_coding_string): Record the last coding system
	used, as the function doc string says (bug#8738).

1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376
2011-07-01  Jan Djärv  <jan.h.d@swipnet.se>

	* xsettings.c (store_monospaced_changed): Take new font as arg and
	check for change against current_mono_font.
	(EMACS_TYPE_SETTINGS): Remove this and related defines.
	(emacs_settings_constructor, emacs_settings_get_property)
	(emacs_settings_set_property, emacs_settings_class_init)
	(emacs_settings_init, gsettings_obj): Remove.
	(something_changedCB): New function for HAVE_GSETTINGS.
	(something_changedCB): HAVE_GCONF: Call store_monospaced_changed
	with value as argument.
	(init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
	g_settings_new (Bug#8967).  Do not create gsettings_obj.
Juanma Barranquero's avatar
Juanma Barranquero committed
1377
	Remove calls to g_settings_bind.  Connect something_changedCB to
1378 1379 1380 1381 1382 1383 1384 1385 1386
	"changed".

	* xgselect.c: Add defined (HAVE_GSETTINGS).
	(xgselect_initialize): Ditto.

	* process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
	(wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
	xg_select.

1387 1388 1389 1390 1391 1392 1393 1394 1395 1396
2011-07-01  Paul Eggert  <eggert@cs.ucla.edu>

	* eval.c (struct backtrace): Simplify and port the data structure.
	Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
	signed bit field, as this assumption is not portable and it makes
	Emacs crash when compiled with Sun C 5.8 on sparc.  Do not use
	"char debug_on_exit : 1" as this is not portable either; instead,
	use the portable "unsigned int debug_on_exit : 1".  Remove unused
	member evalargs.  Remove obsolete comments about cc bombing out.

1397 1398
2011-06-30  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
1399
	* xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417
	Let HAVE_GSETTINGS override HAVE_GCONF.
	(store_monospaced_changed): New function.
	(EMACS_SETTINGS): A new type derived from GObject to handle
	GSettings notifications.
	(emacs_settings_constructor, emacs_settings_get_property)
	(emacs_settings_set_property, emacs_settings_class_init):
	New functions.
	(gsettings_client, gsettings_obj): New variables.
	(GSETTINGS_SCHEMA): New define.
	(something_changedCB): Call store_monospaced_changed.
	(init_gsettings): New function.
	(xsettings_initialize): Call init_gsettings.
	(syms_of_xsettings): Initialize gsettings_client, gsettings_obj
	to NULL.

	* Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
	GCONF_CFLAGS/LIBS.

1418 1419 1420 1421 1422 1423 1424
2011-06-29  Martin Rudalics  <rudalics@gmx.at>

	* window.c (resize_root_window, grow_mini_window)
	(shrink_mini_window): Rename Qresize_root_window to
	Qwindow_resize_root_window and Qresize_root_window_vertically to
	Qwindow_resize_root_window_vertically.

1425 1426 1427 1428
2011-06-28  Paul Eggert  <eggert@cs.ucla.edu>

	* gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.

1429 1430 1431 1432 1433 1434
2011-06-27  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Redesign dependencies so they reflect more
	clearly which files are directly included by each source file,
	and not through other includes.

1435 1436 1437 1438 1439 1440 1441
2011-06-27  Martin Rudalics  <rudalics@gmx.at>

	* buffer.c (Qclone_number): Declare static and DEFSYM it.
	(sort_overlays, overlay_strings): When an overlay's clone number
	matches the window's clone number process the overlay even if
	the overlay's window property doesn't match the current window.

1442 1443 1444 1445
	* window.c (Fwindow_vchild): Rename to Fwindow_top_child.
	(Fwindow_hchild): Rename to Fwindow_left_child.
	(Fwindow_next): Rename to Fwindow_next_sibling.
	(Fwindow_prev): Rename to Fwindow_prev_sibling.
1446 1447 1448 1449 1450 1451 1452
	(resize_window_check): Rename to window_resize_check.
	(resize_window_apply): Rename to window_resize_apply.
	(Fresize_window_apply): Rename to Fwindow_resize_apply.
	(Fdelete_other_windows_internal, resize_frame_windows)
	(Fsplit_window_internal, Fdelete_window_internal)
	(grow_mini_window, shrink_mini_window)
	(Fresize_mini_window_internal): Fix callers accordingly.
1453

1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473
2011-06-26  Jan Djärv  <jan.h.d@swipnet.se>

	* emacsgtkfixed.h: State that this is only used with Gtk+3.
	(emacs_fixed_set_min_size): Remove.
	(emacs_fixed_new): Take frame as argument.

	* emacsgtkfixed.c: State that this is only used with Gtk+3.
	(_EmacsFixedPrivate): Remove minwidth/height.
	Add struct frame *f.
	(emacs_fixed_init): Initialize priv->f.
	(get_parent_class, emacs_fixed_set_min_size): Remove.
	(emacs_fixed_new): Set priv->f to argument.
	(emacs_fixed_get_preferred_width)
	(emacs_fixed_get_preferred_height): Use min_width/height from
	frames size_hint to set minimum and natural (Bug#8919).
	(XSetWMSizeHints, XSetWMNormalHints): Override these functions
	and use min_width/height from frames size_hint to set
	min_width/height (Bug#8919).

	* gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
Juanma Barranquero's avatar
Juanma Barranquero committed
1474 1475
	(x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
	Fix indentation.
1476

1477 1478 1479 1480 1481 1482
2011-06-26  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
	bidi_at_paragraph_end, since fast_looking_at doesn't like to be
	called at ZV.

1483 1484 1485 1486 1487 1488
2011-06-26  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (wait_reading_process_output): Bypass select if
	waiting for a cell while ignoring keyboard input, and input is
	pending.  Suggested by Jan Djärv (Bug#8869).

1489 1490 1491 1492 1493
2011-06-25  Paul Eggert  <eggert@cs.ucla.edu>

	Use gnulib's dup2 module instead of rolling our own.
	* sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.

1494
2011-06-25  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
1495 1496 1497 1498

	* dispnew.c (scrolling_window): Before scrolling, turn off a
	mouse-highlight in the window being scrolled.

1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554
2011-06-24  Juanma Barranquero  <lekktu@gmail.com>

	Move DEFSYM to lisp.h and use everywhere.

	* character.h (DEFSYM): Move declaration...
	* lisp.h (DEFSYM): ...here.

	* gnutls.c:
	* minibuf.c:
	* w32menu.c:
	* w32proc.c:
	* w32select.c: Don't include character.h.

	* alloc.c (syms_of_alloc):
	* buffer.c (syms_of_buffer):
	* bytecode.c (syms_of_bytecode):
	* callint.c (syms_of_callint):
	* casefiddle.c (syms_of_casefiddle):
	* casetab.c (init_casetab_once):
	* category.c (init_category_once, syms_of_category):
	* ccl.c (syms_of_ccl):
	* cmds.c (syms_of_cmds):
	* composite.c (syms_of_composite):
	* dbusbind.c (syms_of_dbusbind):
	* dired.c (syms_of_dired):
	* dispnew.c (syms_of_display):
	* doc.c (syms_of_doc):
	* editfns.c (syms_of_editfns):
	* emacs.c (syms_of_emacs):
	* eval.c (syms_of_eval):
	* fileio.c (syms_of_fileio):
	* fns.c (syms_of_fns):
	* frame.c (syms_of_frame):
	* fringe.c (syms_of_fringe):
	* insdel.c (syms_of_insdel):
	* keymap.c (syms_of_keymap):
	* lread.c (init_obarray, syms_of_lread):
	* macros.c (syms_of_macros):
	* msdos.c (syms_of_msdos):
	* print.c (syms_of_print):
	* process.c (syms_of_process):
	* search.c (syms_of_search):
	* sound.c (syms_of_sound):
	* syntax.c (init_syntax_once, syms_of_syntax):
	* terminal.c (syms_of_terminal):
	* textprop.c (syms_of_textprop):
	* undo.c (syms_of_undo):
	* w32.c (globals_of_w32):
	* window.c (syms_of_window):
	* xdisp.c (syms_of_xdisp):
	* xfaces.c (syms_of_xfaces):
	* xfns.c (syms_of_xfns):
	* xmenu.c (syms_of_xmenu):
	* xsettings.c (syms_of_xsettings):
	* xterm.c (syms_of_xterm): Use DEFSYM.

1555 1556
2011-06-24  Teodor Zlatanov  <tzz@lifelogs.com>

1557
	* gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1558

1559 1560
2011-06-23  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
1561 1562
	Integer and buffer overflow fixes (Bug#8873).

1563 1564 1565 1566
	* print.c (printchar, strout): Check for string overflow.
	(PRINTPREPARE, printchar, strout):
	Don't set size unless allocation succeeds.

1567 1568 1569 1570
	* minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
	for sizes.  Check for string overflow more accurately.
	Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.

1571 1572 1573 1574 1575 1576 1577 1578
	* macros.c: Integer and buffer overflow fixes.
	* keyboard.h (struct keyboard.kbd_macro_bufsize):
	* macros.c (Fstart_kbd_macro, store_kbd_macro_char):
	Use ptrdiff_t, not int, for sizes.
	Don't increment bufsize until after realloc succeeds.
	Check for size-calculation overflow.
	(Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.

1579 1580
	* lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.

1581 1582 1583 1584 1585 1586
	* lread.c: Integer overflow fixes.
	(read_integer): Radix is now EMACS_INT, not int,
	to improve quality of diagnostics for out-of-range radices.
	Calculate buffer size correctly for out-of-range radices.
	(read1): Check for integer overflow in radices, and in
	read-circle numbers.
1587 1588 1589 1590 1591
	(read_escape): Avoid int overflow.
	(Fload, openp, read_buffer_size, read1)
	(substitute_object_recurse, read_vector, read_list, map_obarray):
	Use ptrdiff_t, not int, for sizes.
	(read1): Use EMACS_INT, not int, for sizes.
1592
	Check for size overflow.
1593

1594 1595
	* image.c (cache_image): Check for size arithmetic overflow.

1596 1597 1598 1599 1600 1601 1602
	* lread.c: Integer overflow issues.
	(saved_doc_string_size, saved_doc_string_length)
	(prev_saved_doc_string_size, prev_saved_doc_string_length):
	Now ptrdiff_t, not int.
	(read1): Don't assume doc string length fits in int.  Check for
	out-of-range doc string lengths.
	(read_list): Don't assume file position fits in int.