ChangeLog 69.8 KB
Newer Older
1 2
2011-04-13  Paul Eggert  <eggert@cs.ucla.edu>

3 4 5 6 7 8 9 10 11 12 13 14 15 16
	emacs_write: Return size_t, not ssize_t, to avoid overflow issues.
	* gnutls.c, gnutls.h (emacs_gnutls_write): Return size_t, not ssize_t.
	* sysdep.c, lisp.h (emacs_write): Likewise.
	Without the above change, emacs_gnutls_write and emacs_write had
	undefined behavior and would typically mistakenly report an error
	when writing a buffer whose size exceeds SSIZE_MAX.
	(emacs_read, emacs_write): Remove check for negative size, as the
	Emacs source code has been audited now.
	(emacs_write): Adjust to new signature, making the code look more
	like that of emacs_gnutls_write.
	* process.c (send_process): Adjust to the new signatures of
	emacs_write and emacs_gnutls_write.  Do not attempt to store
	a byte offset into an 'int'; it might overflow.

17 18 19 20 21 22 23 24
	* sound.c: Don't assume sizes fit in 'int'.
	(struct sound_device.period_size, alsa_period_size):
	Return size_t, not int.
	(struct sound_device.write, vox_write, alsa_write):
	Accept size_t, not int.
	(wav_play, au_play): Use size_t to store sizes, and ssize_t to
	record read return values.

25 26
2011-04-12  Andreas Schwab  <schwab@linux-m68k.org>

27 28 29 30 31 32 33 34
	* charset.c (Fclear_charset_maps): Use xfree instead of free.
	(Bug#8437)
	* keyboard.c (parse_tool_bar_item): Likewise.
	* sound.c (sound_cleanup, alsa_close): Likewise.
	* termcap.c (tgetent): Likewise.
	* xfns.c (x_default_font_parameter): Likewise.
	* xsettings.c (read_and_apply_settings): Likewise.

35 36 37
	* alloc.c (overrun_check_malloc, overrun_check_realloc)
	(overrun_check_free): Protoize.

38 39 40 41 42 43 44 45
2011-04-12  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (emacs_read, emacs_write): Check for negative sizes
	since callers should never pass a negative size.
	Change the signature to match that of plain 'read' and 'write'; see
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
	* lisp.h: Update prototypes of emacs_write and emacs_read.

46 47 48 49
2011-04-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't try to determine the character
	position of the scroll margin if the window start point w->startp
50
	is outside the buffer's accessible region.  (Bug#8468)
51

52 53 54 55 56 57 58 59 60 61 62 63 64 65
2011-04-10  Eli Zaretskii  <eliz@gnu.org>

	Fix write-region and its subroutines for buffers > 2GB.
	* fileio.c (a_write, e_write): Modify declaration of arguments and
	local variables to support buffers larger than 2GB.
	(Fcopy_file): Use EMACS_INT for return value of emacs_read.

	* sysdep.c (emacs_write, emacs_read): Use ssize_t for last
	argument, local variables, and return value.

	* lisp.h: Update prototypes of emacs_write and emacs_read.

	* sound.c (vox_write): Use ssize_t for return value of emacs_write.

Paul Eggert's avatar
Paul Eggert committed
66
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>
67

68 69
	* xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.

70 71
	Fix more problems found by GCC 4.6.0's static checks.

72 73
	* xdisp.c (vmessage): Use a better test for character truncation.

74 75
	* charset.c (load_charset_map): <, not <=, for optimization,
	and to avoid potential problems with integer overflow.
76
	* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
77
	* casetab.c (set_identity, shuffle): Likewise.
Paul Eggert's avatar
Paul Eggert committed
78
	* editfns.c (Fformat): Likewise.
79
	* syntax.c (skip_chars): Likewise.
80

81 82 83
	* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
	This also lets GCC 4.6.0 generate slightly better loop code.

84 85 86 87 88
	* callint.c (Fcall_interactively): <, not <=, for optimization.
	(Fcall_interactively): Count the number of arguments produced,
	not the number of arguments given.  This is simpler and lets GCC
	4.6.0 generate slightly better code.

89 90 91 92 93 94 95 96
	* ftfont.c: Distingish more carefully between FcChar8 and char.
	The previous code passed unsigned char * to a functions like
	strlen and xstrcasecmp that expect char *, which does not
	conform to the C standard.
	(get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
	arguments to FcPatternGetString, and explicitly cast FcChar8 * to
	char * when the C standard requires it.

97 98
	* keyboard.c (read_char): Remove unused var.

99 100 101 102 103 104 105 106 107
	* eval.c: Port to Windows vsnprintf (Bug#8435).
	Include <limits.h>.
	(SIZE_MAX): Define if the headers do not.
	(verror): Do not give up if vsnprintf returns a negative count.
	Instead, grow the buffer.  This ports to Windows vsnprintf, which
	does not conform to C99.  Problem reported by Eli Zaretskii.
	Also, simplify the allocation scheme, by avoiding the need for
	calling realloc, and removing the ALLOCATED variable.

108 109
	* eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

110 111 112
	Remove invocations of doprnt, as Emacs now uses vsnprintf.
	But keep the doprint source code for now, as we might revamp it
	and use it again (Bug#8435).
113 114 115 116
	* lisp.h (doprnt): Remove.
	* Makefile.in (base_obj): Remove doprnt.o.
	* deps.mk (doprnt.o): Remove.

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
	error: Print 32- and 64-bit integers portably (Bug#8435).
	Without this change, on typical 64-bit hosts error ("...%d...", N)
	was used to print both 32- and 64-bit integers N, which relied on
	undefined behavior.
	* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
	New macro.
	* lisp.h (error, verror): Mark as printf-like functions.
	* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
	Report overflow in size calculations when allocating printf buffer.
	Do not truncate output string at its first null byte.
	* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
	Truncate the output at a character boundary, since vsnprintf does not
	do that.
	* charset.c (check_iso_charset_parameter): Convert internal
	character to string before calling 'error', since %c now has the
	printf meaning.
	* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
	overflow when computing char to be passed to 'error'.  Do not
	pass Lisp_Object to 'error'; pass the integer instead.
	* nsfns.m (Fns_do_applescript): Use int, not long, since it's
	formatted with plain %d.

139 140
	* eval.c (internal_lisp_condition_case): Don't pass spurious arg.

141 142
	* keyboard.c (access_keymap_keyremap): Print func name, not garbage.

143 144
	* coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

145 146
	* xterm.c (x_catch_errors): Remove duplicate declaration.

147 148
	* term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

149 150
	* xdisp.c, lisp.h (message_nolog): Remove; unused.

151 152 153 154 155 156 157 158 159 160
2011-04-10  Jim Meyering  <meyering@redhat.com>

	use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
	* gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
	return ssize_t not "int", and use size_t as the buffer length.
	(emacs_gnutls_write): Likewise, and make the buffer pointer "const".
	* gnutls.h: Update declarations.
	* process.c (read_process_output): Use ssize_t, to match.
	(send_process): Likewise.

161 162 163 164
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

	* image.c (Fimagemagick_types): Doc fix, and comment cleanup.

165
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>
166

167 168
	* ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
	unsigned char, to match FcChar8 type definition.
169

170 171 172 173
	* xterm.c (handle_one_xevent):
	* xmenu.c (create_and_show_popup_menu):
	* xselect.c (x_decline_selection_request)
	(x_reply_selection_request): Avoid type-punned deref of X events.
174

175
2011-04-09  Eli Zaretskii  <eliz@gnu.org>
176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215

	Fix some uses of `int' instead of EMACS_INT.
	* search.c (string_match_1, fast_string_match)
	(fast_c_string_match_ignore_case, fast_string_match_ignore_case)
	(scan_buffer, find_next_newline_no_quit)
	(find_before_next_newline, search_command, Freplace_match)
	(Fmatch_data): Make some `int' variables be EMACS_INT.

	* xdisp.c (display_count_lines): 3rd argument and return value now
	EMACS_INT.  All callers changed.
	(pint2hrstr): Last argument is now EMACS_INT.

	* coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
	(detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
	(decode_coding_utf_16, decode_coding_emacs_mule)
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
	(decode_coding_ccl, decode_coding_charset)
	<consumed_chars, consumed_chars_base>: Declare EMACS_INT.
	(decode_coding_iso_2022, decode_coding_emacs_mule)
	(decode_coding_sjis, decode_coding_big5, decode_coding_charset)
	<char_offset, last_offset>: Declare EMACS_INT.
	(encode_coding_utf_8, encode_coding_utf_16)
	(encode_coding_emacs_mule, encode_invocation_designation)
	(encode_designation_at_bol, encode_coding_iso_2022)
	(encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
	(encode_coding_raw_text, encode_coding_charset) <produced_chars>:
	Declare EMACS_INT.
	(ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
	(encode_invocation_designation): Last argument P_NCHARS is now
	EMACS_INT.
	(decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
	(produce_chars): from_nchars and to_nchars are now EMACS_INT.

	* coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
	All users changed.

	* ccl.c (Fccl_execute_on_string): Declare some variables
	EMACS_INT.

216
2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)
217 218 219

	* term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

220 221 222 223
2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

	* process.c (Fformat_network_address): Doc fix.

224 225 226 227
2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

	* xml.c (parse_region): Avoid creating spurious whiespace nodes.

228 229 230 231 232
2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (read_char): Call Lisp function help-form-show,
	instead of using internal_with_output_to_temp_buffer.
	(Qhelp_form_show): New var.
233
	(syms_of_keyboard): Use DEFSYM macro.
234 235 236 237 238

	* print.c (internal_with_output_to_temp_buffer): Function deleted.

	* lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

239 240 241 242 243
2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (Flist_processes): Removed to Lisp.
	(list_processes_1): Deleted.

244 245
2011-04-06  Eli Zaretskii  <eliz@gnu.org>

246 247
	* msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

248 249
	* w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

250
2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
251

Paul Eggert's avatar
Paul Eggert committed
252 253
	Fix more problems found by GCC 4.6.0's static checks.

254 255
	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

256 257
	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

258
	* lisp.h (message, message_nolog, fatal): Mark as printf-like.
259

260 261
	* xdisp.c (vmessage): Mark as a printf-like function.

262 263
	* term.c (vfatal, maybe_fatal): Mark as printf-like functions.

264 265
	* sound.c (sound_warning): Don't crash if arg contains a printf format.

266 267 268 269 270
	* image.c (tiff_error_handler, tiff_warning_handler): Mark as
	printf-like functions.
	(tiff_load): Add casts to remove these marks before passing them
	to system-supplied API.

271 272
	* eval.c (Fsignal): Remove excess argument to 'fatal'.

273 274
	* coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
	This avoids several warnings with gcc -Wstrict-overflow.
275 276 277 278 279 280
	(DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
	directly, rather than having caller test rule sign.  This avoids
	some unnecessary tests.
	* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
	(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
	affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
281

282
	* xfont.c (xfont_text_extents): Remove var that was set but not used.
283
	(xfont_open): Avoid unnecessary tests.
284

285 286
	* composite.c (composition_gstring_put_cache): Use unsigned integer.

287 288 289
	* composite.h, composite.c (composition_gstring_put_cache):
	Use EMACS_INT, not int, for length.

290 291 292 293 294 295
	* composite.h (COMPOSITION_DECODE_REFS): New macro,
	breaking out part of COMPOSITION_DECODE_RULE.
	(COMPOSITION_DECODE_RULE): Use it.
	* composite.c (get_composition_id): Remove unused local vars,
	by using the new macro.

296 297 298
	* textprop.c (set_text_properties_1): Change while to do-while,
	since the condition is always true at first.

299
	* intervals.c (graft_intervals_into_buffer): Mark var as used.
300 301
	(interval_deletion_adjustment): Return unsigned value.
	All uses changed.
302

303 304
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
305
	(create_pty): Remove unnecessary "volatile"s.
306
	(Fnetwork_interface_info): Avoid possibility of int overflow.
307
	(read_process_output): Do adaptive read buffering even if carryover.
308
	(read_process_output): Simplify nbytes computation if buffered.
309

310 311
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

312
	* syntax.c (scan_words): Remove var that was set but not used.
313
	(update_syntax_table): Use unsigned instead of int.
314

315
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
316
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
317
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
318

319 320
	* print.c (print_error_message): Avoid int overflow.

321 322 323
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

324
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
325
	(font_score): Avoid potential overflow in diff calculation.
326

327
	* fns.c (substring_both): Remove var that is set but not used.
328
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
329

330 331
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

332 333 334 335
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

336
	* search.c (boyer_moore, wordify): Remove vars set but not used.
337
	(wordify): Omit three unnecessary tests.
338

339 340 341
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

342 343
	* casefiddle.c (casify_region): Remove var that is set but not used.

344 345
	* dired.c (file_name_completion): Remove var that is set but not used.

346 347
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

348
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
349
	(Finsert_file_contents): Remove unnecessary code checking fd.
350

351 352 353
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

354 355 356
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

357 358
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
359
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
360
	(timer_check_2): Mark vars as initialized.
361

362 363
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

364
	* image.c (lookup_image): Remove var that is set but not used.
365
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
366

367 368 369
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

370
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
371
	if XCreateBitmapFromData fails (Bug#8410).
372

373 374 375
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

376
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
377
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
378

379 380
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
381 382 383
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
384

385 386 387
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

388 389
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

390 391 392 393 394 395 396
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

397 398 399
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

400 401
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
402
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
403 404 405 406 407 408 409 410
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
411 412
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
413

414 415 416 417 418
2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
	first non-nil return value).

419 420 421 422 423
2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
	if not defined (Bug#8403).

424 425 426 427 428 429 430 431 432 433 434 435
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (display_count_lines): Remove parameter `start',
	unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(get_char_face_and_encoding): Remove parameter `multibyte_p',
	unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
	(fill_stretch_glyph_string): Remove parameters `row' and `area',
	unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
	and thereabouts.  All callers changed.
	(get_per_char_metric): Remove parameter `f', unused since
	2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

436 437 438 439 440 441
2011-04-02  Jim Meyering  <meyering@redhat.com>

	do not dereference NULL upon failed strdup
	* nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
	(ns_get_family): Likewise.

442 443 444 445
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

446 447 448 449 450
2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
	later (Bug#8403).

451 452
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

453
	Add lexical binding.
454

455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
472 473 474

	* image.c (parse_image_spec): Use Ffunctionp.

475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492
	* fns.c (concat, mapcar1): Accept byte-code-functions.

	* eval.c (Fsetq): Handle lexical vars.
	(Fdefun, Fdefmacro, Ffunction): Make closures when needed.
	(Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
	(FletX, Flet): Obey lexical binding.
	(Fcommandp): Handle closures.
	(Feval): New `lexical' arg.
	(eval_sub): New function extracted from Feval.  Use it almost
	everywhere where Feval was used.  Look up vars in lexical env.
	Handle closures.
	(Ffunctionp): Move from subr.el.
	(Ffuncall): Handle closures.
	(apply_lambda): Remove `eval_flags'.
	(funcall_lambda): Handle closures and new byte-code-functions.
	(Fspecial_variable_p): New function.
	(syms_of_eval): Initialize the Vinternal_interpreter_environment var,
	but without exporting it to Lisp.
493 494

	* doc.c (Fdocumentation, store_function_docstring):
495
	* data.c (Finteractive_form): Handle closures.
496

497 498
	* callint.c (Fcall_interactively): Preserve lexical-binding mode for
	interactive spec.
499

500 501 502 503
	* bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
	byte-codes.
	(exec_byte_code): New function extracted from Fbyte_code to handle new
	calling convention for byte-code-functions.  Add new byte-codes.
504

505
	* buffer.c (defvar_per_buffer): Set new `declared_special' field.
506

507
	* alloc.c (Fmake_symbol): Init new `declared_special' field.
508

509 510 511 512
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (redisplay_internal): Fix prototype.

513
2011-03-31  Eli Zaretskii  <eliz@gnu.org>
514

515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531
	* xdisp.c (SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.  Limit
	scrolling to 100 screen lines.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

	(try_scrolling): When point is above the window, allow searching
	as far as scroll_max, or one screenful, to compute vertical
	distance from PT to the scroll margin position.  This prevents
	try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.  Clean up the case of PT below the margin at bottom
	of window: scroll_max can no longer be INT_MAX.  When aggressive
	scrolling is in use, don't let point enter the opposite scroll
	margin as result of the scroll.
	(syms_of_xdisp) <scroll-conservatively>: Document the
532 533
	threshold of 100 lines for never-recentering scrolling.

534 535 536 537 538 539 540 541 542 543 544 545 546 547
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (move_it_by_lines):
	* xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
	since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
	(message_log_check_duplicate): Remove parameters `prev_bol' and
	`this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(redisplay_internal): Remove parameter `preserve_echo_area',
	unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

	* indent.c (Fvertical_motion):
	* window.c (window_scroll_pixel_based, Frecenter):
	Don't pass `need_y_p' to `move_it_by_lines'.

548 549
2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

550 551 552 553 554
	* eval.c (struct backtrace): Don't cheat with negative numbers, but do
	steal a few bits to be more compact.
	(interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
	Remove unneeded casts.

555 556
	* bytecode.c (Fbyte_code): CAR and CDR can GC.

557 558 559 560 561
2011-03-30  Zachary Kanfer  <zkanfer@gmail.com>  (tiny change)

	* keyboard.c (Fexecute_extended_command): Do log the "suggest key
	binding" message (bug#7967).

562 563
2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>

564 565
	Fix more problems found by GCC 4.6.0's static checks.

566 567 568
	* unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
	Remove unused local var.

569 570
	* editfns.c (Fmessage_box): Remove unused local var.

571 572 573
	* xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Omit unused local vars.
574
	* window.c (shrink_windows): Omit unused local var.
575
	* menu.c (digest_single_submenu): Omit unused local var.
576 577 578
	* dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
	Omit unused local var.

579 580
	* keyboard.c (parse_modifiers_uncached, parse_modifiers):
	Don't assume string length fits in int.
581
	(keyremap_step, read_key_sequence): Use size_t for sizes.
582
	(read_key_sequence): Don't check last_real_key_start redundantly.
583

584 585 586
	* callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
	instead of alloca (Bug#8344).

587
	* eval.c (Fbacktrace): Don't assume nargs fits in int.
588
	(Fbacktrace_frame): Don't assume nframes fits in int.
589

590 591
	* syntax.c (scan_sexps_forward): Avoid pointer wraparound.

Paul Eggert's avatar
Paul Eggert committed
592 593 594 595 596 597
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

	* term.c (produce_glyphless_glyph): Remove unnecessary test.

	* cm.c (calccost): Turn while-do into do-while, for clarity.
598

599 600 601 602
	* keyboard.c (syms_of_keyboard): Use the same style as later
	in this function when indexing through an array.  This also
	works around GCC bug 48267.

603 604
	* image.c (tiff_load): Fix off-by-one image count (Bug#8336).

605 606
	* xselect.c (x_check_property_data): Return correct size (Bug#8335).

607 608 609
	* chartab.c (sub_char_table_ref_and_range): Redo for slight
	efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

610 611 612 613
	* keyboard.c, keyboard.h (num_input_events): Now size_t.
	This avoids undefined behavior on integer overflow, and is a bit
	more convenient anyway since it is compared to a size_t variable.

614 615 616 617 618
	Variadic C functions now count arguments with size_t, not int.
	This avoids an unnecessary limitation on 64-bit machines, which
	caused (substring ...) to crash on large vectors (Bug#8344).
	* lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
619
	All variadic functions and their callers changed accordingly.
620 621 622 623 624 625 626 627 628 629 630
	(struct gcpro.nvars): Now size_t, not int.  All uses changed.
	* data.c (arith_driver, float_arith_driver): Likewise.
	* editfns.c (general_insert_function): Likewise.
	* eval.c (struct backtrace.nargs, interactive_p)
	(internal_condition_case_n, run_hook_with_args, apply_lambda)
	(funcall_lambda, mark_backtrace): Likewise.
	* fns.c (concat): Likewise.
	* frame.c (x_set_frame_parameters): Likewise.
	* fns.c (get_key_arg): Now accepts and returns size_t, and returns
	0 if not found, not -1.  All callers changed.

631 632 633 634
	* alloc.c (garbage_collect): Don't assume stack size fits in int.
	(stack_copy_size): Now size_t, not int.
	(stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
	unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	All callers changed.

	* lisp.h (multibyte_char_to_unibyte):
	* character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
	unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	* character.h (CHAR_TO_BYTE8):
	* cmds.c (internal_self_insert):
	* editfns.c (general_insert_function):
	* keymap.c (push_key_description):
	* search.c (Freplace_match):
	* xdisp.c (message_dolog, set_message_1): All callers changed.

651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667
2011-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): New function.
	(safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
	don't set the hook to nil, but remove the offending function instead.
	(Qcommand_hook_internal): Remove, unused.
	(syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
	Vcommand_hook_internal.

	* eval.c (enum run_hooks_condition): Remove.
	(funcall_nil, funcall_not): New functions.
	(run_hook_with_args): Call each function through a `funcall' argument.
	Remove `cond' argument, now redundant.
	(Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
	(Frun_hook_with_args_until_failure): Adjust accordingly.
	(run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.

668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (string_buffer_position): Remove declaration.

	* print.c (strout): Remove parameter `multibyte', unused since
	1999-08-21T19:30:21Z!gerd@gnu.org.  All callers changed.

	* search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
	never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
	All callers changed.

	* w32.c (_wsa_errlist): Use braces for struct initializers.

	* xdisp.c (string_buffer_position_lim): Remove parameter `w',
	never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
	All callers changed.
	(string_buffer_position): Likewise.  Also, make static (it's never
	used outside xdisp.c).
	(cursor_row_p): Remove parameter `w', unused since
	2000-10-17T16:08:57Z!gerd@gnu.org.  All callers changed.
	(decode_mode_spec): Remove parameter `precision', introduced during
	Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
	All callers changed.

692 693 694 695
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.

696
2011-03-27  Anders Lindgren  <andlind@gmail.com>
697 698 699 700 701 702 703 704 705 706

	* nsterm.m (ns_menu_bar_is_hidden): New variable.
	(ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
	(ns_update_auto_hide_menu_bar): New functions.
	(ns_update_begin): Call ns_update_auto_hide_menu_bar.
	(applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
	ns_constrain_all_frames.
	(constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
	(syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.

707 708 709 710
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (runDialogAt): Remove argument to timer_check.

711 712 713 714 715 716 717 718 719
2011-03-27  Glenn Morris  <rgm@gnu.org>

	* syssignal.h: Replace RETSIGTYPE with void.
	* atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
	* keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
	Replace SIGTYPE with void everywhere.
	* s/usg5-4-common.h (SIGTYPE): Remove definition.
	* s/template.h (SIGTYPE): Remove commented out definition.

720 721 722 723 724
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

725 726
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

727 728 729 730 731 732 733
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

755 756 757 758 759
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

760 761 762 763 764 765 766 767
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

799 800 801 802 803
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

826 827 828 829 830 831 832 833 834 835 836 837 838 839 840
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
841
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
842 843
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
844
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
845

846 847
	Fix more problems found by GCC 4.5.2's static checks.

848 849 850 851
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

852 853 854
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
855
	of objects (Bug#8318).
856

857 858 859
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

860 861 862 863
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
864 865
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
866

867 868 869
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

870 871
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
872 873
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
874

Paul Eggert's avatar
Paul Eggert committed
875 876
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
877

Paul Eggert's avatar
Paul Eggert committed
878
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
879

880 881 882
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
883
	socklen_t is wider than int (Bug#8277).
884 885 886 887
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

888 889 890 891
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
892
	(Fmake_network_process): Define label "retry_connect" only if needed.
893
	(Fnetwork_interface_info): Fix pointer signedness.
894
	(process_send_signal): Add cast to avoid pointer signedness problem.
895
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
896
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
897

898
	Make tparam.h and terminfo.c consistent.
899 900
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.
	Include tparam.h instead, since it declares them.
901 902 903 904 905 906 907 908 909
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

910
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
911
	(xftfont_open): Rename locals to avoid shadowing.
912

913
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
914 915
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
916
	(ftfont_list): Remove unused local.
917 918 919
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
920

921 922
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
923 924
	* xml.c (make_dom): Now static.

925 926
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
927 928
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
929
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
930 931
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
932

933 934 935 936 937 938 939
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

940 941
	* textprop.c (property_change_between_p): Remove; unused.

942 943
	* intervals.c (interval_start_pos): Now static.

944 945
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

946 947
	* atimer.c (start_atimer, append_atimer_lists, set_alarm):
	Rename locals to avoid shadowing.
948

949 950
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
951
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
952 953
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
954

955 956
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

957 958
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
959 960
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
961 962
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
963

964 965 966 967
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

968
	* callproc.c (call_process_cleanup): Now static.
969
	(relocate_fd): Rename locals to avoid shadowing.
970

971 972 973 974 975
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

976 977 978 979
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

980 981 982 983 984 985
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

986 987 988 989 990 991
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

992 993 994 995 996
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

997 998 999 1000
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

1001 1002 1003 1004
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

1005 1006
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

1007 1008
	Fix more problems found by GCC 4.5.2's static checks.

1009 1010 1011
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

1012 1013 1014 1015 1016 1017 1018
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

1019 1020 1021
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

1022
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1023 1024 1025
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
1026

1027 1028
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
1029 1030
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
1031
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1032

1033 1034
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
1035
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
1036
	* unexec.h: New file.
1037 1038 1039 1040 1041 1042
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1043
	Change as necessary to match prototype in unexec.h.
1044

1045 1046
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
1047
	(back_comment, skip_chars): Mark vars as initialized.
1048

1049 1050 1051
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

1052
	* lread.c (read1): Rewrite so as not to use empty "else".
1053
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
1054

1055 1056
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

1057 1058 1059
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

1060 1061
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
1062
	(font_sort_entities): Mark var as initialized.
1063

1064 1065
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

1066 1067
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
1068
	(font_parse_fcname): Remove unused vars.
1069
	(font_delete_unmatched): Now static.
1070
	(font_get_spec): Remove; unused.
1071 1072 1073
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
1074

1075
	* fns.c (require_nesting_list, require_unwind): Now static.
1076
	(Ffillarray): Rename locals to avoid shadowing.
1077

1078
	* floatfns.c (domain_error2): Define only if needed.
1079
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
1080

1081 1082 1083
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

1084
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1085
	(Fdefvar): Rewrite so as not to use empty "else".
1086 1087
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
1088
	(Fdefvar): Rename locals to avoid shadowing.
1089

1090
	* callint.c (quotify_arg, quotify_args): Now static.
1091
	(Fcall_interactively): Rename locals to avoid shadowing.
1092
	Use const pointer when appropriate.
1093

1094 1095 1096 1097
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
1098 1099 1100
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
1101 1102 1103
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
1104
	(Ftranslate_region_internal): Mark var as initialized.
1105

1106 1107 1108
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

1109 1110 1111
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

1112 1113
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
1114
	(default_value, arithcompare, arith_driver, arith_error): Now static.
1115
	(store_symval_forwarding): Rename local to avoid shadowing.
1116 1117
	(Fmake_variable_buffer_local, Fmake_local_variable):
	Mark variables as initialized.
1118
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
1119

1120
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1121 1122
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
1123 1124
	(mark_stack): Move local variables into the #ifdef region where
	they're used.