ChangeLog 124 KB
Newer Older
1 2 3 4 5 6
2011-05-06  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.
	(LISP_H): Add inttypes.h and stdin.h.
	(PROCESS_H): Add unistd.h.

7 8 9 10 11
2011-05-06  Eli Zaretskii  <eliz@gnu.org>

	* lread.c: Include limits.h (fixes the MS-Windows build broken by
	2011-05-06T07:13:19Z!eggert@cs.ucla.edu).

Paul Eggert's avatar
Paul Eggert committed
12
2011-05-06  Paul Eggert  <eggert@cs.ucla.edu>
13

14 15
	* image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.

16 17 18
	* term.c (vfatal): Remove stray call to va_end.
	It's not needed and the C Standard doesn't allow it here anyway.

19 20 21
	Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
	* eval.c (verror): doprnt a copy of ap, not the original.  (Bug#8545)

22 23 24
	* eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
	bytes.

25 26
	* term.c: Don't include <stdarg.h>, as <lisp.h> does that.

27 28
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.

29 30
	* process.c (Fformat_network_address): Fix typo: args2 -> *args2.

31 32
	* xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).

33 34
	* coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).

35 36 37
	* charset.h (struct charset.code_space): Now has 15 elements, not 16.
	* charset.c (Fdefine_charset_internal): Don't initialize
	charset.code_space[15].  The value was garbage, on hosts with
Paul Eggert's avatar
Paul Eggert committed
38
	32-bit int (Bug#8600).
39 40 41 42 43 44 45

	* lread.c (read_integer): Be more consistent with string-to-number.
	Use string_to_number to do the actual conversion; this avoids
	rounding errors and fixes some other screwups.  Without this fix,
	for example, #x1fffffffffffffff was misread as -2305843009213693952.
	(digit_to_number): Move earlier, for benefit of read_integer.
	Return -1 if the digit is out of range for the base, -2 if it is
Paul Eggert's avatar
Paul Eggert committed
46
	not a digit in any supported base.  (Bug#8602)
47

48 49
	* doprnt.c (doprnt): Support arbitrary pI values, such as "I64".

50 51 52 53
	* dispnew.c (scrolling_window): Return 1 if we scrolled,
	to match comment at start of function.  This also removes a
	GCC warning about overflow in a 32+64-bit port.

54 55
	* lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.

56 57 58 59 60 61
	* dbusbind.c: Do not use XPNTR on a value that may be an integer.
	Reported by Stefan Monnier in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
	(xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
	SYMBOLP-guarded XSYMBOL, not XPNTR.

62 63 64
	* lisp.h (EMACS_INTPTR): Remove.  All uses changed to intptr_t.
	(EMACS_UINTPTR): Likewise, with uintptr_t.

65 66 67 68
	* lisp.h: Prefer 64-bit EMACS_INT if available.
	(EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
	on 32-bit hosts that have 64-bit int, so that they can access
	large files.
69 70
	However, temporarily disable this change unless the temporary
	symbol WIDE_EMACS_INT is defined.
71

72 73
	* lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.

74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
	Prefer intptr_t/uintptr_t for integers the same widths as pointers.
	This removes an assumption that EMACS_INT and long are the same
	width as pointers.  The assumption is true for Emacs porting targets
	now, but we want to make other targets possible.
	* lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
	(EMACS_INTPTR, EMACS_UINTPTR): New macros.
	In the rest of the code, change types of integers that hold casted
	pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
	replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
	(XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
	(XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
	No need to cast type when ORing.
	(XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
	* alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
	* doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
	assume EMACS_INT is the same width as char *.
	* gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
	(xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
	Remove no-longer-needed casts.
	(xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
	(xg_tool_bar_help_callback, xg_make_tool_item):
	Use EMACS_INTPTR to hold an integer
	that will be cast to void *; this can avoid a GCC warning
	if EMACS_INT is not the same width as void *.
	* menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
	* xdisp.c (display_echo_area_1, resize_mini_window_1):
	(current_message_1, set_message_1):
	Use a local to convert to proper width without a cast.
	* xmenu.c (dialog_selection_callback): Likewise.

104 105 106 107 108 109
	* sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
	Also, don't assume VALBITS / RAND_BITS is less than 5,
	and don't rely on undefined behavior when shifting a 1 left into
	the sign bit.
	* lisp.h (get_random): Change signature to match.

110 111 112 113 114 115 116 117
	* lread.c (hash_string): Use size_t, not int, for hash computation.
	Normally we prefer signed values; but hashing is special, because
	it's better to use unsigned division on hash table sizes so that
	the remainder is nonnegative.  Also, size_t is the natural width
	for hashing into memory.  The previous code used 'int', which doesn't
	retain enough info to hash well into very large tables.
	(oblookup, oblookup_last_bucket_number, Funintern): Likewise.

118 119 120 121 122
	* dbusbind.c: Don't possibly lose pointer info when converting.
	(xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
	Use XPNTR rather than XHASH, so that the high-order bits of
	the pointer aren't lost when converting through void *.

123 124
	* eval.c (Fautoload): Don't double-shift a pointer.

125 126
	* fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.

127 128 129 130 131
2011-05-06  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (DEF_GNUTLS_FN):
	* image.c (DEF_IMGLIB_FN): Make function pointers static.

132 133 134 135 136
2011-05-05  Andreas Schwab  <schwab@linux-m68k.org>

	* lread.c (lisp_file_lexically_bound_p): Stop scanning at end
	marker.  (Bug#8610)

137
2011-05-05 Eli Zaretskii  <eliz@gnu.org>
138 139 140 141

	* w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
	New version that can reserve upto 2GB of heap space.

142
2011-05-05  Chong Yidong  <cyd@stupidchicken.com>
143 144 145

	* nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).

146 147 148 149 150
2011-05-05  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
	`gnutls_certificate_set_x509_key_file'.

151 152 153 154 155
2011-05-05  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
	Update dependencies.

156 157 158 159 160 161 162
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
	* gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
	Remove unused parameter `fildes'.
	* process.c (read_process_output, send_process): Don't pass it.

163 164 165 166 167 168
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	Fix previous change: the library cache is defined in w32.c.
	* image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
	(Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	Implement dynamic loading of GnuTLS on Windows.

	* gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
	(emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
	(emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
	Declare.

	* gnutls.c (Qgnutls_dll): Define.
	(DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
	(gnutls_*): Declare function pointers.
	(init_gnutls_functions): New function to initialize function pointers.
	(emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
	(emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
	(emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
	Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
	(emacs_gnutls_write, emacs_gnutls_read)
	(emacs_gnutls_handle_error, Fgnutls_error_fatalp)
	(Fgnutls_available_p): New function.
	(Fgnutls_boot): Call Fgnutls_available_p.  Use function pointers.
	(syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
	(syms_of_gnutls) <Sgnutls_available_p>: defsubr it.

	* image.c: Include w32.h.
	(Vimage_type_cache): Delete.
	(syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
	(CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
	(w32_delayed_load): Move to w32.c.

	* w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.

	* w32.c (QCloaded_from, Vlibrary_cache): Define.
	(w32_delayed_load): Move from image.c.  When loading a library, record
	its filename in the :loaded-from property of the library id.
	(globals_of_w32) <QCloaded_from, Vlibrary_cache>:
	Initialize and staticpro them.
	(emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.

	* process.c: Include lisp.h before w32.h, not after.
	(wait_reading_process_output): Call emacs_gnutls_record_check_pending
	instead of gnutls_record_check_pending.

	* callproc.c, emacs.c: Include lisp.h before w32.h, not after.

214 215 216 217 218 219
2011-05-04  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
	instead of :keyfiles.  Give GnuTLS the keylist and the CRL lists
	as passed in.

220 221 222 223 224
2011-05-03  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_set_frame_alpha): Do not set property on anything
	else than FRAME_X_OUTER_WINDOW (Bug#8608).

225 226 227 228
2011-05-02  Juanma Barranquero  <lekktu@gmail.com>

	* sysdep.c (get_tty_size) [WINDOWSNT]: Implement.  (Bug#8596)

229 230 231 232 233 234 235 236 237 238 239 240
2011-05-02  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
	(Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
	(Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
	(gnutls_global_initialized, Qgnutls_bootprop_priority)
	(Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
	(Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
	(Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
	(Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
	(Qgnutls_bootprop_callbacks_verify): Make static.

241 242
2011-05-01  Andreas Schwab  <schwab@linux-m68k.org>

243 244
	* callproc.c: Indentation fixup.

245 246 247 248
	* sysdep.c (wait_for_termination_1): Make static.
	(wait_for_termination, interruptible_wait_for_termination): Move
	after wait_for_termination_1.

249 250 251 252 253 254 255 256 257 258
2011-05-01  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* sysdep.c (interruptible_wait_for_termination): New function
	which is like wait_for_termination, but allows keyboard
	interruptions.

	* callproc.c (Fcall_process): Add (:file "file") as an option for
	the STDOUT buffer.
	(Fcall_process_region): Ditto.

259 260
2011-04-30  Eli Zaretskii  <eliz@gnu.org>

261 262 263
	* dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
	rather than `XVECTOR (FOO)->size'.

264 265 266 267
	* process.c: Remove HAVE_INTTYPES_H condition from inclusion of
	inttypes.h, as a gnulib replacement is used if it not available in
	system headers.

268 269 270 271 272 273 274 275 276 277 278 279 280 281 282
2011-04-21  Eli Zaretskii  <eliz@gnu.org>

	Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
	* fileio.c (Finsert_file_contents): Don't limit file size to 1/4
	of MOST_POSITIVE_FIXNUM.  (Bug#8528)

	* coding.c (coding_alloc_by_realloc): Error out if destination
	will grow beyond MOST_POSITIVE_FIXNUM.
	(decode_coding_emacs_mule): Abort if there isn't enough place in
	charbuf for the composition carryover bytes.  Reserve an extra
	space for up to 2 characters produced in a loop.
	(decode_coding_iso_2022): Abort if there isn't enough place in
	charbuf for the composition carryover bytes.

2011-04-21  Eli Zaretskii  <eliz@gnu.org>
283

284 285 286 287 288
	* doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
	aborting when %lld or %lll format is passed.
	[!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
	%llo or %llx format is passed.  (Bug#8545)

289 290 291
	* window.c (window_scroll_line_based): Use a marker instead of
	simple variables to record original value of point.  (Bug#7952)

292 293 294
	* doprnt.c (doprnt): Fix the case where a multibyte sequence
	produced by %s or %c overflows available buffer space.  (Bug#8545)

295 296 297
2011-04-28  Paul Eggert  <eggert@cs.ucla.edu>

	* doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
298
	(SIZE_MAX): Move defn after all includes, as they might #define it.
299

300 301 302 303
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* w32.c (init_environment): Warn about defaulting HOME to C:\.

304 305 306 307 308 309 310 311
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (Qdelayed_warnings_hook): Define.
	(command_loop_1): Run `delayed-warnings-hook'
	if Vdelayed_warnings_list is non-nil.
	(syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
	(syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.

312 313 314 315 316
2011-04-28  Eli Zaretskii  <eliz@gnu.org>

	* doprnt.c (doprnt): Don't return value smaller than the buffer
	size if the message was truncated.  (Bug#8545).

317 318 319 320 321
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (Fx_change_window_property, Fx_delete_window_property)
	(Fx_window_property): #if-0 the whole functions, not just the bodies.

322 323 324 325
2011-04-27  Paul Eggert  <eggert@cs.ucla.edu>

	* doprnt.c (doprnt): Support "ll" length modifier, for long long.

326 327 328 329
2011-04-27  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

330 331 332 333 334 335 336 337 338 339 340 341 342
2011-04-27  Eli Zaretskii  <eliz@gnu.org>

	Improve `doprnt' and its usage.  (Bug#8545)
	* doprnt.c (doprnt): Make sure `format' is never accessed beyond
	`format_end'.  Remove support for %l as a conversion specifier.
	Don't use xrealloc.  Improve diagnostics when the %l size modifier
	is used.  Update the commentary.

	* eval.c (verror): Simplify calculation of size_t.

	* coding.c (Ffind_operation_coding_system): Fix diagnostic error
	messages.

343 344 345 346 347
2011-04-27  Yoshiaki Kasahara  <kasahara@nc.kyushu-u.ac.jp>  (tiny change)

	* buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
	change.

348 349 350 351 352
2011-04-27  Paul Eggert  <eggert@cs.ucla.edu>

	* nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
	This makes this file independent of the recent pseudovector change.

Paul Eggert's avatar
Paul Eggert committed
353
2011-04-26  Paul Eggert  <eggert@cs.ucla.edu>
354

355 356
	* keyboard.c (handle_user_signal): Fix pointer signedness problem.

Paul Eggert's avatar
Paul Eggert committed
357
	* gnutls.c (emacs_gnutls_handle_error): Remove unused local.
358
	(Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
Paul Eggert's avatar
Paul Eggert committed
359
	Remove unused local.
360
	(emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
361

Juanma Barranquero's avatar
Juanma Barranquero committed
362
	* lisp.h: Fix a problem with aliasing and vector headers.  (Bug#8546)
363 364 365 366 367 368 369
	GCC 4.6.0 optimizes based on type-based alias analysis.  For
	example, if b is of type struct buffer * and v of type struct
	Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
	!= &v->size, and therefore "v->size = 1; b->size = 2; return
	v->size;" must therefore return 1.  This assumption is incorrect
	for Emacs, since it type-puns struct Lisp_Vector * with many other
	types.  To fix this problem, this patch adds a new type struct
Paul Eggert's avatar
Paul Eggert committed
370
	vectorlike_header that documents the constraints on layout of vectors
371 372 373
	and pseudovectors, and helps optimizing compilers not get fooled
	by Emacs's type punning.  It also adds the macros XSETTYPED_PVECTYPE
	XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
Paul Eggert's avatar
Paul Eggert committed
374 375
	* lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
	the size member.
376 377 378 379 380
	(XSETPVECTYPE): Rewrite in terms of new macro.
	(XSETPVECTYPESIZE): New macro, specifying both type and size.
	This is a bit clearer, and further avoids the possibility of
	undesirable aliasing.
	(XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
Paul Eggert's avatar
Paul Eggert committed
381
	(XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
382 383
	(XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
	since Lisp_Subr is a special case (no "next" field).
Paul Eggert's avatar
Paul Eggert committed
384 385 386 387
	(ASIZE): Now uses header.size rather than size.  All
	previous uses of XVECTOR (foo)->size replaced to use this macro,
	to avoid the hassle of writing XVECTOR (foo)->header.size.
	(struct vectorlike_header): New type.
388 389 390 391 392 393 394
	(TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
	object, to help avoid aliasing.
	(PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
	(SUBRP): Likewise, since Lisp_Subr is a special case.
	* lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
	(struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
	(struct Lisp_Hash_Table): Combine first two members into a single
Paul Eggert's avatar
Paul Eggert committed
395
	struct vectorlike_header member.  All uses of "size" and "next" members
396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411
	changed to be "header.size" and "header.next".
	* buffer.h (struct buffer): Likewise.
	* font.h (struct font_spec, struct font_entity, struct font): Likewise.
	* frame.h (struct frame): Likewise.
	* process.h (struct Lisp_Process): Likewise.
	* termhooks.h (struct terminal): Likewise.
	* window.c (struct save_window_data, struct saved_window): Likewise.
	* window.h (struct window): Likewise.
	* alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
	Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
	* buffer.c (init_buffer_once): Likewise.
	* lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
	special case.
	* process.c (Fformat_network_address): Use local var for size,
	for brevity.

412 413
	* bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.

Paul Eggert's avatar
Paul Eggert committed
414
	Make the Lisp reader and string-to-float more consistent (Bug#8525)
415 416 417 418 419 420 421 422 423 424
	* data.c (atof): Remove decl; no longer used or needed.
	(digit_to_number): Move to lread.c.
	(Fstring_to_number): Use new string_to_number function, to be
	consistent with how the Lisp reader treats infinities and NaNs.
	Do not assume that floating-point numbers represent EMACS_INT
	without losing information; this is not true on most 64-bit hosts.
	Avoid double-rounding errors, by insisting on integers when
	parsing non-base-10 numbers, as the documentation specifies.
	* lisp.h (string_to_number): New decl, replacing ...
	(isfloat_string): Remove.
425
	* lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
426
	(read1): Do not accept +. and -. as integers; this
427 428 429 430 431 432 433 434 435 436 437 438 439
	appears to have been a coding error.  Similarly, do not accept
	strings like +-1e0 as floating point numbers.  Do not report
	overflow for integer overflows unless the base is not 10 which
	means we have no simple and reliable way to continue.
	Break out the floating-point parsing into a new
	function string_to_number, so that Fstring_to_number parses
	floating point numbers consistently with the Lisp reader.
	(digit_to_number): Moved here from data.c.  Make it static inline.
	(E_CHAR, EXP_INT): Remove, replacing with ...
	(E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
	(string_to_number): New function, replacing isfloat_string.
	This function checks for valid syntax and produces the resulting
	Lisp float number too.  Rework it so that string-to-number
440
	no longer mishandles examples like "1.0e+".  Use strtoumax,
441 442
	so that overflow for non-base-10 numbers is reported only when
	there's no portable and simple way to convert to floating point.
443

444 445 446
	* textprop.c (set_text_properties_1): Rewrite for clarity,
	and to avoid GCC warning about integer overflow.

447 448 449 450 451 452
	* intervals.h (struct interval): Use EMACS_INT for members
	where EMACS_UINT might cause problems.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
	(CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
	* intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
	All uses changed.
453 454
	(offset_intervals): Tell GCC not to worry about length overflow
	when negating a negative length.
455

456 457 458
	* alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
	(overrun_check_free): Likewise.

459 460 461 462
	* alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
	in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
	word size.

463 464 465 466 467 468
	* gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(gnutls_make_error): Rename local to avoid shadowing.
	(gnutls_emacs_global_deinit): ifdef out; not used.
	(Fgnutls_boot): Use const for pointer to readonly storage.
	Comment out unused local.  Fix pointer signedness problems.

469 470 471 472
	* lread.c (openp): Don't stuff size_t into an 'int'.
	Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
	about possible signed overflow.

473 474 475 476 477
	* gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(GDK_KEY_g): Don't define if already defined.
	(xg_prepare_tooltip): Avoid pointer signedness problem.
	(xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.

478 479 480
	* process.c (Fnetwork_interface_info): Avoid left-shift undefined
	behavior with 1 << 31.  GCC 4.6.0 warns about this on 32-bit hosts.

481 482 483 484
	* xfns.c (Fx_window_property): Simplify a bit,
	to make a bit faster and to avoid GCC 4.6.0 warning.
	* xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.

485 486
	* fns.c (internal_equal): Don't assume size_t fits in int.

487 488
	* alloc.c (compact_small_strings): Tighten assertion a little.

489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
	Replace pEd with more-general pI, and fix some printf arg casts.
	* lisp.h (pI): New macro, generalizing old pEd macro to other
	conversion specifiers.  For example, use "...%"pI"d..." rather
	than "...%"pEd"...".
	(pEd): Remove.  All uses replaced with similar uses of pI.
	* src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
	* alloc.c (check_pure_size): Don't overflow by converting size to int.
	* bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
	* data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
	* dbusbind.c (xd_append_arg): Use pI to avoid cast.
	(Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
	* font.c (font_unparse_xlfd): Avoid potential buffer overrun on
	64-bit hosts.
	(font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
	* keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
	* print.c (safe_debug_print, print_object): Likewise.
	(print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
	to int.
507 508
	Use pI instead of if-then-else-abort.  Use %p to avoid casts,
	avoiding the 0 flag, which is not portable.
509 510 511 512 513
	* process.c (Fmake_network_process): Use pI to avoid cast.
	* region-cache.c (pp_cache): Likewise.
	* xdisp.c (decode_mode_spec): Likewise.
	* xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
	behavior on 64-bit hosts with printf arg.
514
	* xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
515 516 517
	(x_stop_queuing_selection_requests): Likewise.
	(x_get_window_property): Don't truncate byte count to an 'int'
	when tracing.
518

519 520 521 522 523
	* frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
	here, since it parses constructs like leading '-' and spaces,
	which are not wanted; and it overflows with large numbers.
	Instead, simply match F[0-9]+, which is what is wanted anyway.

524 525 526 527 528 529 530 531 532
	* alloc.c: Remove unportable assumptions about struct layout.
	(SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
	(SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
	(allocate_vectorlike, make_pure_vector): Use the new macros,
	plus offsetof, to remove unportable assumptions about struct layout.
	These assumptions hold on all porting targets that I know of, but
	they are not guaranteed, they're easy to remove, and removing them
	makes further changes easier.

533 534
	* alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
	This doesn't fix a bug but makes the code clearer.
535 536
	(string_overrun_cookie): Now const.  Use initializers that
	don't formally overflow signed char, to avoid warnings.
537 538
	(allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
	can cause Emacs to crash when string overrun checking is enabled.
539 540 541
	(allocate_buffer): Don't assume sizeof (struct buffer) is a
	multiple of sizeof (EMACS_INT); it need not be, if
	alignof(EMACS_INT) < sizeof (EMACS_INT).
542
	(check_sblock, check_string_bytes, check_string_free_list): Protoize.
543

544 545 546 547
2011-04-26  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (QCrtl): Rename from Qrtl.  All uses changed.

548 549 550
2011-04-26  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (emacs_gnutls_handshake): Return an error if we're not
Paul Eggert's avatar
Paul Eggert committed
551
	supposed to be handshaking.  (Bug#8556)
552 553
	Reported by Paul Eggert <eggert@cs.ucla.edu>.

Juanma Barranquero's avatar
Juanma Barranquero committed
554
2011-04-26  Daniel Colascione  <dan.colascione@gmail.com>
Daniel Colascione's avatar
Daniel Colascione committed
555 556

	* lisp.h (Qdebug): List symbol.
557
	* eval.c (Qdebug): Restore global linkage.
Daniel Colascione's avatar
Daniel Colascione committed
558 559 560 561
	* keyboard.c (debug-on-event): New variable.
	(handle_user_signal): Break into debugger when debug-on-event
	matches the current signal symbol.

562 563 564 565 566
2011-04-25  Dan Nicolaescu  <dann@ics.uci.edu>

	* alloc.c (check_sblock, check_string_bytes)
	(check_string_free_list): Convert to standard C.

Ted Zlatanov's avatar
Ted Zlatanov committed
567 568 569 570
2011-04-25  Teodor Zlatanov  <tzz@lifelogs.com>

	* w32.c (emacs_gnutls_push): Fix typo.

571 572
2011-04-25  Eli Zaretskii  <eliz@gnu.org>

573 574 575
	* gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
	"cast to pointer from integer of different size".

576 577 578 579 580 581 582 583 584
	Improve doprnt and its use in verror.  (Bug#8545)
	* doprnt.c (doprnt): Document the set of format control sequences
	supported by the function.  Use SAFE_ALLOCA instead of always
	using `alloca'.

	* eval.c (verror): Don't limit the buffer size at size_max-1, that
	is one byte too soon.  Don't use xrealloc; instead xfree and
	xmalloc anew.

585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
2011-04-24  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
	callbacks stage.

	* gnutls.c: Renamed global_initialized to
	gnutls_global_initialized.  Added internals for the
	:verify-hostname-error, :verify-error, and :verify-flags
	parameters of `gnutls-boot' and documented those parameters in the
	docstring.  Start callback support.
	(emacs_gnutls_handshake): Add Woe32 support. Retry handshake
	unless a fatal error occured. Call gnutls_alert_send_appropriate
	on error. Return error code.
	(emacs_gnutls_write): Call emacs_gnutls_handle_error.
	(emacs_gnutls_read): Likewise.
	(Fgnutls_boot): Return handshake error code.
	(emacs_gnutls_handle_error): New function.
	(wsaerror_to_errno): Likewise.

	* w32.h (emacs_gnutls_pull): Add prototype.
	(emacs_gnutls_push): Likewise.

	* w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
	(emacs_gnutls_push): Likewise.

2011-04-24  Claudio Bley  <claudio.bley@gmail.com>  (tiny change)

	* process.c (wait_reading_process_output): Check if GnuTLS
	buffered some data internally if no FDs are set for TLS
	connections.

	* makefile.w32-in (OBJ2): Add gnutls.$(O).
	(LIBS): Link to USER_LIBS.
	($(BLD)/gnutls.$(0)): New target.

620 621
2011-04-24  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
622 623 624 625 626
	* xdisp.c (handle_single_display_spec): Rename the
	display_replaced_before_p argument into display_replaced_p, to
	make it consistent with the commentary.  Fix typos in the
	commentary.

627 628 629 630 631
	* textprop.c (syms_of_textprop): Remove dead code.
	(copy_text_properties): Delete obsolete commentary about an
	interface that was deleted long ago.  Fix typos in the description
	of arguments.

632 633 634 635 636 637 638 639 640 641 642 643 644 645 646
	* msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
	to changes in oldXMenu/XMenu.h from 2011-04-16.
	<menu_help_message, prev_menu_help_message>: Constify.
	(IT_menu_make_room): menu->help_text is now `const char **';
	adjust.

	* msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
	to changes in oldXMenu/XMenu.h from 2011-04-16.
	(struct XMenu): Declare `help_text' `const char **'.

	* xfaces.c <Qunspecified>: Make extern again.

	* syntax.c: Include sys/types.h before including regex.h, as
	required by Posix.

647 648 649 650 651 652 653 654 655
	* doc.c (get_doc_string): Improve the format passed to `error'.

	* doprnt.c (doprnt): Improve commentary.

	* term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.

	* Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
	them with etags.

656 657
	* makefile.w32-in (globals.h): Add a dummy recipe, to make any
	changes in globals.h immediately force recompilation.
658 659 660
	(TAGS): Depend on $(CURDIR)/m/intel386.h and
	$(CURDIR)/s/ms-w32.h.
	(TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
661

662 663 664 665
	* character.c (Fchar_direction): Function deleted.
	(syms_of_character): Don't defsubr it.
	<char-direction-table>: Deleted.

666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713
2011-04-23  Eli Zaretskii  <eliz@gnu.org>

	Fix doprnt so it could be used again safely in `verror'.  (Bug#8435)
	* doprnt.c: Include limits.h.
	(SIZE_MAX): New macro.
	(doprnt): Return a size_t value.  2nd arg is now size_t.  Many
	local variables are now size_t instead of int or unsigned.
	Improve overflow protection.  Support `l' modifier for integer
	conversions.  Support %l conversion.  Don't assume an EMACS_INT
	argument for integer conversions and for %c.

	* lisp.h (doprnt): Restore prototype.

	* makefile.w32-in ($(BLD)/callint.$(O)): Depend on
	$(SRC)/character.h.

	* Makefile.in (base_obj): Add back doprnt.o.

	* deps.mk (doprnt.o): Add back prerequisites.
	(callint.o): Depend on character.h.

	* eval.c (internal_lisp_condition_case): Include the handler
	representation in the error message.
	(verror): Call doprnt instead of vsnprintf.  Fix an off-by-one bug
	when breaking from the loop.

	* xdisp.c (vmessage): Call doprnt instead of vsnprintf.

	* callint.c (Fcall_interactively): When displaying error message
	about invalid control letter, pass the character's codepoint, not
	a pointer to its multibyte form.  Improve display of the character
	in octal and display also its hex code.

	* character.c (char_string): Use %x to display the (unsigned)
	codepoint of an invalid character, to avoid displaying a bogus
	negative value.

	* font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
	`error', not SYMBOL_NAME itself.

	* coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
	character arguments to `error'.

	* charset.c (check_iso_charset_parameter): Fix incorrect argument
	to `error' in error message about FINAL_CHAR argument.  Make sure
	FINAL_CHAR is a character, and use %c when it is passed as
	argument to `error'.

714
2011-04-23  Eli Zaretskii  <eliz@gnu.org>
715 716 717 718 719 720

	* s/ms-w32.h (localtime): Redirect to sys_localtime.

	* w32.c: Include <time.h>.
	(sys_localtime): New function.

721
2011-04-23  Chong Yidong  <cyd@stupidchicken.com>
722 723 724

	* xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).

725
	* buffer.c (syms_of_buffer): Doc fix (Bug#6902).
726

727
2011-04-23  Samuel Thibault  <sthibault@debian.org>  (tiny change)
728

729 730
	* sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
	zombies (Bug#8467).
731

732 733 734 735 736 737 738 739
2011-04-19  Eli Zaretskii  <eliz@gnu.org>

	* syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
	gl_state.e_property when gl_state.object is Qt.

	* insdel.c (make_gap_larger): Remove limitation of buffer size
	to <= INT_MAX.

740 741 742 743 744 745 746 747 748 749
2011-04-18  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (lookup_glyphless_char_display)
	(produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.
	(Vglyphless_char_display): Document it.

	* term.c (produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.

Chong Yidong's avatar
Chong Yidong committed
750 751 752 753 754 755 756 757 758
2011-04-17  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (get_next_display_element): Remove unnecessary ifdefs.

	* termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.

	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
	definition for no-X builds.

759
2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>
760

761 762
	Static checks with GCC 4.6.0 and non-default toolkits.

763 764
	* s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.

765 766 767 768
	* process.c (keyboard_bit_set): Define only if SIGIO.
	(send_process_trap): Mark it with NO_RETURN if it doesn't return.
	(send_process): Repair possible setjmp clobbering.

769 770
	* s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.

771 772
	* eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.

773 774
	* data.c (arith_error): Mark with NO_RETURN if it doesn't return.

775 776 777
	* alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
	Define only if needed.

778 779
	* sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
	by pacifying GCC about it.  Maybe it's time to retire it?
780
	* xfaces.c (USG, __TIMEVAL__): Likewise.
781

782 783
	* dispextern.h (struct redisplay_interface): Rename param
	to avoid shadowing.
784
	* termhooks.h (struct terminal): Likewise.
785
	* xterm.c (xembed_send_message): Likewise.
786

787 788 789
	* insdel.c (make_gap_smaller): Define only if
	USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.

790 791 792
	* keyboard.c (read_char): Make a var volatile so longjmp won't clobber
	it.

793 794 795
	* emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
	so that we aren't warned about unused symbols.

796 797
	* xfns.c (Fx_file_dialog): Rename local to avoid shadowing.

798
	* xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
799

800 801
	* xfns.c (x_real_positions): Mark locals as initialized.

802 803
	* xmenu.c (xmenu_show): Don't use uninitialized vars.

804 805
	* xterm.c: Fix problems found by static analysis with other toolkits.
	(toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
806 807
	(x_dispatch_event): Declare static if USE_GTK, and
	define if USE_GTK || USE_X_TOOLKIT.
808
	(SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
809
	* xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
Juanma Barranquero's avatar
Juanma Barranquero committed
810 811
	* xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
	if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
812

813 814 815 816 817 818
	* xmenu.c (menu_help_callback): Pointer type fixes.
	Use const pointers when pointing at readonly data.  Avoid pointer
	signedness clashes.
	(FALSE): Remove unused macro.
	(update_frame_menubar): Remove unused decl.

819 820
	* xfns.c (Fx_hide_tip): Move locals to avoid shadowing.

821 822 823 824
	* menu.c (push_submenu_start, push_submenu_end): Do not define unless
	USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
	(single_menu_item): Rename local to avoid shadowing.

825 826
	* keyboard.c (make_lispy_event): Remove unused local var.

827 828 829
	* frame.c, frame.h (x_get_resource_string): Bring this back, but
	only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.

830 831 832 833 834
	* bitmaps: Change bitmaps from unsigned char back to the X11
	compatible char.  Avoid the old compiler warnings about
	out-of-range initializers by using, for example, '\xab' rather
	than 0xab.

835 836 837
	* xgselect.c (xgselect_initialize): Check vs interface
	even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).

838 839
	* xmenu.c (xmenu_show): Rename parm to avoid shadowing.

840 841 842
	* xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
	to read-only memory.

843 844
	* fns.c (vector): Remove; this old hack is no longer needed.

845
	* xsmfns.c (create_client_leader_window): Rename shadowing arg.
Paul Eggert's avatar
Paul Eggert committed
846
	Remove unused var.
847
	(gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
848

849
	* xrdb.c (x_load_resources): Omit unused local.
850

851
	* xfns.c (free_frame_menubar, atof): Remove duplicate decls.
852
	(x_window): Rename locals to avoid shadowing.
853
	(USG): Use the kludged USG macro, to pacify gcc.
854

855
	* xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
856
	(x_term_init): Remove local to avoid shadowing.
857

858
	* xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
859 860 861 862

	* xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
	USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.

863 864
2011-04-16  Eli Zaretskii  <eliz@gnu.org>

865 866
	* gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.

867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898
	Fix regex.c, syntax.c and friends for buffers > 2GB.
	* syntax.h (struct gl_state_s): Declare character position members
	EMACS_INT.

	* syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.

	* textprop.c (verify_interval_modification, interval_of): Declare
	arguments EMACS_INT.

	* intervals.c (adjust_intervals_for_insertion): Declare arguments
	EMACS_INT.

	* intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.

	* indent.c (Fvertical_motion): Local variable it_start is now
	EMACS_INT.

	* regex.c (re_match, re_match_2, re_match_2_internal)
	(bcmp_translate, regcomp, regexec, print_double_string)
	(group_in_compile_stack, re_search, re_search_2, regex_compile)
	(re_compile_pattern, re_exec): Declare arguments and local
	variables `size_t' and `ssize_t' and return values `regoff_t', as
	appropriate.
	(POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
	(CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
	<compile_stack_type>: `size' and `avail' are now `size_t'.

	* regex.h <regoff_t>: Use ssize_t, not int.
	(re_search, re_search_2, re_match, re_match_2): Arguments that
	specify buffer/string position and length are now ssize_t and
	size_t.  Return type is regoff_t.

899 900 901 902 903 904 905 906 907 908
2011-04-16  Ben Key  <bkey76@gmail.com>

	* nsfont.m: Fixed bugs in ns_get_family and
	ns_descriptor_to_entity that were caused by using free to
	deallocate memory blocks that were allocated by xmalloc (via
	xstrdup).  This caused Emacs to crash when compiled with
	XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
	--enable-checking=xmallocoverrun).  xfree is now used to
	deallocate these memory blocks.

Paul Eggert's avatar
Paul Eggert committed
909
2011-04-15  Paul Eggert  <eggert@cs.ucla.edu>
910

911 912
	* sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.

913 914 915 916 917 918 919 920
	emacs_write: Accept and return EMACS_INT for sizes.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
	et seq.
	* gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
	Accept and return EMACS_INT.
	(emacs_gnutls_write): Return the number of bytes written on
	partial writes.
	* sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
921 922
	(emacs_read, emacs_write): Remove check for negative size, as the
	Emacs source code has been audited now.
923 924
	* sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
	(emacs_read, emacs_write): Use it.
925 926 927
	* process.c (send_process): Adjust to the new signatures of
	emacs_write and emacs_gnutls_write.  Do not attempt to store
	a byte offset into an 'int'; it might overflow.
928
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
929

930 931
	* sound.c: Don't assume sizes fit in 'int'.
	(struct sound_device.period_size, alsa_period_size):
932
	Return EMACS_INT, not int.
933
	(struct sound_device.write, vox_write, alsa_write):
934 935
	Accept EMACS_INT, not int.
	(wav_play, au_play): Use EMACS_INT to store sizes and to
936 937
	record read return values.

938 939
2011-04-15  Ben Key  <bkey76@gmail.com>

940 941 942 943
	* keyboard.c (Qundefined): Don't declare static since it is used
	in nsfns.m.
	* xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
	static since they are used in nsfont.m.
944

945 946 947 948 949
2011-04-15  Stefan Monnier  <monnier@iro.umontreal.ca>

	* process.c (Qprocessp): Don't declare static.
	* lisp.h (Qprocessp): Declare again.

950 951 952 953
2011-04-15  Juanma Barranquero  <lekktu@gmail.com>

	* font.c (Qopentype): Don't make static (used from w32uniscribe.c).

954 955
2011-04-14  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
956
	Improve C-level modularity by making more things 'static'.
957

958 959 960 961 962 963 964 965
	Don't publish debugger-only interfaces to other modules.
	* lisp.h (safe_debug_print, debug_output_compilation_hack):
	(verify_bytepos, count_markers): Move decls to the only modules
	that need them.
	* region-cache.h (pp_cache): Likewise.
	* window.h (check_all_windows): Likewise.
	* marker.c, print.c, region-cache.c, window.c: Decls moved here.

966 967 968
	* sysdep.c (croak): Now static, if
	defined TIOCNOTTY || defined USG5 || defined CYGWIN.
	* syssignal.h (croak): Declare only if not static.
969 970 971 972

	* alloc.c (refill_memory_reserve): Now static if
	!defined REL_ALLOC || defined SYSTEM_MALLOC.
	* lisp.h (refill_memory_reserve): Declare only if not static.
973

974 975 976
	* xsettings.c, xsettings.h (xsettings_get_system_normal_font):
	Define only if USE_LUCID.

977 978
	* xrdb.c (x_customization_string, x_rm_string): Now static.

979 980 981
	* xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
	* xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.

982 983 984
	* xdisp.c (draw_row_with_mouse_face): Now static.
	* dispextern.h (draw_row_with_mouse_fave): Remove decl.

985 986
	* window.h (check_all_windows): Mark externally visible.

987 988 989 990 991 992
	* window.c (window_deletion_count): Now static.

	* undo.c: Make symbols static if they're not exported.
	(last_undo_buffer, last_boundary_position, pending_boundary):
	Now static.

993 994 995
	* textprop.c (interval_insert_behind_hooks): Now static.
	(interval_insert_in_front_hooks): Likewise.

996 997 998 999 1000 1001 1002
	* term.c: Make symbols static if they're not exported.
	(tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
	(max_frame_lines, tty_set_terminal_modes):
	(tty_reset_terminal_modes, tty_turn_off_highlight):
	(get_tty_terminal): Now static.
	(term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
	* termhooks.h (term_mouse_moveto): Do not declare if
Paul Eggert's avatar
Paul Eggert committed
1003
	HAVE_WINDOW_SYSTEM.
1004 1005 1006
	* dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
	(tty_turn_off_highlight, get_tty_terminal): Remove decls.

1007 1008 1009 1010 1011 1012 1013 1014
	* sysdep.c: Make symbols static if they're not exported.
	(emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
	Now static.
	(sigprocmask_set, full_mask): Remove; unused.
	(wait_debugging): Mark as visible.
	* syssignal.h (SIGFULLMASK, full_mask): Remove decls.
	* systty.h (emacs_get_tty, emacs_set_tty): Remove decls.

1015 1016
	* syntax.c (syntax_temp): Define only if !__GNUC__.

1017 1018
	* sound.c (current_sound_device, current_sound): Now static.

1019 1020
	* search.c (searchbufs, searchbuf_head): Now static.

1021 1022 1023
	* scroll.c (scroll_cost): Remove; unused.
	* dispextern.h (scroll_cost): Remove decl.

1024 1025
	* region-cache.h (pp_cache): Mark as externally visible.

1026 1027 1028 1029 1030 1031 1032 1033
	* process.c: Make symbols static if they're not exported.
	(process_tick, update_tick, create_process, chan_process):
	(Vprocess_alist, proc_buffered_char, datagram_access):
	(fd_callback_data, send_process_frame, process_sent_to): Now static.
	(deactivate_process): Mark defn as static, as well as decl.
	* lisp.h (create_process): Remove decl.
	* process.h (chan_process, Vprocess_alist): Remove decls.

1034 1035 1036 1037 1038 1039 1040 1041
	* print.c: Make symbols static if they're not exported.
	(print_depth, new_backquote_output, being_printed, print_buffer):
	(print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
	(print_interval, print_number_index, initial_stderr_stream):
	Now static.
	* lisp.h (Fprinc): Remove decl.
	(debug_output_compilation_hack): Mark as externally visible.

1042 1043 1044 1045
	* sysdep.c (croak): Move decl from here to syssignal.h.
	* syssignal.h (croak): Put it here, so the API can be checked when
	'croak' is called from dissociate_if_controlling_tty.

1046 1047 1048 1049
	* minibuf.c: Make symbols static if they're not exported.
	(minibuf_save_list, choose_minibuf_frame): Now static.
	* lisp.h (choose_minibuf_frame): Remove decl.

1050 1051
	* lisp.h (verify_bytepos, count_markers): Mark as externally visible.

1052 1053 1054 1055 1056 1057
	* lread.c: Make symbols static if they're not exported.
	(read_objects, initial_obarray, oblookup_last_bucket_number):
	Now static.
	(make_symbol): Remove; unused.
	* lisp.h (initial_obarray, make_symbol): Remove decls.

1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080
	* keyboard.c: Make symbols static if they're not exported.
	(single_kboard, recent_keys_index, total_keys, recent_keys):
	(this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
	(this_single_command_key_start, echoing, last_auto_save):
	(read_key_sequence_cmd, dribble, recursive_edit_unwind):
	(command_loop, echo_now, keyboard_init_hook, help_char_p):
	(quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
	(Vlispy_mouse_stem, double_click_count):
	Now static.
	(force_auto_save_soon): Define only if SIGDANGER.
	(ignore_mouse_drag_p): Now static if
	!defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
	(print_help): Remove; unused.
	(stop_character, last_timer_event): Mark as externally visible.
	* keyboard.h (ignore_mouse_drag_p): Declare only if
	defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
	(echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
	* lisp.h (echoing): Remove decl.
	(force_auto_save_soon): Declare only if SIGDANGER.
	* xdisp.c (redisplay_window): Simplify code, to make it more
	obvious that ignore_mouse_drag_p is not accessed if !defined
	USE_GTK && !defined HAVE_NS.

1081 1082 1083 1084 1085
	* intervals.c: Make symbols static if they're not exported.
	(merge_properties_sticky, merge_interval_right, delete_interval):
	Now static.
	* intervals.h (merge_interval_right, delete_interval): Remove decls.

1086 1087 1088 1089
	* insdel.c: Make symbols static if they're not exported.
	However, leave prepare_to_modify_buffer alone.  It's never
	called from outside this function, but that appears to be a bug.
	(combine_after_change_list, combine_after_change_buffer):
1090
	(adjust_after_replace, signal_before_change): Now static.
1091 1092
	(adjust_after_replace_noundo): Remove; unused.
	* lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1093
	(signal_before_change): Remove decls.
1094

1095 1096
	* indent.c (val_compute_motion, val_vmotion): Now static.

1097 1098 1099 1100 1101 1102
	* image.c: Make symbols static if they're not exported.
	* dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
	if USE_GTK.
	* image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
	(xpm_color_cache, ct_table, ct_colors_allocated): Now static.

1103 1104 1105
	* fringe.c (standard_bitmaps): Now static.
	(max_used_fringe_bitmap): Now static, unless HAVE_NS.

1106 1107 1108 1109 1110 1111 1112 1113 1114 1115
	* frame.c: Make symbols static if they're not exported.
	(x_report_frame_params, make_terminal_frame): Now static.
	(get_frame_param): Now static, unless HAVE_NS.
	(x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
	(x_get_resource_string): Remove; not used.
	* frame.h (make_terminal_frame, x_report_frame_params):
	(x_get_resource_string); Remove decls.
	(x_fullscreen_adjust): Declare only if WINDOWSNT.
	* lisp.h (get_frame_param): Declare only if HAVE_NS.

1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
	* font.c, fontset.c: Make symbols static if they're not exported.
	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
	(FACE_SUITABLE_FOR_CHAR_P): Use it.
	* font.c (font_close_object): Now static.
	* font.h (font_close_object): Remove.
	* fontset.c (FONTSET_OBJLIST): Remove.
	(free_realized_fontset) #if-0 the body, which does nothing.
	(face_suitable_for_char_p): #if-0, as it's never called.
	* fontset.h (face_suitable_for_char_p): Remove decl.
	* xfaces.c (face_at_string_position): Use
	FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
	since 0 is always ASCII.

1129 1130
	* fns.c (weak_hash_tables): Now static.

1131 1132 1133 1134
	* fileio.c: Make symbols static if they're not exported.
	(auto_saving, auto_save_mode_bits, auto_save_error_occurred):
	(Vwrite_region_annotation_buffers): Now static.

1135 1136 1137 1138
	* eval.c: Make symbols static if they're not exported.
	(backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
	* lisp.h (backtrace_list): Remove decl.

1139 1140 1141 1142 1143 1144 1145 1146 1147 1148
	* emacs.c: Make symbols static if they're not exported.
	(malloc_state_ptr, malloc_using_checking, syms_of_emacs):
	(fatal_error_code, fatal_error_signal_hook, standard_args):
	Now static.
	(fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
	(DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
	(__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
	* lisp.h (fatal_error_signal_hook): Remove decl.
	(fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.

1149 1150 1151 1152 1153
	* editfns.c: Move a (normally-unused) function to its only use.
	* editfns.c, lisp.h (get_operating_system_release): Remove.
	* process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
	worth the hassle of breaking this out.

1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169
	* xterm.c: Make symbols static if they're not exported.
	(x_raise_frame, x_lower_frame, x_wm_set_window_state):
	(x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
	(x_destroy_window, x_delete_display):
	Now static.
	(x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
	(x_mouse_leave): Remove; unused.
	* xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
	(x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
	(x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
	Remove decls.
	(x_mouse_leave): Declare only if WINDOWSNT.
	(x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
	(xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
	USE_X_TOOLKIT.

1170 1171 1172 1173 1174
	* ftxfont.c: Make symbols static if they're not exported.
	(ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
	HAVE_FREETYPE.
	* font.h (ftxfont_driver): Likewise.

1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
	* xfns.c: Make symbols static if they're not exported.
	(x_last_font_name, x_display_info_for_name):
	(x_set_foreground_color, x_set_background_color, x_set_mouse_color):
	(x_set_cursor_color, x_set_border_pixel, x_set_border_color):
	(x_set_cursor_type, x_set_icon_type, x_set_icon_name):
	(x_set_scroll_bar_foreground, x_set_scroll_bar_background):
	(x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
	(last_show_tip_args): Now static.
	(xic_defaut_fontset, xic_create_fontsetname): Define only if
	defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
	(x_screen_planes): Remove; unused.
	* dispextern.h (x_screen_planes): Remove decl.

1188 1189 1190 1191 1192 1193 1194 1195
	* dispnew.c: Make symbols static if they're not exported.
	* dispextern.h (redraw_garbaged_frames, scrolling):
	(increment_row_positions): Remove.
	* dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
	(delayed_size_change, glyph_matrix_count, glyph_pool_count):
	Now static.
	(redraw_garbaged_frames): Remove; unused.

1196 1197 1198 1199 1200 1201 1202 1203 1204 1205
	* xfaces.c: Make symbols static if they're not exported.
	* dispextern.h (ascii_face_of_lisp_face, free_realized_face):
	Remove decls.
	* xterm.h (defined_color): Remove decls.
	(x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
	* xfaces.c (tty_suppress_bold_inverse_default_colors_p):
	(menu_face_changed_default, defined_color, free_realized_face):
	(x_free_dpy_colors): Define only if USE_X_TOOLKIT.
	(ascii_face_of_lisp_face): Remove; unused.

1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223
	* xdisp.c: Make symbols static if they're not exported.
	* dispextern.h (scratch_glyph_row, window_box_edges):
	(glyph_to_pixel_coords, set_cursor_from_row):
	(get_next_display_element, set_iterator_to_next):
	(highlight_trailing_whitespace, frame_to_window_pixel_xy):
	(show_mouse_face): Remove decls
	* frame.h (message_buf_print): Likewise.
	* lisp.h (pop_message, set_message, check_point_in_composition):
	Likewise.
	* xterm.h (set_vertical_scroll_bar): Likewise.
	* xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
	(message_buf_print, scratch_glyph_row, displayed_buffer):
	(set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
	(get_next_display_element, show_mouse_face, window_box_edges):
	(frame_to_window_pixel_xy, check_point_in_composition):
	(set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
	(glyph_to_pixel_coords): Remove; unused.

1224 1225 1226 1227
	* dired.c (file_name_completion): Now static.

	* dbusbind.c (xd_in_read_queued_messages): Now static.

1228 1229 1230
	* lisp.h (circular_list_error, FOREACH): Remove; unused.
	* data.c (circular_list_error): Remove.

1231 1232 1233 1234
	* commands.h (last_point_position, last_point_position_buffer):
	(last_point_position_window): Remove decls.
	* keyboard.c: Make these variables static.

1235 1236 1237 1238 1239 1240
	* coding.h (coding, code_convert_region, encode_coding_gap): Remove
	decls.
	* coding.c (Vsjis_coding_system, Vbig5_coding_system):
	(iso_code_class, detect_coding, code_convert_region): Now static.
	(encode_coding_gap): Remove; unused.

1241 1242
	* chartab.c (chartab_chars, chartab_bits): Now static.

1243 1244 1245 1246
	* charset.h (charset_iso_8859_1): Remove decl.
	* charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
	Now static.

1247 1248 1249 1250
	* ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
	* ccl.c (Vccl_program_table): Now static.
	(check_ccl_update): Remove; unused.

1251 1252 1253 1254
	* category.c (SET_CATEGORY_SET, set_category_set): Move here.
	* category.h: ... from here.
	* category.c (check_category_table, set_category_set): Now static.

1255 1256 1257
	* casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
	* lisp.h: Remove these decls.

1258 1259
	* buffer.c (buffer_count): Remove unused var.

1260 1261 1262 1263 1264 1265
	* bidi.c (bidi_dump_cached_states): Mark as externally visible,
	so that it's not optimized away.
	(bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
	* dispextern.h (bidi_dump_cached_states): Remove, since it's
	exported only to the debugger.

1266 1267 1268
	* atimer.c (alarm_signal_handler, run_all_atimers): Now static.
	* atimer.h (run_all_atimers): Removed; not exported.

1269 1270 1271 1272 1273 1274
	font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
	* font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
	was inaccessible from Lisp.
	(merge_font_spec): Likewise, renaming from Fmerge_font_spec.
	* font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.

1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294
	alloc.c: Import and export fewer symbols, and remove unused items.
	* lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
	is defined.
	(suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
	it's not optimized away by whole-program optimization.
	(message_enable_multibyte, free_misc): Remove.
	(catchlist, handlerlist, mark_backtrace):
	Declare only if BYTE_MARK_STACK.
	(mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
	* alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
	(message_enable_multibyte): Remove decl.
	(free_misc, interval_free_list, float_block, float_block_index):
	(n_float_blocks, float_free_list, cons_block, cons_block_index):
	(cons_free_list, last_marked_index):
	Now static.
	(suppress_checking, die): Define only if ENABLE_CHECKING is defined.
	* eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
	(mark_backtrace): Define only if BYTE_MARK_STACK.
	* xdisp.c (message_enable_multibyte): Now static.

Glenn Morris's avatar
Glenn Morris committed
1295
	Declare Lisp_Object Q* variables to be 'static' if not exported.
1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
	This makes it easier for human readers (and static analyzers)
	to see whether these variables are used from other modules.
	* alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
	* ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
	* data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
	* font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
	* lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
	* sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
	* xmenu.c, xselect.c:
	Declare Q* vars static if they are not used in other modules.
	* ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
	* frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
	Remove decls of unexported vars.
	* keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.

1311 1312
	* lisp.h (DEFINE_FUNC): Make sname 'static'.

1313 1314 1315 1316 1317
	Make Emacs functions such as Fatom 'static' by default.
	This makes it easier for human readers (and static analyzers)
	to see whether these functions can be called from other modules.
	DEFUN now defines a static function.  To make the function external
	so that it can be used in other C modules, use the new macro DEFUE.
Paul Eggert's avatar
Paul Eggert committed
1318 1319
	* lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
	(Finit_image_library):
1320 1321 1322 1323 1324 1325
	(Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
	(Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
	(Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
	Remove decls, since these functions are now static.
	(Funintern, Fget_internal_run_time): New decls, since these functions
	were already external.
1326

1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342