ChangeLog 1.11 MB
Newer Older
1 2
2011-03-27  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* keyboard.c (parse_modifiers_uncached, parse_modifiers):
	Don't assume string length fits in int.
5
	(keyremap_step, read_key_sequence): Use size_t for sizes.
6

7 8 9
	* callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
	instead of alloca (Bug#8344).

10
	* eval.c (Fbacktrace): Don't assume nargs fits in int.
11
	(Fbacktrace_frame): Don't assume nframes fits in int.
12

13 14
	* syntax.c (scan_sexps_forward): Avoid pointer wraparound.

Paul Eggert's avatar
Paul Eggert committed
15 16 17 18 19 20
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

	* term.c (produce_glyphless_glyph): Remove unnecessary test.

	* cm.c (calccost): Turn while-do into do-while, for clarity.
21

22 23 24 25
	* keyboard.c (syms_of_keyboard): Use the same style as later
	in this function when indexing through an array.  This also
	works around GCC bug 48267.

26 27
	* image.c (tiff_load): Fix off-by-one image count (Bug#8336).

28 29
	* xselect.c (x_check_property_data): Return correct size (Bug#8335).

30 31 32
	* chartab.c (sub_char_table_ref_and_range): Redo for slight
	efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

33 34 35 36
	* keyboard.c, keyboard.h (num_input_events): Now size_t.
	This avoids undefined behavior on integer overflow, and is a bit
	more convenient anyway since it is compared to a size_t variable.

37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
	Variadic C functions now count arguments with size_t, not int.
	This avoids an unnecessary limitation on 64-bit machines, which
	caused (substring ...) to crash on large vectors (Bug#8344).
	* lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
	All variadic functions changed accordingly.
	(struct gcpro.nvars): Now size_t, not int.  All uses changed.
	* data.c (arith_driver, float_arith_driver): Likewise.
	* editfns.c (general_insert_function): Likewise.
	* eval.c (struct backtrace.nargs, interactive_p)
	(internal_condition_case_n, run_hook_with_args, apply_lambda)
	(funcall_lambda, mark_backtrace): Likewise.
	* fns.c (concat): Likewise.
	* frame.c (x_set_frame_parameters): Likewise.
	* fns.c (get_key_arg): Now accepts and returns size_t, and returns
	0 if not found, not -1.  All callers changed.

54 55 56 57 58 59
2011-03-26  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (garbage_collect): Don't assume stack size fits in int.
	(stack_copy_size): Now size_t, not int.
	(stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

60 61 62 63 64 65 66 67 68
2011-03-27  Glenn Morris  <rgm@gnu.org>

	* syssignal.h: Replace RETSIGTYPE with void.
	* atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
	* keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
	Replace SIGTYPE with void everywhere.
	* s/usg5-4-common.h (SIGTYPE): Remove definition.
	* s/template.h (SIGTYPE): Remove commented out definition.

69 70 71 72 73
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

74 75
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

76 77 78 79 80 81 82
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

104 105 106 107 108
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

109 110 111 112 113 114 115 116
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

148 149 150 151 152
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

175 176 177 178 179 180 181 182 183 184 185 186 187 188 189
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
190
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
191 192
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
193
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
194

195 196
	Fix more problems found by GCC 4.5.2's static checks.

197 198 199 200
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

201 202 203
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
204
	of objects (Bug#8318).
205

206 207 208
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

209 210 211 212
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
213 214
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
215

216 217 218
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

219 220
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
221 222
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
223

Paul Eggert's avatar
Paul Eggert committed
224 225
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
226

Paul Eggert's avatar
Paul Eggert committed
227
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
228

229 230 231
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
232
	socklen_t is wider than int (Bug#8277).
233 234 235 236
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

237 238 239 240
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
241
	(Fmake_network_process): Define label "retry_connect" only if needed.
242
	(Fnetwork_interface_info): Fix pointer signedness.
243
	(process_send_signal): Add cast to avoid pointer signedness problem.
244
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
245
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
246

247 248 249 250 251 252 253 254 255 256 257 258
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

259
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
260
	(xftfont_open): Rename locals to avoid shadowing.
261

262
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
263 264
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
265
	(ftfont_list): Remove unused local.
266 267 268
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
269

270 271
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
272 273
	* xml.c (make_dom): Now static.

274 275
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
276 277
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
278
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
279 280
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
281

282 283 284 285 286 287 288
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

289 290
	* textprop.c (property_change_between_p): Remove; unused.

291 292
	* intervals.c (interval_start_pos): Now static.

293 294
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

295 296 297
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

298 299
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
300
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
301 302
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
303

304 305
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

306 307
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
308 309
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
310 311
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
312

313 314 315 316
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

317
	* callproc.c (call_process_cleanup): Now static.
318
	(relocate_fd): Rename locals to avoid shadowing.
319

320 321 322 323 324
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

325 326 327 328
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

329 330 331 332 333 334
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

335 336 337 338 339 340
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

341 342 343 344 345
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

346 347 348 349
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

350 351 352 353
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

354 355
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

356 357
	Fix more problems found by GCC 4.5.2's static checks.

358 359 360
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

361 362 363 364 365 366 367
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

368 369 370
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

371
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
372 373 374
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
375

376 377
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
378 379
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
380
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
381

382 383
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
384
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
385
	* unexec.h: New file.
386 387 388 389 390 391
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
392
	Change as necessary to match prototype in unexec.h.
393

394 395
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
396
	(back_comment, skip_chars): Mark vars as initialized.
397

398 399 400
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

401
	* lread.c (read1): Rewrite so as not to use empty "else".
402
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
403

404 405
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

406 407 408
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

409 410
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
411
	(font_sort_entities): Mark var as initialized.
412

413 414
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

415 416
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
417
	(font_parse_fcname): Remove unused vars.
418
	(font_delete_unmatched): Now static.
419
	(font_get_spec): Remove; unused.
420 421 422
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
423

424
	* fns.c (require_nesting_list, require_unwind): Now static.
425
	(Ffillarray): Rename locals to avoid shadowing.
426

427
	* floatfns.c (domain_error2): Define only if needed.
428
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
429

430 431 432
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

433
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
434
	(Fdefvar): Rewrite so as not to use empty "else".
435 436
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
437
	(Fdefvar): Rename locals to avoid shadowing.
438

439
	* callint.c (quotify_arg, quotify_args): Now static.
440
	(Fcall_interactively): Rename locals to avoid shadowing.
441
	Use const pointer when appropriate.
442

443 444 445 446
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
447 448 449
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
450 451 452
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
453
	(Ftranslate_region_internal): Mark var as initialized.
454

455 456 457
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

458 459 460
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

461 462
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
463
	(default_value, arithcompare, arith_driver, arith_error): Now static.
464
	(store_symval_forwarding): Rename local to avoid shadowing.
465 466
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
467
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
468

469
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
470 471
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
472 473
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
474 475 476 477 478
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
479
	(Fmemory_limit): Cast sbrk's returned value to char *.
480

481 482 483
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

484 485
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

486 487 488 489 490 491 492 493
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
494
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
495
	the race-condition problem in the old DOWNCASE.
496

497 498 499
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
500 501
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
502 503
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
504
	(regex_compile, re_match_2_internal): Mark locals as initialized.
505 506 507 508 509 510 511
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
512

513
	* search.c (boyer_moore): Rename locals to avoid shadowing.
514 515
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
516

517 518
	* search.c (simple_search): Remove unused var.

519 520 521 522
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

523 524
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

525 526 527 528
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
529
	(Fvertical_motion): Mark locals as initialized.
530

531
	* casefiddle.c (casify_object, casify_region): Now static.
532
	(casify_region): Mark local as initialized.
533

534 535
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

536 537 538 539 540 541 542 543 544
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
545 546 547
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

569 570
	* dired.c (directory_files_internal_unwind): Now static.

571 572 573
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
574 575 576
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
577
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
578 579
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
580 581
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
582

583
	* minibuf.c (choose_minibuf_frame_1): Now static.
584 585
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
586

587 588
	* marker.c (bytepos_to_charpos): Remove; unused.

589 590 591
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

592 593
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
594
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
595
	(copy_text): Remove unused local var.
596

597
	* filelock.c (within_one_second): Now static.
598
	(lock_file_1): Rename local to avoid shadowing.
599

600 601 602 603
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
604
	(switch_to_buffer_1): Now static.
605 606
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
607

608
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
609
	Fix pointer signedness issue.
610 611
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
612
	(MAXPATHLEN): Define only if needed.
613

614 615 616
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

617 618 619
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

620
	* sysdep.c (reset_io): Now static.
621
	(wait_for_termination_signal): Remove; unused.
622

623 624 625
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
626
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
627
	(DENSE_TABLE_SIZE): Remove; unused.
628 629 630
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
631

632 633 634
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
635 636 637 638 639
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
640
	(read_key_sequence, read_char): Mark locals as initialized.
641
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
642

643
	* keyboard.h (make_ctrl_char): New decl.
644 645
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
646

647 648
	* lisp.h (force_auto_save_soon): New decl.

649
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
650 651 652
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
653 654
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
655

656 657
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

658 659 660 661 662 663 664
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

665 666
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
667
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
668

669 670
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

671 672 673
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

674 675
	* print.c (print_preprocess): Don't forget font objects.

676 677 678 679
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

680 681 682 683 684
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

685 686 687 688 689 690 691 692
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
693
	(run_protected): Add extern declaration for waiting_for_input.
694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

710 711
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
712
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
713

714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

736 737 738 739 740
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

741 742
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
743 744
	Fix more problems found by GCC 4.5.2's static checks.

745 746
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
747 748
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
749 750
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
751 752 753 754 755
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
756 757 758
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
759

760 761
	* xgselect.c (xg_select): Remove unused var.

762 763 764
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
765
	(my_png_error, my_error_exit): Mark with NO_RETURN.
766

767
	* image.c (clear_image_cache): Now static.
768
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
769
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
770 771
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
772
	(gif_load): Fix pointer signedness.
773 774
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
775

Paul Eggert's avatar
Paul Eggert committed
776 777
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

778 779 780 781 782 783
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
784 785 786 787 788 789 790 791 792 793 794 795
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
796 797
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
798

799 800 801 802
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

803 804 805 806 807
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

808
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
809

810 811
	* fringe.c (update_window_fringes): Remove unused variables.

812 813 814
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

815 816
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
817
	* termcap.c [MSDOS]: Include "msdos.h".
818 819 820 821
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

822
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
823

824 825 826 827 828
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

829 830 831 832
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

833 834 835 836 837 838 839 840 841 842 843 844
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

845
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
846

847
	Fix some minor problems found by GCC 4.5.2's static checks.
848

849 850 851
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
852

853 854 855 856 857
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

858
	* fontset.c (free_realized_fontset): Now static.
859
	(Fset_fontset_font): Rename local to avoid shadowing.
860
	(fontset_font): Mark local as initialized.
861
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
862

863 864
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

865
	* xselect.c (x_disown_buffer_selections): Remove; not used.
866
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
867 868 869
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
870

871 872 873
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
874 875 876 877
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
878
	(Fx_create_frame): Add braces to silence GCC warning.
879
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
880 881
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
882 883 884 885
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
886

887 888
	* xterm.h (x_mouse_leave): New decl.

889 890
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
891 892
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
893
	(XTread_socket): Don't define label "out" unless it's used.
894
	Don't declare local "event" unless it's used.
895 896
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
897 898
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
899 900 901 902 903
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
904
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
905
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
906

907 908
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
909
	(tty_defined_color, merge_face_heights): Now static.
910
	(free_realized_faces_for_fontset): Remove; not used.
911 912
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
913 914
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
915

916
	* terminal.c (store_terminal_param): Now static.
917

918
	* xmenu.c (menu_highlight_callback): Now static.
919
	(set_frame_menubar): Remove unused local.
920
	(xmenu_show): Rename parameter to avoid shadowing.
921 922
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
923 924
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
925

926
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
927
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
928 929
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
930
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
931 932
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
933

Paul Eggert's avatar
Paul Eggert committed
934 935
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

936
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
937 938
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
939

940
	* window.c (display_buffer): Now static.
941 942
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
943 944
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
945
	* dispextern.h (bidi_dump_cached_states): Likewise.
946

947 948 949
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
950 951 952
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
953 954
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
955
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
956

957 958 959
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
960 961 962 963 964 965 966 967 968
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
969 970
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
971
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
972
	(decode_coding_object, encode_coding_object, detect_coding_system):
973 974
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
975 976
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
977
	this initialization is needed.  (Bug#8211)
978 979 980 981 982
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
983

984
	* category.c (hash_get_category_set): Remove unused local var.
985
	(copy_category_table): Now static, since it's not used elsewhere.
986
	* character.c (string_count_byte8): Likewise.
987

988 989 990
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

991 992
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
993 994
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
995
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
996

997
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
998
	(BIDI_BOB): Remove unused macro.
999

1000 1001
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
1002
	* term.c (encode_terminal_code): Likewise.
1003

1004
	* term.c (encode_terminal_code): Now static.  Remove unused local.
1005

Paul Eggert's avatar
Paul Eggert committed
1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible