ChangeLog 133 KB
Newer Older
1 2 3 4
2013-07-28  Paul Eggert  <eggert@cs.ucla.edu>

	* frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).

5 6 7 8 9 10 11 12 13
2013-07-28  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
	frame which got the message is still alive, before dereferencing
	its pointer.  (Bug#14970)

	* frame.c (delete_frame): Test "this" frame's minibuffer window to
	be a live window, before using it as such.  (Bug#14970)

14 15 16 17 18 19 20
2013-07-27  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
	w32_detect_focus_change instead of doing part of its job by hand.
	This fixes the problem whereby FOCUS_OUT events were not sent to
	the event queue.

21 22
2013-07-26  Eli Zaretskii  <eliz@gnu.org>

23 24
	* process.c (Fprocess_list): Doc fix.

25 26 27 28 29 30
	* w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
	being re-exposed only if it didn't ask to become visible.
	<WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
	was previously iconified.  (Bug#14841)
	(x_iconify_frame): Mark the frame iconified.

31 32 33 34 35 36
2013-07-26  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
	(backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.

37 38 39 40 41 42 43 44 45 46
2013-07-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (set_specpdl_old_value): New function.
	(unbind_to): Minor simplification.
	(get_backtrace_frame): New function.
	(Fbacktrace_frame): Use it.  Add `base' argument.
	(backtrace_eval_unrewind, Fbacktrace_eval): New functions.
	(syms_of_eval): Export backtrace-eval.
	* xterm.c (x_focus_changed): Simplify.

47 48 49 50
2013-07-25  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).

51 52 53 54 55 56
2013-07-24  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Instead of moving point out of
	scroll margin, reject the force_start method, and try scrolling
	instead.  (Bug#14780)

57 58 59 60 61
2013-07-24  Ken Brown  <kbrown@cornell.edu>

	* alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
	(Bug#14944).

62 63 64 65 66 67 68
2013-07-24  Paul Eggert  <eggert@cs.ucla.edu>

	* eval.c (Fprogn): Do not check that BODY is a proper list.
	This undoes the previous change.  The check slows down the
	interpreter, and is not needed to prevent a crash.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.

69 70 71 72
2013-07-23  Glenn Morris  <rgm@gnu.org>

	* Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.

73 74
2013-07-23  Paul Eggert  <eggert@cs.ucla.edu>

75 76 77 78 79 80
	Port to GNU/Linux systems with tinfo but not ncurses.
	* dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
	to decide whether ncurses is being used.  Without this change,
	GCC complains about tgetent not being declared, on a system
	that has tinfo installed but ncurses not installed.

81 82
	* eval.c (Fprogn): Check that BODY is a proper list.

83 84 85 86 87 88 89 90
	Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
	* data.c (Fsetq_default):
	* eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
	(Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
	(Fcondition_case):
	Tune by taking advantage of the fact that ARGS is always a list
	when a function is declared to have UNEVALLED args.

91 92 93
	* emacsgtkfixed.c: Port to GCC 4.6.
	GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.

94 95 96 97 98
2013-07-23  Juanma Barranquero  <lekktu@gmail.com>

	* callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
	here to silence compiler warnings.

99 100 101 102 103 104
2013-07-22  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
	when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
	from messing up Emacs's 'struct frame' (Bug#14923).

105 106 107 108 109 110
2013-07-21  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (make_save_ptr_ptr): Define this function.
	It was inadvertently omitted.  It's needed only if
	HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).

111 112 113 114 115
2013-07-21  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
	frame have focus (Bug#14895).

116 117 118 119 120 121 122 123 124 125
2013-07-21  Paul Eggert  <eggert@cs.ucla.edu>

	Avoid vfork-related deadlock more cleanly.
	* callproc.c (child_setup): When the child's exec fails, output
	the program name, as that's more useful.  Use O_NONBLOCK to avoid
	deadlock.
	* process.c (create_process_1): Remove; no longer needed.
	(create_process): Remove timer hack; no longer needed, now that
	the child avoids deadlock.

126
2013-07-20  Glenn Morris  <rgm@gnu.org>
127 128 129

	* image.c (Fimage_flush): Fix doc typo.

130 131
2013-07-20  Paul Eggert  <eggert@cs.ucla.edu>

132 133 134 135 136 137 138 139 140 141
	Fix array bounds violation when pty allocation fails.
	* process.c (PTY_NAME_SIZE): New constant.
	(pty_name): Remove static variable; it's now auto.
	(allocate_pty): Define even if !HAVE_PTYS; that's simpler.
	Take pty_name as an arg rather than using a static variable.
	All callers changed.
	(create_process): Recover pty_flag from process, not from volatile local.
	(create_pty): Stay inside array even when pty allocation fails.
	(Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.

142 143 144
	* lread.c (Fload): Avoid initialization only when lint checking.
	Mention that it's needed only for older GCCs.

145 146 147 148 149
2013-07-20  Kenichi Handa  <handa@gnu.org>

	* coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
	(decode_coding_iso_2022): Check the single-shift area.  (Bug#8522)

150 151 152 153
2013-07-20  Andreas Schwab  <schwab@linux-m68k.org>

	* lread.c (Fload): Avoid uninitialized warning.

154 155
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

156 157 158 159 160 161 162 163 164 165 166 167 168
	Fix some minor file descriptor leaks and related glitches.
	* filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
	(create_lock_file): Use write, not emacs_write.
	* image.c (slurp_file, png_load_body):
	* process.c (Fnetwork_interface_list, Fnetwork_interface_info)
	(server_accept_connection):
	Don't leak an fd on memory allocation failure.
	* image.c (slurp_file): Add a cheap heuristic for growing files.
	* xfaces.c (Fx_load_color_file): Block input around the fopen too,
	as that's what the other routines do.  Maybe input need not be
	blocked at all, but it's better to be consistent.
	Avoid undefined behavior when strlen is zero.

169 170 171
	* alloc.c (staticpro): Avoid buffer overrun on repeated calls.
	(NSTATICS): Now a constant; doesn't need to be a macro.

172 173 174 175 176
2013-07-19  Richard Stallman  <rms@gnu.org>

	* coding.c (decode_coding_utf_8): Add simple loop for fast
	processing of ASCII characters.

177 178 179 180
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

	* conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.

Eli Zaretskii's avatar
Eli Zaretskii committed
181 182 183 184 185 186 187
2013-07-19  Eli Zaretskii  <eliz@gnu.org>

	* keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
	unportable 'struct x_display_info'.
	(DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
	is a portable type.

188 189
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

190 191 192 193 194 195 196 197 198 199
	* sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
	(procfs_ttyname): Don't use uninitialized storage if emacs_fopen
	or fscanf fails.
	(system_process_attributes): Prefer plain char to unsigned char
	when either will do.  Clean up properly if interrupted or if
	memory allocations fail.  Don't assume sscanf succeeds.  Remove
	no-longer-needed workaround to stop GCC from whining.  Read
	command-line once, instead of multiple times.  Check read status a
	bit more carefully.

200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
	Fix obscure porting bug with varargs functions.
	The code assumed that int is treated like ptrdiff_t in a vararg
	function, which is not a portable assumption.  There was a similar
	-- though these days less likely -- porting problem with various
	assumptions that pointers of different types all smell the same as
	far as vararg functions is conserved.  To make this problem less
	likely in the future, redo the API to use varargs functions.
	* alloc.c (make_save_value): Remove this vararg function.
	All uses changed to ...
	(make_save_int_int_int, make_save_obj_obj_obj_obj)
	(make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
	New functions.
	(make_save_ptr): Rename from make_save_pointer, for consistency with
	the above.  Define only on platforms that need it.  All uses changed.

215 216 217 218 219
2013-07-18  Paul Eggert  <eggert@cs.ucla.edu>

	* keyboard.c: Try to fix typos in previous change.
	(DISPLAY_LIST_INFO): New macro.
	(kbd_buffer_get_event): Do not access members that are not present
220
	in X11.  Revert inadvertent change of "!=" to "=".
221

222 223 224 225 226 227
2013-07-18  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (kbd_buffer_get_event):
	* w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
	Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.

228 229
2013-07-18  Paul Eggert  <eggert@cs.ucla.edu>

230 231 232 233 234
	* filelock.c: Fix unlikely file descriptor leaks.
	(get_boot_time_1): Rework to avoid using emacs_open.
	This doesn't actually fix a leak, but is better anyway.
	(read_lock_data): Use read, not emacs_read.

235 236 237 238 239
	* doc.c: Fix minor memory and file descriptor leaks.
	* doc.c (get_doc_string): Fix memory leak when doc file absent.
	(get_doc_string, Fsnarf_documentation):
	Fix file descriptor leak on error.

240 241 242 243
	* term.c: Fix minor fdopen-related file descriptor leaks.
	* term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
	(init_tty) [!DOS_NT]: Likewise.  Also close fd if isatty (fd) fails.

244 245 246 247 248 249 250 251 252 253 254 255 256
	* charset.c: Fix file descriptor leaks and errno issues.
	Include <errno.h>.
	(load_charset_map_from_file): Don't leak file descriptor on error.
	Use plain record_xmalloc since the allocation is larger than
	MAX_ALLOCA; that's simpler here.  Simplify test for exhaustion
	of entries.
	* eval.c (record_unwind_protect_nothing):
	* fileio.c (fclose_unwind):
	New functions.
	* lread.c (load_unwind): Remove.  All uses replaced by fclose_unwind.
	The replacement doesn't block input, but that no longer seems
	necessary.

257 258
2013-07-17  Paul Eggert  <eggert@cs.ucla.edu>

259 260 261 262 263 264 265 266 267 268 269 270 271
	* lread.c: Fix file descriptor leaks and errno issues.
	(Fload): Close some races that leaked fds or streams when 'load'
	was interrupted.
	(Fload, openp): Report error number of last nontrivial failure to open.
	ENOENT counts as trivial.
	* eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
	New functions.
	* fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
	now that the function is always called with a nonnegative arg.
	* lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
	All uses replaced with ...
	(clear_unwind_protect, set_unwind_protect_ptr): New decls.

272 273 274 275 276 277 278 279
	A few more minor file errno-reporting bugs.
	* callproc.c (Fcall_process):
	* doc.c (Fsnarf_documentation):
	* fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
	* process.c (set_socket_option):
	Don't let a constructor trash errno.
	* doc.c: Include <errno.h>.

280 281 282 283
2013-07-16  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (unwind_create_tip_frame): Fix declaration.

284 285
2013-07-16  Paul Eggert  <eggert@cs.ucla.edu>

286 287 288 289 290 291 292
	Fix w32 bug with call-process-region (Bug#14885).
	* callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
	to Fcall_process when the input is empty.  This simplifies the
	code a bit.  It makes no difference on POSIXish platforms but
	apparently it fixes a bug on w32.

	Fix bug where insert-file-contents closes a file twice. (Bug#14839).
293 294 295 296 297 298 299 300 301
	* fileio.c (close_file_unwind): Don't close if FD is negative;
	this can happen when unwinding a zapped file descriptor.
	(Finsert_file_contents): Unwind-protect the fd before the point marker,
	in case Emacs runs out of memory between the two unwind-protects.
	Don't trash errno when closing FD.
	Zap the FD in the specpdl when closing it, instead of deferring
	the removal of the unwind-protect; this fixes a bug where a child
	function unwinds the stack past us.

302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402
	New unwind-protect flavors to better type-check C callbacks.
	This also lessens the need to write wrappers for callbacks,
	and the need for make_save_pointer.
	* alloca.c (free_save_value):
	* atimer.c (run_all_atimers):
	Now extern.
	* alloc.c (safe_alloca_unwind):
	* atimer.c (unwind_stop_other_atimers):
	* keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
	* menu.c (cleanup_popup_menu) [HAVE_NS]:
	* minibuf.c (choose_minibuf_frame_1):
	* process.c (make_serial_process_unwind):
	* xdisp.h (pop_message_unwind):
	* xselect.c (queue_selection_requests_unwind):
	Remove no-longer-needed wrapper.  All uses replaced by the wrappee.
	* alloca.c (record_xmalloc):
	Prefer record_unwind_protect_ptr to record_unwind_protect with
	make_save_pointer.
	* alloca.c (Fgarbage_collect):
	Prefer record_unwind_protect_void to passing a dummy.
	* buffer.c (restore_buffer):
	* window.c (restore_window_configuration):
	* xfns.c, w32fns.c (do_unwind_create_frame)
	New wrapper.  All record-unwind uses of wrappee changed.
	* buffer.c (set_buffer_if_live):
	* callproc.c (call_process_cleanup, delete_temp_file):
	* coding.c (code_conversion_restore):
	* dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
	* editfns.c (save_excursion_restore)
	(subst_char_in_region_unwind, subst_char_in_region_unwind_1)
	(save_restriction_restore):
	* eval.c (restore_stack_limits, un_autoload):
	* fns.c (require_unwind):
	* keyboard.c (recursive_edit_unwind, tracking_off):
	* lread.c (record_load_unwind, load_warn_old_style_backquotes):
	* macros.c (pop_kbd_macro, restore_menu_items):
	* nsfns.m (unwind_create_frame):
	* print.c (print_unwind):
	* process.c (start_process_unwind):
	* search.c (unwind_set_match_data):
	* window.c (select_window_norecord, select_frame_norecord):
	* xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
	(fast_set_selected_frame):
	* xfns.c, w32fns.c (unwind_create_tip_frame):
	Return void, not a dummy Lisp_Object.  All uses changed.
	* buffer.h (set_buffer_if_live): Move decl here from lisp.h.
	* callproc.c (call_process_kill):
	* fileio.c (restore_point_unwind, decide_coding_unwind)
	(build_annotations_unwind):
	* insdel.c (Fcombine_after_change_execute_1):
	* keyboard.c (read_char_help_form_unwind):
	* menu.c (unuse_menu_items):
	* minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
	* sound.c (sound_cleanup):
	* xdisp.c (unwind_redisplay):
	* xfns.c (clean_up_dialog):
	* xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
	Accept no args and return void, instead of accepting and returning
	a dummy Lisp_Object.  All uses changed.
	* cygw32.c (fchdir_unwind):
	* fileio.c (close_file_unwind):
	* keyboard.c (restore_kboard_configuration):
	* lread.c (readevalllop_1):
	* process.c (wait_reading_process_output_unwind):
	Accept int and return void, rather than accepting an Emacs integer
	and returning a dummy object.  In some cases this fixes an
	unlikely bug when the corresponding int is outside Emacs integer
	range.  All uses changed.
	* dired.c (directory_files_internal_unwind):
	* fileio.c (do_auto_save_unwind):
	* gtkutil.c (pop_down_dialog):
	* insdel.c (reset_var_on_error):
	* lread.c (load_unwind):
	* xfns.c (clean_up_file_dialog):
	* xmenu.c, nsmenu.m (pop_down_menu):
	* xmenu.c (cleanup_widget_value_tree):
	* xselect.c (wait_for_property_change_unwind):
	Accept pointer and return void, rather than accepting an Emacs
	save value encapsulating the pointer and returning a dummy object.
	All uses changed.
	* editfns.c (Fformat): Update the saved pointer directly via
	set_unwind_protect_ptr rather than indirectly via make_save_pointer.
	* eval.c (specpdl_func): Remove.  All uses replaced by definiens.
	(unwind_body): New function.
	(record_unwind_protect): First arg is now a function returning void,
	not a dummy Lisp_Object.
	(record_unwind_protect_ptr, record_unwind_protect_int)
	(record_unwind_protect_void): New functions.
	(unbind_to): Support SPECPDL_UNWIND_PTR etc.
	* fileio.c (struct auto_save_unwind): New type.
	(do_auto_save_unwind): Use it.
	(do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
	* insdel.c (struct rvoe_arg): New type.
	(reset_var_on_error): Use it.
	* lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
	New constants.
	(specbinding_func): Remove; there are now several such functions.
	(union specbinding): New members unwind_ptr, unwind_int, unwind_void.
	(set_unwind_protect_ptr): New function.
	* xselect.c: Remove unnecessary forward decls, to simplify maintenance.

403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418
	Be simpler and more consistent about reporting I/O errors.
	* fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
	Say "Read error" and "Write error", rather than "I/O error", or
	"IO error reading", or "IO error writing", when a read or write
	error occurs.
	* process.c (Fmake_network_process, wait_reading_process_output)
	(send_process, Fprocess_send_eof, wait_reading_process_output):
	Capitalize diagnostics consistently.  Put "failed foo" at the
	start of the diagnostic, so that we don't capitalize the
	function name "foo".  Consistently say "failed" for such
	diagnostics.
	* sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
	All callers changed.  This is so it can use report_file_error.
	* sysdep.c (serial_open, serial_configure): Capitalize I/O
	diagnostics consistently as above.

419 420 421 422 423 424 425
	* fileio.c (report_file_errno): Fix errno reporting bug.
	If the file name is neither null nor a pair, package it up as a
	singleton list.  All callers changed, both to this function and to
	report_file_error.  This fixes a bug where the memory allocator
	invoked by list1 set errno so that the immediately following
	report_file_error reported the wrong errno value.

426 427 428 429
	Fix minor problems found by --enable-gcc-warnings.
	* frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
	* keyboard.c (kbd_buffer_get_event): Remove unused local.

430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454
2013-07-16  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
	Set event->arg to Qt if switch-event shall be generated.
	Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.

	* termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.

	* nsterm.m (windowDidResignKey): If this is the focused frame, generate
	FOCUS_OUT_EVENT.

	* keyboard.c (Qfocus_in, Qfocus_out): New static objects.
	(make_lispy_focus_in, make_lispy_focus_out): Declare and define.
	(kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
	switch frame event is made.  Check ! NILP (event->arg) if X11 (moved
	from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
	and there is a focused frame.
	(head_table): Add focus-in and focus-out.
	(keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
	bind to handle-focus-in/out.

	* frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
	(Fhandle_switch_frame): Call Fhandle_focus_in.
	(syms_of_frame): defsubr handle-focus-in/out.

455 456
2013-07-16  Paul Eggert  <eggert@cs.ucla.edu>

457 458 459 460 461 462
	Fix porting bug to older POSIXish platforms (Bug#14862).
	* sysdep.c (emacs_pipe): New function, that implements
	pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
	This should port better to CentOS 5 and to Mac OS X 10.6.
	All calls to pipe2 changed.

463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
	Prefer list1 (X) to Fcons (X, Qnil) when building lists.
	This makes the code easier to read and the executable a bit smaller.
	Do not replace all calls to Fcons that happen to create lists,
	just calls that are intended to create lists.  For example, when
	creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
	rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
	Similarly for list2 through list5.
	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
	* bytecode.c (exec_byte_code):
	* callint.c (quotify_arg, Fcall_interactively):
	* callproc.c (Fcall_process, create_temp_file):
	* charset.c (load_charset_map_from_file)
	(Fdefine_charset_internal, init_charset):
	* coding.c (get_translation_table, detect_coding_system)
	(Fcheck_coding_systems_region)
	(Fset_terminal_coding_system_internal)
	(Fdefine_coding_system_internal, Fdefine_coding_system_alias):
	* composite.c (update_compositions, Ffind_composition_internal):
	* dired.c (directory_files_internal, file_name_completion)
	(Fsystem_users):
	* dispnew.c (Fopen_termscript, bitch_at_user, init_display):
	* doc.c (Fsnarf_documentation):
	* editfns.c (Fmessage_box):
	* emacs.c (main):
	* eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
	(Feval, eval_sub, Ffuncall, apply_lambda):
	* fileio.c (make_temp_name, Fcopy_file, Faccess_file)
	(Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
	(Fset_file_times, Finsert_file_contents)
	(Fchoose_write_coding_system, Fwrite_region):
	* fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
	* font.c (font_registry_charsets, font_parse_fcname)
	(font_prepare_cache, font_update_drivers, Flist_fonts):
	* fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
	* frame.c (make_frame, Fmake_terminal_frame)
	(x_set_frame_parameters, x_report_frame_params)
	(x_default_parameter, Fx_parse_geometry):
	* ftfont.c (syms_of_ftfont):
	* image.c (gif_load):
	* keyboard.c (command_loop_1):
	* keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
	(Fcopy_keymap, append_key, Fcurrent_active_maps)
	(Fminor_mode_key_binding, accessible_keymaps_1)
	(Faccessible_keymaps, Fwhere_is_internal):
	* lread.c (read_emacs_mule_char):
	* menu.c (find_and_return_menu_selection):
	* minibuf.c (get_minibuffer):
	* nsfns.m (Fns_perform_service):
	* nsfont.m (ns_script_to_charset):
	* nsmenu.m (ns_popup_dialog):
	* nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
	(Fx_own_selection_internal):
	* nsterm.m (append2):
	* print.c (Fredirect_debugging_output)
	(print_prune_string_charset):
	* process.c (Fdelete_process, Fprocess_contact)
	(Fformat_network_address, set_socket_option)
	(read_and_dispose_of_process_output, write_queue_push)
	(send_process, exec_sentinel):
	* sound.c (Fplay_sound_internal):
	* textprop.c (validate_plist, add_properties)
	(Fput_text_property, Fadd_face_text_property)
	(copy_text_properties, text_property_list, syms_of_textprop):
	* unexaix.c (report_error):
	* unexcoff.c (report_error):
	* unexsol.c (unexec):
	* xdisp.c (redisplay_tool_bar, store_mode_line_string)
	(Fformat_mode_line, syms_of_xdisp):
	* xfaces.c (set_font_frame_param)
	(Finternal_lisp_face_attribute_values)
	(Finternal_merge_in_global_face, syms_of_xfaces):
	* xfns.c (x_default_scroll_bar_color_parameter)
	(x_default_font_parameter, x_create_tip_frame):
	* xfont.c (xfont_supported_scripts):
	* xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
	(menu_help_callback, xmenu_show):
	* xml.c (make_dom):
	* xterm.c (set_wm_state):
	Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
	and similarly for list2 through list5.

544 545 546 547 548 549 550 551 552 553 554 555 556 557 558
2013-07-15  Paul Eggert  <eggert@cs.ucla.edu>

	* callproc.c (Fcall_process_region): Fix minor race and tune.
	(create_temp_file): New function, with the temp-file-creation part
	of the old Fcall_process_region.  Use Fcopy_sequence to create the
	temp file name, rather than alloca + build_string, for simplicity.
	Don't bother to block input around the temp file creation;
	shouldn't be needed.  Simplify use of mktemp.  Use
	record_unwind_protect immediately after creating the temp file;
	this closes an unlikely race where the temp file was not removed.
	Use memcpy rather than an open-coded loop.
	(Fcall_process_region): Use the new function.  If the input is
	empty, redirect from /dev/null rather than from a newly created
	empty temp file; this avoids unnecessary file system traffic.

559 560
2013-07-14  Paul Eggert  <eggert@cs.ucla.edu>

561 562 563 564
	* filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
	Simplify by making this case like the other two.  This is a bit
	slower on obsolete hosts, but the extra complexity isn't worth it.

565 566 567 568
	* callproc.c (child_setup, relocate_fd) [!DOS_NT]:
	* process.c (create_process) [!DOS_NT]:
	Remove now-unnecessary calls to emacs_close.

569 570
2013-07-13  Eli Zaretskii  <eliz@gnu.org>

571 572 573
	* w32term.c (x_draw_hollow_cursor): Delete the brush object when
	returning early.  (Bug#14850)

574 575 576 577
	* coding.c (syms_of_coding): Set up inhibit-null-byte-detection
	and inhibit-iso-escape-detection attributes of 'undecided'.
	(Bug#14822)

578 579
2013-07-13  Paul Eggert  <eggert@cs.ucla.edu>

580 581 582 583
	* deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
	Reported by Herbert J. Skuhra in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.

584 585 586 587 588 589
	Don't lose top specpdl entry when memory is exhausted.
	* eval.c (grow_specpdl): Increment specpdl top by 1 and check for
	specpdl overflow here, to simplify callers; all callers changed.
	Always reserve an unused entry at the stack top; this avoids
	losing the top entry's information when memory is exhausted.

Paul Eggert's avatar
Paul Eggert committed
590 591
2013-07-12  Paul Eggert  <eggert@cs.ucla.edu>

592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614
	Clean up errno reporting and fix some errno-reporting bugs.
	* callproc.c (Fcall_process):
	* fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
	* process.c (create_process, Fmake_network_process):
	* unexaix.c (report_error):
	* unexcoff.c (report_error):
	Be more careful about reporting the errno of failed operations.
	The code previously reported the wrong errno sometimes.
	Also, prefer report_file_errno to setting errno + report_file_error.
	(Fcall_process): Look at openp return value rather than at path,
	as that's a bit faster and clearer when there's a numeric predicate.
	* fileio.c (report_file_errno): New function, with most of the
	old contents of report_file_error.
	(report_file_error): Use it.
	(Ffile_exists_p, Ffile_accessible_directory_p):
	Set errno to 0 when it is junk.
	* fileio.c (Faccess_file):
	* image.c (x_create_bitmap_from_file):
	Use faccessat rather than opening the file, to avoid the hassle of
	having a file descriptor open.
	* lisp.h (report_file_errno): New decl.
	* lread.c (Flocate_file_internal): File descriptor 0 is valid, too.

Paul Eggert's avatar
Paul Eggert committed
615 616 617 618 619 620 621
	Minor EBADF fixes.
	* process.c (create_process, wait_reading_process_output) [AIX]:
	Remove obsolete SIGHUP-related  code, as Emacs no longer disables
	SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
	a multithreaded environment anyway).
	* sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).

622 623 624 625
2013-07-12  Andreas Schwab  <schwab@linux-m68k.org>

	* image.c (x_find_image_file): Don't close a remote file handle.

626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650
2013-07-12  Paul Eggert  <eggert@cs.ucla.edu>

	Fix races with threads and file descriptors.
	* callproc.c (Fcall_process_region):
	* dired.c (open_directory):
	* emacs.c (main, Fdaemon_initialized):
	* image.c (x_find_image_file):
	* inotify.c (Finotify_rm_watch):
	* lread.c (Flocate_file_internal):
	* process.c (Fnetwork_interface_list, Fnetwork_interface_info):
	* term.c (term_mouse_moveto, init_tty):
	* termcap.c (tgetent):
	* unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
	* unexhp9k800.c, unexmacosx.c (unexec):
	* callproc.c (Fcall_process_region):
	Use emacs_close, not close.
	* sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
	New macro and function, which emulates the POSIX_CLOSE_RESTART macro
	and posix_close function on current platforms (which all lack them).
	(emacs_close): Use it.  This should fix the races on GNU/Linux and
	on AIX and on future platforms that support POSIX_CLOSE_RESTART,
	and it should avoid closing random victim file descriptors on
	other platforms.

651 652
2013-07-11  Paul Eggert  <eggert@cs.ucla.edu>

653 654 655 656
	* inotify.c (uninitialized): Remove.  All uses replaced by -1.
	(Finotify_add_watch): Simplify, since -1 means uninitialized now.
	Touch up doc a bit.

657 658 659
	* eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
	This is for .gdbinit xbacktrace.

660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678
	* sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
	* sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
	(emacs_set_tty): Now static.
	* sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
	* term.c (tty_capable_p, tty_default_color_capabilities)
	(get_tty_terminal, term_mouse_movement)
	(handle_one_term_event, init_tty, maybe_fatal):
	* termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
	(tgetent, scan_file, name_match, compare_contin):
	* terminal.c (get_terminal):
	Use bool for boolean.
	* sysdep.c (init_system_name): Don't overflow stack on huge hostname.
	Prefer char to unsigned char if either will do.
	* term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
	(tty_write_glyphs): Prefer int to unsigned.
	(produce_glyphless_glyph): Remove 2nd (unused) int arg.
	All callers changed.
	* termcap.c (tprint, main) [TEST]: Remove non-working test.

679 680
2013-07-10  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718
	Port to C89.
	* bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
	(B__dummy__): New dummy symbol, to pacify C89.
	* dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
	they can't grok varargs macros.
	* dispnew.c (add_window_display_history)
	(add_frame_display_history):
	* print.c (print_object):
	* xdisp.c (debug_method_add):
	Use %p printf format only for void pointers.
	* emacs.c (usage_message): New constant, replacing ...
	(USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
	(main): Adjust to usage reorg.
	* fns.c (syms_of_fns):
	* profiler.c (syms_of_profiler):
	Don't use non-constant struct initializers.
	* gnutls.h (gnutls_initstage_t):
	* lisp.h (enum Lisp_Fwd_Type):
	* lread.c (lisp_file_lexically_bound_p):
	* xsettings.c (anonymous enum):
	Remove trailing comma.
	* xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
	* lisp.h (ENUM_BF): Use unsigned if pedantic.
	(DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
	(DEFUN): Use it.
	* regex.c (const_re_char): New type, to pacify strict C89.
	All uses of 'const re_char' replaced to use it.
	* regex.h (_Restrict_): Rename from __restrict, to avoid clash
	with glibc when strict C89.  This change is imported from gnulib.
	All uses changed.
	(_Restrict_arr_): Rename from __restrict_arr, similarly.
	* sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
	Omit GNU_LINUX implementation, since it requires long long.
	* xterm.c (x_draw_underwave):
	Do not assume the traditional order of struct's members.
	(x_term_init): Rewrite to avoid the need for non-constant structure
	initializers.

719
	Syntax cleanup, mostly replacing macros with functions.
720
	This removes the need for the syntax_temp hack.
721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756
	* search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
	* syntax.c (SYNTAX_INLINE): New macro.
	(SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
	(SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
	(SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
	(SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
	(SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
	(SYNTAX_COMEND_FIRST): Now functions, not macros.
	(ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
	Now constants, not macros.
	(syntax_temp) [!__GNUC__]: Remove.
	(SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
	(syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
	(SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
	(SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
	Move here from syntax.h; now functions, not macros.  Except for the
	last function, these are static since only syntax.c uses them.
	(syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
	All uses changed.  Now a function, not a macro; use this fact
	to simplify the code.
	(scan_lists, scan_sexps_forward): Remove workarounds for ancient
	compiler bugs; no longer relevant.
	* syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
	(SYNTAX_INLINE): New macro.
	(struct gl_state_s, gl_state): Move earlier, so that it's in scope
	for the new functions.  Use bool for boolean member.
	(SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
	(SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
	(UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
	(SETUP_BUFFER_SYNTAX_TABLE):
	Now extern inline functions, not macros.
	(CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
	Remove; all uses replaced by implementation.
	(syntax_temp) [!__GNUC__]: Remove decl.
	(SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.

757 758 759 760
2013-07-10  Jan Djärv  <jan.h.d@swipnet.se>

	* emacs.c (main): Fix syntax error.

Paul Eggert's avatar
Paul Eggert committed
761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778
2013-07-10  Paul Eggert  <eggert@cs.ucla.edu>

	Timestamp fixes for undo (Bug#14824).
	* atimer.c (schedule_atimer):
	* fileio.c (Ffile_newer_than_file_p):
	Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
	* buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
	* fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
	(syms_of_fileio): Remove Sclear_visited_file_name.
	(Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
	file doesn't exist; this avoids an ambiguity with negative timestamps.
	(Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
	* systime.h (make_emacs_time, invalid_emacs_time):
	Don't assume struct timespec layout; POSIX doesn't guarantee it.
	(EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
	* undo.c (record_first_change): Push (visited-file-modtime) onto
	undo list rather than reimplementing it by hand, incorrectly.

779 780 781 782
2013-07-09  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.

783 784 785 786
2013-07-09  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.

787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817
2013-07-09  Paul Eggert  <eggert@cs.ucla.edu>

	Handle errno and exit status a bit more carefully.
	* callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
	number into an exit status.  Instead, use EXIT_CANCELED.
	(child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
	* callproc.c (relocate_fd):
	* emacs.c (close_output_streams, main):
	* process.c (create_process):
	* sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
	Use emacs_perror for simplicity.
	* callproc.c (relocate_fd, main):
	* sysdep.c (sys_subshell):
	Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
	(shut_down_emacs): Use emacs_write, not write.
	* emacs.c, sysdep.c: Don't include <ignore-value.h>.
	* fileio.c (Fcopy_file, e_write):
	* nsterm.m (ns_select):
	* process.c (send_process):
	* sound.c (vox_write):
	Use emacs_write_sig, not emacs_write.
	* lisp.h (emacs_write_sig, emacs_perror): New decls.
	* process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
	New constants.
	* sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
	of write.
	(emacs_full_write): New function.
	(emacs_write): Rewrite to use it.
	(emacswrite_sig, emacs_perror): New functions.
	* xrdb.c (fatal): Don't invoke perror, since errno might be garbage.

818
2013-07-08  Magnus Henoch  <magnus.henoch@gmail.com>  (tiny change).
819 820 821 822

	* image.c (imagemagick_load_image): Do not use MagickExportImagePixels
	on NS even if it is present.  Pixmap on NS is a void*.

Paul Eggert's avatar
Paul Eggert committed
823 824 825 826 827 828 829
2013-07-07  Paul Eggert  <eggert@cs.ucla.edu>

	Port to Ubuntu 10 (Bug#14803).
	Problem reported by T.V. Raman.
	* process.c (close_on_exec, accept4, process_socket):
	Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.

830 831 832 833 834 835 836 837
2013-07-07  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (sys_dup): Declare prototype.

	* filelock.c:
	* emacs.c:
	* callproc.c [WINDOWSNT]: Include sys/socket.h.

838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875
2013-07-07  Paul Eggert  <eggert@cs.ucla.edu>

	Make file descriptors close-on-exec when possible (Bug#14803).
	This simplifies Emacs a bit, since it no longer needs to worry
	about closing file descriptors by hand in some cases.
	It also fixes some unlikely races.  Not all such races, as
	libraries often open files internally without setting
	close-on-exec, but it's an improvement.
	* alloc.c (valid_pointer_p) [!WINDOWSNT]:
	* callproc.c (Fcall_process) [!MSDOS]:
	* emacs.c (main) [!DOS_NT]:
	* nsterm.m (ns_term_init):
	* process.c (create_process):
	Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
	* emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
	* filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
	Prefer mkostemp with O_CLOEXEC to mkstemp.
	* callproc.c (relocate_fd) [!WINDOWSNT]:
	* emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
	No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
	now using pipe2.
	* filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
	Make the resulting file descriptor close-on-exec.
	* lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
	* lread.c (load_descriptor_list, load_descriptor_unwind):
	Remove; no longer needed.  All uses removed.
	* process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
	(close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
	New functions.
	(socket) [!SOCK_CLOEXEC]: Supply a substitute.
	(Fmake_network_process, Fnetwork_interface_list):
	(Fnetwork_interface_info, server_accept_connection):
	Make newly-created socket close-on-exec.
	* sysdep.c (emacs_open, emacs_fopen):
	Make new-created descriptor close-on-exec.
	* w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
	* w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.

Jan Djärv's avatar
Jan Djärv committed
876 877 878 879 880
2013-07-07  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (sendEvent:): Propagate keyboard events to modal windows
	for NS_IMPL_GNUSTEP.

Paul Eggert's avatar
Paul Eggert committed
881 882 883 884 885 886 887
2013-07-07  Paul Eggert  <eggert@cs.ucla.edu>

	Fix openp errno handling.
	* callproc.c (Fcall_process): Preserve openp errno around close.
	* lread.c (openp): Set errno when returning -1, as some callers
	expect this.

888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903
2013-07-06  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.

	* nsterm.h (NSSavePanel): Update comment.
	(NSAPP_DATA2_RUNFILEDIALOG): Define.
	(ns_run_file_dialog): Declare.

	* nsfns.m: Remove panelOK.
	(ns_fd_data): New.
	(ns_run_file_dialog): New function.
	(Fns_read_file_name): Fill in ns_fd_data, post an event and start the
	event loop, so file dialog is popped up by ns_run_file_dialog, called
	by sendEvent (Bug#14578).
	(EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.

904 905
2013-07-06  Eli Zaretskii  <eliz@gnu.org>

906 907 908 909 910 911 912 913 914 915 916 917 918
	* xdisp.c (default_line_pixel_height): New function.
	(pos_visible_p, move_it_vertically_backward, try_scrolling)
	(try_cursor_movement, redisplay_window, try_window)
	(try_window_id): Use it instead of FRAME_LINE_HEIGHT.  (Bug#14771)

	* window.c (window_scroll_pixel_based): use
	default_line_pixel_height.

	* dispextern.h (default_line_pixel_height): Add prototype.

	* frame.c (x_set_line_spacing): Accept a float value for
	line-spacing parameter, per the documentation.

919 920
	* data.c (Fmultibyte_string_p): Doc fix.

921 922
2013-07-05  Paul Eggert  <eggert@cs.ucla.edu>

923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954
	Use emacs_open more consistently when opening files.
	This handles EINTR more consistently now, and makes it easier
	to introduce other uniform changes to file descriptor handling.
	* src/systdio.h: New file.
	* src/buffer.c (mmap_init):
	* cygw32.c (chdir_to_default_directory):
	* dispnew.c (Fopen_termscript):
	* emacs.c (Fdaemon_initialized):
	* fileio.c (Fdo_auto_save):
	* image.c (slurp_file, png_load_body, jpeg_load_body):
	* keyboard.c (Fopen_dribble_file):
	* lread.c (Fload):
	* print.c (Fredirect_debugging_output):
	* sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
	* termcap.c (tgetent):
	* unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
	* unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
	* w32term.c (w32_initialize) [CYGWIN]:
	* xfaces.c (Fx_load_color_file):
	Use emacs_open instead of plain open, and emacs_fopen instead of
	plain fopen.
	* dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
	* xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
	* callproc.c (default_output_mode): New constant.
	(Fcall_process): Use it to call emacs_open instead of plain creat.
	* dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
	* sysdep.c (emacs_open): Add commentary and don't call file name "path".
	(emacs_fopen): New function.
	* unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
	Include <lisp.h>, for emacs_open.
	* unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.

955 956 957 958 959 960 961 962 963 964 965 966 967 968 969
	Remove duplicate #include directives.
	* alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
	* xfaces.c:
	Don't include stdio.h twice.
	* buffer.c [USE_MMAP_FOR_BUFFERS]:
	Don't include sys/types.h or stdio.h twice.
	* fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
	* lread.c: Don't include coding.h twice.
	* nsfont.m: Don't include frame.h twice.
	* process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
	* ralloc.c: Don't include <unistd.h> twice.
	* xdisp.c: Don't include font.h twice.
	* xterm.c: Don't include fontset.h twice.
	* xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.

970 971 972 973 974 975 976 977
2013-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	Scale ImageMagick images more carefully.
	* image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
	(compute_image_size): Use it.  Define only if HAVE_IMAGEMAGICK.
	Be more careful about avoiding undefined behavior after
	integer overflow and division by zero.

978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001
2013-07-04  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

	* w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
	(syms_of_w32fns): DEFSYM them.
	(MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
	(CCHDEVICENAME): Define macros if not defined.
	(struct MONITOR_INFO_EX): New struct.
	(MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
	(enum_display_monitors_fn): New variable.
	(globals_of_w32fns): Initialize it.
	(Fx_display_pixel_width, Fx_display_pixel_height)
	(Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
	multi-monitor setups in docstrings.
	(Fx_display_mm_height, Fx_display_mm_width): Approximate whole
	screen size by primary monitor's millimeter per pixel.
	(w32_monitor_enum, w32_display_monitor_attributes_list)
	(w32_display_monitor_attributes_list_fallback)
	(Fw32_display_monitor_attributes_list): New functions.
	(syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.

	* w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
	if not defined.
	(x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.

1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
2013-07-04  Michael Albinus  <michael.albinus@gmx.de>

	* fileio.c (Qfile_notify_error): New error symbol.

	* gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
	* inotify.c (inotify_callback, symbol_to_inotifymask)
	(Finotify_add_watch, Finotify_rm_watch): Use it.
	(inotifyevent_to_event): Exchange order of cookie and file name.
	(Finotify_add_watch): Adapt docstring.

	* lisp.h (Qfile_notify_error): Declare.

1014 1015 1016 1017 1018 1019 1020 1021 1022 1023
2013-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
	* emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
	Do not clear _malloc_thread_enabled_p, undoing the previous change,
	which did not work (see <http://bugs.gnu.org/14569#307>).
	(main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
	&& (!noninteractive || initialized)).  This attempts to thread
	the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.

1024 1025 1026 1027 1028
2013-07-04  Juanma Barranquero  <lekktu@gmail.com>

	* image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
	(x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.

1029 1030 1031 1032 1033 1034 1035
2013-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
	* emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
	Clear _malloc_thread_enabled_p at startup.  Reported by Ashish SHUKLA in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.

1036 1037 1038 1039 1040
2013-07-02  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
	Define to __sys_siglist.

1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053
2013-07-02  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
	word-wrap, so that overflow-newline-into-fringe would work in
	visual-line-mode.  (Bug#2749)
	(move_it_in_display_line_to): When the last scanned display
	element fits exactly on the display line, and
	overflow-newline-into-fringe is non-nil, but wrap_it is valid,
	don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
	wrap point and return MOVE_LINE_CONTINUED.  Fixes problems with
	finding buffer position that corresponds to pixel coordinates,
	e.g. in buffer_posn_from_coords.

1054 1055 1056 1057 1058
2013-07-02  Jan Djärv  <jan.h.d@swipnet.se>

	* process.c (handle_child_signal): Call catch_child_signal if
	NS_IMPL_GNUSTEP.

Paul Eggert's avatar
Paul Eggert committed
1059 1060
2013-07-02  Paul Eggert  <eggert@cs.ucla.edu>

1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075
	Don't convert function pointers to void * and back.
	It isn't portable C, and it's easy enough to avoid.
	* alloc.c: Verify SAVE_FUNCPOINTER bits, too.
	(make_save_value): Add support for SAVE_FUNCPOINTER.
	* keymap.c (map_keymap_char_table_item, map_keymap_internal):
	* print.c (print_object):
	Distinguish function from object pointers.
	* lisp.h (SAVE_FUNCPOINTER): New constant.
	(SAVE_SLOT_BITS): Adjust to it.
	(SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
	SAVE_TYPE_PTR_PTR_OBJ.  Change the only use.
	(voidfuncptr): New typedef.
	(struct Lisp_Save_Value): New member data[0].funcpointer.
	(XSAVE_FUNCPOINTER): New function.

Paul Eggert's avatar
Paul Eggert committed
1076 1077 1078 1079 1080 1081 1082 1083 1084
	Simplify buildobj processing.
	* Makefile.in (buildobj.h): Make it a sequence of strings each
	followed by comma, rather than a single string.  Put it into a
	.tmp file in case there's an error while generating it.
	(gl-stamp): Use .tmp for temp files.
	(mostlyclean): Clean .tmp files.
	* doc.c (buildobj): Move to just the routine that needs it.
	It's now an array of strings, so processing is simpler.

1085 1086 1087 1088 1089 1090 1091 1092 1093 1094
2013-07-01  Paul Eggert  <eggert@cs.ucla.edu>

	Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
	* emacs.c (malloc_enable_thread): Hoist extern decl to top level.
	(main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
	Invoke malloc_enable_thread even when not interactive.
	Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
	* process.c (init_process_emacs) [CYGWIN]: Tickle glib even
	in this case, since the underlying bug has now been fixed.

1095 1096 1097 1098 1099
2013-07-01  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
	unlinking it (bug#14691).

1100 1101 1102 1103 1104 1105 1106 1107
2013-06-30  Michal Nazarewicz  <mina86@mina86.com>

	* buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
	before checking whether buffer is modified.  This lets
	`kill-buffer-query-functions' cancel killing of the buffer or save
	its content before `kill-buffer' asks user the "Buffer %s
	modified; kill anyway?" question.

1108 1109 1110 1111 1112
2013-06-30  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfns.m (handlePanelKeys): Don't process Command+Function keys.
	Let the super performKeyEquivalent deal with them (Bug#14747).

1113 1114
2013-06-30  Paul Eggert  <eggert@cs.ucla.edu>

1115 1116
	* widget.c (resize_cb): Remove unused local.

1117 1118 1119 1120 1121
	Do not use GTK 3 if it exists but cannot be compiled.
	* xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
	* xterm.c (x_error_handler) [!USE_GTK]:
	Do not use GTK 3.

1122 1123
	* intervals.c (get_local_map): Actually clip POSITION (Bug#14753).

1124 1125
2013-06-30  Eli Zaretskii  <eliz@gnu.org>

1126 1127 1128
	* intervals.c (get_local_map): Instead of aborting, clip POSITION
	to the valid range of values.  (Bug#14753)

1129 1130 1131 1132 1133
	* xdisp.c (Fmove_point_visually): Invalidate the cursor position
	when moving point by using the current glyph matrix.  This avoids
	the need to force redisplay when this function is called in a
	loop.

1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145
2013-06-29  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* coding.c (encode_inhibit_flag, inhibit_flag): New functions.
	Redo the latter's body to sidestep GCC parenthesization warnings.
	(setup_coding_system, detect_coding, detect_coding_system): Use them.
	* coding.c (detect_coding, detect_coding_system):
	* coding.h (struct undecided_spec):
	Use bool for boolean.
	* image.c (QCmax_width, QCmax_height): Now static.
	* xdisp.c (Fmove_point_visually): Remove unused local.

1146 1147 1148 1149
2013-06-29  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fmove_point_visually): New function.

Juanma Barranquero's avatar
Juanma Barranquero committed
1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
2013-06-28  Kenichi Handa  <handa@gnu.org>

	* coding.h (define_coding_undecided_arg_index): New enum.
	(coding_attr_index): New members
	coding_attr_undecided_inhibit_null_byte_detection,
	coding_attr_undecided_inhibit_iso_escape_detection,
	coding_attr_undecided_prefer_utf_8.
	(undecided_spec): New struct.
	(struct coding_system): New member `undecided' of the member
	`spec'.

	* coding.c (setup_coding_system): Handle CODING->spec.undecided.
	(detect_coding): Likewise.
	(detect_coding_system): Likewise.
	(Fdefine_coding_system_internal): New coding system properties
	:inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
	:prefer-utf-8.
	(syms_of_coding): Adjust for coding_arg_undecided_max.

1169 1170 1171 1172
2013-06-28  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (x_from_xcolors): Remove unused local.

1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
2013-06-28  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

	Defer image data transfer between X client and server until actual
	display happens.

	* dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
	and `mask_img'.

	* image.c (Destroy_Image): Remove.
	(x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
	`mask_p', and `colors_p'.  All uses changed.
	(x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
1185 1186
	(CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
	New macros for `flags' arg to x_clear_image_1.
1187 1188
	(postprocess_image, xpm_load_image, x_build_heuristic_mask)
	(png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
1189
	(ZPixmap, XGetImage) [HAVE_NS]: Remove.
1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208
	(image_get_x_image_or_dc, image_unget_x_image_or_dc)
	(image_get_x_image, image_unget_x_image): New functions or macros.
	(image_background, image_background_transparent, x_to_xcolors)
	(x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
	XGetImage or CreateCompatibleDC.  Use image_unget_x_image_or_dc
	instead of Destroy_Image.
	(image_create_x_image_and_pixmap, image_put_x_image): New functions.
	(xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
	(png_load_body, jpeg_load_body, tiff_load, gif_load)
	(imagemagick_load_image, svg_load_image): Use them instead of
	x_create_x_image_and_pixmap, and x_put_x_image followed by
	x_destroy_x_image, respectively.
	(xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
	XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
	XpmCreatePixmapFromBuffer.  Create pixmaps.  Fill background and
	background_transparent fields.
	(image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
	(prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.

1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226
2013-06-27  Paul Eggert  <eggert@cs.ucla.edu>

	Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
	This mostly consists of undoing recent changes.
	* callproc.c (Fcall_process):
	* process.c (create_process):
	Do not worry about catching SIGCHLD here, undoing previous change.
	* nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
	* process.c, process.h (catch_child_signal):
	No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
	* process.c (catch_child_handler): Don't worry about being called
	lazily and do not assume caller has blocked SIGCHLD, undoing
	previous change.  Move first-time stuff back to
	init_process_emacs, undoing 06-22 change.  If CYGWIN, do not
	tickle glib, as that causes Cygwin bootstrap to fail.  Do not
	set lib_child_handler if it's already initialized, which may
	help avoid problems on GNUStep.

1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243
2013-06-23  Paul Eggert  <eggert@cs.ucla.edu>

	A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
	* callproc.c (Fcall_process):
	* process.c (create_process):
	Make sure SIGCHLD is caught before we fork,
	since Emacs startup no arranges to catch SIGCHLD.
	* process.c (lib_child_handler): Initialize to null, not to
	dummy_handler.
	(catch_child_signal): Allow self to be called lazily.
	Do nothing if it's already been called.
	Assume caller has blocked SIGCHLD (all callers do now).
	* emacs.c (main): Do not catch SIGCHLD here; defer it until
	just before it's really needed.
	* nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
	since it hasn't been caught yet.

1244 1245 1246 1247 1248 1249
2013-06-23  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (compute_image_size): New function to implement
	:max-width and :max-height.
	(imagemagick_load_image): Use it.

1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
2013-06-23  Paul Eggert  <eggert@cs.ucla.edu>

	Try to avoid malloc SEGVs on Cygwin (Bug#14569).
	* callproc.c, process.h (block_child_signal, unblock_child_signal):
	Now extern.
	* emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
	* process.c (catch_child_signal): Block SIGCHLD while futzing with
	the SIGCHLD handler, since the code is not atomic and (due to glib)
	signals may be arriving now.
	* sysdep.c (init_signals): Do not catch child signals here;
	'main' now does that later, at a safer time.

1262 1263
2013-06-22  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274
	Clean up SIGCHLD handling a bit (Bug#14569).
	* process.c, process.h (catch_child_signal):
	Now always extern, even if !NS_IMPL_GNUSTEP.
	* process.c (catch_child_signal): Move glib tickler here from
	init_process_emacs, so that it's done earlier in Emacs
	initialization.  Also move the noninteractive && !initialized
	check here from init_process_emacs.  This is all a bit cleaner for
	GNUish platforms, and I hope it works around the Cygwin bug.
	* sysdep.c (init_signals): Invoke catch_child_signal here, so
	that glib signal handling is tickled before glib creates threads.

1275 1276 1277
	* process.c (wait_reading_process_output): Avoid int overflow
	when reading more than 2 GiB total from a process.

1278 1279 1280 1281 1282 1283
2013-06-21  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (create_process): Handle a couple more cases,
	i.e., work even if new_argv and wait_child_setup[i] are cached.
	Use Fcall_process's style for volatile vars.

1284 1285 1286 1287
2013-06-21  Andreas Schwab  <schwab@linux-m68k.org>

	* process.c (create_process): Mark PROCESS volatile.

1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315
2013-06-21  Paul Eggert  <eggert@cs.ucla.edu>

	Use C99-style flexible array members if available.
	This avoids some subtle aliasing issues, which typically
	aren't a problem with GCC but may be a problem elsewhere.
	* alloc.c (sdata): New typedef, replacing the old struct sdata.
	It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
	In either case, it uses a flexible array member rather than
	the old struct hack.  All uses changed.
	(SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
	Adjust to sdata reorganization.
	* alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
	Use offsetof (struct, flex_array_member), not sizeof (struct), as
	that ports better to pre-C99 non-GCC.
	* chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
	Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
	as the latter has changed.
	* conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
	and port better to pre-C99 GCC.
	* image.c (struct xpm_cached_color):
	* lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
	(struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
	Use FLEXIBLE_ARRAY_MEMBER.
	* lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
	Move decl to top level so it gets checked against implementation.
	(CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
	* w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.

Paul Eggert's avatar
Paul Eggert committed
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
2013-06-20  Paul Eggert  <eggert@cs.ucla.edu>

	* syntax.c: Integer cleanups.
	(SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
	All uses that need 0-or-2 changed to:
	(SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
	as the old SYNTAX_FLAGS_COMMENT_STYLEC.
	(struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
	(char_quoted, prev_char_comend_first, back_comment)
	(Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
	(in_classes, forw_comment, scan_lists, scan_sexps_forward):
	Use bool for boolean.
	(update_syntax_table, skip_chars, skip_syntaxes):
	Prefer int to unsigned when either will do.
	(back_comment): Return boolean success flag, like forw_comment,
	instead of positive-or-minus-1 (which might have overflowed int anyway).
	Don't stuff ptrdiff_t into int.
	(syntax_spec_code, syntax_code_spec): Now const.
	(Fmatching_paren, scan_lists, scan_sexps_forward):
	Use enum syntaxcode for syntax code.
	(Fmatching_paren): Check that arg is a character, not just an integer.
	(Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
	(Finternal_describe_syntax_value): Omit no-longer-needed
	comparison to 0.
	(skip_chars): Use char, not unsigned char, when the distinction
	doesn't matter.
	(forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
	* bytecode.c (exec_byte_code):
	* syntax.c (syntax_spec_code, Fchar_syntax)
	(Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
	(init_syntax_once):
	* syntax.h (SYNTAX_WITH_FLAGS):
	Omit unnecessary casts.

1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362
2013-06-20  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc): Don't compute the header line and mode
	line dimensions here, to avoid race conditions with the main
	thread.  (Bug#14062, bug#14630, bug#14669)

	* w32term.c (w32_draw_window_cursor): Compute the header line and
	mode line dimensions here.
	<w32_system_caret_window, w32_system_caret_hdr_height>:
	<w32_system_caret_mode_height>: New variables.

	* w32term.h: Declare them.

1363 1364
2013-06-20  Paul Eggert  <eggert@cs.ucla.edu>

1365 1366 1367 1368 1369 1370
	* alloc.c (die): Move "assertion failed" string here ...
	* lisp.h (eassert): ... from here.  Also, suppress evaluation of
	COND when SUPPRESS_CHECKING.  This shrinks the executable text
	size by 0.8% to 2.2% when configured with --enable-checking,
	depending on optimization flags (GCC 4.8.1 x86-64).

1371 1372
	* floatfns.c (Flog10): Move to Lisp (marked obsolete there).

1373
2013-06-20  Rüdiger Sonderfeld  <ruediger@c-plusplus.de>
1374 1375 1376 1377

	* floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
	base is 2; this is more accurate.

1378 1379 1380 1381 1382
2013-06-19  Juanma Barranquero  <lekktu@gmail.com>

	* sound.c (string_default): Move to !WINDOWSNT section.
	(Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.

1383 1384
2013-06-19  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395
	* sound.c: Integer cleanups.
	Remove unnecessary forward decls.
	(struct sound_device): The 'file' member is now a Lisp_Object, not
	a char *, so that we needn't invoke alloca on a huge size.
	(Fplay_sound_internal): Adjust to this.
	(string_default): New function.
	(vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
	Use it to adjust to the struct sound_device change.
	(parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
	(be2hs) [0]: Remove.

1396 1397 1398 1399
	* syntax.c (skip_chars): Don't use uninitialized storage
	when searching a multibyte buffer for characters that are not in a
	unibyte string that contains non-ASCII characters.

1400 1401 1402 1403 1404
2013-06-18  Jan Djärv  <jan.h.d@swipnet.se>

	* process.c: Include xgselect.h if HAVE_GLIB.  Include glib.h
	if HAVE_GLIB && ! WINDOWSNT (Bug#14654).

1405 1406 1407 1408
2013-06-18  Paul Eggert  <eggert@cs.ucla.edu>

	* conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.

1409 1410
2013-06-18  Kenichi Handa  <handa@gnu.org>

1411 1412
	* font.c (Ffont_spec): Signal an error for an invalid font name
	(Bug#14648).
1413

1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434
2013-06-18  Paul Eggert  <eggert@cs.ucla.edu>

	Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
	In particular this ports to 32-bit sparc Sun cc.
	* eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
	array with a dummy element at specpdl[-1], so that its address can
	be taken portably.
	(unbind_to): Do not copy the binding; not needed, now that we
	copy old_value in the one place where the copy is needed.
	* fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
	* lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
	(union specbinding): Rename from struct specbinding.  Redo layout
	to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
	which is not portable.  With Sun C 5.12 32-bit sparc, the
	declaration causes nargs to be an unsigned bitfield, a behavior
	that the C standard allows; but Emacs wants nargs to be signed.
	The overall type is now a union of structures rather than a
	structure of union of structures, and the 'kind' member is now a
	bitfield, so that the overall type doesn't grow.  All uses changed.
	* process.c (Fmake_serial_process): Remove unnecessary initialization.

1435 1436
2013-06-17  Paul Eggert  <eggert@cs.ucla.edu>

1437 1438 1439
	* frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
	Needed if HAVE_NTGUI.  Reported by Juanma Barranquero.

1440 1441
	* nsfont.m (ns_registry_to_script): Parenthesize while expression.

1442 1443 1444 1445 1446 1447
2013-06-17  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
	unless we know that the window w's frame is a frame object.
	Another attempt at solving bug#14062 and bug#14630.

1448 1449 1450 1451 1452
2013-06-17  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* textprop.c (property_set_type): New enum.
	(add_properties): Allow appending/prepending text properties.
	(add_text_properties_1): Factored out of Fadd_text_properties.
1453
	(Fadd_text_properties): Move all the code into
1454 1455 1456 1457
	add_text_properties_1.
	(Fadd_face_text_property): New function that calls
	add_text_properties_1.

1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544
2013-06-17  Paul Eggert  <eggert@cs.ucla.edu>

	Move functions from lisp.h to individual modules when possible.
	From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
	* alloc.c (XFLOAT_INIT, set_symbol_name):
	* buffer.c (CHECK_OVERLAY):
	* chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
	(set_char_table_parent):
	* coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
	* data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
	(XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
	(blv_value, set_blv_value, set_blv_where, set_blv_defcell)
	(set_blv_valcell):
	* emacs.c (setlocale) [!HAVE_SETLOCALE]:
	* eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
	(specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
	(backtrace_args, backtrace_debug_on_exit):
	* floatfns.c (CHECK_FLOAT):
	* fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
	(set_hash_key_and_value, set_hash_next, set_hash_next_slot)
	(set_hash_hash, set_hash_hash_slot, set_hash_index)
	(set_hash_index_slot):
	* keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
	* marker.c (CHECK_MARKER):
	* textprop.c (CHECK_STRING_OR_BUFFER):
	* window.c (CHECK_WINDOW_CONFIGURATION):
	Move here from lisp.h, and make these functions static rather than
	extern inline.
	* buffer.c (Qoverlayp):
	* data.c (Qsubrp):
	* fns.c (Qhash_table_p):
	* window.c (Qwindow_configuration_p):
	Now static.
	* lisp.h: Remove the abovementioned defns and decls.

	Use functions, not macros, for XINT etc. (Bug#11935).
	In lisp.h, prefer functions to function-like macros, and
	constants to object-like macros, when either will do.  This:
	 . simplifies use, as there's no more need to worry about
	   arguments' side effects being evaluated multiple times.
	 . makes the code easier to debug on some platforms.
	However, when using gcc -O0, keep using function-like macros
	for a few critical operations, for performance reasons.
	This sort of thing isn't needed with gcc -Og, but -Og
	is a GCC 4.8 feature and isn't widely-enough available yet.
	* alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
	Remove enum lsb_bits; no longer needed.
	(allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
	* buffer.c (Qoverlap):
	* data.c (Qsubrp):
	* fns.c (Qhash_table_p):
	Now extern, so lisp.h can use these symbols.
	* dispextern.h: Include character.h, for MAX_CHAR etc.
	(GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
	(SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
	(SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
	(GLYPH_CODE_P): Move here from lisp.h.
	(GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
	(GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
	(GLYPH_MODE_LINE_FACE): Now enums, not macros.
	* eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
	XUNTAG now returns void *.
	* lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
	(lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
	(lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
	(lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
	(lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
	(lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
	(lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
	(lisp_h_XPNTR, lisp_h_XSYMBOL):
	New macros, renamed from their sans-lisp_h_ counterparts.
	(XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
	(CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
	(MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
	(VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
	If compiling via GCC without optimization, define these as macros
	in addition to inline functions.
	To disable this, compile with -DINLINING=0.
	(LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
	(check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
	(make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
	hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
	(INTMASK, VALMASK): Now macros, since static values cannot be
	accessed from extern inline functions.
	(VALMASK): Also a constant, for benefit of old GDB.
	(LISP_INT_TAG_P): Remove; no longer needed as the only caller
	is INTEGERP, which can fold it in.
Juanma Barranquero's avatar
Juanma Barranquero committed
1545
	(XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618
	(make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
	(XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
	(XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
	(CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
	(CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
	(SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
	(ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
	(CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
	(SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
	(SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
	(SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
	(XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
	(HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
	(XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
	(XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
	(XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
	(RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
	(INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
	(MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
	(BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
	(PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
	(TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
	(SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
	(CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
	(CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
	(CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
	(CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
	(CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
	(CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
	(CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
	(CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
	(CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
	Now functions.
	(check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
	(LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
	(VALMASK): Define in one place rather than in two, merging the
	USE_LSB_TAG parts; this is simpler.
	(aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
	(max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
	Move up, to avoid use before definition.
	Also include "globals.h" earlier, for the same reason.
	(make_natnum): New function.
	(XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
	(union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
	(CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
	(KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
	(PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
	(VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
	(char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
	(Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
	(Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
	(Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
	(initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
	(Qwindow_configuration_p, Qimage): New forward declarations.
	(XSETFASTINT): Simplify by rewriting in terms of make_natnum.
	(STRING_COPYIN): Remove; unused.
	(XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
	(xcar_addr, xcdr_addr): New functions.  All uses changed.
	(IEEE_FLOATING_POINT): Now a constant, not a macro.
	(GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
	(SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
	(SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
	(GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
	(TYPE_RANGED_INTEGERP): Simplify.
	(Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
	(setlocale, fixup_locale, synchronize_system_messages_locale)
	(synchronize_system_time_locale) [!HAVE_SETLOCALE]:
	Now empty functions, not macros.
	(functionp): Return bool, not int.
	* window.c (Qwindow_configuration_p): Now extern,
	so window.h can use it.
	* window.h (Qwindowp): Move decl back to lisp.h.

1619 1620 1621 1622 1623
2013-06-15  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fline_pixel_height): New function, required for solving
	bug #14567.

1624 1625 1626 1627
2013-06-15  Paul Eggert  <eggert@cs.ucla.edu>

	* fns.c (Fcopy_sequence): Simplify XTYPE calculation.

1628 1629 1630 1631 1632
2013-06-13  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (syms_of_lread):
	* fns.c (Fprovide): Adjust to new format of after-load-alist.

1633 1634 1635 1636
2013-06-13  Kelly Dean  <kellydeanch@yahoo.com>  (tiny change)

	* fileio.c (Fdo_auto_save): Trap errors in auto-save-hook.  (Bug#14479)

1637 1638 1639 1640
2013-06-12  Xue Fuqiao  <xfq.free@gmail.com>

	* fileio.c (expand_file_name): Doc fix.

1641 1642
2013-06-11  Paul Eggert  <eggert@cs.ucla.edu>

1643 1644 1645 1646 1647
	Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
	* process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
	Wait for self, not for 0.  This can't hurt on GNU or similar
	system, and may help with Cygwin.

1648 1649 1650 1651
	* keyboard.c: Don't use PROP (...) as an lvalue.
	(parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
	Use set_prop (A, B), not PROP (A) = B.

1652 1653 1654 1655 1656
2013-06-10  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (get_it_property): Use it->window instead of generating
	a Lisp object from it->w.

1657 1658 1659 1660 1661
2013-06-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (get_it_property): If it->object is a buffer, pass to
	get-char-property the window that is being rendered, instead of
	the buffer, to support window-specific overlays.  (Bug#14575)
1662 1663 1664 1665 1666
	(compute_display_string_pos): When W is NULL, use the current
	buffer as the object to pass to get-char-property.
	(Fcurrent_bidi_paragraph_direction): Assign NULL to the window
	pointer member of the bidi iterator, since no window is pertinent
	to this function.
1667

1668 1669 1670 1671 1672 1673 1674 1675 1676 1677
2013-06-08  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_fetch_char): Accept additional argument, the window
	being displayed, and pass it to compute_display_string_pos.
	(bidi_level_of_next_char, bidi_resolve_explicit_1)
	(bidi_paragraph_init): All callers changed.

	* xdisp.c (init_from_display_pos, init_iterator)
	(handle_single_display_spec, next_overlay_string)
	(get_overlay_strings_1, reseat_1, reseat_to_string)
1678 1679
	(push_prefix_prop, Fcurrent_bidi_paragraph_direction):
	Set bidi_it.w member from it->w.
1680 1681 1682 1683 1684 1685 1686 1687
	(compute_display_string_pos): Accept additional argument, the
	window being displayed, and pass it to Fget_char_property.
	(Bug#14575)

	* dispextern.h (struct bidi_it): New member w, the window being
	displayed.
	(compute_display_string_pos): Adjust prototype.

1688 1689
2013-06-08  Jan Djärv  <jan.h.d@swipnet.se>

1690
	* xgselect.c: Remove unneeded include xterm.h.
1691 1692 1693 1694

	* process.c (wait_reading_process_output): Check for NS before GLIB.
	GLIB may be linked in due to rsvg, but ns_select must be called.

1695 1696 1697 1698
	* xgselect.c (xg_select): Remove call to window_system_available
	and g_main_context_pending at the top, so Gdk events (i.e. file
	notify) are processed when Emacs is started with -nw.

Eli Zaretskii's avatar
Eli Zaretskii committed
1699 1700 1701 1702 1703 1704 1705 1706
2013-06-07  Eli Zaretskii  <eliz@gnu.org>

	* Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
	(ctagsfiles3): New variable, includes only *.m files.
	(TAGS): Use an explicit language name in the regular expressions,
	to avoid transformation of '/SOMETHING' by MSYS to
	'c:\MSYS\SOMETHING'.

1707 1708 1709 1710
2013-06-07  Richard Copley  <rcopley@gmail.com>  (tiny change)

	* epaths.in: Fix commentary to PATH_SITELOADSEARCH.

1711 1712 1713 1714 1715 1716
2013-06-06  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (note_mouse_highlight): When mouse-highlight is off,
	still need to set the mouse pointer shape and activate help-echo.
	(Bug#14558)

1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736
2013-06-06  Paul Eggert  <eggert@cs.ucla.edu>

	A few porting etc. fixes for the new file monitor code.
	See the thread containing
	<http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
	* gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
	(Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
	(dir_monitor_callback, Fgfile_rm_watch):
	Use assq_no_quit instead of Fassoc, for speed.
	(dir_monitor_callback, Fgfile_rm_watch):
	eassert that the monitor is a fixnum.
	(dir_monitor_callback): No need for CDR_SAFE.
	Simplify building of lisp with alternative tails.
	(Fgfile_add_watch, Fgfile_rm_watch):
	Do not assume glib functions set errno reliably on failure.
	(Fgfile_add_watch): Check that the monitor survives the XIL trick,
	and signal an error otherwise.
	(Fgfile_rm_watch): Prefer CONSP to !NILP.
	Use Fdelq instead of Fdelete, for speed.

1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
2013-06-05  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
	don't insist on being invoked on a highlighted tool-bar button.
	Avoids losing tool-bar functionality when mouse-highlight is nil.
	(note_tool_bar_highlight, note_mode_line_or_margin_highlight):
	Don't highlight when mouse-highlight is nil.
	(note_mouse_highlight): When mouse-highlight is nil, don't return
	right away; instead, run tool-bar and mode-line highlight
	subroutine, clear any existing highlight, and revert the mouse
	pointer to its default shape.  (Bug#14558)

1749 1750 1751 1752
2013-06-05  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.mk (lisp): Add prog-mode.el.

1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766
2013-06-05  Paul Eggert  <eggert@cs.ucla.edu>

	Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
	* process.c (dummy_handler): New function.
	(lib_child_handler): New static var.
	(handle_child_signal): Invoke it.
	(catch_child_signal): If a library has set up a signal handler,
	save it into lib_child_handler.
	(init_process_emacs): If using glib and not on Windows, tickle glib's
	child-handling code so that it initializes its private SIGCHLD handler.
	* syssignal.h (SA_SIGINFO): Default to 0.
	* xterm.c (x_term_init): Remove D-bus hack that I installed on May
	31; it should no longer be needed now.

1767 1768 1769 1770 1771 1772 1773 1774 1775
2013-06-05  Michael Albinus  <michael.albinus@gmx.de>

	* emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.

	* gfilenotify.c (globals_of_gfilenotify): New function.
	(syms_of_gfilenotify): Move global initialization there.

	* lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.

1776 1777 1778 1779 1780 1781 1782
2013-06-05  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
	* keyboard.c (menu_bar_items, tool_bar_items):
	* doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
	not override local keymaps any more.

1783 1784 1785 1786
2013-06-04  Eli Zaretskii  <eliz@gnu.org>

	* window.c (Fpos_visible_in_window_p): Doc fix.  (Bug#14540)

1787 1788
2013-06-03  Eli Zaretskii  <eliz@gnu.org>

1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799
	* w32console.c (initialize_w32_display): Return the dimensions of
	the console window via 2 additional arguments, not via the current
	frame.  This avoids crashes due to overrunning the bounds of
	frame's decode_mode_spec_buffer, which is not resized following
	the change of the frame dimensions from the initial 10x10.

	* w32term.h (w32_initialize_display_info): Adjust prototype.

	* term.c (init_tty): Take dimensions of the frame from the values
	returned by initialize_w32_display.

1800 1801 1802 1803 1804 1805 1806 1807 1808
	* Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
	(ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
	(LIBES): Add $(GFILENOTIFY_LIBS).

	* w32inevt.c (handle_file_notifications): Add dummy implementation
	for !HAVE_W32NOTIFY.

	* w32term.c: Wrap code with HAVE_W32NOTIFY.

1809 1810 1811 1812 1813 1814 1815 1816
2013-06-03  Jan Djärv  <jan.h.d@swipnet.se>

	* xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.

	* process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.

	* Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.

1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838
2013-06-03  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* data.c (pure_write_error):
	Use xsignal2, not Fsignal, as Fsignal might return.
	* eval.c (set_backtrace_debug_on_exit): Now static.
	(backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
	No longer inline.  EXTERN_INLINE is needed only for functions
	defined in .h files.  Reindent function header as per GNU style.
	(backtrace_p, backtrace_top, backtrace_next):
	Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
	compiler or linker.  Add extern decls to pacify gcc -Wall.
	* frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
	Now static.
	* frame.c (free_monitors): Define only on platforms that need it.
	* nsterm.m (ns_term_init):
	* process.c (catch_child_signal):
	Don't worry about whether SIGCHLD is defined, as SIGCHLD is
	defined on all porting targets these days.
	* process.c, process.h (catch_child_signal):
	Make it extern only if NS_IMPL_GNUSTEP is defined.

1839 1840 1841 1842 1843
2013-06-03  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (gettimeofday): Make the signature identical to prototype
	in nt/inc/sys/time.h.

1844 1845 1846 1847 1848 1849 1850 1851 1852 1853
2013-06-03  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
	.gdbinit.

	* keyboard.c (safe_run_hooks_error): Improve error message.

	* data.c (pure_write_error): Add `object' argument.
	* puresize.h (CHECK_IMPURE): Use it.

1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872
2013-06-03  Michael Albinus  <michael.albinus@gmx.de>

	* Makefile.in (NOTIFY_OBJ): New variable.
	(base_obj): Replace inotify.o by $(NOTIFY_OBJ).

	* emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
	Call syms_of_gfilenotify.

	* gfilenotify.c: New file.

	* keyboard.c (Qfile_notify): New variable.  Replaces Qfile_inotify
	and Qfile_w32notify.
	(top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
	HAVE_W32NOTIFY and USE_FILE_NOTIFY.

	* lisp.h: Declare syms_of_gfilenotify.

	* termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.

1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920
2013-06-03  Stefan Monnier  <monnier@iro.umontreal.ca>

	Merge the specpdl and backtrace stacks.  Make the structure of the
	specpdl entries more obvious via a tagged union of structs.
	* lisp.h (BITS_PER_PTRDIFF_T): New constant.
	(enum specbind_tag): New enum.
	(struct specbinding): Make it a tagged union of structs.
	Add a case for backtrace records.
	(specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
	(specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
	(backtrace_debug_on_exit): New accessors.
	(struct backtrace): Remove.
	(struct catchtag): Remove backlist field.
	* data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
	Move to eval.c.
	(Flocal_variable_p): Speed up the common case where the binding is
	already loaded.
	* eval.c (backtrace_list): Remove.
	(set_specpdl_symbol, set_specpdl_old_value): Remove.
	(set_backtrace_args, set_backtrace_nargs)
	(set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
	(backtrace_next): New functions.
	(Fdefvaralias, Fdefvar): Adjust to new specpdl format.
	(unwind_to_catch, internal_lisp_condition_case)
	(internal_condition_case, internal_condition_case_1)
	(internal_condition_case_2, internal_condition_case_n): Don't bother
	with backtrace_list any more.
	(Fsignal): Adjust to new backtrace format.
	(grow_specpdl): Move up.
	(record_in_backtrace): New function.
	(eval_sub, Ffuncall): Use it.
	(apply_lambda): Adjust to new backtrace format.
	(let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
	data.c.
	(specbind): Adjust to new specpdl format.  Simplify.
	(record_unwind_protect, unbind_to): Adjust to new specpdl format.
	(Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
	backtrace format.
	(mark_backtrace): Remove.
	(mark_specpdl, get_backtrace, backtrace_top_function): New functions.
	* xdisp.c (redisplay_internal): Use record_in_backtrace.
	* alloc.c (Fgarbage_collect): Use record_in_backtrace.
	Use mark_specpdl.
	* profiler.c (record_backtrace): Use get_backtrace.
	(handle_profiler_signal): Use backtrace_top_function.
	* .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
	accessor functions.

1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945