ChangeLog 1.1 MB
Newer Older
1 2
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	Fix more problems found by GCC 4.5.2's static checks.

5 6 7
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

8 9 10 11 12 13 14
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

15 16 17
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

18
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
19 20 21
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
22

23 24
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
25 26
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
27
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
28

29 30
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
31
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
32
	* unexec.h: New file.
33 34 35 36 37 38
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
39
	Change as necessary to match prototype in unexec.h.
40

41 42
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
43
	(back_comment, skip_chars): Mark vars as initialized.
44

45 46 47
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

48
	* lread.c (read1): Rewrite so as not to use empty "else".
49
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
50

51 52
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

53 54 55
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

56 57
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
58
	(font_sort_entities): Mark var as initialized.
59

60 61
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

62 63
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
64
	(font_parse_fcname): Remove unused vars.
65
	(font_delete_unmatched): Now static.
66
	(font_get_spec): Remove; unused.
67 68 69
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
70

71
	* fns.c (require_nesting_list, require_unwind): Now static.
72
	(Ffillarray): Rename locals to avoid shadowing.
73

74
	* floatfns.c (domain_error2): Define only if needed.
75
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
76

77 78 79
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

80
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
81
	(Fdefvar): Rewrite so as not to use empty "else".
82 83
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
84
	(Fdefvar): Rename locals to avoid shadowing.
85

86
	* callint.c (quotify_arg, quotify_args): Now static.
87
	(Fcall_interactively): Rename locals to avoid shadowing.
88
	Use const pointer when appropriate.
89

90 91 92 93
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
94 95 96
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
97 98 99
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
100
	(Ftranslate_region_internal): Mark var as initialized.
101

102 103 104
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

105 106 107
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

108 109
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
110
	(default_value, arithcompare, arith_driver, arith_error): Now static.
111
	(store_symval_forwarding): Rename local to avoid shadowing.
112 113
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
114
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
115

116
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
117 118
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
119 120
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
121 122 123 124 125
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
126
	(Fmemory_limit): Cast sbrk's returned value to char *.
127

128 129 130
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

131 132
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

133 134 135 136 137 138 139 140
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
141
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
142
	the race-condition problem in the old DOWNCASE.
143

144 145 146
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
147 148
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
149 150
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
151
	(regex_compile, re_match_2_internal): Mark locals as initialized.
152 153 154 155 156 157 158
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
159

160
	* search.c (boyer_moore): Rename locals to avoid shadowing.
161 162
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
163

164 165
	* search.c (simple_search): Remove unused var.

166 167 168 169
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

170 171
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

172 173 174 175
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
176
	(Fvertical_motion): Mark locals as initialized.
177

178
	* casefiddle.c (casify_object, casify_region): Now static.
179
	(casify_region): Mark local as initialized.
180

181 182
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

183 184 185 186 187 188 189 190 191
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
192 193 194
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

216 217
	* dired.c (directory_files_internal_unwind): Now static.

218 219 220
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
221 222 223
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
224
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
225 226
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
227 228
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
229

230
	* minibuf.c (choose_minibuf_frame_1): Now static.
231 232
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
233

234 235
	* marker.c (bytepos_to_charpos): Remove; unused.

236 237 238
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

239 240
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
241
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
242
	(copy_text): Remove unused local var.
243

244
	* filelock.c (within_one_second): Now static.
245
	(lock_file_1): Rename local to avoid shadowing.
246

247 248 249 250
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
251
	(switch_to_buffer_1): Now static.
252 253
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
254

255
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
256
	Fix pointer signedness issue.
257 258
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
259
	(MAXPATHLEN): Define only if needed.
260

261 262 263
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

264 265 266
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

267
	* sysdep.c (reset_io): Now static.
268
	(wait_for_termination_signal): Remove; unused.
269

270 271 272
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
273
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
274
	(DENSE_TABLE_SIZE): Remove; unused.
275 276 277
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
278

279 280 281
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
282 283 284 285 286
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
287
	(read_key_sequence, read_char): Mark locals as initialized.
288
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
289

290
	* keyboard.h (make_ctrl_char): New decl.
291 292
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
293

294 295
	* lisp.h (force_auto_save_soon): New decl.

296
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
297 298 299
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
300 301
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
302

303 304
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

305 306 307 308 309 310 311
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

312 313
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
314
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
315

316 317
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

318 319 320
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

321 322
	* print.c (print_preprocess): Don't forget font objects.

323 324 325 326
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

327 328 329 330 331
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

332 333 334 335 336 337 338 339
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
340
	(run_protected): Add extern declaration for waiting_for_input.
341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

357 358
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
359
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
360

361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

383 384 385 386 387
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

388 389
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
390 391
	Fix more problems found by GCC 4.5.2's static checks.

392 393
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
394 395
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
396 397
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
398 399 400 401 402
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
403 404 405
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
406

407 408
	* xgselect.c (xg_select): Remove unused var.

409 410 411
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
412
	(my_png_error, my_error_exit): Mark with NO_RETURN.
413

414
	* image.c (clear_image_cache): Now static.
415
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
416
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
417 418
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
419
	(gif_load): Fix pointer signedness.
420 421
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
422

Paul Eggert's avatar
Paul Eggert committed
423 424
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

425 426 427 428 429 430
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
431 432 433 434 435 436 437 438 439 440 441 442
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
443 444
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
445

446 447 448 449
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

450 451 452 453 454
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

455
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
456

457 458
	* fringe.c (update_window_fringes): Remove unused variables.

459 460 461
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

462 463
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
464
	* termcap.c [MSDOS]: Include "msdos.h".
465 466 467 468
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

469
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
470

471 472 473 474 475
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

476 477 478 479
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

480 481 482 483 484 485 486 487 488 489 490 491
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

492
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
493

494
	Fix some minor problems found by GCC 4.5.2's static checks.
495

496 497 498
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
499

500 501 502 503 504
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

505
	* fontset.c (free_realized_fontset): Now static.
506
	(Fset_fontset_font): Rename local to avoid shadowing.
507
	(fontset_font): Mark local as initialized.
508
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
509

510 511
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

512
	* xselect.c (x_disown_buffer_selections): Remove; not used.
513
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
514 515 516
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
517

518 519 520
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
521 522 523 524
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
525
	(Fx_create_frame): Add braces to silence GCC warning.
526
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
527 528
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
529 530 531 532
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
533

534 535
	* xterm.h (x_mouse_leave): New decl.

536 537
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
538 539
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
540
	(XTread_socket): Don't define label "out" unless it's used.
541
	Don't declare local "event" unless it's used.
542 543
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
544 545
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
546 547 548 549 550
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
551
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
552
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
553

554 555
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
556
	(tty_defined_color, merge_face_heights): Now static.
557
	(free_realized_faces_for_fontset): Remove; not used.
558 559
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
560 561
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
562

563
	* terminal.c (store_terminal_param): Now static.
564

565
	* xmenu.c (menu_highlight_callback): Now static.
566
	(set_frame_menubar): Remove unused local.
567
	(xmenu_show): Rename parameter to avoid shadowing.
568 569
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
570 571
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
572

573
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
574
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
575 576
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
577
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
578 579
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
580

Paul Eggert's avatar
Paul Eggert committed
581 582
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

583
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
584 585
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
586

587
	* window.c (display_buffer): Now static.
588 589
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
590 591
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
592
	* dispextern.h (bidi_dump_cached_states): Likewise.
593

594 595 596
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
597 598 599
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
600 601
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
602
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
603

604 605 606
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
607 608 609 610 611 612 613 614 615
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
616 617
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
618
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
619
	(decode_coding_object, encode_coding_object, detect_coding_system):
620 621
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
622 623
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
624
	this initialization is needed.  (Bug#8211)
625 626 627 628 629
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
630

631
	* category.c (hash_get_category_set): Remove unused local var.
632
	(copy_category_table): Now static, since it's not used elsewhere.
633
	* character.c (string_count_byte8): Likewise.
634

635 636 637
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

638 639
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
640 641
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
642
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
643

644
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
645
	(BIDI_BOB): Remove unused macro.
646

647 648
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
649
	* term.c (encode_terminal_code): Likewise.
650

651
	* term.c (encode_terminal_code): Now static.  Remove unused local.
652

Paul Eggert's avatar
Paul Eggert committed
653 654 655 656 657 658 659 660 661 662 663
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

664 665 666 667 668 669 670 671 672
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

673 674
	* term.c (term_mouse_position): Rename local to avoid shadowing.

675 676 677
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

678 679 680 681
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

682 683 684 685 686 687
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

740 741 742 743 744
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
745 746 747 748 749 750 751
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
752
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
753

754 755 756 757 758 759
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

760 761 762 763 764
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

765 766
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

767 768 769
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

794 795 796 797 798
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

799
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
800
	* xdisp.c (redisplay_window): Likewise.
801

802 803 804 805 806 807 808 809
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
810
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
811 812
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
813
	(update_window_cursor): Now static, since it's not used elsewhere.
814
	(SKIP_GLYPHS): Removed unused macro.
815

816 817 818 819
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

820 821 822 823
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
824
2011-03-02  Ken Brown  <kbrown@cornell.edu>
825 826 827

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

828 829 830 831 832 833 834 835 836 837 838 839 840
2011-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	Work around some portability problems with symlinks.

	* fileio.c (Fmake_symbolic_link): Treat ENOSYS specially, and
	generate a special message for it.  Suggested by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00995.html>.
	(Frename_file, Fmake_symbolic_link, Ffile_symlink_p):
	Simplify the code by assuming that the readlink and symlink calls
	exist, even if they always fail on this host.
	(Ffile_readable_p): Likewise, for fifos.
	* config.in: Regenerate.

841 842 843 844 845 846
2011-02-27  Chong Yidong  <cyd@stupidchicken.com>

	* frame.c (store_frame_param): Don't store value directly in
	buffer_list and buried_buffer_list; copy the list and remove dead
	buffers (Bug#7898).

847 848
2011-02-27  Eli Zaretskii  <eliz@gnu.org>

849 850
	* msdos.c (readlink) [DJGPP < 2.04]: New stub function.

Juanma Barranquero's avatar
Juanma Barranquero committed
851
	* msdos.h (readlink) [DJGPP < 2.04]: Declare prototype.
852

853 854
	* w32.c (symlink, readlink): New stub functions.

855 856
2011-02-27  Paul Eggert  <eggert@cs.ucla.edu>

857 858 859
	* scroll.c (CHECK_BOUNDS): #define only if GLYPH_DEBUG.
	This avoids a gcc warning in some configurations.

860 861
	* frame.c (x_set_screen_gamma): Rename local to avoid shadowing.

862 863 864 865
	* frame.h: Avoid gcc -Wmissing-prototypes diagnostics.
	(set_menu_bar_lines, x_get_resource_string): New decls.
	* msdos.c (set_menu_bar_lines): Omit decl.

866 867 868 869 870
	* dispextern.h (struct glyph): Make u.img_id int, not unsigned.
	It's always given int values and used as an int.  This suppresses
	a gcc "comparison of unsigned expression >= 0" warning in some
	configurations.

871 872 873
	* dispnew.c: Rename locals to avoid shadowing.
	(update_text_area, scrolling_window, update_frame_1): Rename locals.

874 875 876 877 878 879 880 881 882 883
2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c: Fix problems uncovered by gcc -Wstrict-prototypes.
	(copy_glyph_row_contents): Remove; not used.
	(frame_row_to_window, check_current_matrix_flags):
	(window_change_signal): Now static, since they're not used elsewhere.
	(check_current_matrix_flags): Surround with "#if 0", since its
	only use is in a comment.  Maybe both the comment and the "#if 0"
	stuff should be removed?

884 885 886 887
	* dispnew.c: Fix problem uncovered by gcc -Wunused-variable.
	(adjust_frame_glyphs_for_window_redisplay): Make 'w' local to the
	contexts that actually need it.

888 889 890 891 892
2011-02-26  Eli Zaretskii  <eliz@gnu.org>

	* s/msdos.h (HAVE_LSTAT): Define for DJGPP >= 2.04.
	(lstat): Define for DJGPP < 2.04.

893 894 895 896 897 898
2011-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Increase size of modes from 10 to 12
	as per recent filemodestring API change.  Reported by Jonas Öster in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg01069.html>.

899
2011-02-23  Ben Key  <bkey76@gmail.com>
900 901 902 903 904 905 906 907 908

	* nsterm.m (ns_draw_window_cursor): Obey the cursor_width argument
	directly, for bar cursors.

2011-02-23  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (set_frame_cursor_types): Don't write an undefined value
	into the frame's cursor_width.

909 910 911 912 913
2011-02-23  Stefan Monnier  <monnier@iro.umontreal.ca>

	* print.c (print_object): Never print old-style backquotes.
	Obey escapeflag for hash tables as well.

914
2011-02-23  Kenichi Handa  <handa@m17n.org>
Kenichi Handa's avatar
Kenichi Handa committed
915 916

	* font.c (font_open_entity): Be sure to set scaled_pixel_size.
917
	(font_find_for_lface): Check if attrs[LFACE_HEIGHT_INDEX] is integer.
Kenichi Handa's avatar
Kenichi Handa committed
918

919 920 921 922
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Simplify and avoid #ifdef.

923 924 925 926
2011-02-22  Wolfgang Jenkner  <wjenkner@inode.at>  (tiny change)

	* lread.c (openp): Correct Boolean typo in last commit.

927 928 929
2011-02-22  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (EmacsView-keyDown:): Don't pass shift-only-modified
930
	key to Emacs, treat as unmodified (go to input manager processing).
931

Paul Eggert's avatar
Paul Eggert committed
932 933 934 935 936 937 938 939 940 941 942 943 944 945
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	Assume S_ISLNK etc. work, since gnulib supports this.
	* config.in: Regenerate.
	* dired.c (lstat): Remove.
	(file_name_completion): Assume S_ISDIR works.
	(file_name_completion_stat): Assume S_ISLNK works.
	Do not bother calling stat unless lstat says it's a symlink.
	* fileio.c (S_ISLNK, S_ISFIFO, S_ISREG, lstat): Remove.
	(Fcopy_file): Assume S_ISREG and S_ISLNK work.
	(check_writable, Ffile_writable_p, Fset_file_times):
	Assume S_ISDIR works.
	(Ffile_readable_p): Use S_IFIFO, not S_ISFIFO, to guess whether
	fifos exist.
Juanma Barranquero's avatar
Juanma Barranquero committed
946
	(Ffile_regular_p, Finsert_file_contents): Assume S_ISREG works.
Paul Eggert's avatar
Paul Eggert committed
947 948 949 950
	* filelock.c (S_ISLNK): Remove.
	* lread.c (openp): Assume S_ISDIR works.
	* xrdb.c (S_ISDIR): Remove.

951 952 953
2011-02-21  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/filemode.$(O)): Move recipe to
Juanma Barranquero's avatar
Juanma Barranquero committed
954
	lib/makefile.w32-in.
955 956 957 958
	($(BLD)/dired.$(O)): Depend on $(EMACS_ROOT)/lib/filemode.h.
	(GLOBAL_SOURCES): Remove filemode.c.
	(OBJ1): Remove $(BLD)/filemode.$(O).

959 960 961 962 963 964 965 966 967 968
2011-02-21  Paul Eggert  <eggert@cs.ucla.edu>

	Import filemode module from gnulib.
	* Makefile.in (base_obj): Remove filemode.o, as it's now in ../lib.
	* deps.mk (dired.o): Depend on ../lib/filemode.h, too.
	(filemode.o): Remove; this is now in ../lib.
	* dired.c: Include <filemode.h>.
	(filemodestring): Remove now-redundant decl.
	* config.in: Regenerate.

969 970 971 972 973
2011-02-20  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/fns.$(O)): Depend on
	$(EMACS_ROOT)/lib/md5.h and on stamp_BLD.

Juanma Barranquero's avatar
Juanma Barranquero committed
974
2011-02-20  Christoph Scholtes  <cschol2112@gmail.com>
975 976 977 978 979

	* makefile.w32-in: Remove md5.$(O).
	($(BLD)/md5.$(O)): Remove prerequisites, moved to
	lib/makefile.w32-in.

980
2011-02-20  Paul Eggert  <eggert@cs.ucla.edu>
981

982 983 984 985 986 987 988 989
	Import crypto/md5 and stdint modules from gnulib.
	* Makefile.in (base_obj): Remove md5.o, since this file
	is in lib now.
	* config.in: Regenerate.
	* md5.h, md5.h: Move to ../lib.
	* deps.mk (md5.o): Remove.
	(fns.o): Depend on ../lib/md5.h, not md5.h.

990 991
2011-02-19  Eli Zaretskii  <eliz@gnu.org>

992 993
	* termcap.c (tputs): Don't declare baud_rate.

994 995
	* s/msdos.h (strtold): Define to _strtold.

996 997
2011-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>

998 999 1000 1001 1002 1003
	* process.c (Fstart_process, Fmake_serial_process)
	(Fmake_network_process, server_accept_connection):
	Use empty_unibyte_string.

	* alloc.c (make_unibyte_string): Don't SET_UNIBYTE redundantly.

1004 1005 1006 1007
	* lread.c (Qdir_ok): New constant.
	(syms_of_lread): Initialize it.
	(openp): Don't ignore directories if the predicate returns dir-ok.

1008 1009
2011-02-18  Eli Zaretskii  <eliz@gnu.org>

1010 1011
	* xdisp.c (display_line): Fix the change made for bug#7939.

1012 1013 1014 1015
	* terminal.c (create_terminal): Use default-keyboard-coding-system
	and default-terminal-coding-system to initialize coding systems of
	the new terminal.  (Bug#7840)

1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
2011-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.h (BYTE_MARK_STACK): New macro.
	(mark_byte_stack): Only declare if BYTE_MARK_STACK is set.

	* bytecode.c (BYTE_MAINTAIN_TOP): New macros.
	(struct byte_stack): Only define `top' and `bottom' if used.
	(mark_byte_stack): Only define if used.
	(BEFORE_POTENTIAL_GC, AFTER_POTENTIAL_GC): Nullify if BYTE_MAINTAIN_TOP
	is not set.
	(Fbyte_code): Don't set `bottom' unless BYTE_MAINTAIN_TOP is set.

	* term.c (OUTPUT_IF): Use OUTPUT.

	* alloc.c (Fgarbage_collect): When using stack scanning, don't
	redundantly scan byte-code stacks, catchlist, and handlerlist.

Jan Djärv's avatar
Jan Djärv committed
1033 1034 1035 1036 1037 1038 1039
2011-02-17  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfns.m (Fx_create_frame, ns_set_name_as_filename)
	(Fns_read_file_name): Replace B_ with BVAR.

	* nsterm.m (ns_term_init): Use KVAR.

1040 1041
2011-02-16  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
1042 1043
	* msdos.c (internal_terminal_init): Use KVAR.

1044 1045 1046 1047 1048
	* w32fns.c (Fx_create_frame): Use KVAR.

	* w32term.c (w32_create_terminal): Use KVAR.

	* s/ms-w32.h (MODE_LINE_BINARY_TEXT): Remove.
1049
	(getloadavg): Declare prototype which was removed from lisp.h.
1050 1051 1052

	* xdisp.c (decode_mode_spec): Don't use MODE_LINE_BINARY_TEXT.

1053 1054
	* fileio.c (Finsert_file_contents, Fwrite_region):
	Remove references to buffer_file_type.
1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067
	(syms_of_fileio): Don't intern and staticpro
	find-buffer-file-type.

	* callproc.c (syms_of_callproc): Remove references to
	buffer_file_type.

	* buffer.c (reset_buffer_local_variables): Don't set
	buffer_file_type.
	(init_buffer_once): Likewise.
	(syms_of_buffer): Don't define buffer-file-type.

	* buffer.h (struct buffer): Remove buffer_file_type.

1068 1069
2011-02-16  Tom Tromey  <tromey@parfait>

1070 1071 1072
	* callint.c (Fcall_interactively): Update for change to field names.
	* doc.c (Fsubstitute_command_keys): Update for change to field names.
	* cmds.c (Fself_insert_command): Update for change to field names.
1073
	* keymap.c (Fcurrent_active_maps, Fkey_binding)
1074
	(Fdescribe_buffer_bindings): Update for change to field names.
1075 1076
	* macros.c (Fstart_kbd_macro, end_kbd_macro, Fend_kbd_macro)
	(store_kbd_macro_char, Fcall_last_kbd_macro, Fexecute_kbd_macro):
1077
	Update for change to field names.
1078 1079 1080 1081 1082 1083
	* keyboard.c (echo_char, echo_dash, echo_now, cancel_echoing)
	(echo_length, echo_truncate, cmd_error, command_loop_1)
	(read_char, kbd_buffer_store_event_hold, make_lispy_event)
	(menu_bar_items, tool_bar_items, read_char_minibuf_menu_prompt)
	(read_key_sequence, Fcommand_execute, Fexecute_extended_command)
	(Fdiscard_input, init_kboard, init_keyboard, mark_kboards):
1084 1085 1086 1087
	Update for change to field names.
	* xfns.c (Fx_create_frame): Update for change to field names.
	* xterm.c (x_connection_closed, x_term_init): Update for change to
	field names.
1088
	* term.c (term_get_fkeys_1, CONDITIONAL_REASSIGN, init_tty):
1089
	Update for change to field names.
1090
	* window.c (window_scroll_pixel_based, window_scroll_line_based):
1091
	Update for change to field names.
1092
	* frame.c (make_frame_without_minibuffer, Fhandle_switch_frame)
1093
	(delete_frame): Update for change to field names.
1094 1095 1096 1097
	* lisp.h (DEFVAR_KBOARD): Update for change to field names.
	* keyboard.h (struct kboard): Rename all Lisp_Object fields.
	(KBOARD_INTERNAL_FIELD, KVAR): New macros.

1098 1099 1100 1101
2011-02-16  Tom Tromey  <tromey@redhat.com>

	* lisp.h (DEFVAR_BUFFER_DEFAULTS): Use BVAR.

Tom Tromey's avatar
Tom Tromey committed
1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146
2011-02-16  Tom Tromey  <tromey@parfait>

	* xfns.c (x_create_tip_frame, Fx_show_tip): Replace B_ with BVAR.
	* xfaces.c (compute_char_face): Replace B_ with BVAR.
	* xdisp.c (pos_visible_p, init_iterator, reseat_1)
	(message_dolog, update_echo_area, ensure_echo_area_buffers)
	(with_echo_area_buffer, setup_echo_area_for_printing)
	(set_message_1, update_menu_bar, update_tool_bar)
	(text_outside_line_unchanged_p, redisplay_internal)
	(try_scrolling, try_cursor_movement, redisplay_window)
	(try_window_reusing_current_matrix, row_containing_pos)
	(try_window_id, get_overlay_arrow_glyph_row, display_line)
	(Fcurrent_bidi_paragraph_direction, display_mode_lines)
	(decode_mode_spec_coding, decode_mode_spec, display_count_lines)
	(get_window_cursor_type, note_mouse_highlight): Replace B_ with
	BVAR.
	* window.c (window_display_table, unshow_buffer, window_loop)
	(window_min_size_2, set_window_buffer, Fset_window_buffer)
	(select_window, Fforce_window_update, temp_output_buffer_show)
	(Fset_window_configuration, save_window_save): Replace B_ with
	BVAR.
	* w32fns.c (x_create_tip_frame, Fx_show_tip, Fw32_shell_execute):
	Replace B_ with BVAR.
	* undo.c (record_point, record_insert, record_delete)
	(record_marker_adjustment, record_first_change)
	(record_property_change, Fundo_boundary, truncate_undo_list)
	(Fprimitive_undo): Replace B_ with BVAR.
	* syntax.h (Vstandard_syntax_table, CURRENT_SYNTAX_TABLE)
	(SETUP_BUFFER_SYNTAX_TABLE): Replace B_ with BVAR.
	* syntax.c (update_syntax_table, dec_bytepos, Fsyntax_table)
	(Fset_syntax_table, Fmodify_syntax_entry, skip_chars)
	(skip_syntaxes, scan_lists): Replace B_ with BVAR.
	* search.c (compile_pattern_1, compile_pattern, looking_at_1)
	(string_match_1, fast_looking_at, newline_cache_on_off)
	(search_command, search_buffer, simple_search, boyer_moore)
	(Freplace_match): Replace B_ with BVAR.
	* process.c (get_process, list_processes_1, Fstart_process)
	(Fmake_serial_process, Fmake_network_process)
	(read_process_output, send_process, exec_sentinel)
	(status_notify, setup_process_coding_systems): Replace B_ with
	BVAR.
	* print.c (PRINTDECLARE, PRINTPREPARE, PRINTFINISH, printchar)
	(strout, print_string, temp_output_buffer_setup, print_object):
	Replace B_ with BVAR.
	* msdos.c (IT_frame_up_to_date): Replace B_ with BVAR.
1147 1148
	* minibuf.c (read_minibuf, get_minibuffer, Fread_buffer):
	Replace B_ with BVAR.
Tom Tromey's avatar
Tom Tromey committed
1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 <