ChangeLog 942 KB
Newer Older
1 2 3 4 5
2013-05-21  Barry OReilly <gundaetiapo@gmail.com>

	* search.c (looking_at_1): Only set last_thing_searched if the match
	changed the match-data (bug#14281).

6 7 8 9 10 11
2013-05-21  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (reseat_at_previous_visible_line_start):
	Already	declared in dispextern.h, so remove it here.
	(move_it_vertically_backward): Likewise.

12 13 14
2013-05-20  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

	* xfns.c (check_x_display_info): Don't use XINT for terminal object.
15
	(Fx_display_pixel_width, Fx_display_pixel_height)
16 17
	(Fx_display_mm_width, Fx_display_mm_height):
	Mention `display-monitor-attributes-list' in docstrings.
18

19 20 21 22 23 24 25 26 27 28 29 30 31 32
	* nsfns.m (ns_get_screen): Remove function.  All uses removed.
	(check_ns_display_info): Sync with check_x_display_info	in xfns.c.
	(Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
	(Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
	(Fx_display_backing_store, Fx_display_visual_class)
	(Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
	(Fx_display_grayscale_p, Fx_display_pixel_width)
	(Fx_display_pixel_height, Fx_display_planes)
	(Fx_display_color_cells): Sync args and docstrings with xfns.c.
	(Fx_display_screens): Don't confuse X11 screens with NS screens.
	(Fx_display_mm_width, Fx_display_mm_height)
	(Fx_display_pixel_width, Fx_display_pixel_width): Return width or
	height for all physical monitors as in X11.

33 34
	* nsterm.m (x_display_pixel_width, x_display_pixel_height):
	Return pixel width or height for all physical monitors as in X11.
35

36 37 38 39 40 41 42 43 44 45 46 47 48
2013-05-18  Paul Eggert  <eggert@cs.ucla.edu>

	Port --enable-gcc-warnings to clang.
	* bytecode.c (exec_byte_code):
	* regex.c:
	Redo diagnostic pragmas to pacify clang, too.
	* dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
	* editfns.c (Fencode_time):
	* fileio.c (file_accessible_directory_p):
	* font.c (font_unparse_xlfd):
	Use '&"string"[index]' instead of '"string" + (index)'.
	* undo.c (user_error): Remove; unused.

49 50
2013-05-16  Eli Zaretskii  <eliz@gnu.org>

51 52 53
	* insdel.c (insert_1_both): Document the arguments, instead of
	referring to insert_1, which no longer exists.

54 55 56 57
	* xdisp.c (message_dolog): If the *Messages* buffer is shown in
	some window, increment windows_or_buffers_changed, so that
	*Messages* display in that window is updated.  (Bug#14408)

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
	* w32.c: Include epaths.h.
	(init_environment): Use cmdproxy.exe without leading directories.
	Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
	case.
	(gettimeofday): Adjust signature and return value to Posix
	expectations.

	* unexw32.c (open_output_file): Delete the existing emacs.exe
	before creating it, to break the hard link to the versioned
	executable.

	* Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
	(ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
	(FIRSTFILE_OBJ): New variables.
	(W32_RES): Rename to EMACSRES.  All users changed.
	(base_obj): Use $(CM_OBJ).
	(ALLOBJS): Use $(FIRSTFILE_OBJ).
	(emacs$(EXEEXT)): Depend on $(ADDSECTION).
	(temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
	$(W32_RES_LINK) before $(LIBES).
	(emacs.res): Depend on $(EMACS_MANIFEST).  Put emacs.rc in nt.

80 81
2013-05-15  Stefan Monnier  <monnier@iro.umontreal.ca>

82 83 84 85
	* makefile.w32-in (DOC): Use just "DOC".

	* Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.

86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
	* process.c: Export default filters and sentinels to Elisp.
	(Qinternal_default_process_sentinel, Qinternal_default_process_filter):
	New constants.
	(pset_filter, pset_sentinel, make_process, Fset_process_filter)
	(Fset_process_sentinel, Fformat_network_address):
	Default to them instead of nil.
	(server_accept_connection): Sentinels can't be nil any more.
	(read_and_dispose_of_process_output): New function, extracted from
	read_process_output.
	(read_process_output): Use it; filters can't be nil.
	(Finternal_default_process_filter): New function, extracted from
	read_process_output.
	(exec_sentinel_unwind): Remove function.
	(exec_sentinel): Don't zilch sentinel while running.
	(status_notify): Sentinels can't be nil.
	(Finternal_default_process_sentinel): New function extracted from
	status_notify.
	(setup_process_coding_systems): Default filter is not nil any more.
	(syms_of_process): Export new Elisp functions and initialize
	new constants.
	* lisp.h (make_lisp_proc): New function.

108 109 110 111
2013-05-15  Stefan Monnier  <monnier@iro.umontreal.ca>

	* regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.

112 113 114
2013-05-14  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
115 116
	unless we know that the window w is a leaf window.
	Another attempt at solving bug#14062.
117

118 119 120 121 122
2013-05-14  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfont.m (ns_spec_to_descriptor): Retain and autorelease
	fdesc (Bug#14375).

123 124 125 126
2013-05-12  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (gif_load): Check that subimages fit (Bug#14345).

127 128 129 130 131 132 133
2013-05-09  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (skip_dyn_eof): New function.
	(read1): Use it to skip the end of a file in response to #@00.

	* doc.c (get_doc_string): Slightly relax the sanity checking.

134 135 136 137 138 139 140 141 142 143 144
2013-05-09  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfns.m: Include IOGraphicsLib.h if Cocoa.
	(Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
	(MonitorInfo): New struct.
	(free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
	(Fns_display_monitor_attributes_list): New functions.
	(display-usable-bounds): Remove.
	(syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
	Qsource.

145 146 147 148 149 150 151
2013-05-09  Paul Eggert  <eggert@cs.ucla.edu>

	* xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
	(GTK_CHECK_VERSION): New macro, if not already defined.
	All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
	replaced by GTK_CHECK_VERSION.

152 153 154 155 156 157
2013-05-08  Paul Eggert  <eggert@cs.ucla.edu>

	* xterm.h (GTK_PREREQ): New macro.
	All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
	to use this macro instead, for consistency and clarity.

158 159 160 161 162 163 164 165 166 167 168
2013-05-08  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (row_for_charpos_p): New function, with code of
	cursor_row_p, but accepts an additional argument CHARPOS instead
	of using a hardcoded PT.
	(cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
	(row_containing_pos): Call row_for_charpos_p instead of partially
	doing the same.  Fixes cursor positioning under longlines-mode
	when longlines-show-effect includes more than one newline, when
	moving the cursor vertically up.

169 170 171 172 173
2013-05-08  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in (ACL_H): New macro.
	($(BLD)/fileio.$(O)): Update dependencies.

174 175
2013-05-07  Paul Eggert  <eggert@cs.ucla.edu>

176 177 178 179 180 181 182 183 184 185 186
	Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
	* Makefile.in (LIB_ACL): New macro.
	(LIBACL_LIBS): Remove.
	(LIBES): Use LIB_ACL, not LIBACL_LIBS.
	* fileio.c: Include <acl.h>.
	Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
	(ACL_NOT_WELL_SUPPORTED): Remove.  All uses replaced by
	!acl_errno_valid.
	(Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
	it ourselves.

187 188 189 190 191 192
	* unexelf.c: Don't assume ElfW (Half) fits in int.
	(entry_address, find_section, unexec): Use ptrdiff_t, not int,
	when dealing with ElfW (Half) values, since they can exceed 2**31
	on 64-bit OpenBSD hosts.  Problem reported privately by Han Boetes.
	(entry_address): Omit unused NUM arg.  All uses changed.

193 194 195 196 197 198
2013-05-07  Juri Linkov  <juri@jurta.org>

	* callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
	to the string converted from number with `Fnumber_to_string'.
	(Bug#14254)

199 200 201 202 203
2013-05-07  Paul Eggert  <eggert@cs.ucla.edu>

	* xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
	This fixes a problem introduced by my previous change.

204 205 206 207
2013-05-07  Glenn Morris  <rgm@gnu.org>

	* lread.c (readchar): Don't read from a dead buffer.  (Bug#14280)

208 209 210 211
2013-05-07  Jan Djärv  <jan.h.d@swipnet.se>

	* xfns.c: Move misplaced ifndef USE_GTK from previous checkin.

Paul Eggert's avatar
Paul Eggert committed
212 213 214 215 216 217 218 219 220 221 222 223 224 225
2013-05-07  Paul Eggert  <eggert@cs.ucla.edu>

	Static checking by GCC 4.8.0.
	* xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
	(x_get_monitor_for_frame, x_make_monitor_attribute_list)
	(x_get_monitor_attributes_fallback)
	(x_get_monitor_attributes_xinerama)
	(x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
	Define only if USE_GTK.
	(free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
	(x_get_monitor_attributes_fallback): Omit unused locals.
	(x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
	Use double, not float, to avoid mixed-mode floating point arithmetic.

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250
2013-05-07  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
	    Jan Djärv  <jan.h.d@swipnet.se>

	* Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
	(XINERAMA_CFLAGS): New macros.
	(ALL_CFLAGS, LIBES): Use them.

	* xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
	include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
	(Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
	(syms_of_xfns): DEFSYM them.
	(struct MonitorInfo): New struct.
	(x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
	(x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
	(x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
	(x_get_monitor_attributes_xinerama): New functions.
	(Fx_display_monitor_attributes_list): New primitive.
	(syms_of_xfns): Defsubr it.

	* xterm.h (x_display_info): Add Xatom_net_workarea and
	Xatom_net_current_desktop.

	* xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
	and dpyinfo->Xatom_net_current_desktop.

251 252 253 254 255 256 257
2013-05-06  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (pos_visible_p): Use the special code for finding the
	beginning of a display property or overlay for any "replacing"
	display property, not just for display strings.  This solves
	incorrect reporting of position by posn-at-point.  (Bug#14241)

258 259
2013-05-06  Paul Eggert  <eggert@cs.ucla.edu>

260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
	* unexelf.c: Fix some 32-bit integer problems, notably when debugging.
	Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
	Verify that ElfW (Half) fits in int.
	(fatal): Use same signature as lisp.h.
	(UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
	configure and build with -DUNEXELF_DEBUG without worrying about
	other modules that use DEBUG.
	(DEBUG_LOG) [UNEXELF_DEBUG]: New macro.  All debug code that prints
	possibly-wide integers now uses it instead of plain fprintf.
	(entry_address): New function, which avoids problems with 32-bit
	overflow on 64-bit hosts.
	(OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
	(round_up): Don't assume the remainder fits in int.
	(find_section): Use bool for boolean.  Simplify debug code.
	(unexec): Don't assume file sizes fit in int or size_t.
	Omit unnecessary trailing newline in 'fatal' format.
	Use strerror rather than outputting decimal error number.
	Remove unused code when emacs is not defined;
	this file relies on Emacs now.
	Don't assume e_phnum and e_shnum are positive.

281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
	* regex.c: Fix problems when DEBUG is defined.
	(extract_number, extract_number_and_incr): Define regardless of
	whether DEBUG is defined; that's simpler and makes the code less
	likely to go stale in the normal case when DEBUG is not defined.
	Return int rather than taking an int * arg.  All callers changed.
	(DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
	Remove, replacing with ...
	(DEBUG_PRINT): New macro.  All callers changed.
	(DEBUG_COMPILES_ARGUMENTS): New macro.
	(print_fastmap, print_partial_compiled_pattern) [DEBUG]:
	(print_compiled_pattern, print_double_string) [DEBUG]:
	Use prototype rather than old-style definition.
	(print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
	(ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
	(POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
	(POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
	Don't assume ptrdiff_t, size_t, and long are the same width as int.
	(POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
	This matters only when DEBUG is defined.

301 302 303 304 305 306 307
2013-05-05  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (set_iterator_to_next): Set the
	ignore_overlay_strings_at_pos_p flag only if we are _really_
	iterating over an overlay string, as indicated by the
	current.overlay_string_index member.  (Bug#14306)

308 309 310 311 312
2013-05-05  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
	to where it is used, to avoid autorelease issues (Bug#14050).

313 314 315 316 317 318 319 320
2013-05-05  Paul Eggert  <eggert@cs.ucla.edu>

	`write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
	* fileio.c (syms_of_fileio): Implement this.
	* filelock.c (create_lock_file): If symbolic links don't work, so
	we use a regular file as a lock file, do not fsync the lock file;
	it's not needed.

321 322 323 324 325 326 327
2013-05-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
	(syms_of_minibuf): Adjust accodingly.
	* lread.c (Fread):
	* callint.c (Fcall_interactively): Adjust calls accordingly.

328 329 330
2013-05-04  Eli Zaretskii  <eliz@gnu.org>

	* dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
331 332
	w->contents is a buffer before computing everything else.
	Use parentheses to disambiguate last part of the condition.
333 334 335 336

	* w32fns.c (w32_wnd_proc): Remove temporary code used to trap
	assertion violations.  (Bug#14062)

337 338 339 340
2013-05-01  David Reitter  <david.reitter@gmail.com>

	* nsfns.m (ns_tooltip): Initialize.

341 342 343 344 345
2013-04-28  Eli Zaretskii  <eliz@gnu.org>

	* coding.c (decode_coding_gap): Don't remove the character before
	a newline unless it's a CR character.  (Bug#14287)

346 347 348 349 350
2013-04-28  Dan Nicolaescu  <dann@gnu.org>

	* dispextern.h (struct face): Move enum face_underline_type
	earlier so that bitfields can be in the same word.

351 352 353 354 355 356 357
2013-04-28  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfns.m (handlePanelKeys): New function.
	(EmacsOpenPanel:performKeyEquivalent:)
	(EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
	arrows/function/control and copy/paste keys (Bug#14296).

358 359 360 361 362 363
2013-04-27  Juri Linkov  <juri@jurta.org>

	* callint.c (Fcall_interactively): Call `Qread_number' for
	interactive code letter `n' instead of using duplicate code.
	(Bug#14254)

364 365 366 367
2013-04-27  Paul Eggert  <eggert@cs.ucla.edu>

	* systime.h (make_timeval): Declare as 'const'.

368 369 370 371 372
2013-04-27  Kenichi Handa  <handa@gnu.org>

	* font.c (font_open_entity): Always open a font of manageable
	size.

Kenichi Handa's avatar
Kenichi Handa committed
373
2013-04-26  Paul Eggert  <eggert@cs.ucla.edu>
374

Paul Eggert's avatar
Paul Eggert committed
375 376 377 378
	Port better to AIX (Bug#14258).
	* lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
	to pacify AIX xlc.

379 380 381 382 383 384
2013-04-24  Kenichi Handa  <handa@gnu.org>

	* coding.c (decode_coding_iso_2022): When an invalid escape
	sequence is encountered, reset the invocation and designation
	status to the safest one.

385 386 387 388 389
2013-04-22  Paul Eggert  <eggert@cs.ucla.edu>

	* Makefile.in (bootstrap-clean): Remove stamp-h1 too.
	Without this fix, "make distclean" leaves stamp-h1 behind.

390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408
2013-04-20  Erik Charlebois  <erikcharlebois@gmail.com>

	* w32fns.c (w32_fullscreen_rect): New function to compute the
	window rectangle for the given fullscreen mode.
	(w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
	longer tunes the window size.  This keeps the window's edges flush
	with the screen and allows the taskbar to hide itself in fullboth.

	* w32term.c (w32fullscreen_hook): 'fullboth' now shows without
	window decorations and uses the entire screen.

	* w32term.h  (w32_fullscreen_rect) Add prototype.
	(struct w32_output): Replace normal_width, normal_height,
	normal_top, and normal_left members with a single normal_placement
	struct.
	(FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
	Remove macros.
	(FRAME_NORMAL_PLACEMENT): New macro.

409 410 411 412
2013-04-16  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Ftest_completion): Silence compiler warning.

413 414 415
2013-04-15  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc): Add more assertions to investigate
Eli Zaretskii's avatar
Eli Zaretskii committed
416
	bug#14062.
417 418 419 420 421 422 423 424 425

	* frame.h (WINDOW_FRAME): Protect macro and its argument with
	parentheses.

	* dispextern.h (CURRENT_MODE_LINE_HEIGHT)
	(CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
	(WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
	parentheses where appropriate.

426 427 428 429
2013-04-14  Paul Eggert  <eggert@cs.ucla.edu>

	* keyboard.c (timer_start_idle): Remove no-longer-used local.

430 431 432 433 434 435 436
2013-04-14  Eli Zaretskii  <eliz@gnu.org>

	* buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
	<left-fringe-width, right-fringe-width, fringes-outside-margins>:
	Mention in the doc string that setting these variables takes
	effect only after a call to set-window-buffer.  (Bug#14200)

437 438 439 440 441 442 443 444 445 446
2013-04-13  Eli Zaretskii  <eliz@gnu.org>

	* indent.c (Fvertical_motion): Don't consider display strings on
	overlay strings as display strings on the buffer position we
	started from.  This prevents vertical cursor motion from jumping
	more than one line when there's an overlay string with a display
	property at end of line.
	Reported by Karl Chen <Karl.Chen@quarl.org> in
	http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.

447 448 449 450 451
2013-04-12  Stefan Monnier  <monnier@iro.umontreal.ca>

	* window.c (select_window): `record_buffer' even if window is
	already selected (bug#14191).

452 453 454 455 456 457 458 459 460
2013-04-11  Eli Zaretskii  <eliz@gnu.org>

	* window.c (Fwindow_end): Test more flags, including the buffer's
	last_overlay_modified flag, to determine whether the window's
	display is really up-to-date.  Prevents the function from
	returning a stale value.  (Bug#14170)
	(Fwindow_line_height): Fix the test for up-to-date-ness of the
	current matrix.

461 462 463
2013-04-10  Eli Zaretskii  <eliz@gnu.org>

	* frame.c (do_switch_frame): Mark the TTY frame we switch to as
464 465
	garbaged only if it is not already the top frame on its TTY.
	This prevents flickering due to constant redrawing of TTY frames when
466 467
	there are GUI frames open in the same session.  (Bug#13864)

468 469 470 471 472
2013-04-10  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
	of marking the idle timers directly.

473 474 475 476 477
2013-04-09  Stefan Monnier  <monnier@iro.umontreal.ca>

	* minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
	tables (bug#14054).

478 479 480 481 482 483 484
2013-04-08  Stefan Monnier  <monnier@iro.umontreal.ca>

	* window.c (select_window): Don't record_buffer while the invariant is
	temporarily broken (bug#14161).

	* fns.c (Fdelq): Don't assume !NILP => CONSP.

485 486 487 488
2013-04-07  Eli Zaretskii  <eliz@gnu.org>

	* fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.

489 490 491 492 493 494
2013-04-07  Romain Francoise  <romain@orebokech.com>

	Ignore additional platform-specific ACL errors (Bug#13702).
	* fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
	(Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.

495 496 497 498 499
2013-03-31  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
	f->output_data.ns.

500 501 502 503 504 505 506 507 508 509 510 511 512
2013-04-07  Paul Eggert  <eggert@cs.ucla.edu>

	Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
	This bug was introduced by my 2013-02-25 change that simplified
	data_start configuration.  Without this change, on GNU/Linux
	an Emacs configured with --enable-profiling fails immediately
	due to a profiler signal.
	* Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
	with these flags.  On platforms where special flags are needed
	when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
	(ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
	(.c.o, .m.o): Compile with $(PROFILING_CFLAGS).

513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
2013-04-07  Dmitry Antipov  <dmantipov@yandex.ru>

	Get rid of some platform-specific functions examining window
	system and its capabilities.  This is a partial rework of the
	2013-04-05 change.
	* lisp.h (have_menus_p): Remove prototype.  This function is
	replaced with platform-independent window_system_available.
	(check_window_system): Move to...
	* frame.h (decode_window_system_frame, window_system_available):
	...here, add new prototypes.
	* frame.c (window_system_available, decode_window_system_frame):
	New functions.
	(check_window_system): Platform-independent now.
	* xterm.h (x_in_use): Remove declaration.
	(check_x_frame):
	* w32term.h (check_x_frame):
	* nsterm.h (check_x_frame): Remove prototypes.  This function
	is replaced with platform-independent decode_window_system_frame.
	* msdos.c (have_menus_p): Remove.
	* nsfns.m (check_window_system, have_menus_p, check_ns_frame):
	Remove platform-specific functions.  Use check_window_system,
	decode_window_system_frame and check_ns_display_info where
	appropriate.  Minor style and comment tweaks.
	* w32fns.c (w32_in_use, check_window_system, have_menus_p)
	(check_x_frame): Likewise.
	* xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
	Likewise.
	* fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
	* nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
	* xmenu.c, xselect.c: All related users changed.

544 545 546 547 548
2013-04-03  Kenichi Handa  <handa@gnu.org>

	The following changes is to optimize the code for reading UTF-8
	files.

549
	* coding.c (check_ascii): Rename from detect_ascii.  Return value
550 551 552 553 554 555 556 557
	changed.  Check EOL format.  Do not call adjust_coding_eol_type
	here.
	(check_utf_8): New function.
	(adjust_coding_eol_type): Do nothing if already adjusted.
	(detect_coding): Compare the return value of check_ascii with
	coding->src_bytes.  Call adjust_coding_eol_type if necessary.
	(decode_coding_gap): Optimize for valid UTF-8.

558 559 560 561 562 563
2013-03-21  Kenichi Handa  <handa@gnu.org>

	* coding.c (syms_of_coding): Cancel previous change.

	* insdel.c (insert_from_gap): Fix previous change.

564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582
2013-04-05  Dmitry Antipov  <dmantipov@yandex.ru>

	Consistently use platform-specific function to detect window system.
	* lisp.h (check_window_system): New prototype.  This function is
	going to replace check_x, check_w32 and check_ns.
	(have_menus_p): Mention msdos.c in comment.
	* fontset.c (check_window_system_func): Remove.  Adjust all users.
	* fontset.h (check_window_system_func): Remove prototype.
	* nsterm.h (check_ns):
	* xterm.h (check_x):
	* w32term.h (check_w32): Likewise.
	* menu.c (Fx_popup_menu): Use check_window_system.
	* msdos.c (check_window_system): Define for MS-DOS.
	* nsfns.m (check_window_system): Define for NS.  Adjust all users.
	* w32fns.c (check_window_system): Likewise for MS-Windows.
	* xfns.c (check_window_system): Likewise for X.
	* font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
	* xfaces.c, xmenu.c: Use check_window_system where appropriate.

583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
2013-04-02  Paul Eggert  <eggert@cs.ucla.edu>

	Prefer < to > in range checks such as 0 <= i && i < N.
	This makes it easier to visualize quantities on a number line.
	This patch doesn't apply to all such range checks,
	only to the range checks affected by the 2013-03-24 change.
	This patch reverts most of the 2013-03-24 change.
	* alloc.c (xpalloc, Fgarbage_collect):
	* ccl.c (ccl_driver, resolve_symbol_ccl_program):
	* character.c (string_escape_byte8):
	* charset.c (read_hex):
	* data.c (cons_to_unsigned):
	* dispnew.c (update_frame_1):
	* doc.c (Fsubstitute_command_keys):
	* doprnt.c (doprnt):
	* editfns.c (hi_time, decode_time_components):
	* fileio.c (file_offset):
	* fns.c (larger_vector, make_hash_table, Fmake_hash_table):
	* font.c (font_intern_prop):
	* frame.c (x_set_alpha):
	* gtkutil.c (get_utf8_string):
	* indent.c (check_display_width):
	* keymap.c (Fkey_description):
	* lisp.h (FIXNUM_OVERFLOW_P, vcopy):
	* lread.c (read1):
	* minibuf.c (read_minibuf_noninteractive):
	* process.c (wait_reading_process_output):
	* search.c (Freplace_match):
	* window.c (get_phys_cursor_glyph):
	* xdisp.c (redisplay_internal):
	* xsmfns.c (smc_save_yourself_CB):
	Prefer < to > for range checks.
	* dispnew.c (sit_for): Don't mishandle NaNs.
	This fixes a bug introduced in the 2013-03-24 change.
	* editfns.c (decode_time_components): Don't hoist comparison.
	This fixes another bug introduced in the 2013-03-24 change.

620 621 622 623 624 625 626
2013-03-31  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (struct frame): Drop scroll_bottom_vpos
	member becaue all real users are dead long ago.
	(FRAME_SCROLL_BOTTOM_VPOS): Remove.
	* xdisp.c (redisplay_internal): Adjust user.

Glenn Morris's avatar
Glenn Morris committed
627 628
2013-03-30  Darren Ho  <darren.hoo@gmail.com>  (tiny change)

629 630 631
	* nsmenu.m (showAtX:Y:for:): setLevel to
	NSPopUpMenuWindowLevel (Bug#13998).

632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648
2013-03-30  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
	(ns_check_pending_open_menu): Declare.

	* nsmenu.m (ns_update_menubar): Correct NSTRACE.
	(x_activate_menubar): Update the menu with title that matches
	ns_get_pending_menu_title, and call
	ns_check_pending_openmenu (Bug#12698).
	(menuWillOpen:): New method.
	(menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).

	* nsterm.m (menu_will_open_state, menu_mouse_point)
	(menu_pending_title): New varaibles.
	(ns_get_pending_menu_title, ns_check_menu_open)
	(ns_check_pending_open_menu): New functions.

649 650 651 652 653 654 655 656 657 658 659 660
2013-03-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* indent.c (current_column_bol_cache): Remove leftover which is not
	used in Fmove_to_column any more.
	(current_column, scan_for_column): Adjust users.
	* keyboard.c (last_point_position_buffer, last_point_position_window):
	Remove leftovers which are not used for recording undo any more.
	(command_loop_1, syms_of_keyboard): Adjust users.
	* xdisp.c (last_max_ascent): Remove leftover which is not used in
	redisplay_window any more.
	(move_it_to): Adjust user.

661 662 663 664 665
2013-03-29  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
	Update dependencies.

666 667 668 669 670 671
2013-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
	(set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
	forward references.

672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725
2013-03-28  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Replace hchild, vchild and buffer slots
	with the only contents slot.  This is possible because each valid
	window may have either the child window (in vertical or horizontal
	combination) or buffer to display (for the leaf window).  Using that,
	a lof of operations to traverse and/or change window hierarchies may
	be simplified.  New member horizontal is used to distinguish between
	horizontal and vertical combinations of internal windows.
	(WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
	(WINDOW_VERTICAL_COMBINATION_P): New macros.
	(WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
	* window.c (wset_hchild, wset_vchild): Remove.  Adjust all users.
	Use contents slot, not buffer, where appropriate.
	(wset_combination): New function.
	(wset_buffer): Add eassert.
	(Fframe_first_window): Simplify the loop reaching first window.
	(Fwindow_buffer): Use WINDOW_LEAF_P.
	(Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
	(Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
	(unshow_buffer): Convert initial debugging check to eassert.
	(replace_window, recombine_windows, Fdelete_other_windows_internal)
	(make_parent_window, window_resize_check, window_resize_apply)
	(resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
	(Fset_window_configuration, delete_all_child_windows, save_window_save):
	Adjust to match struct window changes.
	(window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
	(mark_window_cursors_off, count_windows, get_leaf_windows)
	(foreach_window_1): Simplify the loop.
	* alloc.c (mark_object): Do not check for the leaf window because
	internal windows has no glyph matrices anyway.
	* dispnew.c (clear_window_matrices, showing_window_margins_p)
	(allocate_matrices_for_window_redisplay, fake_current_matrices)
	(allocate_matrices_for_frame_redisplay, free_window_matrices)
	(build_frame_matrix_from_window_tree, mirror_make_current)
	(frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
	(update_window_tree, set_window_update_flags): Simplify the loop.
	(sync_window_with_frame_matrix_rows): Enforce live window.
	Use contents slot, not buffer, where appropriate.
	* frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
	and WINDOW_HORIZONTAL_COMBINATION_P.
	(make_frame_visible_1): Simplify the loop.
	Use contents slot, not buffer, where appropriate.
	* xdisp.c (hscroll_window_tree, mark_window_display_accurate)
	(redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
	(expose_window_tree): Likewise.
	Use contents slot, not buffer, where appropriate.
	* textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
	to avoid deleted windows.  Use contents slot instead of buffer.
	* buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
	* indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
	* nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
	* xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.

726 727
2013-03-28  Eli Zaretskii  <eliz@gnu.org>

728 729 730
	* w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
	identify the reasons for assertion violations in bug#14062 and
	similar ones.
731 732
	(Fx_show_tip): Fix compilation error under
	"--enable-check-lisp-object-type".  (Bug#14073)
733

734 735 736
	* image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
	Reported by <rzl24ozi@gmail.com>.

737 738 739 740
2013-03-28  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (with_echo_area_buffer_unwind_data): Save window
	start marker...
741 742
	(unwind_with_echo_area_buffer): ...to restore it here.
	This is needed to ensure that...
743 744 745 746
	(redisplay_window): ...both window markers are valid here,
	which is verified by eassert.
	* editfns.c (save_excursion_save): Do not assume that
	selected_window always displays the buffer.
747 748
	* buffer.c (Fbuffer_swap_text): Adjust window start markers.
	Fix comment.
749

750 751 752 753 754
2013-03-27  Stefan Monnier  <monnier@iro.umontreal.ca>

	* casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
	the upcase table.

755 756 757 758
2013-03-27  rzl24ozi  <rzl24ozi@gmail.com>  (tiny changes)

	* image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.

759 760 761 762 763 764 765 766
2013-03-27  Eli Zaretskii  <eliz@gnu.org>

	* w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
	since MinGW's w32api headers do.  This avoids compiler warnings.

	* w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
	if already defined.

767 768 769 770
2013-03-26  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.

771 772 773 774 775
2013-03-26  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (style_changed_cb): Check if frame is live and an
	X frame (Bug#14038).

776 777
2013-03-26  Eli Zaretskii  <eliz@gnu.org>

778 779
	* w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
	Define only for _WIN32_WINNT less than 0x0500.
780 781
	(_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
	MinGW64.
Eli Zaretskii's avatar
Eli Zaretskii committed
782 783
	Move inclusion of time.h before sys/time.h, so that MinGW64 could
	see its own definitions of 'struct timeval' and 'struct timezone'.
784

785 786 787 788 789 790
	Fix incompatibilities between MinGW.org and MinGW64 headers.
	* w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.

	* w32.c (REPARSE_DATA_BUFFER): Guard with
	MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.

Jan Djärv's avatar
Jan Djärv committed
791 792 793 794 795
2013-03-25  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c: Include X11/XKBlib.h
	(XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).

796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861
2013-03-24  Andreas Schwab  <schwab@linux-m68k.org>

	* alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
	written backwards.
	* blockinput.h (input_blocked_p): Likewise.
	* bytecode.c (exec_byte_code): Likewise.
	* callproc.c (call_process_kill, call_process_cleanup)
	(Fcall_process): Likewise.
	* ccl.c (ccl_driver, resolve_symbol_ccl_program)
	(Fccl_execute_on_string): Likewise.
	* character.c (string_escape_byte8): Likewise.
	* charset.c (read_hex): Likewise.
	* cm.c (calccost): Likewise.
	* data.c (cons_to_unsigned): Likewise.
	* dired.c (directory_files_internal, file_name_completion):
	Likewise.
	* dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
	(sit_for): Likewise.
	* doc.c (Fsubstitute_command_keys): Likewise.
	* doprnt.c (doprnt): Likewise.
	* editfns.c (hi_time, decode_time_components, Fformat): Likewise.
	* emacsgtkfixed.c: Likewise.
	* fileio.c (file_offset, Fwrite_region): Likewise.
	* floatfns.c (Fexpt, fmod_float): Likewise.
	* fns.c (larger_vector, make_hash_table, Fmake_hash_table):
	Likewise.
	* font.c (font_intern_prop): Likewise.
	* frame.c (x_set_alpha): Likewise.
	* gtkutil.c (get_utf8_string): Likewise.
	* indent.c (check_display_width): Likewise.
	* intervals.c (create_root_interval, rotate_right, rotate_left)
	(split_interval_right, split_interval_left)
	(adjust_intervals_for_insertion, delete_node)
	(interval_deletion_adjustment, adjust_intervals_for_deletion)
	(merge_interval_right, merge_interval_left, copy_intervals)
	(set_intervals_multibyte_1): Likewise.
	* keyboard.c (gobble_input, append_tool_bar_item): Likewise.
	* keymap.c (Fkey_description): Likewise.
	* lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
	* lread.c (openp, read_integer, read1, string_to_number):
	Likewise.
	* menu.c (ensure_menu_items): Likewise.
	* minibuf.c (read_minibuf_noninteractive): Likewise.
	* print.c (printchar, strout): Likewise.
	* process.c (create_process, Faccept_process_output)
	(wait_reading_process_output, read_process_output, send_process)
	(wait_reading_process_output): Likewise.
	* profiler.c (make_log, handle_profiler_signal): Likewise.
	* regex.c (re_exec): Likewise.
	* regex.h: Likewise.
	* search.c (looking_at_1, Freplace_match): Likewise.
	* sysdep.c (get_child_status, procfs_ttyname)
	(procfs_get_total_memory): Likewise.
	* systime.h (EMACS_TIME_VALID_P): Likewise.
	* term.c (dissociate_if_controlling_tty): Likewise.
	* window.c (get_phys_cursor_glyph): Likewise.
	* xdisp.c (init_iterator, redisplay_internal, redisplay_window)
	(try_window_reusing_current_matrix, try_window_id, pint2hrstr):
	Likewise.
	* xfns.c (Fx_window_property): Likewise.
	* xmenu.c (set_frame_menubar): Likewise.
	* xselect.c (x_get_window_property, x_handle_dnd_message):
	Likewise.
	* xsmfns.c (smc_save_yourself_CB): Likewise.
	* xterm.c (x_scroll_bar_set_handle): Likewise.

862 863 864 865 866 867 868
2013-03-24  Dmitry Antipov  <dmantipov@yandex.ru>

	* xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
	to be optional or nil.  Adjust comment and convert it to docstring.
	* xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
	* frame.c (display_x_get_resource, Fx_get_resource): Break long line.

869 870 871 872 873 874 875 876 877 878 879
2013-03-24  Paul Eggert  <eggert@cs.ucla.edu>

	Static checking by GCC 4.8-20130319.
	* image.c (gif_load): Assume pass < 3 to pacify GCC.
	* process.c (Fset_process_datagram_address)
	(Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
	* xdisp.c (get_char_face_and_encoding):
	(get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
	(get_glyph_face_and_encoding): Prepare face before possibly using it.
	(get_per_char_metric): Don't use CHAR2B if it might not be initialized.

880 881
2013-03-24  Ken Brown  <kbrown@cornell.edu>

882 883 884 885
	* w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
	fix compilation on 64-bit Cygwin, where underscores are not
	automatically prepended.

886 887
	* w32term.c (w32_initialize): Silence compiler warning.

888 889
2013-03-23  Eli Zaretskii  <eliz@gnu.org>

890 891
	* w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
	FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
892 893 894 895
	variables, to save and restore frame dimensions.
	Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
	after returning from a 'fullscreen' configuration.
	use SendMessage instead of PostMessage to send the SC_RESTORE message,
896 897 898 899 900 901 902 903
	to avoid races between the main thread and the input thread.

	* w32term.h (struct w32_output): New members normal_width,
	normal_height, normal_top, normal_left, and prev_fsmode.
	(FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
	(FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
	members of a frame.

904 905 906 907 908 909 910 911 912 913 914 915 916 917
	* w32term.c (w32fullscreen_hook): Record last value of the frame's
	'fullscreen' parameter.  Always record previous width and height
	of the frame, except when switching out of maximized modes, so
	that they could be restored correctly, instead of resetting to the
	default frame dimensions.  Send SC_RESTORE command to the frame,
	unless we are going to send SC_MAXIMIZE, to restore the frame
	resize hints in the mouse pointer shown by the window manager.
	(Bug#14032)

	* frame.c (get_frame_param): Now extern for WINDOWSNT as well.

	* lisp.h (get_frame_param): Adjust conditions for prototype
	declaration.

918 919 920 921 922 923 924 925
2013-03-22  Ken Brown  <kbrown@cornell.edu>

	* unexcw.c: Drop unneeded inclusion of w32common.h.
	(report_sheap_usage): Declare.
	(read_exe_header): Add magic numbers for x86_64.
	(fixup_executable): Fix printf format specifier for unsigned long
	argument.

926 927 928 929 930 931 932 933 934 935 936 937
2013-03-22  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (struct frame): Put menu_bar_window under #ifdef
	because this member is not needed when X toolkit is in use.
	(fset_menu_bar_window):
	* dispnew.c (clear_current_matrices, clear_desired_matrices)
	(free_glyphs, update_frame):
	* xdisp.c (expose_frame): Likewise.
	(display_menu_bar): Likewise.  Remove redundant eassert.
	* window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
	toolkit is in use.

938 939
2013-03-21  Paul Eggert  <eggert@cs.ucla.edu>

940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962
	Use functions and constants to manipulate Lisp_Save_Value objects.
	This replaces code that used macros and strings and token-pasting.
	The change makes the C source a bit easier to follow,
	and shrinks the Emacs executable a bit.
	* alloc.c: Verify some properties of Lisp_Save_Value's representation.
	(make_save_value): Change 1st arg from string to enum.  All callers
	changed.
	(INTX): Remove.
	(mark_object): Use if, not #if, for GC_MARK_STACK.
	* lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
	(XSAVE_OBJECT): Now functions, not macros.
	(STRING_BYTES_BOUND): Now just a macro, not a constant too;
	the constant was never used.
	(SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
	(SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
	(SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
	(SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
	New constants.
	(struct Lisp_Save_Value): Replace members area, type0, type1, type2,
	type3 with a single member save_type.  All uses changed.
	(save_type, set_save_pointer, set_save_integer): New functions.
	* print.c (PRINTX): Remove.

963 964
	* alloc.c: Remove redundant static declarations.

965 966 967 968 969 970 971 972 973 974 975
2013-03-20  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_col, top_line, total_lines
	and total_cols from Lisp_Objects to integers.  Adjust comments.
	(wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
	Remove.
	(WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
	(WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
	* dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
	Adjust users where appropriate.

976 977 978 979
2013-03-20  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (struct frame): Drop resx and resy because the same data is
	available from window system-specific output context.  Adjust users.
980 981
	(default_pixels_per_inch_x, default_pixels_per_inch_y):
	New functions to provide defaults when no window system available.
982
	(FRAME_RES_X, FRAME_RES_Y): New macros.
983
	(NUMVAL): Move from xdisp.c.
984 985 986 987 988 989 990 991
	* font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
	(Ffont_face_attributes, Fopen_font):
	* image.c (gs_load):
	* w32font.c (fill_in_logfont):
	* xdisp.c (calc_pixel_width_or_height):
	* xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
	* xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.

992 993 994 995 996 997
2013-03-20  Kenichi Handa  <handa@gnu.org>

	* coding.c (syms_of_coding): Initialize disable_ascii_optimization
	to 1 (temporary workaround until a bug related to ASCII
	optimization is fixed).

998 999 1000 1001 1002 1003
2013-03-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fwindow_combination_limit, Fset_window_combination_limit):
	Signal error if window is not internal.  Adjust docstring.
	(delete_all_child_windows): Use combination_limit to save the buffer.
	(Fset_window_configuration): Adjust accordingly.
1004 1005 1006 1007
	* print.c (syms_of_print): Initialize debugging output not here...
	(init_print_once): ...but in a new function here.
	* lisp.h (init_print_once): Add prototype.
	* emacs.c (main): Add call to init_print_once.  Adjust comments.
1008

1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
2013-03-18  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (window_resize_check, window_resize_apply)
	(window_from_coordinates, recombine_windows, set_window_buffer)
	(make_parent_window, Fwindow_resize_apply, resize_frame_windows)
	(Fsplit_window_internal, Fdelete_window_internal)
	(freeze_window_starts): Use bool for booleans.
	* window.h (window_frame_coordinates, resize_frame_windows)
	(freeze_window_starts, set_window_buffer): Adjust prototypes.

1019 1020 1021 1022
2013-03-17  Stefan Monnier  <monnier@iro.umontreal.ca>

	* dispnew.c (bitch_at_user): Use `user-error'.

1023 1024 1025 1026 1027 1028
2013-03-17  Ken Brown  <kbrown@cornell.edu>

	* dispextern.h (RGB_PIXEL_COLOR): Move here from image.c.  Use it
	as return type of image_background.  (Bug#13981)
	* image.c (RGB_PIXEL_COLOR): Move to dispextern.h.

1029 1030
2013-03-16  Jan Djärv  <jan.h.d@swipnet.se>

1031
	* nsterm.m (updateFrameSize:): Change resize increments if needed.
1032
	(ns_select): Don't return with result uninitialized.
1033

1034 1035 1036
	* nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
	and getDirectory.

1037 1038
	* nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
	New functions.
1039 1040 1041 1042 1043 1044 1045
	(Fns_read_file_name): ret is BOOL.  If ! dir_only_p, don't choose
	directories.  If filename is nil, get directory name (Bug#13932).
	Use getFilename and getDirectory.
	(getFilename, getDirectory): New methods for EmacsSavePanel and
	EmacsOpenPanel.
	(ok:): In EmacsOpenPanel, if we can't choose directories, just return.

1046 1047 1048 1049
2013-03-15  Paul Eggert  <eggert@cs.ucla.edu>

	* coding.c (decode_coding_gap): Fix typo caught by static checking.

1050
2013-03-15  Kenichi Handa  <handa@gnu.org>
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073

	* insdel.c (insert_from_gap): New arg text_at_gap_tail.
	(adjust_after_replace): Make it back to static.  Delete the third
	arg text_at_gap_tail.  Cancel the code for handling it.

	* coding.h (struct coding_system): New member eol_seen.

	* coding.c (detect_ascii): New function.
	(detect_coding): Set coding->head_ascii and coding->eol_seen only
	when the source bytes are actually scanned.  On detecting for
	coding_category_utf_8_auto, call detect_ascii instead of scanning
	source bytes directly.
	(produce_chars): Call insert_from_gap with the new arg 0.
	(encode_coding): Likewise.
	(decode_coding_gap): Control ASCII optimization by the variable
	disable_ascii_optimization instead of #ifndef .. #endif.
	Deccode EOL format according to coding->eol_seen.
	(syms_of_coding): Declare disable-ascii-optimization as a Lisp
	variable.

	* lisp.h (adjust_after_replace): Cancel externing it.
	(insert_from_gap): Adjust prototype.

1074 1075 1076 1077 1078
2013-03-15  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
	FULLSCREEN_MAXIMIZED.  (Bug#13935)

1079 1080 1081 1082 1083 1084 1085
2013-03-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* region-cache.c (find_cache_boundary, move_cache_gap)
	(insert_cache_boundary, delete_cache_boundaries, set_cache_region):
	Simplify debugging check and convert to eassert.  Adjust comment.
	(pp_cache): Put under ENABLE_CHECKING.

1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
2013-03-14  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
	and incorrect code.  Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
	and WM_ACTIVATEAPP.
	(w32fullscreen_hook): If the frame is visible, reset
	f->want_fullscreen flag after changing the frame size.  If the
	frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
	(Bug#13953)

1096 1097 1098 1099 1100 1101 1102
2013-03-13  Daniel Colascione  <dancol@dancol.org>

	* emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
	too so that these builds can use Cygwin's file conversion
	functions.  (We've been building and linking cygw32.o all along
	and just not using it.)

Paul Eggert's avatar
Paul Eggert committed
1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113
2013-03-13  Paul Eggert  <eggert@cs.ucla.edu>

	File synchronization fixes (Bug#13944).
	* Makefile.in (LIB_FDATASYNC): New macro.
	(LIBES): Use it.
	* conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
	* fileio.c (Fwrite_region, write_region_inhibit_fsync):
	Don't worry about HAVE_FSYNC, since a substitute fsync is
	available if the system lacks one.
	(Fwrite_regin): Retry fsync if interrupted.

1114 1115
2013-03-13  Eli Zaretskii  <eliz@gnu.org>

1116
	* w32term.c (w32_read_socket): If the Emacs frame is being
1117 1118 1119
	activated, call w32fullscreen_hook, to make sure the new frame
	dimensions are in effect.  (Bug#13937)

1120 1121 1122 1123
2013-03-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (init_iterator): Simplify because both character and byte
	positions are either specified or -1.  Add eassert.  Adjust comment.
1124 1125
	* window.c (Fscroll_other_window): Use SET_PT_BOTH because both
	character and byte positions can be obtained from marker.
1126

1127 1128
2013-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143
	Static checking by Sun C 5.12.
	* alloc.c (buffer_memory_full) [REL_ALLOC]:
	* bytecode.c (exec_byte_code):
	* dispnew.c (init_display):
	* eval.c (error):
	* fileio.c (Fsubstitute_in_file_name):
	* keyboard.c (Fevent_convert_list):
	* keymap.c (Fsingle_key_description):
	* term.c (maybe_fatal, fatal):
	* xfns.c (Fx_display_backing_store, Fx_display_visual_class):
	* xsmfns.c (Fhandle_save_session):
	Omit unreachable code.
	* keymap.c (map_keymap_char_table_item): Cast void * to
	a function pointer type; the C Standard requires this.

1144 1145 1146 1147 1148 1149
	* sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
	Include <sys/param.h> unconditionally, as that works elsewhere and
	is simpler here.  Include <sys/sysctl.h> if DARWIN_OS ||
	__FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
	and FreeBSD now.

1150 1151 1152 1153
2013-03-11  Paul Eggert  <eggert@cs.ucla.edu>

	* insdel.c (adjust_after_replace): Use bool for boolean.

1154 1155 1156 1157 1158 1159 1160 1161
2013-03-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c: Move keyboard decoding to read_key_sequence.
	(decode_keyboard_code): Remove.
	(tty_read_avail_input): Don't try to decode input.
	(read_decoded_char): New function.
	(read_key_sequence): Use it.

1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186
2013-03-10  Daniel Colascione  <dancol@dancol.org>

	* w32term.h (GUISTR, GUI_ENCODE_FILE, GUI_ENCODE_SYSTEM, GUI_FN)
	(GUI_SDATA, guichar_t): Macros to abstract out differences between
	NTGUI_UNICODE and !NTGUI_UNICODE builds, some moved out of
	w32fns.c.

	* w32term.c (construct_drag_n_drop): Use the above macros to make
	drag-and-drop work for non-ASCII filenames in cygw32 builds.

	* w32fns.c (x_set_name, x_set_title): Use the above macros to
	properly display non-ASCII frame titles in cygw32 builds.

	* w32fns.c (Fw32_shell_execute): Use the above macros to properly
	call ShellExecute in cygw32 builds.

	* w32fn.c (Fx_file_dialog): Use the above macros to simplify the
	common file dialog code.

	* w32fns.c (Ffile_system_info): Remove from cygw32 builds, which
	can just use du like other systems.

	* coding.c (from_unicode_buffer): Declare.
	* coding.c (from_unicode_buffer): Implement.

1187 1188
2013-03-10  Stefan Monnier  <monnier@iro.umontreal.ca>

Stefan Monnier's avatar
Stefan Monnier committed
1189 1190 1191 1192 1193
	* lread.c: Minor cleanup.
	(FROM_FILE_P): New macro.
	(skip_dyn_bytes, unreadchar, read1): Use it.
	(read_list): Consolidate duplicated code.

1194 1195
	* bytecode.c (struct byte_stack): Remove `constants' when unused.

1196 1197 1198 1199 1200 1201
2013-03-10  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (display_tool_bar_line, redisplay_tool_bar)
	(redisplay_internal, set_cursor_from_row, try_window)
	(try_window_id, dump_glyph_row, extend_face_to_end_of_line)
	(display_line, notice_overwritten_cursor)
1202 1203
	(mouse_face_from_buffer_pos, note_mouse_highlight):
	Use MATRIX_ROW_DISPLAYS_TEXT_P.
1204
	(note_mouse_highlight): Use MATRIX_ROW_GLYPH_START.
1205 1206
	(mouse_face_from_string_pos, fast_find_string_pos):
	Use MATRIX_ROW_VPOS.
1207 1208 1209 1210 1211 1212 1213 1214 1215 1216

	* xfns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.

	* w32fns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.

	* xdisp.c (try_cursor_movement): Use MATRIX_ROW and
	MATRIX_MODE_LINE_ROW.

	* dispnew.c (update_window): Use MATRIX_ROW and MATRIX_MODE_LINE_ROW.

1217 1218 1219 1220 1221 1222
2013-03-10  handa  <handa@gnu.org>

	* lisp.h (adjust_after_replace): Extern it.

	* coding.c (detect_coding): Cound the heading ASCII bytes in the
	case of detection for coding_category_utf_8_auto.
1223 1224
	(decode_coding_gap) [not CODING_DISABLE_ASCII_OPTIMIZATION]:
	Skip decoding if all bytes are ASCII.
1225 1226 1227 1228 1229 1230

	* insdel.c (adjust_after_replace): Make it public.  New arg
	text_at_gap_tail.
	(adjust_after_insert): Call adjust_after_replace with the new arg
	value 0.

1231 1232 1233 1234 1235 1236 1237 1238 1239
2013-03-09  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN)
	(POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come
	from Elisp via unread-command-events.

	* keyboard.c (access_keymap_keyremap): Accept nil return value from
	functions to mean "no change".

1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
2013-03-08  Paul Eggert  <eggert@cs.ucla.edu>

	region-cache.c, scroll.c, search.c: Use bool for booleans.
	* lisp.h (compile_pattern):
	* scroll.c (do_scrolling, do_direct_scrolling):
	* search.c (struct regexp_cache, compile_pattern_1)
	(compile_pattern, string_match_1, search_command)
	(trivial_regexp_p, search_buffer, Freplace_match, match_limit)
	(search_regs_saved, Fregexp_quote):
	Use bool for boolean.
	* region-cache.c (region_cache_forward, region_cache_backward):
	Fix comments to match code: these functions return int, not boolean.

1253 1254 1255 1256 1257 1258 1259 1260
2013-03-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* search.c (find_newline): Accept start and end byte positions
	as arguments and allow -1 if not known.
	(find_newline_no_quit): Likewise for start position.
	* lisp.h (find_newline, find_newline_no_quit): Adjust prototype.
	* bidi.c (bidi_find_paragraph_start): Pass byte position to
	find_newline_no_quit, thus eliminating CHAR_TO_BYTE.
1261 1262
	* editfns.c (Fconstrain_to_field): Break long line.
	Adjust call to find_newline.
1263 1264 1265 1266 1267 1268 1269
	* indent.c (vmotion): Adjust calls to find_newline_no_quit.
	Use DEC_BOTH to start next search from the previous buffer
	position, where appropriate.
	* xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
	(get_visually_first_element, move_it_vertically_backward): Likewise.
	Obtain byte position from the display iterator, where appropriate.

1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287
2013-03-08  Paul Eggert  <eggert@cs.ucla.edu>

	print.c, process.c: Use bool for booleans.
	* lisp.h (wait_reading_process_output):
	* print.c (print_output_debug_flag, PRINTDECLARE, printchar)
	(strout, debug_output_compilation_hack, float_to_string, print)
	(print_object):
	* process.c (kbd_is_on_hold, inhibit_sentinels, process_output_skip)
	(decode_status, status_message, create_process, create_pty)
	(Fmake_network_process, Fnetwork_interface_info)
	(wait_reading_process_output, read_process_output)
	(write_queue_push, write_queue_pop, process_send_signal)
	(handle_child_signal, keyboard_bit_set, kbd_on_hold_p):
	* process.h (struct Lisp_Process, inhibit_sentinels, kbd_on_hold_p):
	Use bool for booleans.
	* process.c (Fnetwork_interface_list): Remove unused local.
	(connect_counter): Now EMACS_INT, not int.

1288 1289 1290 1291 1292 1293 1294 1295 1296 1297
2013-03-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* bidi.c (bidi_fetch_char): Swap first and second arguments
	to match other functions accepting character and byte positions.
	Adjust comment.
	(bidi_resolve_explicit_1, bidi_level_of_next_char): Adjust users.
	(bidi_paragraph_init): Likewise.  Use DEC_BOTH which is faster
	when you need just to move to the previous buffer position.
	* xdisp.c (Fcurrent_bidi_paragraph_direction): Use DEC_BOTH.

1298 1299 1300 1301
2013-03-07  Eli Zaretskii  <eliz@gnu.org>

	* .gdbinit (prowlims): Display the enabled_p flag of the row.

1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318
2013-03-07  Dmitry Antipov  <dmantipov@yandex.ru>

	Avoid character to byte conversions in motion subroutines.
	* indent.h (compute_motion, vmotion): Add byte position argument.
	* indent.c (compute_motion): Use it and avoid CHAR_TO_BYTE.
	Add eassert.
	(Fcompute_motion): Break long line.  Adjust call to compute_motion.
	Use list5 for return value.
	(vmotion): Use byte position argument and avoid call to CHAR_TO_BYTE.
	Adjust comments, style and calls to compute_motion.
	(Fvertical_motion): Adjust call to vmotion.
	* window.c (Fdelete_other_windows_internal): Record window start
	byte position and adjust call to vmotion.
	(window_scroll_line_based): Likewise with call to compute_motion.
	Use SET_PT_BOTH.
	(Frecenter): Adjust calls to vmotion.

1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
2013-03-07  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (list2i, list3i): New functions.
	(list4i): Move from window.c and make LISP_INLINE.
	* editfns.c (make_lisp_time):
	* fns.c (Flocale_info):
	* keyboard.c (parse_modifiers):
	* xterm.c (x_ewmh_activate_frame): Use list2i.
	* instel.c (signal_after_change):
	* nsfns.m (Fx_server_version, Fxw_color_values):
	* w32fns.c (Fxw_color_values, Fx_server_version):
	* xfns.c (Fxw_color_values, Fx_server_version): Use list3i.
	* fileio.c (Fvisited_file_modtime):
	* nsfns.m (Fns_display_usable_bounds):
	* w32.c (ltime): Use list4i.

1335 1336
2013-03-06  Eli Zaretskii  <eliz@gnu.org>

1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348
	* search.c (find_newline_no_quit): Rename from find_next_newline.
	Add commentary.

	* lisp.h (find_newline_no_quit): Rename prototype.

	* xdisp.c (back_to_previous_line_start)
	(forward_to_next_line_start, get_visually_first_element)
	(move_it_vertically_backward): Callers of find_newline_no_quit changed.
	* indent.c (vmotion): Callers of find_newline_no_quit changed.
	* bidi.c (bidi_find_paragraph_start): Callers of
	find_newline_no_quit changed.

1349 1350 1351
	* msdos.c: Change encoding to cp850.  (Bug#13879)
	(fr_keyboard, it_keyboard, dk_keyboard): Update keyboard layouts.

1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370
2013-03-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Coding system support cleanup and minor refactoring.
	* coding.h (enum coding_result_code): Remove
	CODING_RESULT_INCONSISTENT_EOL and CODING_RESULT_INSUFFICIENT_MEM.
	(toplevel): Remove unused CODING_MODE_INHIBIT_INCONSISTENT_EOL.
	(CODING_MODE_LAST_BLOCK, CODING_MODE_SELECTIVE_DISPLAY)
	(CODING_MODE_DIRECTION, CODING_MODE_FIXED_DESTINATION)
	(CODING_MODE_SAFE_ENCODING): Rearrange bit values.
	(decode_coding_region, encode_coding_region, decode_coding_string):
	Remove unused compatibility macros.
	* coding.c (Qinconsistent_eol, Qinsufficient_memory): Remove.
	(record_conversion_result): Adjust user.
	(syms_of_coding): Likewise.
	(ALLOC_CONVERSION_WORK_AREA): Use SAFE_ALLOCA.
	(decode_coding, encode_coding): Add USE_SAFE_ALLOCA and SAFE_FREE.
	(decode_coding_object): Simplify since xrealloc never returns NULL.
	Add eassert.

1371
2013-03-06  Paul Eggert  <eggert@cs.ucla.edu>
1372

1373
	Fix a build failure on OpenBSD 4.x and MirBSD (Bug#13881).
1374 1375
	* sysdep.c (list_system_processes)
	[BSD_SYSTEM && !DARWIN_OS && !__FreeBSD__]:
1376
	Make it a stub in this case; otherwise the build might fail,
1377
	and this code hasn't been tested on such hosts anyway.
1378
	Problem reported by Nelson H. F. Beebe in
1379 1380 1381
	<http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00021.html>
	and analyzed by Jérémie Courrèges-Anglas in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00062.html>.
1382

1383 1384 1385 1386 1387 1388 1389 1390
2013-03-06  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (find_next_newline_no_quit): Rename to find_next_newline.
	* xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
	(get_visually_first_element, move_it_vertically_backward): Ajust users.
	* bidi.c (bidi_find_paragraph_start): Likewise.
	* indent.c (vmotion): Likewise.

1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442
2013-03-05  Paul Eggert  <eggert@cs.ucla.edu>

	FILE's lock is now always .#FILE and may be a regular file (Bug#13807).
	* filelock.c: Include <c-ctype.h>.
	(MAX_LFINFO): New top-level constant.
	(lock_info_type): Remove members pid, boot_time.  Add members at,
	dot, colon.  Change user member to be the entire buffer, not a
	pointer.  This allows us to handle the case where a foreign
	pid or boot time exceeds the local range.  All uses changed.
	(LINKS_MIGHT_NOT_WORK): New constant.
	(FREE_LOCK_INFO): Remove, as the pieces no longer need freeing.
	(defined_WINDOWSNT): Remove.
	(MAKE_LOCK_NAME, file_in_lock_file_name):
	Always use .#FILE (not .#-FILE) for the file lock,
	even if it is a regular file.
	(rename_lock_file): New function.
	(create_lock_file): Use it.
	(create_lock_file, read_lock_data):
	Prefer a symbolic link for the lock file, falling back on a
	regular file if symlinks don't work.  Do not try to create
	symlinks on MS-Windows, due to security hassles.  Stick with
	POSIXish functions (open, read, write, close, fchmod, readlink, symlink,
	link, rename, unlink, mkstemp) when creating locks, as a GNUish
	host may be using a Windowsish file system, and cannot use
	MS-Windows-only system calls.  Fall back on mktemp if mkstemp
	doesn't work.  Don't fail merely because of a symlink-contents
	length limit in the current file system; fall back on regular
	files.  Increase the symlink contents length limit to 8 KiB, this
	should be big enough for any real use and doesn't crunch the
	stack.
	(create_lock_file, lock_file_1, read_lock_data):
	Simplify allocation of lock file buffers now that they fit in 8 KiB.
	(lock_file_1): Return error number, not bool.  All callers changed.
	(ELOOP): New macro, if not already defined.
	(read_lock_data): Return size of lock file contents, not Lisp object.
	All callers changed.  Handle a race condition if some other process
	replaces a regular-file lock with a symlink lock or vice versa,
	while we're trying to read the lock.
	(current_lock_owner): Parse contents more carefully, to help avoid
	confusing a regular-file lock with some other application's use
	of the file.  Check for lock file contents being too long, or
	not parsing correctly.
	(current_lock_owner, lock_file):
	Allow foreign pid and boot times that exceed the local range.
	(current_lock_owner, lock_if_free, lock_file):
	Simplify allocation of lock file contents.
	* w32.c (sys_rename_replace): New function, containing most of
	the contents of the old sys_rename.
	(sys_rename): Use it.
	(fchmod): New dummy function.
	* w32.h (sys_rename_replace, fchmod): New decls.

1443 1444 1445 1446 1447 1448 1449
2013-03-05  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_resolve_explicit_1): Don't call CHAR_TO_BYTE or
	bidi_count_bytes, as the callers now arrange for bidi_it->charpos
	to be in sync with bidi_it->bytepos.  Suggested by Dmitry Antipov
	<dmantipov@yandex.ru>.

1450 1451 1452 1453 1454 1455 1456
2013-03-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* composite.c (get_composition_id, fill_gstring_header):
	Use make_uninit_vector where appropriate.
	* font.c (Ffont_get_glyphs, build_style_table): Likewise.
	* xselect.c (clean_local_selection_data): Likewise.

1457 1458 1459 1460 1461 1462
2013-03-04  Paul Eggert  <eggert@cs.ucla.edu>

	Fix misuse of ImageMagick that caused core dump (Bug#13846).
	* image.c (imagemagick_load_image): Calculate height and width
	after flattening the image, not before.

1463 1464 1465 1466 1467 1468
2013-03-04  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (Ffont_get_glyphs): Use convenient LGLYPH_NEW.
	* ftfont.c (ftfont_shape_by_flt): Likewise.
	* w32uniscribe.c (uniscribe_shape): Likewise.

1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2013-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	The lock for FILE is now .#FILE or .#-FILE (Bug#13807).
	The old approach, which fell back on DIR/.#FILE.0 through
	DIR/.#FILE.9, had race conditions that could not be easily fixed.
	If DIR/.#FILE is a non-symlink file, Emacs now does not create a
	lock file for DIR/FILE; that is, DIR/FILE is no longer partly
	protected by a lock if DIR/.#FILE is a non-symlink file ("partly"
	because the locking mechanism was never reliable in that case).
	This patch fixes this and other bugs discovered by a code
	inspection that was prompted by
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00531.html>.
	Also, this patch switches to .#-FILE (not .#FILE) on MS-Windows,
	to avoid interoperability problems between the MS-Windows and
	non-MS-Windows implementations.  MS-Windows and non-MS-Windows
	instances of Emacs now ignore each others' locks.
	* filelock.c (defined_WINDOWSNT): New constant.
	(MAKE_LOCK_NAME, fill_in_lock_file_name):
	Don't create DIR/.#FILE.0 through DIR/.#FILE.9.  Instead, create
	DIR/.#FILE symlinks on non-MS-Windows hosts, and DIR/.#-FILE
	regular files on MS-Windows hosts.
	(MAKE_LOCK_NAME, unlock_file, Ffile_locked_p):
	Use SAFE_ALLOCA to avoid problems with long file names.
	(MAX_LFINFO): Now a local constant, not a global macro.
	(IS_LOCK_FILE): Remove.
	(lock_file_1): Don't inspect errno if symlink call succeeds;
	that's not portable.
	(lock_file): Document that this function can return if lock
	creation fails.
1498
	(lock_file): Don't access freed storage.
1499

Andreas Schwab's avatar
Andreas Schwab committed
1500 1501 1502 1503
2013-03-02  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.h (XPNTR) [!USE_LSB_TAG]: Remove extra paren.  (Bug#13734)

1504 1505 1506 1507 1508 1509
2013-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	* textprop.c: Use bool for booleans.
	(validate_interval_range, Fadd_text_properties)
	(Fremove_text_properties): Prefer bool to int when either works.

1510 1511
2013-03-02  Eli Zaretskii  <eliz@gnu.org>

1512 1513
	* textprop.c (Fadd_text_properties, Fremove_text_properties):
	If the interval tree changes as a side effect of calling
1514 1515 1516
	modify_region, re-do processing starting from the call to
	validate_interval_range.  (Bug#13743)

1517
2013-02-28  Eli Zaretskii  <eliz@gnu.org>
1518 1519 1520 1521

	* w32.c (sys_open): Don't reset the flags for FD in fd_info[].
	(Bug#13546).

1522 1523 1524 1525 1526 1527 1528
2013-02-27  Eli Zaretskii  <eliz@gnu.org>

	* filelock.c (create_lock_file) [WINDOWSNT]: Use _sopen with
	_SH_DENYRW flag, instead of emacs_open, to deny any other process
	access to the lock file until it is written and closed.
	(Bug#13807)

1529 1530 1531 1532 1533 1534
2013-02-27  Paul Eggert  <eggert@cs.ucla.edu>

	* callint.c (Qcall_interactively):
	* macros.c (Qexecute_kbd_macro):
	Now static.

1535 1536 1537 1538
2013-02-26  Bastien Guerry  <bzg@gnu.org>

	* window.c (Frecenter): Tiny docstring enhancement.

Paul Eggert's avatar
Paul Eggert committed
1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555
2013-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	Minor textprop integer cleanup.
	* intervals.h, textprop.c (add_text_properties_from_list):
	Return void, not int, since nobody uses the return value.
	* textprop.c (validate_plist, add_properties, remove_properties)
	(Fadd_text_properties):
	Don't assume list length fits in int.
	(interval_has_all_properties, interval_has_some_properties)
	(interval_has_some_properties_list, add_properties, remove_properties)
	(Fadd_text_properties, Fremove_text_properties)
	(Fremove_list_of_text_properties, text_property_stickiness):
	Use bool for booleans.
	(Fadd_text_properties, Fremove_text_properties):
	(Fremove_list_of_text_properties):
	Reindent do-while as per GNU style.

1556 1557
2013-02-25  Eli Zaretskii  <eliz@gnu.org>

1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585
	Implement CLASH_DETECTION for MS-Windows.

	* filelock.c [WINDOWSNT]: Include w32.h.
	(MAKE_LOCK_NAME): Don't use 'lock', it clashes with MS runtime
	function of that name.  Up-case the macro arguments.
	(IS_LOCK_FILE): New macro.
	(fill_in_lock_file_name): Use IS_LOCK_FILE instead of S_ISLNK.
	(create_lock_file): New function, with body extracted from
	lock_file_1.
	[WINDOWSNT]: Implement lock files by writing a regular file with
	the lock information as its contents.
	(read_lock_data): New function, on Posix platforms just calls
	emacs_readlinkat.
	[WINDOWSNT]: Read the lock info from the file.
	(current_lock_owner): Call read_lock_data instead of calling
	emacs_readlinkat directly.
	(lock_file) [WINDOWSNT]: Run the file name through
	dostounix_filename.

	* w32proc.c (sys_kill): Support the case of SIG = 0, in which case
	just check if the process by that PID exists.

	* w32.c (sys_open): Don't reset the _O_CREAT flag if _O_EXCL is
	also present, as doing so will fail to error out if the file
	already exists.

	* makefile.w32-in ($(BLD)/filelock.$(O)): Depend on src/w32.h.

1586 1587 1588
	* textprop.c (Fadd_text_properties, Fremove_text_properties)
	(Fremove_list_of_text_properties): Skip all of the intervals in
	the region between START and END that already have resp. don't
1589 1590
	have the requested properties, not just the first one.
	Add assertions that the loop afterwards always modifies the
1591 1592
	properties.  (Bug#13743)

1593 1594 1595 1596 1597 1598
2013-02-25  Stefan Monnier  <monnier@iro.umontreal.ca>

	* callint.c (Fcall_interactively): Use the right lexical environment
	for `interactive' specs (bug#13811).
	* eval.c (Feval): Accept a lexical environment.

1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631
2013-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	Simplify data_start configuration (Bug#13783).
	This is a followon simplification to the fix for Bug#13650.
	* Makefile.in (LD_FIRSTFLAG, LIB_GCC, CRT_DIR, LIB_STANDARD)
	(START_FILES): Remove.  All uses removed.
	(otherobj): Remove $(VMLIMIT_OBJ), as it's now first.
	(ALLOBJS): Move here from autodeps.mk, and with VMLIMITS_OBJ first.
	(buildobj.h): Use it.
	($(ALLOBJS)): Depend on globals.h.
	(temacs$(EXEEXT)): Use $(ALLOBJS).
	* autodeps.mk (ALLOBJS): Move to Makefile.in.
	* deps.mk (vm-limit.o):
	* makefile.w32-in ($(BLD)/vm-limit.$(O)):
	Do not depend on mem-limits.h.
	* emacs.c (__do_global_ctors, __do_global_ctors_aux)
	(__do_global_dtors, __CTOR_LIST__, __DTOR_LIST__)
	[__GNUC__ && !ORDINARY_LINK]: Remove.
	* mem-limits.h, pre-crt0.c: Remove.
	* unexaix.c, unexcoff.c: Don't include mem-limits.h.
	* unexcoff.c (etext): New decl.
	(make_hdr): Use DATA_START instead of start_of_data.
	* vm-limit.c: Move most of mem-limits.h's contents here.
	(data_start): New decl.  It's OK if this is approximate,
	so simplify-away some unnecessary exactness.
	(POINTER): Remove; all uses removed.
	(data_space_start): Now char *, to avoid casts.
	(exceeds_lisp_ptr): New function, replacing the old
	EXCEEDS_LISP_PTR macro.  All uses changed.
	(check_memory_limits): Simplify and remove casts.
	(start_of_data) [!CANNOT_DUMP || !SYSTEM_MALLOC]: Remove.
	(memory_warnings): Use data_start instead of start_of_data.

Andreas Schwab's avatar
Andreas Schwab committed
1632 1633 1634 1635 1636
2013-02-24  Andreas Schwab  <schwab@linux-m68k.org>

	* xdisp.c (set_message): Only check for debug-on-message if STRING
	is a string.  (Bug#13797)

1637 1638 1639 1640 1641 1642 1643 1644 1645
2013-02-24  Paul Eggert  <eggert@cs.ucla.edu>

	Fix regression introduced by July 10 filelock.c patch.
	* filelock.c (fill_in_lock_file_name): Fix crash caused by the
	2012-07-10 patch to this file.  Reported by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00533.html>
	and diagnosed by Andreas Schwab in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00534.html>.

Paul Eggert's avatar
Paul Eggert committed
1646 1647 1648 1649 1650 1651 1652 1653
2013-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	Assume C89 or better.
	* ralloc.c (SIZE, POINTER, NIL):
	* vm-limit.c (POINTER):
	Remove, replacing all uses with C89 equivalents.  These old
	symbols were present only for porting to pre-C89 platforms.

1654 1655 1656 1657 1658
2013-02-22  Claudio Bley  <claudio.bley@gmail.com>

	* w32.c (emacs_gnutls_pull): Don't call 'select', and don't loop.
	This avoids warning messages reported as part of Bug#13546.

1659 1660 1661 1662
2013-02-21  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (report_sheap_usage): Fix arguments of message1_no_log.

1663 1664
2013-02-20  Stefan Monnier  <monnier@iro.umontreal.ca>

1665 1666
	* sheap.c (report_sheap_usage): Prefer message1_nolog.