ChangeLog 101 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
2011-04-21  Paul Eggert  <eggert@cs.ucla.edu>

	Make the Lisp reader and string-to-float more consistent.
	* data.c (atof): Remove decl; no longer used or needed.
	(digit_to_number): Move to lread.c.
	(Fstring_to_number): Use new string_to_number function, to be
	consistent with how the Lisp reader treats infinities and NaNs.
	Do not assume that floating-point numbers represent EMACS_INT
	without losing information; this is not true on most 64-bit hosts.
	Avoid double-rounding errors, by insisting on integers when
	parsing non-base-10 numbers, as the documentation specifies.
	* lisp.h (string_to_number): New decl, replacing ...
	(isfloat_string): Remove.
	* lread.c (read1): Do not accept +. and -. as integers; this
	appears to have been a coding error.  Similarly, do not accept
	strings like +-1e0 as floating point numbers.  Do not report
	overflow for integer overflows unless the base is not 10 which
	means we have no simple and reliable way to continue.
	Break out the floating-point parsing into a new
	function string_to_number, so that Fstring_to_number parses
	floating point numbers consistently with the Lisp reader.
	(digit_to_number): Moved here from data.c.  Make it static inline.
	(E_CHAR, EXP_INT): Remove, replacing with ...
	(E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
	(string_to_number): New function, replacing isfloat_string.
	This function checks for valid syntax and produces the resulting
	Lisp float number too.  Rework it so that string-to-number
	no longer mishandles examples like "1.0e+".

30 31
2011-04-20  Paul Eggert  <eggert@cs.ucla.edu>

32 33 34
	* textprop.c (set_text_properties_1): Rewrite for clarity,
	and to avoid GCC warning about integer overflow.

35 36 37 38 39 40
	* intervals.h (struct interval): Use EMACS_INT for members
	where EMACS_UINT might cause problems.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
	(CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
	* intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
	All uses changed.
41 42
	(offset_intervals): Tell GCC not to worry about length overflow
	when negating a negative length.
43

44 45 46
	* alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
	(overrun_check_free): Likewise.

47 48 49 50
	* alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
	in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
	word size.

51 52 53 54 55 56
	* gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(gnutls_make_error): Rename local to avoid shadowing.
	(gnutls_emacs_global_deinit): ifdef out; not used.
	(Fgnutls_boot): Use const for pointer to readonly storage.
	Comment out unused local.  Fix pointer signedness problems.

57 58 59 60
	* lread.c (openp): Don't stuff size_t into an 'int'.
	Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
	about possible signed overflow.

61 62 63 64 65
	* gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(GDK_KEY_g): Don't define if already defined.
	(xg_prepare_tooltip): Avoid pointer signedness problem.
	(xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.

66 67 68
	* process.c (Fnetwork_interface_info): Avoid left-shift undefined
	behavior with 1 << 31.  GCC 4.6.0 warns about this on 32-bit hosts.

69 70 71 72
	* xfns.c (Fx_window_property): Simplify a bit,
	to make a bit faster and to avoid GCC 4.6.0 warning.
	* xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.

73 74
	* fns.c (internal_equal): Don't assume size_t fits in int.

75 76
	* alloc.c (compact_small_strings): Tighten assertion a little.

77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
	Replace pEd with more-general pI, and fix some printf arg casts.
	* lisp.h (pI): New macro, generalizing old pEd macro to other
	conversion specifiers.  For example, use "...%"pI"d..." rather
	than "...%"pEd"...".
	(pEd): Remove.  All uses replaced with similar uses of pI.
	* src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
	* alloc.c (check_pure_size): Don't overflow by converting size to int.
	* bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
	* data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
	* dbusbind.c (xd_append_arg): Use pI to avoid cast.
	(Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
	* font.c (font_unparse_xlfd): Avoid potential buffer overrun on
	64-bit hosts.
	(font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
	* keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
	* print.c (safe_debug_print, print_object): Likewise.
	(print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
	to int.
95 96
	Use pI instead of if-then-else-abort.  Use %p to avoid casts,
	avoiding the 0 flag, which is not portable.
97 98 99 100 101
	* process.c (Fmake_network_process): Use pI to avoid cast.
	* region-cache.c (pp_cache): Likewise.
	* xdisp.c (decode_mode_spec): Likewise.
	* xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
	behavior on 64-bit hosts with printf arg.
102
	* xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
103 104 105
	(x_stop_queuing_selection_requests): Likewise.
	(x_get_window_property): Don't truncate byte count to an 'int'
	when tracing.
106

107 108 109 110 111
	* frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
	here, since it parses constructs like leading '-' and spaces,
	which are not wanted; and it overflows with large numbers.
	Instead, simply match F[0-9]+, which is what is wanted anyway.

112 113 114 115 116 117 118 119 120
	* alloc.c: Remove unportable assumptions about struct layout.
	(SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
	(SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
	(allocate_vectorlike, make_pure_vector): Use the new macros,
	plus offsetof, to remove unportable assumptions about struct layout.
	These assumptions hold on all porting targets that I know of, but
	they are not guaranteed, they're easy to remove, and removing them
	makes further changes easier.

121 122
	* alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
	This doesn't fix a bug but makes the code clearer.
123 124
	(string_overrun_cookie): Now const.  Use initializers that
	don't formally overflow signed char, to avoid warnings.
125 126
	(allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
	can cause Emacs to crash when string overrun checking is enabled.
127 128 129
	(allocate_buffer): Don't assume sizeof (struct buffer) is a
	multiple of sizeof (EMACS_INT); it need not be, if
	alignof(EMACS_INT) < sizeof (EMACS_INT).
130
	(check_sblock, check_string_bytes, check_string_free_list): Protoize.
131

132 133 134 135 136 137 138 139
2011-04-19  Eli Zaretskii  <eliz@gnu.org>

	* syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
	gl_state.e_property when gl_state.object is Qt.

	* insdel.c (make_gap_larger): Remove limitation of buffer size
	to <= INT_MAX.

140 141 142 143 144 145 146 147 148 149
2011-04-18  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (lookup_glyphless_char_display)
	(produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.
	(Vglyphless_char_display): Document it.

	* term.c (produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.

Chong Yidong's avatar
Chong Yidong committed
150 151 152 153 154 155 156 157 158
2011-04-17  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (get_next_display_element): Remove unnecessary ifdefs.

	* termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.

	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
	definition for no-X builds.

159
2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>
160

161 162
	Static checks with GCC 4.6.0 and non-default toolkits.

163 164
	* s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.

165 166 167 168
	* process.c (keyboard_bit_set): Define only if SIGIO.
	(send_process_trap): Mark it with NO_RETURN if it doesn't return.
	(send_process): Repair possible setjmp clobbering.

169 170
	* s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.

171 172
	* eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.

173 174
	* data.c (arith_error): Mark with NO_RETURN if it doesn't return.

175 176 177
	* alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
	Define only if needed.

178 179
	* sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
	by pacifying GCC about it.  Maybe it's time to retire it?
180
	* xfaces.c (USG, __TIMEVAL__): Likewise.
181

182 183
	* dispextern.h (struct redisplay_interface): Rename param
	to avoid shadowing.
184
	* termhooks.h (struct terminal): Likewise.
185
	* xterm.c (xembed_send_message): Likewise.
186

187 188 189
	* insdel.c (make_gap_smaller): Define only if
	USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.

190 191 192
	* keyboard.c (read_char): Make a var volatile so longjmp won't clobber
	it.

193 194 195
	* emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
	so that we aren't warned about unused symbols.

196 197
	* xfns.c (Fx_file_dialog): Rename local to avoid shadowing.

198
	* xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
199

200 201
	* xfns.c (x_real_positions): Mark locals as initialized.

202 203
	* xmenu.c (xmenu_show): Don't use uninitialized vars.

204 205
	* xterm.c: Fix problems found by static analysis with other toolkits.
	(toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
206 207
	(x_dispatch_event): Declare static if USE_GTK, and
	define if USE_GTK || USE_X_TOOLKIT.
208
	(SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
209
	* xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
210 211 212
	* xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
	defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.

213 214 215 216 217 218
	* xmenu.c (menu_help_callback): Pointer type fixes.
	Use const pointers when pointing at readonly data.  Avoid pointer
	signedness clashes.
	(FALSE): Remove unused macro.
	(update_frame_menubar): Remove unused decl.

219 220
	* xfns.c (Fx_hide_tip): Move locals to avoid shadowing.

221 222 223 224
	* menu.c (push_submenu_start, push_submenu_end): Do not define unless
	USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
	(single_menu_item): Rename local to avoid shadowing.

225 226
	* keyboard.c (make_lispy_event): Remove unused local var.

227 228 229
	* frame.c, frame.h (x_get_resource_string): Bring this back, but
	only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.

230 231 232 233 234
	* bitmaps: Change bitmaps from unsigned char back to the X11
	compatible char.  Avoid the old compiler warnings about
	out-of-range initializers by using, for example, '\xab' rather
	than 0xab.

235 236 237
	* xgselect.c (xgselect_initialize): Check vs interface
	even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).

238 239
	* xmenu.c (xmenu_show): Rename parm to avoid shadowing.

240 241 242
	* xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
	to read-only memory.

243 244
	* fns.c (vector): Remove; this old hack is no longer needed.

245
	* xsmfns.c (create_client_leader_window): Rename shadowing arg.
Paul Eggert's avatar
Paul Eggert committed
246
	Remove unused var.
247
	(gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
248

249
	* xrdb.c (x_load_resources): Omit unused local.
250

251
	* xfns.c (free_frame_menubar, atof): Remove duplicate decls.
252
	(x_window): Rename locals to avoid shadowing.
253
	(USG): Use the kludged USG macro, to pacify gcc.
254

255
	* xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
256
	(x_term_init): Remove local to avoid shadowing.
257

258
	* xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
259 260 261 262

	* xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
	USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.

263 264
2011-04-16  Eli Zaretskii  <eliz@gnu.org>

265 266
	* gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.

267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298
	Fix regex.c, syntax.c and friends for buffers > 2GB.
	* syntax.h (struct gl_state_s): Declare character position members
	EMACS_INT.

	* syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.

	* textprop.c (verify_interval_modification, interval_of): Declare
	arguments EMACS_INT.

	* intervals.c (adjust_intervals_for_insertion): Declare arguments
	EMACS_INT.

	* intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.

	* indent.c (Fvertical_motion): Local variable it_start is now
	EMACS_INT.

	* regex.c (re_match, re_match_2, re_match_2_internal)
	(bcmp_translate, regcomp, regexec, print_double_string)
	(group_in_compile_stack, re_search, re_search_2, regex_compile)
	(re_compile_pattern, re_exec): Declare arguments and local
	variables `size_t' and `ssize_t' and return values `regoff_t', as
	appropriate.
	(POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
	(CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
	<compile_stack_type>: `size' and `avail' are now `size_t'.

	* regex.h <regoff_t>: Use ssize_t, not int.
	(re_search, re_search_2, re_match, re_match_2): Arguments that
	specify buffer/string position and length are now ssize_t and
	size_t.  Return type is regoff_t.

299 300 301 302 303 304 305 306 307 308
2011-04-16  Ben Key  <bkey76@gmail.com>

	* nsfont.m: Fixed bugs in ns_get_family and
	ns_descriptor_to_entity that were caused by using free to
	deallocate memory blocks that were allocated by xmalloc (via
	xstrdup).  This caused Emacs to crash when compiled with
	XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
	--enable-checking=xmallocoverrun).  xfree is now used to
	deallocate these memory blocks.

Paul Eggert's avatar
Paul Eggert committed
309
2011-04-15  Paul Eggert  <eggert@cs.ucla.edu>
310

311 312
	* sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.

313 314 315 316 317 318 319 320
	emacs_write: Accept and return EMACS_INT for sizes.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
	et seq.
	* gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
	Accept and return EMACS_INT.
	(emacs_gnutls_write): Return the number of bytes written on
	partial writes.
	* sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
321 322
	(emacs_read, emacs_write): Remove check for negative size, as the
	Emacs source code has been audited now.
323 324
	* sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
	(emacs_read, emacs_write): Use it.
325 326 327
	* process.c (send_process): Adjust to the new signatures of
	emacs_write and emacs_gnutls_write.  Do not attempt to store
	a byte offset into an 'int'; it might overflow.
328
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
329

330 331
	* sound.c: Don't assume sizes fit in 'int'.
	(struct sound_device.period_size, alsa_period_size):
332
	Return EMACS_INT, not int.
333
	(struct sound_device.write, vox_write, alsa_write):
334 335
	Accept EMACS_INT, not int.
	(wav_play, au_play): Use EMACS_INT to store sizes and to
336 337
	record read return values.

338 339
2011-04-15  Ben Key  <bkey76@gmail.com>

340 341 342 343
	* keyboard.c (Qundefined): Don't declare static since it is used
	in nsfns.m.
	* xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
	static since they are used in nsfont.m.
344

345 346 347 348 349
2011-04-15  Stefan Monnier  <monnier@iro.umontreal.ca>

	* process.c (Qprocessp): Don't declare static.
	* lisp.h (Qprocessp): Declare again.

350 351 352 353
2011-04-15  Juanma Barranquero  <lekktu@gmail.com>

	* font.c (Qopentype): Don't make static (used from w32uniscribe.c).

354 355
2011-04-14  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
356
	Improve C-level modularity by making more things 'static'.
357

358 359 360 361 362 363 364 365
	Don't publish debugger-only interfaces to other modules.
	* lisp.h (safe_debug_print, debug_output_compilation_hack):
	(verify_bytepos, count_markers): Move decls to the only modules
	that need them.
	* region-cache.h (pp_cache): Likewise.
	* window.h (check_all_windows): Likewise.
	* marker.c, print.c, region-cache.c, window.c: Decls moved here.

366 367 368
	* sysdep.c (croak): Now static, if
	defined TIOCNOTTY || defined USG5 || defined CYGWIN.
	* syssignal.h (croak): Declare only if not static.
369 370 371 372

	* alloc.c (refill_memory_reserve): Now static if
	!defined REL_ALLOC || defined SYSTEM_MALLOC.
	* lisp.h (refill_memory_reserve): Declare only if not static.
373

374 375 376
	* xsettings.c, xsettings.h (xsettings_get_system_normal_font):
	Define only if USE_LUCID.

377 378
	* xrdb.c (x_customization_string, x_rm_string): Now static.

379 380 381
	* xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
	* xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.

382 383 384
	* xdisp.c (draw_row_with_mouse_face): Now static.
	* dispextern.h (draw_row_with_mouse_fave): Remove decl.

385 386
	* window.h (check_all_windows): Mark externally visible.

387 388 389 390 391 392
	* window.c (window_deletion_count): Now static.

	* undo.c: Make symbols static if they're not exported.
	(last_undo_buffer, last_boundary_position, pending_boundary):
	Now static.

393 394 395
	* textprop.c (interval_insert_behind_hooks): Now static.
	(interval_insert_in_front_hooks): Likewise.

396 397 398 399 400 401 402
	* term.c: Make symbols static if they're not exported.
	(tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
	(max_frame_lines, tty_set_terminal_modes):
	(tty_reset_terminal_modes, tty_turn_off_highlight):
	(get_tty_terminal): Now static.
	(term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
	* termhooks.h (term_mouse_moveto): Do not declare if
Paul Eggert's avatar
Paul Eggert committed
403
	HAVE_WINDOW_SYSTEM.
404 405 406
	* dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
	(tty_turn_off_highlight, get_tty_terminal): Remove decls.

407 408 409 410 411 412 413 414
	* sysdep.c: Make symbols static if they're not exported.
	(emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
	Now static.
	(sigprocmask_set, full_mask): Remove; unused.
	(wait_debugging): Mark as visible.
	* syssignal.h (SIGFULLMASK, full_mask): Remove decls.
	* systty.h (emacs_get_tty, emacs_set_tty): Remove decls.

415 416
	* syntax.c (syntax_temp): Define only if !__GNUC__.

417 418
	* sound.c (current_sound_device, current_sound): Now static.

419 420
	* search.c (searchbufs, searchbuf_head): Now static.

421 422 423
	* scroll.c (scroll_cost): Remove; unused.
	* dispextern.h (scroll_cost): Remove decl.

424 425
	* region-cache.h (pp_cache): Mark as externally visible.

426 427 428 429 430 431 432 433
	* process.c: Make symbols static if they're not exported.
	(process_tick, update_tick, create_process, chan_process):
	(Vprocess_alist, proc_buffered_char, datagram_access):
	(fd_callback_data, send_process_frame, process_sent_to): Now static.
	(deactivate_process): Mark defn as static, as well as decl.
	* lisp.h (create_process): Remove decl.
	* process.h (chan_process, Vprocess_alist): Remove decls.

434 435 436 437 438 439 440 441
	* print.c: Make symbols static if they're not exported.
	(print_depth, new_backquote_output, being_printed, print_buffer):
	(print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
	(print_interval, print_number_index, initial_stderr_stream):
	Now static.
	* lisp.h (Fprinc): Remove decl.
	(debug_output_compilation_hack): Mark as externally visible.

442 443 444 445
	* sysdep.c (croak): Move decl from here to syssignal.h.
	* syssignal.h (croak): Put it here, so the API can be checked when
	'croak' is called from dissociate_if_controlling_tty.

446 447 448 449
	* minibuf.c: Make symbols static if they're not exported.
	(minibuf_save_list, choose_minibuf_frame): Now static.
	* lisp.h (choose_minibuf_frame): Remove decl.

450 451
	* lisp.h (verify_bytepos, count_markers): Mark as externally visible.

452 453 454 455 456 457
	* lread.c: Make symbols static if they're not exported.
	(read_objects, initial_obarray, oblookup_last_bucket_number):
	Now static.
	(make_symbol): Remove; unused.
	* lisp.h (initial_obarray, make_symbol): Remove decls.

458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
	* keyboard.c: Make symbols static if they're not exported.
	(single_kboard, recent_keys_index, total_keys, recent_keys):
	(this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
	(this_single_command_key_start, echoing, last_auto_save):
	(read_key_sequence_cmd, dribble, recursive_edit_unwind):
	(command_loop, echo_now, keyboard_init_hook, help_char_p):
	(quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
	(Vlispy_mouse_stem, double_click_count):
	Now static.
	(force_auto_save_soon): Define only if SIGDANGER.
	(ignore_mouse_drag_p): Now static if
	!defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
	(print_help): Remove; unused.
	(stop_character, last_timer_event): Mark as externally visible.
	* keyboard.h (ignore_mouse_drag_p): Declare only if
	defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
	(echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
	* lisp.h (echoing): Remove decl.
	(force_auto_save_soon): Declare only if SIGDANGER.
	* xdisp.c (redisplay_window): Simplify code, to make it more
	obvious that ignore_mouse_drag_p is not accessed if !defined
	USE_GTK && !defined HAVE_NS.

481 482 483 484 485
	* intervals.c: Make symbols static if they're not exported.
	(merge_properties_sticky, merge_interval_right, delete_interval):
	Now static.
	* intervals.h (merge_interval_right, delete_interval): Remove decls.

486 487 488 489
	* insdel.c: Make symbols static if they're not exported.
	However, leave prepare_to_modify_buffer alone.  It's never
	called from outside this function, but that appears to be a bug.
	(combine_after_change_list, combine_after_change_buffer):
490
	(adjust_after_replace, signal_before_change): Now static.
491 492
	(adjust_after_replace_noundo): Remove; unused.
	* lisp.h (adjust_after_replace, adjust_after_replace_noundo):
493
	(signal_before_change): Remove decls.
494

495 496
	* indent.c (val_compute_motion, val_vmotion): Now static.

497 498 499 500 501 502
	* image.c: Make symbols static if they're not exported.
	* dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
	if USE_GTK.
	* image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
	(xpm_color_cache, ct_table, ct_colors_allocated): Now static.

503 504 505
	* fringe.c (standard_bitmaps): Now static.
	(max_used_fringe_bitmap): Now static, unless HAVE_NS.

506 507 508 509 510 511 512 513 514 515
	* frame.c: Make symbols static if they're not exported.
	(x_report_frame_params, make_terminal_frame): Now static.
	(get_frame_param): Now static, unless HAVE_NS.
	(x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
	(x_get_resource_string): Remove; not used.
	* frame.h (make_terminal_frame, x_report_frame_params):
	(x_get_resource_string); Remove decls.
	(x_fullscreen_adjust): Declare only if WINDOWSNT.
	* lisp.h (get_frame_param): Declare only if HAVE_NS.

516 517 518 519 520 521 522 523 524 525 526 527 528
	* font.c, fontset.c: Make symbols static if they're not exported.
	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
	(FACE_SUITABLE_FOR_CHAR_P): Use it.
	* font.c (font_close_object): Now static.
	* font.h (font_close_object): Remove.
	* fontset.c (FONTSET_OBJLIST): Remove.
	(free_realized_fontset) #if-0 the body, which does nothing.
	(face_suitable_for_char_p): #if-0, as it's never called.
	* fontset.h (face_suitable_for_char_p): Remove decl.
	* xfaces.c (face_at_string_position): Use
	FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
	since 0 is always ASCII.

529 530
	* fns.c (weak_hash_tables): Now static.

531 532 533 534
	* fileio.c: Make symbols static if they're not exported.
	(auto_saving, auto_save_mode_bits, auto_save_error_occurred):
	(Vwrite_region_annotation_buffers): Now static.

535 536 537 538
	* eval.c: Make symbols static if they're not exported.
	(backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
	* lisp.h (backtrace_list): Remove decl.

539 540 541 542 543 544 545 546 547 548
	* emacs.c: Make symbols static if they're not exported.
	(malloc_state_ptr, malloc_using_checking, syms_of_emacs):
	(fatal_error_code, fatal_error_signal_hook, standard_args):
	Now static.
	(fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
	(DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
	(__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
	* lisp.h (fatal_error_signal_hook): Remove decl.
	(fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.

549 550 551 552 553
	* editfns.c: Move a (normally-unused) function to its only use.
	* editfns.c, lisp.h (get_operating_system_release): Remove.
	* process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
	worth the hassle of breaking this out.

554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
	* xterm.c: Make symbols static if they're not exported.
	(x_raise_frame, x_lower_frame, x_wm_set_window_state):
	(x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
	(x_destroy_window, x_delete_display):
	Now static.
	(x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
	(x_mouse_leave): Remove; unused.
	* xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
	(x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
	(x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
	Remove decls.
	(x_mouse_leave): Declare only if WINDOWSNT.
	(x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
	(xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
	USE_X_TOOLKIT.

570 571 572 573 574
	* ftxfont.c: Make symbols static if they're not exported.
	(ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
	HAVE_FREETYPE.
	* font.h (ftxfont_driver): Likewise.

575 576 577 578 579 580 581 582 583 584 585 586 587
	* xfns.c: Make symbols static if they're not exported.
	(x_last_font_name, x_display_info_for_name):
	(x_set_foreground_color, x_set_background_color, x_set_mouse_color):
	(x_set_cursor_color, x_set_border_pixel, x_set_border_color):
	(x_set_cursor_type, x_set_icon_type, x_set_icon_name):
	(x_set_scroll_bar_foreground, x_set_scroll_bar_background):
	(x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
	(last_show_tip_args): Now static.
	(xic_defaut_fontset, xic_create_fontsetname): Define only if
	defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
	(x_screen_planes): Remove; unused.
	* dispextern.h (x_screen_planes): Remove decl.

588 589 590 591 592 593 594 595
	* dispnew.c: Make symbols static if they're not exported.
	* dispextern.h (redraw_garbaged_frames, scrolling):
	(increment_row_positions): Remove.
	* dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
	(delayed_size_change, glyph_matrix_count, glyph_pool_count):
	Now static.
	(redraw_garbaged_frames): Remove; unused.

596 597 598 599 600 601 602 603 604 605
	* xfaces.c: Make symbols static if they're not exported.
	* dispextern.h (ascii_face_of_lisp_face, free_realized_face):
	Remove decls.
	* xterm.h (defined_color): Remove decls.
	(x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
	* xfaces.c (tty_suppress_bold_inverse_default_colors_p):
	(menu_face_changed_default, defined_color, free_realized_face):
	(x_free_dpy_colors): Define only if USE_X_TOOLKIT.
	(ascii_face_of_lisp_face): Remove; unused.

606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623
	* xdisp.c: Make symbols static if they're not exported.
	* dispextern.h (scratch_glyph_row, window_box_edges):
	(glyph_to_pixel_coords, set_cursor_from_row):
	(get_next_display_element, set_iterator_to_next):
	(highlight_trailing_whitespace, frame_to_window_pixel_xy):
	(show_mouse_face): Remove decls
	* frame.h (message_buf_print): Likewise.
	* lisp.h (pop_message, set_message, check_point_in_composition):
	Likewise.
	* xterm.h (set_vertical_scroll_bar): Likewise.
	* xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
	(message_buf_print, scratch_glyph_row, displayed_buffer):
	(set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
	(get_next_display_element, show_mouse_face, window_box_edges):
	(frame_to_window_pixel_xy, check_point_in_composition):
	(set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
	(glyph_to_pixel_coords): Remove; unused.

624 625 626 627
	* dired.c (file_name_completion): Now static.

	* dbusbind.c (xd_in_read_queued_messages): Now static.

628 629 630
	* lisp.h (circular_list_error, FOREACH): Remove; unused.
	* data.c (circular_list_error): Remove.

631 632 633 634
	* commands.h (last_point_position, last_point_position_buffer):
	(last_point_position_window): Remove decls.
	* keyboard.c: Make these variables static.

635 636 637 638 639 640
	* coding.h (coding, code_convert_region, encode_coding_gap): Remove
	decls.
	* coding.c (Vsjis_coding_system, Vbig5_coding_system):
	(iso_code_class, detect_coding, code_convert_region): Now static.
	(encode_coding_gap): Remove; unused.

641 642
	* chartab.c (chartab_chars, chartab_bits): Now static.

643 644 645 646
	* charset.h (charset_iso_8859_1): Remove decl.
	* charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
	Now static.

647 648 649 650
	* ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
	* ccl.c (Vccl_program_table): Now static.
	(check_ccl_update): Remove; unused.

651 652 653 654
	* category.c (SET_CATEGORY_SET, set_category_set): Move here.
	* category.h: ... from here.
	* category.c (check_category_table, set_category_set): Now static.

655 656 657
	* casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
	* lisp.h: Remove these decls.

658 659
	* buffer.c (buffer_count): Remove unused var.

660 661 662 663 664 665
	* bidi.c (bidi_dump_cached_states): Mark as externally visible,
	so that it's not optimized away.
	(bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
	* dispextern.h (bidi_dump_cached_states): Remove, since it's
	exported only to the debugger.

666 667 668
	* atimer.c (alarm_signal_handler, run_all_atimers): Now static.
	* atimer.h (run_all_atimers): Removed; not exported.

669 670 671 672 673 674
	font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
	* font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
	was inaccessible from Lisp.
	(merge_font_spec): Likewise, renaming from Fmerge_font_spec.
	* font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.

675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694
	alloc.c: Import and export fewer symbols, and remove unused items.
	* lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
	is defined.
	(suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
	it's not optimized away by whole-program optimization.
	(message_enable_multibyte, free_misc): Remove.
	(catchlist, handlerlist, mark_backtrace):
	Declare only if BYTE_MARK_STACK.
	(mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
	* alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
	(message_enable_multibyte): Remove decl.
	(free_misc, interval_free_list, float_block, float_block_index):
	(n_float_blocks, float_free_list, cons_block, cons_block_index):
	(cons_free_list, last_marked_index):
	Now static.
	(suppress_checking, die): Define only if ENABLE_CHECKING is defined.
	* eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
	(mark_backtrace): Define only if BYTE_MARK_STACK.
	* xdisp.c (message_enable_multibyte): Now static.

Glenn Morris's avatar
Glenn Morris committed
695
	Declare Lisp_Object Q* variables to be 'static' if not exported.
696 697 698 699 700 701 702 703 704 705 706 707 708 709 710
	This makes it easier for human readers (and static analyzers)
	to see whether these variables are used from other modules.
	* alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
	* ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
	* data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
	* font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
	* lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
	* sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
	* xmenu.c, xselect.c:
	Declare Q* vars static if they are not used in other modules.
	* ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
	* frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
	Remove decls of unexported vars.
	* keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.

711 712
	* lisp.h (DEFINE_FUNC): Make sname 'static'.

713 714 715 716 717
	Make Emacs functions such as Fatom 'static' by default.
	This makes it easier for human readers (and static analyzers)
	to see whether these functions can be called from other modules.
	DEFUN now defines a static function.  To make the function external
	so that it can be used in other C modules, use the new macro DEFUE.
Paul Eggert's avatar
Paul Eggert committed
718 719
	* lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
	(Finit_image_library):
720 721 722 723 724 725
	(Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
	(Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
	(Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
	Remove decls, since these functions are now static.
	(Funintern, Fget_internal_run_time): New decls, since these functions
	were already external.
726

727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
	* alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
	* ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
	* doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
	* fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
	* keyboard.c, keymap.c, lread.c:
	* macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
	* syntax.c, term.c, terminal.c, textprop.c, undo.c:
	* window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
	Mark functions with DEFUE instead of DEFUN,
	if they are used in other modules.
	* buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
	decls for now-static functions.
	* buffer.h (Fdelete_overlay): Remove decl.
	* callproc.c (Fgetenv_internal): Mark as internal.
	* composite.c (Fremove_list_of_text_properties): Remove decl.
	(Fcomposition_get_gstring): New forward static decl.
	* composite.h (Fcomposite_get_gstring): Remove decl.
	* dired.c (Ffile_attributes): New forward static decl.
	* doc.c (Fdocumntation_property): New forward static decl.
	* eval.c (Ffetch_bytecode): New forward static decl.
	(Funintern): Remove extern decl; now in .h file where it belongs.
	* fileio.c (Fmake_symbolic_link): New forward static decl.
	* image.c (Finit_image_library): New forward static decl.
	* insdel.c (Fcombine_after_change_execute): Make forward decl static.
	* intervals.h (Fprevious_property_change):
	(Fremove_list_of_text_properties): Remove decls.
	* keyboard.c (Fthis_command_keys): Remove decl.
	(Fcommand_execute): New forward static decl.
	* keymap.c (Flookup_key): New forward static decl.
	(Fcopy_keymap): Now static.
	* keymap.h (Flookup_key): Remove decl.
	* process.c (Fget_process): New forward static decl.
	(Fprocess_datagram_address): Mark as internal.
	* syntax.c (Fsyntax_table_p): New forward static decl.
	(skip_chars): Remove duplicate decl.
	* textprop.c (Fprevious_property_change): New forward static decl.
	* window.c (Fset_window_fringes, Fset_window_scroll_bars):
	Now internal.
	(Fset_window_margins, Fset_window_vscroll): New forward static decls.
	* window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.

768 769
	* editfns.c (Fformat): Remove unreachable code.

770 771 772 773 774
2011-04-14  Andreas Schwab  <schwab@linux-m68k.org>

	* fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
	change.  (Bug#8496)

775 776 777 778 779
2011-04-13  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
	when at ZV.  (Bug#8487)

780 781
2011-04-12  Andreas Schwab  <schwab@linux-m68k.org>

782 783 784 785 786 787 788 789
	* charset.c (Fclear_charset_maps): Use xfree instead of free.
	(Bug#8437)
	* keyboard.c (parse_tool_bar_item): Likewise.
	* sound.c (sound_cleanup, alsa_close): Likewise.
	* termcap.c (tgetent): Likewise.
	* xfns.c (x_default_font_parameter): Likewise.
	* xsettings.c (read_and_apply_settings): Likewise.

790 791 792
	* alloc.c (overrun_check_malloc, overrun_check_realloc)
	(overrun_check_free): Protoize.

793 794 795 796 797 798 799 800
2011-04-12  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (emacs_read, emacs_write): Check for negative sizes
	since callers should never pass a negative size.
	Change the signature to match that of plain 'read' and 'write'; see
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
	* lisp.h: Update prototypes of emacs_write and emacs_read.

801 802 803 804
2011-04-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't try to determine the character
	position of the scroll margin if the window start point w->startp
805
	is outside the buffer's accessible region.  (Bug#8468)
806

807 808 809 810 811 812 813 814 815 816 817 818 819 820
2011-04-10  Eli Zaretskii  <eliz@gnu.org>

	Fix write-region and its subroutines for buffers > 2GB.
	* fileio.c (a_write, e_write): Modify declaration of arguments and
	local variables to support buffers larger than 2GB.
	(Fcopy_file): Use EMACS_INT for return value of emacs_read.

	* sysdep.c (emacs_write, emacs_read): Use ssize_t for last
	argument, local variables, and return value.

	* lisp.h: Update prototypes of emacs_write and emacs_read.

	* sound.c (vox_write): Use ssize_t for return value of emacs_write.

Paul Eggert's avatar
Paul Eggert committed
821
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>
822

823 824
	* xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.

825 826
	Fix more problems found by GCC 4.6.0's static checks.

827 828
	* xdisp.c (vmessage): Use a better test for character truncation.

829 830
	* charset.c (load_charset_map): <, not <=, for optimization,
	and to avoid potential problems with integer overflow.
831
	* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
832
	* casetab.c (set_identity, shuffle): Likewise.
Paul Eggert's avatar
Paul Eggert committed
833
	* editfns.c (Fformat): Likewise.
834
	* syntax.c (skip_chars): Likewise.
835

836 837 838
	* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
	This also lets GCC 4.6.0 generate slightly better loop code.

839 840 841 842 843
	* callint.c (Fcall_interactively): <, not <=, for optimization.
	(Fcall_interactively): Count the number of arguments produced,
	not the number of arguments given.  This is simpler and lets GCC
	4.6.0 generate slightly better code.

844 845 846 847 848 849 850 851
	* ftfont.c: Distingish more carefully between FcChar8 and char.
	The previous code passed unsigned char * to a functions like
	strlen and xstrcasecmp that expect char *, which does not
	conform to the C standard.
	(get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
	arguments to FcPatternGetString, and explicitly cast FcChar8 * to
	char * when the C standard requires it.

852 853
	* keyboard.c (read_char): Remove unused var.

854 855 856 857 858 859 860 861 862
	* eval.c: Port to Windows vsnprintf (Bug#8435).
	Include <limits.h>.
	(SIZE_MAX): Define if the headers do not.
	(verror): Do not give up if vsnprintf returns a negative count.
	Instead, grow the buffer.  This ports to Windows vsnprintf, which
	does not conform to C99.  Problem reported by Eli Zaretskii.
	Also, simplify the allocation scheme, by avoiding the need for
	calling realloc, and removing the ALLOCATED variable.

863 864
	* eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

865 866 867
	Remove invocations of doprnt, as Emacs now uses vsnprintf.
	But keep the doprint source code for now, as we might revamp it
	and use it again (Bug#8435).
868 869 870 871
	* lisp.h (doprnt): Remove.
	* Makefile.in (base_obj): Remove doprnt.o.
	* deps.mk (doprnt.o): Remove.

872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893
	error: Print 32- and 64-bit integers portably (Bug#8435).
	Without this change, on typical 64-bit hosts error ("...%d...", N)
	was used to print both 32- and 64-bit integers N, which relied on
	undefined behavior.
	* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
	New macro.
	* lisp.h (error, verror): Mark as printf-like functions.
	* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
	Report overflow in size calculations when allocating printf buffer.
	Do not truncate output string at its first null byte.
	* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
	Truncate the output at a character boundary, since vsnprintf does not
	do that.
	* charset.c (check_iso_charset_parameter): Convert internal
	character to string before calling 'error', since %c now has the
	printf meaning.
	* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
	overflow when computing char to be passed to 'error'.  Do not
	pass Lisp_Object to 'error'; pass the integer instead.
	* nsfns.m (Fns_do_applescript): Use int, not long, since it's
	formatted with plain %d.

894 895
	* eval.c (internal_lisp_condition_case): Don't pass spurious arg.

896 897
	* keyboard.c (access_keymap_keyremap): Print func name, not garbage.

898 899
	* coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

900 901
	* xterm.c (x_catch_errors): Remove duplicate declaration.

902 903
	* term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

904 905
	* xdisp.c, lisp.h (message_nolog): Remove; unused.

906 907 908 909 910 911 912 913 914 915
2011-04-10  Jim Meyering  <meyering@redhat.com>

	use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
	* gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
	return ssize_t not "int", and use size_t as the buffer length.
	(emacs_gnutls_write): Likewise, and make the buffer pointer "const".
	* gnutls.h: Update declarations.
	* process.c (read_process_output): Use ssize_t, to match.
	(send_process): Likewise.

916 917 918 919
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

	* image.c (Fimagemagick_types): Doc fix, and comment cleanup.

920
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>
921

922 923
	* ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
	unsigned char, to match FcChar8 type definition.
924

925 926 927 928
	* xterm.c (handle_one_xevent):
	* xmenu.c (create_and_show_popup_menu):
	* xselect.c (x_decline_selection_request)
	(x_reply_selection_request): Avoid type-punned deref of X events.
929

930
2011-04-09  Eli Zaretskii  <eliz@gnu.org>
931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970

	Fix some uses of `int' instead of EMACS_INT.
	* search.c (string_match_1, fast_string_match)
	(fast_c_string_match_ignore_case, fast_string_match_ignore_case)
	(scan_buffer, find_next_newline_no_quit)
	(find_before_next_newline, search_command, Freplace_match)
	(Fmatch_data): Make some `int' variables be EMACS_INT.

	* xdisp.c (display_count_lines): 3rd argument and return value now
	EMACS_INT.  All callers changed.
	(pint2hrstr): Last argument is now EMACS_INT.

	* coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
	(detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
	(decode_coding_utf_16, decode_coding_emacs_mule)
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
	(decode_coding_ccl, decode_coding_charset)
	<consumed_chars, consumed_chars_base>: Declare EMACS_INT.
	(decode_coding_iso_2022, decode_coding_emacs_mule)
	(decode_coding_sjis, decode_coding_big5, decode_coding_charset)
	<char_offset, last_offset>: Declare EMACS_INT.
	(encode_coding_utf_8, encode_coding_utf_16)
	(encode_coding_emacs_mule, encode_invocation_designation)
	(encode_designation_at_bol, encode_coding_iso_2022)
	(encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
	(encode_coding_raw_text, encode_coding_charset) <produced_chars>:
	Declare EMACS_INT.
	(ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
	(encode_invocation_designation): Last argument P_NCHARS is now
	EMACS_INT.
	(decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
	(produce_chars): from_nchars and to_nchars are now EMACS_INT.

	* coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
	All users changed.

	* ccl.c (Fccl_execute_on_string): Declare some variables
	EMACS_INT.

971
2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)
972 973 974

	* term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

975 976 977 978
2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

	* process.c (Fformat_network_address): Doc fix.

979 980 981 982
2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

	* xml.c (parse_region): Avoid creating spurious whiespace nodes.

983 984 985 986 987
2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (read_char): Call Lisp function help-form-show,
	instead of using internal_with_output_to_temp_buffer.
	(Qhelp_form_show): New var.
988
	(syms_of_keyboard): Use DEFSYM macro.
989 990 991 992 993

	* print.c (internal_with_output_to_temp_buffer): Function deleted.

	* lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

994 995 996 997 998
2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (Flist_processes): Removed to Lisp.
	(list_processes_1): Deleted.

999 1000
2011-04-06  Eli Zaretskii  <eliz@gnu.org>

1001 1002
	* msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

1003 1004
	* w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

1005
2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
1006

Paul Eggert's avatar
Paul Eggert committed
1007 1008
	Fix more problems found by GCC 4.6.0's static checks.

1009 1010
	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

1011 1012
	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

1013
	* lisp.h (message, message_nolog, fatal): Mark as printf-like.
1014

1015 1016
	* xdisp.c (vmessage): Mark as a printf-like function.

1017 1018
	* term.c (vfatal, maybe_fatal): Mark as printf-like functions.

1019 1020
	* sound.c (sound_warning): Don't crash if arg contains a printf format.

1021 1022 1023 1024 1025
	* image.c (tiff_error_handler, tiff_warning_handler): Mark as
	printf-like functions.
	(tiff_load): Add casts to remove these marks before passing them
	to system-supplied API.

1026 1027
	* eval.c (Fsignal): Remove excess argument to 'fatal'.

1028 1029
	* coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
	This avoids several warnings with gcc -Wstrict-overflow.
1030 1031 1032 1033 1034 1035
	(DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
	directly, rather than having caller test rule sign.  This avoids
	some unnecessary tests.
	* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
	(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
	affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1036

1037
	* xfont.c (xfont_text_extents): Remove var that was set but not used.
1038
	(xfont_open): Avoid unnecessary tests.
1039

1040 1041
	* composite.c (composition_gstring_put_cache): Use unsigned integer.

1042 1043 1044
	* composite.h, composite.c (composition_gstring_put_cache):
	Use EMACS_INT, not int, for length.

1045 1046 1047 1048 1049 1050
	* composite.h (COMPOSITION_DECODE_REFS): New macro,
	breaking out part of COMPOSITION_DECODE_RULE.
	(COMPOSITION_DECODE_RULE): Use it.
	* composite.c (get_composition_id): Remove unused local vars,
	by using the new macro.

1051 1052 1053
	* textprop.c (set_text_properties_1): Change while to do-while,
	since the condition is always true at first.

1054
	* intervals.c (graft_intervals_into_buffer): Mark var as used.
1055 1056
	(interval_deletion_adjustment): Return unsigned value.
	All uses changed.
1057

1058 1059
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
1060
	(create_pty): Remove unnecessary "volatile"s.
1061
	(Fnetwork_interface_info): Avoid possibility of int overflow.
1062
	(read_process_output): Do adaptive read buffering even if carryover.
1063
	(read_process_output): Simplify nbytes computation if buffered.
1064

1065 1066
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

1067
	* syntax.c (scan_words): Remove var that was set but not used.
1068
	(update_syntax_table): Use unsigned instead of int.
1069

1070
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1071
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1072
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1073

1074 1075
	* print.c (print_error_message): Avoid int overflow.

1076 1077 1078
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

1079
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1080
	(font_score): Avoid potential overflow in diff calculation.
1081

1082
	* fns.c (substring_both): Remove var that is set but not used.
1083
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
1084

1085 1086
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

1087 1088 1089 1090
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

1091
	* search.c (boyer_moore, wordify): Remove vars set but not used.
1092
	(wordify): Omit three unnecessary tests.
1093

1094 1095 1096
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

1097 1098
	* casefiddle.c (casify_region): Remove var that is set but not used.

1099 1100
	* dired.c (file_name_completion): Remove var that is set but not used.

1101 1102
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

1103
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1104
	(Finsert_file_contents): Remove unnecessary code checking fd.
1105

1106 1107 1108
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

1109 1110 1111
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

1112 1113
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
1114
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1115
	(timer_check_2): Mark vars as initialized.
1116

1117 1118
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

1119
	* image.c (lookup_image): Remove var that is set but not used.
1120
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1121

1122 1123 1124
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

1125
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
1126
	if XCreateBitmapFromData fails (Bug#8410).
1127

1128 1129 1130
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

1131
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
1132
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
1133

1134 1135
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
1136 1137 1138
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
1139

1140 1141 1142
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

1143 1144
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

1145 1146 1147 1148 1149 1150 1151
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

1152 1153 1154
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

1155 1156
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
1157
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1158 1159 1160 1161 1162 1163 1164 1165
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
1166 1167
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
1168

1169 1170 1171 1172 1173
2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
	first non-nil return value).

1174 1175 1176 1177 1178
2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
	if not defined (Bug#8403).

1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (display_count_lines): Remove parameter `start',
	unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(get_char_face_and_encoding): Remove parameter `multibyte_p',
	unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
	(fill_stretch_glyph_string): Remove parameters `row' and `area',
	unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
	and thereabouts.  All callers changed.
	(get_per_char_metric): Remove parameter `f', unused since
	2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

1191 1192 1193 1194 1195 1196
2011-04-02  Jim Meyering  <meyering@redhat.com>

	do not dereference NULL upon failed strdup
	* nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
	(ns_get_family): Likewise.

1197 1198 1199 1200
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

1201 1202 1203 1204 1205
2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
	later (Bug#8403).

1206 1207
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

1208
	Add lexical binding.
1209

1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
1227 1228 1229

	* image.c (parse_image_spec): Use Ffunctionp.

1230 1231 1232 1233 1234 1235 1236 1237