ChangeLog 908 KB
Newer Older
1 2 3 4
2013-03-24  Ken Brown  <kbrown@cornell.edu>

	* w32term.c (w32_initialize): Silence compiler warning.

5 6
2013-03-23  Eli Zaretskii  <eliz@gnu.org>

7 8 9 10 11 12 13 14 15 16 17 18 19 20
	* w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
	FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
	variables, to save and restore frame dimensions.  Use
	FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
	after returning from a 'fullscreen' configuration.  use
	SendMessage instead of PostMessage to send the SC_RESTORE message,
	to avoid races between the main thread and the input thread.

	* w32term.h (struct w32_output): New members normal_width,
	normal_height, normal_top, normal_left, and prev_fsmode.
	(FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
	(FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
	members of a frame.

21 22 23 24 25 26 27 28 29 30 31 32 33 34
	* w32term.c (w32fullscreen_hook): Record last value of the frame's
	'fullscreen' parameter.  Always record previous width and height
	of the frame, except when switching out of maximized modes, so
	that they could be restored correctly, instead of resetting to the
	default frame dimensions.  Send SC_RESTORE command to the frame,
	unless we are going to send SC_MAXIMIZE, to restore the frame
	resize hints in the mouse pointer shown by the window manager.
	(Bug#14032)

	* frame.c (get_frame_param): Now extern for WINDOWSNT as well.

	* lisp.h (get_frame_param): Adjust conditions for prototype
	declaration.

35 36 37 38 39 40 41 42
2013-03-22  Ken Brown  <kbrown@cornell.edu>

	* unexcw.c: Drop unneeded inclusion of w32common.h.
	(report_sheap_usage): Declare.
	(read_exe_header): Add magic numbers for x86_64.
	(fixup_executable): Fix printf format specifier for unsigned long
	argument.

43 44 45 46 47 48 49 50 51 52 53 54
2013-03-22  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (struct frame): Put menu_bar_window under #ifdef
	because this member is not needed when X toolkit is in use.
	(fset_menu_bar_window):
	* dispnew.c (clear_current_matrices, clear_desired_matrices)
	(free_glyphs, update_frame):
	* xdisp.c (expose_frame): Likewise.
	(display_menu_bar): Likewise.  Remove redundant eassert.
	* window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
	toolkit is in use.

55 56
2013-03-21  Paul Eggert  <eggert@cs.ucla.edu>

57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
	Use functions and constants to manipulate Lisp_Save_Value objects.
	This replaces code that used macros and strings and token-pasting.
	The change makes the C source a bit easier to follow,
	and shrinks the Emacs executable a bit.
	* alloc.c: Verify some properties of Lisp_Save_Value's representation.
	(make_save_value): Change 1st arg from string to enum.  All callers
	changed.
	(INTX): Remove.
	(mark_object): Use if, not #if, for GC_MARK_STACK.
	* lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
	(XSAVE_OBJECT): Now functions, not macros.
	(STRING_BYTES_BOUND): Now just a macro, not a constant too;
	the constant was never used.
	(SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
	(SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
	(SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
	(SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
	New constants.
	(struct Lisp_Save_Value): Replace members area, type0, type1, type2,
	type3 with a single member save_type.  All uses changed.
	(save_type, set_save_pointer, set_save_integer): New functions.
	* print.c (PRINTX): Remove.

80 81
	* alloc.c: Remove redundant static declarations.

82 83 84 85 86 87 88 89 90 91 92
2013-03-20  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_col, top_line, total_lines
	and total_cols from Lisp_Objects to integers.  Adjust comments.
	(wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
	Remove.
	(WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
	(WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
	* dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
	Adjust users where appropriate.

93 94 95 96
2013-03-20  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (struct frame): Drop resx and resy because the same data is
	available from window system-specific output context.  Adjust users.
Dmitry Antipov's avatar
Dmitry Antipov committed
97
	(default_pixels_per_inch_x, default_pixels_per_inch_y): New
98 99 100 101 102 103 104 105 106 107 108
	functions to provide defaults when no window system available.
	(FRAME_RES_X, FRAME_RES_Y): New macros.
	(NUMVAL): Moved from xdisp.c.
	* font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
	(Ffont_face_attributes, Fopen_font):
	* image.c (gs_load):
	* w32font.c (fill_in_logfont):
	* xdisp.c (calc_pixel_width_or_height):
	* xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
	* xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.

109 110 111 112 113 114
2013-03-20  Kenichi Handa  <handa@gnu.org>

	* coding.c (syms_of_coding): Initialize disable_ascii_optimization
	to 1 (temporary workaround until a bug related to ASCII
	optimization is fixed).

115 116 117 118 119 120
2013-03-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fwindow_combination_limit, Fset_window_combination_limit):
	Signal error if window is not internal.  Adjust docstring.
	(delete_all_child_windows): Use combination_limit to save the buffer.
	(Fset_window_configuration): Adjust accordingly.
121 122 123 124
	* print.c (syms_of_print): Initialize debugging output not here...
	(init_print_once): ...but in a new function here.
	* lisp.h (init_print_once): Add prototype.
	* emacs.c (main): Add call to init_print_once.  Adjust comments.
125

126 127 128 129 130 131 132 133 134 135
2013-03-18  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (window_resize_check, window_resize_apply)
	(window_from_coordinates, recombine_windows, set_window_buffer)
	(make_parent_window, Fwindow_resize_apply, resize_frame_windows)
	(Fsplit_window_internal, Fdelete_window_internal)
	(freeze_window_starts): Use bool for booleans.
	* window.h (window_frame_coordinates, resize_frame_windows)
	(freeze_window_starts, set_window_buffer): Adjust prototypes.

136 137 138 139
2013-03-17  Stefan Monnier  <monnier@iro.umontreal.ca>

	* dispnew.c (bitch_at_user): Use `user-error'.

140 141 142 143 144 145
2013-03-17  Ken Brown  <kbrown@cornell.edu>

	* dispextern.h (RGB_PIXEL_COLOR): Move here from image.c.  Use it
	as return type of image_background.  (Bug#13981)
	* image.c (RGB_PIXEL_COLOR): Move to dispextern.h.

146 147
2013-03-16  Jan Djärv  <jan.h.d@swipnet.se>

148
	* nsterm.m (updateFrameSize:): Change resize increments if needed.
149
	(ns_select): Don't return with result uninitialized.
150

151 152 153
	* nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
	and getDirectory.

154 155
	* nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
	New functions.
156 157 158 159 160 161 162
	(Fns_read_file_name): ret is BOOL.  If ! dir_only_p, don't choose
	directories.  If filename is nil, get directory name (Bug#13932).
	Use getFilename and getDirectory.
	(getFilename, getDirectory): New methods for EmacsSavePanel and
	EmacsOpenPanel.
	(ok:): In EmacsOpenPanel, if we can't choose directories, just return.

163 164 165 166
2013-03-15  Paul Eggert  <eggert@cs.ucla.edu>

	* coding.c (decode_coding_gap): Fix typo caught by static checking.

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190
2013-03-15  handa  <handa@gnu.org>

	* insdel.c (insert_from_gap): New arg text_at_gap_tail.
	(adjust_after_replace): Make it back to static.  Delete the third
	arg text_at_gap_tail.  Cancel the code for handling it.

	* coding.h (struct coding_system): New member eol_seen.

	* coding.c (detect_ascii): New function.
	(detect_coding): Set coding->head_ascii and coding->eol_seen only
	when the source bytes are actually scanned.  On detecting for
	coding_category_utf_8_auto, call detect_ascii instead of scanning
	source bytes directly.
	(produce_chars): Call insert_from_gap with the new arg 0.
	(encode_coding): Likewise.
	(decode_coding_gap): Control ASCII optimization by the variable
	disable_ascii_optimization instead of #ifndef .. #endif.
	Deccode EOL format according to coding->eol_seen.
	(syms_of_coding): Declare disable-ascii-optimization as a Lisp
	variable.

	* lisp.h (adjust_after_replace): Cancel externing it.
	(insert_from_gap): Adjust prototype.

191 192 193 194 195
2013-03-15  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
	FULLSCREEN_MAXIMIZED.  (Bug#13935)

196 197 198 199 200 201 202
2013-03-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* region-cache.c (find_cache_boundary, move_cache_gap)
	(insert_cache_boundary, delete_cache_boundaries, set_cache_region):
	Simplify debugging check and convert to eassert.  Adjust comment.
	(pp_cache): Put under ENABLE_CHECKING.

203 204 205 206 207 208 209 210 211 212
2013-03-14  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
	and incorrect code.  Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
	and WM_ACTIVATEAPP.
	(w32fullscreen_hook): If the frame is visible, reset
	f->want_fullscreen flag after changing the frame size.  If the
	frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
	(Bug#13953)

213 214 215 216 217 218 219
2013-03-13  Daniel Colascione  <dancol@dancol.org>

	* emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
	too so that these builds can use Cygwin's file conversion
	functions.  (We've been building and linking cygw32.o all along
	and just not using it.)

Paul Eggert's avatar
Paul Eggert committed
220 221 222 223 224 225 226 227 228 229 230
2013-03-13  Paul Eggert  <eggert@cs.ucla.edu>

	File synchronization fixes (Bug#13944).
	* Makefile.in (LIB_FDATASYNC): New macro.
	(LIBES): Use it.
	* conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
	* fileio.c (Fwrite_region, write_region_inhibit_fsync):
	Don't worry about HAVE_FSYNC, since a substitute fsync is
	available if the system lacks one.
	(Fwrite_regin): Retry fsync if interrupted.

231 232
2013-03-13  Eli Zaretskii  <eliz@gnu.org>

233
	* w32term.c (w32_read_socket): If the Emacs frame is being
234 235 236
	activated, call w32fullscreen_hook, to make sure the new frame
	dimensions are in effect.  (Bug#13937)

237 238 239 240
2013-03-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (init_iterator): Simplify because both character and byte
	positions are either specified or -1.  Add eassert.  Adjust comment.
241 242
	* window.c (Fscroll_other_window): Use SET_PT_BOTH because both
	character and byte positions can be obtained from marker.
243

244 245
2013-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
246 247 248 249 250 251 252 253 254 255 256 257 258 259 260
	Static checking by Sun C 5.12.
	* alloc.c (buffer_memory_full) [REL_ALLOC]:
	* bytecode.c (exec_byte_code):
	* dispnew.c (init_display):
	* eval.c (error):
	* fileio.c (Fsubstitute_in_file_name):
	* keyboard.c (Fevent_convert_list):
	* keymap.c (Fsingle_key_description):
	* term.c (maybe_fatal, fatal):
	* xfns.c (Fx_display_backing_store, Fx_display_visual_class):
	* xsmfns.c (Fhandle_save_session):
	Omit unreachable code.
	* keymap.c (map_keymap_char_table_item): Cast void * to
	a function pointer type; the C Standard requires this.

261 262 263 264 265 266
	* sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
	Include <sys/param.h> unconditionally, as that works elsewhere and
	is simpler here.  Include <sys/sysctl.h> if DARWIN_OS ||
	__FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
	and FreeBSD now.

267 268 269 270
2013-03-11  Paul Eggert  <eggert@cs.ucla.edu>

	* insdel.c (adjust_after_replace): Use bool for boolean.

271 272 273 274 275 276 277 278
2013-03-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c: Move keyboard decoding to read_key_sequence.
	(decode_keyboard_code): Remove.
	(tty_read_avail_input): Don't try to decode input.
	(read_decoded_char): New function.
	(read_key_sequence): Use it.

279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303
2013-03-10  Daniel Colascione  <dancol@dancol.org>

	* w32term.h (GUISTR, GUI_ENCODE_FILE, GUI_ENCODE_SYSTEM, GUI_FN)
	(GUI_SDATA, guichar_t): Macros to abstract out differences between
	NTGUI_UNICODE and !NTGUI_UNICODE builds, some moved out of
	w32fns.c.

	* w32term.c (construct_drag_n_drop): Use the above macros to make
	drag-and-drop work for non-ASCII filenames in cygw32 builds.

	* w32fns.c (x_set_name, x_set_title): Use the above macros to
	properly display non-ASCII frame titles in cygw32 builds.

	* w32fns.c (Fw32_shell_execute): Use the above macros to properly
	call ShellExecute in cygw32 builds.

	* w32fn.c (Fx_file_dialog): Use the above macros to simplify the
	common file dialog code.

	* w32fns.c (Ffile_system_info): Remove from cygw32 builds, which
	can just use du like other systems.

	* coding.c (from_unicode_buffer): Declare.
	* coding.c (from_unicode_buffer): Implement.

304 305
2013-03-10  Stefan Monnier  <monnier@iro.umontreal.ca>

Stefan Monnier's avatar
Stefan Monnier committed
306 307 308 309 310
	* lread.c: Minor cleanup.
	(FROM_FILE_P): New macro.
	(skip_dyn_bytes, unreadchar, read1): Use it.
	(read_list): Consolidate duplicated code.

311 312
	* bytecode.c (struct byte_stack): Remove `constants' when unused.

313 314 315 316 317 318
2013-03-10  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (display_tool_bar_line, redisplay_tool_bar)
	(redisplay_internal, set_cursor_from_row, try_window)
	(try_window_id, dump_glyph_row, extend_face_to_end_of_line)
	(display_line, notice_overwritten_cursor)
319 320
	(mouse_face_from_buffer_pos, note_mouse_highlight):
	Use MATRIX_ROW_DISPLAYS_TEXT_P.
321
	(note_mouse_highlight): Use MATRIX_ROW_GLYPH_START.
322 323
	(mouse_face_from_string_pos, fast_find_string_pos):
	Use MATRIX_ROW_VPOS.
324 325 326 327 328 329 330 331 332 333

	* xfns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.

	* w32fns.c (Fx_show_tip): Use MATRIX_ROW_DISPLAYS_TEXT_P.

	* xdisp.c (try_cursor_movement): Use MATRIX_ROW and
	MATRIX_MODE_LINE_ROW.

	* dispnew.c (update_window): Use MATRIX_ROW and MATRIX_MODE_LINE_ROW.

334 335 336 337 338 339
2013-03-10  handa  <handa@gnu.org>

	* lisp.h (adjust_after_replace): Extern it.

	* coding.c (detect_coding): Cound the heading ASCII bytes in the
	case of detection for coding_category_utf_8_auto.
340 341
	(decode_coding_gap) [not CODING_DISABLE_ASCII_OPTIMIZATION]:
	Skip decoding if all bytes are ASCII.
342 343 344 345 346 347

	* insdel.c (adjust_after_replace): Make it public.  New arg
	text_at_gap_tail.
	(adjust_after_insert): Call adjust_after_replace with the new arg
	value 0.

348 349 350 351 352 353 354 355 356
2013-03-09  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN)
	(POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come
	from Elisp via unread-command-events.

	* keyboard.c (access_keymap_keyremap): Accept nil return value from
	functions to mean "no change".

357 358 359 360 361 362 363 364 365 366 367 368 369
2013-03-08  Paul Eggert  <eggert@cs.ucla.edu>

	region-cache.c, scroll.c, search.c: Use bool for booleans.
	* lisp.h (compile_pattern):
	* scroll.c (do_scrolling, do_direct_scrolling):
	* search.c (struct regexp_cache, compile_pattern_1)
	(compile_pattern, string_match_1, search_command)
	(trivial_regexp_p, search_buffer, Freplace_match, match_limit)
	(search_regs_saved, Fregexp_quote):
	Use bool for boolean.
	* region-cache.c (region_cache_forward, region_cache_backward):
	Fix comments to match code: these functions return int, not boolean.

370 371 372 373 374 375 376 377
2013-03-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* search.c (find_newline): Accept start and end byte positions
	as arguments and allow -1 if not known.
	(find_newline_no_quit): Likewise for start position.
	* lisp.h (find_newline, find_newline_no_quit): Adjust prototype.
	* bidi.c (bidi_find_paragraph_start): Pass byte position to
	find_newline_no_quit, thus eliminating CHAR_TO_BYTE.
378 379
	* editfns.c (Fconstrain_to_field): Break long line.
	Adjust call to find_newline.
380 381 382 383 384 385 386
	* indent.c (vmotion): Adjust calls to find_newline_no_quit.
	Use DEC_BOTH to start next search from the previous buffer
	position, where appropriate.
	* xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
	(get_visually_first_element, move_it_vertically_backward): Likewise.
	Obtain byte position from the display iterator, where appropriate.

387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
2013-03-08  Paul Eggert  <eggert@cs.ucla.edu>

	print.c, process.c: Use bool for booleans.
	* lisp.h (wait_reading_process_output):
	* print.c (print_output_debug_flag, PRINTDECLARE, printchar)
	(strout, debug_output_compilation_hack, float_to_string, print)
	(print_object):
	* process.c (kbd_is_on_hold, inhibit_sentinels, process_output_skip)
	(decode_status, status_message, create_process, create_pty)
	(Fmake_network_process, Fnetwork_interface_info)
	(wait_reading_process_output, read_process_output)
	(write_queue_push, write_queue_pop, process_send_signal)
	(handle_child_signal, keyboard_bit_set, kbd_on_hold_p):
	* process.h (struct Lisp_Process, inhibit_sentinels, kbd_on_hold_p):
	Use bool for booleans.
	* process.c (Fnetwork_interface_list): Remove unused local.
	(connect_counter): Now EMACS_INT, not int.

405 406 407 408 409 410 411 412 413 414
2013-03-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* bidi.c (bidi_fetch_char): Swap first and second arguments
	to match other functions accepting character and byte positions.
	Adjust comment.
	(bidi_resolve_explicit_1, bidi_level_of_next_char): Adjust users.
	(bidi_paragraph_init): Likewise.  Use DEC_BOTH which is faster
	when you need just to move to the previous buffer position.
	* xdisp.c (Fcurrent_bidi_paragraph_direction): Use DEC_BOTH.

415 416 417 418
2013-03-07  Eli Zaretskii  <eliz@gnu.org>

	* .gdbinit (prowlims): Display the enabled_p flag of the row.

419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435
2013-03-07  Dmitry Antipov  <dmantipov@yandex.ru>

	Avoid character to byte conversions in motion subroutines.
	* indent.h (compute_motion, vmotion): Add byte position argument.
	* indent.c (compute_motion): Use it and avoid CHAR_TO_BYTE.
	Add eassert.
	(Fcompute_motion): Break long line.  Adjust call to compute_motion.
	Use list5 for return value.
	(vmotion): Use byte position argument and avoid call to CHAR_TO_BYTE.
	Adjust comments, style and calls to compute_motion.
	(Fvertical_motion): Adjust call to vmotion.
	* window.c (Fdelete_other_windows_internal): Record window start
	byte position and adjust call to vmotion.
	(window_scroll_line_based): Likewise with call to compute_motion.
	Use SET_PT_BOTH.
	(Frecenter): Adjust calls to vmotion.

436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
2013-03-07  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (list2i, list3i): New functions.
	(list4i): Move from window.c and make LISP_INLINE.
	* editfns.c (make_lisp_time):
	* fns.c (Flocale_info):
	* keyboard.c (parse_modifiers):
	* xterm.c (x_ewmh_activate_frame): Use list2i.
	* instel.c (signal_after_change):
	* nsfns.m (Fx_server_version, Fxw_color_values):
	* w32fns.c (Fxw_color_values, Fx_server_version):
	* xfns.c (Fxw_color_values, Fx_server_version): Use list3i.
	* fileio.c (Fvisited_file_modtime):
	* nsfns.m (Fns_display_usable_bounds):
	* w32.c (ltime): Use list4i.

452 453
2013-03-06  Eli Zaretskii  <eliz@gnu.org>

454 455 456 457 458 459 460 461 462 463 464 465
	* search.c (find_newline_no_quit): Rename from find_next_newline.
	Add commentary.

	* lisp.h (find_newline_no_quit): Rename prototype.

	* xdisp.c (back_to_previous_line_start)
	(forward_to_next_line_start, get_visually_first_element)
	(move_it_vertically_backward): Callers of find_newline_no_quit changed.
	* indent.c (vmotion): Callers of find_newline_no_quit changed.
	* bidi.c (bidi_find_paragraph_start): Callers of
	find_newline_no_quit changed.

466 467 468
	* msdos.c: Change encoding to cp850.  (Bug#13879)
	(fr_keyboard, it_keyboard, dk_keyboard): Update keyboard layouts.

469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487
2013-03-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Coding system support cleanup and minor refactoring.
	* coding.h (enum coding_result_code): Remove
	CODING_RESULT_INCONSISTENT_EOL and CODING_RESULT_INSUFFICIENT_MEM.
	(toplevel): Remove unused CODING_MODE_INHIBIT_INCONSISTENT_EOL.
	(CODING_MODE_LAST_BLOCK, CODING_MODE_SELECTIVE_DISPLAY)
	(CODING_MODE_DIRECTION, CODING_MODE_FIXED_DESTINATION)
	(CODING_MODE_SAFE_ENCODING): Rearrange bit values.
	(decode_coding_region, encode_coding_region, decode_coding_string):
	Remove unused compatibility macros.
	* coding.c (Qinconsistent_eol, Qinsufficient_memory): Remove.
	(record_conversion_result): Adjust user.
	(syms_of_coding): Likewise.
	(ALLOC_CONVERSION_WORK_AREA): Use SAFE_ALLOCA.
	(decode_coding, encode_coding): Add USE_SAFE_ALLOCA and SAFE_FREE.
	(decode_coding_object): Simplify since xrealloc never returns NULL.
	Add eassert.

488
2013-03-06  Paul Eggert  <eggert@cs.ucla.edu>
489

490
	Fix a build failure on OpenBSD 4.x and MirBSD (Bug#13881).
491 492
	* sysdep.c (list_system_processes)
	[BSD_SYSTEM && !DARWIN_OS && !__FreeBSD__]:
493
	Make it a stub in this case; otherwise the build might fail,
494
	and this code hasn't been tested on such hosts anyway.
495
	Problem reported by Nelson H. F. Beebe in
496 497 498
	<http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00021.html>
	and analyzed by Jérémie Courrèges-Anglas in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00062.html>.
499

500 501 502 503 504 505 506 507
2013-03-06  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (find_next_newline_no_quit): Rename to find_next_newline.
	* xdisp.c (back_to_previous_line_start, forward_to_next_line_start)
	(get_visually_first_element, move_it_vertically_backward): Ajust users.
	* bidi.c (bidi_find_paragraph_start): Likewise.
	* indent.c (vmotion): Likewise.

508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559
2013-03-05  Paul Eggert  <eggert@cs.ucla.edu>

	FILE's lock is now always .#FILE and may be a regular file (Bug#13807).
	* filelock.c: Include <c-ctype.h>.
	(MAX_LFINFO): New top-level constant.
	(lock_info_type): Remove members pid, boot_time.  Add members at,
	dot, colon.  Change user member to be the entire buffer, not a
	pointer.  This allows us to handle the case where a foreign
	pid or boot time exceeds the local range.  All uses changed.
	(LINKS_MIGHT_NOT_WORK): New constant.
	(FREE_LOCK_INFO): Remove, as the pieces no longer need freeing.
	(defined_WINDOWSNT): Remove.
	(MAKE_LOCK_NAME, file_in_lock_file_name):
	Always use .#FILE (not .#-FILE) for the file lock,
	even if it is a regular file.
	(rename_lock_file): New function.
	(create_lock_file): Use it.
	(create_lock_file, read_lock_data):
	Prefer a symbolic link for the lock file, falling back on a
	regular file if symlinks don't work.  Do not try to create
	symlinks on MS-Windows, due to security hassles.  Stick with
	POSIXish functions (open, read, write, close, fchmod, readlink, symlink,
	link, rename, unlink, mkstemp) when creating locks, as a GNUish
	host may be using a Windowsish file system, and cannot use
	MS-Windows-only system calls.  Fall back on mktemp if mkstemp
	doesn't work.  Don't fail merely because of a symlink-contents
	length limit in the current file system; fall back on regular
	files.  Increase the symlink contents length limit to 8 KiB, this
	should be big enough for any real use and doesn't crunch the
	stack.
	(create_lock_file, lock_file_1, read_lock_data):
	Simplify allocation of lock file buffers now that they fit in 8 KiB.
	(lock_file_1): Return error number, not bool.  All callers changed.
	(ELOOP): New macro, if not already defined.
	(read_lock_data): Return size of lock file contents, not Lisp object.
	All callers changed.  Handle a race condition if some other process
	replaces a regular-file lock with a symlink lock or vice versa,
	while we're trying to read the lock.
	(current_lock_owner): Parse contents more carefully, to help avoid
	confusing a regular-file lock with some other application's use
	of the file.  Check for lock file contents being too long, or
	not parsing correctly.
	(current_lock_owner, lock_file):
	Allow foreign pid and boot times that exceed the local range.
	(current_lock_owner, lock_if_free, lock_file):
	Simplify allocation of lock file contents.
	* w32.c (sys_rename_replace): New function, containing most of
	the contents of the old sys_rename.
	(sys_rename): Use it.
	(fchmod): New dummy function.
	* w32.h (sys_rename_replace, fchmod): New decls.

560 561 562 563 564 565 566
2013-03-05  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_resolve_explicit_1): Don't call CHAR_TO_BYTE or
	bidi_count_bytes, as the callers now arrange for bidi_it->charpos
	to be in sync with bidi_it->bytepos.  Suggested by Dmitry Antipov
	<dmantipov@yandex.ru>.

567 568 569 570 571 572 573
2013-03-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* composite.c (get_composition_id, fill_gstring_header):
	Use make_uninit_vector where appropriate.
	* font.c (Ffont_get_glyphs, build_style_table): Likewise.
	* xselect.c (clean_local_selection_data): Likewise.

574 575 576 577 578 579
2013-03-04  Paul Eggert  <eggert@cs.ucla.edu>

	Fix misuse of ImageMagick that caused core dump (Bug#13846).
	* image.c (imagemagick_load_image): Calculate height and width
	after flattening the image, not before.

580 581 582 583 584 585
2013-03-04  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (Ffont_get_glyphs): Use convenient LGLYPH_NEW.
	* ftfont.c (ftfont_shape_by_flt): Likewise.
	* w32uniscribe.c (uniscribe_shape): Likewise.

586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614
2013-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	The lock for FILE is now .#FILE or .#-FILE (Bug#13807).
	The old approach, which fell back on DIR/.#FILE.0 through
	DIR/.#FILE.9, had race conditions that could not be easily fixed.
	If DIR/.#FILE is a non-symlink file, Emacs now does not create a
	lock file for DIR/FILE; that is, DIR/FILE is no longer partly
	protected by a lock if DIR/.#FILE is a non-symlink file ("partly"
	because the locking mechanism was never reliable in that case).
	This patch fixes this and other bugs discovered by a code
	inspection that was prompted by
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00531.html>.
	Also, this patch switches to .#-FILE (not .#FILE) on MS-Windows,
	to avoid interoperability problems between the MS-Windows and
	non-MS-Windows implementations.  MS-Windows and non-MS-Windows
	instances of Emacs now ignore each others' locks.
	* filelock.c (defined_WINDOWSNT): New constant.
	(MAKE_LOCK_NAME, fill_in_lock_file_name):
	Don't create DIR/.#FILE.0 through DIR/.#FILE.9.  Instead, create
	DIR/.#FILE symlinks on non-MS-Windows hosts, and DIR/.#-FILE
	regular files on MS-Windows hosts.
	(MAKE_LOCK_NAME, unlock_file, Ffile_locked_p):
	Use SAFE_ALLOCA to avoid problems with long file names.
	(MAX_LFINFO): Now a local constant, not a global macro.
	(IS_LOCK_FILE): Remove.
	(lock_file_1): Don't inspect errno if symlink call succeeds;
	that's not portable.
	(lock_file): Document that this function can return if lock
	creation fails.
615
	(lock_file): Don't access freed storage.
616

Andreas Schwab's avatar
Andreas Schwab committed
617 618 619 620
2013-03-02  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.h (XPNTR) [!USE_LSB_TAG]: Remove extra paren.  (Bug#13734)

621 622 623 624 625 626
2013-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	* textprop.c: Use bool for booleans.
	(validate_interval_range, Fadd_text_properties)
	(Fremove_text_properties): Prefer bool to int when either works.

627 628
2013-03-02  Eli Zaretskii  <eliz@gnu.org>

629 630
	* textprop.c (Fadd_text_properties, Fremove_text_properties):
	If the interval tree changes as a side effect of calling
631 632 633
	modify_region, re-do processing starting from the call to
	validate_interval_range.  (Bug#13743)

634
2013-02-28  Eli Zaretskii  <eliz@gnu.org>
635 636 637 638

	* w32.c (sys_open): Don't reset the flags for FD in fd_info[].
	(Bug#13546).

639 640 641 642 643 644 645
2013-02-27  Eli Zaretskii  <eliz@gnu.org>

	* filelock.c (create_lock_file) [WINDOWSNT]: Use _sopen with
	_SH_DENYRW flag, instead of emacs_open, to deny any other process
	access to the lock file until it is written and closed.
	(Bug#13807)

646 647 648 649 650 651
2013-02-27  Paul Eggert  <eggert@cs.ucla.edu>

	* callint.c (Qcall_interactively):
	* macros.c (Qexecute_kbd_macro):
	Now static.

652 653 654 655
2013-02-26  Bastien Guerry  <bzg@gnu.org>

	* window.c (Frecenter): Tiny docstring enhancement.

Paul Eggert's avatar
Paul Eggert committed
656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672
2013-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	Minor textprop integer cleanup.
	* intervals.h, textprop.c (add_text_properties_from_list):
	Return void, not int, since nobody uses the return value.
	* textprop.c (validate_plist, add_properties, remove_properties)
	(Fadd_text_properties):
	Don't assume list length fits in int.
	(interval_has_all_properties, interval_has_some_properties)
	(interval_has_some_properties_list, add_properties, remove_properties)
	(Fadd_text_properties, Fremove_text_properties)
	(Fremove_list_of_text_properties, text_property_stickiness):
	Use bool for booleans.
	(Fadd_text_properties, Fremove_text_properties):
	(Fremove_list_of_text_properties):
	Reindent do-while as per GNU style.

673 674
2013-02-25  Eli Zaretskii  <eliz@gnu.org>

675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702
	Implement CLASH_DETECTION for MS-Windows.

	* filelock.c [WINDOWSNT]: Include w32.h.
	(MAKE_LOCK_NAME): Don't use 'lock', it clashes with MS runtime
	function of that name.  Up-case the macro arguments.
	(IS_LOCK_FILE): New macro.
	(fill_in_lock_file_name): Use IS_LOCK_FILE instead of S_ISLNK.
	(create_lock_file): New function, with body extracted from
	lock_file_1.
	[WINDOWSNT]: Implement lock files by writing a regular file with
	the lock information as its contents.
	(read_lock_data): New function, on Posix platforms just calls
	emacs_readlinkat.
	[WINDOWSNT]: Read the lock info from the file.
	(current_lock_owner): Call read_lock_data instead of calling
	emacs_readlinkat directly.
	(lock_file) [WINDOWSNT]: Run the file name through
	dostounix_filename.

	* w32proc.c (sys_kill): Support the case of SIG = 0, in which case
	just check if the process by that PID exists.

	* w32.c (sys_open): Don't reset the _O_CREAT flag if _O_EXCL is
	also present, as doing so will fail to error out if the file
	already exists.

	* makefile.w32-in ($(BLD)/filelock.$(O)): Depend on src/w32.h.

703 704 705
	* textprop.c (Fadd_text_properties, Fremove_text_properties)
	(Fremove_list_of_text_properties): Skip all of the intervals in
	the region between START and END that already have resp. don't
706 707
	have the requested properties, not just the first one.
	Add assertions that the loop afterwards always modifies the
708 709
	properties.  (Bug#13743)

710 711 712 713 714 715
2013-02-25  Stefan Monnier  <monnier@iro.umontreal.ca>

	* callint.c (Fcall_interactively): Use the right lexical environment
	for `interactive' specs (bug#13811).
	* eval.c (Feval): Accept a lexical environment.

716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748
2013-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	Simplify data_start configuration (Bug#13783).
	This is a followon simplification to the fix for Bug#13650.
	* Makefile.in (LD_FIRSTFLAG, LIB_GCC, CRT_DIR, LIB_STANDARD)
	(START_FILES): Remove.  All uses removed.
	(otherobj): Remove $(VMLIMIT_OBJ), as it's now first.
	(ALLOBJS): Move here from autodeps.mk, and with VMLIMITS_OBJ first.
	(buildobj.h): Use it.
	($(ALLOBJS)): Depend on globals.h.
	(temacs$(EXEEXT)): Use $(ALLOBJS).
	* autodeps.mk (ALLOBJS): Move to Makefile.in.
	* deps.mk (vm-limit.o):
	* makefile.w32-in ($(BLD)/vm-limit.$(O)):
	Do not depend on mem-limits.h.
	* emacs.c (__do_global_ctors, __do_global_ctors_aux)
	(__do_global_dtors, __CTOR_LIST__, __DTOR_LIST__)
	[__GNUC__ && !ORDINARY_LINK]: Remove.
	* mem-limits.h, pre-crt0.c: Remove.
	* unexaix.c, unexcoff.c: Don't include mem-limits.h.
	* unexcoff.c (etext): New decl.
	(make_hdr): Use DATA_START instead of start_of_data.
	* vm-limit.c: Move most of mem-limits.h's contents here.
	(data_start): New decl.  It's OK if this is approximate,
	so simplify-away some unnecessary exactness.
	(POINTER): Remove; all uses removed.
	(data_space_start): Now char *, to avoid casts.
	(exceeds_lisp_ptr): New function, replacing the old
	EXCEEDS_LISP_PTR macro.  All uses changed.
	(check_memory_limits): Simplify and remove casts.
	(start_of_data) [!CANNOT_DUMP || !SYSTEM_MALLOC]: Remove.
	(memory_warnings): Use data_start instead of start_of_data.

Andreas Schwab's avatar
Andreas Schwab committed
749 750 751 752 753
2013-02-24  Andreas Schwab  <schwab@linux-m68k.org>

	* xdisp.c (set_message): Only check for debug-on-message if STRING
	is a string.  (Bug#13797)

754 755 756 757 758 759 760 761 762
2013-02-24  Paul Eggert  <eggert@cs.ucla.edu>

	Fix regression introduced by July 10 filelock.c patch.
	* filelock.c (fill_in_lock_file_name): Fix crash caused by the
	2012-07-10 patch to this file.  Reported by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00533.html>
	and diagnosed by Andreas Schwab in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00534.html>.

Paul Eggert's avatar
Paul Eggert committed
763 764 765 766 767 768 769 770
2013-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	Assume C89 or better.
	* ralloc.c (SIZE, POINTER, NIL):
	* vm-limit.c (POINTER):
	Remove, replacing all uses with C89 equivalents.  These old
	symbols were present only for porting to pre-C89 platforms.

771 772 773 774 775
2013-02-22  Claudio Bley  <claudio.bley@gmail.com>

	* w32.c (emacs_gnutls_pull): Don't call 'select', and don't loop.
	This avoids warning messages reported as part of Bug#13546.

776 777 778 779
2013-02-21  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (report_sheap_usage): Fix arguments of message1_no_log.

780 781
2013-02-20  Stefan Monnier  <monnier@iro.umontreal.ca>

782 783
	* sheap.c (report_sheap_usage): Prefer message1_nolog.

784 785 786 787 788
	* keyboard.c (Qcommand_execute): New var.
	(command_loop_1, read_char): Use it.
	(Fcommand_execute): Remove, replace by an Elisp implementation.
	(syms_of_keyboard): Adjust accordingly.

789
2013-02-19  Daniel Colascione <dancol@dancol.org>
790

791 792 793
	* sheap.c (report_sheap_usage): Use message, not message1, so
	that we don't try to create a buffer while we're in the middle
	of dumping Emacs.  Explain why.
794

795
2013-02-20  Dmitry Antipov  <dmantipov@yandex.ru>
796

797 798
	* search.c (find_newline): Return byte position in bytepos.
	Adjust comment.
799 800
	(find_next_newline_no_quit, find_before_next_newline):
	Add bytepos argument.
801 802 803 804 805 806 807 808 809
	* lisp.h (find_newline, find_next_newline_no_quit)
	(find_before_next_newline): Adjust prototypes.
	* bidi.c (bidi_find_paragraph_start):
	* editfns.c (Fconstrain_to_field, Fline_end_position):
	* indent.c (compute_motion, vmotion):
	* xdisp.c (back_to_previous_line_start, forward_to_next_line_start):
	(get_visually_first_element, move_it_vertically_backward):
	Adjust users and avoid calls to CHAR_TO_BYTE where appropriate.

810
2013-02-19  Eli Zaretskii  <eliz@gnu.org>
811 812 813 814

	* w32proc.c (new_child): Avoid leaking handles if the subprocess
	resources were not orderly released.

815 816 817 818 819 820
2013-02-17  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (x_draw_vertical_border): For a window that is neither
	the leftmost nor the rightmost, redraw both the left and the right
	vertical borders.  (Bug#13723)

821 822 823 824 825 826 827 828 829 830 831 832 833
2013-02-17  Stefan Monnier  <monnier@iro.umontreal.ca>

	* xml.c (init_libxml2_functions):
	* sound.c (sound_warning):
	* sheap.c (report_sheap_usage):
	* process.c (wait_reading_process_output):
	* msdos.c (XMenuActivate):
	* macros.c (Fstart_kbd_macro, Fend_kbd_macro):
	* keyboard.c (top_level_1):
	* editfns.c (Fmessage, Fmessage_box):
	* callint.c (Fcall_interactively):
	* fns.c (Fyes_or_no_p): Prefer `message1' over `message'.

834 835 836 837 838
2013-02-17  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (syms_of_xterm): Move scroll-bar-adjust-thumb-portion ...
	* frame.c (syms_of_frame): ... to here.

839 840
2013-02-16  Eli Zaretskii  <eliz@gnu.org>

841 842
	* w32.c (sys_chown): Remove unused function.

843 844 845
	* w32term.c <input_signal_count>: Declare 'volatile'
	unconditionally.  (Bug#9066)

846 847 848 849 850 851 852 853 854 855
	* w32.c (set_errno): Reset h_errno and don't set it to any other
	value.  Set errno instead.
	(check_errno): Reset h_errno.
	(sys_socket, socket_to_fd, sys_bind, sys_connect)
	(sys_gethostname, sys_getservbyname, sys_getpeername)
	(sys_shutdown, sys_setsockopt, sys_listen, sys_getsockname)
	(sys_accept, sys_recvfrom, sys_sendto, fcntl, sys_read): Don't set
	h_errno.
	(sys_gethostbyname): Set h_errno only errors detected.

856 857 858 859
2013-02-15  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (h_errno) [!HAVE_H_ERRNO]: Remove unused decl.

860 861
2013-02-15  Eli Zaretskii  <eliz@gnu.org>

862 863 864
	* keyboard.c (read_char): Fix calculation of auto-save time out
	when auto-save-timeout is less than 4.  (Bug#13720)

865
	* w32proc.c (new_child): Free up to 2 slots of dead processes at a
866
	time.  Improve diagnostics in DebPrint.  (Bug#13546)
867

868 869 870 871 872 873 874 875 876 877
	* w32.c (sys_socket, sys_bind, sys_connect, sys_gethostname)
	(sys_gethostbyname, sys_getservbyname, sys_getpeername)
	(sys_shutdown, sys_setsockopt, sys_listen, sys_getsockname)
	(sys_accept, sys_recvfrom, sys_sendto, fcntl): In case of failure,
	make sure errno is set to an appropriate value.  (Bug#13546)
	(socket_to_fd): Add assertion against indexing fd_info[] with a
	value that is out of bounds.
	(sys_accept): If fd is negative, do not set up the child_process
	structure for reading.

878 879 880 881 882 883 884 885 886 887 888 889 890 891
2013-02-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* composite.c (fill_gstring_header): Remove useless prototype.
	Break long line.
	* lisp.h (message_dolog, compile_pattern): Adjust prototype.
	* print.c (PRINTDECLARE, print_object):
	* search.c (compile_pattern, fast_looking_at, search_buffer):
	(simple_search, boyer_moore, Freplace_match):
	* xdisp.c (c_string_pos, number_of_chars, message_dolog):
	(get_overlay_arrow_glyph_row, display_mode_element):
	(decode_mode_spec_coding, message3):
	* xfaces.c (face_at_string_position): Use bool for booleans.
	Adjust comments.

892
2013-02-15  Paul Eggert  <eggert@cs.ucla.edu>
Paul Eggert's avatar
Paul Eggert committed
893

Paul Eggert's avatar
Paul Eggert committed
894 895 896 897 898 899
	Fix AIX port (Bug#13650).
	* lisp.h (XPNTR) [!USE_LSB_TAG && DATA_SEG_BITS]:
	Fix bug introduced in 2012-07-27 change.  DATA_SEG_BITS, if set,
	was #undeffed earlier, so it cannot be used as a macro here.
	Use the constant and not the macro.

900
2013-02-15  Eli Zaretskii  <eliz@gnu.org>
901

902 903 904 905
	* w32proc.c (new_child): If no vacant slots are found in
	child_procs[], make another pass looking for slots whose process
	has exited or died.  (Bug#13546)

906 907 908 909 910 911
	* w32.c (sys_pipe): When failing due to file descriptors above
	MAXDESC, set errno to EMFILE.
	(_sys_read_ahead): Update cp->status when failing to read serial
	communications input, so that the status doesn't stay at
	STATUS_READ_IN_PROGRESS.  (Bug#13546)

912 913 914 915 916
2013-02-14  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (tb_size_cb): New function.
	(xg_create_tool_bar): Connect size-allocate to tb_size_cb (Bug#13512).

917 918 919 920 921
2013-02-14  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (active_maps): Fcurrent_active_maps expects a position, not
	an event.

922 923 924 925
2013-02-13  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (syms_of_keyboard): Further tweaks of docstring.

926 927 928 929 930 931 932 933
2013-02-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (font_range): Add pos_byte argument.  Adjust comment
	and break long line.
	* font.h (font_range): Adjust prototype.
	* composite.c (autocmp_chars): Pass byte position to font_range.
	Break long line.  Remove useless prototype and format comment.

934 935 936 937
2013-02-13  Glenn Morris  <rgm@gnu.org>

	* keyboard.c (input-decode-map, key-translation-map): Doc fixes.

938
2013-02-13  Paul Eggert  <eggert@cs.ucla.edu>
939

Paul Eggert's avatar
Paul Eggert committed
940 941 942 943 944 945 946 947 948 949 950 951 952 953
	Improve AIX port some more (Bug#13650).
	With this, it should be as good as it was in 23.3, though it's
	still pretty bad: the dumped emacs does not run.  See Mark Fleishman in
	http://lists.gnu.org/archive/html/help-gnu-emacs/2011-04/msg00287.html
	* unexaix.c (start_of_text): Remove.
	(_data, _text): Declare as char[], not int, as AIX manual suggests.
	(bias, lnnoptr, text_scnptr, data_scnptr, load_scnptr)
	(orig_load_scnptr, orig_data_scnptr):
	Now off_t, not long, since they are file offsets.
	(make_hdr): Use _data, not start_of_data ().
	This is the key part of the fix.
	(make_hdr, unrelocate_symbols): Use off_t for file offsets.
	(unrelocate_symbols): Cast pointers to intptr_t, not to ulong.

954 955 956 957
	* pre-crt0.c (data_start): Initialize to 1.
	This ports to compilers that optimize the external declaration
	'int x = 0;' as if it were 'int x;' to shrink the executable.

Paul Eggert's avatar
Paul Eggert committed
958 959 960 961 962 963 964 965 966 967 968
	Improve AIX port (Bug#13650).
	This doesn't fix the bug, but it makes progress: Emacs builds now.
	* unexaix.c: Include inttypes.h, stdarg.h.
	(report_error, report_error_1): Mark as _Noreturn.
	(report_error): Don't report the wrong errno.
	(report_error_1): Now varargs.  All callers changed.
	(make_hdr): Use uintptr_t, not unsigned, when converting pointers
	to unsigned.  Don't use ADDR_CORRECT, as it no longer exists.
	(write_ptr): Use %p to print address rather than %lx and a cast
	to unsigned long.  Grow buffer a bit, to be safer.

969
2013-02-13  Eli Zaretskii  <eliz@gnu.org>
Eli Zaretskii's avatar
Eli Zaretskii committed
970 971 972 973 974 975 976 977 978 979

	* bidi.c (bidi_resolve_neutral): After finding the next
	non-neutral character, accept NEUTRAL_ON type as well, because
	directional control characters, such as LRE and RLE, have their
	type converted to that by bidi_resolve_weak.  This avoids aborts
	when LRE/RLE follows a run of neutrals.
	(bidi_move_to_visually_next): Assert that return value of
	bidi_peek_at_next_level is non-negative.  Negative values will
	cause an infloop.

Paul Eggert's avatar
Paul Eggert committed
980 981 982 983 984 985 986 987 988 989
2013-02-13  Paul Eggert  <eggert@cs.ucla.edu>

	Minor getenv-related fixes.
	* callproc.c (Fcall_process_region) [!DOS_NT]:
	Avoid unnecessary duplicate call to getenv.
	* callproc.c (init_callproc):
	* dispnew.c (init_display):
	* sysdep.c (sys_subshell):
	Omit unnecessary cast of getenv or egetenv.

990 991 992 993 994
2013-02-13  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/sysdep.$(O)):
	Update dependencies.

995 996 997 998 999 1000 1001 1002
2013-02-12  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_internal): Don't set w->region_showing to the
	marker's position.
	(display_line): Set w->region_showing to the value of
	it->region_beg_charpos, not to -1.  This fixes redisplay
	optimization when cursor is moved up after M->.  (Bug#13623)
	(Bug#13626)
1003 1004 1005
	(try_scrolling): Scroll text up more if point is too close to ZV
	and inside the scroll margin.  This makes sure point is moved
	outside the scroll margin in these cases.
1006 1007 1008 1009

	* window.h (struct window): region_showing can no longer be
	negative.

1010 1011
2013-02-11  Paul Eggert  <eggert@cs.ucla.edu>

1012 1013 1014 1015 1016 1017 1018 1019 1020
	Tune by using memchr and memrchr.
	* doc.c (Fsnarf_documentation):
	* fileio.c (Fsubstitute_in_file_name):
	* search.c (find_newline, scan_newline):
	* xdisp.c (pos_visible_p, display_count_lines):
	Use memchr and memrchr rather than scanning byte-by-byte.
	* search.c (find_newline): Rename from scan_buffer.
	Omit first arg TARGET, as it's always '\n'.  All callers changed.

1021 1022 1023 1024
	Clean up read_key_sequence a tiny bit more.
	* keyboard.c (read_char_x_menu_prompt) [HAVE_MENUS]:
	(read_key_sequence): Remove unused locals.

1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2013-02-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	Clean up read_key_sequence a bit; reread active keymaps after first event.
	* keyboard.c (read_char, read_char_x_menu_prompt)
	(read_char_minibuf_menu_prompt):
	Replace nmaps+maps with a single `map' arg.
	(follow_key): Operate on a single map.
	(active_maps): New function.
	(test_undefined): Also return true for nil bindings.
	(read_key_sequence): Use active_maps to replace the arrays of keymaps with
	a single (composed) keymap.  Remember `first_event' to choose the right
	set of active keymaps.  Recompute the set of keymaps after receiving
	the first event.  Remove GOBBLE_FIRST_EVENT.
	(syms_of_keyboard): Remove inhibit_local_menu_bar_menus.
	* keyboard.h (read_char): Update declaration.
	* lread.c (read_filtered_event): Adjust call to read_char.

1042 1043
2013-02-11  Eli Zaretskii  <eliz@gnu.org>

1044 1045
	* xdisp.c (move_it_vertically_backward, move_it_by_lines):
	Don't use the limitation on backwards movement when lines are truncated
1046 1047
	in the window.  (Bug#13675)

1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058
2013-02-11  Dmitry Antipov  <dmantipov@yandex.ru>

	* marker.c (set_marker_internal): If desired position is passed
	as a marker, avoid call to buf_charpos_to_bytepos.
	* window.c (Fset_window_point): Omit redundant type checking.
	(Fset_window_start): Likewise.  Format comment.
	(window_scroll_pixel_based): Use set_marker_restricted_both
	with character and byte positions obtained from an iterator.
	(Fset_window_configuration): Use set_marker_restricted_both.
	* xdisp.c (message_dolog): Likewise.

1059 1060
2013-02-10  Eli Zaretskii  <eliz@gnu.org>

1061 1062
	* xdisp.c (move_it_vertically_backward, move_it_by_lines):
	When text lines are longer than window's screen lines, don't move back
1063 1064
	too far.  This speeds up some redisplay operations.  (Bug#13675)

1065 1066 1067 1068 1069
2013-02-10  Dmitry Antipov  <dmantipov@yandex.ru>

	* syntax.c (scan_sexps_forward): Fix byte position calculation
	Bug#13664 (a.k.a Bug#13667) introduced with 2013-02-08 change.

1070 1071 1072 1073 1074
2013-02-10  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Fexpand_file_name): Omit confusing pointer comparison
	that was not needed.

Paul Eggert's avatar
Paul Eggert committed
1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
2013-02-09  Paul Eggert  <eggert@cs.ucla.edu>

	Minor hashing refactoring.
	* fns.c (SXHASH_REDUCE): Move to lisp.h.
	(sxhash_float): Return EMACS_UINT, for consistency with the other
	hash functions.
	* lisp.h (INTMASK): Now a macro, since SXHASH_REDUCE is now a
	non-static inline function and therefore can't use static vars.
	(SXHASH_REDUCE): Move here from fns.c, and make it inline.
	* profiler.c (hashfn_profiler): Use SXHASH_REDUCE, to be consistent
	with the other hash functions.

1087 1088
2013-02-09  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
1089 1090 1091
	* callproc.c (Fcall_process_region) [WINDOWSNT]: Make sure the
	XXXXXX part of the temporary file pattern is not downcased even
	when w32-downcase-file-names is non-nil.  (Bug#13661)
1092

1093 1094
	* xdisp.c (decode_mode_spec): Remove handling of %t.

1095 1096
	* msdos.c (careadlinkatcwd): Remove.

1097 1098 1099 1100 1101 1102
2013-02-08  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (skip_dyn_bytes): New function (bug#12598).
	(read1): Use it.  Use getc instead of READCHAR to read bytes.
	(load_each_byte): Remove.  Update users.

1103 1104 1105 1106 1107 1108 1109 1110 1111 1112
2013-02-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* search.c (scan_buffer): Calculate end byte position just once.
	(scan_newline): Do not recalculate start_byte.
	(search_command): Use eassert.
	* syntax.c (struct lisp_parse_state): New member location_byte.
	(scan_sexps_forward): Record from_byte and avoid redundant
	character to byte position calculation ...
	(Fparse_partial_sexp): ... here.  Break too long line.

1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
2013-02-08  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (make_uninit_vector): New function.
	* alloc.c (Fvector, Fmake_byte_code):
	* ccl.c (Fregister_ccl_program):
	* charset.c (Fdefine_charset_internal, define_charset_internal):
	* coding.c (make_subsidiaries, Fdefine_coding_system_internal):
	* composite.c (syms_of_composite):
	* font.c (Fquery_font, Ffont_info, syms_of_font):
	* fontset.c (FONT_DEF_NEW, Fset_fontset_font):
	* ftfont.c (ftfont_shape_by_flt):
	* indent.c (recompute_width_table):
	* nsselect.m (clean_local_selection_data):
	* syntax.c (init_syntax_once):
	* w32unsubscribe.c (uniscribe_shape):
	* window.c (Fcurrent_window_configuration):
	* xfaces.c (Fx_family_fonts):
	* xselect.c (selection_data_to_lisp_data): Use it.

1132 1133 1134 1135 1136 1137 1138 1139
2013-02-07  Dmitry Antipov  <dmantipov@yandex.ru>

	* coding.c (Fdefine_coding_system_internal): Use AREF where
	argument is known to be a vector.
	* fns.c (Flocale_info): Likewise for ASET.
	* xselect.c (selection_data_to_lisp_data): Likewise for ASET.
	* w32fns.c (w32_parse_hot_key): Likewise for ASIZE and AREF.

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
2013-02-05  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (update_frame_tool_bar): Check for negative tool bar
	height.

	* nsterm.h (HAVE_NATIVE_FS): Define if OSX => 10.7.
	(EmacsView): Add fs_is_native, fsIsNative, isFullscreen and
	updateCollectionBehaviour.

	* nsterm.m (NEW_STYLE_FS): Remove.
	(ns_last_use_native_fullscreen): New variable.
	(x_make_frame_visible): Replace NEW_STYLE_FS with isFullscreen.
	(x_set_window_size): Do not take title bar and tool bar into account
	if isFullscreen returns YES.
	(ns_fullscreen_hook): Replace NEW_STYLE_FS with isFullscreen.
	(check_native_fs): New function.
	(ns_select, ns_read_socket): Call check_native_fs if HAVE_NATIVE_FS.
	(ns_term_init): Remove NEW_STYLE_FS.
	(updateFrameSize:, windowWillResize:toSize:): Only adjust for title bar
	and tool bar if isFullscreen returns NO.
	(windowDidResize:): Replace NEW_STYLE_FS with fsIsNative.
	(initFrameFromEmacs:): Initialize fs_is_native.  Replace NEW_STYLE_FS
	with HAVE_NATIVE_FS.
	(window:willUseFullScreenPresentationOptions:): New method.
	(windowDidEnterFullScreen:): Replace NEW_STYLE_FS with fsIsNative.
	Hide toolbar if not enabled (Bug#13444).
	(windowDidExitFullScreen:): Call updateCollectionBehaviour.
	Restore tool bar if enabled, hide it otherwise (Bug#13444).
	(fsIsNative, isFullscreen, updateCollectionBehaviour): New methods.
	(toggleFullScreen:): If fs_is_native, call toggleFullScreen on
	window.  Do no set FRAME_EXTERNAL_TOOL_BAR (f) to 0.
	Check FRAME_EXTERNAL_TOOL_BAR (f) before restoring
	FRAME_TOOLBAR_HEIGHT (f).  Call updateFrameSize when going non-fs.
	(syms_of_nsterm): Add ns-use-native-fullscreen.

1175 1176 1177 1178
2013-02-04  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Qchoose_write_coding_system): Now static.

1179 1180 1181 1182 1183
2013-02-04  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (window_buffer_changed): region_showing can be negative,
	which still means region is being displayed.
	(redisplay_internal): Resurrect code that forced redisplay of the
1184 1185
	whole window when showing region and the mark has changed.
	Record the new mark position to allow redisplay optimizations.
1186 1187 1188 1189 1190 1191
	(display_line): If it->region_beg_charpos is non-zero, set the
	window's region_showing member to -1.  (Bug#13623)  (Bug#13626)

	* window.h (struct window) <region_showing>: Declare ptrdiff_t,
	not bitfield of 1 bit.

1192 1193 1194 1195 1196 1197
2013-02-03  Daniel Colascione  <dancol@dancol.org>

	* emacs.c: Use execvp, not execv, when DAEMON_MUST_EXEC, so that
	daemon mode works on cygw32 when Emacs is installed and not just
	during development.

1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208
2013-02-02  Paul Eggert  <eggert@cs.ucla.edu>

	Avoid file time stamp bug on MS-Windows (Bug#13149).
	* fileio.c (Fwrite_region): Don't use the heuristic on empty files,
	as FAT32 doesn't update time stamps when truncating them.
	Also, check that a file time stamp is not a multiple of 100 ns;
	this should catch all instances of the problem on MS-Windows,
	as its native file system resolution is 100 ns or worse, and
	checking for a non-multiple of 100 ns should impose only a small
	overhead on systems with ns resolution.

1209
2013-02-02  Eli Zaretskii  <eliz@gnu.org>
1210

1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
	Avoid encoding file names on MS-Windows when they need to be run
	through dostounix_filename.
	* w32.c (normalize_filename): Accept an additional argument
	MULTIBYTE; if non-zero, traverse the file name by bytes and don't
	downcase it even if w32-downcase-file-names is non-nil.
	(dostounix_filename): Accept an additional argument MULTIBYTE and
	pass it to normalize_filename.
	(emacs_root_dir): Adjust.

	* msdos.h (dostounix_filename): Adjust prototype.

	* w32.h (dostounix_filename): Adjust prototype.

	* msdos.c (dostounix_filename): Accept an additional argument and
	ignore it.
	(init_environment): Adjust callers of dostounix_filename.

	* fileio.c (Ffile_name_directory, file_name_as_directory)
	(directory_file_name, Fexpand_file_name)
	(Fsubstitute_in_file_name): [DOS_NT] Adjust call to
	dostounix_filename.
	[WINDOWSNT]: Downcase file names if w32-downcase-file-names is
	non-nil.
	(Fsubstitute_in_file_name): [DOS_NT] Don't downcase environment
	variables, as egetenv is case-insensitive for DOS_NT.

	* dired.c (file_name_completion): Don't call Fdirectory_file_name
	with an encoded file name.

1240 1241
	* w32proc.c (Fw32_short_file_name, Fw32_long_file_name):
	Adjust calls to dostounix_filename.
1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254

	* w32fns.c (Fx_file_dialog): Adjust call to dostounix_filename.

	* unexw32.c (unexec): Adjust call to dostounix_filename.

	* termcap.c (tgetent) [MSDOS]: Adjust call to dostounix_filename.

	* emacs.c (decode_env_path) [DOS_NT]: Adjust call to
	dostounix_filename.

	* callproc.c (Fcall_process) [MSDOS]: Adjust call to
	dostounix_filename.

1255 1256 1257 1258 1259
	* callproc.c (Fcall_process): Make sure program name in PATH and
	new_argv[0] is encoded, if needed.  Otherwise, un-encoded string
	is passed to exec/spawnve, which fails unless the file-name
	encoding is UTF-8.

1260 1261 1262
	* w32proc.c (sys_spawnve): Make sure escape_char is initialized,
	even if w32-quote-process-args is nil.

1263 1264 1265 1266 1267 1268 1269 1270 1271
2013-02-01  Paul Eggert  <eggert@cs.ucla.edu>

	Fix timestamp bug when write-region appends nothing (Bug#13149).
	* fileio.c (Fwrite_region): When neither O_EXCL nor O_TRUNC is used,
	the file's time stamp doesn't change if Emacs happens to write nothing
	to the file, and on a buggy file system this could cause Emacs to
	incorrectly infer that the file system doesn't have the bug.
	Avoid this problem by inhibiting the inference in this case.

1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
2013-02-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert base_line_number, base_line_pos
	and column_number_displayed members from Lisp_Object to ptrdiff_t.
	Convert region_showing member from Lisp_Object to bitfield.
	Remove sequence_number member.  Adjust comments.
	* window.c (sequence_number): Remove.
	(make_window): Initialize column_number_displayed.
	* print.c (print_object): Follow the printed representation of
	frames and print window pointer to distinguish between windows.
	(adjust_window_count): Invalidate base_line_pos.  Adjust comment.
	* xdisp.c (wset_base_line_number, wset_base_line_pos)
	(wset_column_number_displayed, wset_region_showing): Remove.
	(window_buffer_changed, mode_line_update_needed, redisplay_internal)
	(try_scrolling, try_cursor_movement, redisplay_window)
	(try_window_reusing_current_matrix, try_window_id, display_line)
	(display_mode_lines, decode_mode_spec): Adjust users.
	* .gdbinit (pwinx): Do not print sequence_number.

1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321
2013-02-01  Paul Eggert  <eggert@cs.ucla.edu>

	Use fdopendir, fstatat and readlinkat, for efficiency (Bug#13539).
	* conf_post.h (GNULIB_SUPPORT_ONLY_AT_FDCWD): Remove.
	* dired.c: Include <fcntl.h>.
	(open_directory): New function, which uses open and fdopendir
	rather than opendir.  DOS_NT platforms still use opendir, though.
	(directory_files_internal, file_name_completion): Use it.
	(file_attributes): New function, with most of the old Ffile_attributes.
	(directory_files_internal, Ffile_attributes): Use it.
	(file_attributes, file_name_completion_stat): First arg is now fd,
	not dir name.  All uses changed.  Use fstatat rather than lstat +
	stat.
	(file_attributes): Use emacs_readlinkat rather than Ffile_symlink_p.
	* fileio.c: Include <allocator.h>, <careadlinkat.h>.
	(emacs_readlinkat): New function, with much of the old
	Ffile_symlink_p, but with an fd argument for speed.
	It uses readlinkat rather than careadlinkatcwd, so that it
	need not assume the working directory.
	(Ffile_symlink_p): Use it.
	* filelock.c (current_lock_owner): Use emacs_readlinkat
	rather than emacs_readlink.
	* lisp.h (emacs_readlinkat): New decl.
	(READLINK_BUFSIZE, emacs_readlink): Remove.
	* sysdep.c: Do not include <allocator.h>, <careadlinkat.h>.
	(emacs_norealloc_allocator, emacs_readlink): Remove.
	This stuff is moved to fileio.c.
	* w32.c (fstatat, readlinkat): New functions.
	(careadlinkat): Don't check that fd == AT_FDCWD.
	(careadlinkatcwd): Remove; no longer needed.

1322 1323 1324
2013-01-31  Glenn Morris  <rgm@gnu.org>

	* fileio.c (choose_write_coding_system): Make it callable from Lisp.
1325 1326
	(Fwrite_region): Update for new choose_write_coding_system args.
	Move the last piece of choose_write_coding_system here.  (Bug#13522)
1327 1328
	(syms_of_fileio): Add choose-write-coding-system.

1329
2013-01-30  Eli Zaretskii  <eliz@gnu.org>
1330 1331 1332 1333 1334

	* w32.c (sys_open): Zero out the flags for the new file descriptor.
	(sys_close): Zero out the flags for the file descriptor before
	closing it.  (Bug#13546)

1335
	* w32.c (parse_root, get_volume_info, readdir, read_unc_volume)
1336 1337
	(logon_network_drive, stat_worker, symlink, chase_symlinks):
	Use CharNextExA and CharPrevExA to iterate over file names encoded in
1338 1339
	DBCS.  (Bug#13553)

1340 1341
	* w32.c (w32_get_long_filename, init_environment, readlink):
	Support file names encoded in DBCS codepages.
1342 1343
	(readlink): Use the current file-name-coding-system, not the ANSI
	codepage, to decode and handle targets of symlinks.
1344

1345 1346 1347 1348
2013-01-28  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (opendir): Now accepts a 'const char *'.

1349 1350 1351 1352 1353 1354 1355 1356 1357 1358
2013-01-28  Dmitry Antipov  <dmantipov@yandex.ru>

	Remove obsolete redisplay code.  See the discussion at
	http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00576.html.
	* dispnew.c (preemption_period, preemption_next_check): Remove.
	(Vredisplay_preemption_period): Likewise.
	(update_frame, update_single_window, update_window, update_frame_1):
	Adjust users.  Always assume that PERIODIC_PREEMPTION_CHECKING is not
	used, following the 2012-06-22 change.

1359 1360 1361 1362
2013-01-25  Eli Zaretskii  <eliz@gnu.org>

	* w32notify.c (Fw32notify_add_watch): Doc fix.  (Bug#13540)

1363 1364 1365 1366
2013-01-25  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (num_fonts): Remove the leftover from old
	debugging code.  Adjust comment style here and there.
1367 1368 1369
	* insdel.c (insert_1): Remove.
	* lisp.h (insert_1): Remove prototype.
	* xdisp.c (message_dolog): Adjust users to call insert_1_both.
1370

1371
2013-01-25  Eli Zaretskii  <eliz@gnu.org>
1372 1373 1374 1375 1376

	* w32.c (max_filename_mbslen): New function.
	(normalize_filename, readdir): Use it to detect locales where ANSI
	encoding of file names uses a double-byte character set (DBCS).
	If a DBCS encoding is used, advance by characters using
1377 1378
	CharNextExA, instead of incrementing a 'char *' pointer.
	Use _mbslwr instead of _strlwr.  (Bug#13515)
1379

1380 1381 1382
	* w32heap.c (allocate_heap) [!_WIN64]: Decrease the initial
	request of memory reservation to 1.7GB.  (Bug#13065)

1383
2013-01-25  Andreas Schwab  <schwab@linux-m68k.org>
Andreas Schwab's avatar
Andreas Schwab committed
1384 1385 1386 1387

	* coding.c (detect_coding_iso_2022): Move back mis-reordered code
	at check_extra_latin label.  (Bug#13505)

1388 1389 1390 1391 1392
2013-01-24  Dmitry Antipov  <dmantipov@yandex.ru>

	* nsfont.m (ns_escape_name, ns_unescape_name, ns_registry_to_script):
	Avoid redundant calls to strlen.

1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408
2013-01-24  Dmitry Antipov  <dmantipov@yandex.ru>

	Drop async_visible and async_iconified fields of struct frame.
	This is possible because async input is gone; for details, see
	http://lists.gnu.org/archive/html/emacs-devel/2012-12/msg00734.html.
	* frame.h (struct frame): Remove async_visible and async_iconified
	members, convert garbaged to unsigned bitfield.  Adjust comments.
	(FRAME_SAMPLE_VISIBILITY): Remove.  Adjust all users.
	(SET_FRAME_VISIBLE, SET_FRAME_ICONIFIED): New macros.
	* frame.c, gtkutil.c, term.c, w32fns.c, window.c, xdisp.c:
	Consistently use SET_FRAME_VISIBLE, SET_FRAME_ICONIFIED,
	FRAME_VISIBLE_P and FRAME_ICONIFIED_P macros where appropriate.
	* w32term.c: Ditto.
	(w32_read_socket): Save iconified state to generate DEICONIFY_EVENT
	properly.  Likewise for obscured.
	* xterm.c: Ditto.
1409
	(handle_one_xevent): Save visible state to generate ICONIFY_EVENT
1410 1411 1412 1413
	properly.
	* nsterm.m: Ditto.
	(windowDidDeminiaturize): Generate DEICONIFY_EVENT.

1414 1415 1416 1417 1418
2013-01-24  Dmitry Antipov  <dmantipov@yandex.ru>

	* insdel.c (prepare_to_modify_buffer): Revert last change as suggested
	in http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00555.html.

1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447
2013-01-23  Stefan Monnier  <monnier@iro.umontreal.ca>

	* xdisp.c (message2, message2_nolog): Remove functions.
	(message3, message3_nolog): Extract nbytes and multibyteness directly
	from the string.  Change all callers.
	(message3_nolog): Don't set message_enable_multibyte since set_message
	will reset it anyway.
	(message1, message1_nolog): Use message3.
	(vmessage): Use a stack allocated buffer rather than f->message_buf.
	(with_echo_area_buffer): Remove last two arguments.  Update all callers.
	(set_message): Drop all but the second arg, which has to be a string.
	(set_message_1): Simplify now that we know that a1 is NULL and the
	second arg is a string.
	* frame.h (struct frame): Remove `message_buf' field.
	Use glyphs_initialized_p instead.
	(FRAME_MESSAGE_BUF): Remove macro.
	* w16select.c (Fw16_set_clipboard_data): Prefer message3 to message2.
	* lisp.h (message2, message2_nolog): Remove declarations.
	(message3, message3_nolog): Update declarations.
	* keyboard.c (read_char_minibuf_menu_text)
	(read_char_minibuf_menu_width): Remove vars.
	(read_char_minibuf_menu_prompt): Rewrite the menu's construction so as
	to correctly handle multibyte strings.
	* frame.c (delete_frame): Don't free message_buf any more.
	* editfns.c (message_text, message_length): Remove vars.
	(Fmessage_box): Don't copy the Lisp string's bytes any longer.
	* fileio.c (auto_save_error): Use message3 instead of message2.
	* dispnew.c (adjust_frame_message_buffer): Remove function.

1448 1449 1450 1451 1452
2013-01-23  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32fullscreen_hook): Account correctly for the screen
	real estate used for the tool bar and the menu bar.

1453 1454 1455 1456 1457
2013-01-23  Dmitry Antipov  <dmantipov@yandex.ru>

	* insdel.c (prepare_to_modify_buffer): Force redisplay if
	hidden buffer is prepared to modification (Bug#13164).

1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473
2013-01-22  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Change window_end_valid member from
	Lisp_Object to a bitfield.  Adjust comments.
	(wset_window_end_valid): Remove.
	* window.c (adjust_window_count): Clear window_end_valid.
	(Fwindow_end): Adjust user.  Remove ancient #if 0 code.
	(Fwindow_line_height, set_window_buffer, Frecenter)
	(Fsplit_window_internal, Fdelete_other_windows_internal)
	(Fset_window_fringes, Fset_window_scroll_bars): Adjust users.
	* dispnew.c (adjust_glyph_matrix, clear_window_matrices): Likewise.
	* xdisp.c (check_window_end, reconsider_clip_changes)
	(redisplay_internal, mark_window_display_accurate_1, redisplay_window)
	(try_window, try_window_reusing_current_matrix, note_mouse_highlight)
	(find_first_unchanged_at_end_row, try_window_id): Likewise.

1474 1475 1476 1477 1478 1479 1480 1481 1482
2013-01-22  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (mark_window_display_accurate): Simplify the loop
	assuming that the only one of vchild, hchild or buffer window
	slots is non-nil.  Call mark_window_display_accurate_1 for
	the leaf windows only.
	(mark_window_display_accurate_1): Always assume leaf window.
	Adjust comment.

1483 1484
2013-01-22  Paul Eggert  <eggert@cs.ucla.edu>

1485 1486
	* emacs.c (Qkill_emacs_hook): Now static.

1487 1488 1489
	* fileio.c (Finsert_file_contents): Simplify.
	Remove unnecessary assignments and tests.

1490 1491 1492 1493 1494 1495
2013-01-21  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (acl_set_file): Don't test for errors unless
	set_file_security returns FALSE.  Avoids spurious errors when
	saving files.

1496 1497 1498 1499 1500 1501 1502
2013-01-21  Dmitry Antipov  <dmantipov@yandex.ru>

	* fileio.c (Finsert_file_contents): Revert code introduced at
	2013-01-18 in favor of the simpler and generally better fix.
	Save stack space by removing 'buffer' and reusing 'read_buf'
	where appropriate.

1503 1504 1505 1506 1507 1508
2013-01-19  Paul Eggert  <eggert@cs.ucla.edu>

	* lisp.h (eabs): Define unconditionally (Bug#13419).
	The old "#if !defined (eabs)" was an unnecessary revenant of back
	when this macro was called "abs".  Document 'eabs' better.

1509
2013-01-19  Glenn Morris  <rgm@gnu.org>
Glenn Morris's avatar
Glenn Morris committed
1510 1511 1512

	* fns.c (Frandom): Doc fix.

1513 1514 1515 1516 1517 1518
2013-01-19  Eli Zaretskii  <eliz@gnu.org>

	* editfns.c (get_pos_property): Use SAFE_ALLOCA_LISP, to avoid
	segfault when there are lots of overlays.

	* buffer.c (sort_overlays): Use SAFE_NALLOCA, to avoid segfault
1519 1520
	when there are lots of overlays.
	See http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00421.html
1521 1522
	for the details and a way to reproduce.

1523 1524
2013-01-19  Paul Eggert  <eggert@cs.ucla.edu>

1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535
	* fileio.c: Use O_APPEND to append.
	This corresponds better to the natural interpretation of "append",
	and avoids the need to open the output file twice, or to invoke
	lseek when APPEND is neither nil nor a number.
	This relies on POSIX 1003.1-1988 or later, which is OK nowadays.
	(Fwrite_region): Simplify.  Use O_APPEND instead of opening the
	file possibly twice, and lseeking to its end; this avoids the
	need to lseek on non-regular files.  Do not use O_EXCL and O_TRUNC
	at the same time: the combination is never needed and apparently
	it doesn't work with DOS_NT.

1536 1537 1538
	Fix size bug on DOS_NT introduced by CIFS workaround (Bug#13149).
	* fileio.c (Fwrite_region): Use O_BINARY in checking code, too.

1539 1540 1541 1542 1543 1544 1545
	Allow floating-point file offsets.
	Problem reported by Vitalie Spinu in
	<http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00411.html>.
	* fileio.c (emacs_lseek): Remove.
	(file_offset): New function.
	(Finsert_file_contents, Fwrite_region): Use it.

1546 1547 1548 1549 1550
2013-01-19  Chong Yidong  <cyd@gnu.org>

	* emacs.c (Fkill_emacs): Set waiting_for_input to 0 to avoid
	aborting on Fsignal (Bug#13289).

Eli Zaretskii's avatar
Eli Zaretskii committed
1551 1552 1553 1554 1555
2013-01-19  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (acl_set_file): Treat ERROR_ACCESS_DENIED from
	set_file_security as failure due to insufficient privileges.
	Reported by Fabrice Popineau <fabrice.popineau@supelec.fr>.
1556
	(fstat): Return owner and group like 'stat' and 'lstat' do.
Eli Zaretskii's avatar
Eli Zaretskii committed
1557

1558 1559
2013-01-19  Paul Eggert  <eggert@cs.ucla.edu>

1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572
	Work around bug in CIFS and vboxsf file systems (Bug#13149).
	The bug was observed on Ubuntu operating inside a virtual machine,
	editing files mounted via CIFS or vboxsf from the MS Windows 7 host.
	The workaround introduces a race condition on non-buggy hosts,
	but it's an unlikely race and anyway there's a nearly identical
	nearby race that can't be fixed.
	* fileio.c (valid_timestamp_file_system, timestamp_file_system):
	New static vars.
	(Fwrite_region): Test for file system time stamp bug.
	(init_fileio): New function.
	* lisp.h (init_fileio): Declare it.
	* emacs.c (main): Call it.

1573 1574 1575
	* fileio.c (Finsert_file_contents): Simplify new diagnostic
	and make it more consistent with other stat-failure diagnostics.

1576 1577
2013-01-18  Dmitry Antipov  <dmantipov@yandex.ru>

1578 1579
	Fix crash when inserting data from non-regular files.
	See http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00406.html
1580 1581 1582