ChangeLog 1.1 MB
Newer Older
1 2
2011-03-21  Paul Eggert  <eggert@cs.ucla.edu>

3 4 5
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.

Paul Eggert's avatar
Paul Eggert committed
6 7
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
8

Paul Eggert's avatar
Paul Eggert committed
9
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10

11 12 13
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
14
	socklen_t is wider than int (Bug#8277).
15 16 17 18
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

19 20 21 22
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
23
	(Fmake_network_process): Define label "retry_connect" only if needed.
24
	(Fnetwork_interface_info): Fix pointer signedness.
25
	(process_send_signal): Add cast to avoid pointer signedness problem.
26
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
27
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
28

29 30 31 32 33 34 35 36 37 38 39 40
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

41
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
42
	(xftfont_open): Rename locals to avoid shadowing.
43

44
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
45 46
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
47
	(ftfont_list): Remove unused local.
48 49 50
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
51

52 53
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
54 55
	* xml.c (make_dom): Now static.

56 57
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
58 59
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
60
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
61 62
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
63

64 65 66 67 68 69 70
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

71 72
	* textprop.c (property_change_between_p): Remove; unused.

73 74
	* intervals.c (interval_start_pos): Now static.

75 76
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

77 78 79
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

80 81
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
82
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
83 84
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
85

86 87
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

88 89
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
90 91
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
92 93
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
94

95 96 97 98
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

99
	* callproc.c (call_process_cleanup): Now static.
100
	(relocate_fd): Rename locals to avoid shadowing.
101

102 103 104 105
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

106 107 108 109 110 111
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

112 113 114 115 116 117
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

118 119 120 121 122
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

123 124 125 126
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

127 128 129 130
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

131 132
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

133 134
	Fix more problems found by GCC 4.5.2's static checks.

135 136 137
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

138 139 140 141 142 143 144
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

145 146 147
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

148
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
149 150 151
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
152

153 154
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
155 156
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
157
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
158

159 160
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
161
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
162
	* unexec.h: New file.
163 164 165 166 167 168
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
169
	Change as necessary to match prototype in unexec.h.
170

171 172
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
173
	(back_comment, skip_chars): Mark vars as initialized.
174

175 176 177
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

178
	* lread.c (read1): Rewrite so as not to use empty "else".
179
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
180

181 182
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

183 184 185
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

186 187
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
188
	(font_sort_entities): Mark var as initialized.
189

190 191
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

192 193
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
194
	(font_parse_fcname): Remove unused vars.
195
	(font_delete_unmatched): Now static.
196
	(font_get_spec): Remove; unused.
197 198 199
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
200

201
	* fns.c (require_nesting_list, require_unwind): Now static.
202
	(Ffillarray): Rename locals to avoid shadowing.
203

204
	* floatfns.c (domain_error2): Define only if needed.
205
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
206

207 208 209
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

210
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
211
	(Fdefvar): Rewrite so as not to use empty "else".
212 213
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
214
	(Fdefvar): Rename locals to avoid shadowing.
215

216
	* callint.c (quotify_arg, quotify_args): Now static.
217
	(Fcall_interactively): Rename locals to avoid shadowing.
218
	Use const pointer when appropriate.
219

220 221 222 223
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
224 225 226
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
227 228 229
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
230
	(Ftranslate_region_internal): Mark var as initialized.
231

232 233 234
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

235 236 237
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

238 239
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
240
	(default_value, arithcompare, arith_driver, arith_error): Now static.
241
	(store_symval_forwarding): Rename local to avoid shadowing.
242 243
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
244
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
245

246
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
247 248
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
249 250
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
251 252 253 254 255
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
256
	(Fmemory_limit): Cast sbrk's returned value to char *.
257

258 259 260
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

261 262
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

263 264 265 266 267 268 269 270
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
271
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
272
	the race-condition problem in the old DOWNCASE.
273

274 275 276
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
277 278
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
279 280
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
281
	(regex_compile, re_match_2_internal): Mark locals as initialized.
282 283 284 285 286 287 288
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
289

290
	* search.c (boyer_moore): Rename locals to avoid shadowing.
291 292
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
293

294 295
	* search.c (simple_search): Remove unused var.

296 297 298 299
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

300 301
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

302 303 304 305
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
306
	(Fvertical_motion): Mark locals as initialized.
307

308
	* casefiddle.c (casify_object, casify_region): Now static.
309
	(casify_region): Mark local as initialized.
310

311 312
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

313 314 315 316 317 318 319 320 321
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
322 323 324
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

346 347
	* dired.c (directory_files_internal_unwind): Now static.

348 349 350
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
351 352 353
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
354
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
355 356
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
357 358
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
359

360
	* minibuf.c (choose_minibuf_frame_1): Now static.
361 362
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
363

364 365
	* marker.c (bytepos_to_charpos): Remove; unused.

366 367 368
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

369 370
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
371
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
372
	(copy_text): Remove unused local var.
373

374
	* filelock.c (within_one_second): Now static.
375
	(lock_file_1): Rename local to avoid shadowing.
376

377 378 379 380
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
381
	(switch_to_buffer_1): Now static.
382 383
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
384

385
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
386
	Fix pointer signedness issue.
387 388
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
389
	(MAXPATHLEN): Define only if needed.
390

391 392 393
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

394 395 396
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

397
	* sysdep.c (reset_io): Now static.
398
	(wait_for_termination_signal): Remove; unused.
399

400 401 402
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
403
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
404
	(DENSE_TABLE_SIZE): Remove; unused.
405 406 407
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
408

409 410 411
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
412 413 414 415 416
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
417
	(read_key_sequence, read_char): Mark locals as initialized.
418
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
419

420
	* keyboard.h (make_ctrl_char): New decl.
421 422
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
423

424 425
	* lisp.h (force_auto_save_soon): New decl.

426
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
427 428 429
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
430 431
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
432

433 434
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

435 436 437 438 439 440 441
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

442 443
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
444
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
445

446 447
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

448 449 450
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

451 452
	* print.c (print_preprocess): Don't forget font objects.

453 454 455 456
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

457 458 459 460 461
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

462 463 464 465 466 467 468 469
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
470
	(run_protected): Add extern declaration for waiting_for_input.
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

487 488
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
489
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
490

491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

513 514 515 516 517
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

518 519
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
520 521
	Fix more problems found by GCC 4.5.2's static checks.

522 523
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
524 525
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
526 527
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
528 529 530 531 532
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
533 534 535
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
536

537 538
	* xgselect.c (xg_select): Remove unused var.

539 540 541
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
542
	(my_png_error, my_error_exit): Mark with NO_RETURN.
543

544
	* image.c (clear_image_cache): Now static.
545
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
546
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
547 548
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
549
	(gif_load): Fix pointer signedness.
550 551
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
552

Paul Eggert's avatar
Paul Eggert committed
553 554
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

555 556 557 558 559 560
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
561 562 563 564 565 566 567 568 569 570 571 572
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
573 574
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
575

576 577 578 579
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

580 581 582 583 584
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

585
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
586

587 588
	* fringe.c (update_window_fringes): Remove unused variables.

589 590 591
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

592 593
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
594
	* termcap.c [MSDOS]: Include "msdos.h".
595 596 597 598
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

599
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
600

601 602 603 604 605
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

606 607 608 609
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

610 611 612 613 614 615 616 617 618 619 620 621
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

622
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
623

624
	Fix some minor problems found by GCC 4.5.2's static checks.
625

626 627 628
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
629

630 631 632 633 634
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

635
	* fontset.c (free_realized_fontset): Now static.
636
	(Fset_fontset_font): Rename local to avoid shadowing.
637
	(fontset_font): Mark local as initialized.
638
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
639

640 641
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

642
	* xselect.c (x_disown_buffer_selections): Remove; not used.
643
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
644 645 646
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
647

648 649 650
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
651 652 653 654
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
655
	(Fx_create_frame): Add braces to silence GCC warning.
656
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
657 658
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
659 660 661 662
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
663

664 665
	* xterm.h (x_mouse_leave): New decl.

666 667
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
668 669
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
670
	(XTread_socket): Don't define label "out" unless it's used.
671
	Don't declare local "event" unless it's used.
672 673
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
674 675
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
676 677 678 679 680
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
681
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
682
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
683

684 685
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
686
	(tty_defined_color, merge_face_heights): Now static.
687
	(free_realized_faces_for_fontset): Remove; not used.
688 689
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
690 691
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
692

693
	* terminal.c (store_terminal_param): Now static.
694

695
	* xmenu.c (menu_highlight_callback): Now static.
696
	(set_frame_menubar): Remove unused local.
697
	(xmenu_show): Rename parameter to avoid shadowing.
698 699
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
700 701
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
702

703
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
704
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
705 706
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
707
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
708 709
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
710

Paul Eggert's avatar
Paul Eggert committed
711 712
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

713
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
714 715
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
716

717
	* window.c (display_buffer): Now static.
718 719
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
720 721
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
722
	* dispextern.h (bidi_dump_cached_states): Likewise.
723

724 725 726
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
727 728 729
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
730 731
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
732
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
733

734 735 736
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
737 738 739 740 741 742 743 744 745
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
746 747
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
748
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
749
	(decode_coding_object, encode_coding_object, detect_coding_system):
750 751
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
752 753
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
754
	this initialization is needed.  (Bug#8211)
755 756 757 758 759
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
760

761
	* category.c (hash_get_category_set): Remove unused local var.
762
	(copy_category_table): Now static, since it's not used elsewhere.
763
	* character.c (string_count_byte8): Likewise.
764

765 766 767
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

768 769
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
770 771
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
772
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
773

774
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
775
	(BIDI_BOB): Remove unused macro.
776

777 778
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
779
	* term.c (encode_terminal_code): Likewise.
780

781
	* term.c (encode_terminal_code): Now static.  Remove unused local.
782

Paul Eggert's avatar
Paul Eggert committed
783 784 785 786 787 788 789 790 791 792 793
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

794 795 796 797 798 799 800 801 802
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

803 804
	* term.c (term_mouse_position): Rename local to avoid shadowing.

805 806 807
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

808 809 810 811
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

812 813 814 815 816 817
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

870 871 872 873 874
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
875 876 877 878 879 880 881
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
882
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
883

884 885 886 887 888 889
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

890 891 892 893 894
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

895 896
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

897 898 899
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

924 925 926 927 928
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

929
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
930
	* xdisp.c (redisplay_window): Likewise.
931

932 933 934 935 936 937 938 939
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
940
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
941 942
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
943
	(update_window_cursor): Now static, since it's not used elsewhere.
944
	(SKIP_GLYPHS): Removed unused macro.
945

946 947 948 949
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

950 951 952 953
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
954
2011-03-02  Ken Brown  <kbrown@cornell.edu>
955 956 957

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

958 959 960 961 962 963 964 965 966 967 968 969 970
2011-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	Work around some portability problems with symlinks.

	* fileio.c (Fmake_symbolic_link): Treat ENOSYS specially, and
	generate a special message for it.  Suggested by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00995.html>.
	(Frename_file, Fmake_symbolic_link, Ffile_symlink_p):
	Simplify the code by assuming that the readlink and symlink calls
	exist, even if they always fail on this host.
	(Ffile_readable_p): Likewise, for fifos.
	* config.in: Regenerate.

971 972 973 974 975 976
2011-02-27  Chong Yidong  <cyd@stupidchicken.com>

	* frame.c (store_frame_param): Don't store value directly in
	buffer_list and buried_buffer_list; copy the list and remove dead
	buffers (Bug#7898).

977 978
2011-02-27  Eli Zaretskii  <eliz@gnu.org>

979 980
	* msdos.c (readlink) [DJGPP < 2.04]: New stub function.

Juanma Barranquero's avatar
Juanma Barranquero committed
981
	* msdos.h (readlink) [DJGPP < 2.04]: Declare prototype.
982

983 984
	* w32.c (symlink, readlink): New stub functions.

985 986
2011-02-27  Paul Eggert  <eggert@cs.ucla.edu>

987 988 989
	* scroll.c (CHECK_BOUNDS): #define only if GLYPH_DEBUG.
	This avoids a gcc warning in some configurations.

990 991
	* frame.c (x_set_screen_gamma): Rename local to avoid shadowing.

992 993 994 995
	* frame.h: Avoid gcc -Wmissing-prototypes diagnostics.
	(set_menu_bar_lines, x_get_resource_string): New decls.
	* msdos.c (set_menu_bar_lines): Omit decl.

996 997 998 999 1000
	* dispextern.h (struct glyph): Make u.img_id int, not unsigned.
	It's always given int values and used as an int.  This suppresses
	a gcc "comparison of unsigned expression >= 0" warning in some
	configurations.

1001 1002 1003
	* dispnew.c: Rename locals to avoid shadowing.
	(update_text_area, scrolling_window, update_frame_1): Rename locals.

1004 1005 1006 1007 1008 1009 1010 1011 1012 1013
2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c: Fix problems uncovered by gcc -Wstrict-prototypes.
	(copy_glyph_row_contents): Remove; not used.
	(frame_row_to_window, check_current_matrix_flags):
	(window_change_signal): Now static, since they're not used elsewhere.
	(check_current_matrix_flags): Surround with "#if 0", since its
	only use is in a comment.  Maybe both the comment and the "#if 0"
	stuff should be removed?

1014 1015