ChangeLog 224 KB
Newer Older
1 2 3 4 5
2011-07-14  Martin Rudalics  <rudalics@gmx.at>

	* indent.c (Fvertical_motion): Set and restore w->pointm when
	saving and restoring the window's buffer (Bug#9006).

6 7 8 9 10
2011-07-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* editfns.c (Fstring_to_char): Clarify just what is returned
	(bug#6576).  Text by Eli Zaretskii.

11 12 13 14
2011-07-13  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).

15 16 17 18
2011-07-13  Eli Zaretskii  <eliz@gnu.org>

	* buffer.c (mmap_find): Fix a typo.

19 20 21 22 23 24 25 26 27 28 29 30
2011-07-13  Johan Bockgård  <bojohan@gnu.org>

	Fix execution of x selection hooks.
	* xselect.c (Qx_lost_selection_functions)
	(Qx_sent_selection_functions): New vars.
	(syms_of_xselect): DEFSYM them.
	(x_handle_selection_request): Pass Qx_sent_selection_functions
	rather than Vx_sent_selection_functions to Frun_hook_with_args.
	(x_handle_selection_clear,x_clear_frame_selections):
	Pass Qx_lost_selection_functions rather than
	Vx_lost_selection_functions to Frun_hook_with_args.

31 32
2011-07-13  Paul Eggert  <eggert@cs.ucla.edu>

33
	* buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
34 35
	The old code sometimes used this field without initializing it.

36 37 38 39
	* alloc.c (gc_sweep): Don't read past end of array.
	In theory, the old code could also have corrupted Emacs internals,
	though it'd be very unlikely.

40 41 42
2011-07-12  Andreas Schwab  <schwab@linux-m68k.org>

	* character.c (Fcharacterp): Don't advertise optional ignored
43
	argument.  (Bug#4026)
44

Lars Magne Ingebrigtsen's avatar
Lars Magne Ingebrigtsen committed
45 46
2011-07-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

47 48 49
	* keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
	key" (bug#4257).

Lars Magne Ingebrigtsen's avatar
Lars Magne Ingebrigtsen committed
50 51 52
	* window.c (Fset_window_start): Doc fix (bug#4199).
	(Fset_window_hscroll): Ditto.

53 54
2011-07-12  Paul Eggert  <eggert@cs.ucla.edu>

55
	Fix minor new problems caught by GCC 4.6.1.
56
	* term.c (init_tty): Remove unused local.
57
	* xsettings.c (store_monospaced_changed): Define this function only
58
	if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
59
	not used otherwise.
60

61 62 63 64
2011-07-12  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).

65 66
2011-07-11  Lars Magne Ingebrigtsen  <larsi@gnus.org>

67 68 69
	* xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
	are the mini-buffer and the echo area (bug#3320).

70 71 72
	* term.c (init_tty): Remove support for supdup, c10 and perq
	terminals, which are no longer supported (bug#1482).

73 74 75 76
2011-07-10  Johan Bockgård  <bojohan@gnu.org>

	* xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.

77 78 79 80 81
2011-07-10  Jan Djärv  <jan.h.d@swipnet.se>

	* xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
	for non-popups (Bug#3642).

Andreas Schwab's avatar
Andreas Schwab committed
82 83
2011-07-10  Andreas Schwab  <schwab@linux-m68k.org>

Andreas Schwab's avatar
Andreas Schwab committed
84
	* alloc.c (reset_malloc_hooks): Protoize.
Andreas Schwab's avatar
Andreas Schwab committed
85
	* buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
Andreas Schwab's avatar
Andreas Schwab committed
86 87
	(mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
	* cm.c (losecursor): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
88 89 90 91 92 93 94 95 96 97 98 99 100 101
	* data.c (fmod): Likewise.
	* dispnew.c (swap_glyphs_in_rows): Likewise.
	* emacs.c (memory_warning_signal): Likewise.
	* floatfns.c (float_error): Likewise.
	* font.c (check_gstring, check_otf_features, otf_tag_symbol)
	(otf_open, font_otf_capability, generate_otf_features)
	(font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
	Likewise.
	* image.c (pbm_read_file): Likewise.
	* indent.c (string_display_width): Likewise.
	* intervals.c (check_for_interval, search_for_interval)
	(inc_interval_count, count_intervals, root_interval)
	(adjust_intervals_for_insertion, make_new_interval): Likewise.
	* lread.c (defalias): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
102
	* ralloc.c (r_alloc_check): Likewise.
Andreas Schwab's avatar
Andreas Schwab committed
103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
	* regex.c (set_image_of_range_1, set_image_of_range)
	(regex_grow_registers): Likewise.
	* sysdep.c (strerror): Likewise.
	* termcap.c (valid_filename_p, tprint, main): Likewise.
	* tparam.c (main): Likewise.
	* unexhp9k800.c (run_time_remap, save_data_space)
	(update_file_ptrs, read_header, write_header, calculate_checksum)
	(copy_file, copy_rest, display_header): Likewise.
	* widget.c (mark_shell_size_user_specified, create_frame_gcs):
	Likewise.
	* xdisp.c (check_it): Likewise.
	* xfaces.c (register_color, unregister_color, unregister_colors):
	Likewise.
	* xfns.c (print_fontset_result): Likewise.
	* xrdb.c (member, fatal, main): Likewise.

119 120 121 122 123 124 125 126
2011-07-10  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking (Bug#9031).
	* chartab.c (char_table_set_range, map_sub_char_table):
	Remove unused locals.
	(uniprop_table): Now static.
	* composite.c (_work_char): Remove unused static var.

127 128 129 130
2011-07-09  Juanma Barranquero  <lekktu@gmail.com>

	* chartab.c (uniprop_table_uncompress): Remove unused local variable.

131 132 133 134
2011-07-09  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (qttip_cb): Remove code without function.

135 136 137 138
2011-07-09  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (pthread_sigmask): New stub.

Paul Eggert's avatar
Paul Eggert committed
139
2011-07-08  Paul Eggert  <eggert@cs.ucla.edu>
140

Paul Eggert's avatar
Paul Eggert committed
141
	Use pthread_sigmask, not sigprocmask (Bug#9010).
142 143
	sigprocmask is portable only for single-threaded applications, and
	Emacs can be multi-threaded when it uses GTK.
144 145 146 147 148 149
	* Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
	(LIBES): Use it.
	* callproc.c (Fcall_process):
	* process.c (create_process):
	* sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
	Use pthread_sigmask, not sigprocmask.
150

151 152 153 154 155 156
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
	(xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
	wrong (Bug#8591).

157 158
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
159 160 161 162
	* gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
	Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
	(xg_hide_tooltip): Fix comment.

163 164 165 166 167 168 169
	* nsterm.m (initFrameFromEmacs): Don't use ns_return_types
	in registerServicesMenuSendTypes.
	(validRequestorForSendType): Don't check ns_return_types.

	* nsfns.m (Fx_open_connection): Put NSStringPboardType into
	ns_return_type.

170 171 172 173 174
2011-07-08  Jason Rumney  <jasonr@gnu.org>

	* w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
	frame struct members of non-existent frames (Bug#6284).

175 176
2011-07-08  Jan Djärv  <jan.h.d@swipnet.se>

177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
	* nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
	variable firstTime not needed on OSX >= 10.6.
	(setPosition): setFloatValue:knobProportion: is deprecated on OSX
	>= 10.5.  Use setKnobProportion, setDoubleValue.

	* nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
	(MAC_OS_X_VERSION_10_5): Define if not defined.
	(EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
	(EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
	(EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.

	* nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
	cString and lossyCString on OSX >= 10.4

	* nsmenu.m (fillWithWidgetValue): Don't use depercated method
	sizeToFit on OSX >= 10.2.

	* nsimage.m (allocInitFromFile): Don't use deprecated method
	bestRepresentationForDevice on OSX >= 10.6.

	* nsfns.m (check_ns_display_info): Cast to long and use %ld in error
	to avoid warning.

	* emacs.c: Declare unexec_init_emacs_zone.

202 203
	* nsgui.h: Fix compiler warning about gnulib redefining verify.

204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
	* nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).

	* nsmenu.m (ns_update_menubar): Remove useless setDelegate call
	on svcsMenu (Bug#8842).

	* nsfns.m (Fx_open_connection): Remove NSStringPboardType from
	ns_return_types.
	(Fns_list_services): Just return Qnil on 10.6, code not working there.

	* nsterm.m (QUTF8_STRING): Declare.
	(initFrameFromEmacs): Call registerServicesMenuSendTypes.
	(validRequestorForSendType): Return type is (id).
	Change indexOfObjectIdenticalTo to indexOfObject.
	Check if we have local selection before returning self (Bug#8842).
	(writeSelectionToPasteboard): Put local selection into paste board
	if we have a local selection (Bug#8842).
	(syms_of_nsterm): DEFSYM QUTF8_STRING.

	* nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
	(ns_get_local_selection): Declare.

225 226
2011-07-07  Lars Magne Ingebrigtsen  <larsi@gnus.org>

227 228 229 230
	* keymap.c (describe_map_tree): Don't insert a double newline at
	the end of the buffer (bug#1169) and return whether we inserted
	something.

231 232 233
	* callint.c (Fcall_interactively): Change "reading args" to
	"providing args" to try to clarify what it does (bug#1010).

234 235 236 237 238 239 240
2011-07-07  Kenichi Handa  <handa@m17n.org>

	* composite.c (composition_compute_stop_pos): Ignore a static
	composition starting before CHARPOS (Bug#8915).

	* xdisp.c (handle_composition_prop): Likewise.

241 242 243 244 245
2011-07-07  Eli Zaretskii  <eliz@gnu.org>

	* term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
	(Bug#9015)

Kenichi Handa's avatar
Kenichi Handa committed
246
2011-07-07  Kenichi Handa  <handa@m17n.org>
247 248 249 250 251 252 253 254 255 256

	* character.h (unicode_category_t): New enum type.

	* chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
	(Qchar_code_property_table): New variable.
	(UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
	(UNIPROP_COMPRESSED_FORM_P): New macros.
	(char_table_ascii): Uncompress the compressed values.
	(sub_char_table_ref): New arg is_uniprop.  Callers changed.
	Uncompress the compressed values.
257
	(sub_char_table_ref_and_range): Likewise.
258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287
	(char_table_ref_and_range): Uncompress the compressed values.
	(sub_char_table_set): New arg is_uniprop.  Callers changed.
	Uncompress the compressed values.
	(sub_char_table_set_range): Args changed.  Callers changed.
	(char_table_set_range): Adjuted for the above change.
	(map_sub_char_table): Delete args default_val and parent.  Add arg
	top.  Give decoded values to a Lisp function.
	(map_char_table): Adjusted for the above change.  Give decoded
	values to a Lisp function.  Gcpro more variables.
	(uniprop_table_uncompress)
	(uniprop_decode_value_run_length): New functions.
	(uniprop_decoder, uniprop_decoder_count): New variables.
	(uniprop_get_decoder, uniprop_encode_value_character)
	(uniprop_encode_value_run_length, uniprop_encode_value_numeric):
	New functions.
	(uniprop_encoder, uniprop_encoder_count): New variables.
	(uniprop_get_encoder, uniprop_table)
	(Funicode_property_table_internal, Fget_unicode_property_internal)
	(Fput_unicode_property_internal): New functions.
	(syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
	Sunicode_property_table_internal, Sget_unicode_property_internal,
	and Sput_unicode_property_internal. Defvar_lisp
	char-code-property-alist.

	* composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
	Vunicode_category_table.

	* font.c (font_range): Adjusted for the change of
	Vunicode_category_table.

288 289 290 291 292
2011-07-07  Dan Nicolaescu  <dann@ics.uci.edu>

	* m/iris4d.h: Remove file, move contents ...
	* s/irix6-5.h: ... here.

293 294 295
2011-07-06  Paul Eggert  <eggert@cs.ucla.edu>

	Remove unportable assumption about struct layout (Bug#8884).
296 297 298
	* alloc.c (mark_buffer):
	* buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
	(clone_per_buffer_values): Don't assume that
299 300 301 302 303 304
	sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
	This isn't true in general, and it's particularly not true
	if Emacs is configured with --with-wide-int.
	* buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
	New macros, used in the buffer.c change.

305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336
2011-07-05  Jan Djärv  <jan.h.d@swipnet.se>

	* xsettings.c: Use both GConf and GSettings if both are available.
	(store_config_changed_event): Add comment.
	(dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
	(store_tool_bar_style_changed): New functions.
	(store_monospaced_changed): Add comment. Call dpyinfo_valid.
	(struct xsettings): Move font inside HAVE_XFT.
	(GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
	(GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
	Move inside HAVE_XFT.
	(something_changed_gsettingsCB): Renamed from something_changedCB.
	Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
	also.
	(GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
	(GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
	(something_changed_gconfCB): Renamed from something_changedCB.
	Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
	(parse_settings): Move check for font inside HAVE_XFT.
	(read_settings, apply_xft_settings): Add comment.
	(read_and_apply_settings): Add comment.  Call map_tool_bar_style and
	store_tool_bar_style_changed.  Move check for font inside HAVE_XFT and
	call store_font_name_changed.
	(xft_settings_event): Add comment.
	(init_gsettings): Add comment.  Get values for GSETTINGS_TOOL_BAR_STYLE
	and GSETTINGS_FONT_NAME.  Move check for fonts within HAVE_XFT.
	(init_gconf): Add comment.  Get values for GCONF_TOOL_BAR_STYLE
	and GCONF_FONT_NAME.  Move check for fonts within HAVE_XFT.
	(xsettings_initialize): Call init_gsettings last.
	(xsettings_get_system_font, xsettings_get_system_normal_font): Add
	comment.

337 338 339 340 341 342 343 344 345 346 347 348
2011-07-05  Paul Eggert  <eggert@cs.ucla.edu>

	Random fixes.  E.g., (random) never returned negative values.
	* fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
	subseconds part to the entropy, as that's a bit more random.
	Prefer signed to unsigned, since the signedness doesn't matter and
	in general we prefer signed.  When given a limit, use a
	denominator equal to INTMASK + 1, not to VALMASK + 1, because the
	latter isn't right if USE_2_TAGS_FOR_INTS.
	* sysdep.c (get_random): Return a value in the range 0..INTMASK,
	not 0..VALMASK.  Don't discard "excess" bits that random () returns.

349 350 351 352 353 354 355 356
2011-07-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* textprop.c (text_property_stickiness):
	Obey Vtext_property_default_nonsticky.
	(syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
	* w32fns.c (syms_of_w32fns):
	* xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.

357 358 359 360 361
2011-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
	This is more efficient than Ffile_directory_p and avoids a minor race.

362 363
2011-07-04  Lars Magne Ingebrigtsen  <larsi@gnus.org>

364 365 366
	* buffer.c (Foverlay_put): Say what the return value is
	(bug#7835).

367 368 369
	* fileio.c (barf_or_query_if_file_exists): Check first if the file
	is a directory before asking whether to use the file name
	(bug#7564).
370 371
	(barf_or_query_if_file_exists): Make the "File is a directory"
	error be more correct.
372

373 374 375 376
	* fns.c (Frequire): Remove the mention of the .gz files, since
	that's installation-specific, but keep the mention of
	`get-load-suffixes'.

377 378 379 380 381
2011-07-04  Paul Eggert  <eggert@cs.ucla.edu>

	* editfns.c (Fformat_time_string): Don't assume strlen fits in int.
	Report string overflow if the output is too long.

382 383
2011-07-04  Juanma Barranquero  <lekktu@gmail.com>

384 385 386 387 388
	* gnutls.c (Fgnutls_boot): Don't mention :verify-error.
	(syms_of_gnutls): Remove duplicate DEFSYM for
	Qgnutls_bootprop_verify_hostname_error, an error for
	Qgnutls_bootprop_verify_error (which is no longer used).

389 390 391 392
	* eval.c (find_handler_clause): Remove parameters `sig' and `data',
	unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca.  All callers changed.
	Also (re)move comments that are misplaced or no longer relevant.

393 394 395 396
2011-07-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).

397 398 399 400 401
2011-07-03  Chong Yidong  <cyd@stupidchicken.com>

	* xfaces.c (Finternal_merge_in_global_face): Modify the foreground
	and background color parameters if they have been changed.

402 403 404 405
2011-07-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).

406 407
2011-07-03  Paul Eggert  <eggert@cs.ucla.edu>

408 409 410
	* xsettings.c (SYSTEM_FONT): Define only when used.
	No need to define when HAVE_GSETTINGS || !HAVE_XFT.

411 412
	* keymap.c (access_keymap_1): Now static.

413 414 415 416 417
2011-07-02  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (command_loop_1): If a down-mouse event is unbound,
	leave any prefix arg for the up event (Bug#1586).

418 419
2011-07-02  Lars Magne Ingebrigtsen  <larsi@gnus.org>

420 421 422
	* lread.c (syms_of_lread): Mention single symbols defined by
	`defvar' or `defconst' (bug#7154).

423
	* fns.c (Frequire): Mention .el.gz files (bug#7314).
424
	(Frequire): Mention get-load-suffixes.
425

426 427 428 429 430 431 432 433 434 435 436
2011-07-02  Martin Rudalics  <rudalics@gmx.at>

	* window.h (window): Remove clone_number slot.
	* window.c (Fwindow_clone_number, Fset_window_clone_number):
	Remove.
	(make_parent_window, make_window, saved_window)
	(Fset_window_configuration, save_window_save): Don't deal with
	clone numbers.
	* buffer.c (Qclone_number): Remove declaration.
	(sort_overlays, overlay_strings): Don't deal with clone numbers.

437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457
2011-07-02  Stefan Monnier  <monnier@iro.umontreal.ca>

	Add multiple inheritance to keymaps.
	* keymap.c (Fmake_composed_keymap): New function.
	(Fset_keymap_parent): Simplify.
	(fix_submap_inheritance): Remove.
	(access_keymap_1): New function extracted from access_keymap to handle
	embedded parents and handle lists of maps.
	(access_keymap): Use it.
	(Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
	(Fcopy_keymap): Handle embedded parents.
	(Fcommand_remapping, define_as_prefix): Simplify.
	(Fkey_binding): Simplify.
	(syms_of_keymap): Move minibuffer-local-completion-map,
	minibuffer-local-filename-completion-map,
	minibuffer-local-must-match-map, and
	minibuffer-local-filename-must-match-map to Elisp.
	(syms_of_keymap): Defsubr make-composed-keymap.
	* keyboard.c (menu_bar_items): Use map_keymap_canonical.
	(parse_menu_item): Trivial simplification.

458 459 460 461
2011-07-01  Glenn Morris  <rgm@gnu.org>

	* Makefile.in (SETTINGS_LIBS): Fix typo.

462 463 464 465 466
2011-07-01  Kazuhiro Ito  <kzhr@d1.dion.ne.jp>  (tiny patch)

	* coding.c (Fencode_coding_string): Record the last coding system
	used, as the function doc string says (bug#8738).

467 468 469 470 471 472 473 474 475 476 477 478 479
2011-07-01  Jan Djärv  <jan.h.d@swipnet.se>

	* xsettings.c (store_monospaced_changed): Take new font as arg and
	check for change against current_mono_font.
	(EMACS_TYPE_SETTINGS): Remove this and related defines.
	(emacs_settings_constructor, emacs_settings_get_property)
	(emacs_settings_set_property, emacs_settings_class_init)
	(emacs_settings_init, gsettings_obj): Remove.
	(something_changedCB): New function for HAVE_GSETTINGS.
	(something_changedCB): HAVE_GCONF: Call store_monospaced_changed
	with value as argument.
	(init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
	g_settings_new (Bug#8967).  Do not create gsettings_obj.
Juanma Barranquero's avatar
Juanma Barranquero committed
480
	Remove calls to g_settings_bind.  Connect something_changedCB to
481 482 483 484 485 486 487 488 489
	"changed".

	* xgselect.c: Add defined (HAVE_GSETTINGS).
	(xgselect_initialize): Ditto.

	* process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
	(wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
	xg_select.

490 491 492 493 494 495 496 497 498 499
2011-07-01  Paul Eggert  <eggert@cs.ucla.edu>

	* eval.c (struct backtrace): Simplify and port the data structure.
	Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
	signed bit field, as this assumption is not portable and it makes
	Emacs crash when compiled with Sun C 5.8 on sparc.  Do not use
	"char debug_on_exit : 1" as this is not portable either; instead,
	use the portable "unsigned int debug_on_exit : 1".  Remove unused
	member evalargs.  Remove obsolete comments about cc bombing out.

500 501
2011-06-30  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
502
	* xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520
	Let HAVE_GSETTINGS override HAVE_GCONF.
	(store_monospaced_changed): New function.
	(EMACS_SETTINGS): A new type derived from GObject to handle
	GSettings notifications.
	(emacs_settings_constructor, emacs_settings_get_property)
	(emacs_settings_set_property, emacs_settings_class_init):
	New functions.
	(gsettings_client, gsettings_obj): New variables.
	(GSETTINGS_SCHEMA): New define.
	(something_changedCB): Call store_monospaced_changed.
	(init_gsettings): New function.
	(xsettings_initialize): Call init_gsettings.
	(syms_of_xsettings): Initialize gsettings_client, gsettings_obj
	to NULL.

	* Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
	GCONF_CFLAGS/LIBS.

521 522 523 524 525 526 527
2011-06-29  Martin Rudalics  <rudalics@gmx.at>

	* window.c (resize_root_window, grow_mini_window)
	(shrink_mini_window): Rename Qresize_root_window to
	Qwindow_resize_root_window and Qresize_root_window_vertically to
	Qwindow_resize_root_window_vertically.

528 529 530 531
2011-06-28  Paul Eggert  <eggert@cs.ucla.edu>

	* gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.

532 533 534 535 536 537
2011-06-27  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Redesign dependencies so they reflect more
	clearly which files are directly included by each source file,
	and not through other includes.

538 539 540 541 542 543 544
2011-06-27  Martin Rudalics  <rudalics@gmx.at>

	* buffer.c (Qclone_number): Declare static and DEFSYM it.
	(sort_overlays, overlay_strings): When an overlay's clone number
	matches the window's clone number process the overlay even if
	the overlay's window property doesn't match the current window.

545 546 547 548
	* window.c (Fwindow_vchild): Rename to Fwindow_top_child.
	(Fwindow_hchild): Rename to Fwindow_left_child.
	(Fwindow_next): Rename to Fwindow_next_sibling.
	(Fwindow_prev): Rename to Fwindow_prev_sibling.
549 550 551 552 553 554 555
	(resize_window_check): Rename to window_resize_check.
	(resize_window_apply): Rename to window_resize_apply.
	(Fresize_window_apply): Rename to Fwindow_resize_apply.
	(Fdelete_other_windows_internal, resize_frame_windows)
	(Fsplit_window_internal, Fdelete_window_internal)
	(grow_mini_window, shrink_mini_window)
	(Fresize_mini_window_internal): Fix callers accordingly.
556

557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576
2011-06-26  Jan Djärv  <jan.h.d@swipnet.se>

	* emacsgtkfixed.h: State that this is only used with Gtk+3.
	(emacs_fixed_set_min_size): Remove.
	(emacs_fixed_new): Take frame as argument.

	* emacsgtkfixed.c: State that this is only used with Gtk+3.
	(_EmacsFixedPrivate): Remove minwidth/height.
	Add struct frame *f.
	(emacs_fixed_init): Initialize priv->f.
	(get_parent_class, emacs_fixed_set_min_size): Remove.
	(emacs_fixed_new): Set priv->f to argument.
	(emacs_fixed_get_preferred_width)
	(emacs_fixed_get_preferred_height): Use min_width/height from
	frames size_hint to set minimum and natural (Bug#8919).
	(XSetWMSizeHints, XSetWMNormalHints): Override these functions
	and use min_width/height from frames size_hint to set
	min_width/height (Bug#8919).

	* gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
Juanma Barranquero's avatar
Juanma Barranquero committed
577 578
	(x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
	Fix indentation.
579

580 581 582 583 584 585
2011-06-26  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
	bidi_at_paragraph_end, since fast_looking_at doesn't like to be
	called at ZV.

586 587 588 589 590 591
2011-06-26  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (wait_reading_process_output): Bypass select if
	waiting for a cell while ignoring keyboard input, and input is
	pending.  Suggested by Jan Djärv (Bug#8869).

592 593 594 595 596
2011-06-25  Paul Eggert  <eggert@cs.ucla.edu>

	Use gnulib's dup2 module instead of rolling our own.
	* sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.

597
2011-06-25  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
598 599 600 601

	* dispnew.c (scrolling_window): Before scrolling, turn off a
	mouse-highlight in the window being scrolled.

602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
2011-06-24  Juanma Barranquero  <lekktu@gmail.com>

	Move DEFSYM to lisp.h and use everywhere.

	* character.h (DEFSYM): Move declaration...
	* lisp.h (DEFSYM): ...here.

	* gnutls.c:
	* minibuf.c:
	* w32menu.c:
	* w32proc.c:
	* w32select.c: Don't include character.h.

	* alloc.c (syms_of_alloc):
	* buffer.c (syms_of_buffer):
	* bytecode.c (syms_of_bytecode):
	* callint.c (syms_of_callint):
	* casefiddle.c (syms_of_casefiddle):
	* casetab.c (init_casetab_once):
	* category.c (init_category_once, syms_of_category):
	* ccl.c (syms_of_ccl):
	* cmds.c (syms_of_cmds):
	* composite.c (syms_of_composite):
	* dbusbind.c (syms_of_dbusbind):
	* dired.c (syms_of_dired):
	* dispnew.c (syms_of_display):
	* doc.c (syms_of_doc):
	* editfns.c (syms_of_editfns):
	* emacs.c (syms_of_emacs):
	* eval.c (syms_of_eval):
	* fileio.c (syms_of_fileio):
	* fns.c (syms_of_fns):
	* frame.c (syms_of_frame):
	* fringe.c (syms_of_fringe):
	* insdel.c (syms_of_insdel):
	* keymap.c (syms_of_keymap):
	* lread.c (init_obarray, syms_of_lread):
	* macros.c (syms_of_macros):
	* msdos.c (syms_of_msdos):
	* print.c (syms_of_print):
	* process.c (syms_of_process):
	* search.c (syms_of_search):
	* sound.c (syms_of_sound):
	* syntax.c (init_syntax_once, syms_of_syntax):
	* terminal.c (syms_of_terminal):
	* textprop.c (syms_of_textprop):
	* undo.c (syms_of_undo):
	* w32.c (globals_of_w32):
	* window.c (syms_of_window):
	* xdisp.c (syms_of_xdisp):
	* xfaces.c (syms_of_xfaces):
	* xfns.c (syms_of_xfns):
	* xmenu.c (syms_of_xmenu):
	* xsettings.c (syms_of_xsettings):
	* xterm.c (syms_of_xterm): Use DEFSYM.

658 659
2011-06-24  Teodor Zlatanov  <tzz@lifelogs.com>

660
	* gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
661

662 663
2011-06-23  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
664 665
	Integer and buffer overflow fixes (Bug#8873).

666 667 668 669
	* print.c (printchar, strout): Check for string overflow.
	(PRINTPREPARE, printchar, strout):
	Don't set size unless allocation succeeds.

670 671 672 673
	* minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
	for sizes.  Check for string overflow more accurately.
	Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.

674 675 676 677 678 679 680 681
	* macros.c: Integer and buffer overflow fixes.
	* keyboard.h (struct keyboard.kbd_macro_bufsize):
	* macros.c (Fstart_kbd_macro, store_kbd_macro_char):
	Use ptrdiff_t, not int, for sizes.
	Don't increment bufsize until after realloc succeeds.
	Check for size-calculation overflow.
	(Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.

682 683
	* lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.

684 685 686 687 688 689
	* lread.c: Integer overflow fixes.
	(read_integer): Radix is now EMACS_INT, not int,
	to improve quality of diagnostics for out-of-range radices.
	Calculate buffer size correctly for out-of-range radices.
	(read1): Check for integer overflow in radices, and in
	read-circle numbers.
690 691 692 693 694
	(read_escape): Avoid int overflow.
	(Fload, openp, read_buffer_size, read1)
	(substitute_object_recurse, read_vector, read_list, map_obarray):
	Use ptrdiff_t, not int, for sizes.
	(read1): Use EMACS_INT, not int, for sizes.
695
	Check for size overflow.
696

697 698
	* image.c (cache_image): Check for size arithmetic overflow.

699 700 701 702 703 704 705
	* lread.c: Integer overflow issues.
	(saved_doc_string_size, saved_doc_string_length)
	(prev_saved_doc_string_size, prev_saved_doc_string_length):
	Now ptrdiff_t, not int.
	(read1): Don't assume doc string length fits in int.  Check for
	out-of-range doc string lengths.
	(read_list): Don't assume file position fits in int.
706
	(read_escape): Check for hex character overflow.
707

708 709 710 711 712
2011-06-22  Leo Liu  <sdl.web@gmail.com>

	* minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
	Move to minibuffer.el.

Paul Eggert's avatar
Paul Eggert committed
713 714
2011-06-22  Paul Eggert  <eggert@cs.ucla.edu>

715
	Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
Paul Eggert's avatar
Paul Eggert committed
716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740
	The following patches are for when GLYPH_DEBUG && !XASSERT.
	* dispextern.h (trace_redisplay_p, dump_glyph_string):
	* dispnew.c (flush_stdout):
	* xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
	Mark as externally visible.
	* dispnew.c (check_window_matrix_pointers): Now static.
	* dispnew.c (window_to_frame_vpos):
	* xfns.c (unwind_create_frame):
	* xterm.c (x_check_font): Remove unused local.
	* scroll.c (CHECK_BOUNDS):
	* xfaces.c (cache_fache): Rename local to avoid shadowing.
	* xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
	* xdisp.c (check_window_end): Now a no-op if !XASSERTS.
	(debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
	(debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
	Now static.
	(debug_method_add): Use va_list and vsprintf rather than relying
	on undefined behavior with wrong number of arguments.
	(dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
	Don't assume ptrdiff_t and EMACS_INT are the same width as int.
	In this code, it's OK to assume C99 behavior for ptrdiff_t formats
	since we're not interested in debugging glyphs with old libraries.
	* xfaces.c (cache_face): Move debugging code earlier; this pacifies
	GCC 4.6.0's static checking.

741 742
2011-06-22  Paul Eggert  <eggert@cs.ucla.edu>

743 744 745
	Integer overflow and signedness fixes (Bug#8873).
	A few related buffer overrun fixes, too.

746 747
	* font.c (font_score): Use EMACS_INT, not int, to store XINT value.

748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764
	* dispextern.h (struct face.stipple):
	* image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
	(x_bitmap_mask, x_allocate_bitmap_record)
	(x_create_bitmap_from_data, x_create_bitmap_from_file)
	(x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
	(x_create_bitmap_from_xpm_data):
	* nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
	* w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
	(.bitmaps_last):
	* xfaces.c (load_pixmap):
	* xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
	* xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
	(.bitmaps_last, struct x_output.icon_bitmap):
	Use ptrdiff_t, not int, for bitmap indexes.
	(x_allocate_bitmap_record): Check for size overflow.
	* dispextern.h, lisp.h: Adjust to API changes elsewhere.

765 766 767 768 769 770
	Use ptrdiff_t, not int, for overlay counts.
	* buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
	* editfns.c (overlays_around, get_pos_property):
	* textprop.c (get_char_property_and_overlay):
	* xdisp.c (next_overlay_change, note_mouse_highlight):
	* xfaces.c (face_at_buffer_position):
771 772 773 774
	* buffer.c (OVERLAY_COUNT_MAX): New macro.
	(overlays_at, overlays_in, sort_overlays, Foverlays_at)
	(Fnext_overlay_change, Fprevious_overlay_change)
	(mouse_face_overlay_overlaps, Foverlays_in):
775
	Use ptrdiff_t, not int, for sizes.
776
	(overlays_at, overlays_in): Check for size-calculation overflow.
777

778 779
	* xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.

780 781 782
	* xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
	(x_session_initialize): Do not assume string length fits in int.

783 784 785
	* xsettings.c (apply_xft_settings): Fix potential buffer overrun.
	This is unlikely, but can occur if DPI is outlandish.

786
	* xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
787 788
	* xselect.c (Fx_get_atom_name): Avoid need for strlen.

789 790 791 792 793
	* xrdb.c: Don't assume strlen fits in int; avoid some strlens.
	* xrdb.c (magic_file_p, search_magic_path):
	Omit last arg SUFFIX; it was always 0.  All callers changed.
	(magic_file_p): Use ptrdiff_t, not int.  Check for size overflow.

794 795
	* xfont.c (xfont_match): Avoid need for strlen.

796 797 798
	* xfns.c: Don't assume strlen fits in int.
	(xic_create_fontsetname, x_window): Use ptrdiff_t, not int.

799 800 801 802
	* xdisp.c (message_log_check_duplicate): Return intmax_t,
	not unsigned long, as we prefer signed integers.  All callers changed.
	Detect integer overflow in repeat count.
	(message_dolog): Don't assume print length fits in 39 bytes.
803
	(display_mode_element): Don't assume strlen fits in int.
804

805 806 807 808
	* termcap.c: Don't assume sizes fit in int and never overflow.
	(struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
	(gobble_line): Check for size-calculation overflow.

809
	* minibuf.c (Fread_buffer):
810
	* lread.c (intern, intern_c_string):
811 812 813
	* image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
	Don't assume string length fits in int.

814
	* keyboard.c (parse_tool_bar_item):
815 816
	* gtkutil.c (style_changed_cb): Avoid need for strlen.

817 818 819
	* font.c: Don't assume string length fits in int.
	(font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
	Use ptrdiff_t, not int.
820 821 822
	(font_intern_prop): Don't assume string length fits in int.
	Don't assume integer property fits in fixnum.
	* font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
823

824
	* filelock.c: Fix some buffer overrun and integer overflow issues.
Paul Eggert's avatar
Paul Eggert committed
825
	(get_boot_time): Don't assume gzip command string fits in 100 bytes.
826 827 828 829 830 831 832 833 834 835 836
	Reformulate so as not to need the command string.
	Invoke gzip -cd rather than gunzip, as it's more portable.
	(lock_info_type, lock_file_1, lock_file):
	Don't assume pid_t and time_t fit in unsigned long.
	(LOCK_PID_MAX): Remove; we now use more-reliable bounds.
	(current_lock_owner): Prefer signed type for sizes.
	Use memcpy, not strncpy, where memcpy is what is really wanted.
	Don't assume (via atoi) that time_t and pid_t fit in int.
	Check for time_t and/or pid_t out of range, e.g., via a network share.
	Don't alloca where an auto var works fine.

837 838 839 840 841 842 843
	* fileio.c: Fix some integer overflow issues.
	(file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
	Don't assume string length fits in int.
	(directory_file_name): Don't assume string length fits in long.
	(make_temp_name): Don't assume pid fits in int, or that its print
	length is less than 20.

844 845
	* data.c (Fsubr_name): Rewrite to avoid a strlen call.

846 847
	* coding.c (make_subsidiaries): Don't assume string length fits in int.

848 849
	* callproc.c (child_setup): Rewrite to avoid two strlen calls.

850 851 852
	* process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
	We prefer signed integers, even for size calculations.

853 854 855 856
	* emacs.c: Don't assume string length fits in 'int'.
	(DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
	(main): Don't invoke strlen when not needed.

857 858 859
	* dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
	(XD_DEBUG_MESSAGE): Don't waste a byte.

860 861
	* callproc.c (getenv_internal_1, getenv_internal)
	(Fgetenv_internal):
862 863
	* buffer.c (init_buffer): Don't assume string length fits in 'int'.

864 865 866 867
	* lread.c (invalid_syntax): Omit length argument.
	All uses changed.  This doesn't fix a bug, but it simplifies the
	code away from its former Hollerith-constant appearance, and it's
	one less 'int' to worry about when looking at integer-overflow issues.
Paul Eggert's avatar
Paul Eggert committed
868
	(string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
869

870 871 872 873
	* lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
	This didn't break anything, but it didn't help either.
	It's confusing to put a bogus integer in a place where the actual
	value does not matter.
874
	(LIST_END_P): Remove unused macro and its bogus comment.
875
	(make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
876

877 878 879
	* lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
	This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
	implementation.
880 881 882
	(struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
	We prefer signed types, and the value cannot exceed the EMACS_INT
	range anyway (because otherwise the length would not be representable).
883 884 885
	(XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
	not EMACS_UINT and EMACS_INT, when converting pointer to integer.
	This avoids a GCC warning when WIDE_EMACS_INT.
886

887 888 889
	* indent.c (sane_tab_width): New function.
	(current_column, scan_for_column, Findent_to, position_indentation)
	(compute_motion): Use it.  This is just for clarity.
890
	(Fcompute_motion): Don't assume hscroll and tab offset fit in int.
891

Paul Eggert's avatar
Paul Eggert committed
892
	* image.c (xbm_image_p): Don't assume stated width, height fit in int.
893

894 895 896 897
	* lisp.h (lint_assume): New macro.
	* composite.c (composition_gstring_put_cache):
	* ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.

898 899
	* editfns.c, insdel.c:
	Omit unnecessary forward decls, to simplify future changes.
900

901 902
	* ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.

903 904
	* font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.

905
	* fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
906
	Use much-faster test for byte-length change.
907
	Don't assume string byte-length fits in 'int'.
908
	Check that character arg fits in 'int'.
909
	(mapcar1): Declare byte as byte, for clarity.
910

911 912
	* alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.

913 914 915
	* fns.c (concat): Catch string overflow earlier.
	Do not rely on integer wraparound.

Paul Eggert's avatar
Paul Eggert committed
916 917
	* dispextern.h (struct it.overlay_strings_charpos)
	(struct it.selective): Now EMACS_INT, not int.
918 919 920 921 922
	* xdisp.c (forward_to_next_line_start)
	(back_to_previous_visible_line_start)
	(reseat_at_next_visible_line_start, next_element_from_buffer):
	Don't arbitrarily truncate the value of 'selective' to int.

923 924
	* xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.

925 926 927
	* composite.c: Don't truncate sizes to 'int'.
	(composition_gstring_p, composition_reseat_it)
	(composition_adjust_point): Use EMACS_INT, not int.
928 929
	(get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
	not EMACS_UINT, for indexes.
930

931 932
	* category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.

Paul Eggert's avatar
Paul Eggert committed
933 934
	* buffer.c: Include <verify.h>.
	(struct sortvec.priority, struct sortstr.priority):
935
	Now EMACS_INT, not int.
936
	(compare_overlays, cmp_for_strings): Avoid subtraction overflow.
937 938 939 940
	(struct sortstr.size, record_overlay_string)
	(struct sortstrlist.size, struct sortlist.used):
	Don't truncate size to int.
	(record_overlay_string): Check for size-calculation overflow.
Paul Eggert's avatar
Paul Eggert committed
941
	(init_buffer_once): Check at compile-time, not run-time.
942

943 944
2011-06-22  Jim Meyering  <meyering@redhat.com>

945
	Don't leak an XBM-image-sized buffer
946 947
	* image.c (xbm_load): Free the image buffer after using it.

Paul Eggert's avatar
Paul Eggert committed
948 949 950 951 952 953 954 955 956
2011-06-21  Paul Eggert  <eggert@cs.ucla.edu>

	Port to Sun C.
	* composite.c (find_automatic_composition): Omit needless 'return 0;'
	that Sun C diagnosed.
	* fns.c (secure_hash): Fix pointer signedness issue.
	* intervals.c (static_offset_intervals): New function.
	(offset_intervals): Use it.

957 958 959 960 961 962 963 964
2011-06-21  Leo Liu  <sdl.web@gmail.com>

	* deps.mk (fns.o):
	* makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
	sha512.h.

	* fns.c (secure_hash): Rename from crypto_hash_function and change
	the first arg to accept symbols.
Glenn Morris's avatar
Glenn Morris committed
965
	(Fsecure_hash): New primitive.
966 967
	(syms_of_fns): New symbols.

968 969 970 971 972
2011-06-20  Deniz Dogan  <deniz@dogan.se>

	* process.c (Fset_process_buffer): Clarify return value in
	docstring.

Chong Yidong's avatar
Chong Yidong committed
973 974 975 976 977 978 979 980 981 982 983 984 985 986
2011-06-18  Chong Yidong  <cyd@stupidchicken.com>

	* dispnew.c (add_window_display_history): Use BVAR.

	* xdisp.c (debug_method_add): Use BVAR.
	(check_window_end, dump_glyph_matrix, dump_glyph)
	(dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.

	* xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
	Likewise.

	* xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
	check till after the cache is created in init_frame_faces.

987 988 989 990
2011-06-17  Stefan Monnier  <monnier@iro.umontreal.ca>

	* fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.

991 992
2011-06-16  Paul Eggert  <eggert@cs.ucla.edu>

993 994 995 996
	* lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
	Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
	hosts with pre-C99 libraries, because pD is wrongly defined to "t".

997
	Improve buffer-overflow checking (Bug#8873).
998 999 1000 1001 1002 1003 1004 1005 1006
	* fileio.c (Finsert_file_contents):
	* insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
	Remove the old (too-loose) buffer overflow checks.
	They weren't needed, since make_gap checks for buffer overflow.
	* insdel.c (make_gap_larger): Catch buffer overflows that were missed.
	The old code merely checked for Emacs fixnum overflow, and relied
	on undefined (wraparound) behavior.  The new code avoids undefined
	behavior, and also checks for ptrdiff_t and/or size_t overflow.

1007
	* editfns.c (Finsert_char): Don't dump core with very negative counts.
1008 1009
	Tune.  Don't use wider integers than needed.  Don't use alloca.
	Use a bigger 'string' buffer.  Rewrite to avoid 'n > 0' test.
1010

1011 1012
	* insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.

1013 1014 1015 1016 1017 1018
	* insdel.c, lisp.h (buffer_overflow): New function.
	(insert_from_buffer_1, replace_range, replace_range_2):
	* insdel.c (make_gap_larger):
	* editfns.c (Finsert_char):
	* fileio.c (Finsert_file_contents): Use it, to normalize wording.

1019 1020
	* buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.

1021 1022
2011-06-15  Paul Eggert  <eggert@cs.ucla.edu>

1023
	Integer overflow and signedness fixes (Bug#8873).
Paul Eggert's avatar
Paul Eggert committed
1024

1025 1026 1027
	* ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
	(GET_CCL_RANGE, IN_INT_RANGE): Use it.

1028 1029 1030 1031 1032
	* fileio.c: Don't assume EMACS_INT fits in off_t.
	(emacs_lseek): New static function.
	(Finsert_file_contents, Fwrite_region): Use it.
	Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.

1033 1034
	* fns.c (Fload_average): Don't assume 100 * load average fits in int.

1035 1036 1037 1038 1039 1040 1041 1042 1043
	* fns.c: Don't overflow int when computing a list length.
	* fns.c (QUIT_COUNT_HEURISTIC): New constant.
	(Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
	truncation on 64-bit hosts.  Check for QUIT every
	QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
	faster and is responsive enough.
	(Flength): Report an error instead of overflowing an integer.
	(Fsafe_length): Return a float if the value is not representable
	as a fixnum.  This shouldn't happen except in contrived situations.
1044
	(Fnthcdr, Fsort): Don't assume list length fits in int.
1045
	(Fcopy_sequence): Don't assume vector length fits in int.
1046

1047 1048 1049 1050 1051 1052 1053
	* alloc.c: Check that resized vectors' lengths fit in fixnums.
	(header_size, word_size): New constants.
	(allocate_vectorlike): Don't check size overflow here.
	(allocate_vector): Check it here instead, since this is the only
	caller of allocate_vectorlike that could cause overflow.
	Check that the new vector's length is representable as a fixnum.

1054 1055 1056 1057 1058 1059
	* fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
	The previous code was bogus.  For example, next_almost_prime (32)
	returned 39, which is undesirable as it is a multiple of 3; and
	next_almost_prime (24) returned 25, which is a multiple of 5 so
	why was the code bothering to check for multiples of 7?

1060 1061
	* bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.

1062 1063
	* eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.

1064 1065 1066 1067
	Variadic C functions now count arguments with ptrdiff_t.
	This partly undoes my 2011-03-30 change, which replaced int with size_t.
	Back then I didn't know that the Emacs coding style prefers signed int.
	Also, in the meantime I found a few more instances where arguments
1068 1069
	were being counted with int, which may truncate counts on 64-bit
	machines, or EMACS_INT, which may be unnecessarily wide.
1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
	* lisp.h (struct Lisp_Subr.function.aMANY)
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
	Arg counts are now ptrdiff_t, not size_t.
	All variadic functions and their callers changed accordingly.
	(struct gcpro.nvars): Now size_t, not size_t.  All uses changed.
	* bytecode.c (exec_byte_code): Check maxdepth for overflow,
	to avoid potential buffer overrun.  Don't assume arg counts fit in 'int'.
	* callint.c (Fcall_interactively): Check arg count for overflow,
	to avoid potential buffer overrun.  Use signed char, not 'int',
	for 'varies' array, so that we needn't bother to check its size
	calculation for overflow.
	* editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
	* eval.c (apply_lambda):
	* fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
	(struct textprop_rec.argnum): Now ptrdiff_t, not int.  All uses changed.
	(mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.

1087 1088
	* callint.c (Fcall_interactively): Don't use index var as event count.

1089 1090 1091
	* vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
	* mem-limits.h (SIZE): Remove; no longer used.

1092
	* xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1093

Paul Eggert's avatar
Paul Eggert committed
1094 1095 1096 1097 1098 1099
	Remove unnecessary casts.
	* xterm.c (x_term_init):
	* xfns.c (x_set_border_pixel):
	* widget.c (create_frame_gcs): Remove casts to unsigned long etc.
	These aren't needed now that we assume ANSI C.

1100 1101 1102 1103
	* sound.c (Fplay_sound_internal): Remove cast to unsigned long.
	It's more likely to cause problems (due to unsigned overflow)
	than to cure them.

1104 1105
	* dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.

1106 1107
	* unexelf.c (unexec): Don't assume BSS addr fits in unsigned.

1108 1109
	* xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.

1110 1111
	* keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.

1112 1113
	* lisp.h (CHAR_TABLE_SET): Omit now-redundant test.

1114 1115
	* lread.c (Fload): Don't compare a possibly-garbage time_t value.

1116 1117 1118
	GLYPH_CODE_FACE returns EMACS_INT, not int.
	* dispextern.h (merge_faces):
	* xfaces.c (merge_faces):
Paul Eggert's avatar
Paul Eggert committed
1119 1120
	* xdisp.c (get_next_display_element, next_element_from_display_vector):
	Don't assume EMACS_INT fits in int.
1121

1122 1123 1124
	* character.h (CHAR_VALID_P): Remove unused parameter.
	* fontset.c, lisp.h, xdisp.c: All uses changed.

1125 1126
	* editfns.c (Ftranslate_region_internal): Omit redundant test.

1127 1128 1129 1130 1131 1132
	* fns.c (concat): Minor tuning based on overflow analysis.
	This doesn't fix any bugs.  Use int to hold character, instead
	of constantly refetching from Emacs object.  Use XFASTINT, not
	XINT, for value known to be a character.  Don't bother comparing
	a single byte to 0400, as it's always less.

1133
	* floatfns.c (Fexpt):
1134 1135
	* fileio.c (make_temp_name): Omit unnecessary cast to unsigned.

1136 1137 1138
	* editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
	for characters.

1139 1140
	* doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.

1141 1142 1143 1144 1145
	* data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
	Without this fix, on a 64-bit host (aset S 0 4294967386) would
	incorrectly succeed when S was a string, because 4294967386 was
	truncated before it was used.

1146 1147 1148 1149
	* chartab.c (Fchar_table_range): Use CHARACTERP to check range.
	Otherwise, an out-of-range integer could cause undefined behavior
	on a 64-bit host.

1150 1151 1152 1153 1154 1155
	* composite.c: Use int, not EMACS_INT, for characters.
	(fill_gstring_body, composition_compute_stop_pos): Use int, not
	EMACS_INT, for values that are known to be in character range.
	This doesn't fix any bugs but is the usual style inside Emacs and
	may generate better code on 32-bit machines.

1156 1157 1158 1159 1160 1161 1162 1163
	Make sure a 64-bit char is never passed to ENCODE_CHAR.
	This is for reasons similar to the recent CHAR_STRING fix.
	* charset.c (Fencode_char): Check that character arg is actually
	a character.  Pass an int to ENCODE_CHAR.
	* charset.h (ENCODE_CHAR): Verify that the character argument is no
	wider than 'int', as a compile-time check to prevent future regressions
	in this area.

1164
	* character.c (char_string): Remove unnecessary casts.
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174

	Make sure a 64-bit char is never passed to CHAR_STRING.
	Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
	by silently ignoring the top 32 bits, allowing some values
	that were far too large to be valid characters.
	* character.h: Include <verify.h>.
	(CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
	arguments are no wider than unsigned, as a compile-time check
	to prevent future regressions in this area.
	* data.c (Faset):
Paul Eggert's avatar
Paul Eggert committed
1175
	* editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1176 1177 1178 1179 1180 1181 1182 1183 1184
	(Fsubst_char_in_region):
	* fns.c (concat):
	* xdisp.c (decode_mode_spec_coding):
	Adjust to CHAR_STRING's new requirement.
	* editfns.c (Finsert_char, Fsubst_char_in_region):
	* fns.c (concat): Check that character args are actually
	characters.  Without this test, these functions did the wrong
	thing with wildly out-of-range values on 64-bit hosts.

1185 1186 1187 1188 1189
	Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
	These casts should not be needed on 32-bit hosts, either.
	* keyboard.c (read_char):
	* lread.c (Fload): Remove casts to unsigned.

1190 1191 1192 1193
	* lisp.h (UNSIGNED_CMP): New macro.
	This fixes comparison bugs on 64-bit hosts.
	(ASCII_CHAR_P): Use it.
	* casefiddle.c (casify_object):
Paul Eggert's avatar
Paul Eggert committed
1194
	* character.h (ASCII_BYTE_P, CHAR_VALID_P)
1195 1196 1197 1198 1199
	(SINGLE_BYTE_CHAR_P, CHAR_STRING):
	* composite.h (COMPOSITION_ENCODE_RULE_VALID):
	* dispextern.h (FACE_FROM_ID):
	* keyboard.c (read_char): Use UNSIGNED_CMP.

1200 1201 1202
	* xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
	not to EMACS_INT, to avoid GCC warning.

1203 1204
	* xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.

1205 1206 1207
	* buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
	The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
	isn't needed on 32-bit machines.
1208

Paul Eggert's avatar
Paul Eggert committed
1209 1210
	* buffer.c (Fgenerate_new_buffer_name):
	Use EMACS_INT for count, not int.
1211
	(advance_to_char_boundary): Return EMACS_INT, not int.
1212 1213 1214

	* data.c (Qcompiled_function): Now static.

1215 1216
	* window.c (window_body_lines): Now static.

1217 1218
	* image.c (gif_load): Rename local to avoid shadowing.

1219 1220 1221 1222 1223 1224 1225 1226
	* lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
	(struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
	* alloc.c (make_save_value): Integer argument is now of type
	ptrdiff_t, not int.
	(mark_object): Use ptrdiff_t, not int.
	* lisp.h (pD): New macro.
	* print.c (print_object): Use it.

1227 1228 1229
	* alloc.c: Use EMACS_INT, not int, to count objects.
	(total_conses, total_markers, total_symbols, total_vector_size)
	(total_free_conses, total_free_markers, total_free_symbols)
Paul Eggert's avatar
Paul Eggert committed
1230 1231
	(total_free_floats, total_floats, total_free_intervals)
	(total_intervals, total_strings, total_free_strings):
1232 1233 1234 1235
	Now EMACS_INT, not int.  All uses changed.
	(Fgarbage_collect): Compute overall total using a double, so that
	integer overflow is less likely to be a problem.  Check for overflow
	when converting back to an integer.
1236 1237 1238 1239
	(n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
	(n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
	These were 'int' variables that could overflow on 64-bit hosts;
	they were never used, so remove them instead of repairing them.
1240
	(nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1241 1242 1243
	(inhibit_garbage_collection): Set gc_cons_threshold to max value.
	Previously, this ceilinged at INT_MAX, but that doesn't work on
	64-bit machines.
1244
	(allocate_pseudovector): Don't use EMACS_INT when int would do.
1245

1246
	* alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1247
	(allocate_vectorlike): Check for ptrdiff_t overflow.
1248 1249 1250
	(mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
	when a (possibly-narrower) signed value would do just as well.
	We prefer using signed arithmetic, to avoid comparison confusion.
1251

1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
	* alloc.c: Catch some string size overflows that we were missing.
	(XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
	for convenience in STRING_BYTES_MAX.
	(STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
	The definition here is exact; the one in lisp.h was approximate.
	(allocate_string_data): Check for string overflow.  This catches
	some instances we weren't catching before.  Also, it catches
	size_t overflow on (unusual) hosts where SIZE_MAX <= min
	(PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
	and ptrdiff_t and EMACS_INT are both 64 bits.
1262

1263 1264 1265 1266
	* character.c, coding.c, doprnt.c, editfns.c, eval.c:
	All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
	* lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.

1267 1268
	* character.c (string_escape_byte8): Fix nbytes/nchars typo.

1269 1270
	* alloc.c (Fmake_string): Check for out-of-range init.

1271 1272 1273 1274
2011-06-15  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (Fdefvaralias): Also mark the target as variable-special-p.

1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298
2011-06-14  Jan Djärv  <jan.h.d@swipnet.se>

	* xfns.c (x_set_scroll_bar_default_width): Remove argument to
	xg_get_default_scrollbar_width.

	* gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
	(int_gtk_range_get_value): Move to the scroll bar part of the file.
	(style_changed_cb): Call update_theme_scrollbar_width and call
	x_set_scroll_bar_default_width and xg_frame_set_char_size for
	all frames (Bug#8505).
	(xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
	Call gtk_window_set_resizable if HAVE_GTK3.
	(x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
	and height if HAVE_GTK3 (Bug#8505).
	(scroll_bar_width_for_theme): New variable.
	(update_theme_scrollbar_width): New function.
	(xg_get_default_scrollbar_width): Move code to
	update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
	(xg_initialize): Call update_theme_scrollbar_width.

	* gtkutil.h (xg_get_default_scrollbar_width): Remove argument.

	* emacsgtkfixed.c, emacsgtkfixed.h: New files.

1299 1300 1301 1302 1303 1304 1305 1306 1307 1308