ChangeLog 235 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2013-09-28  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_selection_color): Remove.
	(ns_get_color): Check for ns_selection_(fg|bg)_color using
	NSColor selectedText(Background)Color.  Only for COCOA.
	(ns_term_init): Remove assignment of ns_selection_color, logic
	moved to ns_get_color.

	* nsterm.h (NS_SELECTION_BG_COLOR_DEFAULT): Renamed from
	NS_SELECTION_COLOR_DEFAULT.
	(NS_SELECTION_FG_COLOR_DEFAULT): New.

13 14 15 16 17
2013-09-28  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fdump_tool_bar_row): Ifdef away the body if 'struct
	frame' does not have the tool_bar_window member.

18 19 20 21 22 23 24
2013-09-26  Barry O'Reilly  <gundaetiapo@gmail.com>

	Signal error when reading an empty byte-code object (Bug#15405)
	* lread.c (read1): signal error
	* alloc.c (make_byte_code): eassert header size
	(sweep_vectors): change an int to size_t

25 26
2013-09-24  Paul Eggert  <eggert@cs.ucla.edu>

27 28 29 30
	* dispnew.c (clear_glyph_row, copy_row_except_pointers): Use enums
	instead of ints, as it's the usual style for offsetof constants.  See:
	http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00478.html

31 32 33 34 35 36 37 38 39 40 41
	* data.c (POPCOUNT_STATIC_INLINE): New macro, as a hack for popcount.
	This is ugly, but it should fix the performance problem for older
	GCC versions in the short run.  I'll look into integrating the
	Gnulib module for popcount, as a better fix.
	See the thread starting in:
	http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00474.html
	(popcount_size_t_generic) [NEED_GENERIC_POPCOUNT]:
	(popcount_size_t_msc) [USE_MSC_POPCOUNT]:
	(popcount_size_t_gcc) [USE_GCC_POPCOUNT]:
	(popcount_size_t): Use it.

42 43 44 45 46
2013-09-24  Daniel Colascione  <dancol@dancol.org>

	* process.c (Fnetwork_interface_info): Fix build break due to
	vector changes.

47 48 49 50 51 52 53 54
2013-09-24  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c (clear_glyph_row, copy_row_except_pointers):
	Prefer signed to unsigned integers where either will do.
	No need for 'const' on locals that do not escape.
	Omit easserts with unnecessary and unportable assumptions about
	alignment.  Avoid unnecessary casts to char *.

55 56 57 58 59 60 61 62 63 64 65 66 67
2013-09-24  Dmitry Antipov  <dmantipov@yandex.ru>

	Use union for the payload of struct Lisp_Vector.
	This helps to avoid a few glitches dictated by C's aliasing rules.
	* lisp.h (struct Lisp_Vector): Use union for next and
	contents member.  Adjust comment.  Change related users.
	* alloc.c (next_in_free_list, set_next_in_free_list): Remove.
	Related users changed.
	* buffer.c, bytecode.c, ccl.c, character.h, chartab.c, composite.c:
	* composite.h, disptab.h, fns.c, fontset.c, indent.c, keyboard.c:
	* lread.c, msdos.c, process.c, w32menu.c, window.c, xdisp.c:
	* xfaces.c, xfont.c, xmenu.c: Related users changed.

68 69 70 71 72 73 74 75 76 77
2013-09-24  Dmitry Antipov  <dmantipov@yandex.ru>

	Optimize glyph row clearing and copying routines.
	* dispextern.h (struct glyph_row): Change layout of struct
	glyph_row to help copy_row_except_pointers.  Adjust comment.
	* dispnew.c (null_row): Remove.
	(clear_glyph_row): Use offsetof and memset to find and clear
	just the members that need clearing.  Adjust comment.
	(copy_row_except_pointers): Likewise for copying.

78 79
2013-09-24  Paul Eggert  <eggert@cs.ucla.edu>

80 81 82 83 84 85 86 87 88 89 90 91 92 93
	Some minor cleanups of recently-added bool vector code.
	* conf_post.h (assume): Always return void.  Use lint version
	only if GCC and MSC versions don't apply.
	* conf_post.h (assume):
	* data.c (USC_MSC_POPCOUNT, count_trailing_zero_bits):
	Depend on _MSC_VER, not __MSC_VER, for consistency with
	the rest of Emacs.
	* data.c (bool_vector_spare_mask, popcount_size_t_generic)
	(popcount_size_t_msc, popcount_size_t_gcc, popcount_size_t)
	(bool_vector_binop_driver, count_trailing_zero_bits)
	(size_t_to_host_endian): Now static, not static inline;
	the latter isn't needed with modern compilers and doesn't
	work with older compilers anyway.

94 95
	* alloc.c (valgrind_p): Use bool for boolean.

96 97 98 99 100 101 102
2013-09-23  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (noninteractive_need_newline, message_log_need_newline)
	(overlay_arrow_seen, message_enable_multibyte, line_number_displayed)
	(display_last_displayed_message_p, message_buf_print)
	(message_cleared_p, help_echo_showing_p, hourglass_shown_p):
	Use bool for boolean.
103 104 105
	* dispextern.h (cancel_line, init_desired_glyphs):
	Remove ancient leftover.
	(help_echo_showing_p, hourglass_shown_p):
106 107
	* lisp.h (noninteractive_need_newline): Adjust declaration.

108 109 110 111 112 113 114 115 116 117 118 119
2013-09-23  Dmitry Antipov  <dmantipov@yandex.ru>

	* dispnew.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
	Move to...
	* frame.c (frame_garbaged, selected_frame, last_nonminibuf_frame):
	...this file and convert the latter to static.  Adjust comment.
	(make_initial_frame):
	* window.c (init_window_once): Adjust user.
	* frame.h (last_nonminibuf_frame): Remove declaration.
	* lisp.h (selected_frame): Likewise.
	* msdos.c (the_only_display_info): Adjust comment.

120 121
2013-09-23  Eli Zaretskii  <eliz@gnu.org>

122 123 124
	* xdisp.c (mouse_face_from_string_pos): Fix off-by-one error in
	computing the end column of mouse-highlight that comes from
	display or overlay strings.  (Bug#15437)
Eli Zaretskii's avatar
Eli Zaretskii committed
125 126
	(note_mouse_highlight): Adapt calculation of last argument to
	mouse_face_from_string_pos to the above change.
127

128 129 130
	* conf_post.h (__has_builtin): Define to zero, if undefined, on
	all platforms, not just for clang.

131 132 133 134 135 136 137
2013-09-23  Jan Djärv  <jan.h.d@swipnet.se>

	* filelock.c (lock_file_1): Rearrange to remove compiler warning
	about excess arguments to snprintf.

	* conf_post.h(assume): Use __builtin_unreachable for clang.

138 139 140 141 142
2013-09-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32console.c (initialize_w32_display): Remove unused variable hlinfo.
	* w32term.c (w32_scroll_bar_handle_click): Remove unused variable f.

143 144 145 146 147 148 149 150 151 152
2013-09-23  Daniel Colascione  <dancol@dancol.org>

	* alloc.c (USE_VALGRIND): New macro; on by default
	when ENABLE_CHECKING.
	(mark_maybe_object,mark_maybe_pointer)
	[USE_VALGRIND]: Mark conservatively-scanned regions valid for
	valgrind purposes.
	(valgrind_p) [USE_VALGRIND]: New variable.
	(init_alloc) [USE_VALGRIND]: Initialize valgrind_p.

153 154
2013-09-22  Jan Djärv  <jan.h.d@swipnet.se>

155 156 157 158 159 160 161 162 163 164
	* process.c (wait_reading_process_output): Change int pnamelen to
	socklen_t.

	* nsterm.m (setMarkedText:selectedRange:):
	(deleteWorkingText):
	* nsmenu.m (addDisplayItemWithImage:idx:tag:helpText:enabled:):
	* nsfont.m (ns_get_covering_families, ns_findfonts): Cast NSLog
	argument to unsigned long to avoid warning.
	(nsfont_draw): Use 0.25 instead of  Fix2X (kATSItalicQDSkew).

165 166
	* conf_post.h (assume): Fix compiler error: x shall be cond.

167 168 169 170 171
2013-09-22  Daniel Colascione  <dancol@dancol.org>

	* xfns.c (x_get_monitor_attributes): Suppress unused variable
	warning when compiling without a window system.

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213
2013-09-22  Daniel Colascione  <dancol@dancol.org>

	* data.c (Qbool_vector_p): New symbol.
	(bool_vector_spare_mask,popcount_size_t_generic)
	(popcount_size_t_msc,popcount_size_t_gcc)
	(popcount_size_t)
	(bool_vector_binop_driver)
	(count_trailing_zero_bits,size_t_to_host_endian)
	(Fbool_vector_exclusive_or)
	(Fbool_vector_union)
	(Fbool_vector_intersection,Fbool_vector_set_difference)
	(Fbool_vector_subsetp,Fbool_vector_not)
	(Fbool_vector_count_matches)
	(Fbool_vector_count_matches_at): New functions.
	(syms_of_data): Intern new symbol, functions.
	* alloc.c (bool_vector_payload_bytes): New function.
	(Fmake_bool_vector): Instead of calling Fmake_vector,
	which performs redundant initialization and argument checking,
	just call allocate_vector ourselves.  Make sure we clear any
	terminating padding to zero.
	(vector_nbytes,sweep_vectors): Use bool_vector_payload_bytes
	instead of open-coding the size calculation.
	(vroundup_ct): New macro.
	(vroundup): Assume argument >= 0; invoke vroundup_ct.
	* casetab.c (shuffle,set_identity): Change lint_assume to assume.
	* composite.c (composition_gstring_put_cache): Change
	lint_assume to assume.
	* conf_post.h (assume): New macro.
	(lint_assume): Remove.
	* dispnew.c (update_frame_1): Change lint_assume to assume.
	* ftfont.c (ftfont_shape_by_flt): Change lint_assume
	to assume.
	* image.c (gif_load): Change lint_assume to assume.
	* lisp.h (eassert_and_assume): New macro.
	(Qbool_vector_p): Declare.
	(CHECK_BOOL_VECTOR,ROUNDUP,BITS_PER_SIZE_T): New macros.
	(swap16,swap32,swap64): New inline functions.
	* macfont.c (macfont_shape): Change lint_assume to assume.
	* ralloc.c: Rename ROUNDUP to PAGE_ROUNDUP throughout.
	* xsettings.c (parse_settings): Use new swap16 and
	swap32 from lisp.h instead of file-specific macros.

214 215 216 217 218 219
2013-09-22  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_window_id): Don't abort if cursor row could not be
	found (which can legitimately happen when the glyph row at the
	window start is disabled in the current_matrix.  (Bug#15365)

220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237
2013-09-22  Paul Eggert  <eggert@cs.ucla.edu>

	Fix syntax.h bug introduced by recent INLINE change.
	syntax.h defined an extern inline function SYNTAX_ENTRY that was
	conditionally compiled one way in some modules, and a different
	way in others.  This doesn't work with extern inline functions,
	which must have the same definition in all modules, because the
	defining code might be shared across modules, depending on the
	implementation.  Symptoms reported by Martin Rudalics in:
	http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
	* regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
	(SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
	overriding the corresponding functions in syntax.h.
	* syntax.h (syntax_property_entry, syntax_property_with_flags)
	(syntax_property): New inline functions.
	(SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
	Rewrite in terms of these new functions.

238 239 240 241 242 243
2013-09-21  Eli Zaretskii  <eliz@gnu.org>

	* dired.c (directory_files_internal): Use multibyte_chars_in_text,
	not chars_in_text, whose result depends on the multibyteness of
	the current buffer.  (Bug#15426)

Paul Eggert's avatar
Paul Eggert committed
244 245
2013-09-20  Paul Eggert  <eggert@cs.ucla.edu>

246 247 248 249 250
	Port recent change to hosts where pointers aren't 'long'.
	* xterm.c (x_send_scroll_bar_event, x_scroll_bar_to_input_event):
	Don't assume that pointers are the same width as 'long'.
	Add a compile-time check that a pointer fits into two X slots.

Paul Eggert's avatar
Paul Eggert committed
251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
	A simpler, centralized INLINE.
	* conf_post.h (INLINE): Define only if not already defined.
	This allows us to use a single INLINE, defined by one file
	per executable.
	* emacs.c (INLINE): Define it.
	Also, include category.h, charset.h, composite.h, dispextern.h,
	syntax.h, systime.h, so that their INLINE definitions are expanded
	properly for Emacs.
	* blockinput.h, keyboard.c (BLOCKINPUT_INLINE):
	* buffer.h, buffer.c (BUFFER_INLINE):
	* category.h, category.c (CATEGORY_INLINE):
	* character.h, character.c (CHARACTER_INLINE):
	* charset.h, charset.c (CHARSET_INLINE):
	* composite.h, composite.c (COMPOSITE_INLINE):
	* dispextern.h, dispnew.c (DISPEXTERN_INLINE):
	* frame.h, frame.c (FRAME_INLINE):
	* intervals.h, intervals.c (INTERVALS_INLINE):
	* keyboard.h, keyboard.c (KEYBOARD_INLINE):
	* lisp.h, alloc.c (LISP_INLINE):
	* process.h, process.c (PROCESS_INLINE):
	* syntax.h, syntax.c (SYNTAX_INLINE):
	* systime.h, sysdep.c (SYSTIME_INLINE):
	* termhooks.h, terminal.h (TERMHOOKS_INLINE):
	* window.h, window.c (WINDOW_INLINE):
	Remove.  All uses replaced with INLINE.

277 278 279 280 281
2013-09-20  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (handle_one_xevent): Revert part of 2013-09-17 change
	to avoid Bug#15398.

282 283 284 285 286 287
2013-09-19  Eli Zaretskii  <eliz@gnu.org>

	* w32reg.c (w32_get_string_resource): Make the first 2 arguments
	'const char *' to avoid compiler warnings due to similar change in
	the prototype of x_get_string_resource.

288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314
2013-09-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct x_display_info): New members last_mouse_glyph_frame,
	last_mouse_scroll_bar, last_mouse_glyph and last_mouse_movement_time,
	going to replace static variables below.  Adjust comments.
	* xterm.c (last_mouse_glyph, last_mouse_glyph_frame)
	(last_mouse_scroll_bar, last_mouse_movement_time): Remove.
	(note_mouse_movement, XTmouse_position, x_scroll_bar_note_movement)
	(x_scroll_bar_report_motion, handle_one_xevent, syms_of_xterm):
	Related users changed.
	* w32term.h (struct w32_display_info): New members last_mouse_glyph_frame,
	last_mouse_scroll_bar, last_mouse_scroll_bar_pos, last_mouse_glyph and
	last_mouse_movement_time, going to replace static variables below.
	Adjust comments.
	* w32term.c (last_mouse_glyph_frame, last_mouse_scroll_bar)
	(last_mouse_scroll_bar_pos, last_mouse_glyph, last_mouse_movement_time):
	Remove.
	(note_mouse_movement, w32_mouse_position, w32_scroll_bar_handle_click)
	(x_scroll_bar_report_motion, syms_of_w32term): Related users changed.
	* nsterm.h (struct ns_display_info): New members last_mouse_glyph,
	last_mouse_movement_time and last_mouse_scroll_bar, going to replace
	static variables below.
	* nsterm.m (last_mouse_glyph, last_mouse_movement_time)
	(last_mouse_scroll_bar): Remove.
	(note_mouse_movement, ns_mouse_position, mouseMoved, mouseEntered)
	(mouseExited): Related users changed.

315 316 317 318 319 320 321 322
2013-09-19  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not use external array to process X scroll bar messages.
	* xterm.c (scroll_bar_windows, scroll_bar_windows_size): Remove.
	(x_send_scroll_bar_event): Pack window pointer into two slots
	of XClientMessageEvent if we're 64-bit.  Adjust comment.
	(x_scroll_bar_to_input_event): Unpack accordingly.

323 324 325 326 327 328 329 330
2013-09-18  Dmitry Antipov  <dmantipov@yandex.ru>

	Ifdef away recent changes which aren't relevant to NS port.
	* dispextern.h (x_mouse_grabbed, x_redo_mouse_highlight)
	[!HAVE_NS]: Declare as such.
	* frame.c (x_mouse_grabbed, x_redo_mouse_highlight)
	[!HAVE_NS]: Define as such.

331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353
2013-09-18  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (x_redo_mouse_highlight): New function
	to factor out common code used in W32 and X ports.
	* dispextern.h (x_redo_mouse_highlight): Add prototype.
	* xterm.h (struct x_display_info):
	* w32term.h (struct w32_display_info):
	* nsterm.h (struct ns_display_info): New members
	last_mouse_motion_frame, last_mouse_motion_x and
	last_mouse_motion_y, going to replace static variables below.
	* xterm.c (last_mouse_motion_event, last_mouse_motion_frame)
	(redo_mouse_highlight): Remove.
	(note_mouse_movement, syms_of_xterm): Adjust user.
	(handle_one_xevent): Likewise.  Use x_redo_mouse_highlight.
	* w32term.c (last_mouse_motion_event, last_mouse_motion_frame)
	(redo_mouse_highlight): Remove.
	(note_mouse_movement, syms_of_w32term): Adjust user.
	(w32_read_socket): Likewise.  Use x_redo_mouse_highlight.
	* nsterm.m (last_mouse_motion_position, last_mouse_motion_frame):
	Remove.
	(note_mouse_movement, mouseMoved, syms_of_nsterm):
	* nsfns.m (compute_tip_xy): Adjust user.

354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
2013-09-18  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (x_mouse_grabbed): New function.
	* dispextern.h (x_mouse_grabbed): Add prototype.
	(last_mouse_frame): Remove declaration.
	* xterm.h (struct x_display_info):
	* w32term.h (struct w32_display_info):
	* nsterm.h (struct ns_display_info): New member
	last_mouse_frame, going to replace...
	* xdisp.c (last_mouse_frame): ...global variable.
	(note_tool_bar_highlight):
	* w32term.c (w32_mouse_position, w32_read_socket):
	* xterm.c (XTmouse_position, handle_one_xevent):
	Use x_mouse_grabbed.
	* nsterm.m (ns_mouse_position, mouseDown): Adjust user.

370 371 372 373 374 375
2013-09-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* w32term.c (w32_read_socket): Avoid temporary
	variables in a call to x_real_positions.
	* xterm.c (handle_one_xevent): Likewise.

376 377 378 379 380 381 382 383 384 385
2013-09-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function.
	(x_icon_type): Remove prototype.
	(x_bitmap_icon) [!HAVE_NS]: Declare as such.
	* frame.c (x_icon_type): Remove.
	* w32term.c (x_make_frame_visible, x_iconify_frame):
	* xterm.c (x_make_frame_visible, x_iconify_frame):
	Use x_set_bitmap_icon to factor out common code.

386 387 388 389 390 391 392 393 394 395 396 397
2013-09-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* dispextern.h (check_x_display_info, x_get_string_resource):
	Declare here just once and unify the latter.
	* frame.c (check_x_display_info, x_get_string_resource):
	* nsterm.h (check_x_display_info):
	* xrdb.c (x_get_string_resource):
	* xterm.h (check_x_display_info): Remove prototypes.
	* nsfns.m (x_get_string_resource): Likewise.  Adjust definition.
	* w32reg.c (x_get_string_resource): Likewise.
	(w32_get_rdb_resource): Adjust user.

398 399 400 401 402 403 404 405 406 407 408
2013-09-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct x_display_info): New member
	x_pending_autoraise_frame, going to replace...
	* xterm.c (pending_autoraise_frame): ...static variable.
	(x_new_focus_frame, XTread_socket): Adjust users.
	* w32term.h (struct w32_display_info): New member
	w32_pending_autoraise_frame, going to replace...
	* w32term.c (pending_autoraise_frame): ...global variable.
	(x_new_focus_frame, w32_read_socket): Adjust users.

409 410 411 412 413
2013-09-17  Glenn Morris  <rgm@gnu.org>

	* xdisp.c (message_dolog): If we create *Messages*,
	switch it to messages-buffer-mode.

414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
2013-09-17  Paul Eggert  <eggert@cs.ucla.edu>

	Don't overuse 'const' in types of locals.
	* bidi.c (bidi_count_bytes):
	* gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
	(xg_event_is_for_scrollbar):
	* xselect.c (x_handle_property_notify)
	(x_handle_selection_notify, x_handle_dnd_message):
	* xsettings.c, xsettings.h (xft_settings_event):
	* xterm.c (x_handle_net_wm_state, handle_one_event)
	(x_menubar_window_to_frame, x_detect_focus_change)
	(construct_mouse_click, note_mouse_movement)
	(x_scroll_bar_to_input_event, x_scroll_bar_expose)
	(x_scroll_bar_handle_click, x_scroll_bar_note_movement)
	(handle_one_xevent, x_handle_net_wm_state):
	* xterm.h (x_handle_property_notify, x_handle_selection_notify)
	(x_handle_dnd_message):
	Avoid unnecessary 'const', typically the second 'const' in
	'const foo * const arg', a 'const' that does not affect the API
	and doesn't significantly help the human reader.

435 436 437 438 439 440 441
2013-09-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* image.c (fn_g_type_init) [WINDOWSNT]: Define and load
	only if Glib < 2.36.0.
	(fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
	* xsettings.c (init_gconf, init_gsettings): Do not check
	for g_type_init.
442 443
	* xterm.c (handle_one_xevent): Do not call to x_clear_area
	if GTK >= 2.7.0.
444
	(toplevel) [USE_MOTIF]: Include xlwmenu.h to pacify GCC.
445

Jan Djärv's avatar
Jan Djärv committed
446 447
2013-09-16  Jan Djärv  <jan.h.d@swipnet.se>

448 449 450
	* xsettings.c (init_gconf, init_gsettings): Check for Glib 2.36.0
	before calling g_type_init.

Jan Djärv's avatar
Jan Djärv committed
451 452 453 454
	* font.c (syms_of_font): Move call to syms_of_(ns|mac)font ...

	* nsterm.m (syms_of_nsterm): ... to here.

455 456 457 458 459 460
2013-09-16  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (toolkit_scroll_bar_interaction): Use bool for boolean.
	(ignore_next_mouse_click_timeout): Use Time as X does.
	(handle_one_xevent): Avoid cast and use unsigned comparison.

461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481
2013-09-16  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not copy X event in handle_one_xevent except KeyPress case.
	Wnen XEvent is processed, it is unlikely to be changed except
	KeyPress case, so we can avoid copying and use const pointer to
	const data to make sure that an event is not changed elsewhere.
	* xterm.c (handle_one_xevent): Change 2nd arg to 'const XEvent *
	const' and do not create local copy except for the KeyPress event.
	Use casts to avoid a few glitches.  Adjust formatting.  Add comments.
	(SET_SAVED_BUTTON_EVENT): Remove and move the code to the only user.
	(x_handle_net_wm_state, x_menubar_window_to_frame)
	(x_detect_focus_change, construct_mouse_click, note_mouse_movement)
	(x_scroll_bar_to_input_event, x_scroll_bar_expose)
	(x_scroll_bar_handle_click, x_scroll_bar_note_movement):
	* gtkutil.c (xg_event_is_for_menubar, xg_event_is_for_scrollbar):
	* xselect.c (x_handle_property_notify, x_handle_selection_notify)
	(x_handle_dnd_message):
	* xsettings.c (xft_settings_event):
	Use 'const XEvent * const' where appropriate.
	* xterm.h, gtkutil.h, xsettngs.h: Adjust related prototypes.

482 483 484 485 486 487 488 489 490 491
2013-09-16  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix X event waiting to handle multiple frames.
	* frame.h (struct frame) [HAVE_X_WINDOWS]: New member wait_event_type.
	* xterm.c (pending_event_wait): Remove.  Adjust users.
	(x_detect_focus_change): Pass frame arg.
	(handle_one_xevent): Find related frame early and clear per-frame
	wait_event_type only if this is an event for the relevant frame.
	(x_wait_for_event): Use per-frame wait_event_type.

492 493
2013-09-15  Jan Djärv  <jan.h.d@swipnet.se>

494 495 496 497 498 499
	* nsfns.m (Fx_create_frame): Fix font driver registration for
	GNUStep.

	* font.c (syms_of_font): Check MAC_OS_X_VERSION_MAX_ALLOWED >= 1050
	for syms_of_macfont.

500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529
	* nsterm.m: Include macfont.h.
	(ns_tmp_flags, ns_tmp_font): Remove.
	(ns_compute_glyph_string_overhangs): Check for driver Qns.
	(ns_draw_glyph_string): Use local variables instead of ns_tmp_flags,
	ns_tmp_font.  Call ns_draw_text_decoration here instead of nsfont.m.
	(changeFont:): Fix code style.  Check for font driver type when
	getiing font.

	* nsterm.h (FONT_DESCENT, FONT_ASCENT): Define to (f)->ascent and
	(f)->descent.

	* nsfont.m (ns_tmp_flags, ns_tmp_font): Remove.
	(nsfont_open): Set font driver type.
	Set font->ascent and font->descent.  Figure out font instead of
	ns_tmp_font, and flags instead of ns_tmp_flags.
	Fix indentation. Remove call to ns_draw_text_decoration,
	moved to nsterm.

	* nsfns.m: Include macfont.h.
	(Fx_create_frame): Register macfont driver, make a better default font.
	(Fns_popup_font_panel): Get font from macfont driver, if used.

	* macfont.m, macfont.h, maccuvs.h: New files.

	* font.h: Declare syms_of_macfont.

	* font.c (syms_of_font): Call syms_of_macfont.

	* Makefile.in (NS_OBJ, SOME_MACHINE_OBJECTS): Add macfont.o.

530 531 532 533 534 535 536 537 538 539 540 541 542 543
2013-09-15  Dmitry Antipov  <dmantipov@yandex.ru>

	Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM.  For X, it is zero since 1999,
	and it is always zero for others, so I assume that this is an ancient
	leftover which nobody will want to change any more.
	* xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
	(VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
	* frame.c (x_set_scroll_bar_width):
	* w32fns.c (w32_createscrollbar):
	* w32term.c (w32_set_vertical_scroll_bar):
	* xfns.c (x_set_scroll_bar_default_width):
	* xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
	(x_scroll_bar_expose): Related users changed.

544 545 546 547
2013-09-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
	(BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
548 549
	(SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
	Define as such.
550 551 552
	* frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
	Define once here...
	* nsterm.h, w32term.h, xterm.h: ...and not here.
553 554
	* w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
	Remove unused Xisms.
555 556
	* xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
	these modules are never compiled otherwise.
557

558 559
2013-09-14  Eli Zaretskii  <eliz@gnu.org>

560
	* buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
561 562
	Doc fix.  (Bug#15375)

563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	Unify Fx_focus_frame between all ports.
	* frame.h (x_focus_frame): New prototype.
	* xfns.c (Fx_focus_frame): Remove.
	(syms_of_xfns): Do not defsubr it.
	(x_focus_frame): X implementation.
	* nsfns.m (Fx_focus_frame): Remove.
	(syms_of_nsfns): Do not defsubr it.
	(x_focus_frame): NS implementation.
	* w32term.c (Fx_focus_frame): Remove.
	(x_focus_on_frame): Rename to...
	(x_focus_frame): W32 implementation.
	* w32term.h (x_focus_on_frame): Remove prototype.
	* w32fns.c (Fx_focus_frame): Remove.
	(syms_of_w32fns): Do not defsubr it.
	* frame.c (Fx_focus_frame): Define here.
	(syms_of_frame): Defsubr here.
	* gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.

583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
	All of them are replaced with FRAME_DISPLAY_INFO, defined in
	each port to reference the port-specific window system data.
	* msdos.h (FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.
	* w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.  Adjust users.
	* xterm.h (FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.  Adjust users.
	* frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
	* font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
	* nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
	* w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
	* xselect.c, xterm.c: All related users changed.

600 601 602 603 604 605 606 607 608 609 610
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame): Remove prototypes.
	* xfns.c (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame, x_top_window_to_frame):
	Move from here...
	* xterm.c (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame, x_top_window_to_frame):
	...to here and convert all but the last to static.

611 612 613 614
2013-09-12  Eli Zaretskii  <eliz@gnu.org>

	* lisp.mk (lisp): Add w32-common-fns.elc.

615 616 617 618
2013-09-12  Xue Fuqiao  <xfq.free@gmail.com>

	* charset.c (char_charset): Document an exception for char-charset.

619 620 621 622 623 624
2013-09-12  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (x_display_info): New field last_user_time...
	* xterm.c (toplevel): ...to replace static last_user_time.
	(handle_one_xevent, x_ewmh_activate_frame): Adjust users.

625 626 627 628 629
2013-09-12  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
	scroll bar values to prevent thumb from disappear and update comment.

630 631 632 633
2013-09-11  Glenn Morris  <rgm@gnu.org>

	* emacs.c (usage_message): Possessive apostrophe tweak.

634 635
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

636 637 638 639 640 641
	* nsterm.m (syms_of_nsterm): Use Qns.
	* w32fns.c (Fx_open_connection): Remove old '#if 0' code.
	* w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
	* xfns.c (x_display_info_for_name, Fx_open_connection):
	Remove old '#if 0' code.
	(syms_of_xfns): Use Qx.
642 643 644
	* termhooks.h (fullscreen_hook): Remove the leftover.
	(struct terminal): Fix typo in comment.

645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleaning up a few X scroll bar bits.
	* termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
	* xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
	New member last_seen_part, going to replace...
	* xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
	(xt_action_hook) [USE_LUCID]: Adjust user.
	(xm_scroll_callback, xg_scroll_callback): Do not bloat with
	Lucid-specific scroll bar support.
	(xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
	to int and adjust to use last_seen_part member.
	(x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
	(x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
	Initialize last_seen_part.

661 662 663 664 665
2013-09-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
	insert-buffer-substring an empty string.

666 667 668 669 670
2013-09-11  Paul Eggert  <eggert@cs.ucla.edu>

	* xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
	avoiding a GCC warning.

671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Ifdef away frame tool bar code when it is not really used.
	* frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
	Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
	and minimize_tool_bar_window_p under the above.
	(fset_current_tool_bar_string, fset_desired_tool_bar_string)
	(fset_tool_bar_window): Likewise.
	* dispnew.c (clear_current_matrices, clear_desired_matrices)
	(adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
	(change_frame_size_1):
	* window.c (window_from_coordinates, Frecenter): Adjust users.
	* window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
	code is not really used.
	* xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
	(tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
	(get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
	[!USE_GTK && !HAVE_NS]: Define as such.
	(Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
	(note_mouse_highlight, expose_frame):
	* xfns.c (x_set_tool_bar_lines):
	* xterm.c (handle_one_xevent): Adjust users.

694 695 696 697 698 699 700 701 702 703 704
2013-09-11  Paul Eggert  <eggert@cs.ucla.edu>

	Fix corruption with multiple emacsclient -t instances (Bug#15222).
	This bug was introduced by my 2013-08-26 patch, which incorrectly
	assumed that the terminfo implementation doesn't use termcap buffers.
	* term.c (init_tty) [TERMINFO]: Remove optimization, as
	these buffers apparently are used after all.
	* termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
	(struct tty_display_info): Define members termcap_term_buffer and
	termcap_strings_buffer even if TERMINFO.

Dmitry Antipov's avatar
Dmitry Antipov committed
705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix last change.
	* data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
	'usage' docstring entry to pacify make-docfile.

2013-09-11  Barry O'Reilly  <gundaetiapo@gmail.com>

	Change comparison functions =, <, >, <=, >= to take many arguments.
	* data.c: Change comparison functions' interface and implementation.
	* lisp.h: Make arithcompare available for efficient two arg
	comparisons.
	* bytecode.c: Use arithcompare.
	* fileio.c: Use new interface.

720 721 722 723
2013-09-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (read_char): Don't break immediate_echo (bug#15332).

724 725 726 727
2013-09-10  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (Feval): Document the new use of `lexical'.

728 729 730 731 732 733 734 735 736 737 738
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Review and drop old frame resize hack.
	* frame.h (struct frame): Remove force_flush_display_p.
	* dispnew.c (update_frame): Adjust user and don't call
	flush_frame here.  The comment has said that there was an issues
	with redisplaying fringes, but I don't see any differences with
	and without this hack.  Hopefully we can continue without it.
	* xdisp.c (clear_garbaged_frames): Adjust user and do not clear
	current frame matrices twice if resized_p is set.

739 740 741 742 743 744 745 746
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not populate pure Xism x_sync to other ports.
	* frame.h (x_sync): Move under HAVE_X_WINDOWS.
	* frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
	* nsfns.m, w32xfns.c (x_sync): Remove no-op.
	* w32term.h (x_sync): Remove prototype.

Dmitry Antipov's avatar
Dmitry Antipov committed
747 748 749
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleanup frame flushing.
750 751
	* dispextern.h (struct redisplay_interface):
	Drop flush_display_optional because flush_display is enough
Dmitry Antipov's avatar
Dmitry Antipov committed
752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
	for X and flushing via RIF is just a no-op for others.
	* frame.h (flush_frame): New function.
	* dispnew.c (update_frame):
	* minibuf.c (read_minibuf):
	* xdisp.c (echo_area_display, redisplay_preserve_echo_area):
	Use it.
	* keyboard.c (detect_input_pending_run_timers): Do not flush
	all frames but selected one in redisplay_preserve_echo_area.
	* nsterm.m (ns_flush): Remove no-op.
	(ns_redisplay_interface): Adjust user.
	* w32term.h (x_flush): Remove no-op.
	(w32_redisplay_interface): Adjust user.
	* xterm.c (x_flush): Simplify because we do not flush all
	frames at once any more.  Adjust comment.
	(x_redisplay_interface): Adjust user.

768 769 770 771 772 773
2013-09-07  Paul Eggert  <eggert@cs.ucla.edu>

	Port --without-x --enable-gcc-warnings to Fedora 19.
	* gfilenotify.c (globals_of_gfilenotify):
	Call g_type_init only if using an older glib version that needs it.

774 775 776 777 778 779 780 781 782 783 784 785 786
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
	(last_glyphless_glyph_merged_face_id): Remove declarations.
	* dispextern.h (merge_glyphless_glyph_face): Add prototype.
	* xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
	(last_glyphless_glyph_merged_face_id): Now static.
	(merge_escape_glyph_face): New function, refactored from...
	(get_next_display_element): ...here.
	(merge_glyphless_glyph_face): New function, refactored from...
	(produce_glyphless_glyph): ...here...
	* term.c (produce_glyphless_glyph): ...and here.

787 788 789 790
2013-09-06  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (eval_sub): Only call Ffunction if necessary.

791 792 793 794 795 796 797 798 799 800 801 802 803
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Attempt to make redisplay more selective when changing cursor type.
	* frame.h (struct frame): New bitfield cursor_type_changed.
	* xdisp.c (cursor_type_changed): Remove.
	(try_cursor_movement, redisplay_window, try_window_id)
	(set_frame_cursor_types, try_window_reusing_current_matrix):
	Adjust to use per-frame bitfield.
	(redisplay_internal): Look for cursor type change on each visible
	frame and consider all frames if cursor type has been changed on
	the frame other than selected.  If cursor type has been changed on
	selected frame only, do not use fast update.

804 805 806 807 808 809 810
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Attempt to make redisplay more selective when changing fonts.
	* frame.h (struct frame): New bitfield fonts_changed.
	* dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
	(adjust_frame_glyphs): Add prototype.
	* dispnew.c (fonts_changed_p): Remove.
Dmitry Antipov's avatar
Dmitry Antipov committed
811
	(adjust_glyphs): Remove because we do not
812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833
	adjust matrices on all frames at once any more.
	(adjust_frame_glyphs): Block and unblock input here.
	(adjust_glyph_matrix): Use fonts_changed.
	(change_frame_size_1): Use adjust_frame_glyphs.
	* font.c (font_open_entity): Use fonts_changed.
	* frame.c (set_menu_bar_lines, Fmake_terminal_frame):
	* w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
	* window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
	(Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
	(shrink_mini_window, Fresize_mini_window_internal)
	(window_scroll_pixel_based, Fset_window_configuration)
	(apply_window_adjustment, Fset_window_vscroll):
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
	Use adjust_frame_glyphs.
	* xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
	(try_window_reusing_current_matrix, try_window_id, display_line)
	(IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
	(redisplay_internal): Consider fonts_changed and adjust frame
	matrices for each frame only if the frame is visible.  If font
	has been changed on some frame during full redisplay, retry
	only visible frames where the font has been actually changed.

834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	Cache current header and mode line height for each window.
	* window.h (struct window): New fields mode_line_height
	and header_line_height.
	* window.c (make_window): Initialize them.
	* dispextern.h (CURRENT_MODE_LINE_HEIGHT)
	(CURRENT_HEADER_LINE_HEIGHT): Use them.  Adjust comment.
	(current_mode_line_height, current_header_line_height):
	Remove declaration.
	* xdisp.c (current_mode_line_height, current_header_line_height):
	Remove.
	(pos_visible_p, init_xdisp): Adjust user.
	(redisplay_window): Invalidate mode_line_height and
	header_line_height if current and desired matrices do not agree.

850 851 852 853 854
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
	* xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.

855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	Make --without-x compatible with --enable-gcc-warnings.
	* font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
	* font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
	members under HAVE_WINDOW_SYSTEM.
	* keyboard.c (make_lispy_focus_out): Likewise.
	(record_menu_key): Move under HAVE_MENUS.
	* xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
	THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
	(syms_of_xdisp): Adjust user.
	(window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
	(start_hourglass, cancel_hourglass):
	* xfaces.c (toplevel): Likewise with PT_PER_INCH,
	clear_font_table_count, CLEAR_FONT_TABLE_COUNT
	and CLEAR_FONT_TABLE_NFONTS.
	(set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
	Declare only if HAVE_WINDOW_SYSTEM.
	(lface_same_font_attributes_p, clear_face_gcs): Define only
	if HAVE_WINDOW_SYSTEM.

876 877 878 879 880 881
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (check_minibuf_window): Update 'frame' with frame pointer.
	* xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
	Don't pass C integer to XINT (tiny fix for 2013-09-03 change).

882 883 884 885
2013-09-05  Stefan Monnier  <monnier@iro.umontreal.ca>

	* cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.

886 887 888 889 890
2013-09-04  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
	This fixes a type error on hosts where ptrdiff_t is wider than int.

891 892
2013-09-04  Stefan Monnier  <monnier@iro.umontreal.ca>

893 894 895 896
	* keyboard.c (read_key_sequence_vs): New function.
	(Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
	common code.

897 898
	* callint.c (Fcall_interactively): Always return a vector for 'K'.

Paul Eggert's avatar
Paul Eggert committed
899 900 901 902 903 904 905 906
2013-09-04  Paul Eggert  <eggert@cs.ucla.edu>

	Makefile improvements.
	* Makefile.in (config.status): Don't use double-colon rules, as
	they are not portable according to POSIX.  Fix shell typo with `;
	I guess this rule has never been tested?
	(VCSWITNESS): New macro, to override any environment var.

907 908 909 910 911 912 913
2013-09-04  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct x_display_info): Do not track X connection
	fd separately because it is always available from Display.
	* xterm.c (x_term_init, x_delete_terminal, x_delete_display):
	Adjust users.

Dmitry Antipov's avatar
Dmitry Antipov committed
914 915 916 917 918 919
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (drop_overlay):
	* fileio.c (restore_point_unwind): Prefer unchain_marker to
	Fset_marker (X, Qnil, ...) (which is the same but a bit slower).

920 921 922 923 924 925 926
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (Fmake_overlay, Fmove_overlay):
	* intervals.c (set_point_from_marker):
	* print.c (PRINTPREPARE): Prefer signal_error
	to plain error and report unsuitable marker too.

927 928 929 930
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct scroll_bar): Prefer int to Lisp_Object
	for 'dragging' member.
931 932
	(struct x_output): Remove set-but-unused leftovers
	'left_before_move' and 'top_before_move'.
933 934 935 936 937 938
	* gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
	* xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
	(xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
	(x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
	(x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
	(x_scroll_bar_handle_click, x_scroll_bar_note_movement)
939
	(x_scroll_bar_report_motion, x_set_offset): Related users changed.
940
	* xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
941

942 943 944 945 946 947
2013-09-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfont.m (INVALID_GLYPH): New define.
	(nsfont_encode_char): Use INVALID_GLYPH.
	(ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).

948 949 950 951 952 953 954 955
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_last_mouse_movement_time): Revert last change.
	This code should use XDisplayMotionBufferSize to check display's
	motion history first, and there are few other issues as well.
	(x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
	(handle_one_xevent): Adjust user.

956 957
2013-09-02  Martin Rudalics  <rudalics@gmx.at>

958 959 960 961
	* dispnew.c (Flast_nonminibuf_frame): Move from here ...
	* frame.c (Flast_nonminibuf_frame): ... to here.
	(check_minibuf_window): Don't abort if no window was found
	(Bug#15247).
962

963 964 965 966 967 968 969 970 971 972
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	Use XGetMotionEvents to ask the last mouse motion time from X server.
	* xterm.c (X_MOTION_HISTORY): Default to 1.
	(x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
	(x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
	(note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
	Ifdef away legacy code.
	(XTmouse_position, x_scroll_bar_report_motion):
	Use x_last_mouse_movement_time.
973 974
	(handle_one_xevent): Use event.xunmap and not event.xmap when handling
	UnmapNotify event.
975

976 977 978 979 980 981 982 983 984 985 986
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* msdos.c (last_mouse_window): Move to...
	(dos_rawgetc): ...this function and adjust comment.
	* nsterm.m (last_window): Rename to last_mouse_window, move to...
	(mouseMoved): ...this function and adjust comment.
	* w32term.c (last_window): Likewise with...
	(w32_read_socket): ...this function.
	* xterm.c (last_window): Likewise with...
	(handle_one_xevent): ...this function.

987 988
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

989
	* window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
990 991 992 993 994
	* xterm.c (toplevel): Drop obsolete comment and move compose_status...
	(handle_one_xevent): ...to here.
	(STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
	otherwise.

995 996 997 998 999 1000 1001 1002 1003 1004 1005
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* msdos.c (IT_set_terminal_window): Remove no-op.
	(initialize_msdos_display): Adjust terminal setup.
	* w32console.c (w32con_set_terminal_window): Remove no-op.
	(initialize_w32_display): Adjust terminal setup.
	* w32term.c (w32_set_terminal_window): Remove no-op.
	(w32_create_terminal): Adjust terminal setup.
	* xterm.c (XTset_terminal_window): Remove no-op.
	(x_create_terminal): Adjust terminal setup.

1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017
2013-09-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
	Remove no-ops.
	(ns_create_terminal): Adjust terminal setup.
	* w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
	Remove no-ops.
	(w32_create_terminal): Adjust terminal setup.
	* xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
	Remove no-ops.
	(x_create_terminal): Adjust terminal setup.

1018 1019 1020 1021 1022 1023 1024 1025
2013-09-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
	(CLIP_TEXT_POS_FROM_MARKER): New macro.
	* dispnew.c (buffer_posn_from_coords):
	* window.c (Fwindow_end, displayed_window_lines):
	* xdisp.c (redisplay_mode_lines): Use it.

1026 1027 1028 1029 1030
2013-09-01  Jan Djärv  <jan.h.d@swipnet.se>

	* fontset.c (face_for_char): Check char in the current face font first
	if HAVE_NS (Bug#15138).

1031 1032 1033 1034 1035
2013-08-31  Martin Rudalics  <rudalics@gmx.at>

	* window.c (temp_output_buffer_show): Make sure window returned
	by display_buffer is live (Bug#15213).

1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
2013-08-30  Dmitry Antipov  <dmantipov@yandex.ru>

	Minor cleanup to avoid forward declarations.
	* coding.h (struct ccl_spec): Remove forward declaration.
	* composite.h (toplevel): Include font.h.
	(struct composition_it, struct face, struct font_metrics):
	Remove forward declaration.
	* dispextern.h (struct image, struct atimer): Likewise.
	* emacsgtkfixed.h (struct frame): Likewise.
	* emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
	* font.h (struct font_driver, struct font, struct glyph_string)
	(struct face): Remove forward declaration.
	* fontset.h (struct face, struct font): Likewise.
	* frame.h (toplevel): Style cleanup.
	(enum output_method): Move to...
	* termhooks.h (enum output_method): ...here.
	(struct glyph, struct frame, struct ns_display_info)
	(struct x_display_info, struct w32_display_info):
	Remove forward declaration.
	* xterm.h (toplevel): Include termhooks.h.
	(struct font, struct window, struct glyph_matrix, struct frame)
	(struct input_event, struct face, struct image): Remove forward
	declaration.
	* gtkutil.h (struct _widget_value): Likewise.
	* keyboard.h (toplevel): Include termhooks.h.
	(struct input_event): Remove forward declaration.

1063 1064 1065 1066 1067 1068 1069 1070
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* intervals.c (set_point_from_marker): New function.
	* editfns.c (Fgoto_char):
	* process.c (Finternal_default_process_filter):
	* window.c (select_window_1): Use it.
	* buffer.h (set_point_from_marker): Add prototype.

1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084
2013-08-29  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (term_winsock): Call release_listen_threads before calling
	WSACleanup.
	(_sys_wait_accept): Wait for accept event in a loop with a finite
	timeout, instead of waiting indefinitely.  Will hopefully avoid
	hanging during exit because WSACleanup deadlocks waiting for the
	event object to be released.  (Bug#14333)

	* w32proc.c (release_listen_threads): New function, signals all
	the reader threads that listen for connections to stop waiting.

	* w32.h (release_listen_threads): Add prototype.

1085 1086 1087 1088
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* alloc.c (Fmake_marker, build_marker): Zero need_adjustment
	field of new marker (for sanity and safety).
1089 1090
	* lisp.h (XSETMARKER): Remove unused macro (it doesn't work
	anyway because XMISCTYPE is a function and can't be an lvalue).
1091

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_clear_area): Lost 7th arg because it is always False.
	(x_after_update_window_line, x_scroll_bar_create):
	(x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
	(handle_one_xevent, x_clear_frame_area):
	* gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
	* xterm.h (x_clear_area): Adjust prototype.

1102 1103 1104 1105 1106 1107 1108 1109 1110 1111
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	Hook scanning and indentation functions to find_newline.  This helps
	to avoid duplicated code and renders more respect to newline cache.
	* lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
	* cmds.c (Fforward_line):
	* indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
	Use find_newline and avoid unnecessary point movements.
	* search.c (scan_newline): Implement on top of find_newline.

1112 1113 1114 1115 1116
2013-08-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
	scoped code (bug#11258).

1117 1118 1119 1120 1121 1122 1123 1124
2013-08-28  Davor Cubranic  <cubranic@stat.ubc.ca> (tiny change)

	* nsterm.m (last_window): New variable.
	(EV_TRAILER2): New macro.
	(EV_TRAILER): Call EV_TRAILER2.
	(mouseMoved:):  Add support for mouse-autoselect-window
	on nextstep (Bug#6888).

1125 1126 1127 1128 1129 1130
2013-08-28  Andreas Schwab  <schwab@suse.de>

	* regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
	(SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
	Remove unused macro definitions.
	(CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
1131 1132
	(SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
	Only define if emacs.
1133

1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	Prefer enum glyph_row_area to int where appropriate.
	* dispextern.h (enum glyph_row_area): Add ANY_AREA member.
	Fix comment.
	(window_box, window_box_width, window_box_left, window_box_left_offset)
	(window_box_right, window_box_right_offset): Adjust prototypes.
	* xdisp.c (window_box, window_box_width, window_box_left)
	(window_box_left_offset, window_box_right, window_box_right_offset):
	Use enum glyph_row_area.  Adjust users and tweak comment where needed.
	(window_box_edges): Likewise.  Lost 2nd arg since it is always ANY_AREA.
	* nsterm.m (ns_clip_to_row):
	* w32term.c (w32_clip_to_row):
	* xterm.c (x_clip_to_row): Likewise.

1149 1150 1151 1152 1153
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
	(Fprevious_overlay_change): Fast path for buffer with no overlays.

1154 1155 1156 1157 1158
2013-08-28  Paul Eggert  <eggert@cs.ucla.edu>

	* Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
	for portability to hosts where /bin/sh has problems.

1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop global output_cursor.
	* dispextern.h (struct redisplay_interface): Remove cursor_to member.
	(toplevel): Remove declaration of output_cursor.
	(set_output_cursor, x_cursor_to): Remove prototype.
	* window.h (struct window): New member output_cursor.
	(output_cursor_to): New function to replace RIF member.
	* dispnew.c (redraw_overlapped_rows, update_marginal_area)
	(update_text_area, set_window_cursor_after_update): Use it.
	* xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	* nsterm.m (ns_update_window_begin, ns_update_window_end):
	* w32term.c (x_update_window_begin, x_update_window_end):
	* xterm.c (x_update_window_begin, x_update_window_end):
	Adjust to use per-window output cursor.

1176 1177
2013-08-27  Paul Eggert  <eggert@cs.ucla.edu>

1178 1179 1180 1181 1182 1183 1184
	Simplify SELECT_TYPE-related code.
	Like EMACS_TIME, this portability layer is no longer needed, since
	Emacs has been using fd_set as a portability layer for some time.
	* sysselect.h (FD_SETSIZE): Rename from MAXDESC.  All uses changed.
	(SELECT_TYPE): Remove.  All uses changed to fd_set.
	(fd_set) [!FD_SET]: New typedef.

1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
	Simplify EMACS_TIME-related code.
	This portability layer is no longer needed, since Emacs has been
	using struct timespec as a portability layer for some time.
	* atimer.h, buffer.h, dispextern.h, xgselect.h:
	Include <time.h> rather than "systime.h"; that's all that's needed now.
	* dispnew.c: Include <timespec.h> rather than "systime.h";
	that's all that's needed now.
	* systime.h (EMACS_TIME): Remove.  All uses changed to struct timespec.
	(EMACS_TIME_RESOLUTION): Remove.  All uses changed to
	TIMESPEC_RESOLUTION.
	(LOG10_EMACS_TIME_RESOLUTION): Remove.  All uses changed to
	LOG10_TIMESPEC_RESOLUTION.
	(EMACS_SECS, emacs_secs_addr): Remove.  All uses changed to tv_sec.
	(EMACS_NSECS): Remove.  All uses changed to tv_nsec.
	(make_emacs_time): Remove.  All used changed to make_timespec.
	(invalid_timespec): Rename from invalid_emacs_time.  All uses changed.
	(current_timespec): Rename from current_emacs_time.  All uses changed.
	(add_emacs_time): Remove.  All uses changed to timespec_add.
	(sub_emacs_time): Remove.  All uses change dot timespec_sub.
	(EMACS_TIME_SIGN): Remove.  All uses changed to timespec_sign.
	(timespec_valid_p): Rename from EMACS_TIME_VALID_P.  All uses changed.
	(EMACS_TIME_FROM_DOUBLE): Remove.  All uses changed to dtotimespec.
	(EMACS_TIME_TO_DOUBLE): Remove.  All uses changed to timespectod.
	(current_timespec): Rename from current_emacs_time.  All uses changed.
	(EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove.  All uses
	changed to timespec_cmp.
	* xgselect.c: Include <timespec.h>, since our .h files don't.

1213 1214 1215 1216 1217 1218 1219 1220 1221 1222
2013-08-27  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
	* nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
	Remove the leftovers.
	* gtkutil.c (toplevel): Do not declare Qxft but include
	font.h to do so.
	* image.c (toplevel): Do not declare Vlibrary_cache because
	it's already done in lisp.h.

1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
2013-08-27  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (Mouse_HLInfo): Move from here...
	* dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
	(reset_mouse_highlight): New function.
	* msdos.c (dos_set_window_size, IT_update_begin)
	(internal_terminal_init):
	* nsterm.m (ns_update_window_end, x_free_frame_resources)
	(ns_initialize_display_info):
	* w32console.c (initialize_w32_display):
	* w32term.c (x_update_window_end, x_free_frame_resources)
	(w32_initialize_display_info):
	* xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
	* window.c (Fdelete_other_windows_internal):
	* xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
	* termchar.h (toplevel):
	* xterm.h (toplevel): Include dispextern.h.

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256
2013-08-26  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
	(expect): Avoid nested-if warning.
	(x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
	* nsmenu.m (fillWithWidgetValue:): Avoid type warning.
	* nsterm.h, nsterm.m (ns_select):
	* xgselect.c, xgselect.h (xg_select):
	Adjust signature to better match pselect's.
	* nsterm.m (ns_select):
	Don't set *TIMEOUT, since pselect doesn't.
	* regex.c (whitespace_regexp): Now const_re_char *, to avoid
	diagnostic about assigning const char * to it.
	* xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.

1257 1258 1259 1260 1261
2013-08-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (substitute_object_recurse): Handle hash-tables as well
	(bug#15190).

1262 1263
2013-08-26  Paul Eggert  <eggert@cs.ucla.edu>

1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
	Fix unlikely core dump in init_tty, and simplify terminfo case.
	* term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
	The old version incorrectly dumped core if malloc returned a
	buffer containing only non-NUL bytes.
	(init_tty): Do not allocate or free termcap buffers; the
	struct does that for us now.
	* termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
	(struct tty_display_info): Define members termcap_term_buffer and
	termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
	use them.  Allocate them directly in struct rather than indirectly
	via a pointer, to simplify init_tty.

1276 1277 1278
	* frame.c (check_minibuf_window): Initialize 'window' properly,
	so that Emacs reliably aborts later if 'window' is not initialized.

1279 1280 1281 1282 1283
2013-08-26  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
	of VoidSymbol (Bug#15154).

1284 1285 1286 1287 1288 1289 1290 1291
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (Mouse_HLInfo): Drop set-but-unused members
	mouse_face_beg_y and mouse_face_end_y.
	* xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
	(mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
	Adjust users and update comment where appropriate.

1292 1293 1294
2013-08-26  Martin Rudalics  <rudalics@gmx.at>

	* frame.c (check_minibuf_window): New function.
1295 1296
	(delete_frame, Fmake_frame_invisible, Ficonify_frame):
	Call check_minibuf_window (Bug#15183).
1297

1298 1299 1300 1301 1302 1303 1304 1305
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Replace last_cursor with last_cursor_vpos
	because this is the only last cursor data we need to keep and consult.
	* window.c (replace_window, set_window_buffer, Fsplit_window_internal):
	* xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
	Adjust users.

1306 1307
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

1308 1309
	Fix recovering from possible decompression error.
	Since insert_from_gap doesn't always move point, we can't use PT as
1310
	the position where the partially decompressed data ends, and
Dmitry Antipov's avatar
Dmitry Antipov committed
1311
	should count how many bytes was produced so far.
1312 1313 1314 1315
	* decompress.c (struct decompress_unwind_data): Add nbytes member.
	(unwind_decompress): Really delete partially uncompressed data.
	(Fzlib_decompress_region): Take decompressed data size into account.

1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* syntax.c (init_syntax_once): Adjust comment and do an early
	initialization of Qchar_table_extra_slots just once...
	* casetab.c (init_casetab_once):
	* category.c (init_category_once):
	* character.c (syms_of_character):
	* coding.c (syms_of_coding):
	* xdisp.c (syms_of_xdisp): ...and omit it here.

1326 1327
2013-08-24  Eli Zaretskii  <eliz@gnu.org>

1328 1329 1330 1331
	* xdisp.c (get_next_display_element): Don't apply to characters
	from a display vector the logic of setting it->end_of_box_run_p
	suitable for characters from a buffer.  (Bug#15175)

1332 1333 1334 1335
	* w32.c (fdutimens): Call 'utime', which is implemented on w32.c
	to handle directories, rather than '_utime' which doesn't.
	(Bug#15176)

1336 1337 1338 1339 1340
2013-08-24  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
	or fullscreen (Bug#14627).

1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356
2013-08-24  Paul Eggert  <eggert@cs.ucla.edu>

	System-dependent integer overflow fixes.
	* process.c (Fset_process_window_size): Signal an error if
	the window size is outside the range supported by the lower level.
	* sysdep.c (set_window_size): Return negative on error,
	nonnegative on success, rather than -1, 0, 1 on not in system,
	failure, success.  This is simpler.  Caller changed.
	(serial_configure): Remove unnecessary initialization of local.
	(procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
	size fits in unsigned long; this isn't true on some 32-bit hosts.
	Avoid buffer overrun if some future version of /proc/meminfo has a
	variable name longer than 20 bytes.
	(system_process_attributes) [__FreeBSD__]:
	Don't assume hw.availpages fits in 'int'.

1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378
2013-08-23  Paul Eggert  <eggert@cs.ucla.edu>

	Don't let very long directory names overrun the stack.
	Fix some related minor problems involving "//", vfork.
	* callproc.c (encode_current_directory): New function.
	(call_process): Don't append "/"; not needed.
	* fileio.c (file_name_as_directory_slop): New constant.
	(file_name_as_directory): Allow SRC to be longer than SRCLEN;
	this can save the caller having to alloca.
	(Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
	Use SAFE_ALLOCA, not alloca.
	(directory_file_name, Fexpand_file_name): Leave leading "//"
	alone, since it can be special even on POSIX platforms.
	* callproc.c (call_process):
	* process.c (Fformat_network_address):
	* sysdep.c (sys_subshell):
	Use encode_current_directory rather than rolling our own.
	(create_process): No need to encode directory; caller does that now.
	* process.h (encode_current_directory): New decl.
	* sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
	Rework to avoid 'goto xyzzy;'.

1379 1380 1381 1382 1383
2013-08-23  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_face_prop): If the default face was remapped use
	the remapped face for strings from prefix properties.  (Bug#15155)

1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Minor cleanup for redisplay interface and few related functions.
	* frame.h (enum text_cursor_kinds): Move from here...
	* dispextern.h (enum text_cursor_kinds): ...to here.
	(toplevel): Drop unnecessary declarations.
	(struct redisplay_interface): Use bool and enum text_cursor_kinds
	in update_window_end_hook and draw_window_cursor functions.
	(display_and_set_cursor, x_update_cursor): Adjust prototypes.
	* nsterm.m (ns_update_window_end, ns_draw_window_cursor):
	* w32term.c (x_update_window_end,w32_draw_window_cursor):
	* xterm.c (x_update_window_end, x_draw_window_cursor):
	* xdisp.c (display_and_set_cursor, update_window_cursor)
	(update_cursor_in_window_tree, x_update_cursor): Use bool and
	enum text_cursor_kinds where appropriate.

1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop updated_row and updated_area.
	* dispextern.h (updated_row, updated_area): Remove declaration.
	(struct redisplay_interface): Pass glyph row and row area parameters
	to write_glyphs, insert_glyphs and clear_end_of_line functions.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust prototypes.
	* dispnew.c (updated_row, updated_area): Remove.
	(redraw_overlapped_rows, update_window_line): Adjust user.
	(update_marginal_area, update_text_area): Likewise.  Pass updated row
	as a parameter.  Prefer enum glyph_row_area to int where appropriate.
	* xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust users.

1415 1416 1417 1418 1419
2013-08-22  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (flush_pending_output): Remove stub.
	All uses removed.

1420 1421 1422 1423 1424 1425 1426 1427
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* callproc.c: Fix race that killed background processes (Bug#15144).
	(call_process): New arg TEMPFILE_INDEX.  Callers changed.
	Record deleted process-id in critical section, not afterwards.
	Don't mistakenly kill process created by a call-process invocation
	that discards output and does not wait.

1428 1429 1430 1431 1432 1433 1434 1435 1436
2013-08-21  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
	and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
	* alloc.c (toplevel): Remove unnecessary nested #if...#endif.
	(mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
	to shut up compiler in mark_object.
	(dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.

1437 1438 1439 1440 1441 1442
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
	We can't portably rely on PTY_OPEN doing that, even if
	it calls posix_openpt with O_CLOEXEC.

1443 1444 1445 1446
2013-08-20  Kenichi Handa  <handa@gnu.org>

	* character.c (string_char): Improve commentary.

1447 1448 1449 1450 1451 1452 1453
2013-08-20  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (SIGNATURE_DIGESTSIZE): Remove.
	(struct animation_cache): Make signature a flexible array member.
	All uses changed.  This is a tad slower but may insulate us better
	from future changes to ImageMagick.

1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c: Shrink memory needed for animation cache.
	(SIGNATURE_DIGESTSIZE): New constant.
	(struct animation_cache): Make 'signature' a fixed size array of bytes.
	(imagemagick_create_cache): Copy the signature.  This saves
	several KB of memory that ImageMagick wastes per signature.
	Don't bother updating the update_time, as the caller does that now.
	(imagemagick_prune_animation_cache): Don't destroy the signature, as
	it's a fixed size struct member now.
	(imagemagick_get_animation_cache): Always destroy the signature,
	as it's now imagemagick_create_cache's responsibility to copy it.
	Avoid duplicate calls to strcmp and to imagemagick_create_cache,
	and use memcmp rather than strcmp.
	eassert that ImageMagick returns a signature of the specified length.

1470 1471 1472 1473
2013-08-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault on
	each invocation.
1474 1475 1476
	(imagemagick_get_animation_cache): Revert to previous definition
	so that it actually works.  But keep the memory leak fix.
	(imagemagick_get_animation_cache): Fix memory leak.
1477

1478 1479
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490
	* image.c: Fix animation cache signature memory leak.
	Fix some other minor performance problems while we're at it.
	(imagemagick_create_cache): Clear just the members that
	need clearing.  Don't set update_time, as caller does that now.
	(imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
	Simplify by using pointer-to-pointer instead of a prev pointer.
	(imagemagick_prune_animation_cache): Use make_emacs_time rather
	than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
	(imagemagick_get_animation_cache): Don't xstrdup the image signature;
	it's already a copy.  Free the signature probe unless it's cached.

1491 1492 1493
	* process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
	This was introduced by my 2013-08-12 fix for Bug#15035.

1494 1495 1496 1497 1498
2013-08-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
	(imagemagick_prune_animation_cache): Now static.

1499 1500 1501 1502 1503
2013-08-18  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault when
	pruning all entries.

1504 1505 1506 1507 1508 1509 1510 1511 1512
2013-08-18  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
	static heap if ENABLE_CHECKING is defined.
	(max_bss_sbrk_ptr): New variable.
	(bss_sbrk): Use it.
	(report_sheap_usage): Report maximum static heap usage instead of
	ending static heap usage.

1513 1514 1515 1516 1517 1518
2013-08-17  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
	of zlib_initialized according to the results of calling
	init_zlib_functions.

1519 1520 1521
2013-08-16  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c: Implement an ImageMagick per-image cache.
1522
	(imagemagick_get_animation_cache): Fix a double-free error.
1523 1524 1525
	(imagemagick_load_image): Remove the ping_wand code, which only
	apparently saved time on invalid animated images, and slowed down
	everything else.  Optimise for the common case.
1526

1527 1528
2013-08-16  Xue Fuqiao  <xfq.free@gmail.com>

1529 1530
	* buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.

1531 1532
	* editfns.c (insert_before_markers): Mention overlay in the doc string.

1533 1534
	* marker.c (set_marker): Remove documentation of undefined behavior.

1535 1536 1537 1538
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Animate correctly
	when sub-images are smaller than the main image.
1539 1540
	(imagemagick_compute_animated_image): Setting the iterator row to
	zero is apparently not allowed.
1541 1542 1543
	(imagemagick_compute_animated_image): Allow images that say they
	have sub-images that are bigger than the main image, but just crop
	them.
1544

1545 1546 1547 1548
2013-08-15  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).

1549 1550 1551 1552 1553
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Respect the GIF
	disposal methods.

1554 1555 1556 1557 1558 1559
2013-08-15  Ken Brown  <kbrown@cornell.edu>

	* emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
	* gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
	needed.

1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570
2013-08-15  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* frame.c (delete_frame):
	* xdisp.c (next_element_from_display_vector):
	Avoid uninitialized local.
	* image.c (imagemagick_compute_animated_image): Port to C89.
	Prefer usual GNU indentation style for loops.
	Be more careful about bizarrely large sizes, by using ptrdiff_t
	instead of int.

1571 1572 1573 1574 1575
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix infinite frame selection loop (Bug#15025).
	* frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.

1576 1577
2013-08-15  Eli Zaretskii  <eliz@gnu.org>

1578 1579
	* xdisp.c (compute_window_start_on_continuation_line):
	When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
1580 1581 1582 1583
	to make sure we end up setting the window start at the leftmost
	visible character of the display line.  This avoids funky
	horizontal shifting because the window start is not kept on the
	same position.  (Bug#15090)
1584 1585
	(next_element_from_display_vector): Support 'box' face attribute
	in the face definitions of a display vector.  (Bug#15099)
1586

1587 1588 1589 1590
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Implement animated
	images (bug#14700).
1591 1592 1593
	(imagemagick_compute_animated_image): Fix some compilation
	warnings.  Implement a very simple cache to make the animation
	usable at all, but it should be replaced with a per-image cache.
1594

1595 1596 1597 1598 1599 1600 1601 1602 1603
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (FOR_EACH_ALIST_VALUE): New macro
	to do `for' loops over alist values.
	* buffer.h (FOR_EACH_BUFFER):
	* process.c (FOR_EACH_PROCESS): Use it.
	(handle_child_signal, status_notify, Fget_buffer_process)
	(kill_buffer_processes): Use FOR_EACH_PROCESS.

1604 1605 1606 1607 1608 1609 1610 1611 1612
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
	(tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
	* image.c (make_image_cache): For struct image_cache, prefer xmalloc
	to xzalloc and so avoid redundant call to memset.
	* xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
	members because it is allocated with xzalloc and so already zeroed.

1613 1614 1615 1616 1617
2013-08-14  Ken Brown  <kbrown@cornell.edu>

	* gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
	(Bug#15094).

1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Utility function and macro to copy Lisp string to C string.
	* lisp.h (xlispstrdupa): New macro.
	(xlispstrdup): New prototype.
	* alloc.c (xlispstrdup): New function.
	* callint.c (Fcall_interactively):
	* fileio.c (Ffile_name_directory, Fexpand_file_name)
	(Fsubstitute_in_file_name):
	* frame.c (Fmake_terminal_frame): Use xlispstrdupa.
	* image.c (x_create_bitmap_from_file):
	* w32term.c (w32_term_init):
	* xterm.c (x_term_init): Use xlispstrdup.

1632 1633
2013-08-14  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1634 1635 1636 1637
	* image.c (imagemagick_load_image): Make animated pictures work.
	There's still some problems with background color settings, though
	(bug#14700).

1638 1639
	* decompress.c (unwind_decompress): Always restore point.

1640