ChangeLog 67.3 KB
Newer Older
1 2 3 4
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>

	* editfns.c (Fformat): Remove unreachable code.

Paul Eggert's avatar
Paul Eggert committed
5
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>
6

7 8
	Fix more problems found by GCC 4.6.0's static checks.

9 10
	* xdisp.c (vmessage): Use a better test for character truncation.

11 12
	* charset.c (load_charset_map): <, not <=, for optimization,
	and to avoid potential problems with integer overflow.
13
	* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
14
	* casetab.c (set_identity, shuffle): Likewise.
Paul Eggert's avatar
Paul Eggert committed
15
	* editfns.c (Fformat): Likewise.
16
	* syntax.c (skip_chars): Likewise.
17

18 19 20
	* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
	This also lets GCC 4.6.0 generate slightly better loop code.

21 22 23 24 25
	* callint.c (Fcall_interactively): <, not <=, for optimization.
	(Fcall_interactively): Count the number of arguments produced,
	not the number of arguments given.  This is simpler and lets GCC
	4.6.0 generate slightly better code.

26 27 28 29 30 31 32 33
	* ftfont.c: Distingish more carefully between FcChar8 and char.
	The previous code passed unsigned char * to a functions like
	strlen and xstrcasecmp that expect char *, which does not
	conform to the C standard.
	(get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
	arguments to FcPatternGetString, and explicitly cast FcChar8 * to
	char * when the C standard requires it.

34 35
	* keyboard.c (read_char): Remove unused var.

36 37 38 39 40 41 42 43 44
	* eval.c: Port to Windows vsnprintf (Bug#8435).
	Include <limits.h>.
	(SIZE_MAX): Define if the headers do not.
	(verror): Do not give up if vsnprintf returns a negative count.
	Instead, grow the buffer.  This ports to Windows vsnprintf, which
	does not conform to C99.  Problem reported by Eli Zaretskii.
	Also, simplify the allocation scheme, by avoiding the need for
	calling realloc, and removing the ALLOCATED variable.

45 46
	* eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

47 48 49
	Remove invocations of doprnt, as Emacs now uses vsnprintf.
	But keep the doprint source code for now, as we might revamp it
	and use it again (Bug#8435).
50 51 52 53
	* lisp.h (doprnt): Remove.
	* Makefile.in (base_obj): Remove doprnt.o.
	* deps.mk (doprnt.o): Remove.

54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
	error: Print 32- and 64-bit integers portably (Bug#8435).
	Without this change, on typical 64-bit hosts error ("...%d...", N)
	was used to print both 32- and 64-bit integers N, which relied on
	undefined behavior.
	* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
	New macro.
	* lisp.h (error, verror): Mark as printf-like functions.
	* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
	Report overflow in size calculations when allocating printf buffer.
	Do not truncate output string at its first null byte.
	* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
	Truncate the output at a character boundary, since vsnprintf does not
	do that.
	* charset.c (check_iso_charset_parameter): Convert internal
	character to string before calling 'error', since %c now has the
	printf meaning.
	* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
	overflow when computing char to be passed to 'error'.  Do not
	pass Lisp_Object to 'error'; pass the integer instead.
	* nsfns.m (Fns_do_applescript): Use int, not long, since it's
	formatted with plain %d.

76 77
	* eval.c (internal_lisp_condition_case): Don't pass spurious arg.

78 79
	* keyboard.c (access_keymap_keyremap): Print func name, not garbage.

80 81
	* coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

82 83
	* xterm.c (x_catch_errors): Remove duplicate declaration.

84 85
	* term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

86 87
	* xdisp.c, lisp.h (message_nolog): Remove; unused.

88 89 90 91 92 93 94 95 96 97
2011-04-10  Jim Meyering  <meyering@redhat.com>

	use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
	* gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
	return ssize_t not "int", and use size_t as the buffer length.
	(emacs_gnutls_write): Likewise, and make the buffer pointer "const".
	* gnutls.h: Update declarations.
	* process.c (read_process_output): Use ssize_t, to match.
	(send_process): Likewise.

98 99 100 101
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

	* image.c (Fimagemagick_types): Doc fix, and comment cleanup.

102
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>
103

104 105
	* ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
	unsigned char, to match FcChar8 type definition.
106

107 108 109 110
	* xterm.c (handle_one_xevent):
	* xmenu.c (create_and_show_popup_menu):
	* xselect.c (x_decline_selection_request)
	(x_reply_selection_request): Avoid type-punned deref of X events.
111

112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152
2011-04-09  Eli Zaretskii  <eliz@emacstest.gnu.org>

	Fix some uses of `int' instead of EMACS_INT.
	* search.c (string_match_1, fast_string_match)
	(fast_c_string_match_ignore_case, fast_string_match_ignore_case)
	(scan_buffer, find_next_newline_no_quit)
	(find_before_next_newline, search_command, Freplace_match)
	(Fmatch_data): Make some `int' variables be EMACS_INT.

	* xdisp.c (display_count_lines): 3rd argument and return value now
	EMACS_INT.  All callers changed.
	(pint2hrstr): Last argument is now EMACS_INT.

	* coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
	(detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
	(decode_coding_utf_16, decode_coding_emacs_mule)
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
	(decode_coding_ccl, decode_coding_charset)
	<consumed_chars, consumed_chars_base>: Declare EMACS_INT.
	(decode_coding_iso_2022, decode_coding_emacs_mule)
	(decode_coding_sjis, decode_coding_big5, decode_coding_charset)
	<char_offset, last_offset>: Declare EMACS_INT.
	(encode_coding_utf_8, encode_coding_utf_16)
	(encode_coding_emacs_mule, encode_invocation_designation)
	(encode_designation_at_bol, encode_coding_iso_2022)
	(encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
	(encode_coding_raw_text, encode_coding_charset) <produced_chars>:
	Declare EMACS_INT.
	(ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
	(encode_invocation_designation): Last argument P_NCHARS is now
	EMACS_INT.
	(decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
	(produce_chars): from_nchars and to_nchars are now EMACS_INT.

	* coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
	All users changed.

	* ccl.c (Fccl_execute_on_string): Declare some variables
	EMACS_INT.

153
2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)
154 155 156

	* term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

157 158 159 160
2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

	* process.c (Fformat_network_address): Doc fix.

161 162 163 164
2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

	* xml.c (parse_region): Avoid creating spurious whiespace nodes.

165 166 167 168 169
2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (read_char): Call Lisp function help-form-show,
	instead of using internal_with_output_to_temp_buffer.
	(Qhelp_form_show): New var.
170
	(syms_of_keyboard): Use DEFSYM macro.
171 172 173 174 175

	* print.c (internal_with_output_to_temp_buffer): Function deleted.

	* lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

176 177 178 179 180
2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (Flist_processes): Removed to Lisp.
	(list_processes_1): Deleted.

181 182
2011-04-06  Eli Zaretskii  <eliz@gnu.org>

183 184
	* msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

185 186
	* w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

187
2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
188

Paul Eggert's avatar
Paul Eggert committed
189 190
	Fix more problems found by GCC 4.6.0's static checks.

191 192
	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

193 194
	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

195
	* lisp.h (message, message_nolog, fatal): Mark as printf-like.
196

197 198
	* xdisp.c (vmessage): Mark as a printf-like function.

199 200
	* term.c (vfatal, maybe_fatal): Mark as printf-like functions.

201 202
	* sound.c (sound_warning): Don't crash if arg contains a printf format.

203 204 205 206 207
	* image.c (tiff_error_handler, tiff_warning_handler): Mark as
	printf-like functions.
	(tiff_load): Add casts to remove these marks before passing them
	to system-supplied API.

208 209
	* eval.c (Fsignal): Remove excess argument to 'fatal'.

210 211
	* coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
	This avoids several warnings with gcc -Wstrict-overflow.
212 213 214 215 216 217
	(DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
	directly, rather than having caller test rule sign.  This avoids
	some unnecessary tests.
	* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
	(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
	affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
218

219
	* xfont.c (xfont_text_extents): Remove var that was set but not used.
220
	(xfont_open): Avoid unnecessary tests.
221

222 223
	* composite.c (composition_gstring_put_cache): Use unsigned integer.

224 225 226
	* composite.h, composite.c (composition_gstring_put_cache):
	Use EMACS_INT, not int, for length.

227 228 229 230 231 232
	* composite.h (COMPOSITION_DECODE_REFS): New macro,
	breaking out part of COMPOSITION_DECODE_RULE.
	(COMPOSITION_DECODE_RULE): Use it.
	* composite.c (get_composition_id): Remove unused local vars,
	by using the new macro.

233 234 235
	* textprop.c (set_text_properties_1): Change while to do-while,
	since the condition is always true at first.

236
	* intervals.c (graft_intervals_into_buffer): Mark var as used.
237 238
	(interval_deletion_adjustment): Return unsigned value.
	All uses changed.
239

240 241
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
242
	(create_pty): Remove unnecessary "volatile"s.
243
	(Fnetwork_interface_info): Avoid possibility of int overflow.
244
	(read_process_output): Do adaptive read buffering even if carryover.
245
	(read_process_output): Simplify nbytes computation if buffered.
246

247 248
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

249
	* syntax.c (scan_words): Remove var that was set but not used.
250
	(update_syntax_table): Use unsigned instead of int.
251

252
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
253
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
254
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
255

256 257
	* print.c (print_error_message): Avoid int overflow.

258 259 260
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

261
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
262
	(font_score): Avoid potential overflow in diff calculation.
263

264
	* fns.c (substring_both): Remove var that is set but not used.
265
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
266

267 268
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

269 270 271 272
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

273
	* search.c (boyer_moore, wordify): Remove vars set but not used.
274
	(wordify): Omit three unnecessary tests.
275

276 277 278
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

279 280
	* casefiddle.c (casify_region): Remove var that is set but not used.

281 282
	* dired.c (file_name_completion): Remove var that is set but not used.

283 284
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

285
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
286
	(Finsert_file_contents): Remove unnecessary code checking fd.
287

288 289 290
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

291 292 293
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

294 295
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
296
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
297
	(timer_check_2): Mark vars as initialized.
298

299 300
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

301
	* image.c (lookup_image): Remove var that is set but not used.
302
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
303

304 305 306
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

307
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
308
	if XCreateBitmapFromData fails (Bug#8410).
309

310 311 312
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

313
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
314
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
315

316 317
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
318 319 320
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
321

322 323 324
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

325 326
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

327 328 329 330 331 332 333
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

334 335 336
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

337 338
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
339
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
340 341 342 343 344 345 346 347
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
348 349
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
350

351 352 353 354 355
2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
	first non-nil return value).

356 357 358 359 360
2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
	if not defined (Bug#8403).

361 362 363 364 365 366 367 368 369 370 371 372
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (display_count_lines): Remove parameter `start',
	unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(get_char_face_and_encoding): Remove parameter `multibyte_p',
	unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
	(fill_stretch_glyph_string): Remove parameters `row' and `area',
	unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
	and thereabouts.  All callers changed.
	(get_per_char_metric): Remove parameter `f', unused since
	2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

373 374 375 376 377 378
2011-04-02  Jim Meyering  <meyering@redhat.com>

	do not dereference NULL upon failed strdup
	* nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
	(ns_get_family): Likewise.

379 380 381 382
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

383 384 385 386 387
2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
	later (Bug#8403).

388 389
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

390
	Add lexical binding.
391

392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
409 410 411

	* image.c (parse_image_spec): Use Ffunctionp.

412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429
	* fns.c (concat, mapcar1): Accept byte-code-functions.

	* eval.c (Fsetq): Handle lexical vars.
	(Fdefun, Fdefmacro, Ffunction): Make closures when needed.
	(Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
	(FletX, Flet): Obey lexical binding.
	(Fcommandp): Handle closures.
	(Feval): New `lexical' arg.
	(eval_sub): New function extracted from Feval.  Use it almost
	everywhere where Feval was used.  Look up vars in lexical env.
	Handle closures.
	(Ffunctionp): Move from subr.el.
	(Ffuncall): Handle closures.
	(apply_lambda): Remove `eval_flags'.
	(funcall_lambda): Handle closures and new byte-code-functions.
	(Fspecial_variable_p): New function.
	(syms_of_eval): Initialize the Vinternal_interpreter_environment var,
	but without exporting it to Lisp.
430 431

	* doc.c (Fdocumentation, store_function_docstring):
432
	* data.c (Finteractive_form): Handle closures.
433

434 435
	* callint.c (Fcall_interactively): Preserve lexical-binding mode for
	interactive spec.
436

437 438 439 440
	* bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
	byte-codes.
	(exec_byte_code): New function extracted from Fbyte_code to handle new
	calling convention for byte-code-functions.  Add new byte-codes.
441

442
	* buffer.c (defvar_per_buffer): Set new `declared_special' field.
443

444
	* alloc.c (Fmake_symbol): Init new `declared_special' field.
445

446 447 448 449
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (redisplay_internal): Fix prototype.

450
2011-03-31  Eli Zaretskii  <eliz@gnu.org>
451

452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468
	* xdisp.c (SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.  Limit
	scrolling to 100 screen lines.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

	(try_scrolling): When point is above the window, allow searching
	as far as scroll_max, or one screenful, to compute vertical
	distance from PT to the scroll margin position.  This prevents
	try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.  Clean up the case of PT below the margin at bottom
	of window: scroll_max can no longer be INT_MAX.  When aggressive
	scrolling is in use, don't let point enter the opposite scroll
	margin as result of the scroll.
	(syms_of_xdisp) <scroll-conservatively>: Document the
469 470
	threshold of 100 lines for never-recentering scrolling.

471 472 473 474 475 476 477 478 479 480 481 482 483 484
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (move_it_by_lines):
	* xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
	since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
	(message_log_check_duplicate): Remove parameters `prev_bol' and
	`this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(redisplay_internal): Remove parameter `preserve_echo_area',
	unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

	* indent.c (Fvertical_motion):
	* window.c (window_scroll_pixel_based, Frecenter):
	Don't pass `need_y_p' to `move_it_by_lines'.

485 486
2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

487 488 489 490 491
	* eval.c (struct backtrace): Don't cheat with negative numbers, but do
	steal a few bits to be more compact.
	(interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
	Remove unneeded casts.

492 493
	* bytecode.c (Fbyte_code): CAR and CDR can GC.

494 495 496 497 498
2011-03-30  Zachary Kanfer  <zkanfer@gmail.com>  (tiny change)

	* keyboard.c (Fexecute_extended_command): Do log the "suggest key
	binding" message (bug#7967).

499 500
2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>

501 502
	Fix more problems found by GCC 4.6.0's static checks.

503 504 505
	* unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
	Remove unused local var.

506 507
	* editfns.c (Fmessage_box): Remove unused local var.

508 509 510
	* xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Omit unused local vars.
511
	* window.c (shrink_windows): Omit unused local var.
512
	* menu.c (digest_single_submenu): Omit unused local var.
513 514 515
	* dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
	Omit unused local var.

516 517
	* keyboard.c (parse_modifiers_uncached, parse_modifiers):
	Don't assume string length fits in int.
518
	(keyremap_step, read_key_sequence): Use size_t for sizes.
519
	(read_key_sequence): Don't check last_real_key_start redundantly.
520

521 522 523
	* callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
	instead of alloca (Bug#8344).

524
	* eval.c (Fbacktrace): Don't assume nargs fits in int.
525
	(Fbacktrace_frame): Don't assume nframes fits in int.
526

527 528
	* syntax.c (scan_sexps_forward): Avoid pointer wraparound.

Paul Eggert's avatar
Paul Eggert committed
529 530 531 532 533 534
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

	* term.c (produce_glyphless_glyph): Remove unnecessary test.

	* cm.c (calccost): Turn while-do into do-while, for clarity.
535

536 537 538 539
	* keyboard.c (syms_of_keyboard): Use the same style as later
	in this function when indexing through an array.  This also
	works around GCC bug 48267.

540 541
	* image.c (tiff_load): Fix off-by-one image count (Bug#8336).

542 543
	* xselect.c (x_check_property_data): Return correct size (Bug#8335).

544 545 546
	* chartab.c (sub_char_table_ref_and_range): Redo for slight
	efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

547 548 549 550
	* keyboard.c, keyboard.h (num_input_events): Now size_t.
	This avoids undefined behavior on integer overflow, and is a bit
	more convenient anyway since it is compared to a size_t variable.

551 552 553 554 555
	Variadic C functions now count arguments with size_t, not int.
	This avoids an unnecessary limitation on 64-bit machines, which
	caused (substring ...) to crash on large vectors (Bug#8344).
	* lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
556
	All variadic functions and their callers changed accordingly.
557 558 559 560 561 562 563 564 565 566 567
	(struct gcpro.nvars): Now size_t, not int.  All uses changed.
	* data.c (arith_driver, float_arith_driver): Likewise.
	* editfns.c (general_insert_function): Likewise.
	* eval.c (struct backtrace.nargs, interactive_p)
	(internal_condition_case_n, run_hook_with_args, apply_lambda)
	(funcall_lambda, mark_backtrace): Likewise.
	* fns.c (concat): Likewise.
	* frame.c (x_set_frame_parameters): Likewise.
	* fns.c (get_key_arg): Now accepts and returns size_t, and returns
	0 if not found, not -1.  All callers changed.

568 569 570 571
	* alloc.c (garbage_collect): Don't assume stack size fits in int.
	(stack_copy_size): Now size_t, not int.
	(stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
	unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	All callers changed.

	* lisp.h (multibyte_char_to_unibyte):
	* character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
	unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	* character.h (CHAR_TO_BYTE8):
	* cmds.c (internal_self_insert):
	* editfns.c (general_insert_function):
	* keymap.c (push_key_description):
	* search.c (Freplace_match):
	* xdisp.c (message_dolog, set_message_1): All callers changed.

588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604
2011-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): New function.
	(safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
	don't set the hook to nil, but remove the offending function instead.
	(Qcommand_hook_internal): Remove, unused.
	(syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
	Vcommand_hook_internal.

	* eval.c (enum run_hooks_condition): Remove.
	(funcall_nil, funcall_not): New functions.
	(run_hook_with_args): Call each function through a `funcall' argument.
	Remove `cond' argument, now redundant.
	(Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
	(Frun_hook_with_args_until_failure): Adjust accordingly.
	(run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.

605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (string_buffer_position): Remove declaration.

	* print.c (strout): Remove parameter `multibyte', unused since
	1999-08-21T19:30:21Z!gerd@gnu.org.  All callers changed.

	* search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
	never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
	All callers changed.

	* w32.c (_wsa_errlist): Use braces for struct initializers.

	* xdisp.c (string_buffer_position_lim): Remove parameter `w',
	never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
	All callers changed.
	(string_buffer_position): Likewise.  Also, make static (it's never
	used outside xdisp.c).
	(cursor_row_p): Remove parameter `w', unused since
	2000-10-17T16:08:57Z!gerd@gnu.org.  All callers changed.
	(decode_mode_spec): Remove parameter `precision', introduced during
	Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
	All callers changed.

629 630 631 632
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.

633
2011-03-27  Anders Lindgren  <andlind@gmail.com>
634 635 636 637 638 639 640 641 642 643

	* nsterm.m (ns_menu_bar_is_hidden): New variable.
	(ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
	(ns_update_auto_hide_menu_bar): New functions.
	(ns_update_begin): Call ns_update_auto_hide_menu_bar.
	(applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
	ns_constrain_all_frames.
	(constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
	(syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.

644 645 646 647
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (runDialogAt): Remove argument to timer_check.

648 649 650 651 652 653 654 655 656
2011-03-27  Glenn Morris  <rgm@gnu.org>

	* syssignal.h: Replace RETSIGTYPE with void.
	* atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
	* keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
	Replace SIGTYPE with void everywhere.
	* s/usg5-4-common.h (SIGTYPE): Remove definition.
	* s/template.h (SIGTYPE): Remove commented out definition.

657 658 659 660 661
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

662 663
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

664 665 666 667 668 669 670
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

692 693 694 695 696
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

697 698 699 700 701 702 703 704
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

736 737 738 739 740
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
778
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
779 780
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
781
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
782

783 784
	Fix more problems found by GCC 4.5.2's static checks.

785 786 787 788
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

789 790 791
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
792
	of objects (Bug#8318).
793

794 795 796
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

797 798 799 800
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
801 802
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
803

804 805 806
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

807 808
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
809 810
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
811

Paul Eggert's avatar
Paul Eggert committed
812 813
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
814

Paul Eggert's avatar
Paul Eggert committed
815
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
816

817 818 819
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
820
	socklen_t is wider than int (Bug#8277).
821 822 823 824
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

825 826 827 828
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
829
	(Fmake_network_process): Define label "retry_connect" only if needed.
830
	(Fnetwork_interface_info): Fix pointer signedness.
831
	(process_send_signal): Add cast to avoid pointer signedness problem.
832
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
833
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
834

835
	Make tparam.h and terminfo.c consistent.
836 837
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.
	Include tparam.h instead, since it declares them.
838 839 840 841 842 843 844 845 846
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

847
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
848
	(xftfont_open): Rename locals to avoid shadowing.
849

850
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
851 852
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
853
	(ftfont_list): Remove unused local.
854 855 856
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
857

858 859
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
860 861
	* xml.c (make_dom): Now static.

862 863
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
864 865
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
866
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
867 868
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
869

870 871 872 873 874 875 876
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

877 878
	* textprop.c (property_change_between_p): Remove; unused.

879 880
	* intervals.c (interval_start_pos): Now static.

881 882
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

883 884
	* atimer.c (start_atimer, append_atimer_lists, set_alarm):
	Rename locals to avoid shadowing.
885

886 887
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
888
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
889 890
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
891

892 893
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

894 895
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
896 897
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
898 899
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
900

901 902 903 904
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

905
	* callproc.c (call_process_cleanup): Now static.
906
	(relocate_fd): Rename locals to avoid shadowing.
907

908 909 910 911 912
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

913 914 915 916
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

917 918 919 920 921 922
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

923 924 925 926 927 928
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

929 930 931 932 933
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

934 935 936 937
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

938 939 940 941
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

942 943
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

944 945
	Fix more problems found by GCC 4.5.2's static checks.

946 947 948
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

949 950 951 952 953 954 955
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

956 957 958
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

959
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
960 961 962
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
963

964 965
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
966 967
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
968
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
969

970 971
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
972
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
973
	* unexec.h: New file.
974 975 976 977 978 979
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
980
	Change as necessary to match prototype in unexec.h.
981

982 983
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
984
	(back_comment, skip_chars): Mark vars as initialized.
985

986 987 988
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

989
	* lread.c (read1): Rewrite so as not to use empty "else".
990
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
991

992 993
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

994 995 996
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

997 998
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
999
	(font_sort_entities): Mark var as initialized.
1000

1001 1002
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

1003 1004
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
1005
	(font_parse_fcname): Remove unused vars.
1006
	(font_delete_unmatched): Now static.
1007
	(font_get_spec): Remove; unused.
1008 1009 1010
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
1011

1012
	* fns.c (require_nesting_list, require_unwind): Now static.
1013
	(Ffillarray): Rename locals to avoid shadowing.
1014

1015
	* floatfns.c (domain_error2): Define only if needed.
1016
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
1017

1018 1019 1020
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

1021
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1022
	(Fdefvar): Rewrite so as not to use empty "else".
1023 1024
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
1025
	(Fdefvar): Rename locals to avoid shadowing.
1026

1027
	* callint.c (quotify_arg, quotify_args): Now static.
1028
	(Fcall_interactively): Rename locals to avoid shadowing.
1029
	Use const pointer when appropriate.
1030

1031 1032 1033 1034
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
1035 1036 1037
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
1038 1039 1040
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
1041
	(Ftranslate_region_internal): Mark var as initialized.
1042

1043 1044 1045
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

1046 1047 1048
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

1049 1050
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
1051
	(default_value, arithcompare, arith_driver, arith_error): Now static.
1052
	(store_symval_forwarding): Rename local to avoid shadowing.
1053 1054
	(Fmake_variable_buffer_local, Fmake_local_variable):
	Mark variables as initialized.
1055
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
1056

1057
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1058 1059
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
1060 1061
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
1062 1063 1064 1065 1066
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
1067
	(Fmemory_limit): Cast sbrk's returned value to char *.
1068

1069 1070 1071
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

1072 1073
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

1074 1075 1076 1077 1078 1079 1080 1081
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
1082
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
1083
	the race-condition problem in the old DOWNCASE.
1084

1085 1086 1087
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1088 1089
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
1090 1091
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
1092
	(regex_compile, re_match_2_internal): Mark locals as initialized.
1093 1094 1095 1096 1097 1098 1099
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
1100

1101
	* search.c (boyer_moore): Rename locals to avoid shadowing.
1102 1103
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
1104