ChangeLog 379 KB
Newer Older
Paul Eggert's avatar
Paul Eggert committed
1
2011-11-18  Paul Eggert  <eggert@cs.ucla.edu>
2

Paul Eggert's avatar
Paul Eggert committed
3
	Fix integer width and related bugs (Bug#9874).
Paul Eggert's avatar
Paul Eggert committed
4
	* alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37
	(allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
	(string_bytes, check_sblock, allocate_string_data):
	(compact_small_strings, Fmake_bool_vector, make_string)
	(make_unibyte_string, make_multibyte_string)
	(make_string_from_bytes, make_specified_string)
	(allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
	(make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
	(mark_vectorlike):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(allocate_pseudovector):
	Use int, not EMACS_INT, where int is wide enough.
	(inhibit_garbage_collection, Fgarbage_collect):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
	int might not be wide enough.
	(bidi_cache_search, bidi_cache_find, bidi_init_it)
	(bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
	(bidi_at_paragraph_end, bidi_find_paragraph_start)
	(bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* buffer.c (copy_overlays, Fgenerate_new_buffer_name)
	(Fkill_buffer, Fset_buffer_major_mode)
	(advance_to_char_boundary, Fbuffer_swap_text)
	(Fset_buffer_multibyte, overlays_at, overlays_in)
	(overlay_touches_p, struct sortvec, record_overlay_string)
	(overlay_strings, recenter_overlay_lists)
	(adjust_overlays_for_insert, adjust_overlays_for_delete)
	(fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
	(Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
	(Foverlay_recenter, last_overlay_modification_hooks_used)
	(report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
Paul Eggert's avatar
Paul Eggert committed
38 39
	(validate_region): Omit unnecessary test for b <= e,
	since that's guaranteed by the previous test.
40 41 42 43 44 45 46
	(adjust_overlays_for_delete): Avoid pos + length overflow.
	(Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
	(report_overlay_modification):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
	Omit pointer cast, which isn't needed anyway, and doesn't work
	after the EMACS_INT -> ptrdiff_t change.
47 48 49 50 51 52
	(Fmove_overlay): Delete an evaporating overlay
	if it becomes empty after its bounds are adjusted to fit within
	its buffer.  Without this fix, in a nonempty buffer (let ((o
	(make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
	yields an empty overlay that has the evaporate property, which is
	not supposed to happen.  (Bug#9642)
53 54 55 56
	* buffer.h: Adjust decls to match defn changes elsewhere.
	(struct buffer_text, struct buffer):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Use EMACS_INT, not int, where int might not be wide enough.
57 58 59 60 61 62
	* bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
	not int, to avoid needless 32-bit limit on 64-bit hosts.
	(exec_byte_code): Use tighter memory-full test, one that checks
	for alloca overflow.  Don't compute the address of the object just
	before an array, as that's not portable.  Use EMACS_INT, not
	ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
	* callint.c (Fcall_interactively):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* callproc.c (call_process_kill, Fcall_process):
	Don't assume pid_t fits into an Emacs fixnum.
	(call_process_cleanup, Fcall_process, child_setup):
	Don't assume pid_t fits into int.
	(call_process_cleanup, Fcall_process, delete_temp_file)
	(Fcall_process_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fcall_process): Simplify handling of volatile integers.
	Use int, not EMACS_INT, where int will do.
	* casefiddle.c (casify_object, casify_region, operate_on_word)
	(Fupcase_word, Fdowncase_word, Fcapitalize_word):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(casify_object): Avoid integer overflow when overallocating buffer.
	* casetab.c (set_identity, shuffle): Prefer int to unsigned when
79
	either works.  Use lint_assume to convince GCC 4.6.1 that it's OK.
80 81 82 83 84 85 86
	* category.c (Fchar_category_set): Don't assume fixnum fits in int.
	* category.h (CATEGORYP): Don't assume arg is nonnegative.
	* ccl.c (GET_CCL_INT): Remove; no longer needed, since the
	integers are now checked earlier.  All uses replaced with XINT.
	(ccl_driver):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	For CCL_MapSingle, check that content and value are in int range.
87 88
	(ccl_driver, Fregister_code_conversion_map):
	Check that Vcode_version_map_vector is a vector.
89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108
	(resolve_symbol_ccl_program): Check that vector header is in range.
	Always copy the vector, so that we can check its contents reliably
	now rather than having to recheck each instruction as it's being
	executed.  Check that vector words fit in 'int'.
	(ccl_get_compiled_code, Fregister_ccl_program)
	(Fregister_code_conversion_map): Use ptrdiff_t, not int, for
	program indexes, to avoid needless 32-bit limit on 64-bit hosts.
	(Fccl_execute, Fccl_execute_on_string): Check that initial reg
	contents are in range.
	(Fccl_execute_on_string): Check that status is in range.
	* ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
	* character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
	Accept and return EMACS_INT, not int, because callers can pass values
	out of 'int' range.
	(c_string_width, strwidth, lisp_string_width, chars_in_text)
	(multibyte_chars_in_text, parse_str_as_multibyte)
	(str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
	(str_as_unibyte, str_to_unibyte, string_count_byte8)
	(string_escape_byte8, Fget_byte):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109
	(Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 111 112 113 114 115 116
	avoid mishandling large integers.
	* character.h: Adjust decls to match defn changes elsewhere.
	* charset.c (load_charset_map_from_file, find_charsets_in_text)
	(Ffind_charset_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(load_charset_map_from_file): Redo idx calculation to avoid overflow.
	(load_charset_map_from_vector, Fdefine_charset_internal):
117
	Don't assume fixnum fits in int.
118 119 120
	(load_charset_map_from_vector, Fmap_charset_chars):
	Remove now-unnecessary CHECK_NATNUMs.
	(Fdefine_charset_internal): Check ranges here, more carefully.
121 122 123 124 125 126 127 128 129 130 131 132
	Don't rely on undefined behavior with signed left shift overflow.
	Don't assume unsigned int fits into fixnum, or that fixnum fits
	into unsigned int.  Don't require max_code to be a valid fixnum;
	that's not true for gb10830 4-byte on a 32-bit host.  Allow
	invalid_code to be a cons, for the same reason.  Require code_offset
	to be a character.  Avoid int overflow if max_char is close
	to INT_MAX.
	(CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
	this is intended anyway and avoids some undefined behavior.
	(load_charset_map): Pass unsigned, not int, as 2nd arg of
	INDEX_TO_CODE_POINT, as that's what it expects.
	(Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 134 135 136 137 138 139
	* charset.h (DECODE_CHAR): Return int, not unsigned;
	this is what was intended anyway, and it avoids undefined behavior.
	(CHARSET_OFFSET): Remove unused macro, instead of fixing its
	integer-overflow issues.
	(ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
	Formerly, it returned EMACS_INT on 64-bit hosts in the common case
	where the argument is EMACS_INT, and this behavior is not intended.
140 141 142 143 144 145
	* chartab.c (Fmake_char_table, Fset_char_table_range)
	(uniprop_get_decoder, uniprop_get_encoder):
	Don't assume fixnum fits in int.
	* cmds.c (move_point): New function, that does the gist of
	Fforward_char and Fbackward_char, but does so while checking
	for integer overflow more accurately.
146
	(Fforward_char, Fbackward_char): Use it.
147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177
	(Fforward_line, Fend_of_line, internal_self_insert)
	(internal_self_insert):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Fix a FIXME, by checking for integer overflow when calculating
	target_clm and actual_clm.
	* coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
	(ASSURE_DESTINATION, coding_alloc_by_realloc)
	(coding_alloc_by_making_gap, alloc_destination)
	(detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
	(encode_coding_utf_16, detect_coding_emacs_mule)
	(decode_coding_emacs_mule, encode_coding_emacs_mule)
	(detect_coding_iso_2022, decode_coding_iso_2022)
	(encode_invocation_designation, encode_designation_at_bol)
	(encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
	(encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
	(encode_coding_ccl, encode_coding_raw_text)
	(detect_coding_charset, decode_coding_charset)
	(encode_coding_charset, detect_eol, decode_eol, produce_chars)
	(produce_composition, produce_charset, produce_annotation)
	(decode_coding, handle_composition_annotation)
	(handle_charset_annotation, consume_chars, decode_coding_gap)
	(decode_coding_object, encode_coding_object, detect_coding_system)
	(Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
	(code_convert_region, code_convert_string)
	(Fdefine_coding_system_internal):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
	(Fdefine_coding_system_internal):
	Don't assume fixnums fit in int.
	(decode_coding_gap, decode_coding_object, encode_coding_object)
Paul Eggert's avatar
Paul Eggert committed
178
	(Fread_coding_system, Fdetect_coding_region)
179 180
	(Funencodable_char_position, Fcheck_coding_systems_region)
	(get_translation, handle_composition_annotation, consume_chars):
181
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
Paul Eggert's avatar
Paul Eggert committed
182
	(consume_chars): Rewrite to not calculate an address outside buffer.
183
	(Ffind_operation_coding_system): NATNUMP can eval its arg twice.
184
	Don't access memory outside of the args array.
185
	(Fdefine_coding_system_internal): Check for charset-id overflow.
186 187
	(ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
	result of ENCODE_CHAR.
188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231
	* coding.h: Adjust decls to match defn changes elsewhere.
	(struct coding_system):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* composite.c (get_composition_id, find_composition)
	(run_composition_function, update_compositions)
	(compose_text, composition_gstring_put_cache)
	(composition_gstring_p, composition_gstring_width)
	(fill_gstring_header, fill_gstring_body, autocmp_chars)
	(composition_compute_stop_pos, composition_reseat_it)
	(composition_update_it, struct position_record)
	(find_automatic_composition, composition_adjust_point)
	(Fcomposition_get_gstring, Ffind_composition_internal):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(update_compositions):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* composite.h: Adjust decls to match defn changes elsewhere.
	(struct composition):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
	Do not attempt to compute the address of the object just before a
	buffer; this is not portable.
	(Faref, Faset):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Faset): Use int, not EMACS_INT, where int is wide enough.
	(Fstring_to_number): Don't assume fixnums fit in int.
	(Frem): Don't assume arg is nonnegative.
	* dbusbind.c (xd_append_arg): Check for integers out of range.
	(Fdbus_call_method): Don't overflow the timeout int.
	* dired.c (directory_files_internal, file_name_completion, scmp)
	(file_name_completion_stat):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(file_name_completion): Don't overflow matchcount.
	(file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
	* dispextern.h: Adjust decls to match defn changes elsewhere.
	(struct text_pos, struct glyph, struct bidi_saved_info)
	(struct bidi_string_data, struct bidi_it, struct composition_it)
	(struct it):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(struct display_pos, struct composition_it, struct it):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* dispnew.c (increment_matrix_positions)
	(increment_row_positions, mode_line_string)
	(marginal_area_string):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232
	(change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(duration_to_sec_usec): New function, to check for overflow better.
	(Fsleep_for, sit_for): Use it.
	* doc.c (get_doc_string, store_function_docstring):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(get_doc_string, Fsnarf_documentation):
	Use int, not EMACS_INT, where int is wide enough.
	(get_doc_string):
	Use SAFE_ALLOCA, not alloca.
	Check for overflow when converting EMACS_INT to off_t.
	* doprnt.c (doprnt):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
	Don't assume uid_t fits into fixnum.
	(buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
	(Ffield_string, Ffield_string_no_properties, Ffield_beginning)
	(Ffield_end, Fconstrain_to_field, Fline_beginning_position)
	(Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
	(general_insert_function)
	(Finsert_char, make_buffer_string, make_buffer_string_both)
	(update_buffer_properties, Fbuffer_substring)
	(Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
	(Fsubst_char_in_region, check_translation)
	(Ftranslate_region_internal, save_restriction_restore, Fformat)
	(transpose_markers, Ftranspose_regions):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(clip_to_bounds): Move to lisp.h as an inline function).
	(Fconstrain_to_field): Don't assume integers are nonnegative.
	(Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
	(Fsubst_char_in_region, Fsave_restriction):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Femacs_pid): Don't assume pid_t fits into fixnum.
	(lo_time): Use int, not EMACS_INT, when int suffices.
	(lisp_time_argument): Check for usec out of range.
	(Fencode_time): Don't assume fixnum fits in int.
268 269 270
	(Fuser_login_name, Fuser_full_name): Signal an error
	if a uid argument is out of range, rather than relying on
	undefined behavior.
271 272
	(Fformat_time_string): Remove now-unnecessary check.
	lisp_time_argument checks for out-of-range usec now.
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
	* emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
	(gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
	(PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
	(init_cmdargs, Fdump_emacs):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fkill_emacs): Don't assume fixnum fits in int; instead, take just
	the bottom (typically) 32 bits of the fixnum.
	* eval.c (specpdl_size, call_debugger):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(when_entered_debugger, Fbacktrace_debug):
	Don't assume fixnum can fit in int.
	(Fdefvaralias, Fdefvar): Do not attempt to compute the address of
	the object just before a buffer; this is not portable.
	(FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
	(grow_specpdl, unbind_to):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
	(grow_specpdl): Simplify allocation by using xpalloc.
291
	(Fprog1, Fprog2): Don't assume list length fits in int.  Simplify.
292 293 294 295 296 297 298 299 300 301 302 303 304
	* fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
	(Finsert_file_contents, Fwrite_region, Fdo_auto_save):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
	(a_write, e_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fcopy_file, non_regular_nbytes, read_non_regular)
	(Finsert_file_contents):
	Use int, not EMACS_INT, where int is wide enough.
	(READ_BUF_SIZE): Verify that it fits in int.
	(Finsert_file_contents): Check that counts are in proper range,
	rather than assuming fixnums fit into ptrdiff_t etc.
	Don't assume fixnums fit into int.
305
	* floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
Paul Eggert's avatar
Paul Eggert committed
306 307
	* fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
	(string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383
	(string_char_to_byte, string_byte_to_char)
	(string_make_multibyte, string_to_multibyte)
	(string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
	(Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
	(substring_both, Fdelete, internal_equal, Ffillarray)
	(Fclear_string, mapcar1)
	(Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
	(Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
	(larger_vector, make_hash_table, maybe_resize_hash_table)
	(hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
	(Fmaphash, secure_hash):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(concat): Check for string index and length overflow.
	(Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
	(Frequire):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(larger_vector): New API (vec, incr_min, size_max) replaces old
	one (vec, new_size, init).  This catches size overflow.
	INIT was removed because it was always Qnil.
	All callers changed.
	(INDEX_SIZE_BOUND): New macro, which calculates more precisely
	the upper bound on a hash table index size.
	(make_hash_table, maybe_resize_hash_table): Use it.
	(secure_hash): Computer start_byte and end_byte only after
	they're known to be in ptrdiff_t range.
	* font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
	(Ffont_get_glyphs, Ffont_at):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(font_style_to_value, font_prop_validate_style, font_expand_wildcards)
	(Flist_fonts, Fopen_font):
	Don't assume fixnum can fit in int.
	(check_gstring): Don't assume index can fit in int.
	(font_match_p): Check that fixnum is a character, not a nonnegative
	fixnum, since the later code needs to stuff it into an int.
	(font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
	(font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
	conversion overflow issues.
	(Fopen_font): Check for integer out of  range.
	(Ffont_get_glyphs): Don't assume index can fit in int.
	* font.h: Adjust decls to match defn changes elsewhere.
	* fontset.c (reorder_font_vector): Redo score calculation to avoid
	integer overflow.
	(num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
	printmax_t, where ptrdiff_t is wide enough.
	(Finternal_char_font):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
	(Fset_frame_height, Fset_frame_width, Fset_frame_size)
	(Fset_frame_position, x_set_frame_parameters)
	(x_set_line_spacing, x_set_border_width)
	(x_set_internal_border_width, x_set_alpha, x_figure_window_size):
	Check that fixnums are in proper range for system types.
	(frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fmodify_frame_parameters): Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	* frame.h (struct frame): Use intptr_t, not EMACS_INT, where
	intptr_t is wide enough.
	* fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
	(Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
	(Ffringe_bitmaps_at_pos): Don't assume index fits in int.
	Check for fixnum out of range.
	* ftfont.c (ftfont_list): Don't assume index fits in int.
	Check that fixnums are in proper range for system types.
	(ftfont_shape_by_flt):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
	Check that fixnums are in proper range for system types.
	* gnutls.h: Adjust decls to match defn changes elsewhere.
	* gtkutil.c (xg_dialog_run):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(update_frame_tool_bar):
	Check that fixnums are in proper range for system types.
	* image.c (parse_image_spec): Redo count calculation to avoid overflow.
Paul Eggert's avatar
Paul Eggert committed
384
	(lookup_image): Check that fixnums are in range for system types.
385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497
	* indent.c (last_known_column, last_known_column_point):
	(current_column_bol_cache):
	(skip_invisible, current_column, check_display_width):
	(check_display_width, scan_for_column, current_column_1)
	(Findent_to, Fcurrent_indentation, position_indentation)
	(indented_beyond_p, Fmove_to_column, compute_motion):
	(Fcompute_motion, Fvertical_motion):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(last_known_column_modified): Use EMACS_INT, not int.
	(check_display_width):
	(Fcompute_motion):
	Check that fixnums and floats are in proper range for system types.
	(compute_motion): Don't assume index or fixnum fits in int.
	(compute_motion, Fcompute_motion):
	Use int, not EMACS_INT, when it is wide enough.
	(vmotion): Omit local var start_hpos that is always 0; that way
	we don't need to worry about overflow in expressions involving it.
	* indent.h: Adjust decls to match defn changes elsewhere.
	(struct position):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Use int, not EMACS_INT, where int is wide enough.
	Remove unused members ovstring_chars_done and tab_offset;
	all uses removed.
	* insdel.c (move_gap, move_gap_both, gap_left, gap_right)
	(adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
	(adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
	(make_gap, copy_text, insert, insert_and_inherit)
	(insert_before_markers, insert_before_markers_and_inherit)
	(insert_1, count_combining_before, count_combining_after)
	(insert_1_both, insert_from_string)
	(insert_from_string_before_markers, insert_from_string_1)
	(insert_from_gap, insert_from_buffer, insert_from_buffer_1)
	(adjust_after_replace, adjust_after_insert, replace_range)
	(replace_range_2, del_range, del_range_1, del_range_byte)
	(del_range_both, del_range_2, modify_region)
	(prepare_to_modify_buffer, signal_before_change)
	(signal_after_change, Fcombine_after_change_execute):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* intervals.c (traverse_intervals, rotate_right, rotate_left)
	(balance_an_interval, split_interval_right, split_interval_left)
	(find_interval, next_interval, update_interval)
	(adjust_intervals_for_insertion, delete_node, delete_interval)
	(interval_deletion_adjustment, adjust_intervals_for_deletion)
	(static_offset_intervals, offset_intervals)
	(merge_interval_right, merge_interval_left, make_new_interval)
	(graft_intervals_into_buffer, temp_set_point_both)
	(temp_set_point, set_point, adjust_for_invis_intang)
	(set_point_both, move_if_not_intangible, get_property_and_range)
	(get_local_map, copy_intervals, copy_intervals_to_string)
	(compare_string_intervals, set_intervals_multibyte_1):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* intervals.h: Adjust decls to match defn changes elsewhere.
	(struct interval):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* keyboard.c (this_command_key_count, this_single_command_key_start)
	(before_command_key_count, before_command_echo_length, echo_now)
	(echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
	(command_loop_1, safe_run_hooks, read_char, timer_check_2)
	(menu_item_eval_property, read_key_sequence, Fread_key_sequence)
	(Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(last_non_minibuf_size, last_point_position, echo_truncate)
	(command_loop_1, adjust_point_for_property, read_char, gen_help_event)
	(make_lispy_position, make_lispy_event, parse_modifiers_uncached)
	(parse_modifiers, modify_event_symbol, Fexecute_extended_command)
	(stuff_buffered_input):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(last_auto_save, command_loop_1, read_char):
	Use EMACS_INT, not int, to avoid integer overflow.
	(record_char): Avoid overflow in total_keys computation.
	(parse_modifiers_uncached): Redo index calculation to avoid overflow.
	* keyboard.h: Adjust decls to match defn changes elsewhere.
	* keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
	(Fkey_description, Fdescribe_vector, Flookup_key):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(click_position): New function, to check that positions are in range.
	(Fcurrent_active_maps):
	(describe_command):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Faccessible_keymaps, Fkey_description):
	(preferred_sequence_p):
	Don't assume fixnum can fit into int.
	(Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
	Check for integer overflow in size calculations.
	(Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
	avoid mishandling large integers.
	* lisp.h: Adjust decls to match defn changes elsewhere.
	(ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
	(struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
	(struct Lisp_Marker):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(clip_to_bounds): Now an inline function, moved here from editfns.c.
	(GLYPH_CODE_P): Check for overflow in system types, subsuming the
	need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
	All callers changed.
	(GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
	Assume the arg has valid form, since it always does.
	(TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
	unsigned integer system type.
	(CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
	(struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
	(duration_to_sec_usec): New decl.
	* lread.c (read_from_string_index, read_from_string_index_byte)
	(read_from_string_limit, readchar, unreadchar, openp)
	(read_internal_start, read1, oblookup):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fload, readevalloop, Feval_buffer, Feval_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(openp): Check for out-of-range argument to 'access'.
	(read1): Use int, not EMACS_INT, where int is wide enough.
	Don't assume fixnum fits into int.
498
	Fix off-by-one error that can read outside a buffer.
499 500
	(read_filtered_event): Use duration_to_sec_usec
	to do proper overflow checking on durations.
501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
	* macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
	in size calculation.
	(Fexecute_kbd_macro):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* marker.c (cached_charpos, cached_bytepos, CONSIDER)
	(byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
	(buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
	(set_marker_both, set_marker_restricted_both, marker_position)
	(marker_byte_position, Fbuffer_has_markers_at):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
	* menu.c (ensure_menu_items): Renamed from grow_menu_items.
	It now merely ensures that the menu is large enough, without
	necessarily growing it, as this avoids some integer overflow issues.
	All callers changed.
	(keymap_panes, parse_single_submenu, Fx_popup_menu):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	(find_and_return_menu_selection): Avoid unnecessary casts of pointers
	to EMACS_INT.  Check that fixnums are in proper range for system types.
	* minibuf.c (minibuf_prompt_width, string_to_object)
	(Fminibuffer_contents, Fminibuffer_contents_no_properties)
	(Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(get_minibuffer, read_minibuf_unwind):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
	this simplifies overflow checking.  All callers changed.
	(read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
	(Ftest_completion):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
	(x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
	Check that fixnums are in proper range for system types.
	(Fx_create_frame, Fx_show_tip):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* nsfont.m (ns_findfonts, nsfont_list_family):
	Don't assume fixnum fits in long.
	* nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
	wide enough.
544
	* nsselect.m (ns_get_local_selection, clean_local_selection_data):
545 546 547 548 549 550 551 552 553 554 555 556
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
	(PRINTDECLARE, PRINTPREPARE):
	(strout, print_string):
	(print, print_preprocess, print_check_string_charset_prop)
	(print_object):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(PRINTDECLARE):
	(temp_output_buffer_setup, Fprin1_to_string, print_object):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
	(printchar, strout): Use xpalloc to catch size calculation overflow.
557
	(Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
558 559 560 561 562
	(print_error_message): Use SAFE_ALLOCA, not alloca.
	(print_object): Use int, not EMACS_INT, where int is wide enough.
	* process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
	(Fset_process_window_size, Fformat_network_address)
	(get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
563
	(sigchld_handler):
564
	Check that fixnums are in proper range for system types.
565
	(Fsignal_process): Simplify by avoiding a goto.
566 567
	Check for process-ids out of pid_t range rather than relying on
	undefined behavior.
568 569 570 571 572 573 574 575 576
	(Fformat_network_address, read_process_output, send_process)
	(Fprocess_send_region, status_notify):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fformat_network_address, Fmake_serial_process, Fmake_network_process)
	(wait_reading_process_output, read_process_output, exec_sentinel):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
	(Faccept_process_output): Use duration_to_sec_usec to do proper
	overflow checking on durations.
577 578
	(emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
	Don't assume pid_t fits in int.
579 580
	* puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
	configured --with-wide-int.
581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603
	* scroll.c (calculate_scrolling, calculate_direct_scrolling)
	(line_ins_del): Use int, not EMACS_INT, where int is wide enough.
	* search.c (looking_at_1, string_match_1):
	(fast_string_match, fast_c_string_match_ignore_case)
	(fast_string_match_ignore_case, fast_looking_at, scan_buffer)
	(scan_newline, find_before_next_newline, search_command)
	(trivial_regexp_p, search_buffer, simple_search, boyer_moore)
	(set_search_regs, wordify):
	(Freplace_match):
	(Fmatch_data):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(string_match_1, search_buffer, set_search_regs):
	(Fmatch_data):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(wordify): Check for overflow in size calculation.
	(Freplace_match): Avoid potential buffer overflow in search_regs.start.
	(Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
	Check that fixnums are in proper range for system types.
	* sound.c (struct sound_device)
	(wav_play, au_play, vox_write, alsa_period_size, alsa_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fplay_sound_internal):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604
	* syntax.c (struct lisp_parse_state, find_start_modiff)
605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631
	(Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
	(Fparse_partial_sexp):
	Don't assume fixnums can fit in int.
	(struct lisp_parse_state, find_start_pos, find_start_value)
	(find_start_value_byte, find_start_begv)
	(update_syntax_table, char_quoted, dec_bytepos)
	(find_defun_start, prev_char_comend_first, back_comment):
	(scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
	(scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Finternal_describe_syntax_value): Check that match_lisp is a
	character, not an integer, since the code stuffs it into int.
	(scan_words, scan_sexps_forward):
	Check that fixnums are in proper range for system types.
	(Fforward_word):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(scan_sexps_forward):
	Use CHARACTERP, not INTEGERP, since the value must fit into int.
	(Fparse_partial_sexp): Fix doc; element 8 is not ignored.
	* syntax.h: Adjust decls to match defn changes elsewhere.
	(struct gl_state_s):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* sysdep.c (wait_for_termination_1, wait_for_termination)
	(interruptible_wait_for_termination, mkdir):
	Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
	(emacs_read, emacs_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 633
	(system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
	and double all fit in int.
634 635 636 637 638 639 640 641 642 643 644 645 646 647
	* term.c (set_tty_color_mode):
	Check that fixnums are in proper range for system types.
	* termhooks.h (struct input_event):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* textprop.c (validate_interval_range, interval_of)
	(Fadd_text_properties, set_text_properties_1)
	(Fremove_text_properties, Fremove_list_of_text_properties)
	(Ftext_property_any, Ftext_property_not_all)
	(copy_text_properties, text_property_list, extend_property_ranges)
	(verify_interval_modification):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fnext_single_char_property_change)
	(Fprevious_single_char_property_change):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
Paul Eggert's avatar
Paul Eggert committed
648 649
	(copy_text_properties):
	Check for integer overflow in index calculation.
650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
	* undo.c (last_boundary_position, record_point, record_insert)
	(record_delete, record_marker_adjustment, record_change)
	(record_property_change):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
	(Fx_hide_tip, Fx_file_dialog):
	* w32menu.c (set_frame_menubar):
	Use ptrdiff_t, not int, for consistency with rest of code.
	* window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
	(select_window, Fdelete_other_windows_internal)
	(window_scroll_pixel_based, window_scroll_line_based)
	(Frecenter, Fset_window_configuration):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fset_window_hscroll, run_window_configuration_change_hook)
	(set_window_buffer, temp_output_buffer_show, scroll_command)
Paul Eggert's avatar
Paul Eggert committed
667
	(Fscroll_other_window, Frecenter):
668 669 670 671 672 673 674 675 676 677
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
	Don't assume fixnum fits in int.
	(Fset_window_scroll_bars):
	Check that fixnums are in proper range for system types.
	* xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
	(string_pos, c_string_pos, number_of_chars, init_iterator)
	(in_ellipses_for_invisible_text_p, init_from_display_pos)
	(compute_stop_pos, next_overlay_change, compute_display_string_pos)
	(compute_display_string_end, handle_face_prop)
Paul Eggert's avatar
Paul Eggert committed
678 679
	(face_before_or_after_it_pos, handle_invisible_prop)
	(handle_display_prop, handle_display_spec, handle_single_display_spec)
680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
	(display_prop_intangible_p, string_buffer_position_lim)
	(string_buffer_position, handle_composition_prop, load_overlay_strings)
	(get_overlay_strings_1, get_overlay_strings)
	(iterate_out_of_display_property, forward_to_next_line_start)
	(back_to_previous_visible_line_start, reseat, reseat_to_string)
	(get_next_display_element, set_iterator_to_next)
	(get_visually_first_element, compute_stop_pos_backwards)
	(handle_stop_backwards, next_element_from_buffer)
	(move_it_in_display_line_to, move_it_in_display_line)
	(move_it_to, move_it_vertically_backward, move_it_by_lines)
	(add_to_log, message_dolog, message_log_check_duplicate)
	(message2, message2_nolog, message3, message3_nolog
	(with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
	(current_message_1, truncate_echo_area, truncate_message_1)
	(set_message, set_message_1, store_mode_line_noprop)
	(hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
	(text_outside_line_unchanged_p, check_point_in_composition)
	(reconsider_clip_changes)
	(redisplay_internal, set_cursor_from_row, try_scrolling)
	(try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
	(redisplay_window, find_last_unchanged_at_beg_row)
	(find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
	(trailing_whitespace_p, find_row_edges, display_line)
	(RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
	(display_mode_element, store_mode_line_string)
	(pint2str, pint2hrstr, decode_mode_spec)
	(display_count_lines, display_string, draw_glyphs)
	(x_produce_glyphs, x_insert_glyphs)
	(rows_from_pos_range, mouse_face_from_buffer_pos)
	(fast_find_string_pos, mouse_face_from_string_pos)
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(safe_call, init_from_display_pos, handle_fontified_prop)
	(handle_single_display_spec, load_overlay_strings)
	(with_echo_area_buffer, setup_echo_area_for_printing)
	(display_echo_area, echo_area_display)
	(x_consider_frame_title, prepare_menu_bars, update_menu_bar)
	(update_tool_bar, hscroll_window_tree, redisplay_internal)
Paul Eggert's avatar
Paul Eggert committed
718 719
	(redisplay_window, dump_glyph_row, display_mode_line)
	(Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
720
	(handle_display_spec, display_prop_string_p):
721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(handle_single_display_spec, build_desired_tool_bar_string)
	(redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
	(get_specified_cursor_type):
	Check that fixnums are in proper range for system types.
	(struct overlay_entry, resize_mini_window, Fdump_glyph_row)
	(Flookup_image_map):
	Don't assume fixnums fit in int.
	(compare_overlay_entries):
	Avoid mishandling comparisons due to subtraction overflow.
	(load_overlay_strings): Use SAFE_NALLOCA, not alloca.
	(last_escape_glyph_face_id, last_glyphless_glyph_face_id):
	(handle_tool_bar_click):
	Use int, not unsigned, since we prefer signed and the signedness
	doesn't matter here.
	(get_next_display_element, next_element_from_display_vector):
	Use int, not EMACS_INT, when int is wide enough.
	(start_hourglass): Use duration_to_sec_usec to do proper
	overflow checking on durations.
	* xfaces.c (Fbitmap_spec_p):
	Check that fixnums are in proper range for system types.
	(compare_fonts_by_sort_order):
	Avoid mishandling comparisons due to subtraction overflow.
	(Fx_family_fonts, realize_basic_faces):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fx_family_fonts):
	Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	(merge_face_heights): Remove unnecessary cast to EMACS_INT.
	(Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
	(face_at_buffer_position, face_for_overlay_string)
	(face_at_string_position):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(merge_faces): Use int, not EMACS_INT, where int is wide enough.
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
	(Fx_show_tip):
	Check that fixnums are in proper range for system types.
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip)
	(Fx_hide_tip, Fx_file_dialog, Fx_select_font):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fx_change_window_property): Don't assume fixnums fit in int.
	* xfont.c (xfont_chars_supported):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xmenu.c (Fx_popup_dialog, set_frame_menubar)
	(create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xml.c (parse_region):
	* xrdb.c (magic_file_p):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* xselect.c (TRACE1): Don't assume pid_t promotes to int.
	(x_get_local_selection, x_reply_selection_request)
	(x_handle_selection_request, wait_for_property_change):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(selection_data_to_lisp_data): Use short, not EMACS_INT, where
	short is wide enough.
	(x_send_client_event): Don't assume fixnum fits in int.
	* xterm.c (x_x_to_emacs_modifiers):
	Don't assume EMACS_INT overflows nicely into int.
	(x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
	may come from Lisp.
	(handle_one_xevent): NATNUMP can eval its arg twice.
	(x_connection_closed):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xterm.h: Adjust decls to match defn changes elsewhere.
	(struct scroll_bar): Use struct vectorlike_header
	rather than rolling our own approximation.
	(SCROLL_BAR_VEC_SIZE): Remove; not used.

789 790 791 792 793 794
2011-11-18  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* dispextern.h, xdisp.c (row_hash): Declare extern only if XASSERTS.
	* dispnew.c (verify_row_hash): Now static.

795 796 797 798
2011-11-18  Dmitry Antipov  <dmantipov@yandex.ru>

	* keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.

799 800 801 802 803
2011-11-18  Stefan Monnier  <monnier@iro.umontreal.ca>

	* intervals.c: Fix grafting over the whole buffer (bug#10071).
	(graft_intervals_into_buffer): Simplify.

804 805 806 807 808 809
2011-11-18  Eli Zaretskii  <eliz@gnu.org>

	* dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
	hash values of the two rows.
	(copy_row_except_pointers): Preserve the used[] arrays and the
	hash values of the two rows.  (Bug#10035)
810
	(add_row_entry): Add xassert to verify that ROW's hash code is valid.
811 812 813 814 815 816 817 818 819 820 821

	* xdisp.c (row_hash): New function, body extracted from
	compute_line_metrics.
	(compute_line_metrics): Call row_hash, instead of computing the
	hash code inline.

	* dispnew.c (verify_row_hash): Call row_hash for computing the
	hash code of a row, instead of duplicating code from xdisp.c.

	* dispextern.h (row_hash): Add prototype.

822 823 824 825 826
2011-11-18  Tassilo Horn  <tassilo@member.fsf.org>

	* frame.c (delete_frame): Don't delete the terminal when the last
	X frame is closed if emacs is built with GTK toolkit.

Juanma Barranquero's avatar
Juanma Barranquero committed
827 828 829 830
2011-11-17  Juanma Barranquero  <lekktu@gmail.com>

	* window.c (syms_of_window) <window-combination-resize>: Fix typo.

831 832 833 834 835 836 837
2011-11-17  Martin Rudalics  <rudalics@gmx.at>

	* window.c (Vwindow_splits): Rename to
	Vwindow_combination_resize.  Suggested by Juri Linkov.
	(Fsplit_window_internal): Use Vwindow_combination_resize instead
	of Vwindow_splits.

Juanma Barranquero's avatar
Juanma Barranquero committed
838 839
2011-11-16  Juanma Barranquero  <lekktu@gmail.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
840 841
	* nsfns.m (Fns_font_name):
	* window.c (syms_of_window) <window-combination-limit>: Fix typos.
Juanma Barranquero's avatar
Juanma Barranquero committed
842

843 844 845 846 847 848 849 850 851 852 853
2011-11-16  Martin Rudalics  <rudalics@gmx.at>

	* window.h (window): Rename slot "nest" to "combination_limit".
	* window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
	(Fset_window_nest): Rename to Fset_window_combination_limit.
	(Vwindow_nest): Rename to Vwindow_combination_limit.
	(recombine_windows, make_parent_window, make_window)
	(Fsplit_window_internal, saved_window)
	(Fset_window_configuration, save_window_save): Rename all
	occurrences of window_nest to window_combination_limit.

Juanma Barranquero's avatar
Juanma Barranquero committed
854 855 856 857
2011-11-15  Juanma Barranquero  <lekktu@gmail.com>

	* image.c (imagemagick_load_image): Fix typo.

858 859 860 861 862 863 864 865
2011-11-14  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (display_line): Move the call to
	highlight_trailing_whitespace before the call to
	compute_line_metrics, since the latter needs to see the final
	faces of all the glyphs to compute ROW's hash value.  Fixes
	assertion violations in row_equal_p.  (Bug#10035)

Juanma Barranquero's avatar
Juanma Barranquero committed
866 867 868 869 870
2011-11-14  Juanma Barranquero  <lekktu@gmail.com>

	* w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
	just return (bug#10044).

871 872
2011-11-12  Eli Zaretskii  <eliz@gnu.org>

873 874 875 876 877
	* makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
	with user-defined heap size.  Bump the default size of the temacs
	heap to 27MB, to avoid memory warning when running temacs.
	($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.

878 879
	* dispnew.c (scrolling_window): Fix incorrect indices in accessing
	current_matrix and desired_matrix.  (Bug#9990)
880 881 882
	(verify_row_hash) [XASSERTS]: New function.
	(adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
	that the hash value of glyph rows is correct.
883

Martin Rudalics's avatar
Martin Rudalics committed
884 885 886 887 888 889 890 891 892 893 894
2011-11-12  Martin Rudalics  <rudalics@gmx.at>

	* window.h (window): Remove splits slot.
	* window.c (Fwindow_splits, Fset_window_splits): Remove.
	(Fdelete_other_windows_internal, make_parent_window)
	(make_window, Fsplit_window_internal, Fdelete_window_internal)
	(Fset_window_configuration, save_window_save): Don't deal with
	split status of windows.
	(saved_window): Remove splits slot.
	(Vwindow_splits): Rewrite doc-string.

Jan Djärv's avatar
Jan Djärv committed
895 896 897 898 899 900 901
2011-11-11  Jan Djärv  <jan.h.d@swipnet.se>

	* xfns.c (unwind_create_frame):
	* nsfns.m (unwind_create_frame):
	* w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
	Vframe_list (Bug#9999).

902 903
2011-11-11  Dmitry Antipov  <dmantipov@yandex.ru>

Juanma Barranquero's avatar
Juanma Barranquero committed
904
	* xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
905

906 907 908 909 910
2011-11-11  Kenichi Handa  <handa@m17n.org>

	* callproc.c (Fcall_process): Set the member dst_multibyte of
	process_coding.

911 912 913 914 915
2011-11-11  Johan Bockgård  <bojohan@gnu.org>

	* xdisp.c (fill_composite_glyph_string): Always set s->face, to
	avoid a crash (bug#9496).

916 917 918 919 920
2011-11-09  Chong Yidong  <cyd@gnu.org>

	* window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
	(Fwindow_inside_absolute_pixel_edges): Only allow live windows.

921 922 923 924
2011-11-08  Paul Eggert  <eggert@cs.ucla.edu>

	* s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).

925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944
2011-11-08  Paul Eggert  <eggert@cs.ucla.edu>

	Avoid some portability problems by eschewing 'extern inline' functions.
	The trivial performance wins aren't worth the portability hassles; see
	<http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
	et seq.
	* dispextern.h (window_box, window_box_height, window_text_bottom_y)
	(window_box_width, window_box_left, window_box_left_offset)
	(window_box_right, window_box_right_offset): Undo previous change,
	by removing the "extern"s.
	* intervals.c (adjust_intervals_for_insertion)
	(adjust_intervals_for_deletion): Undo previous change,
	making these static again.
	(offset_intervals, temp_set_point_both, temp_set_point)
	(copy_intervals_to_string): No longer inline.
	* xdisp.c (window_text_bottom_y, window_box_width)
	(window_box_height, window_box_left_offset)
	(window_box_right_offset, window_box_left, window_box_right)
	(window_box): No longer inline.

945 946 947 948 949 950 951 952
2011-11-08  Chong Yidong  <cyd@gnu.org>

	* window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
	(Fwindow_body_height, Fwindow_body_width): Move from Lisp.  Signal
	an error if not a live window.
	(Fwindow_total_width, Fwindow_total_height): Move from Lisp.
	(Fwindow_total_size, Fwindow_body_size): Move to Lisp.

953 954 955 956 957
2011-11-07  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (syms_of_abbrev): Remove declaration.
	Reported by CHENG Gao <chenggao@royau.me>.

958 959 960 961 962 963
2011-11-07  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (check_windows_init_file): Don't look for term/w32-win.el
	if Vpurify_flag is non-nil.  Fixes a crash when running w32 build
	of temacs in GUI mode.

964 965 966 967 968 969 970 971 972 973 974 975 976
2011-11-07  Martin Rudalics  <rudalics@gmx.at>

	* window.h: Declare delete_all_child_windows instead of
	delete_all_subwindows.
	* window.c (Fwindow_nest, Fset_window_nest)
	(Fset_window_new_total, Fset_window_new_normal)
	(Fwindow_resize_apply): Don't use term subwindow in doc-strings.
	(delete_all_subwindows): Rename to delete_all_child_windows.
	(Fdelete_other_windows_internal, Fset_window_configuration):
	Call delete_all_child_windows instead of delete_all_subwindows.
	* frame.c (delete_frame): Call delete_all_child_windows instead
	of delete_all_subwindows.

977 978 979 980 981 982 983
2011-11-07  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
	This is also needed for porting to any host where GC_MARK_STACK is
	not GC_MAKE_GCPROS_NOOPS.
	(which_symbols): Use it.

984 985 986 987 988 989 990 991 992 993 994
2011-11-07  Kenichi Handa  <handa@m17n.org>

	* coding.c (coding_set_destination): Check coding->src_pos only
	when coding->src_object is a buffer (bug#9910).

	* process.c (send_process): Set the member src_multibyte of coding
	to 0 (bug#9911) when sending a unibyte text.

	* callproc.c (Fcall_process): Set the member src_multibyte of
	process_coding to 0 (bug#9912).

995
2011-11-06  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
996 997 998 999 1000

	* xmenu.c (cleanup_widget_value_tree): New function.
	(xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
	calling free_menubar_widget_value_tree directly (Bug#9830).

1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
2011-11-06  Paul Eggert  <eggert@cs.ucla.edu>

	Fix some portability problems with 'inline'.
	* dispextern.h (window_box, window_box_height, window_text_bottom_y)
	(window_box_width, window_box_left, window_box_left_offset)
	(window_box_right, window_box_right_offset): Declare extern.
	Otherwise, these inline functions do not conform to C99 and
	are miscompiled by Microsoft compilers.  Reported by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
	* intervals.c (adjust_intervals_for_insertion)
	(adjust_intervals_for_deletion): Now extern, because otherwise the
	extern inline functions 'offset_intervals' couldn't refer to it.
	(static_offset_intervals): Remove.
	(offset_intervals): Rewrite using the old contents of
	static_offset_intervals.  The old version didn't conform to C99
	because an extern inline function contained a reference to an
	identifier with static linkage.

1019 1020 1021 1022 1023
2011-11-06  Andreas Schwab  <schwab@linux-m68k.org>

	* keyboard.c (interrupt_signal): Don't call kill-emacs while in
	GC.

1024 1025 1026 1027 1028 1029 1030
2011-11-06  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (init_iterator, reseat_to_string): Don't set the
	iterator's bidi_p flag if Vpurify_flag is non-nil.  (Bug#9963)
	(Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
	return Qleft_to_right.

1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043
2011-11-06  Chong Yidong  <cyd@gnu.org>

	* window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
	(Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
	(Fset_window_splits, Fwindow_nest, Fset_window_nest)
	(Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
	(Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
	(Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
	(Fwindow_vscroll): Doc fix.
	(Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
	argument, since it makes no sense to pass a live window and for
	consistency with window-child.

1044 1045 1046 1047 1048
2011-11-05  Christoph Scholtes  <cschol2112@googlemail.com>

	* makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
	support MSVC.

1049 1050 1051 1052 1053 1054 1055 1056 1057
2011-11-05  Jason Rumney  <jasonr@gnu.org>

	* w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
	(add_font_entity_to_list): Filter out non-Japanese Shift-JIS
	fonts (Bug#6029).
	(add_font_entity_to_list): Fix logic errors in mixed boolean and
	bitwise arithmetic preventing use of unicode-sip and non-truetype
	opentype fonts.

1058 1059
2011-11-05  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
1060 1061 1062
	* s/ms-w32.h (fstat, stat, utime): Move redirections to
	"emacs"-only part.

1063 1064 1065 1066
	* w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
	initialization code to keep similarity to xfns.c after changes
	from 2011-11-05.

1067 1068
2011-11-05  Jan Djärv  <jan.h.d@swipnet.se>

1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
	* nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
	(unwind_create_frame): New function (Bug#9943).
	(Fx_create_frame): Restructure code to be more similar to the one in
	xfns.c.  Call record_unwind_protect with unwind_create_frame (Bug#9943).
	Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
	Move terminal->reference_count++ just before making the frame official
	(Bug#9943).

	* nsterm.m (x_free_frame_resources): New function.
	(x_destroy_window): Move code to x_free_frame_resources.

1080 1081 1082 1083 1084 1085
	* xfns.c (unwind_create_frame): Fix comment.
	(Fx_create_frame, x_create_tip_frame): Move
	terminal->reference_count++ just before making the frame
	official. Move initialization of image_cache_refcount and
	dpyinfo_refcount before calling init_frame_faces (Bug#9943).

1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103
2011-11-05  Eli Zaretskii  <eliz@gnu.org>

	Support MSVC build with newer versions of Visual Studio.
	* makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
	Nmake barfs on that.  Use $(OBJ*_c) variables instead, defined on
	nt/gmake.defs.

	* lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
	which are not supported by MSVC.
	(Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
	(Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
	bitfields.
	(Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
	types in bitfields.
	(DEFUN) [_MSC_VER]: Define in a different way for MSVC.

	* w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.

Juanma Barranquero's avatar
Juanma Barranquero committed
1104
2011-11-05  Fabrice Popineau  <fabrice.popineau@supelec.fr>  (tiny change)
1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120

	Support MSVC build with newer versions of Visual Studio.
	* w32.c: Don't include w32api.h for MSVC.
	(init_environment) [_MSC_VER]: Call sys_access, not _access.

	* s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
	[_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
	(fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
	(malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
	e_* cousins.
	(alloca) [_MSC_VER]: Define to _alloca.

	* lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.

	* regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.

1121 1122 1123 1124 1125 1126
2011-11-04  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (note_mouse_highlight): If either of
	previous/next-single-property-change returns nil, treat that as
	the beginning or the end of the buffer.  (Bug#9955)

1127 1128
2011-11-04  Jan Djärv  <jan.h.d@swipnet.se>

1129
	* gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1130 1131 1132 1133
	label is not null (Bug#9951).
	(xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
	may be NULL.

1134 1135 1136 1137 1138
2011-11-04  Eli Zaretskii  <eliz@gnu.org>

	* window.c (Fwindow_body_size): Mention in the doc string that the
	return value is in frame's canonical units.  (Bug#9949)

1139 1140
2011-11-03  Eli Zaretskii  <eliz@gnu.org>

1141 1142
	* xdisp.c (note_mouse_highlight): Initialize `area'.  (Bug#9947)

1143
	* w32fns.c (unwind_create_frame): If needed, free the glyph
1144
	matrices of the partially constructed frame.  (Bug#9943)
Eli Zaretskii's avatar
Eli Zaretskii committed
1145
	* xfns.c (unwind_create_frame): Likewise.
1146

1147 1148 1149 1150 1151
2011-11-01  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
	Don't stop backward scan on the continuation glyph, even though
	its CHARPOS is positive.
1152 1153
	(mouse_face_from_buffer_pos, note_mouse_highlight): Rename
	cover_string to disp_string.
1154

1155 1156 1157 1158 1159 1160
2011-11-01  Martin Rudalics  <rudalics@gmx.at>

	* window.c (temp_output_buffer_show): Don't use
	Vtemp_buffer_show_specifiers.
	(Vtemp_buffer_show_specifiers): Remove unused variable.

1161 1162 1163 1164 1165
2011-10-30  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
	past the beginning of the current glyph matrix.

Juanma Barranquero's avatar
Juanma Barranquero committed
1166
2011-10-30  Adam Sjøgren  <asjo@koldfront.dk>  (tiny change)
Jan Djärv's avatar
Jan Djärv committed
1167 1168 1169 1170

	* xterm.c: Include X11/Xproto.h if HAVE_GTK3.
	(x_error_handler): Ignore BadMatch for X_SetInputFocus for
	HAVE_GTK3 (Bug#9869).
1171

1172 1173 1174
	* gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
	type to GDK_NOTHING so valgrind does not complain (Bug#9901).

1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185
	* xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).

	* xterm.c: Declare x_handle_net_wm_state to return int.
	(handle_one_xevent): Check if we are iconified but don't have
	_NET_WM_STATE_HIDDEN.  If do, treat as deiconify (Bug#9893).
	(get_current_wm_state): Return non-zero if not hidden,
	check for _NET_WM_STATE_HIDDEN (Bug#9893).
	(do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
	(x_handle_net_wm_state): Return what get_current_wm_state returns.
	(x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.

1186 1187 1188 1189 1190 1191
2011-10-29  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
	so that this new function doesn't get optimized away by a
	whole-program optimizer.  Make the 2nd arg EMACS_INT, not int.

1192 1193 1194 1195
2011-10-29  Andreas Schwab  <schwab@linux-m68k.org>

	* frame.h (MOUSE_HL_INFO): Remove excess parens.

1196 1197 1198 1199
2011-10-29  Eli Zaretskii  <eliz@gnu.org>

	Fix the `xbytecode' command.
	* .gdbinit (xprintbytestr): New command.
1200
	(xwhichsymbols): Rename from `which'; all callers changed.
1201 1202
	(xbytecode): Print the byte-code string as well.

1203 1204
2011-10-29  Kim Storm  <storm@cua.dk>

1205 1206
	* alloc.c (which_symbols): New function.

Andreas Schwab's avatar
Andreas Schwab committed
1207 1208 1209 1210 1211
2011-10-29  Andreas Schwab  <schwab@linux-m68k.org>

	* minibuf.c (read_minibuf_noninteractive): Allow reading empty
	line.  (Bug#9903)

1212 1213 1214 1215 1216
2011-10-29  Glenn Morris  <rgm@gnu.org>

	* process.c (wait_reading_process_output): Revert 2009-08-30 change.
	Not clear what it was for, and it causes various bugs.  (Bug#9839)

1217 1218 1219 1220 1221 1222
2011-10-28  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
	possible random value that matches one of those tested as
	condition to clear the mouse face.

1223 1224 1225 1226
2011-10-28  Chong Yidong  <cyd@gnu.org>

	* xdisp.c (note_mouse_highlight): Fix use of uninitialized var.

1227 1228 1229 1230
2011-10-28  Dan Nicolaescu  <dann@ics.uci.edu>

	* window.c (make_window): Initialize phys_cursor_on_p.

1231 1232 1233 1234
2011-10-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.h (struct Lisp_Symbol): Update comments.

1235 1236 1237 1238
2011-10-28  Juanma Barranquero  <lekktu@gmail.com>

	* w32font.c (w32_load_unicows_or_gdi32): Add missing return.

1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249
2011-10-28  Eli Zaretskii  <eliz@gnu.org>

	Fix Emacs on Windows 9X (bug#8562).  Thanks to oslsachem
	<oslsachem@gmail.com> for helping to debug this.

	* w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
	(g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
	(g_b_init_get_glyph_outline_w): New static variables.
	(GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
	(GetGlyphOutlineW_Proc): New typedefs.
	(w32_load_unicows_or_gdi32, get_outline_metrics_w)
1250 1251 1252 1253
	(get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
	New functions.
	(w32font_open_internal, compute_metrics):
	Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1254 1255 1256 1257 1258 1259
	instead of calling the "wide" APIs directly.

	* emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.

	* w32.h (syms_of_w32font): Add prototype.

1260 1261 1262 1263 1264 1265 1266
2011-10-27  Juanma Barranquero  <lekktu@gmail.com>

	* window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
	(Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
	(Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
	(Fmove_to_window_line): Doc fix.

Chong Yidong's avatar
Chong Yidong committed
1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
2011-10-27  Chong Yidong  <cyd@gnu.org>

	* process.c (make_process): Set gnutls_state to NULL.

	* gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
	non-NULL, regardless of GNUTLS_INITSTAGE.
	(Fgnutls_boot): Cleanups.  Call emacs_gnutls_deinit if we signal
	an error.  Set process slots as soon as we allocate them.

	* gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.

1278 1279
2011-10-27  Chong Yidong  <cyd@gnu.org>

1280 1281
	* gnutls.c (emacs_gnutls_deinit): New function.
	Deallocate credentials structures as well as calling gnutls_deinit.
1282 1283 1284 1285 1286
	(Fgnutls_deinit, Fgnutls_boot): Use it.

	* process.c (make_process): Initialize GnuTLS credentials to NULL.
	(deactivate_process): Call emacs_gnutls_deinit.

1287 1288 1289 1290 1291 1292 1293
2011-10-27  Juanma Barranquero  <lekktu@gmail.com>

	* image.c (x_create_x_image_and_pixmap):
	* w32.c (sys_rename, w32_delayed_load):
	* w32font.c (fill_in_logfont):
	* w32reg.c (x_get_string_resource): Silence compiler warnings.

1294 1295 1296 1297
2011-10-26  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (w32_default_color_map): New function,
	extracted from Fw32_default_color_map.
Juanma Barranquero's avatar
Juanma Barranquero committed
1298
	(Fw32_default_color_map, Fx_open_connection): Use it.  (Bug#9785)
1299

1300 1301 1302 1303
2011-10-25  Paul Eggert  <eggert@cs.ucla.edu>

	* dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).

1304 1305 1306 1307 1308
2011-10-25  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (test_undefined): New function (bug#9751).
	(read_key_sequence): Use it to detect when a key is bound to `undefined'.

1309 1310 1311 1312 1313
2011-10-25  Enami Tsugutomo  <tsugutomo.enami@jp.sony.com>

	* sysdep.c (init_sys_modes): Fix the check for the controlling
	terminal (Bug#6649).

1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326
2011-10-20  Eli Zaretskii  <eliz@gnu.org>

	* dispextern.h (struct bidi_it): New member next_en_type.

	* bidi.c (bidi_line_init): Initialize the next_en_type member.
	(bidi_resolve_explicit_1): When next_en_pos is valid for the
	current character, check also for next_en_type being WEAK_EN.
	(bidi_resolve_weak): Don't enter the expensive loop if the current
	position is before next_en_pos.  Record the bidi type of the first
	non-ET, non-BN character we find, in addition to its position.
	(bidi_level_of_next_char): Invalidate next_en_type when
	next_en_pos is over-stepped.

1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347
2011-10-20  Paul Eggert  <eggert@cs.ucla.edu>

	Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
	* editfns.c: Rewrite current-time-zone so that it invokes
	the equivalent of (format-time-string "%Z") to get the time zone name.
	This fixes a bug when the time zone name contains characters that
	need converting from the system time locale to Emacs internal format.
	This fixes a shortcoming that I introduced in my 1999-10-19 patch:
	that patch fixed format-time-string to do the conversion, but
	I forgot to fix current-time-zone.
	(format_time_string): New function, containing most of
	what Fformat_time_string used to contain.
	(Fformat_time_string): Rewrite in terms of format_time_string.
	This doesn't change this function's behavior.
	(current-time-zone): Rewrite to use format_time_string.
	This fixes the bug reported by Michael Schierl in
	<http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
	Jason Rumney's 2007-06-07 change worked around this bug, but
	didn't fix it.
	* systime.h (tzname, timezone): Remove no-longer-used declarations.

1348 1349 1350 1351
2011-10-19  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (start_display): If the character at POS is displayed
	via a display vector, reset IT->current.dpvec_index to zero.
1352 1353 1354 1355
	(try_window_reusing_current_matrix): If a line ends in a display
	vector or the next line starts in a display vector, continue
	redrawing the window even though the character position of
	start_row was reached.
1356 1357
	(Bug#9771, part 2)

1358 1359 1360 1361 1362
2011-10-18  Chong Yidong  <cyd@gnu.org>

	* xdisp.c (get_next_display_element): Handle U+2010 and U+2011
	with nobreak-char-display too.

1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381
2011-10-18  Eli Zaretskii  <eliz@gnu.org>

	Fix part 3 of bug#9771.
	* bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
	(bidi_resolve_neutral): Don't enter the expensive loop looking for
	non-neutral characters if the current character is a paragraph
	separator (a.k.a. Newline).  This avoids running the same
	expensive loop twice, once when we consume the preceding newline
	and the other time when the line actually needs to be displayed.
	Avoid the loop when we see neutrals on the base embedding level
	following a character whose directionality is the same as the
	paragraph's.  This avoids running the expensive loop when a line
	ends in a long sequence of neutrals, like control characters.
	Add assertion against STRONG_AL type.  Slightly rearrange code
	that determines the type of a neutral given the first non-neutral
	that follows it.
	(bidi_level_of_next_char): Set next_en_pos to zero when
	invalidating its info.

1382 1383 1384 1385 1386
2011-10-17  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (push_display_prop): Determine whether to record string
	or buffer position by IT->string, not by IT->method.  Allow
	GET_FROM_DISPLAY_VECTOR as IT->method on entry.  (Bug#9771, part 4)
1387 1388 1389
	(move_it_vertically_backward): Don't look for character position
	immediately after the newline when in a continuation line.
	(Bug#9771, part 1)
1390

1391 1392 1393 1394 1395
2011-10-15  Martin Rudalics  <rudalics@gmx.at>

	* window.c (coordinates_in_window): Rewrite and delabelize
	vertical border check.  (Bug#5357) (Bug#9618)

1396 1397 1398 1399 1400
2011-10-14  Stefan Monnier  <monnier@iro.umontreal.ca>

	* xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
	errors in XSetWindowBorder (bug#9310).

1401 1402 1403 1404 1405
2011-10-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* editfns.c (Fset_time_zone_rule): Replace free with xfree to
	avoid crash when xmalloc overrun checking is enabled.

1406 1407 1408 1409 1410 1411 1412 1413 1414
2011-10-13  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
	itb.paragraph_dir to NEUTRAL_DIR.  Fixes an occasional incorrect
	cursor motion with <left> and <right> arrow keys.

	* bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
	some callers set that themselves.

1415 1416 1417 1418 1419 1420
2011-10-12  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (find_row_edges): Handle the case where ROW comes from a
	display string and the previous row comes from the same string and
	is empty.  (Bug#9739)  (Bug#9738)

1421 1422 1423 1424
2011-10-12  Stefan Monnier  <monnier@iro.umontreal.ca>

	* doc.c (get_doc_string): Encode file name (bug#9735).

1425 1426
2011-10-12  Eli Zaretskii  <eliz@gnu.org>

1427 1428 1429 1430
	* bidi.c (bidi_level_of_next_char):
	* xdisp.c (get_visually_first_element): Remove old incorrect
	comments regarding the Unicode Line Separator character.

1431 1432
	* bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.

1433 1434 1435 1436 1437 1438
2011-10-12  Dmitry Antipov  <dmantipov@yandex.ru>

	* alloc.c (Fgc_status): Do not access beyond zombies array
	boundary if nzombies > MAX_ZOMBIES.
	* alloc.c (dump_zombies): Add missing format specifier.

1439 1440
2011-10-12  Paul Eggert  <eggert@cs.ucla.edu>

1441 1442 1443
	* xdisp.c (set_cursor_from_row): Simplify conditionals,
	to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.

1444 1445 1446
	* lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
	Some packages use them to denote characters with modifiers.

1447 1448 1449 1450 1451 1452
2011-10-11  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
	(GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
	matching a pp-number.  Rename parameter var to var1.

1453 1454 1455 1456
2011-10-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).

Glenn Morris's avatar
Glenn Morris committed
1457 1458 1459 1460 1461
2011-10-08  Glenn Morris  <rgm@gnu.org>

	* callint.c (Fcall_interactively): Give a more explicit error for the
	'c' case with a non-character input.  (Bug#8479)

1462 1463
2011-10-08  Eli Zaretskii  <eliz@gnu.org>

1464 1465
	* xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
	lines.
1466 1467
	(set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
	lines that are hscrolled on the left.
1468

1469 1470 1471
	* dispnew.c (buffer_posn_from_coords): Account for a possible
	presence of header-line.  (Bug#4426)

1472 1473
2011-10-07  Stefan Monnier  <monnier@iro.umontreal.ca>

1474 1475
	* buffer.c (syms_of_buffer) <enable-multibyte-characters>:
	Don't advertise functionality which we discourage or doesn't work.
1476

1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488
2011-10-07  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
	or sizeof.  __alignof__ gives the wrong answer on Fedora x86-64
	with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
	this makes Emacs dump core during garbage collection on rare
	occasions.  sizeof is obviously inferior to offsetof here, so
	stick with offsetof.
	(GC_POINTER_ALIGNMENT): New macro.
	(mark_memory): Omit 3rd (offset) arg; caller changed.
	Don't assume EMACS_INT alignment is the same as pointer alignment.

1489 1490 1491 1492 1493 1494
2011-10-03  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (read_key_sequence_remapped): New var.
	(read_key_sequence): Compute remapping in the right buffer.
	(command_loop_1): Use read_key_sequence's remapping directly.

1495 1496
2011-10-02  Stefan Monnier  <monnier@iro.umontreal.ca>

1497 1498 1499 1500
	* dired.c (file_name_completion): Don't expand file name.
	(Ffile_name_completion, Ffile_name_all_completions): Expand file name
	before checking file name handler.

1501 1502 1503
	* minibuf.c (Finternal_complete_buffer): Only show internal buffers if
	they've been requested explicitly (bug#9591).

Chong Yidong's avatar
Chong Yidong committed
1504
2011-10-01  Andreas Schwab  <schwab@linux-m68k.org>
1505 1506 1507 1508 1509

	* keymap.c (Fsingle_key_description): Use make_specified_string
	instead of build_string to build string from push_key_description.
	(Bug#5193)

1510 1511
2011-09-30  Paul Eggert  <eggert@cs.ucla.edu>

1512 1513 1514 1515 1516 1517 1518 1519
	* buffer.h (struct buffer): Use time_t, not int, for a time stamp.
	This fixes a Y2038 bug on 64-bit hosts.
	* buffer.c (reset_buffer):
	* fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
	(Fclear_buffer_auto_save_failure):
	Use 0, not -1, to represent an unset failure time, since time_t
	might not be signed.

1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533
	Remove dependency on glibc malloc internals.
	* alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
	Move back here from lisp.h, but with their new implementations.
	(XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
	(XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
	* charset.c (charset_table_init): New static var.
	(syms_of_charset): Use it instead of xmalloc.  This removes a
	dependency on glibc malloc internals.  See Eli Zaretskii's comment in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
	* lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
	Move back to alloc.c.
	(XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
	(XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.

1534 1535 1536 1537 1538 1539
2011-09-30  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (windowDidResize): Call x_set_window_size only when
	ns_in_resize is true.  Otherwise set pixelwidth/height and
	call change_frame_size (Bug#9628).

1540 1541
2011-09-30  Paul Eggert  <eggert@cs.ucla.edu>

1542 1543 1544 1545
	Port --enable-checking=all to Fedora 14 x86-64.
	* charset.c (syms_of_charset): Also account for glibc malloc's
	internal overhead when calculating the initial malloc maximum.

1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
	Port --enable-checking=all to Fedora 14 x86.
	* alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
	Move to lisp.h.
	(xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
	(overrun_check_realloc, overrun_check_free):
	Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
	That way, xmalloc returns a properly-aligned pointer even if
	XMALLOC_OVERRUN_CHECK is defined.  The old debugging code happened
	to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
	* charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
	into account when calculating the initial malloc maximum.
	* lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
	Move here from alloc.c, so that charset.c can use it too.
	Properly align; the old code wasn't right for common 32-bit hosts
	when configured with --enable-checking=all.
	(XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
	(XMALLOC_OVERRUN_SIZE_SIZE): New macros.

Eli Zaretskii's avatar
Eli Zaretskii committed
1564 1565
2011-09-29  Eli Zaretskii  <eliz@gnu.org>

1566
	* sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
Eli Zaretskii's avatar
Eli Zaretskii committed
1567 1568
	use EDOM.

1569 1570 1571 1572 1573 1574 1575 1576 1577
2011-09-28  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (compute_display_string_end): If there's no display
	string at CHARPOS, return -1.

	* bidi.c (bidi_fetch_char): When compute_display_string_end
	returns a negative value, treat the character as a normal
	character not covered by a display string.  (Bug#9624)

Juanma Barranquero's avatar
Juanma Barranquero committed
1578 1579 1580 1581
2011-09-28  Juanma Barranquero  <lekktu@gmail.com>

	* lread.c (Fread_from_string): Fix typo in docstring.

1582 1583 1584 1585 1586
2011-09-27  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_invisible_prop): If invisible text ends on a
	newline, reseat the iterator instead of bidi-iterating there one
	character at a time.  (Bug#9610)
1587 1588
	(BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
	TO_CHARPOS if the bidi iterator is at base embedding level.
1589

1590 1591 1592 1593 1594
2011-09-27  Andreas Schwab  <schwab@linux-m68k.org>

	* lread.c (readevalloop): Use correct code for NBSP.
	(read1): Likewise.  (Bug#9608)

1595 1596 1597 1598 1599
2011-09-25  Michael Albinus  <michael.albinus@gmx.de>

	* dbusbind.c (Fdbus_register_signal): When service is not
	registered, use nil in Vdbus_registered_objects_table.  (Bug#9581)

1600 1601 1602 1603
2011-09-25  Glenn Morris  <rgm@gnu.org>

	* buffer.c (truncate-lines): Doc fix.

1604 1605 1606 1607 1608
2011-09-24  Chong Yidong  <cyd@stupidchicken.com>

	* window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
	(Fset_window_next_buffers): Doc fix.

1609 1610 1611 1612
2011-09-24  Glenn Morris  <rgm@gnu.org>

	* minibuf.c (read_minibuf): Disable line truncation.  (Bug#5715)

1613 1614
2011-09-24  Paul Eggert  <eggert@cs.ucla.edu>

1615 1616
	Fix minor problems found by static checking.
	* xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1617 1618
	* indent.c (Fvertical_motion): Fix == vs = typo.

Eli Zaretskii's avatar