ChangeLog 427 KB
Newer Older
Paul Eggert's avatar
Paul Eggert committed
1
2012-04-22  Paul Eggert  <eggert@cs.ucla.edu>
2

Paul Eggert's avatar
Paul Eggert committed
3
	Fix integer width and related bugs (Bug#9874).
Paul Eggert's avatar
Paul Eggert committed
4
	* alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37
	(allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
	(string_bytes, check_sblock, allocate_string_data):
	(compact_small_strings, Fmake_bool_vector, make_string)
	(make_unibyte_string, make_multibyte_string)
	(make_string_from_bytes, make_specified_string)
	(allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
	(make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
	(mark_vectorlike):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(allocate_pseudovector):
	Use int, not EMACS_INT, where int is wide enough.
	(inhibit_garbage_collection, Fgarbage_collect):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
	int might not be wide enough.
	(bidi_cache_search, bidi_cache_find, bidi_init_it)
	(bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
	(bidi_at_paragraph_end, bidi_find_paragraph_start)
	(bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* buffer.c (copy_overlays, Fgenerate_new_buffer_name)
	(Fkill_buffer, Fset_buffer_major_mode)
	(advance_to_char_boundary, Fbuffer_swap_text)
	(Fset_buffer_multibyte, overlays_at, overlays_in)
	(overlay_touches_p, struct sortvec, record_overlay_string)
	(overlay_strings, recenter_overlay_lists)
	(adjust_overlays_for_insert, adjust_overlays_for_delete)
	(fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
	(Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
	(Foverlay_recenter, last_overlay_modification_hooks_used)
	(report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
Paul Eggert's avatar
Paul Eggert committed
38 39
	(validate_region): Omit unnecessary test for b <= e,
	since that's guaranteed by the previous test.
40 41 42 43 44 45 46
	(adjust_overlays_for_delete): Avoid pos + length overflow.
	(Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
	(report_overlay_modification):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
	Omit pointer cast, which isn't needed anyway, and doesn't work
	after the EMACS_INT -> ptrdiff_t change.
47 48 49 50 51 52
	(Fmove_overlay): Delete an evaporating overlay
	if it becomes empty after its bounds are adjusted to fit within
	its buffer.  Without this fix, in a nonempty buffer (let ((o
	(make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
	yields an empty overlay that has the evaporate property, which is
	not supposed to happen.  (Bug#9642)
53 54 55 56
	* buffer.h: Adjust decls to match defn changes elsewhere.
	(struct buffer_text, struct buffer):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Use EMACS_INT, not int, where int might not be wide enough.
57 58 59 60 61 62
	* bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
	not int, to avoid needless 32-bit limit on 64-bit hosts.
	(exec_byte_code): Use tighter memory-full test, one that checks
	for alloca overflow.  Don't compute the address of the object just
	before an array, as that's not portable.  Use EMACS_INT, not
	ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
	* callint.c (Fcall_interactively):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* callproc.c (call_process_kill, Fcall_process):
	Don't assume pid_t fits into an Emacs fixnum.
	(call_process_cleanup, Fcall_process, child_setup):
	Don't assume pid_t fits into int.
	(call_process_cleanup, Fcall_process, delete_temp_file)
	(Fcall_process_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fcall_process): Simplify handling of volatile integers.
	Use int, not EMACS_INT, where int will do.
	* casefiddle.c (casify_object, casify_region, operate_on_word)
	(Fupcase_word, Fdowncase_word, Fcapitalize_word):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(casify_object): Avoid integer overflow when overallocating buffer.
	* casetab.c (set_identity, shuffle): Prefer int to unsigned when
79
	either works.  Use lint_assume to convince GCC 4.6.1 that it's OK.
80 81 82 83 84 85 86
	* category.c (Fchar_category_set): Don't assume fixnum fits in int.
	* category.h (CATEGORYP): Don't assume arg is nonnegative.
	* ccl.c (GET_CCL_INT): Remove; no longer needed, since the
	integers are now checked earlier.  All uses replaced with XINT.
	(ccl_driver):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	For CCL_MapSingle, check that content and value are in int range.
87 88
	(ccl_driver, Fregister_code_conversion_map):
	Check that Vcode_version_map_vector is a vector.
89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108
	(resolve_symbol_ccl_program): Check that vector header is in range.
	Always copy the vector, so that we can check its contents reliably
	now rather than having to recheck each instruction as it's being
	executed.  Check that vector words fit in 'int'.
	(ccl_get_compiled_code, Fregister_ccl_program)
	(Fregister_code_conversion_map): Use ptrdiff_t, not int, for
	program indexes, to avoid needless 32-bit limit on 64-bit hosts.
	(Fccl_execute, Fccl_execute_on_string): Check that initial reg
	contents are in range.
	(Fccl_execute_on_string): Check that status is in range.
	* ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
	* character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
	Accept and return EMACS_INT, not int, because callers can pass values
	out of 'int' range.
	(c_string_width, strwidth, lisp_string_width, chars_in_text)
	(multibyte_chars_in_text, parse_str_as_multibyte)
	(str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
	(str_as_unibyte, str_to_unibyte, string_count_byte8)
	(string_escape_byte8, Fget_byte):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109
	(Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 111 112 113 114 115 116
	avoid mishandling large integers.
	* character.h: Adjust decls to match defn changes elsewhere.
	* charset.c (load_charset_map_from_file, find_charsets_in_text)
	(Ffind_charset_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(load_charset_map_from_file): Redo idx calculation to avoid overflow.
	(load_charset_map_from_vector, Fdefine_charset_internal):
117
	Don't assume fixnum fits in int.
118 119 120
	(load_charset_map_from_vector, Fmap_charset_chars):
	Remove now-unnecessary CHECK_NATNUMs.
	(Fdefine_charset_internal): Check ranges here, more carefully.
121 122 123 124 125 126 127 128 129 130 131 132
	Don't rely on undefined behavior with signed left shift overflow.
	Don't assume unsigned int fits into fixnum, or that fixnum fits
	into unsigned int.  Don't require max_code to be a valid fixnum;
	that's not true for gb10830 4-byte on a 32-bit host.  Allow
	invalid_code to be a cons, for the same reason.  Require code_offset
	to be a character.  Avoid int overflow if max_char is close
	to INT_MAX.
	(CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
	this is intended anyway and avoids some undefined behavior.
	(load_charset_map): Pass unsigned, not int, as 2nd arg of
	INDEX_TO_CODE_POINT, as that's what it expects.
	(Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 134 135 136 137 138 139
	* charset.h (DECODE_CHAR): Return int, not unsigned;
	this is what was intended anyway, and it avoids undefined behavior.
	(CHARSET_OFFSET): Remove unused macro, instead of fixing its
	integer-overflow issues.
	(ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
	Formerly, it returned EMACS_INT on 64-bit hosts in the common case
	where the argument is EMACS_INT, and this behavior is not intended.
140 141 142 143 144 145
	* chartab.c (Fmake_char_table, Fset_char_table_range)
	(uniprop_get_decoder, uniprop_get_encoder):
	Don't assume fixnum fits in int.
	* cmds.c (move_point): New function, that does the gist of
	Fforward_char and Fbackward_char, but does so while checking
	for integer overflow more accurately.
146
	(Fforward_char, Fbackward_char): Use it.
147 148 149 150 151 152
	(Fforward_line, Fend_of_line, internal_self_insert)
	(internal_self_insert):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Fix a FIXME, by checking for integer overflow when calculating
	target_clm and actual_clm.
	* coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
Paul Eggert's avatar
Paul Eggert committed
153
	(CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
	(ASSURE_DESTINATION, coding_alloc_by_realloc)
	(coding_alloc_by_making_gap, alloc_destination)
	(detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
	(encode_coding_utf_16, detect_coding_emacs_mule)
	(decode_coding_emacs_mule, encode_coding_emacs_mule)
	(detect_coding_iso_2022, decode_coding_iso_2022)
	(encode_invocation_designation, encode_designation_at_bol)
	(encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
	(encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
	(encode_coding_ccl, encode_coding_raw_text)
	(detect_coding_charset, decode_coding_charset)
	(encode_coding_charset, detect_eol, decode_eol, produce_chars)
	(produce_composition, produce_charset, produce_annotation)
	(decode_coding, handle_composition_annotation)
	(handle_charset_annotation, consume_chars, decode_coding_gap)
	(decode_coding_object, encode_coding_object, detect_coding_system)
	(Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
	(code_convert_region, code_convert_string)
Paul Eggert's avatar
Paul Eggert committed
173 174
	(Fdefine_coding_system_internal)
	(coding_set_source, coding_set_destination):
175 176 177 178 179
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
	(Fdefine_coding_system_internal):
	Don't assume fixnums fit in int.
	(decode_coding_gap, decode_coding_object, encode_coding_object)
Paul Eggert's avatar
Paul Eggert committed
180
	(Fread_coding_system, Fdetect_coding_region)
181 182
	(Funencodable_char_position, Fcheck_coding_systems_region)
	(get_translation, handle_composition_annotation, consume_chars):
183
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
Paul Eggert's avatar
Paul Eggert committed
184
	(consume_chars): Rewrite to not calculate an address outside buffer.
185
	(Ffind_operation_coding_system): NATNUMP can eval its arg twice.
186
	Don't access memory outside of the args array.
187
	(Fdefine_coding_system_internal): Check for charset-id overflow.
188 189
	(ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
	result of ENCODE_CHAR.
190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233
	* coding.h: Adjust decls to match defn changes elsewhere.
	(struct coding_system):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* composite.c (get_composition_id, find_composition)
	(run_composition_function, update_compositions)
	(compose_text, composition_gstring_put_cache)
	(composition_gstring_p, composition_gstring_width)
	(fill_gstring_header, fill_gstring_body, autocmp_chars)
	(composition_compute_stop_pos, composition_reseat_it)
	(composition_update_it, struct position_record)
	(find_automatic_composition, composition_adjust_point)
	(Fcomposition_get_gstring, Ffind_composition_internal):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(update_compositions):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* composite.h: Adjust decls to match defn changes elsewhere.
	(struct composition):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
	Do not attempt to compute the address of the object just before a
	buffer; this is not portable.
	(Faref, Faset):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Faset): Use int, not EMACS_INT, where int is wide enough.
	(Fstring_to_number): Don't assume fixnums fit in int.
	(Frem): Don't assume arg is nonnegative.
	* dbusbind.c (xd_append_arg): Check for integers out of range.
	(Fdbus_call_method): Don't overflow the timeout int.
	* dired.c (directory_files_internal, file_name_completion, scmp)
	(file_name_completion_stat):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(file_name_completion): Don't overflow matchcount.
	(file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
	* dispextern.h: Adjust decls to match defn changes elsewhere.
	(struct text_pos, struct glyph, struct bidi_saved_info)
	(struct bidi_string_data, struct bidi_it, struct composition_it)
	(struct it):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(struct display_pos, struct composition_it, struct it):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* dispnew.c (increment_matrix_positions)
	(increment_row_positions, mode_line_string)
	(marginal_area_string):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
234
	(change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(duration_to_sec_usec): New function, to check for overflow better.
	(Fsleep_for, sit_for): Use it.
	* doc.c (get_doc_string, store_function_docstring):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(get_doc_string, Fsnarf_documentation):
	Use int, not EMACS_INT, where int is wide enough.
	(get_doc_string):
	Use SAFE_ALLOCA, not alloca.
	Check for overflow when converting EMACS_INT to off_t.
	* doprnt.c (doprnt):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
	Don't assume uid_t fits into fixnum.
	(buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
	(Ffield_string, Ffield_string_no_properties, Ffield_beginning)
	(Ffield_end, Fconstrain_to_field, Fline_beginning_position)
	(Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
	(general_insert_function)
	(Finsert_char, make_buffer_string, make_buffer_string_both)
	(update_buffer_properties, Fbuffer_substring)
	(Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
	(Fsubst_char_in_region, check_translation)
	(Ftranslate_region_internal, save_restriction_restore, Fformat)
	(transpose_markers, Ftranspose_regions):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(clip_to_bounds): Move to lisp.h as an inline function).
	(Fconstrain_to_field): Don't assume integers are nonnegative.
	(Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
	(Fsubst_char_in_region, Fsave_restriction):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Femacs_pid): Don't assume pid_t fits into fixnum.
	(lo_time): Use int, not EMACS_INT, when int suffices.
	(lisp_time_argument): Check for usec out of range.
	(Fencode_time): Don't assume fixnum fits in int.
270 271 272
	(Fuser_login_name, Fuser_full_name): Signal an error
	if a uid argument is out of range, rather than relying on
	undefined behavior.
273 274
	(Fformat_time_string): Remove now-unnecessary check.
	lisp_time_argument checks for out-of-range usec now.
275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
	* emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
	(gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
	(PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
	(init_cmdargs, Fdump_emacs):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fkill_emacs): Don't assume fixnum fits in int; instead, take just
	the bottom (typically) 32 bits of the fixnum.
	* eval.c (specpdl_size, call_debugger):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(when_entered_debugger, Fbacktrace_debug):
	Don't assume fixnum can fit in int.
	(Fdefvaralias, Fdefvar): Do not attempt to compute the address of
	the object just before a buffer; this is not portable.
	(FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
	(grow_specpdl, unbind_to):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
	(grow_specpdl): Simplify allocation by using xpalloc.
293
	(Fprog1, Fprog2): Don't assume list length fits in int.  Simplify.
294 295 296 297 298 299 300 301 302 303 304 305 306
	* fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
	(Finsert_file_contents, Fwrite_region, Fdo_auto_save):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
	(a_write, e_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fcopy_file, non_regular_nbytes, read_non_regular)
	(Finsert_file_contents):
	Use int, not EMACS_INT, where int is wide enough.
	(READ_BUF_SIZE): Verify that it fits in int.
	(Finsert_file_contents): Check that counts are in proper range,
	rather than assuming fixnums fit into ptrdiff_t etc.
	Don't assume fixnums fit into int.
307
	* floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
Paul Eggert's avatar
Paul Eggert committed
308 309
	* fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
	(string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385
	(string_char_to_byte, string_byte_to_char)
	(string_make_multibyte, string_to_multibyte)
	(string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
	(Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
	(substring_both, Fdelete, internal_equal, Ffillarray)
	(Fclear_string, mapcar1)
	(Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
	(Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
	(larger_vector, make_hash_table, maybe_resize_hash_table)
	(hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
	(Fmaphash, secure_hash):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(concat): Check for string index and length overflow.
	(Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
	(Frequire):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(larger_vector): New API (vec, incr_min, size_max) replaces old
	one (vec, new_size, init).  This catches size overflow.
	INIT was removed because it was always Qnil.
	All callers changed.
	(INDEX_SIZE_BOUND): New macro, which calculates more precisely
	the upper bound on a hash table index size.
	(make_hash_table, maybe_resize_hash_table): Use it.
	(secure_hash): Computer start_byte and end_byte only after
	they're known to be in ptrdiff_t range.
	* font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
	(Ffont_get_glyphs, Ffont_at):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(font_style_to_value, font_prop_validate_style, font_expand_wildcards)
	(Flist_fonts, Fopen_font):
	Don't assume fixnum can fit in int.
	(check_gstring): Don't assume index can fit in int.
	(font_match_p): Check that fixnum is a character, not a nonnegative
	fixnum, since the later code needs to stuff it into an int.
	(font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
	(font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
	conversion overflow issues.
	(Fopen_font): Check for integer out of  range.
	(Ffont_get_glyphs): Don't assume index can fit in int.
	* font.h: Adjust decls to match defn changes elsewhere.
	* fontset.c (reorder_font_vector): Redo score calculation to avoid
	integer overflow.
	(num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
	printmax_t, where ptrdiff_t is wide enough.
	(Finternal_char_font):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
	(Fset_frame_height, Fset_frame_width, Fset_frame_size)
	(Fset_frame_position, x_set_frame_parameters)
	(x_set_line_spacing, x_set_border_width)
	(x_set_internal_border_width, x_set_alpha, x_figure_window_size):
	Check that fixnums are in proper range for system types.
	(frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fmodify_frame_parameters): Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	* frame.h (struct frame): Use intptr_t, not EMACS_INT, where
	intptr_t is wide enough.
	* fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
	(Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
	(Ffringe_bitmaps_at_pos): Don't assume index fits in int.
	Check for fixnum out of range.
	* ftfont.c (ftfont_list): Don't assume index fits in int.
	Check that fixnums are in proper range for system types.
	(ftfont_shape_by_flt):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
	Check that fixnums are in proper range for system types.
	* gnutls.h: Adjust decls to match defn changes elsewhere.
	* gtkutil.c (xg_dialog_run):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(update_frame_tool_bar):
	Check that fixnums are in proper range for system types.
	* image.c (parse_image_spec): Redo count calculation to avoid overflow.
Paul Eggert's avatar
Paul Eggert committed
386
	(lookup_image): Check that fixnums are in range for system types.
387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499
	* indent.c (last_known_column, last_known_column_point):
	(current_column_bol_cache):
	(skip_invisible, current_column, check_display_width):
	(check_display_width, scan_for_column, current_column_1)
	(Findent_to, Fcurrent_indentation, position_indentation)
	(indented_beyond_p, Fmove_to_column, compute_motion):
	(Fcompute_motion, Fvertical_motion):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(last_known_column_modified): Use EMACS_INT, not int.
	(check_display_width):
	(Fcompute_motion):
	Check that fixnums and floats are in proper range for system types.
	(compute_motion): Don't assume index or fixnum fits in int.
	(compute_motion, Fcompute_motion):
	Use int, not EMACS_INT, when it is wide enough.
	(vmotion): Omit local var start_hpos that is always 0; that way
	we don't need to worry about overflow in expressions involving it.
	* indent.h: Adjust decls to match defn changes elsewhere.
	(struct position):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	Use int, not EMACS_INT, where int is wide enough.
	Remove unused members ovstring_chars_done and tab_offset;
	all uses removed.
	* insdel.c (move_gap, move_gap_both, gap_left, gap_right)
	(adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
	(adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
	(make_gap, copy_text, insert, insert_and_inherit)
	(insert_before_markers, insert_before_markers_and_inherit)
	(insert_1, count_combining_before, count_combining_after)
	(insert_1_both, insert_from_string)
	(insert_from_string_before_markers, insert_from_string_1)
	(insert_from_gap, insert_from_buffer, insert_from_buffer_1)
	(adjust_after_replace, adjust_after_insert, replace_range)
	(replace_range_2, del_range, del_range_1, del_range_byte)
	(del_range_both, del_range_2, modify_region)
	(prepare_to_modify_buffer, signal_before_change)
	(signal_after_change, Fcombine_after_change_execute):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* intervals.c (traverse_intervals, rotate_right, rotate_left)
	(balance_an_interval, split_interval_right, split_interval_left)
	(find_interval, next_interval, update_interval)
	(adjust_intervals_for_insertion, delete_node, delete_interval)
	(interval_deletion_adjustment, adjust_intervals_for_deletion)
	(static_offset_intervals, offset_intervals)
	(merge_interval_right, merge_interval_left, make_new_interval)
	(graft_intervals_into_buffer, temp_set_point_both)
	(temp_set_point, set_point, adjust_for_invis_intang)
	(set_point_both, move_if_not_intangible, get_property_and_range)
	(get_local_map, copy_intervals, copy_intervals_to_string)
	(compare_string_intervals, set_intervals_multibyte_1):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* intervals.h: Adjust decls to match defn changes elsewhere.
	(struct interval):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* keyboard.c (this_command_key_count, this_single_command_key_start)
	(before_command_key_count, before_command_echo_length, echo_now)
	(echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
	(command_loop_1, safe_run_hooks, read_char, timer_check_2)
	(menu_item_eval_property, read_key_sequence, Fread_key_sequence)
	(Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(last_non_minibuf_size, last_point_position, echo_truncate)
	(command_loop_1, adjust_point_for_property, read_char, gen_help_event)
	(make_lispy_position, make_lispy_event, parse_modifiers_uncached)
	(parse_modifiers, modify_event_symbol, Fexecute_extended_command)
	(stuff_buffered_input):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(last_auto_save, command_loop_1, read_char):
	Use EMACS_INT, not int, to avoid integer overflow.
	(record_char): Avoid overflow in total_keys computation.
	(parse_modifiers_uncached): Redo index calculation to avoid overflow.
	* keyboard.h: Adjust decls to match defn changes elsewhere.
	* keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
	(Fkey_description, Fdescribe_vector, Flookup_key):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(click_position): New function, to check that positions are in range.
	(Fcurrent_active_maps):
	(describe_command):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Faccessible_keymaps, Fkey_description):
	(preferred_sequence_p):
	Don't assume fixnum can fit into int.
	(Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
	Check for integer overflow in size calculations.
	(Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
	avoid mishandling large integers.
	* lisp.h: Adjust decls to match defn changes elsewhere.
	(ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
	(struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
	(struct Lisp_Marker):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(clip_to_bounds): Now an inline function, moved here from editfns.c.
	(GLYPH_CODE_P): Check for overflow in system types, subsuming the
	need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
	All callers changed.
	(GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
	Assume the arg has valid form, since it always does.
	(TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
	unsigned integer system type.
	(CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
	(struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
	(duration_to_sec_usec): New decl.
	* lread.c (read_from_string_index, read_from_string_index_byte)
	(read_from_string_limit, readchar, unreadchar, openp)
	(read_internal_start, read1, oblookup):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fload, readevalloop, Feval_buffer, Feval_region):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(openp): Check for out-of-range argument to 'access'.
	(read1): Use int, not EMACS_INT, where int is wide enough.
	Don't assume fixnum fits into int.
500
	Fix off-by-one error that can read outside a buffer.
501 502
	(read_filtered_event): Use duration_to_sec_usec
	to do proper overflow checking on durations.
503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
	* macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
	in size calculation.
	(Fexecute_kbd_macro):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* marker.c (cached_charpos, cached_bytepos, CONSIDER)
	(byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
	(buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
	(set_marker_both, set_marker_restricted_both, marker_position)
	(marker_byte_position, Fbuffer_has_markers_at):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
	* menu.c (ensure_menu_items): Renamed from grow_menu_items.
	It now merely ensures that the menu is large enough, without
	necessarily growing it, as this avoids some integer overflow issues.
	All callers changed.
	(keymap_panes, parse_single_submenu, Fx_popup_menu):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	(find_and_return_menu_selection): Avoid unnecessary casts of pointers
	to EMACS_INT.  Check that fixnums are in proper range for system types.
	* minibuf.c (minibuf_prompt_width, string_to_object)
	(Fminibuffer_contents, Fminibuffer_contents_no_properties)
	(Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(get_minibuffer, read_minibuf_unwind):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
	this simplifies overflow checking.  All callers changed.
	(read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
	(Ftest_completion):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
	(x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
	Check that fixnums are in proper range for system types.
	(Fx_create_frame, Fx_show_tip):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* nsfont.m (ns_findfonts, nsfont_list_family):
	Don't assume fixnum fits in long.
	* nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
	wide enough.
546
	* nsselect.m (ns_get_local_selection, clean_local_selection_data):
547 548 549 550 551 552 553 554 555 556 557 558
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
	(PRINTDECLARE, PRINTPREPARE):
	(strout, print_string):
	(print, print_preprocess, print_check_string_charset_prop)
	(print_object):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(PRINTDECLARE):
	(temp_output_buffer_setup, Fprin1_to_string, print_object):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
	(printchar, strout): Use xpalloc to catch size calculation overflow.
559
	(Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
560 561
	(print_error_message): Use SAFE_ALLOCA, not alloca.
	(print_object): Use int, not EMACS_INT, where int is wide enough.
562 563
	(print_depth, new_backquote_output, print_number_index):
	Use ptrdiff_t, not int, where int might not be wide enough.
564 565 566
	* process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
	(Fset_process_window_size, Fformat_network_address)
	(get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
567
	(sigchld_handler):
568
	Check that fixnums are in proper range for system types.
569
	(Fsignal_process): Simplify by avoiding a goto.
570 571
	Check for process-ids out of pid_t range rather than relying on
	undefined behavior.
572 573 574 575 576 577 578 579 580
	(Fformat_network_address, read_process_output, send_process)
	(Fprocess_send_region, status_notify):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fformat_network_address, Fmake_serial_process, Fmake_network_process)
	(wait_reading_process_output, read_process_output, exec_sentinel):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
	(Faccept_process_output): Use duration_to_sec_usec to do proper
	overflow checking on durations.
581 582
	(emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
	Don't assume pid_t fits in int.
583 584
	* puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
	configured --with-wide-int.
585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
	* scroll.c (calculate_scrolling, calculate_direct_scrolling)
	(line_ins_del): Use int, not EMACS_INT, where int is wide enough.
	* search.c (looking_at_1, string_match_1):
	(fast_string_match, fast_c_string_match_ignore_case)
	(fast_string_match_ignore_case, fast_looking_at, scan_buffer)
	(scan_newline, find_before_next_newline, search_command)
	(trivial_regexp_p, search_buffer, simple_search, boyer_moore)
	(set_search_regs, wordify):
	(Freplace_match):
	(Fmatch_data):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(string_match_1, search_buffer, set_search_regs):
	(Fmatch_data):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(wordify): Check for overflow in size calculation.
	(Freplace_match): Avoid potential buffer overflow in search_regs.start.
	(Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
	Check that fixnums are in proper range for system types.
	* sound.c (struct sound_device)
	(wav_play, au_play, vox_write, alsa_period_size, alsa_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fplay_sound_internal):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
608
	* syntax.c (struct lisp_parse_state, find_start_modiff)
609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630
	(Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
	(Fparse_partial_sexp):
	Don't assume fixnums can fit in int.
	(struct lisp_parse_state, find_start_pos, find_start_value)
	(find_start_value_byte, find_start_begv)
	(update_syntax_table, char_quoted, dec_bytepos)
	(find_defun_start, prev_char_comend_first, back_comment):
	(scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
	(scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Finternal_describe_syntax_value): Check that match_lisp is a
	character, not an integer, since the code stuffs it into int.
	(scan_words, scan_sexps_forward):
	Check that fixnums are in proper range for system types.
	(Fforward_word):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(scan_sexps_forward):
	Use CHARACTERP, not INTEGERP, since the value must fit into int.
	(Fparse_partial_sexp): Fix doc; element 8 is not ignored.
	* syntax.h: Adjust decls to match defn changes elsewhere.
	(struct gl_state_s):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
631 632
	(SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
	MOST_POSITIVE_FIXNUM.
633 634 635 636 637
	* sysdep.c (wait_for_termination_1, wait_for_termination)
	(interruptible_wait_for_termination, mkdir):
	Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
	(emacs_read, emacs_write):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 639
	(system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
	and double all fit in int.
640 641 642 643 644 645 646 647 648 649 650 651 652 653
	* term.c (set_tty_color_mode):
	Check that fixnums are in proper range for system types.
	* termhooks.h (struct input_event):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* textprop.c (validate_interval_range, interval_of)
	(Fadd_text_properties, set_text_properties_1)
	(Fremove_text_properties, Fremove_list_of_text_properties)
	(Ftext_property_any, Ftext_property_not_all)
	(copy_text_properties, text_property_list, extend_property_ranges)
	(verify_interval_modification):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fnext_single_char_property_change)
	(Fprevious_single_char_property_change):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
Paul Eggert's avatar
Paul Eggert committed
654 655
	(copy_text_properties):
	Check for integer overflow in index calculation.
656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672
	* undo.c (last_boundary_position, record_point, record_insert)
	(record_delete, record_marker_adjustment, record_change)
	(record_property_change):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
	(Fx_hide_tip, Fx_file_dialog):
	* w32menu.c (set_frame_menubar):
	Use ptrdiff_t, not int, for consistency with rest of code.
	* window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
	(select_window, Fdelete_other_windows_internal)
	(window_scroll_pixel_based, window_scroll_line_based)
	(Frecenter, Fset_window_configuration):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(Fset_window_hscroll, run_window_configuration_change_hook)
	(set_window_buffer, temp_output_buffer_show, scroll_command)
Paul Eggert's avatar
Paul Eggert committed
673
	(Fscroll_other_window, Frecenter):
674 675 676 677 678 679 680 681 682 683
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
	Don't assume fixnum fits in int.
	(Fset_window_scroll_bars):
	Check that fixnums are in proper range for system types.
	* xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
	(string_pos, c_string_pos, number_of_chars, init_iterator)
	(in_ellipses_for_invisible_text_p, init_from_display_pos)
	(compute_stop_pos, next_overlay_change, compute_display_string_pos)
	(compute_display_string_end, handle_face_prop)
Paul Eggert's avatar
Paul Eggert committed
684 685
	(face_before_or_after_it_pos, handle_invisible_prop)
	(handle_display_prop, handle_display_spec, handle_single_display_spec)
686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723
	(display_prop_intangible_p, string_buffer_position_lim)
	(string_buffer_position, handle_composition_prop, load_overlay_strings)
	(get_overlay_strings_1, get_overlay_strings)
	(iterate_out_of_display_property, forward_to_next_line_start)
	(back_to_previous_visible_line_start, reseat, reseat_to_string)
	(get_next_display_element, set_iterator_to_next)
	(get_visually_first_element, compute_stop_pos_backwards)
	(handle_stop_backwards, next_element_from_buffer)
	(move_it_in_display_line_to, move_it_in_display_line)
	(move_it_to, move_it_vertically_backward, move_it_by_lines)
	(add_to_log, message_dolog, message_log_check_duplicate)
	(message2, message2_nolog, message3, message3_nolog
	(with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
	(current_message_1, truncate_echo_area, truncate_message_1)
	(set_message, set_message_1, store_mode_line_noprop)
	(hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
	(text_outside_line_unchanged_p, check_point_in_composition)
	(reconsider_clip_changes)
	(redisplay_internal, set_cursor_from_row, try_scrolling)
	(try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
	(redisplay_window, find_last_unchanged_at_beg_row)
	(find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
	(trailing_whitespace_p, find_row_edges, display_line)
	(RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
	(display_mode_element, store_mode_line_string)
	(pint2str, pint2hrstr, decode_mode_spec)
	(display_count_lines, display_string, draw_glyphs)
	(x_produce_glyphs, x_insert_glyphs)
	(rows_from_pos_range, mouse_face_from_buffer_pos)
	(fast_find_string_pos, mouse_face_from_string_pos)
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(safe_call, init_from_display_pos, handle_fontified_prop)
	(handle_single_display_spec, load_overlay_strings)
	(with_echo_area_buffer, setup_echo_area_for_printing)
	(display_echo_area, echo_area_display)
	(x_consider_frame_title, prepare_menu_bars, update_menu_bar)
	(update_tool_bar, hscroll_window_tree, redisplay_internal)
Paul Eggert's avatar
Paul Eggert committed
724 725
	(redisplay_window, dump_glyph_row, display_mode_line)
	(Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
726
	(handle_display_spec, display_prop_string_p):
727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(handle_single_display_spec, build_desired_tool_bar_string)
	(redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
	(get_specified_cursor_type):
	Check that fixnums are in proper range for system types.
	(struct overlay_entry, resize_mini_window, Fdump_glyph_row)
	(Flookup_image_map):
	Don't assume fixnums fit in int.
	(compare_overlay_entries):
	Avoid mishandling comparisons due to subtraction overflow.
	(load_overlay_strings): Use SAFE_NALLOCA, not alloca.
	(last_escape_glyph_face_id, last_glyphless_glyph_face_id):
	(handle_tool_bar_click):
	Use int, not unsigned, since we prefer signed and the signedness
	doesn't matter here.
	(get_next_display_element, next_element_from_display_vector):
	Use int, not EMACS_INT, when int is wide enough.
	(start_hourglass): Use duration_to_sec_usec to do proper
	overflow checking on durations.
	* xfaces.c (Fbitmap_spec_p):
	Check that fixnums are in proper range for system types.
	(compare_fonts_by_sort_order):
	Avoid mishandling comparisons due to subtraction overflow.
	(Fx_family_fonts, realize_basic_faces):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fx_family_fonts):
	Don't assume fixnum fits in int.
	Use SAFE_ALLOCA_LISP, not alloca.
	(merge_face_heights): Remove unnecessary cast to EMACS_INT.
	(Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
	(face_at_buffer_position, face_for_overlay_string)
	(face_at_string_position):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	(merge_faces): Use int, not EMACS_INT, where int is wide enough.
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
	(Fx_show_tip):
	Check that fixnums are in proper range for system types.
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip)
	(Fx_hide_tip, Fx_file_dialog, Fx_select_font):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(Fx_change_window_property): Don't assume fixnums fit in int.
	* xfont.c (xfont_chars_supported):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xmenu.c (Fx_popup_dialog, set_frame_menubar)
	(create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xml.c (parse_region):
	* xrdb.c (magic_file_p):
	Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
	* xselect.c (TRACE1): Don't assume pid_t promotes to int.
	(x_get_local_selection, x_reply_selection_request)
	(x_handle_selection_request, wait_for_property_change):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	(selection_data_to_lisp_data): Use short, not EMACS_INT, where
	short is wide enough.
	(x_send_client_event): Don't assume fixnum fits in int.
	* xterm.c (x_x_to_emacs_modifiers):
	Don't assume EMACS_INT overflows nicely into int.
	(x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
	may come from Lisp.
	(handle_one_xevent): NATNUMP can eval its arg twice.
	(x_connection_closed):
	Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
	* xterm.h: Adjust decls to match defn changes elsewhere.
	(struct scroll_bar): Use struct vectorlike_header
	rather than rolling our own approximation.
	(SCROLL_BAR_VEC_SIZE): Remove; not used.

795 796 797 798
2012-04-22  Leo Liu  <sdl.web@gmail.com>

	* sysdep.c (list_system_processes): Support Darwin (Bug#5725).

799 800 801 802 803 804 805
2012-04-22  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c [__FreeBSD__]: Minor cleanups.
	(list_system_processes, system_process_attributes) [__FreeBSD__]:
	Use Emacs indenting style more consistently.  Avoid some casts.
	Use 'double' consistently rather than mixing 'float' and 'double'.

806 807 808 809 810
2012-04-21  Eduard Wiebe  <usenet@pusto.de>

	* sysdep.c (list_system_processes, system_process_attributes): Add
	implementation for FreeBSD (Bug#5243).

Andreas Schwab's avatar
Andreas Schwab committed
811 812 813 814
2012-04-21  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.mk (lisp): Update.

815 816 817 818 819
2012-04-20  Paul Eggert  <eggert@cs.ucla.edu>

	* keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
	It is never used otherwise.

820 821 822 823 824 825 826
2012-04-20  Stefan Monnier  <monnier@iro.umontreal.ca>

	* print.c (print_preprocess): Only check print_depth if print-circle
	is nil.
	(print_object): Check for cycles even when print-circle is nil and
	print-gensym is t, but only check print_depth if print-circle is nil.

827 828 829 830 831
2012-04-20  Chong Yidong  <cyd@gnu.org>

	* process.c (wait_reading_process_output): If EIO occurs on a pty,
	set the status to "failed" and ensure that sentinel is run.

Chong Yidong's avatar
Chong Yidong committed
832
2012-04-20  Glenn Morris  <rgm@gnu.org>
833 834 835

	* process.c (Fset_process_inherit_coding_system_flag)
	(Fset_process_query_on_exit_flag): Doc fix (mention return value).
836
	(Fmake_network_process, Fmake_serial_process): Doc fix.
837

Chong Yidong's avatar
Chong Yidong committed
838
2012-04-20  Eli Zaretskii  <eliz@gnu.org>
839 840 841 842 843 844

	* xdisp.c (string_buffer_position_lim): Limit starting position to
	BEGV.
	(set_cursor_from_row): If called for a mode-line or header-line
	row, return zero immediately.
	(try_cursor_movement): If inside continuation line, don't back up
845 846
	farther than the first row after the header line, if any.
	Don't consider the header-line row as "partially visible", even if
847 848
	MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero.  (Bug#11261)

Chong Yidong's avatar
Chong Yidong committed
849
2012-04-20  Atsuo Ohki  <ohki@gssm.otsuka.tsukuba.ac.jp>  (tiny change)
850

851 852
	* lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
	(bug#11238).
853

Chong Yidong's avatar
Chong Yidong committed
854
2012-04-20  Teodor Zlatanov  <tzz@lifelogs.com>
Paul Eggert's avatar
Paul Eggert committed
855
2012-04-18  Paul Eggert  <eggert@cs.ucla.edu>
Paul Eggert's avatar
Paul Eggert committed
856 857 858 859 860 861 862 863 864 865 866 867

	configure: new option --enable-gcc-warnings (Bug#11207)
	* Makefile.in (C_WARNINGS_SWITCH): Remove.
	(WARN_CFLAGS, WERROR_CFLAGS): New macros.
	(ALL_CFLAGS): Use new macros rather than old.
	* process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
	* regex.c: Ignore -Wstrict-overflow.  If !emacs, also ignore
	-Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
	-Wunused-result, -Wunused-variable.  This should go away once
	the Emacs and Gnulib regex code is merged.
	(xmalloc, xrealloc): Now static.

868 869 870 871
2012-04-17  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Fsystem_groups): Remove unused local.

872 873 874 875
2012-04-17  Glenn Morris  <rgm@gnu.org>

	* dired.c (Fsystem_users): Doc fix.

876 877 878 879 880
2012-04-17  Dmitry Antipov  <dmantipov@yandex.ru>

	* dired.c (Fsystem_users, Fsystem_groups): New functions.  (Bug#7900)
	(syms_of_dired): Add them.

881 882
2012-04-16  Paul Eggert  <eggert@cs.ucla.edu>

883 884 885 886 887 888 889 890
	Fix minor alloc.c problems found by static checking.
	* alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
	New extern decls, to avoid calling undeclared functions.
	(dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
	&& GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
	GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
	(NEED_MEM_INSERT): New macro.
	(mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
891
	Remove one incorrect comment and fix another.
892

893 894 895 896 897 898
	Fix minor ralloc.c problems found by static checking.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
	* ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
	(r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
	(r_alloc_sbrk): Now static.

899 900 901 902 903 904 905 906 907
	Improve ralloc.c interface checking.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
	* buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
	(r_alloc_free) [REL_ALLOC]: Move decls from here ...
	* lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
	[REL_ALLOC]: ... to here, to check interface.
	* m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
	Remove decls.  This fixes an "It stinks!".

908 909
	* alloc.c (which_symbols): Fix alignment issue / type clash.

910 911 912 913 914 915 916 917 918 919 920
2012-04-15  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.h (struct Lisp_Symbol): Remove explicit padding.
	(struct Lisp_Misc_Any): Likewise.
	(struct Lisp_Free): Likewise.
	* alloc.c (union aligned_Lisp_Symbol): Define.
	(SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
	aligned_Lisp_Symbol instead of struct Lisp_Symbol.
	(union aligned_Lisp_Misc): Define.
	(MARKER_BLOCK_SIZE, struct marker_block): Use union
	aligned_Lisp_Misc instead of union Lisp_Misc.
921
	(Fmake_symbol, allocate_misc, gc_sweep): Adjust.
922

923 924 925 926 927 928 929 930 931 932 933 934
2012-04-14  Paul Eggert  <eggert@cs.ucla.edu>

	Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
	* lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
	* s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
	* s/netbsd.h, s/sol2-6.h:
	Remove definition of GC_MARK_STACK, since the default now works.
	* s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
	Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
	no longer the default.
	* s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.

935
2012-04-14  Atsuo Ohki  <ohki@gssm.otsuka.tsukuba.ac.jp>  (tiny change)
936

937 938
	* lread.c (lisp_file_lexically_bound_p):
	Fix hang at ";-*-\n" (bug#11238).
939

940 941 942 943 944 945 946 947 948 949
2012-04-14  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
	"unchanged" if its end.pos is beyond ZV.  (Bug#11199)

2012-04-14  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (constrainFrameRect): Always constrain when there is only
	one screen (Bug#10962).

950 951 952 953
2012-04-13  Ken Brown  <kbrown@cornell.edu>

	* s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.

954 955 956 957
2012-04-13  Reuben Thomas  <rrt@sc3d.org>

	* indent.c (Fmove_to_column): Change interactive spec (Bug#739).

958 959 960 961 962 963
2012-04-11  Daniel Colascione  <dancol@dancol.org>

	* s/cygwin.h: The vfork the #define in cygwin.h was protecting
	against is gone.  It's better to use vfork now so that when Cygwin
	gains a new, working vfork, we use it automatically (bug#10398).

964 965 966 967
2012-04-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* window.c (save_window_save): Obey window-point-insertion-type.

968 969 970 971
2012-04-11  Glenn Morris  <rgm@gnu.org>

	* Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.

972 973 974 975
2012-04-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* alloc.c (lisp_align_malloc): Remove unneeded prototype.

Juanma Barranquero's avatar
Juanma Barranquero committed
976
2012-04-10  Jason S. Cornez  <jcornez@ravenpack.com>  (tiny change)
977 978 979 980 981

	* keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
	(force_quit_count): New var.
	(handle_interrupt): Use it.

982 983 984 985 986
2012-04-10  Juanma Barranquero  <lekktu@gmail.com>

	* w32.c (w32_delayed_load): Record the full path of the library
	being loaded (bug#10424).

987 988
2012-04-09  Glenn Morris  <rgm@gnu.org>

Glenn Morris's avatar
Glenn Morris committed
989 990 991
	* doc.c (Fsnarf_documentation): Check variables, functions are bound,
	not just in the obarray, before snarfing them.  (Bug#11036)

992 993 994
	* Makefile.in ($(leimdir)/leim-list.el):
	Pass EMACS rather than BUILT_EMACS.

995 996 997 998 999 1000
2012-04-09  Teodor Zlatanov  <tzz@lifelogs.com>

	* process.c (make_process):
	* process.h: Add integer `gnutls_handshakes_tried' member to
	process struct.

1001 1002
	* gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
	Add convenience `GNUTLS_LOG2i' macro.
1003 1004 1005 1006 1007 1008 1009

	* gnutls.c (gnutls_log_function2i): Convenience log function.
	(emacs_gnutls_read): Use new log functions,
	`gnutls_handshakes_tried' process member, and
	`GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
	attempts per process (connection).

1010 1011 1012 1013 1014 1015 1016 1017 1018
2012-04-09  Chong Yidong  <cyd@gnu.org>

	* eval.c (Fuser_variable_p, user_variable_p_eh)
	(lisp_indirect_variable): Functions deleted.
	(Fdefvar): Caller changed.

	* callint.c (Finteractive, Fcall_interactively):
	* minibuf.c (Fread_variable): Callers changed.

1019 1020 1021 1022 1023 1024 1025 1026
2012-04-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (set_cursor_from_row): If the display string appears in
	the buffer at position that is closer to point than the position
	after the display string, display the cursor on the first glyph of
	the display string.  Fixes cursor display when a 'display' text
	property immediately follows invisible text.  (Bug#11094)

1027 1028 1029 1030 1031 1032 1033
2012-04-09  Paul Eggert  <eggert@cs.ucla.edu>

	composite.c: use 'double' consistently
	* composite.c (get_composition_id): Use 'double' consistently
	instead of converting 'float' to 'double' and vice versa; this is
	easier to understand and avoids a GCC warning.

1034 1035
2012-04-09  Glenn Morris  <rgm@gnu.org>

1036 1037 1038 1039 1040 1041
	* Makefile.in: Generate leim-list with bootstrap-emacs, in
	preparation for dumping it with emacs.  (Bug#4789)
	(leimdir): New variable.
	($(leimdir)/leim-list.el): New rule.
	(emacs$(EXEEXT)): Depend on leim-list.el.

1042 1043 1044 1045
	* buffer.c (Qucs_set_table_for_input): Remove.  (Bug#9821)
	(Fget_buffer_create): Don't call Qucs_set_table_for_input.
	(init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.

1046 1047 1048 1049 1050
2012-04-08  Andreas Schwab  <schwab@linux-m68k.org>

	* lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
	proper alignment.

1051 1052 1053 1054 1055
2012-04-07  Juanma Barranquero  <lekktu@gmail.com>

	* xml.c (init_libxml2_functions) [WINDOWSNT]:
	Remove unused local variable.

1056 1057 1058 1059 1060 1061 1062 1063 1064
2012-04-07  Paul Eggert  <eggert@cs.ucla.edu>

	Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
	* alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
	(mark_memory): Mark Lisp_Objects only if pointers might hide in
	objects, as mark_maybe_pointer will catch them otherwise.
	(GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
	* s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.

1065 1066 1067 1068 1069
2012-04-07  Paul Eggert  <eggert@cs.ucla.edu>

	Fix typo that broke non-Windows builds.
	* xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.

1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
2012-04-07  Eli Zaretskii  <eliz@gnu.org>

	Support building on MS-Windows with libxml2.

	* makefile.w32-in (OBJ2): Add xml.$(O).
	(GLOBAL_SOURCES): Add xml.c.
	($(BLD)/xml.$(O)): New dependency list.

	* xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
	(fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
	(fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
	[!WINDOWSNT]: New macros.
	(init_libxml2_functions, libxml2_loaded_p): New functions.
	(parse_region): Call fn_xmlCheckVersion instead of using the macro
	LIBXML_TEST_VERSION.  Call libxml2 functions via the fn_* macros.
	(xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
	Calls xmlCleanupParser only if libxml2 was loaded (or statically
	linked in).
1088 1089
	(Flibxml_parse_html_region, Flibxml_parse_xml_region):
	Call init_libxml2_functions before calling libxml2 functions.
1090 1091 1092 1093 1094 1095 1096 1097
	(syms_of_xml) <Qlibxml2_dll>: DEFSYM it.

	* emacs.c: Don't include libxml/parser.h.
	(shut_down_emacs): Call xml_cleanup_parser, instead of calling
	xmlCleanupParser directly.

	* lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.

1098 1099 1100 1101 1102 1103
2012-04-07  Eli Zaretskii  <eliz@gnu.org>

	* indent.c (Fvertical_motion): If there is a display string at
	point, use it.vpos to compute how many lines to backtrack after
	move_it_to point.  (Bug#11133)

1104 1105 1106 1107 1108 1109 1110 1111 1112
2012-04-06  Eli Zaretskii  <eliz@gnu.org>

	* buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
	* character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
	about subtle differences between FETCH_CHAR* and STRING_CHAR*
	macros related to unification of CJK characters.  For the details,
	see the discussion following the message here:
	http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.

1113 1114 1115 1116
2012-04-04  Chong Yidong  <cyd@gnu.org>

	* keyboard.c (Vdelayed_warnings_list): Doc fix.

1117 1118 1119 1120 1121
2012-04-01  Eli Zaretskii  <eliz@gnu.org>

	* w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
	instead of alloca.  (Bug#11138)

Andreas Schwab's avatar
Andreas Schwab committed
1122 1123 1124 1125 1126
2012-04-01  Andreas Schwab  <schwab@linux-m68k.org>

	* w32menu.c (is_simple_dialog): Properly check lisp types.
	(Bug#11141)

1127 1128
2012-03-31  Eli Zaretskii  <eliz@gnu.org>

1129 1130 1131 1132 1133
	* xdisp.c (move_it_by_lines): When DVPOS is positive, and the
	position we get to after a call to move_it_to fails the
	IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
	only if we wind up in a string from display property.  (Bug#11063)

1134 1135 1136 1137
	* window.c (Fdelete_other_windows_internal): Invalidate the row
	and column information about mouse highlight, so that redisplay
	restores it after reallocating the glyph matrices.  (Bug#7464)

1138 1139 1140 1141
	* xdisp.c (set_cursor_from_row): If `cursor' property on a display
	string comes from a `display' text property, use the buffer
	position of that property as if we actually saw that position in
	the row's glyphs.
1142 1143 1144 1145
	(move_it_by_lines): Remove the assertion that
	"it->current_x == 0 && it->hpos == 0" which can be legitimately
	violated when there's a before-string at the beginning of a line.
	(Bug#11063)
1146

1147 1148 1149 1150 1151 1152 1153 1154 1155
2012-03-30  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (append_space_for_newline): If the default face was
	remapped, use the remapped face for the appended newline.
	(extend_face_to_end_of_line): Use the remapped default face for
	extending the face to the end of the line.
	(display_line): Call extend_face_to_end_of_line when the default
	face was remapped.  (Bug#11068)

1156 1157 1158 1159
2012-03-29  Eli Zaretskii  <eliz@gnu.org>

	* s/ms-w32.h: Discourage from defining HAVE_GETCWD.

1160 1161 1162 1163
2012-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hooks_error): Don't unquote strings.

1164 1165 1166 1167 1168
2012-03-27  Glenn Morris  <rgm@gnu.org>

	* search.c (Fword_search_backward_lax, Fword_search_forward_lax):
	Doc fixes.

1169 1170 1171 1172 1173
2012-03-26  Kenichi Handa  <handa@m17n.org>

	* dispextern.h (struct glyph): Fix previous change.  Change the
	bit length of glyphless.ch to 25 (Bug#11082).

1174 1175 1176 1177 1178 1179
2012-03-26  Chong Yidong  <cyd@gnu.org>

	* keyboard.c (Vselection_inhibit_update_commands): New variable.
	(command_loop_1): Use it; inhibit selection update for
	handle-select-window too (Bug#8996).

1180 1181
2012-03-25  Fabrice Popineau  <fabrice.popineau@supelec.fr>

1182
	* w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1183

1184 1185 1186 1187 1188
2012-03-25  Kenichi Handa  <handa@m17n.org>

	* dispextern.h (struct glyph): Change the bit length of
	glyphless.ch to 22 to make the member glyphless fit in 32 bits.

1189 1190 1191 1192 1193
2012-03-24  Eli Zaretskii  <eliz@gnu.org>

	* s/ms-w32.h (tzname): Include time.h before redirecting to
	_tzname.  Fixes the MSVC build.  (Bug#9960)

Andreas Schwab's avatar
Andreas Schwab committed
1194 1195
2012-03-24  Andreas Schwab  <schwab@linux-m68k.org>

1196 1197 1198
	* xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
	characters.

Andreas Schwab's avatar
Andreas Schwab committed
1199 1200 1201
	* xterm.c (XTread_socket): Only modify handling_signal if
	!SYNC_INPUT.  (Bug#11080)

1202 1203 1204 1205 1206 1207 1208 1209
2012-03-23  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
	FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES.  Prevents crashes
	when fetching a multibyte character consumes more bytes than
	CHAR_BYTES returns, due to unification of CJK characters in
	string_char.  (Bug#11073)

1210 1211 1212 1213 1214
2012-03-23  Troels Nielsen  <bn.troels@gmail.com>  (tiny change)

	* process.c (wait_reading_process_output): Handle pty disconnect
	by refraining from sending oneself a SIGCHLD (bug#10933).

1215 1216 1217 1218
2012-03-22  Chong Yidong  <cyd@gnu.org>

	* dispextern.h (struct it): New member string_from_prefix_prop_p.

1219
	* xdisp.c (push_prefix_prop): Rename from push_display_prop.
1220 1221 1222 1223
	Mark string as coming from a prefix property.
	(handle_face_prop): Use default face for prefix strings (Bug#4281).
	(pop_it, reseat_1): Save and restore string_from_prefix_prop_p.

1224 1225 1226 1227
2012-03-21  Chong Yidong  <cyd@gnu.org>

	* xfaces.c (Vface_remapping_alist): Doc fix.

1228 1229 1230
2012-03-20  Eli Zaretskii  <eliz@gnu.org>

	* w32proc.c (Fw32_set_console_codepage)
1231 1232
	(Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
	Doc fixes.
1233

1234 1235 1236 1237 1238
2012-03-20  Chong Yidong  <cyd@gnu.org>

	* dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
	to reflect default non-nil value of redisplay-dont-pause.

1239 1240 1241 1242 1243
2012-03-19  Kenichi Handa  <handa@m17n.org>

	* ftfont.c (ftfont_drive_otf): Mask bits of character code to make
	it fit in a valid range (Bug#11003).

1244 1245 1246 1247 1248 1249 1250 1251
2012-03-18  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (cursor_row_p): Even if the glyph row ends in a string
	that is not from display property, accept the row as a "cursor
	row" if one of the string's character has a non-nil `cursor'
	property.  Fixes cursor positioning when there are newlines in
	overlay strings, e.g. in icomplete.el.  (Bug#11035)

1252 1253 1254 1255
2012-03-12  Paul Eggert  <eggert@cs.ucla.edu>

	* buffer.c (compare_overlays): Don't assume args differ (Bug#6830).

1256 1257 1258 1259 1260 1261 1262 1263 1264
2012-03-12  Chong Yidong  <cyd@gnu.org>

	* eval.c (inhibit_lisp_code): Rename from
	inhibit_window_configuration_change_hook; move from window.c.

	* xfns.c (unwind_create_frame_1, Fx_create_frame):
	* window.c (run_window_configuration_change_hook)
	(syms_of_window): Callers changed.

1265 1266
2012-03-11  Chong Yidong  <cyd@gnu.org>

1267 1268
	* keymap.c (Fkey_description): Doc fix (Bug#9700).

1269 1270
	* editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).

1271 1272 1273 1274 1275
2012-03-10  Chong Yidong  <cyd@gnu.org>

	* frame.c (other_visible_frames): Don't assume the selected frame
	is visible (Bug#10955).

1276 1277 1278 1279
2012-03-09  Stefan Monnier  <monnier@iro.umontreal.ca>

	* buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).

1280 1281 1282 1283 1284 1285
2012-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (x_wm_set_size_hint): Use one row in call to
	FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
	zero (Bug#10954).

1286 1287
2012-03-03  Glenn Morris  <rgm@gnu.org>

1288
	* alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1289

1290 1291 1292 1293
2012-03-02  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (try_window_reusing_current_matrix): Don't move cursor
	position past the first glyph_row that ends at ZV.  (Bug#10902)
Eli Zaretskii's avatar
Eli Zaretskii committed
1294 1295
	(redisplay_window, next_element_from_string): Fix typos in
	comments.
1296 1297
	(redisplay_window): Pass to move_it_vertically the margin in
	pixels, not in screen lines.
1298

1299 1300 1301 1302
2012-03-02  Glenn Morris  <rgm@gnu.org>

	* buffer.c (buffer-list-update-hook): Doc fix.

1303 1304 1305 1306 1307 1308 1309 1310
2012-02-29  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
	push_it before setting up the iterator for the first overlay
	string, even if we have an empty string loaded.
	(next_overlay_string): If there's an empty string on the iterator
	stack, pop the stack.  (Bug#10903)

1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321
2012-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
	Suggested by Stefan Monnier in
	<http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
	* alloc.c (widen_to_Lisp_Object): New static function.
	(mark_memory): Also mark Lisp_Objects by fetching pointer words
	and widening them to Lisp_Objects.  This would work even if
	USE_LSB_TAG is defined and wide integers are used, which might
	happen in a future version of Emacs.

1322 1323
2012-02-25  Chong Yidong  <cyd@gnu.org>

1324 1325 1326
	* fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
	Doc fix.

1327 1328 1329 1330
	* xselect.c (Fx_selection_exists_p): Doc fix.
	(x_clipboard_manager_save_all): Print an informative message
	before saving to clipboard manager.

1331 1332 1333 1334 1335
2012-02-24  Chong Yidong  <cyd@gnu.org>

	* keyboard.c (process_special_events): Handle all X selection
	requests in kbd_buffer, not just the next one (Bug#8869).

1336 1337 1338 1339 1340 1341 1342 1343
2012-02-23  Chong Yidong  <cyd@gnu.org>

	* xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
	call when setting menu-bar-lines and tool-bar-lines parameters.
	(unwind_create_frame_1): New helper function.

	* window.c (inhibit_window_configuration_change_hook): New var.
	(run_window_configuration_change_hook): Obey it.
Chong Yidong's avatar
Chong Yidong committed
1344
	(syms_of_window): Initialize it.
1345

1346 1347 1348 1349 1350
2012-02-22  Chong Yidong  <cyd@gnu.org>

	* xterm.c (x_draw_image_relief): Add missing type check for
	Vtool_bar_button_margin (Bug#10743).

1351 1352 1353 1354 1355 1356 1357
2012-02-21  Chong Yidong  <cyd@gnu.org>

	* fileio.c (Vfile_name_handler_alist): Doc fix.

	* buffer.c (Fget_file_buffer): Protect against invalid file
	handler return value.

1358 1359
2012-02-20  Paul Eggert  <eggert@cs.ucla.edu>

1360 1361 1362
	* .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
	when computing $valmask.

1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374
	Fix crash due to non-contiguous EMACS_INT (Bug#10780).
	* lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
	(USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
	It's useless in that case, and it can cause problems on hosts
	that allocate halves of EMACS_INT values separately.
	Reported by Dan Horák.  Diagnosed by Andreas Schwab in
	<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
	* mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
	UINTPTR_MAX >> VALBITS == 0.  This is required by the above change;
	it avoids undefined behavior on hosts where shifting right by more
	than the word width has undefined behavior.

1375 1376 1377 1378 1379 1380 1381 1382
2012-02-19  Chong Yidong  <cyd@gnu.org>

	* fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
	(Funhandled_file_name_directory, Ffile_name_as_directory)
	(Fdirectory_file_name, Fexpand_file_name)
	(Fsubstitute_in_file_name): Protect against invalid file handler
	return values (Bug#10845).

1383 1384 1385 1386 1387
2012-02-18  Eli Zaretskii  <eliz@gnu.org>

	* .gdbinit (pitx): Fix incorrect references to fields of the
	iterator stack.

Chong Yidong's avatar
Chong Yidong committed
1388 1389 1390 1391
2012-02-17  Chong Yidong  <cyd@gnu.org>

	* syntax.c (Fscan_lists): Doc fix (Bug#10833).

1392 1393 1394 1395 1396
2012-02-15  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
	<http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.

1397 1398 1399 1400 1401
2012-02-15  Chong Yidong  <cyd@gnu.org>

	* eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
	marked as special.  Also, starting docstrings with * is obsolete.

1402 1403 1404 1405
2012-02-13  Andreas Schwab  <schwab@linux-m68k.org>

	* gnutls.c (emacs_gnutls_write): Fix last change.

1406 1407 1408 1409 1410
2012-02-13  Lars Ingebrigtsen  <larsi@gnus.org>

	* gnutls.c (emacs_gnutls_write): Set errno appropriately for
	send_process.

1411 1412 1413 1414
2012-02-13  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keymap.c (Fsingle_key_description): Handle char ranges.

1415 1416
2012-02-12  Chong Yidong  <cyd@gnu.org>

1417 1418 1419
	* xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
	as that creates a dangerous corner case.

1420 1421 1422
	* window.c (Fdelete_window_internal): Invalidate the mouse
	highlight (Bug#9904).

1423 1424 1425 1426 1427 1428 1429 1430 1431 1432
2012-02-12  Glenn Morris  <rgm@gnu.org>

	* xselect.c (Fx_own_selection_internal)
	(Fx_get_selection_internal, Fx_disown_selection_internal)
	(Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
	* nsselect.m (Fx_own_selection_internal)
	(Fx_disown_selection_internal, Fx_selection_exists_p)
	(Fx_selection_owner_p, Fx_get_selection_internal):
	Sync docs and argument specs with the xselect.c versions.

1433 1434 1435 1436
2012-02-11  Lars Ingebrigtsen  <larsi@gnus.org>

	* gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.

1437 1438
2012-02-11  Eli Zaretskii  <eliz@gnu.org>

1439 1440 1441 1442 1443
	* w32select.c (Fx_selection_exists_p): Sync doc string and
	argument list with xselect.c.  (Bug#10783)

	* w16select.c (Fx_selection_exists_p): Sync doc string and
	argument list with xselect.c.  (Bug#10783)
1444

1445 1446 1447 1448
2012-02-10  Glenn Morris  <rgm@gnu.org>

	* fns.c (Fsecure_hash): Doc fix.

1449
2012-02-09  Kenichi Handa  <handa@m17n.org>
1450 1451 1452

	* coding.c (produce_chars): Fix updating of src_end (Bug#10701).

1453 1454 1455 1456 1457 1458
2012-02-07  Chong Yidong  <cyd@gnu.org>

	* buffer.c (Fbuffer_local_variables)
	(buffer_lisp_local_variables): Handle unbound vars correctly;
	don't let Qunbound leak into Lisp.

Glenn Morris's avatar
Glenn Morris committed
1459 1460
2012-02-07  Glenn Morris  <rgm@gnu.org>

Glenn Morris's avatar
Glenn Morris committed
1461 1462
	* image.c (Fimagemagick_types): Doc fix.

Glenn Morris's avatar
Glenn Morris committed
1463 1464 1465 1466
	* image.c (imagemagick-render-type): Change it from a lisp object
	to an integer.  Move the doc here from the lisp manual.
	Treat all values not equal to 0 the same.

1467 1468 1469 1470 1471
2012-02-06  Chong Yidong  <cyd@gnu.org>

	* doc.c (store_function_docstring): Avoid applying docstring of
	alias to base function (Bug#2603).

1472 1473 1474 1475 1476
2012-02-04  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pp1, pv1): Remove redundant defines.
	(pr): Use pp.

1477 1478 1479 1480
2012-02-04  Chong Yidong  <cyd@gnu.org>

	* nsterm.m: Declare a global (Bug#10694).

1481 1482
2012-02-04  Eli Zaretskii  <eliz@gnu.org>

1483 1484
	* w32.c (get_emacs_configuration_options):
	Include --enable-checking, if specified, in the return value.
1485

1486 1487 1488 1489 1490
2012-02-04  Martin Rudalics  <rudalics@gmx.at>

	* dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
	after rounding frame sizes.  (Bug#9723)

1491 1492 1493 1494 1495
2012-02-04  Eli Zaretskii  <eliz@gnu.org>

	* keyboard.c (adjust_point_for_property): Don't position point
	before BEGV.  (Bug#10696)

1496 1497 1498 1499 1500 1501 1502 1503 1504
2012-02-03  Paul Eggert  <eggert@cs.ucla.edu>

	Handle overflow when computing char display width (Bug#9496).
	* character.c (char_width): Return EMACS_INT, not int.
	(char_width, c_string_width): Check for overflow when
	computing the width; this is possible now that individual
	characters can have unbounded width.  Problem introduced
	by merge from Emacs 23 on 2012-01-19.

1505 1506 1507 1508 1509
2012-02-02  Michael Albinus  <michael.albinus@gmx.de>

	* dbusbind.c (Fdbus_register_method): Mention the return value
	:ignore in the docstring.

1510 1511
2012-02-02  Glenn Morris  <rgm@gnu.org>

1512 1513
	* callproc.c (Fcall_process, Fcall_process_region): Doc fix.

1514 1515 1516 1517 1518 1519
	* nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
	Unconditionally set to t.  (Bug#10673)
	* nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
	* w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
	* xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.

1520 1521 1522 1523 1524
2012-02-02  Kenichi Handa  <handa@m17n.org>

	(x_produce_glyphs): Cancel previous change.  If cmp->glyph_len is
	0, do not call append_composite_glyph.

Kenichi Handa's avatar
Kenichi Handa committed
1525
2012-02-02  Kenichi Handa  <handa@m17n.org>
1526 1527 1528 1529 1530 1531

	* xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
	NULL (Bug#6988).
	(x_produce_glyphs): If the component of a composition is a null
	string, set it->pixel_width to 1 to avoid zero-width glyph.

1532 1533 1534 1535 1536 1537 1538
2012-02-01  Eli Zaretskii  <eliz@gnu.org>

	* ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
	first 2 arguments are identical.  This makes inserting large
	output from a subprocess an order of magnitude faster on
	MS-Windows, where all sbrk'ed memory is always contiguous.

Glenn Morris's avatar
Glenn Morris committed
1539 1540 1541
2012-01-31  Glenn Morris  <rgm@gnu.org>

	* nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1542
	* w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
Glenn Morris's avatar
Glenn Morris committed
1543 1544
	* xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.

1545 1546