ChangeLog 1.12 MB
Newer Older
1 2
2011-04-04  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
5
	(create_pty): Remove unnecessary "volatile"s.
6

7 8
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

9
	* syntax.c (scan_words): Remove var that was set but not used.
10
	(update_syntax_table): Use unsigned instead of int.
11

12
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
14
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
15

16 17
	* print.c (print_error_message): Avoid int overflow.

18 19 20
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

21 22
2011-04-03  Paul Eggert  <eggert@cs.ucla.edu>

23
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
24
	(font_score): Avoid potential overflow in diff calculation.
25

26
	* fns.c (substring_both): Remove var that is set but not used.
27
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
28

29 30
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

31 32 33 34
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

35
	* search.c (boyer_moore, wordify): Remove vars set but not used.
36
	(wordify): Omit three unnecessary tests.
37

38 39 40
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

41 42
	* casefiddle.c (casify_region): Remove var that is set but not used.

43 44
	* dired.c (file_name_completion): Remove var that is set but not used.

45 46
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

47 48
2011-04-02  Paul Eggert  <eggert@cs.ucla.edu>

49
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
50
	(Finsert_file_contents): Remove unnecessary code checking fd.
51

52 53 54
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

55 56 57
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

58 59
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
60
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
61
	(timer_check_2): Mark vars as initialized.
62

63 64
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

65
	* image.c (lookup_image): Remove var that is set but not used.
66
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
67

68 69 70
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

71
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
72
	if XCreateBitmapFromData fails (Bug#8410).
73

74 75 76
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

77 78
2011-04-01  Paul Eggert  <eggert@cs.ucla.edu>

79
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
80
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
81

82 83
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
84 85 86
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
87

88 89 90
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

91 92
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

93 94 95 96 97 98 99
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

100 101 102
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

103 104
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
105
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
106 107 108 109 110 111 112 113
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
114 115
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
116

117 118
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

119
	Add lexical binding.
120

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
138 139 140

	* image.c (parse_image_spec): Use Ffunctionp.

141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
	* fns.c (concat, mapcar1): Accept byte-code-functions.

	* eval.c (Fsetq): Handle lexical vars.
	(Fdefun, Fdefmacro, Ffunction): Make closures when needed.
	(Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
	(FletX, Flet): Obey lexical binding.
	(Fcommandp): Handle closures.
	(Feval): New `lexical' arg.
	(eval_sub): New function extracted from Feval.  Use it almost
	everywhere where Feval was used.  Look up vars in lexical env.
	Handle closures.
	(Ffunctionp): Move from subr.el.
	(Ffuncall): Handle closures.
	(apply_lambda): Remove `eval_flags'.
	(funcall_lambda): Handle closures and new byte-code-functions.
	(Fspecial_variable_p): New function.
	(syms_of_eval): Initialize the Vinternal_interpreter_environment var,
	but without exporting it to Lisp.
159 160

	* doc.c (Fdocumentation, store_function_docstring):
161
	* data.c (Finteractive_form): Handle closures.
162

163 164
	* callint.c (Fcall_interactively): Preserve lexical-binding mode for
	interactive spec.
165

166 167 168 169
	* bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
	byte-codes.
	(exec_byte_code): New function extracted from Fbyte_code to handle new
	calling convention for byte-code-functions.  Add new byte-codes.
170

171
	* buffer.c (defvar_per_buffer): Set new `declared_special' field.
172

173
	* alloc.c (Fmake_symbol): Init new `declared_special' field.
174

175 176 177 178
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (redisplay_internal): Fix prototype.

179
2011-03-31  Eli Zaretskii  <eliz@gnu.org>
180

181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197
	* xdisp.c (SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.  Limit
	scrolling to 100 screen lines.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

	(try_scrolling): When point is above the window, allow searching
	as far as scroll_max, or one screenful, to compute vertical
	distance from PT to the scroll margin position.  This prevents
	try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.  Clean up the case of PT below the margin at bottom
	of window: scroll_max can no longer be INT_MAX.  When aggressive
	scrolling is in use, don't let point enter the opposite scroll
	margin as result of the scroll.
	(syms_of_xdisp) <scroll-conservatively>: Document the
198 199
	threshold of 100 lines for never-recentering scrolling.

200 201 202 203 204 205 206 207 208 209 210 211 212 213
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (move_it_by_lines):
	* xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
	since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
	(message_log_check_duplicate): Remove parameters `prev_bol' and
	`this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(redisplay_internal): Remove parameter `preserve_echo_area',
	unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

	* indent.c (Fvertical_motion):
	* window.c (window_scroll_pixel_based, Frecenter):
	Don't pass `need_y_p' to `move_it_by_lines'.

214 215
2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

216 217 218 219 220
	* eval.c (struct backtrace): Don't cheat with negative numbers, but do
	steal a few bits to be more compact.
	(interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
	Remove unneeded casts.

221 222
	* bytecode.c (Fbyte_code): CAR and CDR can GC.

223 224 225 226 227
2011-03-30  Zachary Kanfer  <zkanfer@gmail.com>  (tiny change)

	* keyboard.c (Fexecute_extended_command): Do log the "suggest key
	binding" message (bug#7967).

228 229
2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>

230 231
	Fix more problems found by GCC 4.6.0's static checks.

232 233 234
	* unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
	Remove unused local var.

235 236
	* editfns.c (Fmessage_box): Remove unused local var.

237 238 239
	* xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Omit unused local vars.
240
	* window.c (shrink_windows): Omit unused local var.
241
	* menu.c (digest_single_submenu): Omit unused local var.
242 243 244
	* dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
	Omit unused local var.

245 246
	* keyboard.c (parse_modifiers_uncached, parse_modifiers):
	Don't assume string length fits in int.
247
	(keyremap_step, read_key_sequence): Use size_t for sizes.
248
	(read_key_sequence): Don't check last_real_key_start redundantly.
249

250 251 252
	* callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
	instead of alloca (Bug#8344).

253
	* eval.c (Fbacktrace): Don't assume nargs fits in int.
254
	(Fbacktrace_frame): Don't assume nframes fits in int.
255

256 257
	* syntax.c (scan_sexps_forward): Avoid pointer wraparound.

Paul Eggert's avatar
Paul Eggert committed
258 259 260 261 262 263
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

	* term.c (produce_glyphless_glyph): Remove unnecessary test.

	* cm.c (calccost): Turn while-do into do-while, for clarity.
264

265 266 267 268
	* keyboard.c (syms_of_keyboard): Use the same style as later
	in this function when indexing through an array.  This also
	works around GCC bug 48267.

269 270
	* image.c (tiff_load): Fix off-by-one image count (Bug#8336).

271 272
	* xselect.c (x_check_property_data): Return correct size (Bug#8335).

273 274 275
	* chartab.c (sub_char_table_ref_and_range): Redo for slight
	efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

276 277 278 279
	* keyboard.c, keyboard.h (num_input_events): Now size_t.
	This avoids undefined behavior on integer overflow, and is a bit
	more convenient anyway since it is compared to a size_t variable.

280 281 282 283 284
	Variadic C functions now count arguments with size_t, not int.
	This avoids an unnecessary limitation on 64-bit machines, which
	caused (substring ...) to crash on large vectors (Bug#8344).
	* lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
285
	All variadic functions and their callers changed accordingly.
286 287 288 289 290 291 292 293 294 295 296
	(struct gcpro.nvars): Now size_t, not int.  All uses changed.
	* data.c (arith_driver, float_arith_driver): Likewise.
	* editfns.c (general_insert_function): Likewise.
	* eval.c (struct backtrace.nargs, interactive_p)
	(internal_condition_case_n, run_hook_with_args, apply_lambda)
	(funcall_lambda, mark_backtrace): Likewise.
	* fns.c (concat): Likewise.
	* frame.c (x_set_frame_parameters): Likewise.
	* fns.c (get_key_arg): Now accepts and returns size_t, and returns
	0 if not found, not -1.  All callers changed.

297 298 299 300
	* alloc.c (garbage_collect): Don't assume stack size fits in int.
	(stack_copy_size): Now size_t, not int.
	(stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
	unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	All callers changed.

	* lisp.h (multibyte_char_to_unibyte):
	* character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
	unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	* character.h (CHAR_TO_BYTE8):
	* cmds.c (internal_self_insert):
	* editfns.c (general_insert_function):
	* keymap.c (push_key_description):
	* search.c (Freplace_match):
	* xdisp.c (message_dolog, set_message_1): All callers changed.

317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
2011-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): New function.
	(safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
	don't set the hook to nil, but remove the offending function instead.
	(Qcommand_hook_internal): Remove, unused.
	(syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
	Vcommand_hook_internal.

	* eval.c (enum run_hooks_condition): Remove.
	(funcall_nil, funcall_not): New functions.
	(run_hook_with_args): Call each function through a `funcall' argument.
	Remove `cond' argument, now redundant.
	(Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
	(Frun_hook_with_args_until_failure): Adjust accordingly.
	(run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.

334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (string_buffer_position): Remove declaration.

	* print.c (strout): Remove parameter `multibyte', unused since
	1999-08-21T19:30:21Z!gerd@gnu.org.  All callers changed.

	* search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
	never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
	All callers changed.

	* w32.c (_wsa_errlist): Use braces for struct initializers.

	* xdisp.c (string_buffer_position_lim): Remove parameter `w',
	never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
	All callers changed.
	(string_buffer_position): Likewise.  Also, make static (it's never
	used outside xdisp.c).
	(cursor_row_p): Remove parameter `w', unused since
	2000-10-17T16:08:57Z!gerd@gnu.org.  All callers changed.
	(decode_mode_spec): Remove parameter `precision', introduced during
	Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
	All callers changed.

358 359 360 361
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.

362
2011-03-27  Anders Lindgren  <andlind@gmail.com>
363 364 365 366 367 368 369 370 371 372

	* nsterm.m (ns_menu_bar_is_hidden): New variable.
	(ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
	(ns_update_auto_hide_menu_bar): New functions.
	(ns_update_begin): Call ns_update_auto_hide_menu_bar.
	(applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
	ns_constrain_all_frames.
	(constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
	(syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.

373 374 375 376
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (runDialogAt): Remove argument to timer_check.

377 378 379 380 381 382 383 384 385
2011-03-27  Glenn Morris  <rgm@gnu.org>

	* syssignal.h: Replace RETSIGTYPE with void.
	* atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
	* keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
	Replace SIGTYPE with void everywhere.
	* s/usg5-4-common.h (SIGTYPE): Remove definition.
	* s/template.h (SIGTYPE): Remove commented out definition.

386 387 388 389 390
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

391 392
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

393 394 395 396 397 398 399
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

421 422 423 424 425
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

426 427 428 429 430 431 432 433
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

465 466 467 468 469
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
507
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
508 509
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
510
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
511

512 513
	Fix more problems found by GCC 4.5.2's static checks.

514 515 516 517
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

518 519 520
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
521
	of objects (Bug#8318).
522

523 524 525
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

526 527 528 529
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
530 531
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
532

533 534 535
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

536 537
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
538 539
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
540

Paul Eggert's avatar
Paul Eggert committed
541 542
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
543

Paul Eggert's avatar
Paul Eggert committed
544
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
545

546 547 548
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
549
	socklen_t is wider than int (Bug#8277).
550 551 552 553
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

554 555 556 557
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
558
	(Fmake_network_process): Define label "retry_connect" only if needed.
559
	(Fnetwork_interface_info): Fix pointer signedness.
560
	(process_send_signal): Add cast to avoid pointer signedness problem.
561
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
562
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
563

564
	Make tparam.h and terminfo.c consistent.
565 566
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.
	Include tparam.h instead, since it declares them.
567 568 569 570 571 572 573 574 575
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

576
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
577
	(xftfont_open): Rename locals to avoid shadowing.
578

579
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
580 581
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
582
	(ftfont_list): Remove unused local.
583 584 585
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
586

587 588
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
589 590
	* xml.c (make_dom): Now static.

591 592
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
593 594
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
595
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
596 597
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
598

599 600 601 602 603 604 605
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

606 607
	* textprop.c (property_change_between_p): Remove; unused.

608 609
	* intervals.c (interval_start_pos): Now static.

610 611
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

612 613
	* atimer.c (start_atimer, append_atimer_lists, set_alarm):
	Rename locals to avoid shadowing.
614

615 616
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
617
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
618 619
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
620

621 622
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

623 624
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
625 626
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
627 628
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
629

630 631 632 633
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

634
	* callproc.c (call_process_cleanup): Now static.
635
	(relocate_fd): Rename locals to avoid shadowing.
636

637 638 639 640 641
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

642 643 644 645
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

646 647 648 649 650 651
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

652 653 654 655 656 657
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

658 659 660 661 662
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

663 664 665 666
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

667 668 669 670
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

671 672
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

673 674
	Fix more problems found by GCC 4.5.2's static checks.

675 676 677
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

678 679 680 681 682 683 684
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

685 686 687
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

688
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
689 690 691
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
692

693 694
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
695 696
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
697
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
698

699 700
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
701
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
702
	* unexec.h: New file.
703 704 705 706 707 708
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
709
	Change as necessary to match prototype in unexec.h.
710

711 712
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
713
	(back_comment, skip_chars): Mark vars as initialized.
714

715 716 717
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

718
	* lread.c (read1): Rewrite so as not to use empty "else".
719
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
720

721 722
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

723 724 725
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

726 727
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
728
	(font_sort_entities): Mark var as initialized.
729

730 731
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

732 733
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
734
	(font_parse_fcname): Remove unused vars.
735
	(font_delete_unmatched): Now static.
736
	(font_get_spec): Remove; unused.
737 738 739
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
740

741
	* fns.c (require_nesting_list, require_unwind): Now static.
742
	(Ffillarray): Rename locals to avoid shadowing.
743

744
	* floatfns.c (domain_error2): Define only if needed.
745
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
746

747 748 749
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

750
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
751
	(Fdefvar): Rewrite so as not to use empty "else".
752 753
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
754
	(Fdefvar): Rename locals to avoid shadowing.
755

756
	* callint.c (quotify_arg, quotify_args): Now static.
757
	(Fcall_interactively): Rename locals to avoid shadowing.
758
	Use const pointer when appropriate.
759

760 761 762 763
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
764 765 766
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
767 768 769
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
770
	(Ftranslate_region_internal): Mark var as initialized.
771

772 773 774
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

775 776 777
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

778 779
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
780
	(default_value, arithcompare, arith_driver, arith_error): Now static.
781
	(store_symval_forwarding): Rename local to avoid shadowing.
782 783
	(Fmake_variable_buffer_local, Fmake_local_variable):
	Mark variables as initialized.
784
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
785

786
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
787 788
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
789 790
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
791 792 793 794 795
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
796
	(Fmemory_limit): Cast sbrk's returned value to char *.
797

798 799 800
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

801 802
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

803 804 805 806 807 808 809 810
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
811
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
812
	the race-condition problem in the old DOWNCASE.
813

814 815 816
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
817 818
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
819 820
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
821
	(regex_compile, re_match_2_internal): Mark locals as initialized.
822 823 824 825 826 827 828
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
829

830
	* search.c (boyer_moore): Rename locals to avoid shadowing.
831 832
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
833

834 835
	* search.c (simple_search): Remove unused var.

836 837 838 839
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

840 841
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

842 843 844 845
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
846
	(Fvertical_motion): Mark locals as initialized.
847

848
	* casefiddle.c (casify_object, casify_region): Now static.
849
	(casify_region): Mark local as initialized.
850

851 852
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

853 854 855 856 857 858 859 860 861
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
862 863 864
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

886 887
	* dired.c (directory_files_internal_unwind): Now static.

888 889 890
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
891 892 893
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
894
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
895 896
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
897 898
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
899

900
	* minibuf.c (choose_minibuf_frame_1): Now static.
901 902
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
903

904 905
	* marker.c (bytepos_to_charpos): Remove; unused.

906 907 908
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

909 910
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
911
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
912
	(copy_text): Remove unused local var.
913

914
	* filelock.c (within_one_second): Now static.
915
	(lock_file_1): Rename local to avoid shadowing.
916

917 918 919 920
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
921
	(switch_to_buffer_1): Now static.
922 923
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
924

925
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
926
	Fix pointer signedness issue.
927 928
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
929
	(MAXPATHLEN): Define only if needed.
930

931 932 933
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

934 935 936
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

937
	* sysdep.c (reset_io): Now static.
938
	(wait_for_termination_signal): Remove; unused.
939

940 941 942
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
943
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
944
	(DENSE_TABLE_SIZE): Remove; unused.
945 946 947
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
948

949 950 951
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
952 953 954 955 956
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
957
	(read_key_sequence, read_char): Mark locals as initialized.
958
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
959

960
	* keyboard.h (make_ctrl_char): New decl.
961 962
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
963

964 965
	* lisp.h (force_auto_save_soon): New decl.

966
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
967 968 969
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
970 971
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
972

973 974
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

975 976 977 978 979 980 981
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

982 983
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
984
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
985

986 987
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

988 989 990
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

991 992
	* print.c (print_preprocess): Don't forget font objects.

993 994 995 996
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

997 998 999 1000 1001
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

1002 1003 1004 1005 1006 1007 1008 1009
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
1010
	(run_protected): Add extern declaration for waiting_for_input.
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

1027 1028
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
1029
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1030

1031 1032 1033 1034 1035 1036
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

1037 1038
	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
	Assign struct members directly, instead of using BUF_BEGV etc.
1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

1053 1054 1055 1056 1057
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

1058 1059
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
1060 1061
	Fix more problems found by GCC 4.5.2's static checks.

1062 1063
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
1064 1065
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
1066 1067
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
1068 1069 1070 1071 1072
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
1073