ChangeLog 1.1 MB
Newer Older
1 2 3 4 5 6 7
2011-03-20  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.

8 9
2011-03-19  Paul Eggert  <eggert@cs.ucla.edu>

10 11 12 13 14 15 16 17 18 19 20 21
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

22
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
23
	(xftfont_open): Rename locals to avoid shadowing.
24

25
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
26 27
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
28
	(ftfont_list): Remove unused local.
29 30 31
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
32

33 34
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
35 36
	* xml.c (make_dom): Now static.

37 38
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
39 40
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
41
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
42 43
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
44

45 46
2011-03-18  Paul Eggert  <eggert@cs.ucla.edu>

47 48 49 50 51 52 53
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

54 55
	* textprop.c (property_change_between_p): Remove; unused.

56 57
	* intervals.c (interval_start_pos): Now static.

58 59
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

60 61 62
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

63 64
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
65
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
66 67
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
68

69 70
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

71 72
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

73 74 75
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
76

77 78 79 80
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

81
	* callproc.c (call_process_cleanup): Now static.
82
	(relocate_fd): Rename locals to avoid shadowing.
83

84 85 86 87
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

88 89
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

90 91
	Fix more problems found by GCC 4.5.2's static checks.

92 93 94
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

95 96 97 98 99 100 101
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

102 103 104
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

105
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
106 107 108
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
109

110 111
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
112 113
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
114
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
115

116 117
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
118
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
119
	* unexec.h: New file.
120 121 122 123 124 125
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
126
	Change as necessary to match prototype in unexec.h.
127

128 129
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
130
	(back_comment, skip_chars): Mark vars as initialized.
131

132 133 134
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

135
	* lread.c (read1): Rewrite so as not to use empty "else".
136
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
137

138 139
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

140 141 142
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

143 144
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
145
	(font_sort_entities): Mark var as initialized.
146

147 148
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

149 150
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
151
	(font_parse_fcname): Remove unused vars.
152
	(font_delete_unmatched): Now static.
153
	(font_get_spec): Remove; unused.
154 155 156
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
157

158
	* fns.c (require_nesting_list, require_unwind): Now static.
159
	(Ffillarray): Rename locals to avoid shadowing.
160

161
	* floatfns.c (domain_error2): Define only if needed.
162
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
163

164 165 166
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

167
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
168
	(Fdefvar): Rewrite so as not to use empty "else".
169 170
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
171
	(Fdefvar): Rename locals to avoid shadowing.
172

173
	* callint.c (quotify_arg, quotify_args): Now static.
174
	(Fcall_interactively): Rename locals to avoid shadowing.
175
	Use const pointer when appropriate.
176

177 178 179 180
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
181 182 183
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
184 185 186
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
187
	(Ftranslate_region_internal): Mark var as initialized.
188

189 190 191
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

192 193 194
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

195 196
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
197
	(default_value, arithcompare, arith_driver, arith_error): Now static.
198
	(store_symval_forwarding): Rename local to avoid shadowing.
199 200
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
201
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
202

203
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
204 205
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
206 207
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
208 209 210 211 212
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
213
	(Fmemory_limit): Cast sbrk's returned value to char *.
214

215 216 217
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

218 219
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

220 221 222 223 224 225 226 227
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
228
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
229
	the race-condition problem in the old DOWNCASE.
230

231 232 233
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
234 235
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
236 237
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
238
	(regex_compile, re_match_2_internal): Mark locals as initialized.
239 240 241 242 243 244 245
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
246

247
	* search.c (boyer_moore): Rename locals to avoid shadowing.
248 249
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
250

251 252
	* search.c (simple_search): Remove unused var.

253 254 255 256
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

257 258
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

259 260 261 262
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
263
	(Fvertical_motion): Mark locals as initialized.
264

265
	* casefiddle.c (casify_object, casify_region): Now static.
266
	(casify_region): Mark local as initialized.
267

268 269
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

270 271 272 273 274 275 276 277 278
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
279 280 281
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

303 304
	* dired.c (directory_files_internal_unwind): Now static.

305 306 307
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
308 309 310
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
311
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
312 313
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
314 315
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
316

317
	* minibuf.c (choose_minibuf_frame_1): Now static.
318 319
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
320

321 322
	* marker.c (bytepos_to_charpos): Remove; unused.

323 324 325
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

326 327
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
328
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
329
	(copy_text): Remove unused local var.
330

331
	* filelock.c (within_one_second): Now static.
332
	(lock_file_1): Rename local to avoid shadowing.
333

334 335 336 337
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
338
	(switch_to_buffer_1): Now static.
339 340
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
341

342
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
343
	Fix pointer signedness issue.
344 345
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
346
	(MAXPATHLEN): Define only if needed.
347

348 349 350
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

351 352 353
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

354
	* sysdep.c (reset_io): Now static.
355
	(wait_for_termination_signal): Remove; unused.
356

357 358 359
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
360
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
361
	(DENSE_TABLE_SIZE): Remove; unused.
362 363 364
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
365

366 367 368
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
369 370 371 372 373
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
374
	(read_key_sequence, read_char): Mark locals as initialized.
375
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
376

377
	* keyboard.h (make_ctrl_char): New decl.
378 379
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
380

381 382
	* lisp.h (force_auto_save_soon): New decl.

383
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
384 385 386
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
387 388
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
389

390 391
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

392 393 394 395 396 397 398
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

399 400
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
401
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
402

403 404
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

405 406 407
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

408 409
	* print.c (print_preprocess): Don't forget font objects.

410 411 412 413
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

414 415 416 417 418
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

419 420 421 422 423 424 425 426
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
427
	(run_protected): Add extern declaration for waiting_for_input.
428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

444 445
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
446
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
447

448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

470 471 472 473 474
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

475 476
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
477 478
	Fix more problems found by GCC 4.5.2's static checks.

479 480
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
481 482
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
483 484
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
485 486 487 488 489
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
490 491 492
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
493

494 495
	* xgselect.c (xg_select): Remove unused var.

496 497 498
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
499
	(my_png_error, my_error_exit): Mark with NO_RETURN.
500

501
	* image.c (clear_image_cache): Now static.
502
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
503
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
504 505
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
506
	(gif_load): Fix pointer signedness.
507 508
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
509

Paul Eggert's avatar
Paul Eggert committed
510 511
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

512 513 514 515 516 517
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
518 519 520 521 522 523 524 525 526 527 528 529
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
530 531
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
532

533 534 535 536
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

537 538 539 540 541
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

542
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
543

544 545
	* fringe.c (update_window_fringes): Remove unused variables.

546 547 548
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

549 550
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
551
	* termcap.c [MSDOS]: Include "msdos.h".
552 553 554 555
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

556
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
557

558 559 560 561 562
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

563 564 565 566
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

567 568 569 570 571 572 573 574 575 576 577 578
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

579
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
580

581
	Fix some minor problems found by GCC 4.5.2's static checks.
582

583 584 585
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
586

587 588 589 590 591
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

592
	* fontset.c (free_realized_fontset): Now static.
593
	(Fset_fontset_font): Rename local to avoid shadowing.
594
	(fontset_font): Mark local as initialized.
595
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
596

597 598
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

599
	* xselect.c (x_disown_buffer_selections): Remove; not used.
600
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
601 602 603
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
604

605 606 607
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
608 609 610 611
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
612
	(Fx_create_frame): Add braces to silence GCC warning.
613
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
614 615
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
616 617 618 619
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
620

621 622
	* xterm.h (x_mouse_leave): New decl.

623 624
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
625 626
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
627
	(XTread_socket): Don't define label "out" unless it's used.
628
	Don't declare local "event" unless it's used.
629 630
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
631 632
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
633 634 635 636 637
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
638
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
639
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
640

641 642
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
643
	(tty_defined_color, merge_face_heights): Now static.
644
	(free_realized_faces_for_fontset): Remove; not used.
645 646
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
647 648
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
649

650
	* terminal.c (store_terminal_param): Now static.
651

652
	* xmenu.c (menu_highlight_callback): Now static.
653
	(set_frame_menubar): Remove unused local.
654
	(xmenu_show): Rename parameter to avoid shadowing.
655 656
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
657 658
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
659

660
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
661
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
662 663
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
664
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
665 666
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
667

Paul Eggert's avatar
Paul Eggert committed
668 669
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

670
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
671 672
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
673

674
	* window.c (display_buffer): Now static.
675 676
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
677 678
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
679
	* dispextern.h (bidi_dump_cached_states): Likewise.
680

681 682 683
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
684 685 686
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
687 688
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
689
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
690

691 692 693
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
694 695 696 697 698 699 700 701 702
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
703 704
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
705
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
706
	(decode_coding_object, encode_coding_object, detect_coding_system):
707 708
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
709 710
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
711
	this initialization is needed.  (Bug#8211)
712 713 714 715 716
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
717

718
	* category.c (hash_get_category_set): Remove unused local var.
719
	(copy_category_table): Now static, since it's not used elsewhere.
720
	* character.c (string_count_byte8): Likewise.
721

722 723 724
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

725 726
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
727 728
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
729
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
730

731
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
732
	(BIDI_BOB): Remove unused macro.
733

734 735
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
736
	* term.c (encode_terminal_code): Likewise.
737

738
	* term.c (encode_terminal_code): Now static.  Remove unused local.
739

Paul Eggert's avatar
Paul Eggert committed
740 741 742 743 744 745 746 747 748 749 750
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

751 752 753 754 755 756 757 758 759
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

760 761
	* term.c (term_mouse_position): Rename local to avoid shadowing.

762 763 764
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

765 766 767 768
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

769 770 771 772 773 774
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

827 828 829 830 831
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
832 833 834 835 836 837 838
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
839
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
840

841 842 843 844 845 846
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

847 848 849 850 851
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

852 853
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

854 855 856
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

881 882 883 884 885
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

886
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
887
	* xdisp.c (redisplay_window): Likewise.
888

889 890 891 892 893 894 895 896
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
897
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
898 899
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
900
	(update_window_cursor): Now static, since it's not used elsewhere.
901
	(SKIP_GLYPHS): Removed unused macro.
902

903 904 905 906
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

907 908 909 910
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
911
2011-03-02  Ken Brown  <kbrown@cornell.edu>
912 913 914

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

915 916 917 918 919 920 921 922 923 924 925 926 927
2011-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	Work around some portability problems with symlinks.

	* fileio.c (Fmake_symbolic_link): Treat ENOSYS specially, and
	generate a special message for it.  Suggested by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00995.html>.
	(Frename_file, Fmake_symbolic_link, Ffile_symlink_p):
	Simplify the code by assuming that the readlink and symlink calls
	exist, even if they always fail on this host.
	(Ffile_readable_p): Likewise, for fifos.
	* config.in: Regenerate.

928 929 930 931 932 933
2011-02-27  Chong Yidong  <cyd@stupidchicken.com>

	* frame.c (store_frame_param): Don't store value directly in
	buffer_list and buried_buffer_list; copy the list and remove dead
	buffers (Bug#7898).

934 935
2011-02-27  Eli Zaretskii  <eliz@gnu.org>

936 937
	* msdos.c (readlink) [DJGPP < 2.04]: New stub function.

Juanma Barranquero's avatar
Juanma Barranquero committed
938
	* msdos.h (readlink) [DJGPP < 2.04]: Declare prototype.
939

940 941
	* w32.c (symlink, readlink): New stub functions.

942 943
2011-02-27  Paul Eggert  <eggert@cs.ucla.edu>

944 945 946
	* scroll.c (CHECK_BOUNDS): #define only if GLYPH_DEBUG.
	This avoids a gcc warning in some configurations.

947 948
	* frame.c (x_set_screen_gamma): Rename local to avoid shadowing.

949 950 951 952
	* frame.h: Avoid gcc -Wmissing-prototypes diagnostics.
	(set_menu_bar_lines, x_get_resource_string): New decls.
	* msdos.c (set_menu_bar_lines): Omit decl.

953 954 955 956 957
	* dispextern.h (struct glyph): Make u.img_id int, not unsigned.
	It's always given int values and used as an int.  This suppresses
	a gcc "comparison of unsigned expression >= 0" warning in some
	configurations.

958 959 960
	* dispnew.c: Rename locals to avoid shadowing.
	(update_text_area, scrolling_window, update_frame_1): Rename locals.

961 962 963 964 965 966 967 968 969 970
2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c: Fix problems uncovered by gcc -Wstrict-prototypes.
	(copy_glyph_row_contents): Remove; not used.
	(frame_row_to_window, check_current_matrix_flags):
	(window_change_signal): Now static, since they're not used elsewhere.
	(check_current_matrix_flags): Surround with "#if 0", since its
	only use is in a comment.  Maybe both the comment and the "#if 0"
	stuff should be removed?

971 972 973 974
	* dispnew.c: Fix problem uncovered by gcc -Wunused-variable.
	(adjust_frame_glyphs_for_window_redisplay): Make 'w' local to the
	contexts that actually need it.

975 976 977 978 979
2011-02-26  Eli Zaretskii  <eliz@gnu.org>

	* s/msdos.h (HAVE_LSTAT): Define for DJGPP >= 2.04.
	(lstat): Define for DJGPP < 2.04.

980 981 982 983 984 985
2011-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Increase size of modes from 10 to 12
	as per recent filemodestring API change.  Reported by Jonas Öster in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg01069.html>.

986
2011-02-23  Ben Key  <bkey76@gmail.com>
987 988 989 990 991 992 993 994 995

	* nsterm.m (ns_draw_window_cursor): Obey the cursor_width argument
	directly, for bar cursors.

2011-02-23  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (set_frame_cursor_types): Don't write an undefined value
	into the frame's cursor_width.

996 997 998 999 1000
2011-02-23  Stefan Monnier  <monnier@iro.umontreal.ca>

	* print.c (print_object): Never print old-style backquotes.
	Obey escapeflag for hash tables as well.

1001
2011-02-23  Kenichi Handa  <handa@m17n.org>
Kenichi Handa's avatar
Kenichi Handa committed
1002 1003

	* font.c (font_open_entity): Be sure to set scaled_pixel_size.
1004
	(font_find_for_lface): Check if attrs[LFACE_HEIGHT_INDEX] is integer.
Kenichi Handa's avatar
Kenichi Handa committed
1005

1006 1007 1008 1009
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Simplify and avoid #ifdef.

1010 1011 1012 1013
2011-02-22  Wolfgang Jenkner  <wjenkner@inode.at>  (tiny change)

	* lread.c (openp): Correct Boolean typo in last commit.

1014 1015 1016
2011-02-22  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (EmacsView-keyDown:): Don't pass shift-only-modified
1017
	key to Emacs, treat as unmodified (go to input manager processing).
1018

Paul Eggert's avatar
Paul Eggert committed
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	Assume S_ISLNK etc. work, since gnulib supports this.
	* config.in: Regenerate.
	* dired.c (lstat): Remove.
	(file_name_completion): Assume S_ISDIR works.