ChangeLog 213 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14
2013-09-15  Dmitry Antipov  <dmantipov@yandex.ru>

	Drop VERTICAL_SCROLL_BAR_WIDTH_TRIM.  For X, it is zero since 1999,
	and it is always zero for others, so I assume that this is an ancient
	leftover which nobody will want to change any more.
	* xterm.h, w32term.h, nsterm.h (VERTICAL_SCROLL_BAR_WIDTH_TRIM): Remove.
	(VERTICAL_SCROLL_BAR_INSIDE_WIDTH):
	* frame.c (x_set_scroll_bar_width):
	* w32fns.c (w32_createscrollbar):
	* w32term.c (w32_set_vertical_scroll_bar):
	* xfns.c (x_set_scroll_bar_default_width):
	* xterm.c (XTflash, x_scroll_bar_create, XTset_vertical_scroll_bar)
	(x_scroll_bar_expose): Related users changed.

15 16 17 18
2013-09-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (FRAME_X_SCREEN_NUMBER): Add comment.
	(BLACK_PIX_DEFAULT, WHITE_PIX_DEFAULT): Use FRAME_X_SCREEN_NUMBER.
19 20
	(SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET) [USE_X_TOOLKIT]:
	Define as such.
21 22 23
	* frame.h (FRAME_SMALLEST_CHAR_WIDTH, FRAME_SMALLEST_FONT_HEIGHT):
	Define once here...
	* nsterm.h, w32term.h, xterm.h: ...and not here.
24 25
	* w32term.h (SCROLL_BAR_X_WIDGET, SET_SCROLL_BAR_X_WIDGET):
	Remove unused Xisms.
26 27
	* xterm.c, xfns.c (toplevel): Remove #ifdef HAVE_X_WINDOWS because
	these modules are never compiled otherwise.
28

29 30
2013-09-14  Eli Zaretskii  <eliz@gnu.org>

31
	* buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>:
32 33
	Doc fix.  (Bug#15375)

34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	Unify Fx_focus_frame between all ports.
	* frame.h (x_focus_frame): New prototype.
	* xfns.c (Fx_focus_frame): Remove.
	(syms_of_xfns): Do not defsubr it.
	(x_focus_frame): X implementation.
	* nsfns.m (Fx_focus_frame): Remove.
	(syms_of_nsfns): Do not defsubr it.
	(x_focus_frame): NS implementation.
	* w32term.c (Fx_focus_frame): Remove.
	(x_focus_on_frame): Rename to...
	(x_focus_frame): W32 implementation.
	* w32term.h (x_focus_on_frame): Remove prototype.
	* w32fns.c (Fx_focus_frame): Remove.
	(syms_of_w32fns): Do not defsubr it.
	* frame.c (Fx_focus_frame): Define here.
	(syms_of_frame): Defsubr here.
	* gtkutil.c (xg_tool_bar_callback): Use x_focus_frame.

54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	Unify FRAME_window_system_DISPLAY_INFO macros between all ports.
	All of them are replaced with FRAME_DISPLAY_INFO, defined in
	each port to reference the port-specific window system data.
	* msdos.h (FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.
	* w32term.h (FRAME_W32_DISPLAY_INFO, FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.  Adjust users.
	* xterm.h (FRAME_X_DISPLAY_INFO): Remove.
	(FRAME_DISPLAY_INFO): Define.  Adjust users.
	* frame.h (FRAME_RES_X, FRAME_RES_Y): Unify.
	* font.c, frame.c, gtkutil.c, image.c, menu.c, msdos.c, nsfns.m:
	* nsfont.m, nsterm.m, w32fns.c, w32font.c, w32menu.c, w32term.c:
	* w32xfns.c, widget.c, xdisp.c, xfaces.c, xfns.c, xfont.c, xmenu.c:
	* xselect.c, xterm.c: All related users changed.

71 72 73 74 75 76 77 78 79 80 81
2013-09-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame): Remove prototypes.
	* xfns.c (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame, x_top_window_to_frame):
	Move from here...
	* xterm.c (x_window_to_frame, x_any_window_to_frame)
	(x_menubar_window_to_frame, x_top_window_to_frame):
	...to here and convert all but the last to static.

82 83 84 85
2013-09-12  Eli Zaretskii  <eliz@gnu.org>

	* lisp.mk (lisp): Add w32-common-fns.elc.

86 87 88 89
2013-09-12  Xue Fuqiao  <xfq.free@gmail.com>

	* charset.c (char_charset): Document an exception for char-charset.

90 91 92 93 94 95
2013-09-12  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (x_display_info): New field last_user_time...
	* xterm.c (toplevel): ...to replace static last_user_time.
	(handle_one_xevent, x_ewmh_activate_frame): Adjust users.

96 97 98 99 100
2013-09-12  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_set_scroll_bar_thumb) [USE_LUCID && !HAVE_XAW3D]: Clip
	scroll bar values to prevent thumb from disappear and update comment.

101 102 103 104
2013-09-11  Glenn Morris  <rgm@gnu.org>

	* emacs.c (usage_message): Possessive apostrophe tweak.

105 106
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

107 108 109 110 111 112
	* nsterm.m (syms_of_nsterm): Use Qns.
	* w32fns.c (Fx_open_connection): Remove old '#if 0' code.
	* w32term.c (w32_create_terminal, syms_of_w32term): Use Qw32.
	* xfns.c (x_display_info_for_name, Fx_open_connection):
	Remove old '#if 0' code.
	(syms_of_xfns): Use Qx.
113 114 115
	* termhooks.h (fullscreen_hook): Remove the leftover.
	(struct terminal): Fix typo in comment.

116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleaning up a few X scroll bar bits.
	* termhooks.h (enum scroll_bar_part): Add scroll_bar_nowhere member.
	* xterm.h (struct scroll_bar) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
	New member last_seen_part, going to replace...
	* xterm.c [USE_TOOLKIT_SCROLL_BARS]: ...global last_scroll_bar_part.
	(xt_action_hook) [USE_LUCID]: Adjust user.
	(xm_scroll_callback, xg_scroll_callback): Do not bloat with
	Lucid-specific scroll bar support.
	(xaw_jump_callback, xaw_scroll_callback): Prefer enum scroll_par_part
	to int and adjust to use last_seen_part member.
	(x_set_toolkit_scroll_bar_thumb) [USE_LUCID]: Adjust user.
	(x_scroll_bar_create) [USE_TOOLKIT_SCROLL_BARS && USE_LUCID]:
	Initialize last_seen_part.

132 133 134 135 136
2013-09-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* insdel.c (insert_from_buffer_1): Don't mark buffer as modified when
	insert-buffer-substring an empty string.

137 138 139 140 141
2013-09-11  Paul Eggert  <eggert@cs.ucla.edu>

	* xdisp.c (Ftool_bar_lines_needed): Declare as 'const' if ifdeffed out,
	avoiding a GCC warning.

142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Ifdef away frame tool bar code when it is not really used.
	* frame.h (struct frame) [HAVE_WINDOW_SYSTEM && !USE_GTK && !HAVE_NS]:
	Move tool_bar_window, desired_tool_bar_string, current_tool_bar_string
	and minimize_tool_bar_window_p under the above.
	(fset_current_tool_bar_string, fset_desired_tool_bar_string)
	(fset_tool_bar_window): Likewise.
	* dispnew.c (clear_current_matrices, clear_desired_matrices)
	(adjust_frame_glyphs_for_window_redisplay, free_glyphs, update_frame)
	(change_frame_size_1):
	* window.c (window_from_coordinates, Frecenter): Adjust users.
	* window.h (WINDOW_TOOL_BAR_P): Define to zero when frame tool bar
	code is not really used.
	* xdisp.c (build_desired_tool_bar_string, display_tool_bar_line)
	(tool_bar_lines_needed, MAX_FRAME_TOOL_BAR_HEIGHT, tool_bar_item_info)
	(get_tool_bar_item, handle_tool_bar_click, note_tool_bar_highlight)
	[!USE_GTK && !HAVE_NS]: Define as such.
	(Ftool_bar_lines_needed, redisplay_tool_bar, show_mouse_face)
	(note_mouse_highlight, expose_frame):
	* xfns.c (x_set_tool_bar_lines):
	* xterm.c (handle_one_xevent): Adjust users.

165 166 167 168 169 170 171 172 173 174 175
2013-09-11  Paul Eggert  <eggert@cs.ucla.edu>

	Fix corruption with multiple emacsclient -t instances (Bug#15222).
	This bug was introduced by my 2013-08-26 patch, which incorrectly
	assumed that the terminfo implementation doesn't use termcap buffers.
	* term.c (init_tty) [TERMINFO]: Remove optimization, as
	these buffers apparently are used after all.
	* termchar.h (TERMCAP_BUFFER_SIZE) [TERMINFO]: Define here too.
	(struct tty_display_info): Define members termcap_term_buffer and
	termcap_strings_buffer even if TERMINFO.

Dmitry Antipov's avatar
Dmitry Antipov committed
176 177 178 179 180 181 182 183 184 185 186 187 188 189 190
2013-09-11  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix last change.
	* data.c (Feqlsign, Flss, Fgtr, Fleq, Fgeq): Add convenient
	'usage' docstring entry to pacify make-docfile.

2013-09-11  Barry O'Reilly  <gundaetiapo@gmail.com>

	Change comparison functions =, <, >, <=, >= to take many arguments.
	* data.c: Change comparison functions' interface and implementation.
	* lisp.h: Make arithcompare available for efficient two arg
	comparisons.
	* bytecode.c: Use arithcompare.
	* fileio.c: Use new interface.

191 192 193 194
2013-09-11  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (read_char): Don't break immediate_echo (bug#15332).

195 196 197 198
2013-09-10  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (Feval): Document the new use of `lexical'.

199 200 201 202 203 204 205 206 207 208 209
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Review and drop old frame resize hack.
	* frame.h (struct frame): Remove force_flush_display_p.
	* dispnew.c (update_frame): Adjust user and don't call
	flush_frame here.  The comment has said that there was an issues
	with redisplaying fringes, but I don't see any differences with
	and without this hack.  Hopefully we can continue without it.
	* xdisp.c (clear_garbaged_frames): Adjust user and do not clear
	current frame matrices twice if resized_p is set.

210 211 212 213 214 215 216 217
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not populate pure Xism x_sync to other ports.
	* frame.h (x_sync): Move under HAVE_X_WINDOWS.
	* frame.c (other_visible_frames) [HAVE_X_WINDOWS]: Use as such.
	* nsfns.m, w32xfns.c (x_sync): Remove no-op.
	* w32term.h (x_sync): Remove prototype.

Dmitry Antipov's avatar
Dmitry Antipov committed
218 219 220
2013-09-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleanup frame flushing.
221 222
	* dispextern.h (struct redisplay_interface):
	Drop flush_display_optional because flush_display is enough
Dmitry Antipov's avatar
Dmitry Antipov committed
223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238
	for X and flushing via RIF is just a no-op for others.
	* frame.h (flush_frame): New function.
	* dispnew.c (update_frame):
	* minibuf.c (read_minibuf):
	* xdisp.c (echo_area_display, redisplay_preserve_echo_area):
	Use it.
	* keyboard.c (detect_input_pending_run_timers): Do not flush
	all frames but selected one in redisplay_preserve_echo_area.
	* nsterm.m (ns_flush): Remove no-op.
	(ns_redisplay_interface): Adjust user.
	* w32term.h (x_flush): Remove no-op.
	(w32_redisplay_interface): Adjust user.
	* xterm.c (x_flush): Simplify because we do not flush all
	frames at once any more.  Adjust comment.
	(x_redisplay_interface): Adjust user.

239 240 241 242 243 244
2013-09-07  Paul Eggert  <eggert@cs.ucla.edu>

	Port --without-x --enable-gcc-warnings to Fedora 19.
	* gfilenotify.c (globals_of_gfilenotify):
	Call g_type_init only if using an older glib version that needs it.

245 246 247 248 249 250 251 252 253 254 255 256 257
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
	(last_glyphless_glyph_merged_face_id): Remove declarations.
	* dispextern.h (merge_glyphless_glyph_face): Add prototype.
	* xdisp.c (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)
	(last_glyphless_glyph_merged_face_id): Now static.
	(merge_escape_glyph_face): New function, refactored from...
	(get_next_display_element): ...here.
	(merge_glyphless_glyph_face): New function, refactored from...
	(produce_glyphless_glyph): ...here...
	* term.c (produce_glyphless_glyph): ...and here.

258 259 260 261
2013-09-06  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (eval_sub): Only call Ffunction if necessary.

262 263 264 265 266 267 268 269 270 271 272 273 274
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Attempt to make redisplay more selective when changing cursor type.
	* frame.h (struct frame): New bitfield cursor_type_changed.
	* xdisp.c (cursor_type_changed): Remove.
	(try_cursor_movement, redisplay_window, try_window_id)
	(set_frame_cursor_types, try_window_reusing_current_matrix):
	Adjust to use per-frame bitfield.
	(redisplay_internal): Look for cursor type change on each visible
	frame and consider all frames if cursor type has been changed on
	the frame other than selected.  If cursor type has been changed on
	selected frame only, do not use fast update.

275 276 277 278 279 280 281
2013-09-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Attempt to make redisplay more selective when changing fonts.
	* frame.h (struct frame): New bitfield fonts_changed.
	* dispextern.h (fonts_changed_p, adjust_glyphs): Remove declaration.
	(adjust_frame_glyphs): Add prototype.
	* dispnew.c (fonts_changed_p): Remove.
Dmitry Antipov's avatar
Dmitry Antipov committed
282
	(adjust_glyphs): Remove because we do not
283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
	adjust matrices on all frames at once any more.
	(adjust_frame_glyphs): Block and unblock input here.
	(adjust_glyph_matrix): Use fonts_changed.
	(change_frame_size_1): Use adjust_frame_glyphs.
	* font.c (font_open_entity): Use fonts_changed.
	* frame.c (set_menu_bar_lines, Fmake_terminal_frame):
	* w32fns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
	* window.c (Fdelete_other_windows_internal, Fwindow_resize_apply)
	(Fsplit_window_internal, Fdelete_window_internal, grow_mini_window)
	(shrink_mini_window, Fresize_mini_window_internal)
	(window_scroll_pixel_based, Fset_window_configuration)
	(apply_window_adjustment, Fset_window_vscroll):
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_show_tip):
	Use adjust_frame_glyphs.
	* xdisp.c (redisplay_tool_bar, redisplay_window, try_window)
	(try_window_reusing_current_matrix, try_window_id, display_line)
	(IT_EXPAND_MATRIX_WIDTH): Use fonts_changed.
	(redisplay_internal): Consider fonts_changed and adjust frame
	matrices for each frame only if the frame is visible.  If font
	has been changed on some frame during full redisplay, retry
	only visible frames where the font has been actually changed.

305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	Cache current header and mode line height for each window.
	* window.h (struct window): New fields mode_line_height
	and header_line_height.
	* window.c (make_window): Initialize them.
	* dispextern.h (CURRENT_MODE_LINE_HEIGHT)
	(CURRENT_HEADER_LINE_HEIGHT): Use them.  Adjust comment.
	(current_mode_line_height, current_header_line_height):
	Remove declaration.
	* xdisp.c (current_mode_line_height, current_header_line_height):
	Remove.
	(pos_visible_p, init_xdisp): Adjust user.
	(redisplay_window): Invalidate mode_line_height and
	header_line_height if current and desired matrices do not agree.

321 322 323 324 325
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* fontset.c, window.c, xdisp.c (toplevel): Use TERM_HEADER.
	* xfaces.c (toplevel) [HAVE_X_WINDOWS]: Do not include xterm.h twice.

326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	Make --without-x compatible with --enable-gcc-warnings.
	* font.c (register_font_driver): Move check under HAVE_WINDOW_SYSTEM.
	* font.h (struct font_driver): Move draw, get_bitmap and free_bitmap
	members under HAVE_WINDOW_SYSTEM.
	* keyboard.c (make_lispy_focus_out): Likewise.
	(record_menu_key): Move under HAVE_MENUS.
	* xdisp.c (toplevel): Move hourglass_shown_p, hourglass_atimer and
	THIN_SPACE_WIDTH under HAVE_WINDOW_SYSTEM.
	(syms_of_xdisp): Adjust user.
	(window_box_edges): Define only if HAVE_WINDOW_SYSTEM.
	(start_hourglass, cancel_hourglass):
	* xfaces.c (toplevel): Likewise with PT_PER_INCH,
	clear_font_table_count, CLEAR_FONT_TABLE_COUNT
	and CLEAR_FONT_TABLE_NFONTS.
	(set_font_frame_param, clear_face_gcs, realize_non_ascii_face):
	Declare only if HAVE_WINDOW_SYSTEM.
	(lface_same_font_attributes_p, clear_face_gcs): Define only
	if HAVE_WINDOW_SYSTEM.

347 348 349 350 351 352
2013-09-05  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (check_minibuf_window): Update 'frame' with frame pointer.
	* xterm.c (x_scroll_bar_handle_click) [!USE_TOOLKIT_SCROLL_BARS]:
	Don't pass C integer to XINT (tiny fix for 2013-09-03 change).

353 354 355 356
2013-09-05  Stefan Monnier  <monnier@iro.umontreal.ca>

	* cmds.c (Fself_insert_command): Don't pass a non-integer to XINT.

357 358 359 360 361
2013-09-04  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (make_event_array): First arg is now ptrdiff_t, not int.
	This fixes a type error on hosts where ptrdiff_t is wider than int.

362 363
2013-09-04  Stefan Monnier  <monnier@iro.umontreal.ca>

364 365 366 367
	* keyboard.c (read_key_sequence_vs): New function.
	(Fread_key_sequence_vector, Fread_key_sequence): Use it to factor out
	common code.

368 369
	* callint.c (Fcall_interactively): Always return a vector for 'K'.

Paul Eggert's avatar
Paul Eggert committed
370 371 372 373 374 375 376 377
2013-09-04  Paul Eggert  <eggert@cs.ucla.edu>

	Makefile improvements.
	* Makefile.in (config.status): Don't use double-colon rules, as
	they are not portable according to POSIX.  Fix shell typo with `;
	I guess this rule has never been tested?
	(VCSWITNESS): New macro, to override any environment var.

378 379 380 381 382 383 384
2013-09-04  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct x_display_info): Do not track X connection
	fd separately because it is always available from Display.
	* xterm.c (x_term_init, x_delete_terminal, x_delete_display):
	Adjust users.

Dmitry Antipov's avatar
Dmitry Antipov committed
385 386 387 388 389 390
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (drop_overlay):
	* fileio.c (restore_point_unwind): Prefer unchain_marker to
	Fset_marker (X, Qnil, ...) (which is the same but a bit slower).

391 392 393 394 395 396 397
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (Fmake_overlay, Fmove_overlay):
	* intervals.c (set_point_from_marker):
	* print.c (PRINTPREPARE): Prefer signal_error
	to plain error and report unsuitable marker too.

398 399 400 401
2013-09-03  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct scroll_bar): Prefer int to Lisp_Object
	for 'dragging' member.
402 403
	(struct x_output): Remove set-but-unused leftovers
	'left_before_move' and 'top_before_move'.
404 405 406 407 408 409
	* gtkutil.c (xg_set_toolkit_scroll_bar_thumb):
	* xterm.c (xt_action_hook, xm_scroll_callback, xg_scroll_callback)
	(xg_end_scroll_callback, xaw_jump_callback, xaw_scroll_callback)
	(x_set_toolkit_scroll_bar_thumb, x_scroll_bar_create)
	(x_scroll_bar_set_handle, XTset_vertical_scroll_bar)
	(x_scroll_bar_handle_click, x_scroll_bar_note_movement)
410
	(x_scroll_bar_report_motion, x_set_offset): Related users changed.
411
	* xfns.c, image.c (XLIB_ILLEGAL_ACCESS): No longer needed.
412

413 414 415 416 417 418
2013-09-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfont.m (INVALID_GLYPH): New define.
	(nsfont_encode_char): Use INVALID_GLYPH.
	(ns_uni_to_glyphs): Ditto, check for NSNullGlyph (Bug#15138).

419 420 421 422 423 424 425 426
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_last_mouse_movement_time): Revert last change.
	This code should use XDisplayMotionBufferSize to check display's
	motion history first, and there are few other issues as well.
	(x_scroll_bar_note_movement): Pass XMotionEvent rather than XEvent.
	(handle_one_xevent): Adjust user.

427 428
2013-09-02  Martin Rudalics  <rudalics@gmx.at>

429 430 431 432
	* dispnew.c (Flast_nonminibuf_frame): Move from here ...
	* frame.c (Flast_nonminibuf_frame): ... to here.
	(check_minibuf_window): Don't abort if no window was found
	(Bug#15247).
433

434 435 436 437 438 439 440 441 442 443
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	Use XGetMotionEvents to ask the last mouse motion time from X server.
	* xterm.c (X_MOTION_HISTORY): Default to 1.
	(x_last_mouse_movement_time) [X_MOTION_HISTORY]: New function.
	(x_last_mouse_movement_time) [!X_MOTION_HISTORY]: Legacy version.
	(note_mouse_movement, x_scroll_bar_note_movement) [!X_MOTION_HISTORY]:
	Ifdef away legacy code.
	(XTmouse_position, x_scroll_bar_report_motion):
	Use x_last_mouse_movement_time.
444 445
	(handle_one_xevent): Use event.xunmap and not event.xmap when handling
	UnmapNotify event.
446

447 448 449 450 451 452 453 454 455 456 457
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* msdos.c (last_mouse_window): Move to...
	(dos_rawgetc): ...this function and adjust comment.
	* nsterm.m (last_window): Rename to last_mouse_window, move to...
	(mouseMoved): ...this function and adjust comment.
	* w32term.c (last_window): Likewise with...
	(w32_read_socket): ...this function.
	* xterm.c (last_window): Likewise with...
	(handle_one_xevent): ...this function.

458 459
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

460
	* window.h (Vmouse_window, Vmouse_event): Remove the leftovers.
461 462 463 464 465
	* xterm.c (toplevel): Drop obsolete comment and move compose_status...
	(handle_one_xevent): ...to here.
	(STORE_KEYSYM_FOR_DEBUG): Move under ENABLE_CHECKING and make no-op
	otherwise.

466 467 468 469 470 471 472 473 474 475 476
2013-09-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* msdos.c (IT_set_terminal_window): Remove no-op.
	(initialize_msdos_display): Adjust terminal setup.
	* w32console.c (w32con_set_terminal_window): Remove no-op.
	(initialize_w32_display): Adjust terminal setup.
	* w32term.c (w32_set_terminal_window): Remove no-op.
	(w32_create_terminal): Adjust terminal setup.
	* xterm.c (XTset_terminal_window): Remove no-op.
	(x_create_terminal): Adjust terminal setup.

477 478 479 480 481 482 483 484 485 486 487 488
2013-09-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* nsterm.m (ns_set_terminal_modes, ns_reset_terminal_modes):
	Remove no-ops.
	(ns_create_terminal): Adjust terminal setup.
	* w32term.c (w32_set_terminal_modes, w32_reset_terminal_modes):
	Remove no-ops.
	(w32_create_terminal): Adjust terminal setup.
	* xterm.c (XTset_terminal_modes, XTreset_terminal_modes):
	Remove no-ops.
	(x_create_terminal): Adjust terminal setup.

489 490 491 492 493 494 495 496
2013-09-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* dispextern.h (SET_TEXT_POS_FROM_MARKER): Indent.
	(CLIP_TEXT_POS_FROM_MARKER): New macro.
	* dispnew.c (buffer_posn_from_coords):
	* window.c (Fwindow_end, displayed_window_lines):
	* xdisp.c (redisplay_mode_lines): Use it.

497 498 499 500 501
2013-09-01  Jan Djärv  <jan.h.d@swipnet.se>

	* fontset.c (face_for_char): Check char in the current face font first
	if HAVE_NS (Bug#15138).

502 503 504 505 506
2013-08-31  Martin Rudalics  <rudalics@gmx.at>

	* window.c (temp_output_buffer_show): Make sure window returned
	by display_buffer is live (Bug#15213).

507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533
2013-08-30  Dmitry Antipov  <dmantipov@yandex.ru>

	Minor cleanup to avoid forward declarations.
	* coding.h (struct ccl_spec): Remove forward declaration.
	* composite.h (toplevel): Include font.h.
	(struct composition_it, struct face, struct font_metrics):
	Remove forward declaration.
	* dispextern.h (struct image, struct atimer): Likewise.
	* emacsgtkfixed.h (struct frame): Likewise.
	* emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
	* font.h (struct font_driver, struct font, struct glyph_string)
	(struct face): Remove forward declaration.
	* fontset.h (struct face, struct font): Likewise.
	* frame.h (toplevel): Style cleanup.
	(enum output_method): Move to...
	* termhooks.h (enum output_method): ...here.
	(struct glyph, struct frame, struct ns_display_info)
	(struct x_display_info, struct w32_display_info):
	Remove forward declaration.
	* xterm.h (toplevel): Include termhooks.h.
	(struct font, struct window, struct glyph_matrix, struct frame)
	(struct input_event, struct face, struct image): Remove forward
	declaration.
	* gtkutil.h (struct _widget_value): Likewise.
	* keyboard.h (toplevel): Include termhooks.h.
	(struct input_event): Remove forward declaration.

534 535 536 537 538 539 540 541
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* intervals.c (set_point_from_marker): New function.
	* editfns.c (Fgoto_char):
	* process.c (Finternal_default_process_filter):
	* window.c (select_window_1): Use it.
	* buffer.h (set_point_from_marker): Add prototype.

542 543 544 545 546 547 548 549 550 551 552 553 554 555
2013-08-29  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (term_winsock): Call release_listen_threads before calling
	WSACleanup.
	(_sys_wait_accept): Wait for accept event in a loop with a finite
	timeout, instead of waiting indefinitely.  Will hopefully avoid
	hanging during exit because WSACleanup deadlocks waiting for the
	event object to be released.  (Bug#14333)

	* w32proc.c (release_listen_threads): New function, signals all
	the reader threads that listen for connections to stop waiting.

	* w32.h (release_listen_threads): Add prototype.

556 557 558 559
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* alloc.c (Fmake_marker, build_marker): Zero need_adjustment
	field of new marker (for sanity and safety).
560 561
	* lisp.h (XSETMARKER): Remove unused macro (it doesn't work
	anyway because XMISCTYPE is a function and can't be an lvalue).
562

563 564 565 566 567 568 569 570 571 572
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (x_clear_area): Lost 7th arg because it is always False.
	(x_after_update_window_line, x_scroll_bar_create):
	(x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
	(handle_one_xevent, x_clear_frame_area):
	* gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
	* xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
	* xterm.h (x_clear_area): Adjust prototype.

573 574 575 576 577 578 579 580 581 582
2013-08-29  Dmitry Antipov  <dmantipov@yandex.ru>

	Hook scanning and indentation functions to find_newline.  This helps
	to avoid duplicated code and renders more respect to newline cache.
	* lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
	* cmds.c (Fforward_line):
	* indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
	Use find_newline and avoid unnecessary point movements.
	* search.c (scan_newline): Implement on top of find_newline.

583 584 585 586 587
2013-08-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
	scoped code (bug#11258).

588 589 590 591 592 593 594 595
2013-08-28  Davor Cubranic  <cubranic@stat.ubc.ca> (tiny change)

	* nsterm.m (last_window): New variable.
	(EV_TRAILER2): New macro.
	(EV_TRAILER): Call EV_TRAILER2.
	(mouseMoved:):  Add support for mouse-autoselect-window
	on nextstep (Bug#6888).

596 597 598 599 600 601
2013-08-28  Andreas Schwab  <schwab@suse.de>

	* regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
	(SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
	Remove unused macro definitions.
	(CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
602 603
	(SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
	Only define if emacs.
604

605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	Prefer enum glyph_row_area to int where appropriate.
	* dispextern.h (enum glyph_row_area): Add ANY_AREA member.
	Fix comment.
	(window_box, window_box_width, window_box_left, window_box_left_offset)
	(window_box_right, window_box_right_offset): Adjust prototypes.
	* xdisp.c (window_box, window_box_width, window_box_left)
	(window_box_left_offset, window_box_right, window_box_right_offset):
	Use enum glyph_row_area.  Adjust users and tweak comment where needed.
	(window_box_edges): Likewise.  Lost 2nd arg since it is always ANY_AREA.
	* nsterm.m (ns_clip_to_row):
	* w32term.c (w32_clip_to_row):
	* xterm.c (x_clip_to_row): Likewise.

620 621 622 623 624
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	* buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
	(Fprevious_overlay_change): Fast path for buffer with no overlays.

625 626 627 628 629
2013-08-28  Paul Eggert  <eggert@cs.ucla.edu>

	* Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
	for portability to hosts where /bin/sh has problems.

630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646
2013-08-28  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop global output_cursor.
	* dispextern.h (struct redisplay_interface): Remove cursor_to member.
	(toplevel): Remove declaration of output_cursor.
	(set_output_cursor, x_cursor_to): Remove prototype.
	* window.h (struct window): New member output_cursor.
	(output_cursor_to): New function to replace RIF member.
	* dispnew.c (redraw_overlapped_rows, update_marginal_area)
	(update_text_area, set_window_cursor_after_update): Use it.
	* xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	* nsterm.m (ns_update_window_begin, ns_update_window_end):
	* w32term.c (x_update_window_begin, x_update_window_end):
	* xterm.c (x_update_window_begin, x_update_window_end):
	Adjust to use per-window output cursor.

647 648
2013-08-27  Paul Eggert  <eggert@cs.ucla.edu>

649 650 651 652 653 654 655
	Simplify SELECT_TYPE-related code.
	Like EMACS_TIME, this portability layer is no longer needed, since
	Emacs has been using fd_set as a portability layer for some time.
	* sysselect.h (FD_SETSIZE): Rename from MAXDESC.  All uses changed.
	(SELECT_TYPE): Remove.  All uses changed to fd_set.
	(fd_set) [!FD_SET]: New typedef.

656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683
	Simplify EMACS_TIME-related code.
	This portability layer is no longer needed, since Emacs has been
	using struct timespec as a portability layer for some time.
	* atimer.h, buffer.h, dispextern.h, xgselect.h:
	Include <time.h> rather than "systime.h"; that's all that's needed now.
	* dispnew.c: Include <timespec.h> rather than "systime.h";
	that's all that's needed now.
	* systime.h (EMACS_TIME): Remove.  All uses changed to struct timespec.
	(EMACS_TIME_RESOLUTION): Remove.  All uses changed to
	TIMESPEC_RESOLUTION.
	(LOG10_EMACS_TIME_RESOLUTION): Remove.  All uses changed to
	LOG10_TIMESPEC_RESOLUTION.
	(EMACS_SECS, emacs_secs_addr): Remove.  All uses changed to tv_sec.
	(EMACS_NSECS): Remove.  All uses changed to tv_nsec.
	(make_emacs_time): Remove.  All used changed to make_timespec.
	(invalid_timespec): Rename from invalid_emacs_time.  All uses changed.
	(current_timespec): Rename from current_emacs_time.  All uses changed.
	(add_emacs_time): Remove.  All uses changed to timespec_add.
	(sub_emacs_time): Remove.  All uses change dot timespec_sub.
	(EMACS_TIME_SIGN): Remove.  All uses changed to timespec_sign.
	(timespec_valid_p): Rename from EMACS_TIME_VALID_P.  All uses changed.
	(EMACS_TIME_FROM_DOUBLE): Remove.  All uses changed to dtotimespec.
	(EMACS_TIME_TO_DOUBLE): Remove.  All uses changed to timespectod.
	(current_timespec): Rename from current_emacs_time.  All uses changed.
	(EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove.  All uses
	changed to timespec_cmp.
	* xgselect.c: Include <timespec.h>, since our .h files don't.

684 685 686 687 688 689 690 691 692 693
2013-08-27  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
	* nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
	Remove the leftovers.
	* gtkutil.c (toplevel): Do not declare Qxft but include
	font.h to do so.
	* image.c (toplevel): Do not declare Vlibrary_cache because
	it's already done in lisp.h.

694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
2013-08-27  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (Mouse_HLInfo): Move from here...
	* dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
	(reset_mouse_highlight): New function.
	* msdos.c (dos_set_window_size, IT_update_begin)
	(internal_terminal_init):
	* nsterm.m (ns_update_window_end, x_free_frame_resources)
	(ns_initialize_display_info):
	* w32console.c (initialize_w32_display):
	* w32term.c (x_update_window_end, x_free_frame_resources)
	(w32_initialize_display_info):
	* xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
	* window.c (Fdelete_other_windows_internal):
	* xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
	* termchar.h (toplevel):
	* xterm.h (toplevel): Include dispextern.h.

712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727
2013-08-26  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
	(expect): Avoid nested-if warning.
	(x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
	* nsmenu.m (fillWithWidgetValue:): Avoid type warning.
	* nsterm.h, nsterm.m (ns_select):
	* xgselect.c, xgselect.h (xg_select):
	Adjust signature to better match pselect's.
	* nsterm.m (ns_select):
	Don't set *TIMEOUT, since pselect doesn't.
	* regex.c (whitespace_regexp): Now const_re_char *, to avoid
	diagnostic about assigning const char * to it.
	* xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.

728 729 730 731 732
2013-08-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lread.c (substitute_object_recurse): Handle hash-tables as well
	(bug#15190).

733 734
2013-08-26  Paul Eggert  <eggert@cs.ucla.edu>

735 736 737 738 739 740 741 742 743 744 745 746
	Fix unlikely core dump in init_tty, and simplify terminfo case.
	* term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
	The old version incorrectly dumped core if malloc returned a
	buffer containing only non-NUL bytes.
	(init_tty): Do not allocate or free termcap buffers; the
	struct does that for us now.
	* termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
	(struct tty_display_info): Define members termcap_term_buffer and
	termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
	use them.  Allocate them directly in struct rather than indirectly
	via a pointer, to simplify init_tty.

747 748 749
	* frame.c (check_minibuf_window): Initialize 'window' properly,
	so that Emacs reliably aborts later if 'window' is not initialized.

750 751 752 753 754
2013-08-26  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
	of VoidSymbol (Bug#15154).

755 756 757 758 759 760 761 762
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (Mouse_HLInfo): Drop set-but-unused members
	mouse_face_beg_y and mouse_face_end_y.
	* xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
	(mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
	Adjust users and update comment where appropriate.

763 764 765
2013-08-26  Martin Rudalics  <rudalics@gmx.at>

	* frame.c (check_minibuf_window): New function.
766 767
	(delete_frame, Fmake_frame_invisible, Ficonify_frame):
	Call check_minibuf_window (Bug#15183).
768

769 770 771 772 773 774 775 776
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Replace last_cursor with last_cursor_vpos
	because this is the only last cursor data we need to keep and consult.
	* window.c (replace_window, set_window_buffer, Fsplit_window_internal):
	* xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
	Adjust users.

777 778
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

779 780
	Fix recovering from possible decompression error.
	Since insert_from_gap doesn't always move point, we can't use PT as
781
	the position where the partially decompressed data ends, and
Dmitry Antipov's avatar
Dmitry Antipov committed
782
	should count how many bytes was produced so far.
783 784 785 786
	* decompress.c (struct decompress_unwind_data): Add nbytes member.
	(unwind_decompress): Really delete partially uncompressed data.
	(Fzlib_decompress_region): Take decompressed data size into account.

787 788 789 790 791 792 793 794 795 796
2013-08-26  Dmitry Antipov  <dmantipov@yandex.ru>

	* syntax.c (init_syntax_once): Adjust comment and do an early
	initialization of Qchar_table_extra_slots just once...
	* casetab.c (init_casetab_once):
	* category.c (init_category_once):
	* character.c (syms_of_character):
	* coding.c (syms_of_coding):
	* xdisp.c (syms_of_xdisp): ...and omit it here.

797 798
2013-08-24  Eli Zaretskii  <eliz@gnu.org>

799 800 801 802
	* xdisp.c (get_next_display_element): Don't apply to characters
	from a display vector the logic of setting it->end_of_box_run_p
	suitable for characters from a buffer.  (Bug#15175)

803 804 805 806
	* w32.c (fdutimens): Call 'utime', which is implemented on w32.c
	to handle directories, rather than '_utime' which doesn't.
	(Bug#15176)

807 808 809 810 811
2013-08-24  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
	or fullscreen (Bug#14627).

812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827
2013-08-24  Paul Eggert  <eggert@cs.ucla.edu>

	System-dependent integer overflow fixes.
	* process.c (Fset_process_window_size): Signal an error if
	the window size is outside the range supported by the lower level.
	* sysdep.c (set_window_size): Return negative on error,
	nonnegative on success, rather than -1, 0, 1 on not in system,
	failure, success.  This is simpler.  Caller changed.
	(serial_configure): Remove unnecessary initialization of local.
	(procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
	size fits in unsigned long; this isn't true on some 32-bit hosts.
	Avoid buffer overrun if some future version of /proc/meminfo has a
	variable name longer than 20 bytes.
	(system_process_attributes) [__FreeBSD__]:
	Don't assume hw.availpages fits in 'int'.

828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849
2013-08-23  Paul Eggert  <eggert@cs.ucla.edu>

	Don't let very long directory names overrun the stack.
	Fix some related minor problems involving "//", vfork.
	* callproc.c (encode_current_directory): New function.
	(call_process): Don't append "/"; not needed.
	* fileio.c (file_name_as_directory_slop): New constant.
	(file_name_as_directory): Allow SRC to be longer than SRCLEN;
	this can save the caller having to alloca.
	(Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
	Use SAFE_ALLOCA, not alloca.
	(directory_file_name, Fexpand_file_name): Leave leading "//"
	alone, since it can be special even on POSIX platforms.
	* callproc.c (call_process):
	* process.c (Fformat_network_address):
	* sysdep.c (sys_subshell):
	Use encode_current_directory rather than rolling our own.
	(create_process): No need to encode directory; caller does that now.
	* process.h (encode_current_directory): New decl.
	* sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
	Rework to avoid 'goto xyzzy;'.

850 851 852 853 854
2013-08-23  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_face_prop): If the default face was remapped use
	the remapped face for strings from prefix properties.  (Bug#15155)

855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Minor cleanup for redisplay interface and few related functions.
	* frame.h (enum text_cursor_kinds): Move from here...
	* dispextern.h (enum text_cursor_kinds): ...to here.
	(toplevel): Drop unnecessary declarations.
	(struct redisplay_interface): Use bool and enum text_cursor_kinds
	in update_window_end_hook and draw_window_cursor functions.
	(display_and_set_cursor, x_update_cursor): Adjust prototypes.
	* nsterm.m (ns_update_window_end, ns_draw_window_cursor):
	* w32term.c (x_update_window_end,w32_draw_window_cursor):
	* xterm.c (x_update_window_end, x_draw_window_cursor):
	* xdisp.c (display_and_set_cursor, update_window_cursor)
	(update_cursor_in_window_tree, x_update_cursor): Use bool and
	enum text_cursor_kinds where appropriate.

871 872 873 874 875 876 877 878 879 880 881 882 883 884 885
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop updated_row and updated_area.
	* dispextern.h (updated_row, updated_area): Remove declaration.
	(struct redisplay_interface): Pass glyph row and row area parameters
	to write_glyphs, insert_glyphs and clear_end_of_line functions.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust prototypes.
	* dispnew.c (updated_row, updated_area): Remove.
	(redraw_overlapped_rows, update_window_line): Adjust user.
	(update_marginal_area, update_text_area): Likewise.  Pass updated row
	as a parameter.  Prefer enum glyph_row_area to int where appropriate.
	* xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust users.

886 887 888 889 890
2013-08-22  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (flush_pending_output): Remove stub.
	All uses removed.

891 892 893 894 895 896 897 898
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* callproc.c: Fix race that killed background processes (Bug#15144).
	(call_process): New arg TEMPFILE_INDEX.  Callers changed.
	Record deleted process-id in critical section, not afterwards.
	Don't mistakenly kill process created by a call-process invocation
	that discards output and does not wait.

899 900 901 902 903 904 905 906 907
2013-08-21  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
	and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
	* alloc.c (toplevel): Remove unnecessary nested #if...#endif.
	(mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
	to shut up compiler in mark_object.
	(dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.

908 909 910 911 912 913
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
	We can't portably rely on PTY_OPEN doing that, even if
	it calls posix_openpt with O_CLOEXEC.

914 915 916 917
2013-08-20  Kenichi Handa  <handa@gnu.org>

	* character.c (string_char): Improve commentary.

918 919 920 921 922 923 924
2013-08-20  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (SIGNATURE_DIGESTSIZE): Remove.
	(struct animation_cache): Make signature a flexible array member.
	All uses changed.  This is a tad slower but may insulate us better
	from future changes to ImageMagick.

925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c: Shrink memory needed for animation cache.
	(SIGNATURE_DIGESTSIZE): New constant.
	(struct animation_cache): Make 'signature' a fixed size array of bytes.
	(imagemagick_create_cache): Copy the signature.  This saves
	several KB of memory that ImageMagick wastes per signature.
	Don't bother updating the update_time, as the caller does that now.
	(imagemagick_prune_animation_cache): Don't destroy the signature, as
	it's a fixed size struct member now.
	(imagemagick_get_animation_cache): Always destroy the signature,
	as it's now imagemagick_create_cache's responsibility to copy it.
	Avoid duplicate calls to strcmp and to imagemagick_create_cache,
	and use memcmp rather than strcmp.
	eassert that ImageMagick returns a signature of the specified length.

941 942 943 944
2013-08-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault on
	each invocation.
945 946 947
	(imagemagick_get_animation_cache): Revert to previous definition
	so that it actually works.  But keep the memory leak fix.
	(imagemagick_get_animation_cache): Fix memory leak.
948

949 950
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

951 952 953 954 955 956 957 958 959 960 961
	* image.c: Fix animation cache signature memory leak.
	Fix some other minor performance problems while we're at it.
	(imagemagick_create_cache): Clear just the members that
	need clearing.  Don't set update_time, as caller does that now.
	(imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
	Simplify by using pointer-to-pointer instead of a prev pointer.
	(imagemagick_prune_animation_cache): Use make_emacs_time rather
	than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
	(imagemagick_get_animation_cache): Don't xstrdup the image signature;
	it's already a copy.  Free the signature probe unless it's cached.

962 963 964
	* process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
	This was introduced by my 2013-08-12 fix for Bug#15035.

965 966 967 968 969
2013-08-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
	(imagemagick_prune_animation_cache): Now static.

970 971 972 973 974
2013-08-18  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault when
	pruning all entries.

975 976 977 978 979 980 981 982 983
2013-08-18  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
	static heap if ENABLE_CHECKING is defined.
	(max_bss_sbrk_ptr): New variable.
	(bss_sbrk): Use it.
	(report_sheap_usage): Report maximum static heap usage instead of
	ending static heap usage.

984 985 986 987 988 989
2013-08-17  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
	of zlib_initialized according to the results of calling
	init_zlib_functions.

990 991 992
2013-08-16  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c: Implement an ImageMagick per-image cache.
993
	(imagemagick_get_animation_cache): Fix a double-free error.
994 995 996
	(imagemagick_load_image): Remove the ping_wand code, which only
	apparently saved time on invalid animated images, and slowed down
	everything else.  Optimise for the common case.
997

998 999
2013-08-16  Xue Fuqiao  <xfq.free@gmail.com>

1000 1001
	* buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.

1002 1003
	* editfns.c (insert_before_markers): Mention overlay in the doc string.

1004 1005
	* marker.c (set_marker): Remove documentation of undefined behavior.

1006 1007 1008 1009
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Animate correctly
	when sub-images are smaller than the main image.
1010 1011
	(imagemagick_compute_animated_image): Setting the iterator row to
	zero is apparently not allowed.
1012 1013 1014
	(imagemagick_compute_animated_image): Allow images that say they
	have sub-images that are bigger than the main image, but just crop
	them.
1015

1016 1017 1018 1019
2013-08-15  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).

1020 1021 1022 1023 1024
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Respect the GIF
	disposal methods.

1025 1026 1027 1028 1029 1030
2013-08-15  Ken Brown  <kbrown@cornell.edu>

	* emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
	* gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
	needed.

1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2013-08-15  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* frame.c (delete_frame):
	* xdisp.c (next_element_from_display_vector):
	Avoid uninitialized local.
	* image.c (imagemagick_compute_animated_image): Port to C89.
	Prefer usual GNU indentation style for loops.
	Be more careful about bizarrely large sizes, by using ptrdiff_t
	instead of int.

1042 1043 1044 1045 1046
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix infinite frame selection loop (Bug#15025).
	* frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.

1047 1048
2013-08-15  Eli Zaretskii  <eliz@gnu.org>

1049 1050
	* xdisp.c (compute_window_start_on_continuation_line):
	When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
1051 1052 1053 1054
	to make sure we end up setting the window start at the leftmost
	visible character of the display line.  This avoids funky
	horizontal shifting because the window start is not kept on the
	same position.  (Bug#15090)
1055 1056
	(next_element_from_display_vector): Support 'box' face attribute
	in the face definitions of a display vector.  (Bug#15099)
1057

1058 1059 1060 1061
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Implement animated
	images (bug#14700).
1062 1063 1064
	(imagemagick_compute_animated_image): Fix some compilation
	warnings.  Implement a very simple cache to make the animation
	usable at all, but it should be replaced with a per-image cache.
1065

1066 1067 1068 1069 1070 1071 1072 1073 1074
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (FOR_EACH_ALIST_VALUE): New macro
	to do `for' loops over alist values.
	* buffer.h (FOR_EACH_BUFFER):
	* process.c (FOR_EACH_PROCESS): Use it.
	(handle_child_signal, status_notify, Fget_buffer_process)
	(kill_buffer_processes): Use FOR_EACH_PROCESS.

1075 1076 1077 1078 1079 1080 1081 1082 1083
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
	(tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
	* image.c (make_image_cache): For struct image_cache, prefer xmalloc
	to xzalloc and so avoid redundant call to memset.
	* xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
	members because it is allocated with xzalloc and so already zeroed.

1084 1085 1086 1087 1088
2013-08-14  Ken Brown  <kbrown@cornell.edu>

	* gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
	(Bug#15094).

1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Utility function and macro to copy Lisp string to C string.
	* lisp.h (xlispstrdupa): New macro.
	(xlispstrdup): New prototype.
	* alloc.c (xlispstrdup): New function.
	* callint.c (Fcall_interactively):
	* fileio.c (Ffile_name_directory, Fexpand_file_name)
	(Fsubstitute_in_file_name):
	* frame.c (Fmake_terminal_frame): Use xlispstrdupa.
	* image.c (x_create_bitmap_from_file):
	* w32term.c (w32_term_init):
	* xterm.c (x_term_init): Use xlispstrdup.

1103 1104
2013-08-14  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1105 1106 1107 1108
	* image.c (imagemagick_load_image): Make animated pictures work.
	There's still some problems with background color settings, though
	(bug#14700).

1109 1110
	* decompress.c (unwind_decompress): Always restore point.

1111 1112 1113 1114
2013-08-14  Xue Fuqiao  <xfq.free@gmail.com>

	* marker.c (set_marker): Reformat documentation.

1115 1116
2013-08-14  Paul Eggert  <eggert@cs.ucla.edu>

1117 1118
	* xdisp.c (cursor_type_changed): Now static.

1119 1120 1121 1122
	* image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
	Use changed.  This avoids the need to call xmalloc and for the
	caller to call xfree, and avoids memory leaks in some situations.

1123 1124 1125 1126
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (adjust_window_ends): Move duplicated code to new function.
	(try_window, try_window_reusing_current_matrix, try_window_id): Use it.
1127 1128 1129
	(redisplay_window): If window_end_valid is cleared due to non-zero
	windows_or_buffers_changed, clear current_matrix_up_to_date_p and
	so do not call to try_cursor_movement for that window.
1130

1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert window_end_pos and
	window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
	(wset_window_end_pos, wset_window_end_vpos): Remove.
	* dispnew.c (adjust_glyph_matrix):
	* window.c (Fwindow_end, replace_window, set_window_buffer)
	(make_window):
	* xdisp.c (check_window_end, move_it_to, redisplay_internal)
	(set_vertical_scroll_bar, redisplay_window, try_window)
	(try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
	(try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
	(note_mouse_highlight): Adjust users.
	(try_cursor_movement): Likewise.  Convert old precondition to eassert.
	Add comment.

1147 1148 1149 1150 1151 1152
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
	* image.c (imagemagick_filename_hint): Use `const char *' and
	prefer SSDATA to SDATA to avoid warnings.

1153 1154 1155 1156 1157 1158 1159 1160
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleanup window fringes, margins and scroll bars adjustments.
	* window.c (set_window_fringes, set_window_margins)
	(set_window_scroll_bars, apply_window_adjustment): New functions.
	(set_window_buffer, Fset_window_margins, Fset_window_fringes)
	(Fset_window_scroll_bars): Use them.

1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert scroll_bar_width
	from Lisp_Object to integer.  Adjust comment.
	(WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
	Adjust users.
	* window.c (wset_scroll_bar_width): Remove.
	(make_window): Initialize scroll_bar_width.
	(Fsplit_window_internal): Use direct assignment.
	(Fset_window_configuration, save_window_save):
	Convert Lisp_Object to integer and back where appropriate.
	(Fset_window_scroll_bars): Adjust user.  Return t if any scroll
	bar was actually changed, and mention this in docstring.

1175 1176 1177 1178 1179 1180 1181 1182
2013-08-13  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c: Minor simplifications.
	(Fzlib_decompress_region): Don't bother verifying
	that avail_out <= UINT_MAX, as that was confusing.
	Mention the restriction in a comment instead.
	Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.

Jan Djärv's avatar
Jan Djärv committed
1183 1184 1185 1186 1187
2013-08-13  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
	(trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.

1188 1189 1190 1191 1192
2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_filename_hint): Check for errors in the
	alist structure.

1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
2013-08-13  Eli Zaretskii  <eliz@gnu.org>

	* window.c (Fwindow_margins): Return nil when there's no marginal
	area, as per the documented API.

	* w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
	Fmake_vector, as scroll bar's struct members are not all Lisp
	objects now.  This avoids crashes in GC.

	* w32term.h (struct scroll_bar): Convert fringe_extended_p to a
	bool, so its address could be taken.

1205 1206 1207 1208 1209 1210
2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_filename_hint): New function to possibly
	apply `image-content-type-suffixes'.
	(imagemagick_load_image): Use it.

1211 1212 1213 1214 1215
2013-08-13  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
	if loading zlib failed.

1216 1217
2013-08-13  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
1218 1219 1220 1221
	* nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
	2013-08-13 checkin below.  Change bool to BOOL, rule is:
	All Obj-C code uses BOOL, except for interfaces callable from C.

1222 1223
	* nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).

1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
	* nsterm.m (ns_set_vertical_scroll_bar): Use it.  Use convenient
	bool instead of BOOL.
	* w32term.h (struct scroll_bar): Convert fringe_extended_p
	from Lisp_Object to bitfield.  Adjust comment.
	* w32term.c (x_scroll_bar_create): Adjust user.
	Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
	* xterm.c (XTset_vertical_scroll_bar): Likewise.
	Use bool for boolean.
	* xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
	to `unsigned int' when defining a bitfield.

1238 1239 1240 1241
2013-08-13  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.

1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_margin_cols and
	right_margin_cols from Lisp_Objects to integers.  Adjust comment.
	(WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
	(WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
	Adjust users.
	* dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
	Adjust comment.
	(showing_window_margins_p, update_window_line, update_frame_1):
	* fringe.c (draw_fringe_bitmap_1):
	* xdisp.c (window_box_width): Adjust users.
	* window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
	(adjust_window_margins, set_window_buffer, Fsplit_window_internal):
	Use direct assignment.
	(Fset_window_configuration, save_window_save, Fwindow_margins):
	Convert Lisp_Object to integer and back where appropriate.
	(Fset_window_margins): Adjust user.  Return t if any margin
	was actually changed, and mention this in docstring.

1262 1263
2013-08-13  Xue Fuqiao  <xfq.free@gmail.com>

1264
	* syntax.c (forward_word):
1265 1266
	* cmds.c (forward_char, backward_char): Mention the optional argument.

1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_fringe_width
	and right_fringe_width from Lisp_Objects to integers.
	Adjust comment.
	(WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
	(WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
	* window.c (wset_left_fringe_width, wset_right_fringe_width):
	Remove.
	(make_window): Initialize new integer fields to -1.
	(Fsplit_window_internal): Use direct assignment.
1278 1279
	(Fset_window_configuration, save_window_save):
	Convert Lisp_Object to integer and back where appropriate.
1280 1281 1282
	(Fset_window_fringes): Adjust user.  Return t if any fringe
	was actually changed, and mention this in docstring.

1283 1284 1285
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
1286 1287 1288 1289
	* nsfns.m (x_set_cursor_type):
	* w32fns.c (x_set_cursor_type):
	* xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
	* xdisp.c (set_frame_cursor_types): ...but in common code.
1290

1291 1292 1293 1294 1295 1296 1297 1298
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (clear_font_cache): New function, stripped from...
	(Fclear_font_cache): ...here, which now uses the function
	above.  Adjust comment.
	* font.h (clear_font_cache): Add prototype.
	* xfaces.c (clear_face_cache): Use clear_font_cache.

1299 1300 1301 1302 1303
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fset_window_start): Compare `w', not `window' because
	`w' might not be equal to `window' after call to decode_live_window.

1304 1305 1306 1307 1308 1309
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (deactivate_process): Reset fds to -1 (Bug#15035).
	This fixes a problem introduced by the Bug#15035 patch
	when using GPG.  Reported by Herbert J. Skuhra.

1310 1311 1312 1313 1314 1315
2013-08-12  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
	(Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
	not yet initialized.

1316 1317 1318 1319 1320
2013-08-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* decompress.c (Fzlib_decompress_region): Support zlib
	decompression, too, and rename.

Paul Eggert's avatar
Paul Eggert committed
1321 1322 1323 1324 1325 1326
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	Minor zlib configuration tweaks.
	* decompress.c (fn_inflateInit2) [!WINDOWSNT]:
	Don't assume presence of fn_inflateInit2_ zlib internal function.

1327 1328 1329 1330 1331
2013-08-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* decompress.c (Fzlib_decompress_gzipped_region): Rename to
	include the zlib prefix.

1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342
2013-08-12  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c [WINDOWSNT]: Include windows.h and w32.h.
	(DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros.  Use them to
	define static variables that are pointers to zlib functions to be
	dynamically loaded.
	(init_zlib_functions) [WINDOWSNT]: New function.
	(fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
	New macros.
	(Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
	macros instead of invoking the zlib functions directly.
1343 1344
	(syms_of_decompress): DEFSYM Qzlib_dll.
	Staticpro Szlib_available_p.
1345

1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359
2013-08-12  Dmitry Antipov  <dmantipov@yandex.ru>

	Avoid looping over all frame windows to freeze and unfreeze.
	* window.h (struct window): Drop frozen_window_start_p.
	(freeze_window_starts): Drop prototype.
	* frame.h (struct frame): New frozen_window_starts flag.
	(FRAME_WINDOWS_FROZEN): New macro.
	* window.c (freeze_window_start, freeze_window_starts):
	Remove.
	(select_window, replace_window): Adjust users.
	* xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
	(window_frozen_p): New function.
	(redisplay_window): Use it.

1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	Fix some fd issues when running subprocesses (Bug#15035).
	Fix bugs that can leak files or file descriptors on errors.
	Don't unlink open temp files, as that's hard for users to diagnose
	when things go awry (e.g., temp disk exhausted).
	Don't bother to lock temp files.  Check for invalid recursion.
	* callproc.c (synch_process_fd): Remove.  All uses removed.
	(synch_process_tempfile): New var or macro.
	(CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
	New constants.
	(record_kill_process): New arg, the temp name.  All callers changed.
	(delete_temp_file): Now just a simple wrapper around unlink.
	(call_process_kill): New arg, the call_process_fd array.
	Close them all.  Clear synch_process_pid.  Remove the temp file,
	or arrange for it to be removed.
	(call_process_cleanup) [MSDOS]: Arg no longer contains file name;
	that's been moved to synch_process_tempfile.  Caller changed.
	Do not remove the tempfile; that's now call_process_kill's
	responsibility.
	(call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
	call_process_kill; the caller now does that.
	(call_process_cleanup): Do not close the process fd; that's now
	call_process_kill's responsibility.
	(Fcall_process): Implement via new function call_process, which
	has most of the old body of Fcall_process, but with a different API.
	(call_process): New function that does not open or close filefd if
	it is nonnegative.  Record which fds need to be closed, and let
	call_process_kill close (and remove the tempfile, on MSDOS) on error.
	Signal an error if invoked recursively (could be done via a hook).
	Simplify creation of the tempfile in the MSDOS case.
	Don't create the output file until after checking for the executable.
	Report any failure to open /dev/null.
	Don't open /dev/null for writing twice; once is enough.
	Don't create pipe if all output is being discarded or sent to file.
	Don't worry about setting up the coding system or reading from the
	pipe if all output is being discarded.
	Hoist fd_error local into top level, to lessen block nesting.
	Don't record deleted pid here; now done by Fcall_process_region.
	(Fcall_process) [MSDOS]: Report mktemp failure immediately,
	and note its success in synch_process_tempfile.
	Do not leak resources when child_setup fails.
	(Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
	to child_errno.  Remove unnecessary close of fd0; it's close-on-exec.
	(create_temp_file): Now returns open fd, with an additional
	Lisp_Object * argument to return the name.  All callers changed.
	Do not close the file; rewind it instead, and leave it open for
	the caller.  Do not lock the temp file.  Unwind-protect the file
	and the file-descriptor.
	(Fcall_process_region): If the input is /dev/null, unwind-protect it.
	If an asynchrounous process, record it here, not in call_process.
	(syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
	* eval.c (set_unwind_protect): New function.
	* fileio.c (write_region): New function, generalized from the
	old Fwrite_region.  Do not lock temp files.
	(Fwrite_region): Use it.
	* lisp.h (set_unwind_protect, write_region): New decls.
	* process.c: Include <verify.h>.
	(make_process): Mark fds as initially closed.
	(deleted_pid_list): Now a list of pid-filename pairs.
	All uses changed.
	(close_process_fd): New function.
	(SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
	(SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
	New constants.  Verify that their number matches PROCESS_OPEN_FDS.
	(create_process, create_pty, Fmake_serial_process)
	(server_accept_connection): Record which fds need to be closed,
	and let deactivate_process close them.
	(Fmake_network_process): Do not discard the unwind-protect
	until it's safe to do so.
	(deactivate_process): Close the fds opened by create_process etc.
	(Fprocess_send_eof): Adjust to new way of recording open fds.
	Report an error if /dev/null can't be opened, instead of aborting.
	* process.h (PROCESS_OPEN_FDS): New constant.
	(struct Lisp_Process): New member open_fds.
	(record_kill_process, record_deleted_pid): Adjust signatures.
	(record_deleted_pid): Move decl here ...
	* syswait.h (record_deleted_pid): ... from here.

1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449
2013-08-11  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c: Fix bugs with large buffers and weird inputs.
	Tune a bit.  Reindent as per usual Emacs style.
	(BUFFER_SIZE): Remove.
	(Fdecompress_gzipped_region): Do not mishandle input buffers with
	more than UINT_MAX bytes.  Decompress into the gap instead of into
	an auto buffer, as this should avoid copying.  Return nil if
	'inflate' returns Z_NEED_DICT, as we have no dictionary.  Do not
	set immediate_quit; we shouldn't trust zlib code that much.

1450 1451
2013-08-11  Lars Magne Ingebrigtsen  <larsi@gnus.org>

1452 1453 1454
	* decompress.c (Fdecompress_gzipped_region): Respect all zlib
	errors, and really move the gap to where we want it.

1455 1456 1457 1458 1459 1460
	* lisp.h: Include decompress.c support.

	* emacs.c (main): Include decompress.c support.

	* Makefile.in: Include -lz if present.

1461 1462
2013-08-11  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
1463 1464 1465
	* nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
	(initWithTitle:): Initialize frame to 0.
	(fillWithWidgetValue:): Call fillWithWidgetValue:frame.
1466
	(fillWithWidgetValue:frame:): Rename from
Jan Djärv's avatar
Jan Djärv committed
1467 1468 1469 1470 1471
	fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.

	* nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
	fillWithWidgetValue:frame:

Jan Djärv's avatar
Jan Djärv committed
1472 1473 1474
	* nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
	remove memory leak warnings.

1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490
	* nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
	(ns_check_menu_open): Handle menu == nil.  Remove assignment to
	menu_pending_title.

	* nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
	(x_activate_menubar): Update the whole menu.
	(trackingNotification:): Call ns_check_menu_open if tracking ends.
	(menuWillOpen:): Increment trackingMenu.  For OSX <= 10.6, exit if
	current event is not NSSystemDefined (Bug#15001).
	Call ns_check_menu_open only if trackingMenu is 2.
	(menuDidClose:): New method, decrease trackingMenu.
	(fillWithWidgetValue:setDelegate:): New method.
	(fillWithWidgetValue:): Call the above.

	* nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:

Paul Eggert's avatar
Paul Eggert committed
1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544
2013-08-11  Paul Eggert  <eggert@cs.ucla.edu>

	Omit some unnecessary casts.
	Many of these go back to the old pre-C89 days, when they may have
	been needed, but we've been assuming C89 or later for a while now.
	* alloc.c (live_string_p, live_cons_p, live_symbol_p)
	(live_float_p, live_misc_p, live_vector_p):
	* buffer.c (compare_overlays, cmp_for_strings, mmap_find)
	(mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
	(defvar_per_buffer):
	* callint.c (Fcall_interactively):
	* doc.c (Fsubstitute_command_keys):
	* filelock.c (get_boot_time):
	* frame.c (xrdb_get_resource):
	* gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
	(delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
	(xg_get_file_name_from_selector, menuitem_destroy_callback)
	(menuitem_highlight_callback, menu_destroy_callback)
	(xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
	(xg_tool_bar_callback, xg_get_tool_bar_widgets)
	(xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
	(xg_tool_bar_help_callback, tb_size_cb):
	* image.c (xpm_alloc_color, png_read_from_memory)
	(png_read_from_file, png_load_body, our_memory_skip_input_data)
	(jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
	(syms_of_image):
	* keymap.c (describe_map):
	* nsfns.m (Fns_display_monitor_attributes_list):
	* nsmenu.m (process_dialog:):
	* nsterm.m (hold_event):
	* process.c (wait_reading_process_output):
	* regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
	* scroll.c (do_direct_scrolling, scrolling_1):
	* termcap.c (tgetent):
	* window.c (check_window_containing, add_window_to_list)
	(freeze_window_starts):
	* xdisp.c (compare_overlay_entries, vmessage):
	* xfns.c (x_window, x_get_monitor_attributes_xinerama)
	(x_get_monitor_attributes_xrandr)
	(Fx_display_monitor_attributes_list, x_display_info_for_name)
	(Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
	* xfont.c (xfont_match, xfont_open):
	* xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
	(menubar_selection_callback, menu_position_func)
	(popup_selection_callback, create_and_show_popup_menu)
	(dialog_selection_callback, create_and_show_dialog):
	* xrdb.c (x_get_string_resource):
	(main) [TESTRM]:
	* xsmfns.c (x_session_check_input):
	* xterm.c (x_draw_glyphless_glyph_string_foreground)
	(xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
	(xaw_jump_callback, xaw_scroll_callback):
	Omit unnecessary casts.

Paul Eggert's avatar
Paul Eggert committed
1545 1546 1547 1548 1549 1550 1551
2013-08-10  Paul Eggert  <eggert@cs.ucla.edu>

	Minor string-length refactoring.
	* alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
	* frame.c (make_monitor_attribute_list):
	Prefer build_string to strlen + make_string.

1552 1553 1554 1555 1556
2013-08-10  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
	don't check minor_code (Bug#14417).

1557 1558 1559 1560 1561 1562
2013-08-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (draw_glyphs): Don't compare row pointers, compare row
	vertical positions instead.  This avoids calling MATRIX_ROW with
	row numbers that are possibly beyond valid limits.  (Bug#15064)

1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578
2013-08-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Use xstrdup and build_unibyte_string where applicable.
	* alloc.c (xstrdup): Tiny cleanup.  Add eassert.
	* xfns.c (x_window):
	* xrdb.c (x_get_customization_string):
	* xterm.c (xim_initialize):
	* w32fns.c (w32_window): Use xstrdup.
	(w32_display_monitor_attributes_list):
	* emacs.c (init_cmdargs):
	* keyboard.c (PUSH_C_STR):
	* nsfont.m (nsfont_open):
	* sysdep.c (system_process_attributes):
	* w32.c (system_process_attributes):
	* xdisp.c (message1, message1_nolog): Use build_unibyte_string.

1579 1580 1581 1582 1583 1584 1585 1586
2013-08-09  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
	variables of these types so that GDB would know about them, as aid
	for debugging fatal exceptions.  (Bug#15024)  See also
	http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
	discussions.

1587 1588 1589 1590 1591
2013-08-08  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_begin): Don't change clip path if it would be
	larger than the NSWindow (Bug#14934).

1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617
2013-08-08  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop global variable updated_window.
	Always pass currently updated window as a parameter to update routines.
	* dispextern.h (updated_window): Remove declaration.
	(struct redisplay_interface): Pass window parameter to
	write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
	and after_update_window_hook.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
	Adjust prototypes.
	* dispnew.c (updated_window): Remove.
	(redraw_overlapped_rows, update_marginal_area, update_text_area)
	(update_window_line): Adjust to match redisplay interface changes.
	* nsterm.m (ns_update_window_begin, ns_update_window_end)
	(ns_scroll_run, ns_after_update_window_line):
	* w32term.c (x_update_window_begin, x_update_window_end)
	(x_after_update_window_line, x_scroll_run):
	* xterm.c (x_update_window_begin, x_update_window_end)
	(x_after_update_window_line, x_scroll_run):
	* xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Likewise.  Adjust comments where appropriate.
	(x_cursor_to): Simplify because this is always called during window
	update (but install debugging check anyway).
	(expose_window): Check must_be_updated_p flag to see whether this
	function is called during window update.

1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630
2013-08-08  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not reset window modification event counters excessively.
	These leftovers and poor man's tricky methods to catch extra
	redisplay's attention are no longer needed.
	* frame.c (set_menu_bar_lines_1):
	* minibuf.c (read_minibuf_unwind):
	* window.c (Fset_window_start, set_window_buffer, window_resize_apply)
	(grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
	(window_scroll_line_based, Fset_window_configuration):
	* xdisp.c (redisplay_window): Do not reset last_modified and
	last_overlay_modified counters.

1631 1632 1633 1634 1635