ChangeLog 180 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
2013-08-23  Paul Eggert  <eggert@cs.ucla.edu>

	Don't let very long directory names overrun the stack.
	Fix some related minor problems involving "//", vfork.
	* callproc.c (encode_current_directory): New function.
	(call_process): Don't append "/"; not needed.
	* fileio.c (file_name_as_directory_slop): New constant.
	(file_name_as_directory): Allow SRC to be longer than SRCLEN;
	this can save the caller having to alloca.
	(Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
	Use SAFE_ALLOCA, not alloca.
	(directory_file_name, Fexpand_file_name): Leave leading "//"
	alone, since it can be special even on POSIX platforms.
	* callproc.c (call_process):
	* process.c (Fformat_network_address):
	* sysdep.c (sys_subshell):
	Use encode_current_directory rather than rolling our own.
	(create_process): No need to encode directory; caller does that now.
	* process.h (encode_current_directory): New decl.
	* sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
	Rework to avoid 'goto xyzzy;'.

23 24 25 26 27
2013-08-23  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_face_prop): If the default face was remapped use
	the remapped face for strings from prefix properties.  (Bug#15155)

28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Minor cleanup for redisplay interface and few related functions.
	* frame.h (enum text_cursor_kinds): Move from here...
	* dispextern.h (enum text_cursor_kinds): ...to here.
	(toplevel): Drop unnecessary declarations.
	(struct redisplay_interface): Use bool and enum text_cursor_kinds
	in update_window_end_hook and draw_window_cursor functions.
	(display_and_set_cursor, x_update_cursor): Adjust prototypes.
	* nsterm.m (ns_update_window_end, ns_draw_window_cursor):
	* w32term.c (x_update_window_end,w32_draw_window_cursor):
	* xterm.c (x_update_window_end, x_draw_window_cursor):
	* xdisp.c (display_and_set_cursor, update_window_cursor)
	(update_cursor_in_window_tree, x_update_cursor): Use bool and
	enum text_cursor_kinds where appropriate.

44 45 46 47 48 49 50 51 52 53 54 55 56 57 58
2013-08-23  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop updated_row and updated_area.
	* dispextern.h (updated_row, updated_area): Remove declaration.
	(struct redisplay_interface): Pass glyph row and row area parameters
	to write_glyphs, insert_glyphs and clear_end_of_line functions.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust prototypes.
	* dispnew.c (updated_row, updated_area): Remove.
	(redraw_overlapped_rows, update_window_line): Adjust user.
	(update_marginal_area, update_text_area): Likewise.  Pass updated row
	as a parameter.  Prefer enum glyph_row_area to int where appropriate.
	* xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Adjust users.

59 60 61 62 63
2013-08-22  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (flush_pending_output): Remove stub.
	All uses removed.

64 65 66 67 68 69 70 71
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* callproc.c: Fix race that killed background processes (Bug#15144).
	(call_process): New arg TEMPFILE_INDEX.  Callers changed.
	Record deleted process-id in critical section, not afterwards.
	Don't mistakenly kill process created by a call-process invocation
	that discards output and does not wait.

72 73 74 75 76 77 78 79 80
2013-08-21  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
	and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
	* alloc.c (toplevel): Remove unnecessary nested #if...#endif.
	(mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
	to shut up compiler in mark_object.
	(dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.

81 82 83 84 85 86
2013-08-21  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
	We can't portably rely on PTY_OPEN doing that, even if
	it calls posix_openpt with O_CLOEXEC.

87 88 89 90
2013-08-20  Kenichi Handa  <handa@gnu.org>

	* character.c (string_char): Improve commentary.

91 92 93 94 95 96 97
2013-08-20  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c (SIGNATURE_DIGESTSIZE): Remove.
	(struct animation_cache): Make signature a flexible array member.
	All uses changed.  This is a tad slower but may insulate us better
	from future changes to ImageMagick.

98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

	* image.c: Shrink memory needed for animation cache.
	(SIGNATURE_DIGESTSIZE): New constant.
	(struct animation_cache): Make 'signature' a fixed size array of bytes.
	(imagemagick_create_cache): Copy the signature.  This saves
	several KB of memory that ImageMagick wastes per signature.
	Don't bother updating the update_time, as the caller does that now.
	(imagemagick_prune_animation_cache): Don't destroy the signature, as
	it's a fixed size struct member now.
	(imagemagick_get_animation_cache): Always destroy the signature,
	as it's now imagemagick_create_cache's responsibility to copy it.
	Avoid duplicate calls to strcmp and to imagemagick_create_cache,
	and use memcmp rather than strcmp.
	eassert that ImageMagick returns a signature of the specified length.

114 115 116 117
2013-08-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault on
	each invocation.
118 119 120
	(imagemagick_get_animation_cache): Revert to previous definition
	so that it actually works.  But keep the memory leak fix.
	(imagemagick_get_animation_cache): Fix memory leak.
121

122 123
2013-08-19  Paul Eggert  <eggert@cs.ucla.edu>

124 125 126 127 128 129 130 131 132 133 134
	* image.c: Fix animation cache signature memory leak.
	Fix some other minor performance problems while we're at it.
	(imagemagick_create_cache): Clear just the members that
	need clearing.  Don't set update_time, as caller does that now.
	(imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
	Simplify by using pointer-to-pointer instead of a prev pointer.
	(imagemagick_prune_animation_cache): Use make_emacs_time rather
	than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
	(imagemagick_get_animation_cache): Don't xstrdup the image signature;
	it's already a copy.  Free the signature probe unless it's cached.

135 136 137
	* process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
	This was introduced by my 2013-08-12 fix for Bug#15035.

138 139 140 141 142
2013-08-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
	(imagemagick_prune_animation_cache): Now static.

143 144 145 146 147
2013-08-18  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_get_animation_cache): Don't segfault when
	pruning all entries.

148 149 150 151 152 153 154 155 156
2013-08-18  Ken Brown  <kbrown@cornell.edu>

	* sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
	static heap if ENABLE_CHECKING is defined.
	(max_bss_sbrk_ptr): New variable.
	(bss_sbrk): Use it.
	(report_sheap_usage): Report maximum static heap usage instead of
	ending static heap usage.

157 158 159 160 161 162
2013-08-17  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
	of zlib_initialized according to the results of calling
	init_zlib_functions.

163 164 165
2013-08-16  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c: Implement an ImageMagick per-image cache.
166
	(imagemagick_get_animation_cache): Fix a double-free error.
167 168 169
	(imagemagick_load_image): Remove the ping_wand code, which only
	apparently saved time on invalid animated images, and slowed down
	everything else.  Optimise for the common case.
170

171 172
2013-08-16  Xue Fuqiao  <xfq.free@gmail.com>

173 174
	* buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.

175 176
	* editfns.c (insert_before_markers): Mention overlay in the doc string.

177 178
	* marker.c (set_marker): Remove documentation of undefined behavior.

179 180 181 182
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Animate correctly
	when sub-images are smaller than the main image.
183 184
	(imagemagick_compute_animated_image): Setting the iterator row to
	zero is apparently not allowed.
185 186 187
	(imagemagick_compute_animated_image): Allow images that say they
	have sub-images that are bigger than the main image, but just crop
	them.
188

189 190 191 192
2013-08-15  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).

193 194 195 196 197
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Respect the GIF
	disposal methods.

198 199 200 201 202 203
2013-08-15  Ken Brown  <kbrown@cornell.edu>

	* emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
	* gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
	needed.

204 205 206 207 208 209 210 211 212 213 214
2013-08-15  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* frame.c (delete_frame):
	* xdisp.c (next_element_from_display_vector):
	Avoid uninitialized local.
	* image.c (imagemagick_compute_animated_image): Port to C89.
	Prefer usual GNU indentation style for loops.
	Be more careful about bizarrely large sizes, by using ptrdiff_t
	instead of int.

215 216 217 218 219
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix infinite frame selection loop (Bug#15025).
	* frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.

220 221 222 223 224 225 226 227
2013-08-15  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (compute_window_start_on_continuation_line): When
	WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
	to make sure we end up setting the window start at the leftmost
	visible character of the display line.  This avoids funky
	horizontal shifting because the window start is not kept on the
	same position.  (Bug#15090)
228 229
	(next_element_from_display_vector): Support 'box' face attribute
	in the face definitions of a display vector.  (Bug#15099)
230

231 232 233 234
2013-08-15  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_compute_animated_image): Implement animated
	images (bug#14700).
235 236 237
	(imagemagick_compute_animated_image): Fix some compilation
	warnings.  Implement a very simple cache to make the animation
	usable at all, but it should be replaced with a per-image cache.
238

239 240 241 242 243 244 245 246 247
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* lisp.h (FOR_EACH_ALIST_VALUE): New macro
	to do `for' loops over alist values.
	* buffer.h (FOR_EACH_BUFFER):
	* process.c (FOR_EACH_PROCESS): Use it.
	(handle_child_signal, status_notify, Fget_buffer_process)
	(kill_buffer_processes): Use FOR_EACH_PROCESS.

248 249 250 251 252 253 254 255 256
2013-08-15  Dmitry Antipov  <dmantipov@yandex.ru>

	* term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
	(tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
	* image.c (make_image_cache): For struct image_cache, prefer xmalloc
	to xzalloc and so avoid redundant call to memset.
	* xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
	members because it is allocated with xzalloc and so already zeroed.

257 258 259 260 261
2013-08-14  Ken Brown  <kbrown@cornell.edu>

	* gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
	(Bug#15094).

262 263 264 265 266 267 268 269 270 271 272 273 274 275
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Utility function and macro to copy Lisp string to C string.
	* lisp.h (xlispstrdupa): New macro.
	(xlispstrdup): New prototype.
	* alloc.c (xlispstrdup): New function.
	* callint.c (Fcall_interactively):
	* fileio.c (Ffile_name_directory, Fexpand_file_name)
	(Fsubstitute_in_file_name):
	* frame.c (Fmake_terminal_frame): Use xlispstrdupa.
	* image.c (x_create_bitmap_from_file):
	* w32term.c (w32_term_init):
	* xterm.c (x_term_init): Use xlispstrdup.

276 277
2013-08-14  Lars Magne Ingebrigtsen  <larsi@gnus.org>

278 279 280 281
	* image.c (imagemagick_load_image): Make animated pictures work.
	There's still some problems with background color settings, though
	(bug#14700).

282 283
	* decompress.c (unwind_decompress): Always restore point.

284 285 286 287
2013-08-14  Xue Fuqiao  <xfq.free@gmail.com>

	* marker.c (set_marker): Reformat documentation.

288 289
2013-08-14  Paul Eggert  <eggert@cs.ucla.edu>

290 291
	* xdisp.c (cursor_type_changed): Now static.

292 293 294 295
	* image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
	Use changed.  This avoids the need to call xmalloc and for the
	caller to call xfree, and avoids memory leaks in some situations.

296 297 298 299
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* xdisp.c (adjust_window_ends): Move duplicated code to new function.
	(try_window, try_window_reusing_current_matrix, try_window_id): Use it.
300 301 302
	(redisplay_window): If window_end_valid is cleared due to non-zero
	windows_or_buffers_changed, clear current_matrix_up_to_date_p and
	so do not call to try_cursor_movement for that window.
303

304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert window_end_pos and
	window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
	(wset_window_end_pos, wset_window_end_vpos): Remove.
	* dispnew.c (adjust_glyph_matrix):
	* window.c (Fwindow_end, replace_window, set_window_buffer)
	(make_window):
	* xdisp.c (check_window_end, move_it_to, redisplay_internal)
	(set_vertical_scroll_bar, redisplay_window, try_window)
	(try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
	(try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
	(note_mouse_highlight): Adjust users.
	(try_cursor_movement): Likewise.  Convert old precondition to eassert.
	Add comment.

320 321 322 323 324 325
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
	* image.c (imagemagick_filename_hint): Use `const char *' and
	prefer SSDATA to SDATA to avoid warnings.

326 327 328 329 330 331 332 333
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	Cleanup window fringes, margins and scroll bars adjustments.
	* window.c (set_window_fringes, set_window_margins)
	(set_window_scroll_bars, apply_window_adjustment): New functions.
	(set_window_buffer, Fset_window_margins, Fset_window_fringes)
	(Fset_window_scroll_bars): Use them.

334 335 336 337 338 339 340 341 342 343 344 345 346 347
2013-08-14  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert scroll_bar_width
	from Lisp_Object to integer.  Adjust comment.
	(WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
	Adjust users.
	* window.c (wset_scroll_bar_width): Remove.
	(make_window): Initialize scroll_bar_width.
	(Fsplit_window_internal): Use direct assignment.
	(Fset_window_configuration, save_window_save):
	Convert Lisp_Object to integer and back where appropriate.
	(Fset_window_scroll_bars): Adjust user.  Return t if any scroll
	bar was actually changed, and mention this in docstring.

348 349 350 351 352 353 354 355
2013-08-13  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c: Minor simplifications.
	(Fzlib_decompress_region): Don't bother verifying
	that avail_out <= UINT_MAX, as that was confusing.
	Mention the restriction in a comment instead.
	Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.

Jan Djärv's avatar
Jan Djärv committed
356 357 358 359 360
2013-08-13  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
	(trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.

361 362 363 364 365
2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_filename_hint): Check for errors in the
	alist structure.

366 367 368 369 370 371 372 373 374 375 376 377
2013-08-13  Eli Zaretskii  <eliz@gnu.org>

	* window.c (Fwindow_margins): Return nil when there's no marginal
	area, as per the documented API.

	* w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
	Fmake_vector, as scroll bar's struct members are not all Lisp
	objects now.  This avoids crashes in GC.

	* w32term.h (struct scroll_bar): Convert fringe_extended_p to a
	bool, so its address could be taken.

378 379 380 381 382 383
2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_filename_hint): New function to possibly
	apply `image-content-type-suffixes'.
	(imagemagick_load_image): Use it.

384 385 386 387 388
2013-08-13  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
	if loading zlib failed.

389 390
2013-08-13  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
391 392 393 394
	* nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
	2013-08-13 checkin below.  Change bool to BOOL, rule is:
	All Obj-C code uses BOOL, except for interfaces callable from C.

395 396
	* nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).

397 398 399 400 401 402 403 404 405 406 407 408 409 410
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
	* nsterm.m (ns_set_vertical_scroll_bar): Use it.  Use convenient
	bool instead of BOOL.
	* w32term.h (struct scroll_bar): Convert fringe_extended_p
	from Lisp_Object to bitfield.  Adjust comment.
	* w32term.c (x_scroll_bar_create): Adjust user.
	Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
	* xterm.c (XTset_vertical_scroll_bar): Likewise.
	Use bool for boolean.
	* xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
	to `unsigned int' when defining a bitfield.

411 412 413 414
2013-08-13  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.

415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_margin_cols and
	right_margin_cols from Lisp_Objects to integers.  Adjust comment.
	(WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
	(WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
	Adjust users.
	* dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
	Adjust comment.
	(showing_window_margins_p, update_window_line, update_frame_1):
	* fringe.c (draw_fringe_bitmap_1):
	* xdisp.c (window_box_width): Adjust users.
	* window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
	(adjust_window_margins, set_window_buffer, Fsplit_window_internal):
	Use direct assignment.
	(Fset_window_configuration, save_window_save, Fwindow_margins):
	Convert Lisp_Object to integer and back where appropriate.
	(Fset_window_margins): Adjust user.  Return t if any margin
	was actually changed, and mention this in docstring.

435 436
2013-08-13  Xue Fuqiao  <xfq.free@gmail.com>

437
	* syntax.c (forward_word):
438 439
	* cmds.c (forward_char, backward_char): Mention the optional argument.

440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.h (struct window): Convert left_fringe_width
	and right_fringe_width from Lisp_Objects to integers.
	Adjust comment.
	(WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
	(WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
	* window.c (wset_left_fringe_width, wset_right_fringe_width):
	Remove.
	(make_window): Initialize new integer fields to -1.
	(Fsplit_window_internal): Use direct assignment.
	(Fset_window_configuration, save_window_save): Convert
	Lisp_Object to integer and back where appropriate.
	(Fset_window_fringes): Adjust user.  Return t if any fringe
	was actually changed, and mention this in docstring.

456 457 458
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
459 460 461 462
	* nsfns.m (x_set_cursor_type):
	* w32fns.c (x_set_cursor_type):
	* xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
	* xdisp.c (set_frame_cursor_types): ...but in common code.
463

464 465 466 467 468 469 470 471
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* font.c (clear_font_cache): New function, stripped from...
	(Fclear_font_cache): ...here, which now uses the function
	above.  Adjust comment.
	* font.h (clear_font_cache): Add prototype.
	* xfaces.c (clear_face_cache): Use clear_font_cache.

472 473 474 475 476
2013-08-13  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fset_window_start): Compare `w', not `window' because
	`w' might not be equal to `window' after call to decode_live_window.

477 478 479 480 481 482
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c (deactivate_process): Reset fds to -1 (Bug#15035).
	This fixes a problem introduced by the Bug#15035 patch
	when using GPG.  Reported by Herbert J. Skuhra.

483 484 485 486 487 488
2013-08-12  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
	(Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
	not yet initialized.

489 490 491 492 493
2013-08-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* decompress.c (Fzlib_decompress_region): Support zlib
	decompression, too, and rename.

Paul Eggert's avatar
Paul Eggert committed
494 495 496 497 498 499
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	Minor zlib configuration tweaks.
	* decompress.c (fn_inflateInit2) [!WINDOWSNT]:
	Don't assume presence of fn_inflateInit2_ zlib internal function.

500 501 502 503 504
2013-08-12  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* decompress.c (Fzlib_decompress_gzipped_region): Rename to
	include the zlib prefix.

505 506 507 508 509 510 511 512 513 514 515 516 517 518
2013-08-12  Eli Zaretskii  <eliz@gnu.org>

	* decompress.c [WINDOWSNT]: Include windows.h and w32.h.
	(DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros.  Use them to
	define static variables that are pointers to zlib functions to be
	dynamically loaded.
	(init_zlib_functions) [WINDOWSNT]: New function.
	(fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
	New macros.
	(Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
	macros instead of invoking the zlib functions directly.
	(syms_of_decompress): DEFSYM Qzlib_dll.  Staticpro
	Szlib_available_p.

519 520 521 522 523 524 525 526 527 528 529 530 531 532
2013-08-12  Dmitry Antipov  <dmantipov@yandex.ru>

	Avoid looping over all frame windows to freeze and unfreeze.
	* window.h (struct window): Drop frozen_window_start_p.
	(freeze_window_starts): Drop prototype.
	* frame.h (struct frame): New frozen_window_starts flag.
	(FRAME_WINDOWS_FROZEN): New macro.
	* window.c (freeze_window_start, freeze_window_starts):
	Remove.
	(select_window, replace_window): Adjust users.
	* xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
	(window_frozen_p): New function.
	(redisplay_window): Use it.

533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611
2013-08-12  Paul Eggert  <eggert@cs.ucla.edu>

	Fix some fd issues when running subprocesses (Bug#15035).
	Fix bugs that can leak files or file descriptors on errors.
	Don't unlink open temp files, as that's hard for users to diagnose
	when things go awry (e.g., temp disk exhausted).
	Don't bother to lock temp files.  Check for invalid recursion.
	* callproc.c (synch_process_fd): Remove.  All uses removed.
	(synch_process_tempfile): New var or macro.
	(CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
	New constants.
	(record_kill_process): New arg, the temp name.  All callers changed.
	(delete_temp_file): Now just a simple wrapper around unlink.
	(call_process_kill): New arg, the call_process_fd array.
	Close them all.  Clear synch_process_pid.  Remove the temp file,
	or arrange for it to be removed.
	(call_process_cleanup) [MSDOS]: Arg no longer contains file name;
	that's been moved to synch_process_tempfile.  Caller changed.
	Do not remove the tempfile; that's now call_process_kill's
	responsibility.
	(call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
	call_process_kill; the caller now does that.
	(call_process_cleanup): Do not close the process fd; that's now
	call_process_kill's responsibility.
	(Fcall_process): Implement via new function call_process, which
	has most of the old body of Fcall_process, but with a different API.
	(call_process): New function that does not open or close filefd if
	it is nonnegative.  Record which fds need to be closed, and let
	call_process_kill close (and remove the tempfile, on MSDOS) on error.
	Signal an error if invoked recursively (could be done via a hook).
	Simplify creation of the tempfile in the MSDOS case.
	Don't create the output file until after checking for the executable.
	Report any failure to open /dev/null.
	Don't open /dev/null for writing twice; once is enough.
	Don't create pipe if all output is being discarded or sent to file.
	Don't worry about setting up the coding system or reading from the
	pipe if all output is being discarded.
	Hoist fd_error local into top level, to lessen block nesting.
	Don't record deleted pid here; now done by Fcall_process_region.
	(Fcall_process) [MSDOS]: Report mktemp failure immediately,
	and note its success in synch_process_tempfile.
	Do not leak resources when child_setup fails.
	(Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
	to child_errno.  Remove unnecessary close of fd0; it's close-on-exec.
	(create_temp_file): Now returns open fd, with an additional
	Lisp_Object * argument to return the name.  All callers changed.
	Do not close the file; rewind it instead, and leave it open for
	the caller.  Do not lock the temp file.  Unwind-protect the file
	and the file-descriptor.
	(Fcall_process_region): If the input is /dev/null, unwind-protect it.
	If an asynchrounous process, record it here, not in call_process.
	(syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
	* eval.c (set_unwind_protect): New function.
	* fileio.c (write_region): New function, generalized from the
	old Fwrite_region.  Do not lock temp files.
	(Fwrite_region): Use it.
	* lisp.h (set_unwind_protect, write_region): New decls.
	* process.c: Include <verify.h>.
	(make_process): Mark fds as initially closed.
	(deleted_pid_list): Now a list of pid-filename pairs.
	All uses changed.
	(close_process_fd): New function.
	(SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
	(SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
	New constants.  Verify that their number matches PROCESS_OPEN_FDS.
	(create_process, create_pty, Fmake_serial_process)
	(server_accept_connection): Record which fds need to be closed,
	and let deactivate_process close them.
	(Fmake_network_process): Do not discard the unwind-protect
	until it's safe to do so.
	(deactivate_process): Close the fds opened by create_process etc.
	(Fprocess_send_eof): Adjust to new way of recording open fds.
	Report an error if /dev/null can't be opened, instead of aborting.
	* process.h (PROCESS_OPEN_FDS): New constant.
	(struct Lisp_Process): New member open_fds.
	(record_kill_process, record_deleted_pid): Adjust signatures.
	(record_deleted_pid): Move decl here ...
	* syswait.h (record_deleted_pid): ... from here.

612 613 614 615 616 617 618 619 620 621 622
2013-08-11  Paul Eggert  <eggert@cs.ucla.edu>

	* decompress.c: Fix bugs with large buffers and weird inputs.
	Tune a bit.  Reindent as per usual Emacs style.
	(BUFFER_SIZE): Remove.
	(Fdecompress_gzipped_region): Do not mishandle input buffers with
	more than UINT_MAX bytes.  Decompress into the gap instead of into
	an auto buffer, as this should avoid copying.  Return nil if
	'inflate' returns Z_NEED_DICT, as we have no dictionary.  Do not
	set immediate_quit; we shouldn't trust zlib code that much.

623 624
2013-08-11  Lars Magne Ingebrigtsen  <larsi@gnus.org>

625 626 627
	* decompress.c (Fdecompress_gzipped_region): Respect all zlib
	errors, and really move the gap to where we want it.

628 629 630 631 632 633
	* lisp.h: Include decompress.c support.

	* emacs.c (main): Include decompress.c support.

	* Makefile.in: Include -lz if present.

634 635
2013-08-11  Jan Djärv  <jan.h.d@swipnet.se>

Jan Djärv's avatar
Jan Djärv committed
636 637 638 639 640 641 642 643 644
	* nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
	(initWithTitle:): Initialize frame to 0.
	(fillWithWidgetValue:): Call fillWithWidgetValue:frame.
	(fillWithWidgetValue:frame:): Renamed from
	fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.

	* nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
	fillWithWidgetValue:frame:

Jan Djärv's avatar
Jan Djärv committed
645 646 647
	* nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
	remove memory leak warnings.

648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663
	* nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
	(ns_check_menu_open): Handle menu == nil.  Remove assignment to
	menu_pending_title.

	* nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
	(x_activate_menubar): Update the whole menu.
	(trackingNotification:): Call ns_check_menu_open if tracking ends.
	(menuWillOpen:): Increment trackingMenu.  For OSX <= 10.6, exit if
	current event is not NSSystemDefined (Bug#15001).
	Call ns_check_menu_open only if trackingMenu is 2.
	(menuDidClose:): New method, decrease trackingMenu.
	(fillWithWidgetValue:setDelegate:): New method.
	(fillWithWidgetValue:): Call the above.

	* nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:

Paul Eggert's avatar
Paul Eggert committed
664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717
2013-08-11  Paul Eggert  <eggert@cs.ucla.edu>

	Omit some unnecessary casts.
	Many of these go back to the old pre-C89 days, when they may have
	been needed, but we've been assuming C89 or later for a while now.
	* alloc.c (live_string_p, live_cons_p, live_symbol_p)
	(live_float_p, live_misc_p, live_vector_p):
	* buffer.c (compare_overlays, cmp_for_strings, mmap_find)
	(mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
	(defvar_per_buffer):
	* callint.c (Fcall_interactively):
	* doc.c (Fsubstitute_command_keys):
	* filelock.c (get_boot_time):
	* frame.c (xrdb_get_resource):
	* gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
	(delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
	(xg_get_file_name_from_selector, menuitem_destroy_callback)
	(menuitem_highlight_callback, menu_destroy_callback)
	(xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
	(xg_tool_bar_callback, xg_get_tool_bar_widgets)
	(xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
	(xg_tool_bar_help_callback, tb_size_cb):
	* image.c (xpm_alloc_color, png_read_from_memory)
	(png_read_from_file, png_load_body, our_memory_skip_input_data)
	(jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
	(syms_of_image):
	* keymap.c (describe_map):
	* nsfns.m (Fns_display_monitor_attributes_list):
	* nsmenu.m (process_dialog:):
	* nsterm.m (hold_event):
	* process.c (wait_reading_process_output):
	* regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
	* scroll.c (do_direct_scrolling, scrolling_1):
	* termcap.c (tgetent):
	* window.c (check_window_containing, add_window_to_list)
	(freeze_window_starts):
	* xdisp.c (compare_overlay_entries, vmessage):
	* xfns.c (x_window, x_get_monitor_attributes_xinerama)
	(x_get_monitor_attributes_xrandr)
	(Fx_display_monitor_attributes_list, x_display_info_for_name)
	(Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
	* xfont.c (xfont_match, xfont_open):
	* xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
	(menubar_selection_callback, menu_position_func)
	(popup_selection_callback, create_and_show_popup_menu)
	(dialog_selection_callback, create_and_show_dialog):
	* xrdb.c (x_get_string_resource):
	(main) [TESTRM]:
	* xsmfns.c (x_session_check_input):
	* xterm.c (x_draw_glyphless_glyph_string_foreground)
	(xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
	(xaw_jump_callback, xaw_scroll_callback):
	Omit unnecessary casts.

Paul Eggert's avatar
Paul Eggert committed
718 719 720 721 722 723 724
2013-08-10  Paul Eggert  <eggert@cs.ucla.edu>

	Minor string-length refactoring.
	* alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
	* frame.c (make_monitor_attribute_list):
	Prefer build_string to strlen + make_string.

725 726 727 728 729
2013-08-10  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
	don't check minor_code (Bug#14417).

730 731 732 733 734 735
2013-08-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (draw_glyphs): Don't compare row pointers, compare row
	vertical positions instead.  This avoids calling MATRIX_ROW with
	row numbers that are possibly beyond valid limits.  (Bug#15064)

736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751
2013-08-09  Dmitry Antipov  <dmantipov@yandex.ru>

	Use xstrdup and build_unibyte_string where applicable.
	* alloc.c (xstrdup): Tiny cleanup.  Add eassert.
	* xfns.c (x_window):
	* xrdb.c (x_get_customization_string):
	* xterm.c (xim_initialize):
	* w32fns.c (w32_window): Use xstrdup.
	(w32_display_monitor_attributes_list):
	* emacs.c (init_cmdargs):
	* keyboard.c (PUSH_C_STR):
	* nsfont.m (nsfont_open):
	* sysdep.c (system_process_attributes):
	* w32.c (system_process_attributes):
	* xdisp.c (message1, message1_nolog): Use build_unibyte_string.

752 753 754 755 756 757 758 759
2013-08-09  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
	variables of these types so that GDB would know about them, as aid
	for debugging fatal exceptions.  (Bug#15024)  See also
	http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
	discussions.

760 761 762 763 764
2013-08-08  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_begin): Don't change clip path if it would be
	larger than the NSWindow (Bug#14934).

765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
2013-08-08  Dmitry Antipov  <dmantipov@yandex.ru>

	Redesign redisplay interface to drop global variable updated_window.
	Always pass currently updated window as a parameter to update routines.
	* dispextern.h (updated_window): Remove declaration.
	(struct redisplay_interface): Pass window parameter to
	write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
	and after_update_window_hook.
	(x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
	Adjust prototypes.
	* dispnew.c (updated_window): Remove.
	(redraw_overlapped_rows, update_marginal_area, update_text_area)
	(update_window_line): Adjust to match redisplay interface changes.
	* nsterm.m (ns_update_window_begin, ns_update_window_end)
	(ns_scroll_run, ns_after_update_window_line):
	* w32term.c (x_update_window_begin, x_update_window_end)
	(x_after_update_window_line, x_scroll_run):
	* xterm.c (x_update_window_begin, x_update_window_end)
	(x_after_update_window_line, x_scroll_run):
	* xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
	Likewise.  Adjust comments where appropriate.
	(x_cursor_to): Simplify because this is always called during window
	update (but install debugging check anyway).
	(expose_window): Check must_be_updated_p flag to see whether this
	function is called during window update.

791 792 793 794 795 796 797 798 799 800 801 802 803
2013-08-08  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not reset window modification event counters excessively.
	These leftovers and poor man's tricky methods to catch extra
	redisplay's attention are no longer needed.
	* frame.c (set_menu_bar_lines_1):
	* minibuf.c (read_minibuf_unwind):
	* window.c (Fset_window_start, set_window_buffer, window_resize_apply)
	(grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
	(window_scroll_line_based, Fset_window_configuration):
	* xdisp.c (redisplay_window): Do not reset last_modified and
	last_overlay_modified counters.

804 805 806 807 808 809
2013-08-07  Jan Djärv  <jan.h.d@swipnet.se>

	* xselect.c (x_send_client_event): Set send_event and serial, memset
	data.l as it might be bigger than data.b.   Use 24 bit mask to
	XSendEvent (Bug#15034).

810 811 812 813 814 815
2013-08-07  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
	for TTY frames that are not the top frame on their console.
	(Bug#14616)

816 817 818 819 820
2013-08-07  Martin Rudalics  <rudalics@gmx.at>

	* w32term.c (w32fullscreen_hook): Really maximize frame when
	asked for (Bug#14841).

821 822 823 824 825 826 827 828 829
2013-08-07  Dmitry Antipov  <dmantipov@yandex.ru>

	Prefer selected_window to Fselected_window, likewise for frames.
	* buffer.c (Fbuffer_swap_text):
	* data.c (Fvariable_binding_locus):
	* window.c (run_window_configuration_change_hook): Adjust users.
	* w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
	Use decode_live_frame.

830 831 832 833 834 835 836 837 838 839 840 841
2013-08-07  Dmitry Antipov  <dmantipov@yandex.ru>

	Be more careful if selected window shows the buffer other than current,
	use window_outdated only if this is not so.  This change should also
	address some weird issues discussed in Bug#13012.
	* window.h (window_outdated): New prototype.
	* window.c (window_outdated): Now here.  Convert from static and
	always assume window's buffer.
	(Fwindow_end, Fwindow_line_height): Use it.
	* xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
	and always assume window's buffer.
	(redisplay_window): Adjust user.
Dmitry Antipov's avatar
Dmitry Antipov committed
842
	(redisplay_internal): Call to reconsider_clip_changes once and
843 844 845 846 847
	check whether mode line should be updated only if selected window
	shows current buffer.
	(run_window_scroll_functions): Use eassert for debugging check.
	(Fmove_point_visually, note_mouse_highlight): Use window_outdated.

848 849 850 851 852
2013-08-06  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (window_scroll, window_scroll_pixel_based)
	(window_scroll_line_based): Use bool for booleans.

853 854 855 856 857 858 859 860 861 862 863 864
2013-08-06  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c: Fix minor off-by-one issues in descriptor counts.
	This shouldn't fix any real bugs, but it cleans up the code a bit.
	(max_process_desc, max_input_desc): -1, not 0, means none.
	All uses changed.
	(delete_input_desc): New function.
	(delete_write_fd, delete_keyboard_wait_descriptor): Use it.
	(deactivate_process): Scan backwards when recomuting max_process_desc;
	that should be faster.
	(init_process_emacs): Initialize max_input_desc.

865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
2013-08-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Use region cache to speedup bidi_find_paragraph_start.
	* buffer.h (struct buffer): New member bidi_paragraph_cache.
	Rename cache_long_line_scans to cache_long_scans.
	* buffer.c (bset_cache_long_line_scans): Rename to
	bset_cache_long_scans.
	(Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
	(Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
	into account.
	(syms_of_buffer): Rename cache-long-line-scans to
	cache-long-scans.  Adjust docstring.
	* search.c (newline_cache_on_off):
	* indent.c (width_run_cache_on_off): Adjust users.
	* bidi.c (bidi_paragraph_cache_on_off): New function.
	(bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
	* insdel.c (prepare_to_modify_buffer): Invalidate
	bidi_paragraph_cache if enabled.

884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901
2013-08-06  Dmitry Antipov  <dmantipov@yandex.ru>

	Invalidate region caches only if buffer text is going to be changed.
	* lisp.h (modify_region_1): Remove 3rd arg and rename to...
	(modify_text): ...new prototype.
	(prepare_to_modify_buffer_1): New prototype.
	* textprop.c (modify_region): Rename to...
	(modify_text_properties): ...new function.
	(add_text_properties_1, set_text_properties, Fremove_text_properties)
	(Fremove_list_of_text_properties): Adjust users.
	* insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
	(modify_text): ...new function.
	(prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
	(prepare_to_modify_buffer_1): ...new function.
	* casefiddle.c (casify_region):
	* editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
	(Ftranspose_regions): Use modify_text.

902 903 904 905
2013-08-05  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.mk (lisp): Add nadvice.elc.

906 907 908 909 910 911 912 913 914 915 916 917 918 919 920
2013-08-05  Dmitry Antipov  <dmantipov@yandex.ru>

	New macro to iterate over live buffers similar to frames.
	* buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
	(Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
	Declare buffer-related variables here to offload lisp.h.
	* buffer.c (Vbuffer_alist): Adjust comment.
	(Fget_file_buffer, get_truename_buffer, Fother_buffer)
	(other_buffer_safely):
	* data.c (store_symval_forwarding):
	* dispnew.c (Fframe_or_buffer_changed_p):
	* fileio.c (Fdo_auto_save):
	* filelock.c (unlock_all_files):
	* minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.

921 922 923 924 925 926 927
2013-08-04  Paul Eggert  <eggert@cs.ucla.edu>

	Fix some minor races in hosts lacking mkostemp (Bug#15015).
	* callproc.c (create_temp_file):
	* filelock.c (create_lock_file):
	Assume mkostemp, since it's now provided by Gnulib.

928 929 930 931 932
2013-08-04  Eli Zaretskii  <eliz@gnu.org>

	* w32.c (mkostemp): New function.
	(mktemp): Remove, no longer used.  Most of the code reused in
	mkostemp.  (Bug#15015)
Eli Zaretskii's avatar
Eli Zaretskii committed
933
	(mktemp): Don't undef.
934

935 936 937 938 939 940 941 942
2013-08-04  Dmitry Antipov  <dmantipov@yandex.ru>

	* dispnew.c (glyph_matrix_count, glyph_pool_count):
	Move under GLYPH_DEBUG and ENABLE_CHECKING.
	(new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
	(free_glyph_pool, check_glyph_memory): Likewise for
	all users.  Adjust comments where appropriate.

Paul Eggert's avatar
Paul Eggert committed
943 944 945 946 947 948 949 950 951
2013-08-03  Paul Eggert  <eggert@cs.ucla.edu>

	* composite.h: Minor fixups.
	(composition_registered_p): Rename from COMPOSITION_REGISTERD_P
	to fix a misspelling, and change it to an inline function while
	we're at it (it need not be a macro).  All uses changed.
	(composition_method, composition_valid_p):
	Rewrite to avoid assignments in if-conditions.

952 953 954 955 956 957
2013-08-03  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not use global Lisp_Object in composition macros.
	* composite.h (composition_temp): Remove declaration.
	(COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
	(composition_method, composition_valid_p): ...inline functions.
958
	(compose_region): Remove the leftover.
959 960 961 962 963 964 965 966
	* composite.c (composition_temp): Remove.
	(run_composition_function, update_compositions)
	(composition_compute_stop_pos, composition_adjust_point)
	(Ffind_composition_internal):
	* coding.c (handle_composition_annotation):
	* xdisp.c (handle_composition_prop, check_point_in_composition):
	Related users changed.

Dmitry Antipov's avatar
Dmitry Antipov committed
967 968 969 970 971 972 973 974 975 976 977 978
2013-08-03  Dmitry Antipov  <dmantipov@yandex.ru>

	Drop FRAME_PTR typedef.
	* composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
	* ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
	* menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
	* nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
	* w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
	* w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
	* xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
	All related users changed.

979 980 981 982 983 984 985 986 987 988
2013-08-02  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (default_toplevel_binding): New function.
	(Fdefvar): Use it.
	(unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
	(Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
	(syms_of_eval): Export them.
	* data.c (Fdefault_value): Micro cleanup.
	* term.c (init_tty): Use "false".

989 990 991 992 993 994 995 996 997 998
2013-08-02  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix X GC leak in GTK and raw (no toolkit) X ports.
	* xterm.c (x_free_frame_resources): If white and black relief
	GCs are allocated, always free them here.
	* xfns.c (x_make_gc): Omit redundant initialization.
	* widget.c (create_frame_gcs): Remove the leftover.
	(EmacsFrameDestroy): Do nothing because all GCs are now freed
	in x_free_frame_resources.

999 1000 1001 1002 1003 1004 1005 1006 1007 1008
2013-08-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (windowWillResize:toSize:): Only change title if
	! maximizing_resize && FULLSCREEN_NONE (Bug#15005).  strdup title before
	modifying it.
	(viewDidEndLiveResize): New method.

	* nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
	inside NS_IMPL_COCOA.

1009 1010 1011 1012 1013 1014
2013-08-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* insdel.c (adjust_after_replace, replace_range, del_range_2):
	Do not check whether undo is enabled because record_insert and
	record_delete does that themselves.

1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
2013-08-02  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
	member which is not really used any more.
	(FRAME_XIC_BASE_FONTNAME): Remove.
	* xfns.c (xic_free_fontset): Adjust user.
	* xmenu.c (mouse_position_for_popup, x_activate_menubar)
	(update_frame_menubar, set_frame_menubar, free_frame_menubar)
	(create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
	(xdialog_show): Use eassert for debugging check.
1025
	* w32term.c (x_unfocus_frame): Remove unused dummy function.
1026

1027 1028 1029 1030 1031
2013-08-01  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c, fns.c (merge): Move extern decl from here ...
	* lisp.h (merge): ... to here.

Dmitry Antipov's avatar
Dmitry Antipov committed
1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2013-08-01  Dmitry Antipov  <dmantipov@yandex.ru>

	Fix last font-related change.
	* w32font.h (w32font_list_internal, w32font_match_internal):
	Fix prototype.
	* w32uniscribe.c (uniscribe_list, uniscribe_match):
	(uniscribe_list_family): Adjust to match font API change.
	MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
	at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.

1042 1043 1044 1045 1046 1047
2013-08-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.h (FRAME_MOUSE_UPDATE):
	* nsterm.m (ns_frame_up_to_date): Omit redundant check
	whether hlinfo->mouse_face_mouse_frame is non-NULL.

1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066
2013-08-01  Dmitry Antipov  <dmantipov@yandex.ru>

	Avoid redundant Lisp_Object <-> struct frame conversions in font API.
	* font.h (struct font_driver): Change list, match, and list_family
	functions to accept struct frame * as first arg.
	* font.c (font_score, font_compare, font_sort_entities): Remove
	prototypes.
	(font_sort_entities, font_list_entities, font_select_entity):
	(font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
	match font API change.
	* xfont.c (xfont_list, xfont_match, xfont_list_family):
	* ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
	* ftxfont.c (ftxfont_list, ftxfont_match):
	* xftfont.c (xftfont_list, xftfont_match):
	* nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
	* w32font.c (w32font_list, w32font_match, w32font_list):
	(w32font_list_internal, w32_font_match_internal): Likewise.
	* xfaces.c (Fx_family_fonts): Adjust user.

1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
2013-08-01  Dmitry Antipov  <dmantipov@yandex.ru>

	Do not use pure Xism x_wm_set_icon_position in non-X ports.
	* frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
	only if HAVE_X_WINDOWS is in use.
	* frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
	* nsterm.m (x_wm_set_icon_position): Remove no-op.
	* w32term.c (x_wm_set_icon_position): Likewise.
	* w32fns.c (x_icon): Adjust user.

1077 1078 1079 1080 1081
2013-08-01  Dmitry Antipov  <dmantipov@yandex.ru>

	* xterm.c (last_mouse_press_frame): Remove the
	leftover which is not really used any more.
	(handle_one_xevent, syms_of_xterm): Adjust users.
1082 1083 1084 1085
	(x_flush): Call XFlush once per each X display, not frame.
	This is better because this code always unconditionally skips
	non-X frames in Vframe_list and issues the only	XFlush if we
	have more than one X frame on the same X display.
1086 1087 1088 1089 1090
	(any_help_event_p, x_draw_glyph_string_background, x_display_ok):
	Use bool for booleans.
	(x_draw_glyph_string_background, cvt_string_to_pixel):
	(cvt_pixel_dtor): Drop unnecessary prototypes.
	* xterm.h (x_display_ok): Adjust prototype.
1091

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104
2013-07-31  Dmitry Antipov  <dmantipov@yandex.ru>

	Drop unnecessary functions that deals with frame pixel size.
	* frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
	(x_pixel_height): Drop prototypes.
	* msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
	(x_pixel_height): Drop implementations.
	* frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
	which should be always valid for window frame.
	(Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
	* w32menu.c (Fx_popup_dialog):
	* xmenu.c (Fx_popup_dialog): Likewise for both.

1105 1106 1107 1108
2013-07-31  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (Fmake_terminal_frame): Use store_in_alist to setup
	frame parameters and call to Fmodify_frame_parameters just once.
1109 1110 1111
	(Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
	(Fset_frame_size, Fset_frame_position): Use decode_live_frame
	and mention nil frame in docstring.
1112

1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
2013-07-31  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
	(x_figure_window_size): Likewise.  Adjust to return long.
	(syms_of_frame): Do not DEFSYM Qterminal_live_p.
	(toplevel): Move Qterminal_live_p to...
	* terminal.c (toplevel): ...here, make it static, and...
	(syms_of_terminal): ...DEFSYM here.
	* frame.h (Qterminal_live_p): Remove declaration.
	(make_frame, x_figure_window_size): Adjust prototype.
	* nsfns.m (Fx_create_frame): Use long for window flags.

1125 1126 1127 1128 1129 1130
2013-07-30  Paul Eggert  <eggert@cs.ucla.edu>

	Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
	* callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
	Do not assume that emacs_close (INT_MAX) is a no-op.

1131 1132 1133 1134 1135 1136
2013-07-30  Dmitry Antipov  <dmantipov@yandex.ru>

	* xfaces.c (make_face_cache): For struct face_cache, prefer
	xmalloc to xzalloc and so avoid redundant call to memset.
	(Finternal_set_lisp_face_attribute): Fix comment typo and style.

1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
2013-07-30  Dmitry Antipov  <dmantipov@yandex.ru>

	* fringe.c (draw_window_fringes, update_window_fringes)
	(compute_fringe_widths):
	* w32term.c (x_draw_glyph_string):
	* window.c (candidate_window_p, Frecenter):
	* xfaces.c (realize_basic_faces, realize_default_face)
	(Fbitmap_space_p, Finternal_set_lisp_face_attribute)
	(x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
	* xfns.c (x_set_cursor_color, xic_free_xfontset):
	* xmenu.c (Fx_menu_bar_open_internal):
	* xselect.c (x_reply_selection_request, Fx_get_atom_name):
	* xsettings.c (xft_settings_event):
	* xterm.c (x_draw_glyph_string, x_had_errors_p):
	Use bool for booleans.  Adjust style and comments where
	appropriate.
	* dispextern.h (draw_window_fringes, update_window_fringes)
	(compute_fringe_widths):
	* xterm.h (x_had_errors_p): Adjust prototype.

1157 1158 1159 1160 1161
2013-07-30  Dmitry Antipov  <dmantipov@yandex.ru>

	* frame.c (Fmodify_frame_parameters): Always check 2nd arg with
	CHECK_LIST.  Rewrite the loop to avoid useless local variable.

1162 1163 1164 1165 1166
2013-07-29  Dmitry Antipov  <dmantipov@yandex.ru>

	* fns.c (toplevel): Remove comment before Fsafe_length because
	it checks for QUIT.

1167 1168 1169 1170
2013-07-28  Paul Eggert  <eggert@cs.ucla.edu>

	* frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).

1171 1172 1173 1174 1175 1176 1177 1178 1179
2013-07-28  Eli Zaretskii  <eliz@gnu.org>

	* w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
	frame which got the message is still alive, before dereferencing
	its pointer.  (Bug#14970)

	* frame.c (delete_frame): Test "this" frame's minibuffer window to
	be a live window, before using it as such.  (Bug#14970)

1180 1181 1182 1183 1184 1185 1186
2013-07-27  Eli Zaretskii  <eliz@gnu.org>

	* w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
	w32_detect_focus_change instead of doing part of its job by hand.
	This fixes the problem whereby FOCUS_OUT events were not sent to
	the event queue.

1187 1188
2013-07-26  Eli Zaretskii  <eliz@gnu.org>

1189 1190
	* process.c (Fprocess_list): Doc fix.

1191 1192 1193 1194 1195 1196
	* w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
	being re-exposed only if it didn't ask to become visible.
	<WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
	was previously iconified.  (Bug#14841)
	(x_iconify_frame): Mark the frame iconified.

1197 1198 1199 1200 1201 1202
2013-07-26  Paul Eggert  <eggert@cs.ucla.edu>

	Fix minor problems found by static checking.
	* eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
	(backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.

1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
2013-07-26  Stefan Monnier  <monnier@iro.umontreal.ca>

	* eval.c (set_specpdl_old_value): New function.
	(unbind_to): Minor simplification.
	(get_backtrace_frame): New function.
	(Fbacktrace_frame): Use it.  Add `base' argument.
	(backtrace_eval_unrewind, Fbacktrace_eval): New functions.
	(syms_of_eval): Export backtrace-eval.
	* xterm.c (x_focus_changed): Simplify.

1213 1214 1215 1216
2013-07-25  Paul Eggert  <eggert@cs.ucla.edu>

	* fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).

1217 1218 1219 1220 1221 1222
2013-07-24  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Instead of moving point out of
	scroll margin, reject the force_start method, and try scrolling
	instead.  (Bug#14780)

1223 1224 1225 1226 1227
2013-07-24  Ken Brown  <kbrown@cornell.edu>

	* alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
	(Bug#14944).

1228 1229 1230 1231 1232 1233 1234
2013-07-24  Paul Eggert  <eggert@cs.ucla.edu>

	* eval.c (Fprogn): Do not check that BODY is a proper list.
	This undoes the previous change.  The check slows down the
	interpreter, and is not needed to prevent a crash.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.

1235 1236 1237 1238
2013-07-23  Glenn Morris  <rgm@gnu.org>

	* Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.

1239 1240
2013-07-23  Paul Eggert  <eggert@cs.ucla.edu>

1241 1242 1243 1244 1245 1246
	Port to GNU/Linux systems with tinfo but not ncurses.
	* dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
	to decide whether ncurses is being used.  Without this change,
	GCC complains about tgetent not being declared, on a system
	that has tinfo installed but ncurses not installed.

1247 1248
	* eval.c (Fprogn): Check that BODY is a proper list.

1249 1250 1251 1252 1253 1254 1255 1256
	Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
	* data.c (Fsetq_default):
	* eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
	(Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
	(Fcondition_case):
	Tune by taking advantage of the fact that ARGS is always a list
	when a function is declared to have UNEVALLED args.

1257 1258 1259
	* emacsgtkfixed.c: Port to GCC 4.6.
	GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.

1260 1261 1262 1263 1264
2013-07-23  Juanma Barranquero  <lekktu@gmail.com>

	* callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
	here to silence compiler warnings.

1265 1266 1267 1268 1269 1270
2013-07-22  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
	when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
	from messing up Emacs's 'struct frame' (Bug#14923).

1271 1272 1273 1274 1275 1276
2013-07-21  Paul Eggert  <eggert@cs.ucla.edu>

	* alloc.c (make_save_ptr_ptr): Define this function.
	It was inadvertently omitted.  It's needed only if
	HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).

1277 1278 1279 1280 1281
2013-07-21  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
	frame have focus (Bug#14895).

1282 1283 1284 1285 1286 1287 1288 1289 1290 1291
2013-07-21  Paul Eggert  <eggert@cs.ucla.edu>

	Avoid vfork-related deadlock more cleanly.
	* callproc.c (child_setup): When the child's exec fails, output
	the program name, as that's more useful.  Use O_NONBLOCK to avoid
	deadlock.
	* process.c (create_process_1): Remove; no longer needed.
	(create_process): Remove timer hack; no longer needed, now that
	the child avoids deadlock.

1292
2013-07-20  Glenn Morris  <rgm@gnu.org>
1293 1294 1295

	* image.c (Fimage_flush): Fix doc typo.

1296 1297
2013-07-20  Paul Eggert  <eggert@cs.ucla.edu>

1298 1299 1300 1301 1302 1303 1304 1305 1306 1307
	Fix array bounds violation when pty allocation fails.
	* process.c (PTY_NAME_SIZE): New constant.
	(pty_name): Remove static variable; it's now auto.
	(allocate_pty): Define even if !HAVE_PTYS; that's simpler.
	Take pty_name as an arg rather than using a static variable.
	All callers changed.
	(create_process): Recover pty_flag from process, not from volatile local.
	(create_pty): Stay inside array even when pty allocation fails.
	(Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.

1308 1309 1310
	* lread.c (Fload): Avoid initialization only when lint checking.
	Mention that it's needed only for older GCCs.

1311 1312 1313 1314 1315
2013-07-20  Kenichi Handa  <handa@gnu.org>

	* coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
	(decode_coding_iso_2022): Check the single-shift area.  (Bug#8522)

1316 1317 1318 1319
2013-07-20  Andreas Schwab  <schwab@linux-m68k.org>

	* lread.c (Fload): Avoid uninitialized warning.

1320 1321
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
	Fix some minor file descriptor leaks and related glitches.
	* filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
	(create_lock_file): Use write, not emacs_write.
	* image.c (slurp_file, png_load_body):
	* process.c (Fnetwork_interface_list, Fnetwork_interface_info)
	(server_accept_connection):
	Don't leak an fd on memory allocation failure.
	* image.c (slurp_file): Add a cheap heuristic for growing files.
	* xfaces.c (Fx_load_color_file): Block input around the fopen too,
	as that's what the other routines do.  Maybe input need not be
	blocked at all, but it's better to be consistent.
	Avoid undefined behavior when strlen is zero.

1335 1336 1337
	* alloc.c (staticpro): Avoid buffer overrun on repeated calls.
	(NSTATICS): Now a constant; doesn't need to be a macro.

1338 1339 1340 1341 1342
2013-07-19  Richard Stallman  <rms@gnu.org>

	* coding.c (decode_coding_utf_8): Add simple loop for fast
	processing of ASCII characters.

1343 1344 1345 1346
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

	* conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.

Eli Zaretskii's avatar
Eli Zaretskii committed
1347 1348 1349 1350 1351 1352 1353
2013-07-19  Eli Zaretskii  <eliz@gnu.org>

	* keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
	unportable 'struct x_display_info'.
	(DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
	is a portable type.

1354 1355
2013-07-19  Paul Eggert  <eggert@cs.ucla.edu>

1356 1357 1358 1359 1360 1361 1362 1363 1364 1365
	* sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
	(procfs_ttyname): Don't use uninitialized storage if emacs_fopen
	or fscanf fails.
	(system_process_attributes): Prefer plain char to unsigned char
	when either will do.  Clean up properly if interrupted or if
	memory allocations fail.  Don't assume sscanf succeeds.  Remove
	no-longer-needed workaround to stop GCC from whining.  Read
	command-line once, instead of multiple times.  Check read status a
	bit more carefully.

1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380
	Fix obscure porting bug with varargs functions.
	The code assumed that int is treated like ptrdiff_t in a vararg
	function, which is not a portable assumption.  There was a similar
	-- though these days less likely -- porting problem with various
	assumptions that pointers of different types all smell the same as
	far as vararg functions is conserved.  To make this problem less
	likely in the future, redo the API to use varargs functions.
	* alloc.c (make_save_value): Remove this vararg function.
	All uses changed to ...
	(make_save_int_int_int, make_save_obj_obj_obj_obj)
	(make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
	New functions.
	(make_save_ptr): Rename from make_save_pointer, for consistency with
	the above.  Define only on platforms that need it.  All uses changed.

1381 1382 1383 1384 1385
2013-07-18  Paul Eggert  <eggert@cs.ucla.edu>

	* keyboard.c: Try to fix typos in previous change.
	(DISPLAY_LIST_INFO): New macro.
	(kbd_buffer_get_event): Do not access members that are not present
1386
	in X11.  Revert inadvertent change of "!=" to "=".
1387

1388 1389 1390 1391 1392 1393
2013-07-18  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (kbd_buffer_get_event):
	* w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
	Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.

1394 1395
2013-07-18  Paul Eggert  <eggert@cs.ucla.edu>

1396 1397 1398 1399 1400
	* filelock.c: Fix unlikely file descriptor leaks.
	(get_boot_time_1): Rework to avoid using emacs_open.
	This doesn't actually fix a leak, but is better anyway.
	(read_lock_data): Use read, not emacs_read.

1401 1402 1403 1404 1405
	* doc.c: Fix minor memory and file descriptor leaks.
	* doc.c (get_doc_string): Fix memory leak when doc file absent.
	(get_doc_string, Fsnarf_documentation):
	Fix file descriptor leak on error.

1406 1407 1408 1409
	* term.c: Fix minor fdopen-related file descriptor leaks.
	* term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
	(init_tty) [!DOS_NT]: Likewise.  Also close fd if isatty (fd) fails.

1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422
	* charset.c: Fix file descriptor leaks and errno issues.
	Include <errno.h>.
	(load_charset_map_from_file): Don't leak file descriptor on error.
	Use plain record_xmalloc since the allocation is larger than
	MAX_ALLOCA; that's simpler here.  Simplify test for exhaustion
	of entries.
	* eval.c (record_unwind_protect_nothing):
	* fileio.c (fclose_unwind):
	New functions.
	* lread.c (load_unwind): Remove.  All uses replaced by fclose_unwind.
	The replacement doesn't block input, but that no longer seems
	necessary.

1423 1424
2013-07-17  Paul Eggert  <eggert@cs.ucla.edu>

1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437
	* lread.c: Fix file descriptor leaks and errno issues.
	(Fload): Close some races that leaked fds or streams when 'load'
	was interrupted.
	(Fload, openp): Report error number of last nontrivial failure to open.
	ENOENT counts as trivial.
	* eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
	New functions.
	* fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
	now that the function is always called with a nonnegative arg.
	* lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
	All uses replaced with ...
	(clear_unwind_protect, set_unwind_protect_ptr): New decls.

1438 1439 1440 1441 1442 1443 1444 1445
	A few more minor file errno-reporting bugs.
	* callproc.c (Fcall_process):
	* doc.c (Fsnarf_documentation):
	* fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
	* process.c (set_socket_option):
	Don't let a constructor trash errno.
	* doc.c: Include <errno.h>.

1446 1447 1448 1449
2013-07-16  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (unwind_create_tip_frame): Fix declaration.

1450 1451
2013-07-16  Paul Eggert  <eggert@cs.ucla.edu>

1452 1453 1454 1455 1456 1457
	Fix w32 bug with call-process-region (Bug#14885).
	* callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
	to Fcall_process when the input is empty.  This simplifies the
	code a bit.  It makes no difference on POSIXish platforms but
	apparently it fixes a bug on w32.

Juanma Barranquero's avatar
Juanma Barranquero committed
1458
	Fix bug where insert-file-contents closes a file twice (Bug#14839).
1459 1460 1461 1462 1463 1464 1465 1466 1467
	* fileio.c (close_file_unwind): Don't close if FD is negative;
	this can happen when unwinding a zapped file descriptor.
	(Finsert_file_contents): Unwind-protect the fd before the point marker,
	in case Emacs runs out of memory between the two unwind-protects.
	Don't trash errno when closing FD.
	Zap the FD in the specpdl when closing it, instead of deferring
	the removal of the unwind-protect; this fixes a bug where a child
	function unwinds the stack past us.

1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568
	New unwind-protect flavors to better type-check C callbacks.
	This also lessens the need to write wrappers for callbacks,
	and the need for make_save_pointer.
	* alloca.c (free_save_value):
	* atimer.c (run_all_atimers):
	Now extern.
	* alloc.c (safe_alloca_unwind):
	* atimer.c (unwind_stop_other_atimers):
	* keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
	* menu.c (cleanup_popup_menu) [HAVE_NS]:
	* minibuf.c (choose_minibuf_frame_1):
	* process.c (make_serial_process_unwind):
	* xdisp.h (pop_message_unwind):
	* xselect.c (queue_selection_requests_unwind):
	Remove no-longer-needed wrapper.  All uses replaced by the wrappee.
	* alloca.c (record_xmalloc):
	Prefer record_unwind_protect_ptr to record_unwind_protect with
	make_save_pointer.
	* alloca.c (Fgarbage_collect):
	Prefer record_unwind_protect_void to passing a dummy.
	* buffer.c (restore_buffer):
	* window.c (restore_window_configuration):
	* xfns.c, w32fns.c (do_unwind_create_frame)
	New wrapper.  All record-unwind uses of wrappee changed.
	* buffer.c (set_buffer_if_live):
	* callproc.c (call_process_cleanup, delete_temp_file):
	* coding.c (code_conversion_restore):
	* dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
	* editfns.c (save_excursion_restore)
	(subst_char_in_region_unwind, subst_char_in_region_unwind_1)
	(save_restriction_restore):
	* eval.c (restore_stack_limits, un_autoload):
	* fns.c (require_unwind):
	* keyboard.c (recursive_edit_unwind, tracking_off):
	* lread.c (record_load_unwind, load_warn_old_style_backquotes):
	* macros.c (pop_kbd_macro, restore_menu_items):
	* nsfns.m (unwind_create_frame):
	* print.c (print_unwind):
	* process.c (start_process_unwind):
	* search.c (unwind_set_match_data):
	* window.c (select_window_norecord, select_frame_norecord):
	* xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
	(fast_set_selected_frame):
	* xfns.c, w32fns.c (unwind_create_tip_frame):
	Return void, not a dummy Lisp_Object.  All uses changed.
	* buffer.h (set_buffer_if_live): Move decl here from lisp.h.
	* callproc.c (call_process_kill):
	* fileio.c (restore_point_unwind, decide_coding_unwind)
	(build_annotations_unwind):
	* insdel.c (Fcombine_after_change_execute_1):
	* keyboard.c (read_char_help_form_unwind):
	* menu.c (unuse_menu_items):
	* minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
	* sound.c (sound_cleanup):
	* xdisp.c (unwind_redisplay):
	* xfns.c (clean_up_dialog):
	* xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
	Accept no args and return void, instead of accepting and returning
	a dummy Lisp_Object.  All uses changed.
	* cygw32.c (fchdir_unwind):
	* fileio.c (close_file_unwind):
	* keyboard.c (restore_kboard_configuration):
	* lread.c (readevalllop_1):
	* process.c (wait_reading_process_output_unwind):
	Accept int and return void, rather than accepting an Emacs integer
	and returning a dummy object.  In some cases this fixes an
	unlikely bug when the corresponding int is outside Emacs integer
	range.  All uses changed.
	* dired.c (directory_files_internal_unwind):
	* fileio.c (do_auto_save_unwind):
	* gtkutil.c (pop_down_dialog):
	* insdel.c (reset_var_on_error):
	* lread.c (load_unwind):
	* xfns.c (clean_up_file_dialog):
	* xmenu.c, nsmenu.m (pop_down_menu):
	* xmenu.c (cleanup_widget_value_tree):
	* xselect.c (wait_for_property_change_unwind):
	Accept pointer and return void, rather than accepting an Emacs
	save value encapsulating the pointer and returning a dummy object.
	All uses changed.
	* editfns.c (Fformat): Update the saved pointer directly via
	set_unwind_protect_ptr rather than indirectly via make_save_pointer.
	* eval.c (specpdl_func): Remove.  All uses replaced by definiens.
	(unwind_body): New function.
	(record_unwind_protect): First arg is now a function returning void,
	not a dummy Lisp_Object.
	(record_unwind_protect_ptr, record_unwind_protect_int)
	(record_unwind_protect_void): New functions.
	(unbind_to): Support SPECPDL_UNWIND_PTR etc.
	* fileio.c (struct auto_save_unwind): New type.
	(do_auto_save_unwind): Use it.
	(do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
	* insdel.c (struct rvoe_arg): New type.
	(reset_var_on_error): Use it.
	* lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
	New constants.
	(specbinding_func): Remove; there are now several such functions.
	(union specbinding): New members unwind_ptr, unwind_int, unwind_void.
	(set_unwind_protect_ptr): New function.
	* xselect.c: Remove unnecessary forward decls, to simplify maintenance.

1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584
	Be simpler and more consistent about reporting I/O errors.
	* fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
	Say "Read error" and "Write error", rather than "I/O error", or
	"IO error reading", or "IO error writing", when a read or write
	error occurs.
	* process.c (Fmake_network_process, wait_reading_process_output)
	(send_process, Fprocess_send_eof, wait_reading_process_output):
	Capitalize diagnostics consistently.  Put "failed foo" at the
	start of the diagnostic, so that we don't capitalize the
	function name "foo".  Consistently say "failed" for such
	diagnostics.
	* sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
	All callers changed.  This is so it can use report_file_error.
	* sysdep.c (serial_open, serial_configure): Capitalize I/O
	diagnostics consistently as above.

1585 1586 1587 1588 1589 1590 1591
	* fileio.c (report_file_errno): Fix errno reporting bug.
	If the file name is neither null nor a pair, package it up as a
	singleton list.  All callers changed, both to this function and to
	report_file_error.  This fixes a bug where the memory allocator
	invoked by list1 set errno so that the immediately following
	report_file_error reported the wrong errno value.

1592 1593 1594 1595
	Fix minor problems found by --enable-gcc-warnings.
	* frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
	* keyboard.c (kbd_buffer_get_event): Remove unused local.

1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610
2013-07-16  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
	Set event->arg to Qt if switch-event shall be generated.
	Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.

	* termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.

	* nsterm.m (windowDidResignKey): If this is the focused frame, generate
	FOCUS_OUT_EVENT.

	* keyboard.c (Qfocus_in, Qfocus_out): New static objects.
	(make_lispy_focus_in, make_lispy_focus_out): Declare and define.
	(kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
	switch frame event is made.  Check ! NILP (event->arg) if X11 (moved
Juanma Barranquero's avatar
Juanma Barranquero committed
1611
	from xterm.c).  Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1612 1613 1614 1615 1616 1617 1618 1619 1620
	and there is a focused frame.
	(head_table): Add focus-in and focus-out.
	(keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
	bind to handle-focus-in/out.

	* frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
	(Fhandle_switch_frame): Call Fhandle_focus_in.
	(syms_of_frame): defsubr handle-focus-in/out.

1621 1622
2013-07-16  Paul Eggert  <eggert@cs.ucla.edu>

1623 1624 1625 1626 1627 1628
	Fix porting bug to older POSIXish platforms (Bug#14862).
	* sysdep.c (emacs_pipe): New function, that implements
	pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
	This should port better to CentOS 5 and to Mac OS X 10.6.
	All calls to pipe2 changed.

1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709
	Prefer list1 (X) to Fcons (X, Qnil) when building lists.
	This makes the code easier to read and the executable a bit smaller.
	Do not replace all calls to Fcons that happen to create lists,
	just calls that are intended to create lists.  For example, when
	creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
	rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
	Similarly for list2 through list5.
	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
	* bytecode.c (exec_byte_code):
	* callint.c (quotify_arg, Fcall_interactively):
	* callproc.c (Fcall_process, create_temp_file):
	* charset.c (load_charset_map_from_file)
	(Fdefine_charset_internal, init_charset):
	* coding.c (get_translation_table, detect_coding_system)
	(Fcheck_coding_systems_region)
	(Fset_terminal_coding_system_internal)
	(Fdefine_coding_system_internal, Fdefine_coding_system_alias):
	* composite.c (update_compositions, Ffind_composition_internal):
	* dired.c (directory_files_internal, file_name_completion)
	(Fsystem_users):
	* dispnew.c (Fopen_termscript, bitch_at_user, init_display):
	* doc.c (Fsnarf_documentation):
	* editfns.c (Fmessage_box):
	* emacs.c (main):
	* eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
	(Feval, eval_sub, Ffuncall, apply_lambda):
	* fileio.c (make_temp_name, Fcopy_file, Faccess_file)
	(Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
	(Fset_file_times, Finsert_file_contents)
	(Fchoose_write_coding_system, Fwrite_region):
	* fns.c (Flax_plist_put, Fyes_or_no_p, sy