README.multi-tty 22.6 KB
Newer Older
1
			-*- coding: utf-8; mode: text; -*-
2 3 4
GOAL
----

5 6 7
The goal of this branch is to implement support for opening multiple,
different tty devices and simultaneous X and tty frames from a single
Emacs session.
8

9 10 11 12 13 14 15 16 17 18 19 20 21 22
Some use cases:
Emacs is notoriously slow at startup, so most people use another
editor or emacsclient for quick editing jobs from the console.
Unfortunately, emacsclient was very awkward to use, because it did not
support opening a new Emacs frame on the current virtual console.
Now, with multi-tty support, it can do that.  (Emacsclient starts up
faster than vi!)

Some Gnus users (including me) run Gnus in an X frame in its own Emacs
instance, which they typically leave running for weeks.  It would be
nice if they could connect to this instance from a remote ssh session
and check their messages without opening a remote X frame or resorting
to gnus-slave.

23 24 25 26 27
WHO IS DOING IT
---------------

I'm Károly Lőrentey.  My address: lorentey@elte.hu.

28
Comments, bug reports, suggestions and patches are welcome!
29

30
Retrieving the latest version of the branch:
31 32

	tla register-archive lorentey@elte.hu--2004 http://lorentey.web.elte.hu/arch/2004/
33
	tla get lorentey@elte.hu--2004/emacs--multi-tty <directory>
34

35 36 37 38 39
(I use a recent arch development snapshot, but any of the released
versions of arch will do fine, I think.)

If you don't have arch, the branch has a homepage from which you can
download conventional patches against Emacs CVS HEAD:
40

41
	http://lorentey.web.elte.hu/project/emacs.html
42

43 44 45 46 47 48 49 50 51 52 53
If you want to be notified of new revisions, sign up to the
multi-tty@listbox.elte.hu mailing list by visiting the
below homepage and following its instructions.

	https://listbox.elte.hu/mailman/listinfo/multi-tty

Please note that the multi-tty mailing list is read-only, and is
reserved for automatic commit messages.  Discussion about the branch
and bug reports should be sent directly to me (lorentey@elte.hu), or
to the emacs-devel@gnu.org mailing list.

54 55 56
STATUS
------

57 58 59 60 61
The branch is now very stable and almost full-featured. I hope the
major problems were fixed.  (It still needs testing on other
architectures, though.)  Both multiple tty device support and
simultaneous X and tty frame support works fine.  Emacsclient has been
extended to support opening a new terminal frame.
62 63

Please let me know if you find any bugs in this branch.
64

65 66 67
HOW TO COMPILE AND TEST
-----------------------

68
To try it out, compile and run the multi-tty branch with the following
Karoly Lorentey's avatar
Karoly Lorentey committed
69
commands:
70 71 72

   	mkdir +build
	cd +build
73
	../configure <your favourite options>
74
	make bootstrap
75
	src/emacs -nw		# You can also try without -nw
76
	M-x server-start
77

78 79 80
and then (from a shell prompt on another terminal) start emacsclient
with
	lib-src/emacsclient -t /optional/file/names...
81

Karoly Lorentey's avatar
Karoly Lorentey committed
82
You'll hopefully have two fully working, independent frames on
83 84 85 86
separate terminals. The new frame is closed automatically when you
have finished editing the specified files (C-x #), but delete-frame
(C-x 5 0) also works.  Of course, you can create frames on more than
two tty devices.
87

88 89 90
Creating new frames on the same tty with C-x 5 2 works, and they
behave the same way as in previous Emacs versions.  If you exit emacs,
all terminals should be restored to their previous states.
91

92 93
This is work in progress, and probably full of bugs.  You should
always run emacs from gdb, so that you'll have a live instance to
94
debug if something goes wrong.  Please send me your bug reports.
Karoly Lorentey's avatar
Karoly Lorentey committed
95

96 97 98 99 100 101 102 103 104 105 106 107 108 109
I think the best way to use the new Emacs is to have it running inside
a disconnected GNU screen session, and always use emacsclient for
normal work.  This way not a single keystroke of your work will be
lost if the display device that you are using crashes, or the network
connection times out, or whatever.  As long as the server that runs
your Emacs remains up, all your buffers remain exactly as they were
before the crash, and you can continue working as if nothing had
happened.  (I had an extremely unstable X server for some time while I
was developing these patches, and running Emacs this way has saved me
a number of M-x recover-session invocations.)

(I am thinking about introducing a --daemon option to get rid of the
above screen dependency.)

110
Problems:
111

112 113 114 115 116 117 118
	* Suspending Emacs is disabled if there are multiple tty
	  devices.  Also, there is no way to suspend emacsclient. This
	  will be fixed.

	* Mac, Windows and DOS support is broken, probably doesn't
	  even compile -- this will be solved later.

119
	* Only tested on my GNU/Linux box and on Solaris 8.
120 121 122 123 124 125

NEWS
----

For the NEWS file:

126
** Support for multiple terminal devices has been added.
127

128 129
*** You can specify a terminal device (`tty' parameter) and a terminal
    type (`tty-type' parameter) to `make-terminal-frame'.
130

131 132
*** You can test for the presence of multiple terminal support by
    testing for the `multi-tty' feature.
133

134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156
*** Emacsclient has been extended to support opening a new terminal
    frame (see -t option).

*** A make-frame-on-tty function has been added to make it easier to
    create frames on new terminals.

*** New functions: frame-tty-name, frame-tty-type for accessing
    terminal parameters, and delete-tty for closing the terminal
    device.

*** talk.el has been extended for multiple tty support.


** Support for simultaneous graphical and terminal frames has been
   added.

*** The function `make-frame-on-display' now works during a terminal
    session, and `make-frame-on-tty' works during a graphical session.

*** The `window-system' variable has been made frame-local.

*** The new `initial-window-system' variable contains the
    `window-system' value for the first frame.
157

158 159 160 161 162 163
THANKS
------

The following is an (incomplete) list of people who have contributed
to the project by testing, bug reports, and suggestions.  Thanks!

164 165 166 167 168 169
Robert J. Chassel <bob at rattlesnake dot com>
Romain Francoise <romain at orekobech dot com>
Ami Fischman <ami at fischman dot org>
Dan Nicolaescu <dann at ics dot uci dot edu>

Richard Stallman was kind enough to review my patches.
170

171 172 173 174 175 176

CHANGELOG
---------

See arch logs.

177 178
THINGS TO DO
------------
179 180 181 182
** Dan Nicolaescu (dann at ics dot uci dot edu) suggests that -nw
   should be added as an alias for -t in emacsclient.  Good idea.
   (Alas, implementing this is not trivial, getopt_long does not seem
   to support two-letter ``short'' options.)
183

184
** Robert J. Chassell reports:
185

186 187 188 189 190 191 192 193 194 195
   >   * After starting the frame in the VC, I saw this message in the
   >     *Message* buffer
   >
   >         error in process filter: server-process-filter: \
   >         Wrong type argument: sequencep,\
   >          framep
   >         error in process filter: Wrong type argument: sequencep, framep
   >
   >     This also happens when I start a new frame in an xterm.

196 197 198
** Very strange bug: visible-bell does not work on secondary
   terminals.  This might be something xterm (konsole) specific.

199 200 201 202 203 204
** Find out the best way to support suspending Emacs with multiple
   ttys.  My guess: disable it on the controlling tty, but from other
   ttys pass it on to emacsclient somehow.  (It is (I hope) trivial to
   extend emacsclient to handle suspend/resume.  A `kill -STOP' almost
   works right now.)

205 206 207 208 209 210 211
** Clean up the frame-local variable system.  I think it's ugly and
   error-prone.  But maybe I just haven't yet fully understood it.

** Add an elaborate mechanism for display-local variables.  (There are
   already a few of these; search for `terminal-local' in the Elisp
   manual.)

212
** Move baud_rate to struct display.
213 214 215 216 217

** Implement support for starting an interactive Emacs session without
   an initial frame.  (The user would connect to it and open frames
   later, with emacsclient.)  Not necessarily a good idea.

218 219 220 221
** Fix Mac support (I can't do this myself).  Note that the current
   state of Mac-specific source files in the multi-tty tree are not
   useful; before starting work on Mac support, revert to pristine,
   pre-multi-tty versions.
222

223 224 225 226
** Fix W32 support (I can't do this myself).  Note that the current
   state of W32-specific source files in the multi-tty tree are not
   useful; before starting work on W32 support, revert to pristine,
   pre-multi-tty versions.
227

228 229 230 231
** Fix DOS support (I can't do this myself).  Note that the current
   state of DOS-specific source files in the multi-tty tree are not
   useful; before starting work on DOS support, revert to pristine,
   pre-multi-tty versions.
232 233 234 235

** Do a grep on XXX and ?? for more issues.

** Understand Emacs's low-level input system (it seems complicated) :-)
236
   What does interrupt_input do?  I tried to disable it for raw
237 238 239 240 241 242 243
   secondary tty support, but it does not seem to do anything useful.
   (Update: Look again. X unconditionally enables this, maybe that's
   why raw terminal support is broken again.  I really do need to
   understand input.)

** emacsclient -t from an Emacs term buffer does not work, complains
   about face problems.  This can even lock up Emacs (if the recursive
244 245
   frame sets single_kboard).  Update: the face problems are caused by
   bugs in term.el, not in multi-tty.  The lockup is caused by
246 247
   single_kboard mode, and is not easily solvable.  The best thing to
   do is to simply refuse to create a tty frame of type `eterm'.
248

249 250
** Maybe standard-display-table should be display-local.

251 252 253 254
DIARY OF CHANGES
----------------

(ex-TODO items with explanations.)
255

256
-- Introduce a new struct for terminal devices.
257

258
   (Done, see struct tty_output.  The list of members is not yet
259 260 261 262 263 264 265 266 267 268
   complete.)

-- Change the bootstrap procedure to initialize tty_list.

   (Done, but needs review.)

-- Change make-terminal-frame to support specifying another tty.

   (Done, new frame parameters: `tty' and `tty-type'.)

269 270 271
-- Implement support for reading from multiple terminals.

   (Done, read_avail_input tries to read from each terminal, until one
272
   succeeds.  MULTI_KBOARD is not used.  Secondary terminals don't send
273
   SIGIO!)
274

275 276
   (Update: They do, now.)

277 278
   (Update2: After enabling X, they don't.)

279
-- other-frame should cycle through the frames on the `current'
280
   terminal only.
281

282
   (Done, by trivially modifiying next_frame and prev_frame.)
283 284

-- Support different terminal sizes.
285

286 287 288 289 290
   (Done, no problem.)

-- Make sure terminal resizes are handled gracefully.  (Could be
   problematic.)

291 292
   (Done.  We don't get automatic SIGWINCH for additional ttys,
   though.)
293 294 295

-- Extend emacsclient to automatically open a new tty when it connects
   to Emacs.
296

297 298
   (Done.  It's an ugly hack, needs more work.)

299 300
-- Redisplay must refresh the topmost frame on *all* terminals, not
   just the initial terminal.
301

302
   (Done, but introduced an ugly redisplay problems.  Ugh.)
303

304 305
-- Fix redisplay problems.

306 307
   (Done; it turned out that the entire Wcm structure must be moved
   inside tty_output.  Why didn't I catch this earlier?)
308 309 310 311 312 313 314 315 316 317

-- Provide a way for emacsclient to tell Emacs that the tty has been
   resized.

   (Done, simply forward the SIGWINCH signal.)

-- Each keypress should automatically select the frame corresponding
   to the terminal that it was coming from.  This means that Emacs
   must know from which terminal the last keyboard event came from.

318 319
   (Done, it was quite simple, the input event system already
   supported multiple frames.)
320 321 322 323

-- Fix SIGIO issue with secondary terminals.

   (Done, emacsclient signals Emacs after writing to the proxy pseudo
324 325
   terminal.  Note that this means that multi-tty does not work with
   raw ttys!)
326

Karoly Lorentey's avatar
Karoly Lorentey committed
327 328 329
   (Update: This is bullshit.  There is a read_input_waiting function,
   extend that somehow.)

330 331 332 333
   (Update of update: The first update was not right either, extending
   read_input_waiting was not necessary.  Secondary ttys do seem to
   send signals on input.)

334 335
   (Update^3: Not any more.)

336 337 338 339 340 341 342 343 344 345
-- Make make-terminal-frame look up the `tty' and `tty-type' frame
   parameters from the currently selected terminal before the global
   default.

   (Done.)

-- Put all cached terminal escape sequences into struct tty_output.
   Currently, they are still stored in global variables, so we don't
   really support multiple terminal types.

346
   (Done.  It was not fun.)
347 348

-- Implement sane error handling after initialization.  (Currently
349 350 351
   emacs exits if you specify a bad terminal type.)  The helpful error
   messages must still be provided when Emacs starts.

352 353 354 355 356
   (Done.)

-- Implement terminal deletion, i.e., deleting local frames, closing
   the tty device and restoring its previous state without exiting
   Emacs.
357

358 359
   (Done, but at the moment only called when an error happens during
   initialization.  There is a memory corruption error around this
360
   somewhere.)  (Update: now it is fully enabled.)
361

362 363 364 365 366
-- Implement automatic deletion of terminals when the last frame on
   that terminal is closed.

   (Done.)

Karoly Lorentey's avatar
Karoly Lorentey committed
367 368 369 370 371
-- Restore tty screen after closing the terminal.

   (Done, we do the same as Emacs 21.2 for all terminals.)

-- 'TERM=dumb src/emacs' does not restore the terminal state.
372

Karoly Lorentey's avatar
Karoly Lorentey committed
373
   (Done.)
374

375 376 377 378 379 380 381 382
-- C-g should work on secondary terminals.

   (Done, but the binding is not configurable.)

-- Deal with SIGHUP in Emacs and in emacsclient.  (After this, the
   server-frames may be removed from server.el.)

   (Done, nothing to do.  It seems that Emacs does not receive SIGHUP
383
   from secondary ttys, which is actually a good thing.)  (Update: I
384
   think it would be a bad idea to remove server-frames.)
385

386
-- Change emacsclient/server.el to support the -t argument better,
387 388 389 390
   i.e. automatically close the socket when the frame is closed.

   (Seems to be working OK.)

391
-- Fix mysterious memory corruption error with tty deletion.  To
392 393 394 395 396
   trigger it, try the following shell command:

	while true; do TERM=no-such-terminal-definition emacsclient -h; done

   Emacs usually dumps core after a few dozen iterations.  (The bug
397
   seems to be related to the xfreeing or bzeroing of
398 399 400
   tty_output.Wcm.  Maybe there are outside references to struct Wcm?
   Why were these vars collected into a struct before multi-tty
   support?)
401

402 403 404 405
   (Done.  Whew.  It turned out that the problem had nothing to do
   with hypothetical external references to Wcm, or any other
   tty_output component; it was simply that delete_tty closed the
   filehandles of secondary ttys twice, resulting in fclose doubly
406
   freeing memory.  Utterly trivial matter.  I love the C's memory
407 408
   management, it puts hair on your chest.)

409
-- Support raw secondary terminals.  (Note that SIGIO works only on
410
   the controlling terminal.) Hint: extend read_input_waiting for
411
   multiple ttys and hopefully this will be fixed.
412

413 414 415 416
   (Done, it seems to have been working already for some time.  It
   seems F_SETOWN does work, after all.  Not sure what made it fail
   earlier, but it seems to be fixed (there were several changes
   around request_sigio, maybe one of them did it).
417
   read_input_waiting is only used in sys_select, don't change
418
   it.)  (Update: After adding X support, it's broken again.)
419

420
-- Find out why does Emacs abort when it wants to close its
Karoly Lorentey's avatar
Karoly Lorentey committed
421
   controlling tty.  Hint: chan_process[] array.  Hey, maybe
422 423
   noninterrupt-IO would work, too?  Update: no, there is no process
   for stdin/out.
Karoly Lorentey's avatar
Karoly Lorentey committed
424

425 426
   (Done.  Added add/delete_keyboard_wait_descriptor to
   term_init/delete_tty.  The hint was right, in a way.)
427

428
-- Issue with SIGIO: it needs to be disabled during redisplay.  See if
429
   fcntl kernel behaviour could be emulated by emacsclient.
Karoly Lorentey's avatar
Karoly Lorentey committed
430

431
   (Done.  Simply disabled the SIGIO emulation hack in emacsclient.)
432
   (Update: it was added back.)
433

434
-- server.el: There are issues with saving files in buffers of closed
435 436 437 438 439
   clients.  Try editing a file with emacsclient -f, and (without
   saving it) do a delete-frame.  The frame is closed without
   question, and a surprising confirmation prompt appears in another
   frame.

440 441 442 443
   (Done.  delete-frame now asks for confirmation if it still has
   pending buffers, and modified buffers don't seem to be deleted.)

-- emacsclient.el, server.el: Handle eval or file open errors when
444
   doing -t.
445

446
   (Done.)
447

448 449
-- Make parts of struct tty_output accessible from Lisp.  The device
   name and the type is sufficient.
450

451 452 453
   (Done, see frame-tty-name and frame-tty-type.)

-- Export delete_tty to the Lisp environment, for emacsclient.
454

455 456
   (Done, see delete-tty.)

457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476
-- Get rid of the accessor macros in termchar.h, or define macros for
   all members.

   (Done.)

-- Move device-specific parameters (like costs) commonly used by
   device backends to a common, device-dependent structure.

   (Done.  See struct display_method in termhooks.h.)

-- Fix X support.

   (Done.  Well, it seems to be working.)

-- Allow simultaneous X and tty frames.  (Handling input could be
   tricky.  Or maybe not.)

   (Done.  Allowed, that is.  It is currently extremely unstable, to
   the point of being unusable.  The rif variable causes constant
   core dumps.  Handling input is indeed tricky.)
477

478
-- Rewrite multi-tty input in terms of MULTI_KBOARD.
479

480 481 482
   (Done.  In fact, there was no need to rewrite anything, I just
   added a kboard member to tty_display_info, and initialized the
   frame's kboard from there.)
483

484 485 486 487 488 489 490
-- Fix rif issue with X-tty combo sessions.  IMHO the best thing to do
   is to get rid of that global variable (and use the value value in
   display_method, which is guaranteed to be correct).

   (Done, did exactly that.  Core dumps during combo sessions became
   much rarer.  In fact, I have not yet met a single one.)

491 492 493 494
-- Add multi-tty support to talk.el.

   (Done.)

495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528
-- Clean up the source of emacsclient.  It is a mess.

   (Done, eliminated stupid proxy-pty kludge.)

-- Fix faces on tty frames during X-tty combo sessions.  There is an
   init_frame_faces call in init_sys_modes, see if there is a problem
   with it.

   (Done, there was a stupid mistake in
   Ftty_supports_face_attributes_p. Colors are broken, though.)

-- C-x 5 2, C-x 5 o, C-x 5 0 on an emacsclient frame unexpectedly
   exits emacsclient.  This is a result of trying to be clever with
   delete-frame-functions.

   (Fixed, added delete-tty-after-functions, and changed server.el to
   use it.)

-- Something with (maybe) multi-keyboard support broke function keys
   and arrows on ttys during X+tty combo sessions.  Debug this.

   (I can't reproduce it, maybe the terminal type was wrong.)

-- Fix input from raw ttys (again).

   (Now it seems to work all right.)

-- During an X-tty combo session, a (message "Hello") from a tty frame
   goes to the X frame.  Fix this.

   (Done.  There was a safeguard against writing to the initial
   terminal frame during bootstrap which prevented echo_area_display
   from working correctly on a tty frame during a combo session.)

529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556
-- If there are no frames on its controlling terminal, Emacs should
   exit if the uses presses C-c there.

   (Done, as far as possible.  See the SIGTERM comment in
   interrupt_signal on why this seems to be impossible to solve this
   in general.)

-- During an X session, Emacs seems to read from stdin.  Also, Emacs
   fails to start without a controlling tty.

   (Fixed by replacing the troublesome termcap display with a dummy
   bootstrap display during bootstrap.

-- Do tty output through struct display, like graphical display
   backends.

   (Done.)

-- Define an output_initial value for output_method for the initial
   frame that is dumped with Emacs.  Checking for this frame (e.g. in
   cmd_error_internal) is ugly.

   (Done, broking interactive temacs.)

-- The command `emacsclient -t -e '(delete-frame)'' fails to exit.

   (Fixed.)

557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
-- frame-creation-function should always create a frame that is on the
   same display as the selected frame.  Maybe frame-creation-function
   should simply be removed and make-frame changed to do the right
   thing.

   (Done, with a nice hack.  frame-creation-function is now frame-local.)

-- Fix C-g on raw ttys.

   (Done.  I disabled the interrupt/quit keys on all secondary
   terminals, so Emacs sees C-g as normal input.  This looks like an
   overkill, because emacsclient has extra code to pass SIGINT to
   Emacs, so C-g should remain the interrupt/quit key on emacsclient
   frames.  See the next entry why implementing this distinction would
   be a bad idea.)

-- Make sure C-g goes to the right frame with ttys.  This is hard, as
   SIGINT doesn't have a tty parameter. :-(

   (Done, the previous change fixes this as a pleasant side effect.)

578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
-- I have seen a case when Emacs with multiple ttys fell into a loop
   eating 100% of CPU time.  Strace showed this loop:

	getpid()                                = 30284
	kill(30284, SIGIO)                      = 0
	--- SIGIO (I/O possible) @ 0 (0) ---
	ioctl(6, FIONREAD, [0])                 = -1 EIO (Input/output error)
	ioctl(5, FIONREAD, [0])                 = -1 EIO (Input/output error)
	ioctl(0, FIONREAD, [0])                 = 0
	sigreturn()                             = ? (mask now [])
	gettimeofday({1072842297, 747760}, NULL) = 0
	gettimeofday({1072842297, 747806}, NULL) = 0
	select(9, [0 3 5 6], NULL, NULL, {0, 0}) = 2 (in [5 6], left {0, 0})
	select(9, [0 3 5 6], NULL, NULL, {0, 0}) = 2 (in [5 6], left {0, 0})
	gettimeofday({1072842297, 748245}, NULL) = 0

   I have seen something similar with a single X frame, but have not
   been able to reproduce it for debugging.

   Update: This may have been caused by checking for nread != 0
   instead of nread > 0 after calling read_socket_hook in
   read_avail_input.

   (Fixed.  This was caused by unconditionally including stdin in
   input_wait_mask in init_process.  The select call in
   wait_reading_process_input always returned immediately, indicating
   that there is pending input from stdin, which nobody read.

   Note that the above strace output seems to be an unrelated but
   similar bug.  I think that is now fixed.)
608

609 610 611 612 613 614 615 616 617
-- Exiting Emacs while there are emacsclient frames doesn't restore the
   ttys to their default states.

   (This seems to be fixed by some previous change.)

-- Allow opening an X session after -nw.

   (Done.)

618 619 620 621 622 623 624 625 626 627 628
-- Fix color handling during tty+X combo sessions.  (It seems that tty
   sessions automatically convert the face colors to terminal colors
   when the face is loaded.  This conversion must happen instead on
   the fly in write_glyphs, which might be problematic, as color
   approximation is currently done in lisp (term/tty-colors.el).)
   (Update: hm, colors seem to work fine if I start emacs with -nw and
   then create an X frame.  Maybe it's just a small buglet somewhere.)

   (Seems to be fixed.  The problem was in startup.el, it did not
   initialize tty colors when the initial window system was
   graphical.)
629

630 631 632 633 634
-- emacs -nw --eval '(y-or-n-p "Foobar")' segfaults.  (Reported by
   Romain Francoise)

   (Fixed, there was a keyboard initialization problem.)

Karoly Lorentey's avatar
Karoly Lorentey committed
635 636 637 638 639
-- Fix interactive use of temacs.  There are face-related SEGVs, most
   likely because of changes in realize_default_face, realize_face.

   (Fixed.)

640 641 642 643 644
-- Don't exit Emacs when the last X connection fails during a
   multi-display session.

   (Fixed.)

645 646 647 648 649 650 651

-- Dan Nicolaescu noticed that starting emacsclient on the same
   terminal device that is the controlling tty of the Emacs process
   gives unexpected results.

   (Fixed.)

652
;;; arch-tag: 8da1619e-2e79-41a8-9ac9-a0485daad17d