ChangeLog 97.5 KB
Newer Older
1 2
2011-04-19  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* fns.c (internal_equal): Don't assume size_t fits in int.

5 6
	* alloc.c (compact_small_strings): Tighten assertion a little.

7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
	Replace pEd with more-general pI, and fix some printf arg casts.
	* lisp.h (pI): New macro, generalizing old pEd macro to other
	conversion specifiers.  For example, use "...%"pI"d..." rather
	than "...%"pEd"...".
	(pEd): Remove.  All uses replaced with similar uses of pI.
	* src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
	* alloc.c (check_pure_size): Don't overflow by converting size to int.
	* bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
	* data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
	* dbusbind.c (xd_append_arg): Use pI to avoid cast.
	(Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
	* font.c (font_unparse_xlfd): Avoid potential buffer overrun on
	64-bit hosts.
	(font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
	* keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
	* print.c (safe_debug_print, print_object): Likewise.
	(print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
	to int.
	Use pI instead of if-then-else-abort.  Use %p to avoid casts.
	* process.c (Fmake_network_process): Use pI to avoid cast.
	* region-cache.c (pp_cache): Likewise.
	* xdisp.c (decode_mode_spec): Likewise.
	* xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
	behavior on 64-bit hosts with printf arg.
	* xselect.c (x_queue_event): Use %p to avoid casts.
	(x_stop_queuing_selection_requests): Likewise.
	(x_get_window_property): Don't truncate byte count to an 'int'
	when tracing.
35

36 37 38 39 40
	* frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
	here, since it parses constructs like leading '-' and spaces,
	which are not wanted; and it overflows with large numbers.
	Instead, simply match F[0-9]+, which is what is wanted anyway.

41 42 43 44 45 46 47 48 49
	* alloc.c: Remove unportable assumptions about struct layout.
	(SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
	(SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
	(allocate_vectorlike, make_pure_vector): Use the new macros,
	plus offsetof, to remove unportable assumptions about struct layout.
	These assumptions hold on all porting targets that I know of, but
	they are not guaranteed, they're easy to remove, and removing them
	makes further changes easier.

50 51
	* alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
	This doesn't fix a bug but makes the code clearer.
52 53
	(string_overrun_cookie): Now const.  Use initializers that
	don't formally overflow signed char, to avoid warnings.
54 55
	(allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
	can cause Emacs to crash when string overrun checking is enabled.
56 57 58
	(allocate_buffer): Don't assume sizeof (struct buffer) is a
	multiple of sizeof (EMACS_INT); it need not be, if
	alignof(EMACS_INT) < sizeof (EMACS_INT).
59
	(check_sblock, check_string_bytes, check_string_free_list): Protoize.
60

Chong Yidong's avatar
Chong Yidong committed
61 62 63 64 65 66 67 68 69
2011-04-17  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (get_next_display_element): Remove unnecessary ifdefs.

	* termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.

	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
	definition for no-X builds.

70
2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>
71

72 73
	Static checks with GCC 4.6.0 and non-default toolkits.

74 75
	* s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.

76 77 78 79
	* process.c (keyboard_bit_set): Define only if SIGIO.
	(send_process_trap): Mark it with NO_RETURN if it doesn't return.
	(send_process): Repair possible setjmp clobbering.

80 81
	* s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.

82 83
	* eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.

84 85
	* data.c (arith_error): Mark with NO_RETURN if it doesn't return.

86 87 88
	* alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
	Define only if needed.

89 90
	* sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
	by pacifying GCC about it.  Maybe it's time to retire it?
91
	* xfaces.c (USG, __TIMEVAL__): Likewise.
92

93 94
	* dispextern.h (struct redisplay_interface): Rename param
	to avoid shadowing.
95
	* termhooks.h (struct terminal): Likewise.
96
	* xterm.c (xembed_send_message): Likewise.
97

98 99 100
	* insdel.c (make_gap_smaller): Define only if
	USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.

101 102 103
	* keyboard.c (read_char): Make a var volatile so longjmp won't clobber
	it.

104 105 106
	* emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
	so that we aren't warned about unused symbols.

107 108
	* xfns.c (Fx_file_dialog): Rename local to avoid shadowing.

109
	* xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
110

111 112
	* xfns.c (x_real_positions): Mark locals as initialized.

113 114
	* xmenu.c (xmenu_show): Don't use uninitialized vars.

115 116
	* xterm.c: Fix problems found by static analysis with other toolkits.
	(toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
117 118
	(x_dispatch_event): Declare static if USE_GTK, and
	define if USE_GTK || USE_X_TOOLKIT.
119
	(SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
120
	* xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
121 122 123
	* xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
	defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.

124 125 126 127 128 129
	* xmenu.c (menu_help_callback): Pointer type fixes.
	Use const pointers when pointing at readonly data.  Avoid pointer
	signedness clashes.
	(FALSE): Remove unused macro.
	(update_frame_menubar): Remove unused decl.

130 131
	* xfns.c (Fx_hide_tip): Move locals to avoid shadowing.

132 133 134 135
	* menu.c (push_submenu_start, push_submenu_end): Do not define unless
	USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
	(single_menu_item): Rename local to avoid shadowing.

136 137
	* keyboard.c (make_lispy_event): Remove unused local var.

138 139 140
	* frame.c, frame.h (x_get_resource_string): Bring this back, but
	only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.

141 142 143 144 145
	* bitmaps: Change bitmaps from unsigned char back to the X11
	compatible char.  Avoid the old compiler warnings about
	out-of-range initializers by using, for example, '\xab' rather
	than 0xab.

146 147 148
	* xgselect.c (xgselect_initialize): Check vs interface
	even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).

149 150
	* xmenu.c (xmenu_show): Rename parm to avoid shadowing.

151 152 153
	* xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
	to read-only memory.

154 155
	* fns.c (vector): Remove; this old hack is no longer needed.

156
	* xsmfns.c (create_client_leader_window): Rename shadowing arg.
Paul Eggert's avatar
Paul Eggert committed
157
	Remove unused var.
158
	(gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
159

160
	* xrdb.c (x_load_resources): Omit unused local.
161

162
	* xfns.c (free_frame_menubar, atof): Remove duplicate decls.
163
	(x_window): Rename locals to avoid shadowing.
164
	(USG): Use the kludged USG macro, to pacify gcc.
165

166
	* xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
167
	(x_term_init): Remove local to avoid shadowing.
168

169
	* xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
170 171 172 173

	* xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
	USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.

174 175
2011-04-16  Eli Zaretskii  <eliz@gnu.org>

176 177
	* gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.

178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
	Fix regex.c, syntax.c and friends for buffers > 2GB.
	* syntax.h (struct gl_state_s): Declare character position members
	EMACS_INT.

	* syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.

	* textprop.c (verify_interval_modification, interval_of): Declare
	arguments EMACS_INT.

	* intervals.c (adjust_intervals_for_insertion): Declare arguments
	EMACS_INT.

	* intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.

	* indent.c (Fvertical_motion): Local variable it_start is now
	EMACS_INT.

	* regex.c (re_match, re_match_2, re_match_2_internal)
	(bcmp_translate, regcomp, regexec, print_double_string)
	(group_in_compile_stack, re_search, re_search_2, regex_compile)
	(re_compile_pattern, re_exec): Declare arguments and local
	variables `size_t' and `ssize_t' and return values `regoff_t', as
	appropriate.
	(POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
	(CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
	<compile_stack_type>: `size' and `avail' are now `size_t'.

	* regex.h <regoff_t>: Use ssize_t, not int.
	(re_search, re_search_2, re_match, re_match_2): Arguments that
	specify buffer/string position and length are now ssize_t and
	size_t.  Return type is regoff_t.

210 211 212 213 214 215 216 217 218 219
2011-04-16  Ben Key  <bkey76@gmail.com>

	* nsfont.m: Fixed bugs in ns_get_family and
	ns_descriptor_to_entity that were caused by using free to
	deallocate memory blocks that were allocated by xmalloc (via
	xstrdup).  This caused Emacs to crash when compiled with
	XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
	--enable-checking=xmallocoverrun).  xfree is now used to
	deallocate these memory blocks.

Paul Eggert's avatar
Paul Eggert committed
220
2011-04-15  Paul Eggert  <eggert@cs.ucla.edu>
221

222 223
	* sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.

224 225 226 227 228 229 230 231
	emacs_write: Accept and return EMACS_INT for sizes.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
	et seq.
	* gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
	Accept and return EMACS_INT.
	(emacs_gnutls_write): Return the number of bytes written on
	partial writes.
	* sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
232 233
	(emacs_read, emacs_write): Remove check for negative size, as the
	Emacs source code has been audited now.
234 235
	* sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
	(emacs_read, emacs_write): Use it.
236 237 238
	* process.c (send_process): Adjust to the new signatures of
	emacs_write and emacs_gnutls_write.  Do not attempt to store
	a byte offset into an 'int'; it might overflow.
239
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
240

241 242
	* sound.c: Don't assume sizes fit in 'int'.
	(struct sound_device.period_size, alsa_period_size):
243
	Return EMACS_INT, not int.
244
	(struct sound_device.write, vox_write, alsa_write):
245 246
	Accept EMACS_INT, not int.
	(wav_play, au_play): Use EMACS_INT to store sizes and to
247 248
	record read return values.

249 250
2011-04-15  Ben Key  <bkey76@gmail.com>

251 252 253 254
	* keyboard.c (Qundefined): Don't declare static since it is used
	in nsfns.m.
	* xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
	static since they are used in nsfont.m.
255

256 257 258 259 260
2011-04-15  Stefan Monnier  <monnier@iro.umontreal.ca>

	* process.c (Qprocessp): Don't declare static.
	* lisp.h (Qprocessp): Declare again.

261 262 263 264
2011-04-15  Juanma Barranquero  <lekktu@gmail.com>

	* font.c (Qopentype): Don't make static (used from w32uniscribe.c).

265 266
2011-04-14  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
267
	Improve C-level modularity by making more things 'static'.
268

269 270 271 272 273 274 275 276
	Don't publish debugger-only interfaces to other modules.
	* lisp.h (safe_debug_print, debug_output_compilation_hack):
	(verify_bytepos, count_markers): Move decls to the only modules
	that need them.
	* region-cache.h (pp_cache): Likewise.
	* window.h (check_all_windows): Likewise.
	* marker.c, print.c, region-cache.c, window.c: Decls moved here.

277 278 279
	* sysdep.c (croak): Now static, if
	defined TIOCNOTTY || defined USG5 || defined CYGWIN.
	* syssignal.h (croak): Declare only if not static.
280 281 282 283

	* alloc.c (refill_memory_reserve): Now static if
	!defined REL_ALLOC || defined SYSTEM_MALLOC.
	* lisp.h (refill_memory_reserve): Declare only if not static.
284

285 286 287
	* xsettings.c, xsettings.h (xsettings_get_system_normal_font):
	Define only if USE_LUCID.

288 289
	* xrdb.c (x_customization_string, x_rm_string): Now static.

290 291 292
	* xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
	* xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.

293 294 295
	* xdisp.c (draw_row_with_mouse_face): Now static.
	* dispextern.h (draw_row_with_mouse_fave): Remove decl.

296 297
	* window.h (check_all_windows): Mark externally visible.

298 299 300 301 302 303
	* window.c (window_deletion_count): Now static.

	* undo.c: Make symbols static if they're not exported.
	(last_undo_buffer, last_boundary_position, pending_boundary):
	Now static.

304 305 306
	* textprop.c (interval_insert_behind_hooks): Now static.
	(interval_insert_in_front_hooks): Likewise.

307 308 309 310 311 312 313
	* term.c: Make symbols static if they're not exported.
	(tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
	(max_frame_lines, tty_set_terminal_modes):
	(tty_reset_terminal_modes, tty_turn_off_highlight):
	(get_tty_terminal): Now static.
	(term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
	* termhooks.h (term_mouse_moveto): Do not declare if
Paul Eggert's avatar
Paul Eggert committed
314
	HAVE_WINDOW_SYSTEM.
315 316 317
	* dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
	(tty_turn_off_highlight, get_tty_terminal): Remove decls.

318 319 320 321 322 323 324 325
	* sysdep.c: Make symbols static if they're not exported.
	(emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
	Now static.
	(sigprocmask_set, full_mask): Remove; unused.
	(wait_debugging): Mark as visible.
	* syssignal.h (SIGFULLMASK, full_mask): Remove decls.
	* systty.h (emacs_get_tty, emacs_set_tty): Remove decls.

326 327
	* syntax.c (syntax_temp): Define only if !__GNUC__.

328 329
	* sound.c (current_sound_device, current_sound): Now static.

330 331
	* search.c (searchbufs, searchbuf_head): Now static.

332 333 334
	* scroll.c (scroll_cost): Remove; unused.
	* dispextern.h (scroll_cost): Remove decl.

335 336
	* region-cache.h (pp_cache): Mark as externally visible.

337 338 339 340 341 342 343 344
	* process.c: Make symbols static if they're not exported.
	(process_tick, update_tick, create_process, chan_process):
	(Vprocess_alist, proc_buffered_char, datagram_access):
	(fd_callback_data, send_process_frame, process_sent_to): Now static.
	(deactivate_process): Mark defn as static, as well as decl.
	* lisp.h (create_process): Remove decl.
	* process.h (chan_process, Vprocess_alist): Remove decls.

345 346 347 348 349 350 351 352
	* print.c: Make symbols static if they're not exported.
	(print_depth, new_backquote_output, being_printed, print_buffer):
	(print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
	(print_interval, print_number_index, initial_stderr_stream):
	Now static.
	* lisp.h (Fprinc): Remove decl.
	(debug_output_compilation_hack): Mark as externally visible.

353 354 355 356
	* sysdep.c (croak): Move decl from here to syssignal.h.
	* syssignal.h (croak): Put it here, so the API can be checked when
	'croak' is called from dissociate_if_controlling_tty.

357 358 359 360
	* minibuf.c: Make symbols static if they're not exported.
	(minibuf_save_list, choose_minibuf_frame): Now static.
	* lisp.h (choose_minibuf_frame): Remove decl.

361 362
	* lisp.h (verify_bytepos, count_markers): Mark as externally visible.

363 364 365 366 367 368
	* lread.c: Make symbols static if they're not exported.
	(read_objects, initial_obarray, oblookup_last_bucket_number):
	Now static.
	(make_symbol): Remove; unused.
	* lisp.h (initial_obarray, make_symbol): Remove decls.

369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
	* keyboard.c: Make symbols static if they're not exported.
	(single_kboard, recent_keys_index, total_keys, recent_keys):
	(this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
	(this_single_command_key_start, echoing, last_auto_save):
	(read_key_sequence_cmd, dribble, recursive_edit_unwind):
	(command_loop, echo_now, keyboard_init_hook, help_char_p):
	(quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
	(Vlispy_mouse_stem, double_click_count):
	Now static.
	(force_auto_save_soon): Define only if SIGDANGER.
	(ignore_mouse_drag_p): Now static if
	!defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
	(print_help): Remove; unused.
	(stop_character, last_timer_event): Mark as externally visible.
	* keyboard.h (ignore_mouse_drag_p): Declare only if
	defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
	(echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
	* lisp.h (echoing): Remove decl.
	(force_auto_save_soon): Declare only if SIGDANGER.
	* xdisp.c (redisplay_window): Simplify code, to make it more
	obvious that ignore_mouse_drag_p is not accessed if !defined
	USE_GTK && !defined HAVE_NS.

392 393 394 395 396
	* intervals.c: Make symbols static if they're not exported.
	(merge_properties_sticky, merge_interval_right, delete_interval):
	Now static.
	* intervals.h (merge_interval_right, delete_interval): Remove decls.

397 398 399 400
	* insdel.c: Make symbols static if they're not exported.
	However, leave prepare_to_modify_buffer alone.  It's never
	called from outside this function, but that appears to be a bug.
	(combine_after_change_list, combine_after_change_buffer):
401
	(adjust_after_replace, signal_before_change): Now static.
402 403
	(adjust_after_replace_noundo): Remove; unused.
	* lisp.h (adjust_after_replace, adjust_after_replace_noundo):
404
	(signal_before_change): Remove decls.
405

406 407
	* indent.c (val_compute_motion, val_vmotion): Now static.

408 409 410 411 412 413
	* image.c: Make symbols static if they're not exported.
	* dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
	if USE_GTK.
	* image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
	(xpm_color_cache, ct_table, ct_colors_allocated): Now static.

414 415 416
	* fringe.c (standard_bitmaps): Now static.
	(max_used_fringe_bitmap): Now static, unless HAVE_NS.

417 418 419 420 421 422 423 424 425 426
	* frame.c: Make symbols static if they're not exported.
	(x_report_frame_params, make_terminal_frame): Now static.
	(get_frame_param): Now static, unless HAVE_NS.
	(x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
	(x_get_resource_string): Remove; not used.
	* frame.h (make_terminal_frame, x_report_frame_params):
	(x_get_resource_string); Remove decls.
	(x_fullscreen_adjust): Declare only if WINDOWSNT.
	* lisp.h (get_frame_param): Declare only if HAVE_NS.

427 428 429 430 431 432 433 434 435 436 437 438 439
	* font.c, fontset.c: Make symbols static if they're not exported.
	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
	(FACE_SUITABLE_FOR_CHAR_P): Use it.
	* font.c (font_close_object): Now static.
	* font.h (font_close_object): Remove.
	* fontset.c (FONTSET_OBJLIST): Remove.
	(free_realized_fontset) #if-0 the body, which does nothing.
	(face_suitable_for_char_p): #if-0, as it's never called.
	* fontset.h (face_suitable_for_char_p): Remove decl.
	* xfaces.c (face_at_string_position): Use
	FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
	since 0 is always ASCII.

440 441
	* fns.c (weak_hash_tables): Now static.

442 443 444 445
	* fileio.c: Make symbols static if they're not exported.
	(auto_saving, auto_save_mode_bits, auto_save_error_occurred):
	(Vwrite_region_annotation_buffers): Now static.

446 447 448 449
	* eval.c: Make symbols static if they're not exported.
	(backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
	* lisp.h (backtrace_list): Remove decl.

450 451 452 453 454 455 456 457 458 459
	* emacs.c: Make symbols static if they're not exported.
	(malloc_state_ptr, malloc_using_checking, syms_of_emacs):
	(fatal_error_code, fatal_error_signal_hook, standard_args):
	Now static.
	(fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
	(DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
	(__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
	* lisp.h (fatal_error_signal_hook): Remove decl.
	(fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.

460 461 462 463 464
	* editfns.c: Move a (normally-unused) function to its only use.
	* editfns.c, lisp.h (get_operating_system_release): Remove.
	* process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
	worth the hassle of breaking this out.

465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
	* xterm.c: Make symbols static if they're not exported.
	(x_raise_frame, x_lower_frame, x_wm_set_window_state):
	(x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
	(x_destroy_window, x_delete_display):
	Now static.
	(x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
	(x_mouse_leave): Remove; unused.
	* xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
	(x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
	(x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
	Remove decls.
	(x_mouse_leave): Declare only if WINDOWSNT.
	(x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
	(xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
	USE_X_TOOLKIT.

481 482 483 484 485
	* ftxfont.c: Make symbols static if they're not exported.
	(ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
	HAVE_FREETYPE.
	* font.h (ftxfont_driver): Likewise.

486 487 488 489 490 491 492 493 494 495 496 497 498
	* xfns.c: Make symbols static if they're not exported.
	(x_last_font_name, x_display_info_for_name):
	(x_set_foreground_color, x_set_background_color, x_set_mouse_color):
	(x_set_cursor_color, x_set_border_pixel, x_set_border_color):
	(x_set_cursor_type, x_set_icon_type, x_set_icon_name):
	(x_set_scroll_bar_foreground, x_set_scroll_bar_background):
	(x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
	(last_show_tip_args): Now static.
	(xic_defaut_fontset, xic_create_fontsetname): Define only if
	defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
	(x_screen_planes): Remove; unused.
	* dispextern.h (x_screen_planes): Remove decl.

499 500 501 502 503 504 505 506
	* dispnew.c: Make symbols static if they're not exported.
	* dispextern.h (redraw_garbaged_frames, scrolling):
	(increment_row_positions): Remove.
	* dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
	(delayed_size_change, glyph_matrix_count, glyph_pool_count):
	Now static.
	(redraw_garbaged_frames): Remove; unused.

507 508 509 510 511 512 513 514 515 516
	* xfaces.c: Make symbols static if they're not exported.
	* dispextern.h (ascii_face_of_lisp_face, free_realized_face):
	Remove decls.
	* xterm.h (defined_color): Remove decls.
	(x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
	* xfaces.c (tty_suppress_bold_inverse_default_colors_p):
	(menu_face_changed_default, defined_color, free_realized_face):
	(x_free_dpy_colors): Define only if USE_X_TOOLKIT.
	(ascii_face_of_lisp_face): Remove; unused.

517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534
	* xdisp.c: Make symbols static if they're not exported.
	* dispextern.h (scratch_glyph_row, window_box_edges):
	(glyph_to_pixel_coords, set_cursor_from_row):
	(get_next_display_element, set_iterator_to_next):
	(highlight_trailing_whitespace, frame_to_window_pixel_xy):
	(show_mouse_face): Remove decls
	* frame.h (message_buf_print): Likewise.
	* lisp.h (pop_message, set_message, check_point_in_composition):
	Likewise.
	* xterm.h (set_vertical_scroll_bar): Likewise.
	* xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
	(message_buf_print, scratch_glyph_row, displayed_buffer):
	(set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
	(get_next_display_element, show_mouse_face, window_box_edges):
	(frame_to_window_pixel_xy, check_point_in_composition):
	(set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
	(glyph_to_pixel_coords): Remove; unused.

535 536 537 538
	* dired.c (file_name_completion): Now static.

	* dbusbind.c (xd_in_read_queued_messages): Now static.

539 540 541
	* lisp.h (circular_list_error, FOREACH): Remove; unused.
	* data.c (circular_list_error): Remove.

542 543 544 545
	* commands.h (last_point_position, last_point_position_buffer):
	(last_point_position_window): Remove decls.
	* keyboard.c: Make these variables static.

546 547 548 549 550 551
	* coding.h (coding, code_convert_region, encode_coding_gap): Remove
	decls.
	* coding.c (Vsjis_coding_system, Vbig5_coding_system):
	(iso_code_class, detect_coding, code_convert_region): Now static.
	(encode_coding_gap): Remove; unused.

552 553
	* chartab.c (chartab_chars, chartab_bits): Now static.

554 555 556 557
	* charset.h (charset_iso_8859_1): Remove decl.
	* charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
	Now static.

558 559 560 561
	* ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
	* ccl.c (Vccl_program_table): Now static.
	(check_ccl_update): Remove; unused.

562 563 564 565
	* category.c (SET_CATEGORY_SET, set_category_set): Move here.
	* category.h: ... from here.
	* category.c (check_category_table, set_category_set): Now static.

566 567 568
	* casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
	* lisp.h: Remove these decls.

569 570
	* buffer.c (buffer_count): Remove unused var.

571 572 573 574 575 576
	* bidi.c (bidi_dump_cached_states): Mark as externally visible,
	so that it's not optimized away.
	(bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
	* dispextern.h (bidi_dump_cached_states): Remove, since it's
	exported only to the debugger.

577 578 579
	* atimer.c (alarm_signal_handler, run_all_atimers): Now static.
	* atimer.h (run_all_atimers): Removed; not exported.

580 581 582 583 584 585
	font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
	* font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
	was inaccessible from Lisp.
	(merge_font_spec): Likewise, renaming from Fmerge_font_spec.
	* font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.

586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605
	alloc.c: Import and export fewer symbols, and remove unused items.
	* lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
	is defined.
	(suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
	it's not optimized away by whole-program optimization.
	(message_enable_multibyte, free_misc): Remove.
	(catchlist, handlerlist, mark_backtrace):
	Declare only if BYTE_MARK_STACK.
	(mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
	* alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
	(message_enable_multibyte): Remove decl.
	(free_misc, interval_free_list, float_block, float_block_index):
	(n_float_blocks, float_free_list, cons_block, cons_block_index):
	(cons_free_list, last_marked_index):
	Now static.
	(suppress_checking, die): Define only if ENABLE_CHECKING is defined.
	* eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
	(mark_backtrace): Define only if BYTE_MARK_STACK.
	* xdisp.c (message_enable_multibyte): Now static.

Glenn Morris's avatar
Glenn Morris committed
606
	Declare Lisp_Object Q* variables to be 'static' if not exported.
607 608 609 610 611 612 613 614 615 616 617 618 619 620 621
	This makes it easier for human readers (and static analyzers)
	to see whether these variables are used from other modules.
	* alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
	* ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
	* data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
	* font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
	* lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
	* sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
	* xmenu.c, xselect.c:
	Declare Q* vars static if they are not used in other modules.
	* ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
	* frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
	Remove decls of unexported vars.
	* keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.

622 623
	* lisp.h (DEFINE_FUNC): Make sname 'static'.

624 625 626 627 628
	Make Emacs functions such as Fatom 'static' by default.
	This makes it easier for human readers (and static analyzers)
	to see whether these functions can be called from other modules.
	DEFUN now defines a static function.  To make the function external
	so that it can be used in other C modules, use the new macro DEFUE.
Paul Eggert's avatar
Paul Eggert committed
629 630
	* lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
	(Finit_image_library):
631 632 633 634 635 636
	(Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
	(Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
	(Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
	Remove decls, since these functions are now static.
	(Funintern, Fget_internal_run_time): New decls, since these functions
	were already external.
637

638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678
	* alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
	* ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
	* doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
	* fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
	* keyboard.c, keymap.c, lread.c:
	* macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
	* syntax.c, term.c, terminal.c, textprop.c, undo.c:
	* window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
	Mark functions with DEFUE instead of DEFUN,
	if they are used in other modules.
	* buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
	decls for now-static functions.
	* buffer.h (Fdelete_overlay): Remove decl.
	* callproc.c (Fgetenv_internal): Mark as internal.
	* composite.c (Fremove_list_of_text_properties): Remove decl.
	(Fcomposition_get_gstring): New forward static decl.
	* composite.h (Fcomposite_get_gstring): Remove decl.
	* dired.c (Ffile_attributes): New forward static decl.
	* doc.c (Fdocumntation_property): New forward static decl.
	* eval.c (Ffetch_bytecode): New forward static decl.
	(Funintern): Remove extern decl; now in .h file where it belongs.
	* fileio.c (Fmake_symbolic_link): New forward static decl.
	* image.c (Finit_image_library): New forward static decl.
	* insdel.c (Fcombine_after_change_execute): Make forward decl static.
	* intervals.h (Fprevious_property_change):
	(Fremove_list_of_text_properties): Remove decls.
	* keyboard.c (Fthis_command_keys): Remove decl.
	(Fcommand_execute): New forward static decl.
	* keymap.c (Flookup_key): New forward static decl.
	(Fcopy_keymap): Now static.
	* keymap.h (Flookup_key): Remove decl.
	* process.c (Fget_process): New forward static decl.
	(Fprocess_datagram_address): Mark as internal.
	* syntax.c (Fsyntax_table_p): New forward static decl.
	(skip_chars): Remove duplicate decl.
	* textprop.c (Fprevious_property_change): New forward static decl.
	* window.c (Fset_window_fringes, Fset_window_scroll_bars):
	Now internal.
	(Fset_window_margins, Fset_window_vscroll): New forward static decls.
	* window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.

679 680
	* editfns.c (Fformat): Remove unreachable code.

681 682 683 684 685
2011-04-14  Andreas Schwab  <schwab@linux-m68k.org>

	* fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
	change.  (Bug#8496)

686 687 688 689 690
2011-04-13  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
	when at ZV.  (Bug#8487)

691 692
2011-04-12  Andreas Schwab  <schwab@linux-m68k.org>

693 694 695 696 697 698 699 700
	* charset.c (Fclear_charset_maps): Use xfree instead of free.
	(Bug#8437)
	* keyboard.c (parse_tool_bar_item): Likewise.
	* sound.c (sound_cleanup, alsa_close): Likewise.
	* termcap.c (tgetent): Likewise.
	* xfns.c (x_default_font_parameter): Likewise.
	* xsettings.c (read_and_apply_settings): Likewise.

701 702 703
	* alloc.c (overrun_check_malloc, overrun_check_realloc)
	(overrun_check_free): Protoize.

704 705 706 707 708 709 710 711
2011-04-12  Paul Eggert  <eggert@cs.ucla.edu>

	* sysdep.c (emacs_read, emacs_write): Check for negative sizes
	since callers should never pass a negative size.
	Change the signature to match that of plain 'read' and 'write'; see
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
	* lisp.h: Update prototypes of emacs_write and emacs_read.

712 713 714 715
2011-04-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't try to determine the character
	position of the scroll margin if the window start point w->startp
716
	is outside the buffer's accessible region.  (Bug#8468)
717

718 719 720 721 722 723 724 725 726 727 728 729 730 731
2011-04-10  Eli Zaretskii  <eliz@gnu.org>

	Fix write-region and its subroutines for buffers > 2GB.
	* fileio.c (a_write, e_write): Modify declaration of arguments and
	local variables to support buffers larger than 2GB.
	(Fcopy_file): Use EMACS_INT for return value of emacs_read.

	* sysdep.c (emacs_write, emacs_read): Use ssize_t for last
	argument, local variables, and return value.

	* lisp.h: Update prototypes of emacs_write and emacs_read.

	* sound.c (vox_write): Use ssize_t for return value of emacs_write.

Paul Eggert's avatar
Paul Eggert committed
732
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>
733

734 735
	* xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.

736 737
	Fix more problems found by GCC 4.6.0's static checks.

738 739
	* xdisp.c (vmessage): Use a better test for character truncation.

740 741
	* charset.c (load_charset_map): <, not <=, for optimization,
	and to avoid potential problems with integer overflow.
742
	* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
743
	* casetab.c (set_identity, shuffle): Likewise.
Paul Eggert's avatar
Paul Eggert committed
744
	* editfns.c (Fformat): Likewise.
745
	* syntax.c (skip_chars): Likewise.
746

747 748 749
	* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
	This also lets GCC 4.6.0 generate slightly better loop code.

750 751 752 753 754
	* callint.c (Fcall_interactively): <, not <=, for optimization.
	(Fcall_interactively): Count the number of arguments produced,
	not the number of arguments given.  This is simpler and lets GCC
	4.6.0 generate slightly better code.

755 756 757 758 759 760 761 762
	* ftfont.c: Distingish more carefully between FcChar8 and char.
	The previous code passed unsigned char * to a functions like
	strlen and xstrcasecmp that expect char *, which does not
	conform to the C standard.
	(get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
	arguments to FcPatternGetString, and explicitly cast FcChar8 * to
	char * when the C standard requires it.

763 764
	* keyboard.c (read_char): Remove unused var.

765 766 767 768 769 770 771 772 773
	* eval.c: Port to Windows vsnprintf (Bug#8435).
	Include <limits.h>.
	(SIZE_MAX): Define if the headers do not.
	(verror): Do not give up if vsnprintf returns a negative count.
	Instead, grow the buffer.  This ports to Windows vsnprintf, which
	does not conform to C99.  Problem reported by Eli Zaretskii.
	Also, simplify the allocation scheme, by avoiding the need for
	calling realloc, and removing the ALLOCATED variable.

774 775
	* eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

776 777 778
	Remove invocations of doprnt, as Emacs now uses vsnprintf.
	But keep the doprint source code for now, as we might revamp it
	and use it again (Bug#8435).
779 780 781 782
	* lisp.h (doprnt): Remove.
	* Makefile.in (base_obj): Remove doprnt.o.
	* deps.mk (doprnt.o): Remove.

783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804
	error: Print 32- and 64-bit integers portably (Bug#8435).
	Without this change, on typical 64-bit hosts error ("...%d...", N)
	was used to print both 32- and 64-bit integers N, which relied on
	undefined behavior.
	* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
	New macro.
	* lisp.h (error, verror): Mark as printf-like functions.
	* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
	Report overflow in size calculations when allocating printf buffer.
	Do not truncate output string at its first null byte.
	* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
	Truncate the output at a character boundary, since vsnprintf does not
	do that.
	* charset.c (check_iso_charset_parameter): Convert internal
	character to string before calling 'error', since %c now has the
	printf meaning.
	* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
	overflow when computing char to be passed to 'error'.  Do not
	pass Lisp_Object to 'error'; pass the integer instead.
	* nsfns.m (Fns_do_applescript): Use int, not long, since it's
	formatted with plain %d.

805 806
	* eval.c (internal_lisp_condition_case): Don't pass spurious arg.

807 808
	* keyboard.c (access_keymap_keyremap): Print func name, not garbage.

809 810
	* coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

811 812
	* xterm.c (x_catch_errors): Remove duplicate declaration.

813 814
	* term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

815 816
	* xdisp.c, lisp.h (message_nolog): Remove; unused.

817 818 819 820 821 822 823 824 825 826
2011-04-10  Jim Meyering  <meyering@redhat.com>

	use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
	* gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
	return ssize_t not "int", and use size_t as the buffer length.
	(emacs_gnutls_write): Likewise, and make the buffer pointer "const".
	* gnutls.h: Update declarations.
	* process.c (read_process_output): Use ssize_t, to match.
	(send_process): Likewise.

827 828 829 830
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

	* image.c (Fimagemagick_types): Doc fix, and comment cleanup.

831
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>
832

833 834
	* ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
	unsigned char, to match FcChar8 type definition.
835

836 837 838 839
	* xterm.c (handle_one_xevent):
	* xmenu.c (create_and_show_popup_menu):
	* xselect.c (x_decline_selection_request)
	(x_reply_selection_request): Avoid type-punned deref of X events.
840

841
2011-04-09  Eli Zaretskii  <eliz@gnu.org>
842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881

	Fix some uses of `int' instead of EMACS_INT.
	* search.c (string_match_1, fast_string_match)
	(fast_c_string_match_ignore_case, fast_string_match_ignore_case)
	(scan_buffer, find_next_newline_no_quit)
	(find_before_next_newline, search_command, Freplace_match)
	(Fmatch_data): Make some `int' variables be EMACS_INT.

	* xdisp.c (display_count_lines): 3rd argument and return value now
	EMACS_INT.  All callers changed.
	(pint2hrstr): Last argument is now EMACS_INT.

	* coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
	(detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
	(decode_coding_utf_16, decode_coding_emacs_mule)
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
	(decode_coding_ccl, decode_coding_charset)
	<consumed_chars, consumed_chars_base>: Declare EMACS_INT.
	(decode_coding_iso_2022, decode_coding_emacs_mule)
	(decode_coding_sjis, decode_coding_big5, decode_coding_charset)
	<char_offset, last_offset>: Declare EMACS_INT.
	(encode_coding_utf_8, encode_coding_utf_16)
	(encode_coding_emacs_mule, encode_invocation_designation)
	(encode_designation_at_bol, encode_coding_iso_2022)
	(encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
	(encode_coding_raw_text, encode_coding_charset) <produced_chars>:
	Declare EMACS_INT.
	(ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
	(encode_invocation_designation): Last argument P_NCHARS is now
	EMACS_INT.
	(decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
	(produce_chars): from_nchars and to_nchars are now EMACS_INT.

	* coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
	All users changed.

	* ccl.c (Fccl_execute_on_string): Declare some variables
	EMACS_INT.

882
2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)
883 884 885

	* term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

886 887 888 889
2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

	* process.c (Fformat_network_address): Doc fix.

890 891 892 893
2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

	* xml.c (parse_region): Avoid creating spurious whiespace nodes.

894 895 896 897 898
2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (read_char): Call Lisp function help-form-show,
	instead of using internal_with_output_to_temp_buffer.
	(Qhelp_form_show): New var.
899
	(syms_of_keyboard): Use DEFSYM macro.
900 901 902 903 904

	* print.c (internal_with_output_to_temp_buffer): Function deleted.

	* lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

905 906 907 908 909
2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (Flist_processes): Removed to Lisp.
	(list_processes_1): Deleted.

910 911
2011-04-06  Eli Zaretskii  <eliz@gnu.org>

912 913
	* msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

914 915
	* w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

916
2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
917

Paul Eggert's avatar
Paul Eggert committed
918 919
	Fix more problems found by GCC 4.6.0's static checks.

920 921
	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

922 923
	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

924
	* lisp.h (message, message_nolog, fatal): Mark as printf-like.
925

926 927
	* xdisp.c (vmessage): Mark as a printf-like function.

928 929
	* term.c (vfatal, maybe_fatal): Mark as printf-like functions.

930 931
	* sound.c (sound_warning): Don't crash if arg contains a printf format.

932 933 934 935 936
	* image.c (tiff_error_handler, tiff_warning_handler): Mark as
	printf-like functions.
	(tiff_load): Add casts to remove these marks before passing them
	to system-supplied API.

937 938
	* eval.c (Fsignal): Remove excess argument to 'fatal'.

939 940
	* coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
	This avoids several warnings with gcc -Wstrict-overflow.
941 942 943 944 945 946
	(DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
	directly, rather than having caller test rule sign.  This avoids
	some unnecessary tests.
	* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
	(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
	affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
947

948
	* xfont.c (xfont_text_extents): Remove var that was set but not used.
949
	(xfont_open): Avoid unnecessary tests.
950

951 952
	* composite.c (composition_gstring_put_cache): Use unsigned integer.

953 954 955
	* composite.h, composite.c (composition_gstring_put_cache):
	Use EMACS_INT, not int, for length.

956 957 958 959 960 961
	* composite.h (COMPOSITION_DECODE_REFS): New macro,
	breaking out part of COMPOSITION_DECODE_RULE.
	(COMPOSITION_DECODE_RULE): Use it.
	* composite.c (get_composition_id): Remove unused local vars,
	by using the new macro.

962 963 964
	* textprop.c (set_text_properties_1): Change while to do-while,
	since the condition is always true at first.

965
	* intervals.c (graft_intervals_into_buffer): Mark var as used.
966 967
	(interval_deletion_adjustment): Return unsigned value.
	All uses changed.
968

969 970
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
971
	(create_pty): Remove unnecessary "volatile"s.
972
	(Fnetwork_interface_info): Avoid possibility of int overflow.
973
	(read_process_output): Do adaptive read buffering even if carryover.
974
	(read_process_output): Simplify nbytes computation if buffered.
975

976 977
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

978
	* syntax.c (scan_words): Remove var that was set but not used.
979
	(update_syntax_table): Use unsigned instead of int.
980

981
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
982
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
983
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
984

985 986
	* print.c (print_error_message): Avoid int overflow.

987 988 989
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

990
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
991
	(font_score): Avoid potential overflow in diff calculation.
992

993
	* fns.c (substring_both): Remove var that is set but not used.
994
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
995

996 997
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

998 999 1000 1001
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

1002
	* search.c (boyer_moore, wordify): Remove vars set but not used.
1003
	(wordify): Omit three unnecessary tests.
1004

1005 1006 1007
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

1008 1009
	* casefiddle.c (casify_region): Remove var that is set but not used.

1010 1011
	* dired.c (file_name_completion): Remove var that is set but not used.

1012 1013
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

1014
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1015
	(Finsert_file_contents): Remove unnecessary code checking fd.
1016

1017 1018 1019
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

1020 1021 1022
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

1023 1024
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
1025
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1026
	(timer_check_2): Mark vars as initialized.
1027

1028 1029
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

1030
	* image.c (lookup_image): Remove var that is set but not used.
1031
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1032

1033 1034 1035
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

1036
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
1037
	if XCreateBitmapFromData fails (Bug#8410).
1038

1039 1040 1041
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

1042
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
1043
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
1044

1045 1046
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
1047 1048 1049
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
1050

1051 1052 1053
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

1054 1055
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

1056 1057 1058 1059 1060 1061 1062
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

1063 1064 1065
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

1066 1067
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
1068
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1069 1070 1071 1072 1073 1074 1075 1076
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
1077 1078
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
1079

1080 1081 1082 1083 1084
2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
	first non-nil return value).

1085 1086 1087 1088 1089
2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
	if not defined (Bug#8403).

1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (display_count_lines): Remove parameter `start',
	unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(get_char_face_and_encoding): Remove parameter `multibyte_p',
	unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
	(fill_stretch_glyph_string): Remove parameters `row' and `area',
	unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
	and thereabouts.  All callers changed.
	(get_per_char_metric): Remove parameter `f', unused since
	2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

1102 1103 1104 1105 1106 1107
2011-04-02  Jim Meyering  <meyering@redhat.com>

	do not dereference NULL upon failed strdup
	* nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
	(ns_get_family): Likewise.

1108 1109 1110 1111
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

1112 1113 1114 1115 1116
2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
	later (Bug#8403).

1117 1118
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

1119
	Add lexical binding.
1120

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
1138 1139 1140

	* image.c (parse_image_spec): Use Ffunctionp.

1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158
	* fns.c (concat, mapcar1): Accept byte-code-functions.

	* eval.c (Fsetq): Handle lexical vars.
	(Fdefun, Fdefmacro, Ffunction): Make closures when needed.
	(Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
	(FletX, Flet): Obey lexical binding.
	(Fcommandp): Handle closures.
	(Feval): New `lexical' arg.
	(eval_sub): New function extracted from Feval.  Use it almost
	everywhere where Feval was used.  Look up vars in lexical env.
	Handle closures.
	(Ffunctionp): Move from subr.el.
	(Ffuncall): Handle closures.
	(apply_lambda): Remove `eval_flags'.
	(funcall_lambda): Handle closures and new byte-code-functions.
	(Fspecial_variable_p): New function.
	(syms_of_eval): Initialize the Vinternal_interpreter_environment var,
	but without exporting it to Lisp.
1159 1160

	* doc.c (Fdocumentation, store_function_docstring):
1161
	* data.c (Finteractive_form): Handle closures.
1162

1163 1164
	* callint.c (Fcall_interactively): Preserve lexical-binding mode for
	interactive spec.
1165

1166 1167 1168 1169
	* bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
	byte-codes.
	(exec_byte_code): New function extracted from Fbyte_code to handle new
	calling convention for byte-code-functions.  Add new byte-codes.
1170

1171
	* buffer.c (defvar_per_buffer): Set new `declared_special' field.
1172

1173
	* alloc.c (Fmake_symbol): Init new `declared_special' field.
1174

1175 1176 1177 1178
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (redisplay_internal): Fix prototype.

1179
2011-03-31  Eli Zaretskii  <eliz@gnu.org>
1180

1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197
	* xdisp.c (SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.  Limit
	scrolling to 100 screen lines.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

	(try_scrolling): When point is above the window, allow searching
	as far as scroll_max, or one screenful, to compute vertical
	distance from PT to the scroll margin position.  This prevents
	try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.  Clean up the case of PT below the margin at bottom
	of window: scroll_max can no longer be INT_MAX.  When aggressive
	scrolling is in use, don't let point enter the opposite scroll
	margin as result of the scroll.
	(syms_of_xdisp) <scroll-conservatively>: Document the
1198 1199
	threshold of 100 lines for never-recentering scrolling.

1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (move_it_by_lines):
	* xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
	since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
	(message_log_check_duplicate): Remove parameters `prev_bol' and
	`this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(redisplay_internal): Remove parameter `preserve_echo_area',
	unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

	* indent.c (Fvertical_motion):
	* window.c (window_scroll_pixel_based, Frecenter):
	Don't pass `need_y_p' to `move_it_by_lines'.

1214 1215
2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

1216 1217 1218 1219 1220
	* eval.c (struct backtrace): Don't cheat with negative numbers, but do
	steal a few bits to be more compact.
	(interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
	Remove unneeded casts.

1221 1222
	* bytecode.c (Fbyte_code): CAR and CDR can GC.

1223 1224 1225