ChangeLog 144 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
2011-07-19  Eli Zaretskii  <eliz@gnu.org>

	Fix a significant slow-down of vertical-motion when leaning on C-n
	or C-p in a fontified buffer.
	* xdisp.c (reseat): Don't look for prev_stop, as that could mean a
	very long run.
	(next_element_from_buffer): When iterator oversteps prev_pos
	backwards, don't search for a new prev_stop more than 1000
	characters back.
	(handle_stop_backwards): Don't assume that CHARPOS is necessarily
	a stop_pos.
	(compute_display_string_pos): Check also BUF_OVERLAY_MODIFF for a
	match, when testing the cached display string position for
	applicability.

16 17 18 19 20 21 22
2011-07-16  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>:
	Cache for last found display string position.
	(compute_display_string_pos): Return the cached position if asked
	about the same buffer.

23 24 25 26 27 28 29 30
2011-07-14  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_cache_fetch_state, bidi_cache_search)
	(bidi_cache_find_level_change, bidi_cache_ensure_space)
	(bidi_cache_iterator_state, bidi_cache_find)
	(bidi_find_other_level_edge, bidi_cache_start_stack): All
	variables related to cache indices are now EMACS_INT.

31 32
2011-07-09  Eli Zaretskii  <eliz@gnu.org>

33 34 35
	* bidi.c (bidi_fetch_char): Fix the type of `len' according to
	what STRING_CHAR_AND_LENGTH expects.

36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51
	* xdisp.c (move_it_in_display_line_to): Record prev_method and
	prev_pos immediately before the call to set_iterator_to_next.
	Fixes cursor motion in bidi-reordered lines with stretch glyphs
	and strings displayed in margins.  (Bug#8133)  (Bug#8867)
	Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
	TO_CHARPOS.
	(pos_visible_p): Support positions in bidi-reordered lines.  Save
	and restore bidi cache.

2011-07-08  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (move_it_in_display_line_to): If iterator ended up at
	EOL, but we never saw any buffer positions smaller than
	to_charpos, return MOVE_POS_MATCH_OR_ZV.  Fixes vertical cursor
	motion in bidi-reordered lines.

52 53 54 55 56
2011-07-07  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (find_row_edges): If ROW->start.pos gives position
	smaller than min_pos, use it as ROW->minpos.  (Bug#7616)

57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73
2011-07-05  Eli Zaretskii  <eliz@gnu.org>

	* dispnew.c (buffer_posn_from_coords): Save and restore the bidi
	cache around display iteration.

	* window.c (Fwindow_end, window_scroll_pixel_based)
	(displayed_window_lines, Frecenter): Save and restore the bidi
	cache around display iteration.

	* bidi.c (bidi_unshelve_cache): Ensure we have enough space before
	restoring the shelved cache.
	(bidi_cache_ensure_space): Don't assume the required size is just
	one BIDI_CACHE_CHUNK away.

	* xdisp.c (back_to_previous_visible_line_start, reseat_1)
	(init_iterator): Empty the bidi cache "stack".

74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
2011-07-03  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.

	* dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
	prototypes.

	* xdisp.c (SAVE_IT, RESTORE_IT): New macros.
	(pos_visible_p, face_before_or_after_it_pos)
	(back_to_previous_visible_line_start)
	(move_it_in_display_line_to, move_it_in_display_line)
	(move_it_to, move_it_vertically_backward, move_it_by_lines)
	(try_scrolling, redisplay_window, display_line): Use them when
	saving a temporary copy of the iterator and restoring it back.

89 90
2011-07-02  Eli Zaretskii  <eliz@gnu.org>

91
	* xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
92
	iterator with IT's position.  (Bug#7616)
93 94 95 96 97 98 99 100
	(handle_stop, back_to_previous_visible_line_start, reseat_1):
	Reset the from_disp_prop_p flag.

	* bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
	always valid if bidi_cache_idx is valid.
	(bidi_cache_find_level_change): xassert that bidi_cache_last_idx
	is valid if it's going to be used.

101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116
	* dispextern.h (struct iterator_stack_entry, struct it): New
	member from_disp_prop_p.

	* xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
	(handle_single_display_spec, push_display_prop): Set the
	from_disp_prop_p flag.
	(get_overlay_strings_1): Reset the from_disp_prop_p flag.
	(pop_it): Call iterate_out_of_display_property only if we are
	popping after iteration over a string that came from a display
	property.  Fix a typo in popping stretch info.  Add an assertion
	for verifying that the iterator position is in sync with the bidi
	iterator.
	(handle_single_display_spec, get_overlay_strings_1)
	(push_display_prop): Fix initialization of paragraph direction for
	string when that of the parent object is not yet determined.

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
2011-07-01  Eli Zaretskii  <eliz@gnu.org>

	* dispextern.h (struct bidi_string_data): New member `unibyte'.

	* xdisp.c (handle_single_display_spec, next_overlay_string)
	(get_overlay_strings_1, reseat_1, reseat_to_string)
	(push_display_prop): Set up the `unibyte' member of bidi_it.string
	correctly.  Don't assume unibyte strings are not bidi-reordered.
	(compute_display_string_pos)
	(compute_display_string_end): Fix handling the case of C string.

	* bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
	additional argument UNIBYTE, and support unibyte strings.  All
	callers changed.
	(bidi_fetch_char): Support unibyte strings.

133 134
2011-06-25  Eli Zaretskii  <eliz@gnu.org>

135 136 137 138 139 140 141 142 143 144 145 146 147 148
	* xdisp.c (set_iterator_to_next, get_visually_first_element): Use
	it->bidi_it.string.schars rather than it->string_nchars when
	testing whether we're beyond string end, because string_nchars is
	zero for strings that come from overlays and display properties.

	* bidi.c (bidi_cache_iterator_state): Fix a bug with testing
	character positions against the cached range, when we use a
	stacked cache.

	* xdisp.c (push_it, pop_it): Save and restore it.

	* dispextern.h (struct iterator_stack_entry): New member
	paragraph_embedding.

149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
	* xdisp.c (handle_single_display_spec, next_overlay_string)
	(get_overlay_strings_1, push_display_prop): Set up the bidi
	iterator for displaying display or overlay strings.
	(forward_to_next_line_start): Don't use the shortcut if
	bidi-iterating.
	(back_to_previous_visible_line_start): If handle_display_prop
	pushed the iterator stack, restore the internal state of the bidi
	iterator by calling bidi_pop_it same number of times.
	(reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
	and we are bidi-iterating, don't decrement the iterator position;
	instead, set the first_elt flag in the bidi iterator, to produce
	the same effect.
	(reseat_1): Remove redundant setting of string_from_display_prop_p.
	(push_display_prop): xassert that we are iterating a buffer.

	* bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.

2011-06-24  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (push_it, pop_it): Save and restore the state of the
	bidi iterator.  Save and restore the bidi_p flag.
	(pop_it): Iterate out of display property for string iteration as
	well.
	(iterate_out_of_display_property): Support iteration over strings.
	(handle_single_display_spec): Set up it->bidi_it for iteration
	over a display string, and call bidi_init_it.

	* dispextern.h (struct iterator_stack_entry): New member bidi_p.
	(struct it): Member bidi_p is now a bit field 1 bit wide.

179 180 181 182 183 184 185 186 187
2011-06-23  Eli Zaretskii  <eliz@gnu.org>

	* dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.

	* bidi.c (bidi_push_it, bidi_pop_it): New functions.
	(bidi_initialize): Initialize the bidi cache start stack pointer.
	(bidi_cache_ensure_space): New function, refactored from part of
	bidi_cache_iterator_state.

188 189
2011-06-18  Eli Zaretskii  <eliz@gnu.org>

190 191 192 193 194 195 196
	* xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
	(display_menu_bar): Force left-to-right direction.  Add a FIXME
	comment for making that be controlled by a user option.

	* bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
	are iterating.

197 198 199 200
	* term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
	it->what accepted by the xassert.  Fixes a gratuitous crash in an
	Emacs built with -DXASSERTS.

201 202 203 204
	* .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
	(xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
	and vector-like objects.

205
	* xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
206 207
	(next_element_from_c_string): Handle the case of the first string
	character that is not the first one in the visual order.
208 209 210
	(get_visually_first_element): New function, refactored from common
	parts of next_element_from_buffer, next_element_from_string, and
	next_element_from_c_string.
211

212 213 214 215 216 217 218 219 220 221 222 223 224
2011-06-16  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
	here.
	(reseat_to_string): Initialize it->bidi_p for strings here.
	(next_element_from_string, next_element_from_c_string)
	(next_element_from_buffer): Add xassert's for correspondence
	between IT's object being iterated and it->bidi_it.string
	structure.

	* bidi.c (bidi_level_of_next_char): Fix the logic for looking up
	the sentinel state in the cache.

225 226 227 228 229 230 231 232 233 234 235
2011-06-13  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (compute_display_string_pos)
	(compute_display_string_end, reseat_to_string): Don't assume
	it->bidi_it.string.s always points to string.lstring's data.

	* bidi.c (bidi_fetch_char, bidi_paragraph_init)
	(bidi_resolve_explicit_1, bidi_resolve_explicit)
	(bidi_resolve_weak, bidi_level_of_next_char): Don't assume
	string.s always points to string.lstring's data.

236 237 238 239 240
2011-06-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (set_iterator_to_next): Advance string position
	correctly when padding it with blanks.

241 242 243 244
2011-06-11  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (next_element_from_buffer): Improve commentary for when
	the iterator is before prev_stop.
245 246 247 248 249 250 251 252 253 254 255 256 257 258 259
	(init_iterator): Initialize bidi_p from the default value of
	bidi-display-reordering, not from buffer-local value.  Use the
	buffer-local value only if initializing for buffer iteration.
	(handle_invisible_prop): Support invisible properties on strings
	that are being bidi-reordered.
	(reseat_to_string): Enable bidi-related code.
	(set_iterator_to_next): Support bidi reordering of C strings and
	Lisp strings.
	(next_element_from_string): Support bidi reordering of Lisp
	strings.
	(handle_stop_backwards): Support Lisp strings as well.
	(display_mode_line, display_mode_element): Temporarily force L2R
	paragraph direction.
	(display_string): Support display of R2L glyph rows.  Use
	IT_STRING_CHARPOS when displaying from a Lisp string.
260

261 262 263 264 265 266 267 268 269 270 271
2011-06-10  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
	itb.string.lstring.
	(compute_display_string_pos, compute_display_string_end):
	Fix calculation of the object to scan.  Fixes an error when using
	arrow keys.
	(next_element_from_buffer): Don't abort when IT_CHARPOS is before
	base_level_stop; instead, set base_level_stop to BEGV.  Fixes
	crashes in vertical-motion.

272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288
2011-06-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (compute_display_string_pos): First arg is now struct
	`text_pos *'; all callers changed.  Support display properties on
	Lisp strings.
	(compute_display_string_end): Support display properties on Lisp
	strings.
	(init_iterator, reseat_1, reseat_to_string): Initialize the
	string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
	when iterating on a string not from display properties).

	* bidi.c (bidi_fetch_char): Support strings with display
	properties.

	* dispextern.h (struct bidi_string_data): New member bufpos.
	(compute_display_string_pos): Update prototype.

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
2011-06-09  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
	to pass the test for valid cached positions.

	* xdisp.c (init_iterator): Call bidi_init_it only of a valid
	buffer position was specified.  Initialize paragraph_embedding to
	L2R.
	(reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
	out).
	(display_string): If we need to ignore text properties of
	LISP_STRING, set IT->stop_charpos to IT->end_charpos.  (The
	original value of -1 will not work with bidi.)

	* dispextern.h (struct bidi_string_data): New member lstring.

305 306 307 308 309
2011-06-09  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
	itb.string.s to NULL (avoids a crash in bidi_paragraph_init).

310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
2011-06-08  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_paragraph_info): Delete unused struct.
	(bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
	(bidi_cache_start): New variable.
	(bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
	to zero.
	(bidi_cache_fetch_state, bidi_cache_search)
	(bidi_cache_find_level_change, bidi_cache_iterator_state)
	(bidi_cache_find, bidi_peek_at_next_level)
	(bidi_level_of_next_char, bidi_find_other_level_edge)
	(bidi_move_to_visually_next): Compare cache index with
	bidi_cache_start rather than with zero.
	(bidi_fetch_char): Accept new argument STRING; all callers
	changed.  Support iteration over a string.
	(bidi_paragraph_init, bidi_resolve_explicit_1)
	(bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next): Support
	iteration over a string.
	(bidi_set_sor_type, bidi_resolve_explicit_1)
	(bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
	can now be zero (for strings); special values 0 and -1 were
	changed to -1 and -2, respectively.
	(bidi_char_at_pos): New function.
	(bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
	Call it instead of FETCH_MULTIBYTE_CHAR.
	(bidi_move_to_visually_next): Abort if charpos or bytepos were not
	initialized to valid values.
	(bidi_init_it): Don't initialize charpos and bytepos with invalid
	values.

	* xdisp.c (compute_display_string_pos)
	(compute_display_string_end): Accept additional argument STRING.
	(init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
	(reseat_to_string): Initialize bidi_it->string.s and
	bidi_it->string.schars.

	* dispextern.h (struct bidi_string_data): New structure.
	(struct bidi_it): New member `string'.  Make flag members be 1-bit
	fields, and put them last in the struct.
	(compute_display_string_pos, compute_display_string_end): Update
	prototypes.

353 354 355 356
2011-06-04  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.

357 358 359 360 361
2011-06-03  Eli Zaretskii  <eliz@gnu.org>

	* bidi.c (bidi_fetch_char_advance): Remove unused and
	unimplemented function.

362 363
2011-05-28  Eli Zaretskii  <eliz@gnu.org>

364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381
	* xdisp.c (set_cursor_from_row): Set start and stop points
	according to the row's direction when priming the loop that looks
	for the glyph on which to display cursor.
	(single_display_spec_intangible_p): Function deleted.
	(display_prop_intangible_p): Reimplement to call
	handle_display_spec instead of single_display_spec_intangible_p.
	Accept 3 additional arguments needed by handle_display_spec.  This
	fixes incorrect cursor motion across display property with complex
	values: lists, `(when COND...)' forms, etc.
	(single_display_spec_string_p): Support property values that are
	lists with the argument STRING its top-level element.
	(display_prop_string_p): Fix the condition for processing a
	property that is a list to be consistent with handle_display_spec.

	* keyboard.c (adjust_point_for_property): Adjust the call to
	display_prop_intangible_p to its new signature.

	* dispextern.h (display_prop_intangible_p): Adjust prototype.
382

383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
2011-05-21  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (handle_display_spec): New function, refactored from the
	last portion of handle_display_prop.
	(compute_display_string_pos): Accept additional argument
	FRAME_WINDOW_P.  Call handle_display_spec to determine whether the
	value of a `display' property is a "replacing spec".
	(handle_single_display_spec): Accept 2 additional arguments BUFPOS
	and FRAME_WINDOW_P.  If IT is NULL, don't set up the iterator from
	the display property, but just return a value indicating whether
	the display property will replace the characters it covers.
	(Fcurrent_bidi_paragraph_direction): Initialize the nchars and
	frame_window_p members of struct bidi_it.

	* bidi.c (bidi_fetch_char): Accept additional argument
	FRAME_WINDOW_P and pass it to compute_display_string_pos.  All
	callers changed.
	(bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
	it to initialize the frame_window_p member of struct bidi_it.

	* dispextern.h (struct bidi_it): New member frame_window_p.
	(bidi_init_it, compute_display_string_pos): Update prototypes.

406 407
2011-05-14  Eli Zaretskii  <eliz@gnu.org>

408 409
	* xdisp.c (compute_display_string_pos): Non-trivial implementation.
	(compute_display_string_end): New function.
410 411
	(push_it): Accept second argument POSITION, where pop_it should
	jump to continue iteration.
412 413 414 415 416 417 418

	* dispextern.h (compute_display_string_end): Declare prototype.

	* bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
	(bidi_fetch_char): Implement support for runs of characters
	covered by display strings.

419
	* bidi.c (bidi_fetch_char): Accept also character position
420 421
	corresponding to BYTEPOS.  DISP_POS is now a character position,
	not a byte position.  All callers changed.
422 423 424 425 426 427 428 429 430 431 432
	(bidi_cache_iterator_state, bidi_resolve_explicit_1)
	(bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
	bidi_it->nchars is non-positive.
	(bidi_level_of_next_char): Don't try to lookup the cache for the
	next/previous character if nothing is cached there yet, or if we
	were just reseat()'ed to a new position.
	(bidi_paragraph_init, bidi_resolve_explicit_1)
	(bidi_level_of_next_char): Fix arguments in the calls to
	bidi_fetch_char.

433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
2011-05-10  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (compute_display_string_pos): New function.
	(reseat_1): Initialize bidi_it.disp_pos.

	* bidi.c (bidi_copy_it): Use offsetof.
	(bidi_fetch_char, bidi_fetch_char_advance): New functions.
	(bidi_cache_search, bidi_cache_iterator_state)
	(bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
	(bidi_level_of_next_char, bidi_move_to_visually_next): Support
	character positions inside a run of characters covered by a
	display string.
	(bidi_paragraph_init, bidi_resolve_explicit_1)
	(bidi_level_of_next_char): Call bidi_fetch_char and
	bidi_fetch_char_advance instead of FETCH_CHAR and
	FETCH_CHAR_ADVANCE.
	(bidi_init_it): Initialize new members.
	(LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
	definitions.
	(bidi_explicit_dir_char): Lookup character type in bidi_type_table,
	instead of using explicit *_CHAR codes.
	(bidi_resolve_explicit, bidi_resolve_weak): Use
	FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
	bidirectional text is supported only in multibyte buffers.

	* dispextern.h (struct bidi_it): New members nchars and disp_pos.
	ch_len is now EMACS_INT.
	(compute_display_string_pos): Declare prototype.

462 463 464 465
2011-05-09  Andreas Schwab  <schwab@linux-m68k.org>

	* w32menu.c (set_frame_menubar): Fix submenu allocation.

466 467
2011-05-07  Eli Zaretskii  <eliz@gnu.org>

468 469 470 471
	* w32console.c (Fset_screen_color): Doc fix.
	(Fget_screen_color): New function.
	(syms_of_ntterm): Defsubr it.

472 473 474 475 476 477 478 479
	* callproc.c (call_process_cleanup): Don't close and unlink the
	temporary file if Fcall_process didn't create it in the first
	place.
	(Fcall_process): Don't create tempfile if stdout of the child
	process will be redirected to a file specified with `:file'.
	Don't try to re-open tempfile in that case, and set fd[0] to -1 as
	cue to call_process_cleanup not to close that handle.

480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
2011-05-07  Ben Key  <bkey76@gmail.com>

	* makefile.w32-in: The bootstrap-temacs rule now makes use of
	one of two shell specific rules, either bootstrap-temacs-CMD or
	bootstrap-temacs-SH.  The bootstrap-temacs-SH rule is identical
	to the previous implementation of the bootstrap-temacs rule.
	The bootstrap-temacs-CMD rule is similar to the previous
	implementation of the bootstrap-temacs rule except that it
	makes use of the ESC_CFLAGS variable instead of the CFLAGS
	variable.

	These changes, along with some changes to nt/configure.bat,
	nt/gmake.defs, and nt/nmake.defs, are required to extend my
	earlier fix to add support for --cflags and --ldflags options
	that include quotes so that it works whether make uses cmd or
	sh as the shell.

497 498 499 500 501 502 503 504 505 506
2011-05-06  Michael Albinus  <michael.albinus@gmx.de>

	* dbusbind.c (QCdbus_type_unix_fd): Declare static.
	(xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
	is a constant.
	(Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
	a string.  Handle both cases.
	(Fdbus_call_method_asynchronously, Fdbus_register_signal)
	(Fdbus_register_method): Use Qinvalid_function.

507 508 509 510 511 512
2011-05-06  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.
	(LISP_H): Add inttypes.h and stdin.h.
	(PROCESS_H): Add unistd.h.

513 514 515 516 517
2011-05-06  Eli Zaretskii  <eliz@gnu.org>

	* lread.c: Include limits.h (fixes the MS-Windows build broken by
	2011-05-06T07:13:19Z!eggert@cs.ucla.edu).

Paul Eggert's avatar
Paul Eggert committed
518
2011-05-06  Paul Eggert  <eggert@cs.ucla.edu>
519

520 521
	* image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.

522 523 524
	* term.c (vfatal): Remove stray call to va_end.
	It's not needed and the C Standard doesn't allow it here anyway.

525 526 527
	Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
	* eval.c (verror): doprnt a copy of ap, not the original.  (Bug#8545)

528 529 530
	* eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
	bytes.

531 532
	* term.c: Don't include <stdarg.h>, as <lisp.h> does that.

533 534
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.

535 536
	* process.c (Fformat_network_address): Fix typo: args2 -> *args2.

537 538
	* xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).

539 540
	* coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).

541 542 543
	* charset.h (struct charset.code_space): Now has 15 elements, not 16.
	* charset.c (Fdefine_charset_internal): Don't initialize
	charset.code_space[15].  The value was garbage, on hosts with
Paul Eggert's avatar
Paul Eggert committed
544
	32-bit int (Bug#8600).
545 546 547 548 549 550 551

	* lread.c (read_integer): Be more consistent with string-to-number.
	Use string_to_number to do the actual conversion; this avoids
	rounding errors and fixes some other screwups.  Without this fix,
	for example, #x1fffffffffffffff was misread as -2305843009213693952.
	(digit_to_number): Move earlier, for benefit of read_integer.
	Return -1 if the digit is out of range for the base, -2 if it is
Paul Eggert's avatar
Paul Eggert committed
552
	not a digit in any supported base.  (Bug#8602)
553

554 555
	* doprnt.c (doprnt): Support arbitrary pI values, such as "I64".

556 557 558 559
	* dispnew.c (scrolling_window): Return 1 if we scrolled,
	to match comment at start of function.  This also removes a
	GCC warning about overflow in a 32+64-bit port.

560 561
	* lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.

562 563 564 565 566 567
	* dbusbind.c: Do not use XPNTR on a value that may be an integer.
	Reported by Stefan Monnier in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
	(xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
	SYMBOLP-guarded XSYMBOL, not XPNTR.

568 569 570
	* lisp.h (EMACS_INTPTR): Remove.  All uses changed to intptr_t.
	(EMACS_UINTPTR): Likewise, with uintptr_t.

571 572 573 574
	* lisp.h: Prefer 64-bit EMACS_INT if available.
	(EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
	on 32-bit hosts that have 64-bit int, so that they can access
	large files.
575 576
	However, temporarily disable this change unless the temporary
	symbol WIDE_EMACS_INT is defined.
577

578 579
	* lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.

580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609
	Prefer intptr_t/uintptr_t for integers the same widths as pointers.
	This removes an assumption that EMACS_INT and long are the same
	width as pointers.  The assumption is true for Emacs porting targets
	now, but we want to make other targets possible.
	* lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
	(EMACS_INTPTR, EMACS_UINTPTR): New macros.
	In the rest of the code, change types of integers that hold casted
	pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
	replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
	(XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
	(XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
	No need to cast type when ORing.
	(XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
	* alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
	* doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
	assume EMACS_INT is the same width as char *.
	* gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
	(xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
	Remove no-longer-needed casts.
	(xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
	(xg_tool_bar_help_callback, xg_make_tool_item):
	Use EMACS_INTPTR to hold an integer
	that will be cast to void *; this can avoid a GCC warning
	if EMACS_INT is not the same width as void *.
	* menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
	* xdisp.c (display_echo_area_1, resize_mini_window_1):
	(current_message_1, set_message_1):
	Use a local to convert to proper width without a cast.
	* xmenu.c (dialog_selection_callback): Likewise.

610 611 612 613 614 615
	* sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
	Also, don't assume VALBITS / RAND_BITS is less than 5,
	and don't rely on undefined behavior when shifting a 1 left into
	the sign bit.
	* lisp.h (get_random): Change signature to match.

616 617 618 619 620 621 622 623
	* lread.c (hash_string): Use size_t, not int, for hash computation.
	Normally we prefer signed values; but hashing is special, because
	it's better to use unsigned division on hash table sizes so that
	the remainder is nonnegative.  Also, size_t is the natural width
	for hashing into memory.  The previous code used 'int', which doesn't
	retain enough info to hash well into very large tables.
	(oblookup, oblookup_last_bucket_number, Funintern): Likewise.

624 625 626 627 628
	* dbusbind.c: Don't possibly lose pointer info when converting.
	(xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
	Use XPNTR rather than XHASH, so that the high-order bits of
	the pointer aren't lost when converting through void *.

629 630
	* eval.c (Fautoload): Don't double-shift a pointer.

631 632
	* fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.

633 634 635 636 637
2011-05-06  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (DEF_GNUTLS_FN):
	* image.c (DEF_IMGLIB_FN): Make function pointers static.

638 639 640 641 642
2011-05-05  Andreas Schwab  <schwab@linux-m68k.org>

	* lread.c (lisp_file_lexically_bound_p): Stop scanning at end
	marker.  (Bug#8610)

643
2011-05-05 Eli Zaretskii  <eliz@gnu.org>
644 645 646 647

	* w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
	New version that can reserve upto 2GB of heap space.

648
2011-05-05  Chong Yidong  <cyd@stupidchicken.com>
649 650 651

	* nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).

652 653 654 655 656
2011-05-05  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
	`gnutls_certificate_set_x509_key_file'.

657 658 659 660 661
2011-05-05  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
	Update dependencies.

662 663 664 665 666 667 668
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
	* gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
	Remove unused parameter `fildes'.
	* process.c (read_process_output, send_process): Don't pass it.

669 670 671 672 673 674
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	Fix previous change: the library cache is defined in w32.c.
	* image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
	(Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".

675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
2011-05-04  Juanma Barranquero  <lekktu@gmail.com>

	Implement dynamic loading of GnuTLS on Windows.

	* gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
	(emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
	(emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
	Declare.

	* gnutls.c (Qgnutls_dll): Define.
	(DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
	(gnutls_*): Declare function pointers.
	(init_gnutls_functions): New function to initialize function pointers.
	(emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
	(emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
	(emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
	Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
	(emacs_gnutls_write, emacs_gnutls_read)
	(emacs_gnutls_handle_error, Fgnutls_error_fatalp)
	(Fgnutls_available_p): New function.
	(Fgnutls_boot): Call Fgnutls_available_p.  Use function pointers.
	(syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
	(syms_of_gnutls) <Sgnutls_available_p>: defsubr it.

	* image.c: Include w32.h.
	(Vimage_type_cache): Delete.
	(syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
	(CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
	(w32_delayed_load): Move to w32.c.

	* w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.

	* w32.c (QCloaded_from, Vlibrary_cache): Define.
	(w32_delayed_load): Move from image.c.  When loading a library, record
	its filename in the :loaded-from property of the library id.
	(globals_of_w32) <QCloaded_from, Vlibrary_cache>:
	Initialize and staticpro them.
	(emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.

	* process.c: Include lisp.h before w32.h, not after.
	(wait_reading_process_output): Call emacs_gnutls_record_check_pending
	instead of gnutls_record_check_pending.

	* callproc.c, emacs.c: Include lisp.h before w32.h, not after.

720 721 722 723 724 725
2011-05-04  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
	instead of :keyfiles.  Give GnuTLS the keylist and the CRL lists
	as passed in.

726 727 728 729 730
2011-05-03  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_set_frame_alpha): Do not set property on anything
	else than FRAME_X_OUTER_WINDOW (Bug#8608).

731 732 733 734
2011-05-02  Juanma Barranquero  <lekktu@gmail.com>

	* sysdep.c (get_tty_size) [WINDOWSNT]: Implement.  (Bug#8596)

735 736 737 738 739 740 741 742 743 744 745 746
2011-05-02  Juanma Barranquero  <lekktu@gmail.com>

	* gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
	(Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
	(Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
	(gnutls_global_initialized, Qgnutls_bootprop_priority)
	(Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
	(Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
	(Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
	(Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
	(Qgnutls_bootprop_callbacks_verify): Make static.

747 748
2011-05-01  Andreas Schwab  <schwab@linux-m68k.org>

749 750
	* callproc.c: Indentation fixup.

751 752 753 754
	* sysdep.c (wait_for_termination_1): Make static.
	(wait_for_termination, interruptible_wait_for_termination): Move
	after wait_for_termination_1.

755 756 757 758 759 760 761 762 763 764
2011-05-01  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* sysdep.c (interruptible_wait_for_termination): New function
	which is like wait_for_termination, but allows keyboard
	interruptions.

	* callproc.c (Fcall_process): Add (:file "file") as an option for
	the STDOUT buffer.
	(Fcall_process_region): Ditto.

765 766
2011-04-30  Eli Zaretskii  <eliz@gnu.org>

767 768 769
	* dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
	rather than `XVECTOR (FOO)->size'.

770 771 772 773
	* process.c: Remove HAVE_INTTYPES_H condition from inclusion of
	inttypes.h, as a gnulib replacement is used if it not available in
	system headers.

774 775 776 777 778 779 780 781 782 783 784 785 786 787 788
2011-04-21  Eli Zaretskii  <eliz@gnu.org>

	Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
	* fileio.c (Finsert_file_contents): Don't limit file size to 1/4
	of MOST_POSITIVE_FIXNUM.  (Bug#8528)

	* coding.c (coding_alloc_by_realloc): Error out if destination
	will grow beyond MOST_POSITIVE_FIXNUM.
	(decode_coding_emacs_mule): Abort if there isn't enough place in
	charbuf for the composition carryover bytes.  Reserve an extra
	space for up to 2 characters produced in a loop.
	(decode_coding_iso_2022): Abort if there isn't enough place in
	charbuf for the composition carryover bytes.

2011-04-21  Eli Zaretskii  <eliz@gnu.org>
789

790 791 792 793 794
	* doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
	aborting when %lld or %lll format is passed.
	[!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
	%llo or %llx format is passed.  (Bug#8545)

795 796 797
	* window.c (window_scroll_line_based): Use a marker instead of
	simple variables to record original value of point.  (Bug#7952)

798 799 800
	* doprnt.c (doprnt): Fix the case where a multibyte sequence
	produced by %s or %c overflows available buffer space.  (Bug#8545)

801 802 803
2011-04-28  Paul Eggert  <eggert@cs.ucla.edu>

	* doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
804
	(SIZE_MAX): Move defn after all includes, as they might #define it.
805

806 807 808 809
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* w32.c (init_environment): Warn about defaulting HOME to C:\.

810 811 812 813 814 815 816 817
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (Qdelayed_warnings_hook): Define.
	(command_loop_1): Run `delayed-warnings-hook'
	if Vdelayed_warnings_list is non-nil.
	(syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
	(syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.

818 819 820 821 822
2011-04-28  Eli Zaretskii  <eliz@gnu.org>

	* doprnt.c (doprnt): Don't return value smaller than the buffer
	size if the message was truncated.  (Bug#8545).

823 824 825 826 827
2011-04-28  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (Fx_change_window_property, Fx_delete_window_property)
	(Fx_window_property): #if-0 the whole functions, not just the bodies.

828 829 830 831
2011-04-27  Paul Eggert  <eggert@cs.ucla.edu>

	* doprnt.c (doprnt): Support "ll" length modifier, for long long.

832 833 834 835
2011-04-27  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

836 837 838 839 840 841 842 843 844 845 846 847 848
2011-04-27  Eli Zaretskii  <eliz@gnu.org>

	Improve `doprnt' and its usage.  (Bug#8545)
	* doprnt.c (doprnt): Make sure `format' is never accessed beyond
	`format_end'.  Remove support for %l as a conversion specifier.
	Don't use xrealloc.  Improve diagnostics when the %l size modifier
	is used.  Update the commentary.

	* eval.c (verror): Simplify calculation of size_t.

	* coding.c (Ffind_operation_coding_system): Fix diagnostic error
	messages.

849 850 851 852 853
2011-04-27  Yoshiaki Kasahara  <kasahara@nc.kyushu-u.ac.jp>  (tiny change)

	* buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
	change.

854 855 856 857 858
2011-04-27  Paul Eggert  <eggert@cs.ucla.edu>

	* nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
	This makes this file independent of the recent pseudovector change.

Paul Eggert's avatar
Paul Eggert committed
859
2011-04-26  Paul Eggert  <eggert@cs.ucla.edu>
860

861 862
	* keyboard.c (handle_user_signal): Fix pointer signedness problem.

Paul Eggert's avatar
Paul Eggert committed
863
	* gnutls.c (emacs_gnutls_handle_error): Remove unused local.
864
	(Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
Paul Eggert's avatar
Paul Eggert committed
865
	Remove unused local.
866
	(emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
867

Juanma Barranquero's avatar
Juanma Barranquero committed
868
	* lisp.h: Fix a problem with aliasing and vector headers.  (Bug#8546)
869 870 871 872 873 874 875
	GCC 4.6.0 optimizes based on type-based alias analysis.  For
	example, if b is of type struct buffer * and v of type struct
	Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
	!= &v->size, and therefore "v->size = 1; b->size = 2; return
	v->size;" must therefore return 1.  This assumption is incorrect
	for Emacs, since it type-puns struct Lisp_Vector * with many other
	types.  To fix this problem, this patch adds a new type struct
Paul Eggert's avatar
Paul Eggert committed
876
	vectorlike_header that documents the constraints on layout of vectors
877 878 879
	and pseudovectors, and helps optimizing compilers not get fooled
	by Emacs's type punning.  It also adds the macros XSETTYPED_PVECTYPE
	XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
Paul Eggert's avatar
Paul Eggert committed
880 881
	* lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
	the size member.
882 883 884 885 886
	(XSETPVECTYPE): Rewrite in terms of new macro.
	(XSETPVECTYPESIZE): New macro, specifying both type and size.
	This is a bit clearer, and further avoids the possibility of
	undesirable aliasing.
	(XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
Paul Eggert's avatar
Paul Eggert committed
887
	(XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
888 889
	(XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
	since Lisp_Subr is a special case (no "next" field).
Paul Eggert's avatar
Paul Eggert committed
890 891 892 893
	(ASIZE): Now uses header.size rather than size.  All
	previous uses of XVECTOR (foo)->size replaced to use this macro,
	to avoid the hassle of writing XVECTOR (foo)->header.size.
	(struct vectorlike_header): New type.
894 895 896 897 898 899 900
	(TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
	object, to help avoid aliasing.
	(PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
	(SUBRP): Likewise, since Lisp_Subr is a special case.
	* lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
	(struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
	(struct Lisp_Hash_Table): Combine first two members into a single
Paul Eggert's avatar
Paul Eggert committed
901
	struct vectorlike_header member.  All uses of "size" and "next" members
902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917
	changed to be "header.size" and "header.next".
	* buffer.h (struct buffer): Likewise.
	* font.h (struct font_spec, struct font_entity, struct font): Likewise.
	* frame.h (struct frame): Likewise.
	* process.h (struct Lisp_Process): Likewise.
	* termhooks.h (struct terminal): Likewise.
	* window.c (struct save_window_data, struct saved_window): Likewise.
	* window.h (struct window): Likewise.
	* alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
	Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
	* buffer.c (init_buffer_once): Likewise.
	* lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
	special case.
	* process.c (Fformat_network_address): Use local var for size,
	for brevity.

918 919
	* bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.

Paul Eggert's avatar
Paul Eggert committed
920
	Make the Lisp reader and string-to-float more consistent (Bug#8525)
921 922 923 924 925 926 927 928 929 930
	* data.c (atof): Remove decl; no longer used or needed.
	(digit_to_number): Move to lread.c.
	(Fstring_to_number): Use new string_to_number function, to be
	consistent with how the Lisp reader treats infinities and NaNs.
	Do not assume that floating-point numbers represent EMACS_INT
	without losing information; this is not true on most 64-bit hosts.
	Avoid double-rounding errors, by insisting on integers when
	parsing non-base-10 numbers, as the documentation specifies.
	* lisp.h (string_to_number): New decl, replacing ...
	(isfloat_string): Remove.
931
	* lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
932
	(read1): Do not accept +. and -. as integers; this
933 934 935 936 937 938 939 940 941 942 943 944 945
	appears to have been a coding error.  Similarly, do not accept
	strings like +-1e0 as floating point numbers.  Do not report
	overflow for integer overflows unless the base is not 10 which
	means we have no simple and reliable way to continue.
	Break out the floating-point parsing into a new
	function string_to_number, so that Fstring_to_number parses
	floating point numbers consistently with the Lisp reader.
	(digit_to_number): Moved here from data.c.  Make it static inline.
	(E_CHAR, EXP_INT): Remove, replacing with ...
	(E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
	(string_to_number): New function, replacing isfloat_string.
	This function checks for valid syntax and produces the resulting
	Lisp float number too.  Rework it so that string-to-number
946
	no longer mishandles examples like "1.0e+".  Use strtoumax,
947 948
	so that overflow for non-base-10 numbers is reported only when
	there's no portable and simple way to convert to floating point.
949

950 951 952
	* textprop.c (set_text_properties_1): Rewrite for clarity,
	and to avoid GCC warning about integer overflow.

953 954 955 956 957 958
	* intervals.h (struct interval): Use EMACS_INT for members
	where EMACS_UINT might cause problems.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
	(CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
	* intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
	All uses changed.
959 960
	(offset_intervals): Tell GCC not to worry about length overflow
	when negating a negative length.
961

962 963 964
	* alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
	(overrun_check_free): Likewise.

965 966 967 968
	* alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
	in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
	word size.

969 970 971 972 973 974
	* gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(gnutls_make_error): Rename local to avoid shadowing.
	(gnutls_emacs_global_deinit): ifdef out; not used.
	(Fgnutls_boot): Use const for pointer to readonly storage.
	Comment out unused local.  Fix pointer signedness problems.

975 976 977 978
	* lread.c (openp): Don't stuff size_t into an 'int'.
	Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
	about possible signed overflow.

979 980 981 982 983
	* gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
	(GDK_KEY_g): Don't define if already defined.
	(xg_prepare_tooltip): Avoid pointer signedness problem.
	(xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.

984 985 986
	* process.c (Fnetwork_interface_info): Avoid left-shift undefined
	behavior with 1 << 31.  GCC 4.6.0 warns about this on 32-bit hosts.

987 988 989 990
	* xfns.c (Fx_window_property): Simplify a bit,
	to make a bit faster and to avoid GCC 4.6.0 warning.
	* xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.

991 992
	* fns.c (internal_equal): Don't assume size_t fits in int.

993 994
	* alloc.c (compact_small_strings): Tighten assertion a little.

995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
	Replace pEd with more-general pI, and fix some printf arg casts.
	* lisp.h (pI): New macro, generalizing old pEd macro to other
	conversion specifiers.  For example, use "...%"pI"d..." rather
	than "...%"pEd"...".
	(pEd): Remove.  All uses replaced with similar uses of pI.
	* src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
	* alloc.c (check_pure_size): Don't overflow by converting size to int.
	* bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
	* data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
	* dbusbind.c (xd_append_arg): Use pI to avoid cast.
	(Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
	* font.c (font_unparse_xlfd): Avoid potential buffer overrun on
	64-bit hosts.
	(font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
	* keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
	* print.c (safe_debug_print, print_object): Likewise.
	(print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
	to int.
1013 1014
	Use pI instead of if-then-else-abort.  Use %p to avoid casts,
	avoiding the 0 flag, which is not portable.
1015 1016 1017 1018 1019
	* process.c (Fmake_network_process): Use pI to avoid cast.
	* region-cache.c (pp_cache): Likewise.
	* xdisp.c (decode_mode_spec): Likewise.
	* xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
	behavior on 64-bit hosts with printf arg.
1020
	* xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1021 1022 1023
	(x_stop_queuing_selection_requests): Likewise.
	(x_get_window_property): Don't truncate byte count to an 'int'
	when tracing.
1024

1025 1026 1027 1028 1029
	* frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
	here, since it parses constructs like leading '-' and spaces,
	which are not wanted; and it overflows with large numbers.
	Instead, simply match F[0-9]+, which is what is wanted anyway.

1030 1031 1032 1033 1034 1035 1036 1037 1038
	* alloc.c: Remove unportable assumptions about struct layout.
	(SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
	(SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
	(allocate_vectorlike, make_pure_vector): Use the new macros,
	plus offsetof, to remove unportable assumptions about struct layout.
	These assumptions hold on all porting targets that I know of, but
	they are not guaranteed, they're easy to remove, and removing them
	makes further changes easier.

1039 1040
	* alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
	This doesn't fix a bug but makes the code clearer.
1041 1042
	(string_overrun_cookie): Now const.  Use initializers that
	don't formally overflow signed char, to avoid warnings.
1043 1044
	(allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
	can cause Emacs to crash when string overrun checking is enabled.
1045 1046 1047
	(allocate_buffer): Don't assume sizeof (struct buffer) is a
	multiple of sizeof (EMACS_INT); it need not be, if
	alignof(EMACS_INT) < sizeof (EMACS_INT).
1048
	(check_sblock, check_string_bytes, check_string_free_list): Protoize.
1049

1050 1051 1052 1053
2011-04-26  Juanma Barranquero  <lekktu@gmail.com>

	* keyboard.c (QCrtl): Rename from Qrtl.  All uses changed.

1054 1055 1056
2011-04-26  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.c (emacs_gnutls_handshake): Return an error if we're not
Paul Eggert's avatar
Paul Eggert committed
1057
	supposed to be handshaking.  (Bug#8556)
1058 1059
	Reported by Paul Eggert <eggert@cs.ucla.edu>.

Juanma Barranquero's avatar
Juanma Barranquero committed
1060
2011-04-26  Daniel Colascione  <dan.colascione@gmail.com>
Daniel Colascione's avatar
Daniel Colascione committed
1061 1062

	* lisp.h (Qdebug): List symbol.
1063
	* eval.c (Qdebug): Restore global linkage.
Daniel Colascione's avatar
Daniel Colascione committed
1064 1065 1066 1067
	* keyboard.c (debug-on-event): New variable.
	(handle_user_signal): Break into debugger when debug-on-event
	matches the current signal symbol.

1068 1069 1070 1071 1072
2011-04-25  Dan Nicolaescu  <dann@ics.uci.edu>

	* alloc.c (check_sblock, check_string_bytes)
	(check_string_free_list): Convert to standard C.

Ted Zlatanov's avatar
Ted Zlatanov committed
1073 1074 1075 1076
2011-04-25  Teodor Zlatanov  <tzz@lifelogs.com>

	* w32.c (emacs_gnutls_push): Fix typo.

1077 1078
2011-04-25  Eli Zaretskii  <eliz@gnu.org>

1079 1080 1081
	* gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
	"cast to pointer from integer of different size".

1082 1083 1084 1085 1086 1087 1088 1089 1090
	Improve doprnt and its use in verror.  (Bug#8545)
	* doprnt.c (doprnt): Document the set of format control sequences
	supported by the function.  Use SAFE_ALLOCA instead of always
	using `alloca'.

	* eval.c (verror): Don't limit the buffer size at size_max-1, that
	is one byte too soon.  Don't use xrealloc; instead xfree and
	xmalloc anew.

1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
2011-04-24  Teodor Zlatanov  <tzz@lifelogs.com>

	* gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
	callbacks stage.

	* gnutls.c: Renamed global_initialized to
	gnutls_global_initialized.  Added internals for the
	:verify-hostname-error, :verify-error, and :verify-flags
	parameters of `gnutls-boot' and documented those parameters in the
	docstring.  Start callback support.
	(emacs_gnutls_handshake): Add Woe32 support. Retry handshake
	unless a fatal error occured. Call gnutls_alert_send_appropriate
	on error. Return error code.
	(emacs_gnutls_write): Call emacs_gnutls_handle_error.
	(emacs_gnutls_read): Likewise.
	(Fgnutls_boot): Return handshake error code.
	(emacs_gnutls_handle_error): New function.
	(wsaerror_to_errno): Likewise.

	* w32.h (emacs_gnutls_pull): Add prototype.
	(emacs_gnutls_push): Likewise.

	* w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
	(emacs_gnutls_push): Likewise.

2011-04-24  Claudio Bley  <claudio.bley@gmail.com>  (tiny change)

	* process.c (wait_reading_process_output): Check if GnuTLS
	buffered some data internally if no FDs are set for TLS
	connections.

	* makefile.w32-in (OBJ2): Add gnutls.$(O).
	(LIBS): Link to USER_LIBS.
	($(BLD)/gnutls.$(0)): New target.

1126 1127
2011-04-24  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
1128 1129 1130 1131 1132
	* xdisp.c (handle_single_display_spec): Rename the
	display_replaced_before_p argument into display_replaced_p, to
	make it consistent with the commentary.  Fix typos in the
	commentary.

1133 1134 1135 1136 1137
	* textprop.c (syms_of_textprop): Remove dead code.
	(copy_text_properties): Delete obsolete commentary about an
	interface that was deleted long ago.  Fix typos in the description
	of arguments.

1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152
	* msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
	to changes in oldXMenu/XMenu.h from 2011-04-16.
	<menu_help_message, prev_menu_help_message>: Constify.
	(IT_menu_make_room): menu->help_text is now `const char **';
	adjust.

	* msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
	to changes in oldXMenu/XMenu.h from 2011-04-16.
	(struct XMenu): Declare `help_text' `const char **'.

	* xfaces.c <Qunspecified>: Make extern again.

	* syntax.c: Include sys/types.h before including regex.h, as
	required by Posix.

1153 1154 1155 1156 1157 1158 1159 1160 1161
	* doc.c (get_doc_string): Improve the format passed to `error'.

	* doprnt.c (doprnt): Improve commentary.

	* term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.

	* Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
	them with etags.

1162 1163
	* makefile.w32-in (globals.h): Add a dummy recipe, to make any
	changes in globals.h immediately force recompilation.
1164 1165 1166
	(TAGS): Depend on $(CURDIR)/m/intel386.h and
	$(CURDIR)/s/ms-w32.h.
	(TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1167

1168 1169 1170 1171
	* character.c (Fchar_direction): Function deleted.
	(syms_of_character): Don't defsubr it.
	<char-direction-table>: Deleted.

1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219
2011-04-23  Eli Zaretskii  <eliz@gnu.org>

	Fix doprnt so it could be used again safely in `verror'.  (Bug#8435)
	* doprnt.c: Include limits.h.
	(SIZE_MAX): New macro.
	(doprnt): Return a size_t value.  2nd arg is now size_t.  Many
	local variables are now size_t instead of int or unsigned.
	Improve overflow protection.  Support `l' modifier for integer
	conversions.  Support %l conversion.  Don't assume an EMACS_INT
	argument for integer conversions and for %c.

	* lisp.h (doprnt): Restore prototype.

	* makefile.w32-in ($(BLD)/callint.$(O)): Depend on
	$(SRC)/character.h.

	* Makefile.in (base_obj): Add back doprnt.o.

	* deps.mk (doprnt.o): Add back prerequisites.
	(callint.o): Depend on character.h.

	* eval.c (internal_lisp_condition_case): Include the handler
	representation in the error message.
	(verror): Call doprnt instead of vsnprintf.  Fix an off-by-one bug
	when breaking from the loop.

	* xdisp.c (vmessage): Call doprnt instead of vsnprintf.

	* callint.c (Fcall_interactively): When displaying error message
	about invalid control letter, pass the character's codepoint, not
	a pointer to its multibyte form.  Improve display of the character
	in octal and display also its hex code.

	* character.c (char_string): Use %x to display the (unsigned)
	codepoint of an invalid character, to avoid displaying a bogus
	negative value.

	* font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
	`error', not SYMBOL_NAME itself.

	* coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
	character arguments to `error'.

	* charset.c (check_iso_charset_parameter): Fix incorrect argument
	to `error' in error message about FINAL_CHAR argument.  Make sure
	FINAL_CHAR is a character, and use %c when it is passed as
	argument to `error'.

1220
2011-04-23  Eli Zaretskii  <eliz@gnu.org>
1221 1222 1223 1224 1225 1226

	* s/ms-w32.h (localtime): Redirect to sys_localtime.

	* w32.c: Include <time.h>.
	(sys_localtime): New function.

1227
2011-04-23  Chong Yidong  <cyd@stupidchicken.com>
1228 1229 1230

	* xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).

1231
	* buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1232

1233
2011-04-23  Samuel Thibault  <sthibault@debian.org>  (tiny change)
1234

1235 1236
	* sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
	zombies (Bug#8467).
1237

1238 1239 1240 1241 1242 1243 1244 1245
2011-04-19  Eli Zaretskii  <eliz@gnu.org>

	* syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
	gl_state.e_property when gl_state.object is Qt.

	* insdel.c (make_gap_larger): Remove limitation of buffer size
	to <= INT_MAX.

1246 1247 1248 1249 1250 1251 1252 1253 1254 1255
2011-04-18  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (lookup_glyphless_char_display)
	(produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.
	(Vglyphless_char_display): Document it.

	* term.c (produce_glyphless_glyph): Handle cons cell entry in
	glyphless-char-display.

Chong Yidong's avatar
Chong Yidong committed
1256 1257 1258 1259 1260 1261 1262 1263 1264
2011-04-17  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (get_next_display_element): Remove unnecessary ifdefs.

	* termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.

	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
	definition for no-X builds.

1265
2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>
1266

1267 1268
	Static checks with GCC 4.6.0 and non-default toolkits.

1269 1270
	* s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.

1271 1272 1273 1274
	* process.c (keyboard_bit_set): Define only if SIGIO.
	(send_process_trap): Mark it with NO_RETURN if it doesn't return.
	(send_process): Repair possible setjmp clobbering.

1275 1276
	* s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.

1277 1278
	* eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.

1279 1280
	* data.c (arith_error): Mark with NO_RETURN if it doesn't return.

1281 1282 1283
	* alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
	Define only if needed.

1284 1285
	* sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
	by pacifying GCC about it.  Maybe it's time to retire it?
1286
	* xfaces.c (USG, __TIMEVAL__): Likewise.
1287

1288 1289
	* dispextern.h (struct redisplay_interface): Rename param
	to avoid shadowing.
1290
	* termhooks.h (struct terminal): Likewise.
1291
	* xterm.c (xembed_send_message): Likewise.
1292

1293 1294 1295
	* insdel.c (make_gap_smaller): Define only if
	USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.

1296 1297 1298
	* keyboard.c (read_char): Make a var volatile so longjmp won't clobber
	it.

1299 1300 1301
	* emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
	so that we aren't warned about unused symbols.

1302 1303
	* xfns.c (Fx_file_dialog): Rename local to avoid shadowing.

1304
	* xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1305

1306 1307
	* xfns.c (x_real_positions): Mark locals as initialized.

1308 1309
	* xmenu.c (xmenu_show): Don't use uninitialized vars.

1310 1311
	* xterm.c: Fix problems found by static analysis with other toolkits.
	(toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1312 1313
	(x_dispatch_event): Declare static if USE_GTK, and
	define if USE_GTK || USE_X_TOOLKIT.
1314
	(SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1315
	* xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
Juanma Barranquero's avatar
Juanma Barranquero committed
1316 1317
	* xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
	if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1318

1319 1320 1321 1322 1323 1324
	* xmenu.c (menu_help_callback): Pointer type fixes.
	Use const pointers when pointing at readonly data.  Avoid pointer
	signedness clashes.
	(FALSE): Remove unused macro.
	(update_frame_menubar): Remove unused decl.

1325 1326
	* xfns.c (Fx_hide_tip): Move locals to avoid shadowing.

1327 1328 1329 1330
	* menu.c (push_submenu_start, push_submenu_end): Do not define unless
	USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
	(single_menu_item): Rename local to avoid shadowing.

1331 1332
	* keyboard.c (make_lispy_event): Remove unused local var.

1333 1334 1335
	* frame.c, frame.h (x_get_resource_string): Bring this back, but
	only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.

1336 1337 1338 1339 1340
	* bitmaps: Change bitmaps from unsigned char back to the X11
	compatible char.  Avoid the old compiler warnings about
	out-of-range initializers by using, for example, '\xab' rather
	than 0xab.

1341 1342 1343
	* xgselect.c (xgselect_initialize): Check vs interface
	even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).

1344 1345
	* xmenu.c (xmenu_show): Rename parm to avoid shadowing.

1346 1347 1348
	* xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
	to read-only memory.

1349 1350
	* fns.c (vector): Remove; this old hack is no longer needed.

1351
	* xsmfns.c (create_client_leader_window): Rename shadowing arg.
Paul Eggert's avatar
Paul Eggert committed
1352
	Remove unused var.
1353
	(gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1354

1355
	* xrdb.c (x_load_resources): Omit unused local.
1356

1357
	* xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1358
	(x_window): Rename locals to avoid shadowing.
1359
	(USG): Use the kludged USG macro, to pacify gcc.
1360

1361
	* xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1362
	(x_term_init): Remove local to avoid shadowing.
1363

1364
	* xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1365 1366 1367 1368

	* xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
	USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.

1369 1370
2011-04-16  Eli Zaretskii  <eliz@gnu.org>

1371 1372
	* gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.

1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404
	Fix regex.c, syntax.c and friends for buffers > 2GB.
	* syntax.h (struct gl_state_s): Declare character position members
	EMACS_INT.

	* syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.

	* textprop.c (verify_interval_modification, interval_of): Declare
	arguments EMACS_INT.

	* intervals.c (adjust_intervals_for_insertion): Declare arguments
	EMACS_INT.

	* intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.

	* indent.c (Fvertical_motion): Local variable it_start is now
	EMACS_INT.

	* regex.c (re_match, re_match_2, re_match_2_internal)
	(bcmp_translate, regcomp, regexec, print_double_string)
	(group_in_compile_stack, re_search, re_search_2, regex_compile)
	(re_compile_pattern, re_exec): Declare arguments and local
	variables `size_t' and `ssize_t' and return values `regoff_t', as
	appropriate.
	(POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
	(CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
	<compile_stack_type>: `size' and `avail' are now `size_t'.

	* regex.h <regoff_t>: Use ssize_t, not int.
	(re_search, re_search_2, re_match, re_match_2): Arguments that
	specify buffer/string position and length are now ssize_t and
	size_t.  Return type is regoff_t.

1405 1406 1407 1408 1409 1410 1411 1412 1413 1414
2011-04-16  Ben Key  <bkey76@gmail.com>

	* nsfont.m: Fixed bugs in ns_get_family and
	ns_descriptor_to_entity that were caused by using free to
	deallocate memory blocks that were allocated by xmalloc (via
	xstrdup).  This caused Emacs to crash when compiled with
	XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
	--enable-checking=xmallocoverrun).  xfree is now used to
	deallocate these memory blocks.

Paul Eggert's avatar
Paul Eggert committed
1415
2011-04-15  Paul Eggert  <eggert@cs.ucla.edu>
1416

1417 1418
	* sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.

1419 1420 1421 1422 1423 1424 1425 1426
	emacs_write: Accept and return EMACS_INT for sizes.
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
	et seq.
	* gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
	Accept and return EMACS_INT.
	(emacs_gnutls_write): Return the number of bytes written on
	partial writes.
	* sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1427 1428
	(emacs_read, emacs_write): Remove check for negative size, as the
	Emacs source code has been audited now.
1429 1430
	* sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
	(emacs_read, emacs_write): Use it.
1431 1432 1433
	* process.c (send_process): Adjust to the new signatures of
	emacs_write and emacs_gnutls_write.  Do not attempt to store
	a byte offset into an 'int'; it might overflow.
1434
	See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1435

Paul Eggert's avatar