ChangeLog 1.09 MB
Newer Older
1 2
2011-03-15  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6

7
	* filelock.c (within_one_second): Now static.
8
	(lock_file_1): Rename local to avoid shadowing.
9

10 11 12 13 14
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.

15 16
2011-03-14  Paul Eggert  <eggert@cs.ucla.edu>

17
	* buffer.c (switch_to_buffer_1): Now static.
18 19
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
20

21
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
22
	Fix pointer signedness issue.
23 24
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
25
	(MAXPATHLEN): Define only if needed.
26

27 28 29
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

30 31 32
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

33
	* sysdep.c (reset_io): Now static.
34
	(wait_for_termination_signal): Remove; unused.
35

36 37 38
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
39
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
40
	(DENSE_TABLE_SIZE): Remove; unused.
41 42 43
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
44

45 46 47
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
48 49 50 51 52
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
53
	(read_key_sequence, read_char): Mark locals as initialized.
54
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
55

56
	* keyboard.h (make_ctrl_char): New decl.
57 58
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
59

60 61
	* lisp.h (force_auto_save_soon): New decl.

62
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
63 64 65
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
66 67
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
68

69 70
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

71 72 73 74 75 76 77
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

78 79
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
80
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
81

82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

104 105 106 107 108
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

109 110
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
111 112
	Fix more problems found by GCC 4.5.2's static checks.

113 114
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
115 116
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
117 118
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
119 120 121 122 123
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
124 125 126
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
127

128 129
	* xgselect.c (xg_select): Remove unused var.

130 131 132
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
133
	(my_png_error, my_error_exit): Mark with NO_RETURN.
134

135
	* image.c (clear_image_cache): Now static.
136
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
137
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
138 139
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
140
	(gif_load): Fix pointer signedness.
141 142
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
143

Paul Eggert's avatar
Paul Eggert committed
144 145
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

146 147 148 149 150 151
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
152 153 154 155 156 157 158 159 160 161 162 163
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
164 165
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
166

167 168 169 170
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

171 172 173 174 175
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

176
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
177

178 179
	* fringe.c (update_window_fringes): Remove unused variables.

180 181 182
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

183 184
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

185 186 187 188 189
	* termcap.c [MSDOS]: Include "msdos.h.
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

190
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
191

192 193 194 195 196
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

197 198 199 200
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

201 202 203 204 205 206 207 208 209 210 211 212
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

213
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
214

215
	Fix some minor problems found by GCC 4.5.2's static checks.
216

217 218 219
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
220

221 222 223 224 225
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

226
	* fontset.c (free_realized_fontset): Now static.
227
	(Fset_fontset_font): Rename local to avoid shadowing.
228
	(fontset_font): Mark local as initialized.
229
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
230

231 232
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

233
	* xselect.c (x_disown_buffer_selections): Remove; not used.
234
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
235 236 237
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
238

239 240 241
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
242 243 244 245
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
246
	(Fx_create_frame): Add braces to silence GCC warning.
247
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
248 249
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
250 251 252 253
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
254

255 256
	* xterm.h (x_mouse_leave): New decl.

257 258
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
259 260
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
261
	(XTread_socket): Don't define label "out" unless it's used.
262
	Don't declare local "event" unless it's used.
263 264
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
265 266
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
267 268 269 270 271
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
272
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
273
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
274

275 276
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
277
	(tty_defined_color, merge_face_heights): Now static.
278
	(free_realized_faces_for_fontset): Remove; not used.
279 280
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
281 282
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
283

284
	* terminal.c (store_terminal_param): Now static.
285

286
	* xmenu.c (menu_highlight_callback): Now static.
287
	(set_frame_menubar): Remove unused local.
288
	(xmenu_show): Rename parameter to avoid shadowing.
289 290
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
291 292
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
293

294
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
295
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
296 297
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
298
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
299 300
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
301

Paul Eggert's avatar
Paul Eggert committed
302 303
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

304
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
305 306
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
307

308
	* window.c (display_buffer): Now static.
309 310
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
311 312
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
313
	* dispextern.h (bidi_dump_cached_states): Likewise.
314

315 316 317
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
318 319 320
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
321 322
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
323
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
324

325 326 327
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
328 329 330 331 332 333 334 335 336
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
337 338
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
339
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
340
	(decode_coding_object, encode_coding_object, detect_coding_system):
341 342
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
343 344
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
345
	this initialization is needed.  (Bug#8211)
346 347 348 349 350
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
351

352
	* category.c (hash_get_category_set): Remove unused local var.
353
	(copy_category_table): Now static, since it's not used elsewhere.
354
	* character.c (string_count_byte8): Likewise.
355

356 357 358
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

359 360
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
361 362
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
363
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
364

365
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
366
	(BIDI_BOB): Remove unused macro.
367

368 369
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
370
	* term.c (encode_terminal_code): Likewise.
371

372
	* term.c (encode_terminal_code): Now static.  Remove unused local.
373

Paul Eggert's avatar
Paul Eggert committed
374 375 376 377 378 379 380 381 382 383 384
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

385 386 387 388 389 390 391 392 393
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

394 395
	* term.c (term_mouse_position): Rename local to avoid shadowing.

396 397 398
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

399 400 401 402
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

403 404 405 406 407 408
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

461 462 463 464 465
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
466 467 468 469 470 471 472
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
473
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
474

475 476 477 478 479 480
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

481 482 483 484 485
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

486 487
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

488 489 490
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

515 516 517 518 519
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

520
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
521
	* xdisp.c (redisplay_window): Likewise.
522

523 524 525 526 527 528 529 530
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
531
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
532 533
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
534
	(update_window_cursor): Now static, since it's not used elsewhere.
535
	(SKIP_GLYPHS): Removed unused macro.
536

537 538 539 540
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

541 542 543 544
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
545
2011-03-02  Ken Brown  <kbrown@cornell.edu>
546 547 548

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

549 550 551 552 553 554 555 556 557 558 559 560 561
2011-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	Work around some portability problems with symlinks.

	* fileio.c (Fmake_symbolic_link): Treat ENOSYS specially, and
	generate a special message for it.  Suggested by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00995.html>.
	(Frename_file, Fmake_symbolic_link, Ffile_symlink_p):
	Simplify the code by assuming that the readlink and symlink calls
	exist, even if they always fail on this host.
	(Ffile_readable_p): Likewise, for fifos.
	* config.in: Regenerate.

562 563 564 565 566 567
2011-02-27  Chong Yidong  <cyd@stupidchicken.com>

	* frame.c (store_frame_param): Don't store value directly in
	buffer_list and buried_buffer_list; copy the list and remove dead
	buffers (Bug#7898).

568 569
2011-02-27  Eli Zaretskii  <eliz@gnu.org>

570 571
	* msdos.c (readlink) [DJGPP < 2.04]: New stub function.

Juanma Barranquero's avatar
Juanma Barranquero committed
572
	* msdos.h (readlink) [DJGPP < 2.04]: Declare prototype.
573

574 575
	* w32.c (symlink, readlink): New stub functions.

576 577
2011-02-27  Paul Eggert  <eggert@cs.ucla.edu>

578 579 580
	* scroll.c (CHECK_BOUNDS): #define only if GLYPH_DEBUG.
	This avoids a gcc warning in some configurations.

581 582
	* frame.c (x_set_screen_gamma): Rename local to avoid shadowing.

583 584 585 586
	* frame.h: Avoid gcc -Wmissing-prototypes diagnostics.
	(set_menu_bar_lines, x_get_resource_string): New decls.
	* msdos.c (set_menu_bar_lines): Omit decl.

587 588 589 590 591
	* dispextern.h (struct glyph): Make u.img_id int, not unsigned.
	It's always given int values and used as an int.  This suppresses
	a gcc "comparison of unsigned expression >= 0" warning in some
	configurations.

592 593 594
	* dispnew.c: Rename locals to avoid shadowing.
	(update_text_area, scrolling_window, update_frame_1): Rename locals.

595 596 597 598 599 600 601 602 603 604
2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c: Fix problems uncovered by gcc -Wstrict-prototypes.
	(copy_glyph_row_contents): Remove; not used.
	(frame_row_to_window, check_current_matrix_flags):
	(window_change_signal): Now static, since they're not used elsewhere.
	(check_current_matrix_flags): Surround with "#if 0", since its
	only use is in a comment.  Maybe both the comment and the "#if 0"
	stuff should be removed?

605 606 607 608
	* dispnew.c: Fix problem uncovered by gcc -Wunused-variable.
	(adjust_frame_glyphs_for_window_redisplay): Make 'w' local to the
	contexts that actually need it.

609 610 611 612 613
2011-02-26  Eli Zaretskii  <eliz@gnu.org>

	* s/msdos.h (HAVE_LSTAT): Define for DJGPP >= 2.04.
	(lstat): Define for DJGPP < 2.04.

614 615 616 617 618 619
2011-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Increase size of modes from 10 to 12
	as per recent filemodestring API change.  Reported by Jonas Öster in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg01069.html>.

620
2011-02-23  Ben Key  <bkey76@gmail.com>
621 622 623 624 625 626 627 628 629

	* nsterm.m (ns_draw_window_cursor): Obey the cursor_width argument
	directly, for bar cursors.

2011-02-23  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (set_frame_cursor_types): Don't write an undefined value
	into the frame's cursor_width.

630 631 632 633 634
2011-02-23  Stefan Monnier  <monnier@iro.umontreal.ca>

	* print.c (print_object): Never print old-style backquotes.
	Obey escapeflag for hash tables as well.

635
2011-02-23  Kenichi Handa  <handa@m17n.org>
Kenichi Handa's avatar
Kenichi Handa committed
636 637

	* font.c (font_open_entity): Be sure to set scaled_pixel_size.
638
	(font_find_for_lface): Check if attrs[LFACE_HEIGHT_INDEX] is integer.
Kenichi Handa's avatar
Kenichi Handa committed
639

640 641 642 643
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Simplify and avoid #ifdef.

644 645 646 647
2011-02-22  Wolfgang Jenkner  <wjenkner@inode.at>  (tiny change)

	* lread.c (openp): Correct Boolean typo in last commit.

648 649 650
2011-02-22  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (EmacsView-keyDown:): Don't pass shift-only-modified
651
	key to Emacs, treat as unmodified (go to input manager processing).
652

Paul Eggert's avatar
Paul Eggert committed
653 654 655 656 657 658 659 660 661 662 663 664 665 666
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	Assume S_ISLNK etc. work, since gnulib supports this.
	* config.in: Regenerate.
	* dired.c (lstat): Remove.
	(file_name_completion): Assume S_ISDIR works.
	(file_name_completion_stat): Assume S_ISLNK works.
	Do not bother calling stat unless lstat says it's a symlink.
	* fileio.c (S_ISLNK, S_ISFIFO, S_ISREG, lstat): Remove.
	(Fcopy_file): Assume S_ISREG and S_ISLNK work.
	(check_writable, Ffile_writable_p, Fset_file_times):
	Assume S_ISDIR works.
	(Ffile_readable_p): Use S_IFIFO, not S_ISFIFO, to guess whether
	fifos exist.
Juanma Barranquero's avatar
Juanma Barranquero committed
667
	(Ffile_regular_p, Finsert_file_contents): Assume S_ISREG works.
Paul Eggert's avatar
Paul Eggert committed
668 669 670 671
	* filelock.c (S_ISLNK): Remove.
	* lread.c (openp): Assume S_ISDIR works.
	* xrdb.c (S_ISDIR): Remove.

672 673 674
2011-02-21  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/filemode.$(O)): Move recipe to
Juanma Barranquero's avatar
Juanma Barranquero committed
675
	lib/makefile.w32-in.
676 677 678 679
	($(BLD)/dired.$(O)): Depend on $(EMACS_ROOT)/lib/filemode.h.
	(GLOBAL_SOURCES): Remove filemode.c.
	(OBJ1): Remove $(BLD)/filemode.$(O).

680 681 682 683 684 685 686 687 688 689
2011-02-21  Paul Eggert  <eggert@cs.ucla.edu>

	Import filemode module from gnulib.
	* Makefile.in (base_obj): Remove filemode.o, as it's now in ../lib.
	* deps.mk (dired.o): Depend on ../lib/filemode.h, too.
	(filemode.o): Remove; this is now in ../lib.
	* dired.c: Include <filemode.h>.
	(filemodestring): Remove now-redundant decl.
	* config.in: Regenerate.

690 691 692 693 694
2011-02-20  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/fns.$(O)): Depend on
	$(EMACS_ROOT)/lib/md5.h and on stamp_BLD.

Juanma Barranquero's avatar
Juanma Barranquero committed
695
2011-02-20  Christoph Scholtes  <cschol2112@gmail.com>
696 697 698 699 700

	* makefile.w32-in: Remove md5.$(O).
	($(BLD)/md5.$(O)): Remove prerequisites, moved to
	lib/makefile.w32-in.

701
2011-02-20  Paul Eggert  <eggert@cs.ucla.edu>
702

703 704 705 706 707 708 709 710
	Import crypto/md5 and stdint modules from gnulib.
	* Makefile.in (base_obj): Remove md5.o, since this file
	is in lib now.
	* config.in: Regenerate.
	* md5.h, md5.h: Move to ../lib.
	* deps.mk (md5.o): Remove.
	(fns.o): Depend on ../lib/md5.h, not md5.h.

711 712
2011-02-19  Eli Zaretskii  <eliz@gnu.org>

713 714
	* termcap.c (tputs): Don't declare baud_rate.

715 716
	* s/msdos.h (strtold): Define to _strtold.

717 718
2011-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>

719 720 721 722 723 724
	* process.c (Fstart_process, Fmake_serial_process)
	(Fmake_network_process, server_accept_connection):
	Use empty_unibyte_string.

	* alloc.c (make_unibyte_string): Don't SET_UNIBYTE redundantly.

725 726 727 728
	* lread.c (Qdir_ok): New constant.
	(syms_of_lread): Initialize it.
	(openp): Don't ignore directories if the predicate returns dir-ok.

729 730
2011-02-18  Eli Zaretskii  <eliz@gnu.org>

731 732
	* xdisp.c (display_line): Fix the change made for bug#7939.

733 734 735 736
	* terminal.c (create_terminal): Use default-keyboard-coding-system
	and default-terminal-coding-system to initialize coding systems of
	the new terminal.  (Bug#7840)

737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753
2011-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>

	* lisp.h (BYTE_MARK_STACK): New macro.
	(mark_byte_stack): Only declare if BYTE_MARK_STACK is set.

	* bytecode.c (BYTE_MAINTAIN_TOP): New macros.
	(struct byte_stack): Only define `top' and `bottom' if used.
	(mark_byte_stack): Only define if used.
	(BEFORE_POTENTIAL_GC, AFTER_POTENTIAL_GC): Nullify if BYTE_MAINTAIN_TOP
	is not set.
	(Fbyte_code): Don't set `bottom' unless BYTE_MAINTAIN_TOP is set.

	* term.c (OUTPUT_IF): Use OUTPUT.

	* alloc.c (Fgarbage_collect): When using stack scanning, don't
	redundantly scan byte-code stacks, catchlist, and handlerlist.

Jan Djärv's avatar
Jan Djärv committed
754 755 756 757 758 759 760
2011-02-17  Jan Djärv  <jan.h.d@swipnet.se>

	* nsfns.m (Fx_create_frame, ns_set_name_as_filename)
	(Fns_read_file_name): Replace B_ with BVAR.

	* nsterm.m (ns_term_init): Use KVAR.

761 762
2011-02-16  Eli Zaretskii  <eliz@gnu.org>

Eli Zaretskii's avatar
Eli Zaretskii committed
763 764
	* msdos.c (internal_terminal_init): Use KVAR.

765 766 767 768 769
	* w32fns.c (Fx_create_frame): Use KVAR.

	* w32term.c (w32_create_terminal): Use KVAR.

	* s/ms-w32.h (MODE_LINE_BINARY_TEXT): Remove.
770
	(getloadavg): Declare prototype which was removed from lisp.h.
771 772 773

	* xdisp.c (decode_mode_spec): Don't use MODE_LINE_BINARY_TEXT.

774 775
	* fileio.c (Finsert_file_contents, Fwrite_region):
	Remove references to buffer_file_type.
776 777 778 779 780 781 782 783 784 785 786 787 788
	(syms_of_fileio): Don't intern and staticpro
	find-buffer-file-type.

	* callproc.c (syms_of_callproc): Remove references to
	buffer_file_type.

	* buffer.c (reset_buffer_local_variables): Don't set
	buffer_file_type.
	(init_buffer_once): Likewise.
	(syms_of_buffer): Don't define buffer-file-type.

	* buffer.h (struct buffer): Remove buffer_file_type.

789 790
2011-02-16  Tom Tromey  <tromey@parfait>

791 792 793
	* callint.c (Fcall_interactively): Update for change to field names.
	* doc.c (Fsubstitute_command_keys): Update for change to field names.
	* cmds.c (Fself_insert_command): Update for change to field names.
794
	* keymap.c (Fcurrent_active_maps, Fkey_binding)
795
	(Fdescribe_buffer_bindings): Update for change to field names.
796 797
	* macros.c (Fstart_kbd_macro, end_kbd_macro, Fend_kbd_macro)
	(store_kbd_macro_char, Fcall_last_kbd_macro, Fexecute_kbd_macro):
798
	Update for change to field names.
799 800 801 802 803 804
	* keyboard.c (echo_char, echo_dash, echo_now, cancel_echoing)
	(echo_length, echo_truncate, cmd_error, command_loop_1)
	(read_char, kbd_buffer_store_event_hold, make_lispy_event)
	(menu_bar_items, tool_bar_items, read_char_minibuf_menu_prompt)
	(read_key_sequence, Fcommand_execute, Fexecute_extended_command)
	(Fdiscard_input, init_kboard, init_keyboard, mark_kboards):
805 806 807 808
	Update for change to field names.
	* xfns.c (Fx_create_frame): Update for change to field names.
	* xterm.c (x_connection_closed, x_term_init): Update for change to
	field names.
809
	* term.c (term_get_fkeys_1, CONDITIONAL_REASSIGN, init_tty):
810
	Update for change to field names.
811
	* window.c (window_scroll_pixel_based, window_scroll_line_based):
812
	Update for change to field names.
813
	* frame.c (make_frame_without_minibuffer, Fhandle_switch_frame)
814
	(delete_frame): Update for change to field names.
815 816 817 818
	* lisp.h (DEFVAR_KBOARD): Update for change to field names.
	* keyboard.h (struct kboard): Rename all Lisp_Object fields.
	(KBOARD_INTERNAL_FIELD, KVAR): New macros.

819 820 821 822
2011-02-16  Tom Tromey  <tromey@redhat.com>

	* lisp.h (DEFVAR_BUFFER_DEFAULTS): Use BVAR.

Tom Tromey's avatar
Tom Tromey committed
823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867
2011-02-16  Tom Tromey  <tromey@parfait>

	* xfns.c (x_create_tip_frame, Fx_show_tip): Replace B_ with BVAR.
	* xfaces.c (compute_char_face): Replace B_ with BVAR.
	* xdisp.c (pos_visible_p, init_iterator, reseat_1)
	(message_dolog, update_echo_area, ensure_echo_area_buffers)
	(with_echo_area_buffer, setup_echo_area_for_printing)
	(set_message_1, update_menu_bar, update_tool_bar)
	(text_outside_line_unchanged_p, redisplay_internal)
	(try_scrolling, try_cursor_movement, redisplay_window)
	(try_window_reusing_current_matrix, row_containing_pos)
	(try_window_id, get_overlay_arrow_glyph_row, display_line)
	(Fcurrent_bidi_paragraph_direction, display_mode_lines)
	(decode_mode_spec_coding, decode_mode_spec, display_count_lines)
	(get_window_cursor_type, note_mouse_highlight): Replace B_ with
	BVAR.
	* window.c (window_display_table, unshow_buffer, window_loop)
	(window_min_size_2, set_window_buffer, Fset_window_buffer)
	(select_window, Fforce_window_update, temp_output_buffer_show)
	(Fset_window_configuration, save_window_save): Replace B_ with
	BVAR.
	* w32fns.c (x_create_tip_frame, Fx_show_tip, Fw32_shell_execute):
	Replace B_ with BVAR.
	* undo.c (record_point, record_insert, record_delete)
	(record_marker_adjustment, record_first_change)
	(record_property_change, Fundo_boundary, truncate_undo_list)
	(Fprimitive_undo): Replace B_ with BVAR.
	* syntax.h (Vstandard_syntax_table, CURRENT_SYNTAX_TABLE)
	(SETUP_BUFFER_SYNTAX_TABLE): Replace B_ with BVAR.
	* syntax.c (update_syntax_table, dec_bytepos, Fsyntax_table)
	(Fset_syntax_table, Fmodify_syntax_entry, skip_chars)
	(skip_syntaxes, scan_lists): Replace B_ with BVAR.
	* search.c (compile_pattern_1, compile_pattern, looking_at_1)
	(string_match_1, fast_looking_at, newline_cache_on_off)
	(search_command, search_buffer, simple_search, boyer_moore)
	(Freplace_match): Replace B_ with BVAR.
	* process.c (get_process, list_processes_1, Fstart_process)
	(Fmake_serial_process, Fmake_network_process)
	(read_process_output, send_process, exec_sentinel)
	(status_notify, setup_process_coding_systems): Replace B_ with
	BVAR.
	* print.c (PRINTDECLARE, PRINTPREPARE, PRINTFINISH, printchar)
	(strout, print_string, temp_output_buffer_setup, print_object):
	Replace B_ with BVAR.
	* msdos.c (IT_frame_up_to_date): Replace B_ with BVAR.
868 869
	* minibuf.c (read_minibuf, get_minibuffer, Fread_buffer):
	Replace B_ with BVAR.
Tom Tromey's avatar
Tom Tromey committed
870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968
	* marker.c (Fmarker_buffer, Fset_marker, set_marker_restricted)
	(set_marker_both, set_marker_restricted_both, unchain_marker):
	Replace B_ with BVAR.
	* lread.c (readchar, unreadchar, openp, readevalloop)
	(Feval_buffer, Feval_region): Replace B_ with BVAR.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE): Replace B_ with BVAR.
	* keymap.c (Flocal_key_binding, Fuse_local_map)
	(Fcurrent_local_map, push_key_description)
	(Fdescribe_buffer_bindings): Replace B_ with BVAR.
	* keyboard.c (command_loop_1, read_char_minibuf_menu_prompt)
	(read_key_sequence): Replace B_ with BVAR.
	* intervals.h (TEXT_PROP_MEANS_INVISIBLE): Replace B_ with BVAR.
	* intervals.c (set_point_both, get_local_map): Replace B_ with
	BVAR.
	* insdel.c (check_markers, insert_char, insert_1_both)
	(insert_from_string_1, insert_from_gap, insert_from_buffer_1)
	(adjust_after_replace, replace_range, del_range_2)
	(modify_region, prepare_to_modify_buffer)
	(Fcombine_after_change_execute): Replace B_ with BVAR.
	* indent.c (buffer_display_table, recompute_width_table)
	(width_run_cache_on_off, current_column, scan_for_column)
	(Findent_to, position_indentation, compute_motion, vmotion):
	Replace B_ with BVAR.
	* fringe.c (get_logical_cursor_bitmap)
	(get_logical_fringe_bitmap, update_window_fringes): Replace B_
	with BVAR.
	* frame.c (make_frame_visible_1): Replace B_ with BVAR.
	* font.c (font_at): Replace B_ with BVAR.
	* fns.c (Fbase64_encode_region, Fbase64_decode_region, Fmd5):
	Replace B_ with BVAR.
	* filelock.c (unlock_all_files, Flock_buffer, Funlock_buffer)
	(unlock_buffer): Replace B_ with BVAR.
	* fileio.c (Fexpand_file_name, Ffile_directory_p)
	(Ffile_regular_p, Ffile_selinux_context)
	(Fset_file_selinux_context, Ffile_modes, Fset_file_modes)
	(Fset_file_times, Ffile_newer_than_file_p, decide_coding_unwind)
	(Finsert_file_contents, choose_write_coding_system)
	(Fwrite_region, build_annotations, Fverify_visited_file_modtime)
	(Fset_visited_file_modtime, auto_save_error, auto_save_1)
	(Fdo_auto_save, Fset_buffer_auto_saved): Replace B_ with BVAR.
	* editfns.c (region_limit, Fmark_marker, save_excursion_save)
	(save_excursion_restore, Fprevious_char, Fchar_before)
	(general_insert_function, Finsert_char, Finsert_byte)
	(make_buffer_string_both, Finsert_buffer_substring)
	(Fcompare_buffer_substrings, subst_char_in_region_unwind)
	(subst_char_in_region_unwind_1, Fsubst_char_in_region)
	(Ftranslate_region_internal, save_restriction_restore)
	(Fchar_equal): Replace B_ with BVAR.
	* dispnew.c (Fframe_or_buffer_changed_p): Replace B_ with BVAR.
	* dispextern.h (WINDOW_WANTS_MODELINE_P)
	(WINDOW_WANTS_HEADER_LINE_P): Replace B_ with BVAR.
	* dired.c (directory_files_internal): Replace B_ with BVAR.
	* data.c (swap_in_symval_forwarding, set_internal)
	(Fmake_local_variable, Fkill_local_variable, Flocal_variable_p):
	Replace B_ with BVAR.
	* composite.c (fill_gstring_header)
	(composition_compute_stop_pos, composition_adjust_point)
	(Ffind_composition_internal): Replace B_ with BVAR.
	* coding.c (decode_coding, encode_coding)
	(make_conversion_work_buffer, decode_coding_gap)
	(decode_coding_object, encode_coding_object)
	(Fdetect_coding_region, Ffind_coding_systems_region_internal)
	(Funencodable_char_position, Fcheck_coding_systems_region):
	Replace B_ with BVAR.
	* cmds.c (Fself_insert_command, internal_self_insert): Replace B_
	with BVAR.
	* charset.c (Ffind_charset_region): Replace B_ with BVAR.
	* character.h (FETCH_CHAR_ADVANCE, INC_BOTH, DEC_BOTH)
	(ASCII_CHAR_WIDTH): Replace B_ with BVAR.
	* character.c (chars_in_text, Fget_byte): Replace B_ with BVAR.
	* category.h (Vstandard_category_table): Replace B_ with BVAR.
	* category.c (check_category_table, Fcategory_table)
	(Fset_category_table, char_category_set): Replace B_ with BVAR.
	* casetab.c (Fcurrent_case_table, set_case_table): Replace B_ with
	BVAR.
	* casefiddle.c (casify_object, casify_region): Replace B_ with
	BVAR.
	* callproc.c (Fcall_process, Fcall_process_region): Replace B_
	with BVAR.
	* callint.c (check_mark, Fcall_interactively): Replace B_ with
	BVAR.
	* bytecode.c (Fbyte_code): Replace B_ with BVAR.
	* buffer.h (FETCH_CHAR, FETCH_CHAR_AS_MULTIBYTE, BVAR): Replace B_
	with BVAR.
	* buffer.c (Fbuffer_live_p, Fget_file_buffer)
	(get_truename_buffer, Fget_buffer_create)
	(clone_per_buffer_values, Fmake_indirect_buffer, reset_buffer)
	(reset_buffer_local_variables, Fbuffer_name, Fbuffer_file_name)
	(Fbuffer_local_value, buffer_lisp_local_variables)
	(Fset_buffer_modified_p, Frestore_buffer_modified_p)
	(Frename_buffer, Fother_buffer, Fbuffer_enable_undo)
	(Fkill_buffer, Fset_buffer_major_mode, set_buffer_internal_1)
	(set_buffer_temp, Fset_buffer, set_buffer_if_live)
	(Fbarf_if_buffer_read_only, Fbury_buffer, Ferase_buffer)
	(Fbuffer_swap_text, swapfield_, Fbuffer_swap_text)
	(Fset_buffer_multibyte, swap_out_buffer_local_variables)
	(record_overlay_string, overlay_strings, init_buffer_once)
	(init_buffer, syms_of_buffer): Replace B_ with BVAR.

969
2011-02-16  Eli Zaretskii  <eliz@gnu.org>
970 971 972 973 974

	* xdisp.c (redisplay_internal): Resynchronize `w' if the selected
	window is changed inside calls to do_pending_window_change.
	(Bug#8020)

975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000
2011-02-16  Paul Eggert  <eggert@cs.ucla.edu>

	Remove no-longer needed getloadavg symbols.
	* m/alpha.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/amdx86-64.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/ia64.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/ibms390.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/macppc.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/sparc.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/template.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* m/vax.h (LOAD_AVE_TYPE, LOAD_AVE_CVT): Remove.
	* s/aix4-2.h (KERNEL_FILE, LDAV_SYMBOL): Remove.
	* s/bsd-common.h (KERNEL_FILE, LDAV_SYMBOL): Remove #undef.
	* s/hpux10-20.h (KERNEL_FILE, LOAD_AVE_TYPE, LOAD_AVE_CVT):
	(LDAV_SYMBOL): Remove.
	* s/unixware.h (LOAD_AVE_TYPE, LOAD_AVE_CVT, FSCALE): Remove.
	* s/usg5-4-common.h (KERNEL_FILE, LDAV_SYMBOL): Remove.

	Import getloadavg module from gnulib.
	* deps.mk (getloadavg.o): Remove; gnulib now does this.
	* lisp.h (getloadavg) [!defined HAVE_GETLOADAVG]: Remove; gnulib
	now does this.
	* src/s/freebsd.h (HAVE_GETLOADAVG): Remove; gnulib now does this.
	* src/s/netbsd.h (HAVE_GETLOADAVG): Likewise.
	* config.in: Regenerate.

1001 1002 1003 1004
2011-02-15  Eli Zaretskii  <eliz@gnu.org>

	* nsfns.m (ns_set_name_as_filename, Fns_read_file_name): Use B_.

1005 1006 1007 1008 1009
2011-02-14  Michael Welsh Duggan  <md5i@md5i.com>

	* print.c (float_to_string): Ensure that a decimal point is
	printed if using dtoastr (Bug#8033).

1010 1011
2011-02-14  Eli Zaretskii  <eliz@gnu.org>

1012
	* msdos.c (IT_frame_up_to_date):
1013 1014
	* s/msdos.h (MODE_LINE_BINARY_TEXT): Use B_ for the MS-DOS build.

1015 1016 1017 1018 1019 1020 1021 1022
	* dired.c (directory_files_internal):
	* fileio.c (Finsert_file_contents):
	* insdel.c (prepare_to_modify_buffer):
	* xdisp.c (pos_visible_p):
	* s/ms-w32.h (MODE_LINE_BINARY_TEXT):
	* w32fns.c (Fw32_shell_execute, Fx_show_tip, x_create_tip_frame):
	Use B_ for the MS-Windows build.

1023 1024 1025 1026 1027 1028 1029 1030
2011-02-14  Jan Djärv  <jan.h.d@swipnet.se>

	* xrdb.c (x_load_resources): For LUCID and XFT, don't put a
	resource that specifies helvetica for menus and dialogs.

	* xmenu.c (apply_systemfont_to_dialog): Apply to *dialog.font.
	(apply_systemfont_to_menu): Set resources *menubar*font and
	*popup*font.  Remove defflt.
1031 1032
	(set_frame_menubar, create_and_show_popup_menu):
	Call apply_systemfont_to_menu before lw_create_widget.
1033

1034 1035
2011-02-14  Tom Tromey  <tromey@redhat.com>

1036 1037
	* buffer.c (init_buffer_once, syms_of_buffer): Use B_ in DOS_NT case.

1038 1039
	* keyboard.h: Remove obsolete comment.

1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060
2011-02-14  Tom Tromey  <tromey@parfait>

	* composite.c (fill_gstring_header)
	(composition_compute_stop_pos, composition_adjust_point)
	(Ffind_composition_internal): Use B_.
	* intervals.c (set_point_both, get_local_map): Use B_.
	* callproc.c (Fcall_process, Fcall_process_region): Use B_.
	* process.c (get_process, list_processes_1, Fstart_process)
	(Fmake_serial_process, Fmake_network_process)
	(read_process_output, send_process, exec_sentinel)
	(status_notify, setup_process_coding_systems): Use B_.
	* bytecode.c (Fbyte_code): Use B_.
	* syntax.c (update_syntax_table, dec_bytepos, Fsyntax_table)
	(Fset_syntax_table, Fmodify_syntax_entry, skip_chars)
	(skip_syntaxes, scan_lists): Use B_.
	* lread.c (readchar, unreadchar, openp, readevalloop)
	(Feval_buffer, Feval_region): Use B_.
	* print.c (printchar, strout, print_string, PRINTDECLARE)
	(PRINTPREPARE, PRINTFINISH, temp_output_buffer_setup)
	(print_object): Use B_.
	* font.c (font_at): Use B_.
1061 1062
	* fns.c (Fbase64_encode_region, Fbase64_decode_region, Fmd5):
	Use B_.
1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084
	* callint.c (check_mark, Fcall_interactively): Use B_.
	* editfns.c (region_limit, Fmark_marker, save_excursion_save)
	(save_excursion_restore, Fprevious_char, Fchar_before)
	(general_insert_function, Finsert_char, Finsert_byte)
	(make_buffer_string_both, Finsert_buffer_substring)
	(Fcompare_buffer_substrings, subst_char_in_region_unwind)
	(subst_char_in_region_unwind_1, Fsubst_char_in_region)
	(Ftranslate_region_internal, save_restriction_restore)
	(Fchar_equal): Use B_.
	* data.c (swap_in_symval_forwarding, set_internal)
	(Fmake_local_variable, Fkill_local_variable, Flocal_variable_p):
	Use B_.
	* undo.c (record_point, record_insert, record_delete)
	(record_marker_adjustment, record_first_change)
	(record_property_change, Fundo_boundary, truncate_undo_list)
	(Fprimitive_undo): Use B_.
	* search.c (compile_pattern_1, compile_pattern, looking_at_1)
	(string_match_1, fast_looking_at, newline_cache_on_off)
	(search_command, search_buffer, simple_search, boyer_moore)
	(Freplace_match): Use B_.
	* indent.c (buffer_display_table, recompute_width_table)
	(width_run_cache_on_off, current_column, scan_for_column)
1085 1086
	(Findent_to, position_indentation, compute_motion, vmotion):
	Use B_.
1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099
	* casefiddle.c (casify_object, casify_region): Use B_.
	* casetab.c (Fcurrent_case_table, set_case_table): Use B_.
	* cmds.c (Fself_insert_command, internal_self_insert): Use B_.
	* fileio.c (Fexpand_file_name, Ffile_directory_p)
	(Ffile_regular_p, Ffile_selinux_context)
	(Fset_file_selinux_context, Ffile_modes, Fset_file_modes)
	(Fset_file_times, Ffile_newer_than_file_p, decide_coding_unwind)
	(Finsert_file_contents, choose_write_coding_system)
	(Fwrite_region, build_annotations, Fverify_visited_file_modtime)
	(Fset_visited_file_modtime, auto_save_error, auto_save_1)
	(Fdo_auto_save, Fset_buffer_auto_saved): Use B_.
	* minibuf.c (read_minibuf, get_minibuffer, Fread_buffer): Use B_.
	* marker.c (Fmarker_buffer, Fset_marker, set_marker_restricted)
1100 1101
	(set_marker_both, set_marker_restricted_both, unchain_marker):
	Use B_.
1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
	* insdel.c (check_markers, insert_char, insert_1_both)
	(insert_from_string_1, insert_from_gap, insert_from_buffer_1)
	(adjust_after_replace, replace_range, del_range_2)
	(modify_region, prepare_to_modify_buffer)
	(Fcombine_after_change_execute): Use B_.
	* filelock.c (unlock_all_files, Flock_buffer, Funlock_buffer)
	(unlock_buffer): Use B_.
	* keymap.c (Flocal_key_binding, Fuse_local_map)
	(Fcurrent_local_map, push_key_description)
	(Fdescribe_buffer_bindings): Use B_.
	* keyboard.c (command_loop_1, read_char_minibuf_menu_prompt)
	(read_key_sequence): Use B_.
	* fringe.c (get_logical_cursor_bitmap)
	(get_logical_fringe_bitmap, update_window_fringes): Use B_.
	* xfns.c (x_create_tip_frame, Fx_show_tip): Use B_.
	* xfaces.c (compute_char_face): Use B_.
	* character.c (chars_in_text, Fget_byte): Use B_.
	* category.c (check_category_table, Fcategory_table)
	(Fset_category_table, char_category_set): Use B_.
	* coding.c (decode_coding, encode_coding)
	(make_conversion_work_buffer, decode_coding_gap)
	(decode_coding_object, encode_coding_object)
	(Fdetect_coding_region, Ffind_coding_systems_region_internal)
1125 1126
	(Funencodable_char_position, Fcheck_coding_systems_region):
	Use B_.
1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176
	* charset.c (Ffind_charset_region): Use B_.
	* window.c (window_display_table, unshow_buffer, window_loop)
	(window_min_size_2, set_window_buffer, Fset_window_buffer)
	(select_window, Fforce_window_update, temp_output_buffer_show)
	(Fset_window_configuration, save_window_save): Use B_.
	* xdisp.c (pos_visible_p, init_iterator, reseat_1)
	(message_dolog, update_echo_area, ensure_echo_area_buffers)
	(with_echo_area_buffer, setup_echo_area_for_printing)
	(set_message_1, update_menu_bar, update_tool_bar)
	(text_outside_line_unchanged_p, redisplay_internal)
	(try_scrolling, try_cursor_movement, redisplay_window)
	(try_window_reusing_current_matrix, row_containing_pos)
	(try_window_id, get_overlay_arrow_glyph_row, display_line)
	(Fcurrent_bidi_paragraph_direction, display_mode_lines)
	(decode_mode_spec_coding, decode_mode_spec, display_count_lines)
	(get_window_cursor_type, note_mouse_highlight): Use B_.
	* frame.c (make_frame_visible_1): Use B_.
	* dispnew.c (Fframe_or_buffer_changed_p): Use B_.
	* dispextern.h (WINDOW_WANTS_HEADER_LINE_P)
	(WINDOW_WANTS_MODELINE_P): Use B_.
	* syntax.h (Vstandard_syntax_table): Update.
	(CURRENT_SYNTAX_TABLE, SETUP_BUFFER_SYNTAX_TABLE): Use B_.
	* intervals.h (TEXT_PROP_MEANS_INVISIBLE): Update.
	(TEXT_PROP_MEANS_INVISIBLE): Use B_.
	* character.h (FETCH_CHAR_ADVANCE): Update.
	(INC_BOTH, ASCII_CHAR_WIDTH, DEC_BOTH): Use B_.
	* category.h (Vstandard_category_table): Update.
	* lisp.h (DEFVAR_BUFFER_DEFAULTS): Update for change to field
	names.
	(DOWNCASE_TABLE, UPCASE_TABLE): Use B_.
	* buffer.c (swapfield_): New macro.
	(Fbuffer_swap_text): Use swapfield_ where appropriate.
	(Fbuffer_live_p, Fget_file_buffer, get_truename_buffer)
	(Fget_buffer_create, clone_per_buffer_values)
	(Fmake_indirect_buffer, reset_buffer)
	(reset_buffer_local_variables, Fbuffer_name, Fbuffer_file_name)
	(Fbuffer_local_value, buffer_lisp_local_variables)
	(Fset_buffer_modified_p, Frestore_buffer_modified_p)
	(Frename_buffer, Fother_buffer, Fbuffer_enable_undo)
	(Fkill_buffer, Fset_buffer_major_mode, set_buffer_internal_1)
	(set_buffer_temp, Fset_buffer, set_buffer_if_live)
	(Fbarf_if_buffer_read_only, Fbury_buffer, Ferase_buffer)
	(Fbuffer_swap_text, Fset_buffer_multibyte)
	(swap_out_buffer_local_variables, record_overlay_string)
	(overlay_strings, init_buffer_once, init_buffer, syms_of_buffer):
	Use B_.
	* buffer.h (struct buffer): Rename all Lisp_Object fields.
	(BUFFER_INTERNAL_FIELD, B_): New macro.
	(FETCH_CHAR, FETCH_CHAR_AS_MULTIBYTE): Use B_.

1177 1178 1179 1180 1181
2011-02-14  Jan Djärv  <jan.h.d@swipnet.se>

	* gtkutil.c (xg_tool_bar_menu_proxy): Handle case when tool bar label
	is null.

Jan D's avatar
Jan D committed
1182 1183 1184 1185 1186 1187
2011-02-13  Jan Djärv  <jan.h.d@swipnet.se>

	* callproc.c (Fcall_process):
	* process.c (create_process): Replace Gtk with GConf in SIGPIPE
	comment.

1188
2011-02-12  Martin Rudalics  <rudalics@gmx.at>
Martin Rudalics's avatar
Martin Rudalics committed
1189 1190 1191 1192

	* window.c (select_window): Check inhibit_point_swap argument when
	deciding whether to return immediately.

1193
2011-02-12  Jan Djärv  <jan.h.d@swipnet.se>
1194 1195 1196 1197

	* nsterm.m (setFrame, initFrame): Make sure pixel_height doesn't become
	zero (Bug#7348).

1198 1199 1200 1201 1202 1203 1204
2011-02-12  Chong Yidong  <cyd@stupidchicken.com>

	* config.in (TERMINFO): New definition.

	* s/netbsd.h: Use it to choose between terminfo and termcap
	(Bug#7642).

1205 1206 1207 1208 1209 1210 1211
2011-02-12  Paul Eggert  <eggert@cs.ucla.edu>

	* md5.c (md5_process_bytes): Use sizeof, not __alignof__.
	The difference doesn't matter here, in practice, and sizeof is
	more portable to non-GCC compilers.  Also, this makes the code
	match the already-existing comment.

1212 1213 1214 1215 1216
2011-02-12  Andreas Schwab  <schwab@linux-m68k.org>

	* process.c (create_process): Reset SIGPIPE handler in the child.
	* callproc.c (Fcall_process): Likewise.  (Bug#5238)

1217 1218 1219 1220 1221 1222 1223 1224 1225
2011-02-12  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c <this_line_min_pos>: New variable.
	(move_it_in_display_line_to): Record in this_line_min_pos the
	smallest position iterated across.
	(display_line): Use this_line_min_pos to record the smallest
	position in the line even if it is not displayed due to
	hscrolling.  (Bug#7939)

1226 1227
2011-02-12  Paul Eggert  <eggert@cs.ucla.edu>

1228 1229 1230 1231
	Port to Sun C 5.11, which has __attribute__ ((__aligned (N))).
	* md5.h (ATTRIBUTE_ALIGNED): New macro.
	(struct md5_ctx): Use it.

1232 1233 1234 1235 1236 1237
	Port to Solaris 10, which doesn't support FC_HINT_STYLE.
	* xftfont.c (FC_HINT_STYLE): #define to "hintstyle" if not
	defined.
	* xsettings.c (parse_settings, apply_xft_settings): Don't assume
	FC_HINT_STYLE is supported.

1238 1239 1240 1241 1242
2011-02-11  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.c (x_set_frame_alpha): Access data before it is free:d.
	Make sure we don't do x_catch_errors twice.

1243 1244 1245 1246
2011-02-10  Glenn Morris  <rgm@gnu.org>

	* Makefile.in (really-lwlib): Depend on globals.h, for parallel builds.

1247 1248
2011-02-09  Eli Zaretskii  <eliz@gnu.org>

1249 1250
	* makefile.w32-in (GLOBAL_SOURCES, SOME_MACHINE_OBJECTS, obj):
	New macros.
1251 1252 1253
	(globals.h, gl-stamp): New targets.
	(clean): Clean gl-stamp and globals.h.

1254 1255 1256 1257 1258 1259
2011-02-09  Andreas Schwab  <schwab@linux-m68k.org>

	* Makefile.in (gl-stamp): Create globals.h here.
	(globals.h): Don't do it here.
	(mostlyclean): Clean globals.h and gl-stamp.

1260 1261 1262 1263 1264 1265
2011-02-09  Paul Eggert  <eggert@cs.ucla.edu>

	* Makefile.in ($(otherobj)): Depend on globals.h.
	Otherwise 'make -j10' failed on my host, because the build lacked
	necessary dependencies, e.g., vm-limit.o depends on globals.h.

Tom Tromey's avatar
Tom Tromey committed
1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279
2011-02-08  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (NS_OBJC_OBJ): New variable.
	(base_obj): Rename from 'obj'.
	(obj): New variable.
	(globals.h, gl-stamp, $(obj)): New targets.
	(GLOBAL_SOURCES): New variable.
	* globals.h: Remove.
	* nsselect.m (Vselection_alist): Define.  Reverts part of
	2011-01-19T22:11:33Z!jan.h.d@swipnet.se.
	* buffer.c: Don't use "no_cell" for name of kill-buffer-hook's
	variable.
	* xselect.c (Vselection_alist): Define.  Reverts part of 2011-01-19T23:32:42Z!eggert@cs.ucla.edu.

1280 1281 1282 1283
2011-02-08  Kenichi Handa  <handa@m17n.org>

	* font.c (Ffont_get): Do not cache :otf value.

1284 1285 1286 1287 1288 1289 1290
2011-02-07  Paul Eggert  <eggert@cs.ucla.edu>

	conform to C89 pointer rules

	* dired.c (scmp, file_name_completion):
	Change types between char * and unsigned char *, to satisfy C89
	rules about pointer type compatibility.
Paul Eggert's avatar