xterm.c 208 KB
Newer Older
Jim Blandy's avatar
Jim Blandy committed
1
/* X Communication module for terminals which understand the X protocol.
2
   Copyright (C) 1989, 93, 94, 95, 96, 1997 Free Software Foundation, Inc.
Jim Blandy's avatar
Jim Blandy committed
3 4 5 6 7

This file is part of GNU Emacs.

GNU Emacs is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
Jim Blandy's avatar
Jim Blandy committed
8
the Free Software Foundation; either version 2, or (at your option)
Jim Blandy's avatar
Jim Blandy committed
9 10 11 12 13 14 15 16 17
any later version.

GNU Emacs is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Emacs; see the file COPYING.  If not, write to
18 19
the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA.  */
Jim Blandy's avatar
Jim Blandy committed
20

21 22
/* Xt features made by Fred Pierresteguy.  */

23 24 25 26 27
/* On 4.3 these lose if they come after xterm.h.  */
/* On HP-UX 8.0 signal.h loses if it comes after config.h.  */
/* Putting these at the beginning seems to be standard for other .c files.  */
#include <signal.h>

28
#include <config.h>
Jim Blandy's avatar
Jim Blandy committed
29

30 31
#include <stdio.h>

32
/* Need syssignal.h for various externs and definitions that may be required
33
   by some configurations for calls to signal later in this source file.  */
34 35
#include "syssignal.h"

Jim Blandy's avatar
Jim Blandy committed
36 37 38
#ifdef HAVE_X_WINDOWS

#include "lisp.h"
39
#include "blockinput.h"
Jim Blandy's avatar
Jim Blandy committed
40 41 42 43

/* This may include sys/types.h, and that somehow loses
   if this is not done before the other system files.  */
#include "xterm.h"
44
#include <X11/cursorfont.h>
Jim Blandy's avatar
Jim Blandy committed
45

46
#ifndef USG
Jim Blandy's avatar
Jim Blandy committed
47 48 49 50
/* Load sys/types.h if not already loaded.
   In some systems loading it twice is suicidal.  */
#ifndef makedev
#include <sys/types.h>
51 52
#endif /* makedev */
#endif /* USG */
Jim Blandy's avatar
Jim Blandy committed
53

54
#ifdef BSD_SYSTEM
Jim Blandy's avatar
Jim Blandy committed
55
#include <sys/ioctl.h>
56
#endif /* ! defined (BSD_SYSTEM) */
Jim Blandy's avatar
Jim Blandy committed
57

58
#include "systty.h"
Jim Blandy's avatar
Jim Blandy committed
59
#include "systime.h"
Jim Blandy's avatar
Jim Blandy committed
60

61
#ifndef INCLUDED_FCNTL
Jim Blandy's avatar
Jim Blandy committed
62
#include <fcntl.h>
63
#endif
Jim Blandy's avatar
Jim Blandy committed
64 65 66 67
#include <ctype.h>
#include <errno.h>
#include <setjmp.h>
#include <sys/stat.h>
Richard M. Stallman's avatar
Richard M. Stallman committed
68 69
/* Caused redefinition of DBL_DIG on Netbsd; seems not to be needed.  */
/* #include <sys/param.h>  */
Jim Blandy's avatar
Jim Blandy committed
70

71 72 73
#include "charset.h"
#include "ccl.h"
#include "fontset.h"
74
#include "frame.h"
Jim Blandy's avatar
Jim Blandy committed
75 76 77 78 79 80 81
#include "dispextern.h"
#include "termhooks.h"
#include "termopts.h"
#include "termchar.h"
#if 0
#include "sink.h"
#include "sinkmask.h"
82
#endif /* ! 0 */
Jim Blandy's avatar
Jim Blandy committed
83 84 85
#include "gnu.h"
#include "disptab.h"
#include "buffer.h"
86
#include "window.h"
Richard M. Stallman's avatar
Richard M. Stallman committed
87
#include "keyboard.h"
Karl Heuer's avatar
Karl Heuer committed
88
#include "intervals.h"
Andreas Schwab's avatar
Andreas Schwab committed
89
#include "process.h"
Jim Blandy's avatar
Jim Blandy committed
90

91 92 93 94
#ifdef USE_X_TOOLKIT
#include <X11/Shell.h>
#endif

95
#ifdef USE_X_TOOLKIT
96
extern void free_frame_menubar ();
97
extern FRAME_PTR x_menubar_window_to_frame ();
98 99 100 101
#if (XtSpecificationRelease >= 5) && !defined(NO_EDITRES)
#define HACK_EDITRES
extern void _XEditResCheckMessages ();
#endif /* not NO_EDITRES */
102 103
#endif /* USE_X_TOOLKIT */

104 105
#ifndef USE_X_TOOLKIT
#define x_any_window_to_frame x_window_to_frame
106
#define x_top_window_to_frame x_window_to_frame
107 108
#endif

109
#ifdef USE_X_TOOLKIT
Karl Heuer's avatar
Karl Heuer committed
110
#include "widget.h"
111 112 113 114 115
#ifndef XtNinitialState
#define XtNinitialState "initialState"
#endif
#endif

116
#ifdef HAVE_SETLOCALE
Karl Heuer's avatar
Karl Heuer committed
117 118 119 120
/* So we can do setlocale.  */
#include <locale.h>
#endif

Karl Heuer's avatar
Karl Heuer committed
121 122 123 124 125 126 127
#ifdef SOLARIS2
/* memmove will be defined as a macro in Xfuncs.h unless
   <string.h> is included beforehand.  The declaration for memmove in
   <string.h> will cause a syntax error when Xfuncs.h later includes it.  */
#include <string.h>
#endif

128
#ifndef min
Jim Blandy's avatar
Jim Blandy committed
129
#define min(a,b) ((a)<(b) ? (a) : (b))
130 131
#endif
#ifndef max
Jim Blandy's avatar
Jim Blandy committed
132
#define max(a,b) ((a)>(b) ? (a) : (b))
133
#endif
134

135 136
/* This is a chain of structures for all the X displays currently in use.  */
struct x_display_info *x_display_list;
Jim Blandy's avatar
Jim Blandy committed
137

138 139 140 141 142
/* This is a list of cons cells, each of the form (NAME . FONT-LIST-CACHE),
   one for each element of x_display_list and in the same order.
   NAME is the name of the frame.
   FONT-LIST-CACHE records previous values returned by x-list-fonts.  */
Lisp_Object x_display_name_list;
143

144
/* Frame being updated by update_frame.  This is declared in term.c.
145
   This is set by update_begin and looked at by all the
Jim Blandy's avatar
Jim Blandy committed
146
   XT functions.  It is zero while not inside an update.
Jim Blandy's avatar
Jim Blandy committed
147 148
   In that case, the XT functions assume that `selected_frame'
   is the frame to apply to.  */
149
extern struct frame *updating_frame;
Jim Blandy's avatar
Jim Blandy committed
150

Andreas Schwab's avatar
Andreas Schwab committed
151
extern int waiting_for_input;
152

153 154 155
/* This is a frame waiting to be autoraised, within XTread_socket.  */
struct frame *pending_autoraise_frame;

156 157 158
#ifdef USE_X_TOOLKIT
/* The application context for Xt use.  */
XtAppContext Xt_app_con;
159 160 161 162 163

static String Xt_default_resources[] =
{
  0
};
164 165
#endif

Jim Blandy's avatar
Jim Blandy committed
166 167 168 169 170 171 172 173 174 175 176 177 178 179
/* During an update, maximum vpos for ins/del line operations to affect.  */

static int flexlines;

/* During an update, nonzero if chars output now should be highlighted.  */

static int highlight;

/* Nominal cursor position -- where to draw output.
   During an update, these are different from the cursor-box position.  */

static int curs_x;
static int curs_y;

180 181
/* Mouse movement.

182 183 184 185 186 187 188
   Formerly, we used PointerMotionHintMask (in STANDARD_EVENT_MASK)
   so that we would have to call XQueryPointer after each MotionNotify
   event to ask for another such event.  However, this made mouse tracking
   slow, and there was a bug that made it eventually stop.

   Simply asking for MotionNotify all the time seems to work better.

189 190 191 192 193 194 195 196 197
   In order to avoid asking for motion events and then throwing most
   of them away or busy-polling the server for mouse positions, we ask
   the server for pointer motion hints.  This means that we get only
   one event per group of mouse movements.  "Groups" are delimited by
   other kinds of events (focus changes and button clicks, for
   example), or by XQueryPointer calls; when one of these happens, we
   get another MotionNotify event the next time the mouse moves.  This
   is at least as efficient as getting motion events when mouse
   tracking is on, and I suspect only negligibly worse when tracking
198
   is off.  */
199 200 201 202 203

/* Where the mouse was last time we reported a mouse event.  */
static FRAME_PTR last_mouse_frame;
static XRectangle last_mouse_glyph;

204 205
static Lisp_Object last_mouse_press_frame;

206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
/* The scroll bar in which the last X motion event occurred.

   If the last X motion event occurred in a scroll bar, we set this
   so XTmouse_position can know whether to report a scroll bar motion or
   an ordinary motion.

   If the last X motion event didn't occur in a scroll bar, we set this
   to Qnil, to tell XTmouse_position to return an ordinary motion event.  */
static Lisp_Object last_mouse_scroll_bar;

/* This is a hack.  We would really prefer that XTmouse_position would
   return the time associated with the position it returns, but there
   doesn't seem to be any way to wrest the timestamp from the server
   along with the position query.  So, we just keep track of the time
   of the last movement we received, and return that in hopes that
   it's somewhat accurate.  */
static Time last_mouse_movement_time;

224 225 226 227 228 229 230
/* Incremented by XTread_socket whenever it really tries to read events.  */
#ifdef __STDC__
static int volatile input_signal_count;
#else
static int input_signal_count;
#endif

231 232
/* Used locally within XTread_socket.  */
static int x_noop_count;
Jim Blandy's avatar
Jim Blandy committed
233

234 235 236
/* Initial values of argv and argc.  */
extern char **initial_argv;
extern int initial_argc;
Jim Blandy's avatar
Jim Blandy committed
237

238
extern Lisp_Object Vcommand_line_args, Vsystem_name;
Jim Blandy's avatar
Jim Blandy committed
239

240 241 242
/* Tells if a window manager is present or not. */

extern Lisp_Object Vx_no_window_manager;
Jim Blandy's avatar
Jim Blandy committed
243

244
extern Lisp_Object Qface, Qmouse_face;
245

Jim Blandy's avatar
Jim Blandy committed
246 247
extern int errno;

248
/* A mask of extra modifier bits to put into every keyboard char.  */
249 250
extern int extra_keyboard_modifiers;

251 252
static Lisp_Object Qvendor_specific_keysyms;

253
extern XrmDatabase x_load_resources ();
Jim Blandy's avatar
Jim Blandy committed
254

255 256
extern Lisp_Object x_icon_type ();

257 258
void x_delete_display ();

259
static void redraw_previous_char ();
260
static void redraw_following_char ();
261
static unsigned int x_x_to_emacs_modifiers ();
Jim Blandy's avatar
Jim Blandy committed
262

263
static int fast_find_position ();
264 265 266
static void note_mouse_highlight ();
static void clear_mouse_face ();
static void show_mouse_face ();
267
static void do_line_dance ();
268

Andreas Schwab's avatar
Andreas Schwab committed
269 270
static void XTcursor_to ();
static void XTclear_end_of_line ();
271
static int x_io_error_quitter ();
272
int x_catch_errors ();
273
void x_uncatch_errors ();
274

275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302
#if 0
/* This is a function useful for recording debugging information
   about the sequence of occurrences in this file.  */

struct record 
{
  char *locus;
  int type;
};

struct record event_record[100];

int event_record_index;

record_event (locus, type)
     char *locus;
     int type;
{
  if (event_record_index == sizeof (event_record) / sizeof (struct record))
    event_record_index = 0;

  event_record[event_record_index].locus = locus;
  event_record[event_record_index].type = type;
  event_record_index++;
}

#endif /* 0 */

303 304 305 306 307 308 309 310 311 312 313
/* Return the struct x_display_info corresponding to DPY.  */

struct x_display_info *
x_display_info_for_display (dpy)
     Display *dpy;
{
  struct x_display_info *dpyinfo;

  for (dpyinfo = x_display_list; dpyinfo; dpyinfo = dpyinfo->next)
    if (dpyinfo->display == dpy)
      return dpyinfo;
314

315 316
  return 0;
}
Jim Blandy's avatar
Jim Blandy committed
317

318
/* Starting and ending updates.
319 320

   These hooks are called by update_frame at the beginning and end
Jim Blandy's avatar
Jim Blandy committed
321 322 323
   of a frame update.  We record in `updating_frame' the identity
   of the frame being updated, so that the XT... functions do not
   need to take a frame as argument.  Most of the XT... functions
Jim Blandy's avatar
Jim Blandy committed
324
   should never be called except during an update, the only exceptions
325
   being XTcursor_to, XTwrite_glyphs and XTreassert_line_highlight.  */
Jim Blandy's avatar
Jim Blandy committed
326

Andreas Schwab's avatar
Andreas Schwab committed
327
static void
Jim Blandy's avatar
Jim Blandy committed
328 329
XTupdate_begin (f)
     struct frame *f;
330
{
Jim Blandy's avatar
Jim Blandy committed
331 332
  int mask;

Jim Blandy's avatar
Jim Blandy committed
333
  if (f == 0)
Jim Blandy's avatar
Jim Blandy committed
334 335
    abort ();

Jim Blandy's avatar
Jim Blandy committed
336
  flexlines = f->height;
Jim Blandy's avatar
Jim Blandy committed
337 338 339
  highlight = 0;

  BLOCK_INPUT;
340

341 342 343
  curs_x = FRAME_CURSOR_X (f);
  curs_y = FRAME_CURSOR_Y (f);

344
  if (f == FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_frame)
345
    {
346
      /* Don't do highlighting for mouse motion during the update.  */
347
      FRAME_X_DISPLAY_INFO (f)->mouse_face_defer = 1;
348 349 350

      /* If the frame needs to be redrawn,
	 simply forget about any prior mouse highlighting.  */
351
      if (FRAME_GARBAGED_P (f))
352 353
	FRAME_X_DISPLAY_INFO (f)->mouse_face_window = Qnil;

354
      if (!NILP (FRAME_X_DISPLAY_INFO (f)->mouse_face_window))
355 356
	{
	  int firstline, lastline, i;
357
	  struct window *w = XWINDOW (FRAME_X_DISPLAY_INFO (f)->mouse_face_window);
358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373

	  /* Find the first, and the last+1, lines affected by redisplay.  */
	  for (firstline = 0; firstline < f->height; firstline++)
	    if (FRAME_DESIRED_GLYPHS (f)->enable[firstline])
	      break;

	  lastline = f->height;
	  for (i = f->height - 1; i >= 0; i--)
	    {
	      if (FRAME_DESIRED_GLYPHS (f)->enable[i])
		break;
	      else
		lastline = i;
	    }

	  /* Can we tell that this update does not affect the window
374 375 376 377
	     where the mouse highlight is?  If so, no need to turn off.
	     Likewise, don't do anything if the frame is garbaged;
	     in that case, the FRAME_CURRENT_GLYPHS that we would use
	     are all wrong, and we will redisplay that line anyway.  */
378 379
	  if (! (firstline > (XFASTINT (w->top) + window_internal_height (w))
		 || lastline < XFASTINT (w->top)))
380
	    clear_mouse_face (FRAME_X_DISPLAY_INFO (f));
381
	}
382
    }
Richard M. Stallman's avatar
Richard M. Stallman committed
383

Jim Blandy's avatar
Jim Blandy committed
384 385 386
  UNBLOCK_INPUT;
}

Andreas Schwab's avatar
Andreas Schwab committed
387
static void
Jim Blandy's avatar
Jim Blandy committed
388 389
XTupdate_end (f)
     struct frame *f;
390
{
Jim Blandy's avatar
Jim Blandy committed
391 392 393 394
  int mask;

  BLOCK_INPUT;

395
  do_line_dance ();
396
  x_display_cursor (f, 1, curs_x, curs_y);
Jim Blandy's avatar
Jim Blandy committed
397

398
  FRAME_X_DISPLAY_INFO (f)->mouse_face_defer = 0;
399 400 401 402 403 404 405
#if 0
  /* This fails in the case of having updated only the echo area
     if we have switched buffers.  In that case, FRAME_CURRENT_GLYPHS
     has no relation to the current contents, and its charstarts
     have no relation to the contents of the window-buffer.
  I don't know a clean way to check
     for that case.  window_end_valid isn't set up yet.  */
406 407 408
  if (f == FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_frame)
    note_mouse_highlight (f, FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_x,
			  FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_y);
409 410
#endif

411
  XFlush (FRAME_X_DISPLAY (f));
Jim Blandy's avatar
Jim Blandy committed
412 413
  UNBLOCK_INPUT;
}
414

415
/* This is called after a redisplay on frame F.  */
416

Andreas Schwab's avatar
Andreas Schwab committed
417
static void
418 419 420
XTframe_up_to_date (f)
     FRAME_PTR f;
{
421
  BLOCK_INPUT;
422 423
  if (FRAME_X_DISPLAY_INFO (f)->mouse_face_deferred_gc
      || f == FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_frame)
424
    {
425 426 427 428
      if (FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_frame)
	note_mouse_highlight (FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_frame,
			      FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_x,
			      FRAME_X_DISPLAY_INFO (f)->mouse_face_mouse_y);
429
      FRAME_X_DISPLAY_INFO (f)->mouse_face_deferred_gc = 0;
430
    }
431
  UNBLOCK_INPUT;
432
}
Jim Blandy's avatar
Jim Blandy committed
433 434 435 436 437

/* External interface to control of standout mode.
   Call this when about to modify line at position VPOS
   and not change whether it is highlighted.  */

Andreas Schwab's avatar
Andreas Schwab committed
438
void
Jim Blandy's avatar
Jim Blandy committed
439 440 441 442 443 444 445 446 447
XTreassert_line_highlight (new, vpos)
     int new, vpos;
{
  highlight = new;
}

/* Call this when about to modify line at position VPOS
   and change whether it is highlighted.  */

Andreas Schwab's avatar
Andreas Schwab committed
448
static void
Jim Blandy's avatar
Jim Blandy committed
449 450 451 452 453
XTchange_line_highlight (new_highlight, vpos, first_unused_hpos)
     int new_highlight, vpos, first_unused_hpos;
{
  highlight = new_highlight;
  XTcursor_to (vpos, 0);
454
  XTclear_end_of_line (FRAME_WINDOW_WIDTH (updating_frame));
Jim Blandy's avatar
Jim Blandy committed
455 456 457 458 459 460
}

/* This is used when starting Emacs and when restarting after suspend.
   When starting Emacs, no X window is mapped.  And nothing must be done
   to Emacs's own window if it is suspended (though that rarely happens).  */

Andreas Schwab's avatar
Andreas Schwab committed
461
static void
Jim Blandy's avatar
Jim Blandy committed
462 463 464 465 466 467 468 469
XTset_terminal_modes ()
{
}

/* This is called when exiting or suspending Emacs.
   Exiting will make the X-windows go away, and suspending
   requires no action.  */

Andreas Schwab's avatar
Andreas Schwab committed
470
static void
Jim Blandy's avatar
Jim Blandy committed
471 472
XTreset_terminal_modes ()
{
Jim Blandy's avatar
Jim Blandy committed
473
/*  XTclear_frame ();  */
Jim Blandy's avatar
Jim Blandy committed
474 475
}

476 477
/* Set the nominal cursor position of the frame.
   This is where display update commands will take effect.
Jim Blandy's avatar
Jim Blandy committed
478 479
   This does not affect the place where the cursor-box is displayed.  */

Andreas Schwab's avatar
Andreas Schwab committed
480
static void
Jim Blandy's avatar
Jim Blandy committed
481 482 483 484 485 486 487 488 489
XTcursor_to (row, col)
     register int row, col;
{
  int mask;
  int orow = row;

  curs_x = col;
  curs_y = row;

Jim Blandy's avatar
Jim Blandy committed
490
  if (updating_frame == 0)
Jim Blandy's avatar
Jim Blandy committed
491 492
    {
      BLOCK_INPUT;
493
      x_display_cursor (selected_frame, 1, curs_x, curs_y);
494
      XFlush (FRAME_X_DISPLAY (selected_frame));
Jim Blandy's avatar
Jim Blandy committed
495 496 497 498
      UNBLOCK_INPUT;
    }
}

499 500 501 502 503 504 505 506 507 508 509 510 511

/* Return a pointer to per char metric information in FONT of a
   character pointed by B (*XChar2b).  */

#define PER_CHAR_METRIC(font, b)					   \
  ((font)->per_char							   \
   ? ((font)->per_char + (b)->byte2 - (font)->min_char_or_byte2		   \
      + (((font)->min_byte1 || (font)->max_byte1)			   \
	 ? (((b)->byte1 - (font)->min_byte1)				   \
	    * ((font)->max_char_or_byte2 - (font)->min_char_or_byte2 + 1)) \
	 : 0))								   \
   : &((font)->max_bounds))

Jim Blandy's avatar
Jim Blandy committed
512 513
/* Display a sequence of N glyphs found at GP.
   WINDOW is the x-window to output to.  LEFT and TOP are starting coords.
514 515
   HL is 1 if this text is highlighted, 2 if the cursor is on it,
   3 if should appear in its mouse-face.
516 517
   JUST_FOREGROUND if 1 means draw only the foreground;
   don't alter the background.
Jim Blandy's avatar
Jim Blandy committed
518

519 520 521 522 523
   CMPCHARP if non NULL is a pointer to the struct cmpchar_info, which
   means drawing glyphs on the same column.  This is set to non NULL
   only when recursively called within dumpglyphs to draw a composite
   character specified by CMPCHAR.

524
   FONT is the default font to use (for glyphs whose font-code is 0).
Jim Blandy's avatar
Jim Blandy committed
525

526 527 528
   Since the display generation code is responsible for calling
   compute_char_face and compute_glyph_face on everything it puts in
   the display structure, we can assume that the face code on each
529
   glyph is a valid index into FRAME_COMPUTED_FACES (f), and the one
530
   to which we can actually apply intern_face.
531 532 533
   Call this function with input blocked.

   Return overall pixel width of the drawn glyphs.  */
Jim Blandy's avatar
Jim Blandy committed
534

535 536
#if 1
/* This is the multi-face code.  */
Jim Blandy's avatar
Jim Blandy committed
537

538 539
static int
dumpglyphs (f, left, top, gp, n, hl, just_foreground, cmpcharp)
Jim Blandy's avatar
Jim Blandy committed
540
     struct frame *f;
Jim Blandy's avatar
Jim Blandy committed
541 542 543 544
     int left, top;
     register GLYPH *gp; /* Points to first GLYPH. */
     register int n;  /* Number of glyphs to display. */
     int hl;
545
     int just_foreground;
546
     struct cmpchar_info *cmpcharp;
Jim Blandy's avatar
Jim Blandy committed
547
{
548
  /* Holds characters to be displayed. */
549 550 551 552 553
  XChar2b *x_2byte_buffer
    = (XChar2b *) alloca (FRAME_WINDOW_WIDTH (f) * sizeof (*x_2byte_buffer));
  register XChar2b *cp;		/* Steps through x_2byte_buffer[]. */
  char *x_1byte_buffer
    = (char *) alloca (FRAME_WINDOW_WIDTH (f) * sizeof (*x_1byte_buffer));
Jim Blandy's avatar
Jim Blandy committed
554 555
  register int tlen = GLYPH_TABLE_LENGTH;
  register Lisp_Object *tbase = GLYPH_TABLE_BASE;
556
  Window window = FRAME_X_WINDOW (f);
557
  int orig_left = left;
558
  int gidx = 0;
559
  int i;
Jim Blandy's avatar
Jim Blandy committed
560

561
  while (n > 0)
Jim Blandy's avatar
Jim Blandy committed
562 563 564
    {
      /* Get the face-code of the next GLYPH.  */
      int cf, len;
565
      GLYPH g = *gp;
566 567
      int ch, charset;
      Lisp_Object first_ch;
568 569 570
      /* HIGHEST and LOWEST are used while drawing a composite
         character.  The meanings are described later.  */
      int highest, lowest;
Jim Blandy's avatar
Jim Blandy committed
571

572
      GLYPH_FOLLOW_ALIASES (tbase, tlen, g);
573 574
      cf = (cmpcharp ? cmpcharp->face_work : FAST_GLYPH_FACE (g));
      ch = FAST_GLYPH_CHAR (g);
575
      if (gidx == 0) XSETFASTINT (first_ch, ch);
576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597
      charset = CHAR_CHARSET (ch);
      if (charset == CHARSET_COMPOSITION)
	{
	  /* We must draw components of the composite character on the
             same column.  */
	  cmpcharp = cmpchar_table[COMPOSITE_CHAR_ID (ch)];

	  /* Set the face in the slot for work.  */
	  cmpcharp->face_work = cf;

	  /* We don't need the return value ... */
	  dumpglyphs (f, left, top, cmpcharp->glyph, cmpcharp->glyph_len,
		      hl, just_foreground, cmpcharp);
	  /* ... because the width of just drawn text can be
             calculated as follows.  */
	  left += FONT_WIDTH (f->output_data.x->font) * cmpcharp->width;

	  ++gp, --n;
	  while (gp && (*gp & GLYPH_MASK_PADDING)) ++gp, --n;
	  cmpcharp = NULL;
	  continue;
	}
Jim Blandy's avatar
Jim Blandy committed
598

599 600
      /* Find the run of consecutive glyphs which can be drawn with
	 the same GC (i.e. the same charset and the same face-code).
601
	 Extract their character codes into X_2BYTE_BUFFER.
602 603
	 If CMPCHARP is not NULL, face-code is not checked because we
	 use only the face specified in `cmpcharp->face_work'.  */
604
      cp = x_2byte_buffer;
Jim Blandy's avatar
Jim Blandy committed
605 606
      while (n > 0)
	{
607 608
	  int this_charset, c1, c2;

Jim Blandy's avatar
Jim Blandy committed
609
	  g = *gp;
610
	  GLYPH_FOLLOW_ALIASES (tbase, tlen, g);
611 612 613 614
	  ch = FAST_GLYPH_CHAR (g);
	  SPLIT_CHAR (ch, this_charset, c1, c2);
	  if (this_charset != charset
	      || (cmpcharp == NULL && FAST_GLYPH_FACE (g) != cf))
Jim Blandy's avatar
Jim Blandy committed
615 616
	    break;

617
	  if (c2 > 0)
618 619 620 621 622 623 624
	    cp->byte1 = c1, cp->byte2 = c2;
	  else
	    cp->byte1 = 0, cp->byte2 = c1;
	  ++cp;
	  ++gp, --n;
	  while (gp && (*gp & GLYPH_MASK_PADDING))
	    ++gp, --n;
Jim Blandy's avatar
Jim Blandy committed
625 626 627
	}

      /* LEN gets the length of the run.  */
628
      len = cp - x_2byte_buffer;
Jim Blandy's avatar
Jim Blandy committed
629 630
      /* Now output this run of chars, with the font and pixel values
	 determined by the face code CF.  */
631 632
      {
	struct face *face = FRAME_DEFAULT_FACE (f);
633 634
	XFontStruct *font = NULL;
	GC gc;
635
	int stippled = 0;
636 637 638
	int line_height = f->output_data.x->line_height;
	/* Pixel width of each glyph in this run.  */
	int glyph_width
639 640
	  = (FONT_WIDTH (f->output_data.x->font)
	     * (cmpcharp ? cmpcharp->width : CHARSET_WIDTH (charset)));
641 642 643 644
	/* Overall pixel width of this run.  */
	int run_width
	  = (FONT_WIDTH (f->output_data.x->font)
	     * (cmpcharp ? cmpcharp->width : len * CHARSET_WIDTH (charset)));
645 646 647
	/* A flag to tell if we have already filled background.  We
	   fill background in advance in the following cases:
	   1) A face has stipple.
648
	   2) A height of font is shorter than LINE_HEIGHT.
649
	   3) Drawing a composite character.
650
	   4) Font has non-zero _MULE_BASELINE_OFFSET property.
651 652 653 654
	   After filling background, we draw glyphs by XDrawString16.  */
	int background_filled;
	/* Baseline position of a character, offset from TOP.  */
	int baseline;
655 656 657
	/* The property value of `_MULE_RELATIVE_COMPOSE' and
           `_MULE_DEFAULT_ASCENT'.  */
	int relative_compose = 0, default_ascent = 0;
658 659
	/* 1 if we find no font or a font of inappropriate size.  */
	int require_clipping;
660

661 662
	/* HL = 3 means use a mouse face previously chosen.  */
	if (hl == 3)
663
	  cf = FRAME_X_DISPLAY_INFO (f)->mouse_face_face_id;
664

665 666
	/* First look at the face of the text itself.  */
	if (cf != 0)
667
	  {
668 669
	    /* It's possible for the display table to specify
	       a face code that is out of range.  Use 0 in that case.  */
670 671
	    if (cf < 0 || cf >= FRAME_N_COMPUTED_FACES (f)
		|| FRAME_COMPUTED_FACES (f) [cf] == 0)
672
	      cf = 0;
673 674 675 676

	    if (cf == 1)
	      face = FRAME_MODE_LINE_FACE (f);
	    else
677
	      face = intern_face (f, FRAME_COMPUTED_FACES (f) [cf]);
678 679
	    if (FACE_STIPPLE (face))
	      stippled = 1;
680
	  }
681 682

	/* Then comes the distinction between modeline and normal text.  */
683 684 685 686 687
	else if (hl == 0)
	  ;
	else if (hl == 1)
	  {
	    face = FRAME_MODE_LINE_FACE (f);
688 689
	    if (FACE_STIPPLE (face))
	      stippled = 1;
690 691
	  }

692 693
#define FACE_DEFAULT (~0)

694 695 696 697 698 699 700 701
	/* Setting appropriate font and gc for this charset.  */
	if (charset != CHARSET_ASCII)
	  {
	    int font_id;
	    int fontset = FACE_FONTSET (face);
	    struct font_info *fontp;

	    if ((fontset < 0 && (fontset = FRAME_FONTSET (f)) < 0)
702
		|| !(fontp = FS_LOAD_FONT (f, FRAME_X_FONT_TABLE (f),
703 704 705 706 707 708
					   charset, NULL, fontset)))
	      goto font_not_found;

	    font = (XFontStruct *) (fontp->font);
	    gc = FACE_NON_ASCII_GC (face);
	    XSetFont (FRAME_X_DISPLAY (f), gc, font->fid);
709 710 711 712
	    baseline
	      = (font->max_byte1 != 0
		 ? (line_height + font->ascent - font->descent) / 2
		 : f->output_data.x->font_baseline - fontp->baseline_offset);
713 714 715 716 717 718 719
	    if (FONT_HEIGHT (font) <= line_height
		&& (font->ascent > baseline
		    || font->descent > line_height - baseline))
	      /* Adjust baseline for this font to show the whole
                 glyphs in a line.  */
	      baseline = line_height - font->descent;
	      
720
	    if (cmpcharp && cmpcharp->cmp_rule == NULL)
721 722 723 724
	      {
		relative_compose = fontp->relative_compose;
		default_ascent = fontp->default_ascent;
	      }
725 726 727 728 729 730 731 732 733

	    /* We have to change code points in the following cases.  */
	    if (fontp->font_encoder)
	      {
		/* This font requires CCL program to calculate code
                   point of characters.  */
		struct ccl_program *ccl = fontp->font_encoder;

		if (CHARSET_DIMENSION (charset) == 1)
734
		  for (cp = x_2byte_buffer; cp < x_2byte_buffer + len; cp++)
735 736 737 738
		    {
		      ccl->reg[0] = charset;
		      ccl->reg[1] = cp->byte2;
		      ccl_driver (ccl, NULL, NULL, 0, 0, NULL);
739 740 741 742 743 744
		      /* We assume that MSBs are appropriately
                         set/reset by CCL program.  */
		      if (font->max_byte1 == 0)	/* 1-byte font */
			cp->byte2 = ccl->reg[1];
		      else
			cp->byte1 = ccl->reg[1], cp->byte2 = ccl->reg[2];
745 746
		    }
		else
747
		  for (cp = x_2byte_buffer; cp < x_2byte_buffer + len; cp++)
748 749 750 751
		    {
		      ccl->reg[0] = charset;
		      ccl->reg[1] = cp->byte1, ccl->reg[2] = cp->byte2;
		      ccl_driver (ccl, NULL, NULL, 0, 0, NULL);
752 753 754 755 756 757
		      /* We assume that MSBs are appropriately
                         set/reset by CCL program.  */
		      if (font->max_byte1 == 0)	/* 1-byte font */
			cp->byte2 = ccl->reg[1];
		      else
			cp->byte1 = ccl->reg[1], cp->byte2 = ccl->reg[2];
758 759 760 761 762 763 764
		    }
	      }
	    else if (fontp->encoding[charset])
	      {
		int enc = fontp->encoding[charset];

		if ((enc == 1 || enc == 2) && CHARSET_DIMENSION (charset) == 2)
765
		  for (cp = x_2byte_buffer; cp < x_2byte_buffer + len; cp++)
766 767
		    cp->byte1 |= 0x80;
		if (enc == 1 || enc == 3)
768
		  for (cp = x_2byte_buffer; cp < x_2byte_buffer + len; cp++)
769 770 771 772 773 774
		    cp->byte2 |= 0x80;
	      }
	  }
	else
	  {
	  font_not_found:
775 776 777 778 779
	    if (charset == CHARSET_ASCII || charset == charset_latin_iso8859_1)
	      {
		font = FACE_FONT (face);
		if (font == (XFontStruct *) FACE_DEFAULT)
		  font = f->output_data.x->font;
780
		baseline = FONT_BASE (f->output_data.x->font);
781 782 783 784 785 786 787
		if (charset == charset_latin_iso8859_1)
		  {
		    if (font->max_char_or_byte2 < 0x80)
		      /* This font can't display Latin1 characters.  */
		      font = NULL;
		    else
		      {
788
			for (cp = x_2byte_buffer; cp < x_2byte_buffer + len; cp++)
789 790 791 792 793
			  cp->byte2 |= 0x80;
		      }
		  }
	      }
	    gc = FACE_GC (face);
794 795
	  }

796
	/* Now override that if the cursor's on this character.  */
797
	if (hl == 2)
798
	  {
799 800 801
	    /* The cursor overrides stippling.  */
	    stippled = 0;

802
	    if (font == f->output_data.x->font
803
		&& face->background == f->output_data.x->background_pixel
804 805
		&& face->foreground == f->output_data.x->foreground_pixel
		&& !cmpcharp)
806
	      {
807
		gc = f->output_data.x->cursor_gc;
808 809 810 811 812 813 814
	      }
	    /* Cursor on non-default face: must merge.  */
	    else
	      {
		XGCValues xgcv;
		unsigned long mask;

815
		xgcv.background = f->output_data.x->cursor_pixel;
816
		xgcv.foreground = face->background;
817 818 819
		/* If the glyph would be invisible,
		   try a different foreground.  */
		if (xgcv.foreground == xgcv.background)
820
		  xgcv.foreground = face->foreground;
821
		if (xgcv.foreground == xgcv.background)
822
		  xgcv.foreground = f->output_data.x->cursor_foreground_pixel;
823 824 825 826 827 828 829 830 831
		if (xgcv.foreground == xgcv.background)
		  xgcv.foreground = face->foreground;
		/* Make sure the cursor is distinct from text in this face.  */
		if (xgcv.background == face->background
		    && xgcv.foreground == face->foreground)
		  {
		    xgcv.background = face->foreground;
		    xgcv.foreground = face->background;
		  }
832 833 834 835
		if (font)
		  xgcv.font = font->fid;
		else
		  xgcv.font = FACE_FONT (face)->fid;
836 837
		xgcv.graphics_exposures = 0;
		mask = GCForeground | GCBackground | GCFont | GCGraphicsExposures;
838 839 840 841
		if (FRAME_X_DISPLAY_INFO (f)->scratch_cursor_gc)
		  XChangeGC (FRAME_X_DISPLAY (f),
			     FRAME_X_DISPLAY_INFO (f)->scratch_cursor_gc,
			     mask, &xgcv);
842
		else
843
		  FRAME_X_DISPLAY_INFO (f)->scratch_cursor_gc
844
		    = XCreateGC (FRAME_X_DISPLAY (f), window, mask, &xgcv);
845
		gc = FRAME_X_DISPLAY_INFO (f)->scratch_cursor_gc;
846
#if 0
847 848
/* If this code is restored, it must also reset to the default stipple
   if necessary. */
849
		if (face->stipple && face->stipple != FACE_DEFAULT)
850
		  XSetStipple (FRAME_X_DISPLAY (f), gc, face->stipple);
851
#endif
852
	      }
853 854
	  }

855
	if (font)
856 857 858 859 860
	  require_clipping = (!NILP (Vclip_large_size_font)
			      && (font->ascent > baseline
				  || font->descent > line_height - baseline
				  || (!cmpcharp
				      && FONT_WIDTH (font) > glyph_width)));
861

862 863
	if (font && (just_foreground || (cmpcharp && gidx > 0)))
	  background_filled = 1;
864
	else if (stippled)
865 866 867 868 869 870
	  {
	    /* Turn stipple on.  */
	    XSetFillStyle (FRAME_X_DISPLAY (f), gc, FillOpaqueStippled);

	    /* Draw stipple or background color on background.  */
	    XFillRectangle (FRAME_X_DISPLAY (f), window, gc,
871
			    left, top, run_width, line_height);
872 873 874 875

	    /* Turn stipple off.  */
	    XSetFillStyle (FRAME_X_DISPLAY (f), gc, FillSolid);

876 877 878 879 880 881 882 883 884
	    background_filled = 1;
	  }
	else if (!font
		 || FONT_HEIGHT (font) < line_height
		 || FONT_WIDTH (font) < glyph_width
		 || cmpcharp)
	  {
	    /* Fill a area for the current run in background pixle of GC.  */
	    XGCValues xgcv;
885
	    unsigned long mask = GCForeground | GCBackground | GCFillStyle;
886

887 888
	    /* The current code at first set foreground to background,
	      fill the area, then recover the original foreground.
889
	      Aren't there any smarter ways?  */
890 891

	    XGetGCValues (FRAME_X_DISPLAY (f), gc, mask, &xgcv);
892
	    XSetForeground (FRAME_X_DISPLAY (f), gc, xgcv.background);
893
	    XSetFillStyle (FRAME_X_DISPLAY (f), gc, FillSolid);
894 895
	    XFillRectangle (FRAME_X_DISPLAY (f), window, gc,
			    left, top, run_width, line_height);
896
	    XSetForeground (FRAME_X_DISPLAY (f), gc, xgcv.foreground);
897

898 899 900 901 902 903
	    background_filled = 1;
	    if (cmpcharp)
	      /* To assure not to fill background while drawing
		 remaining components.  */
	      just_foreground = 1;
	  }
904
	else
905 906 907
	  background_filled = 0;

	if (font)
908
	  {
909 910 911 912 913 914 915 916 917 918 919 920 921 922
	    if (require_clipping)
	      {
		Region region;	/* Region used for setting clip mask to GC.  */
		XPoint x[4];	/* Data used for creating REGION.  */

		x[0].x = x[3].x = left, x[1].x = x[2].x = left + glyph_width;
		x[0].y = x[1].y = top,  x[2].y = x[3].y = top + line_height;
		region = XPolygonRegion (x, 4, EvenOddRule);
		XSetRegion (FRAME_X_DISPLAY (f), gc, region);
		XDestroyRegion (region);
	      }

	    if (!cmpcharp)
	      {
923
		if (require_clipping || FONT_WIDTH (font) != glyph_width)
924 925
		  for (i = 0; i < len; i++)
		    {
926
		      if (require_clipping && i > 0) 
927 928 929 930 931
			XSetClipOrigin (FRAME_X_DISPLAY (f), gc,
					glyph_width * i, 0);
		      if (background_filled)
			XDrawString16 (FRAME_X_DISPLAY (f), window, gc,
				       left + glyph_width * i,
932
				       top + baseline, x_2byte_buffer + i, 1);
933 934 935
		      else
			XDrawImageString16 (FRAME_X_DISPLAY (f), window, gc,
					    left + glyph_width * i,
936
					    top + baseline, x_2byte_buffer + i, 1);
937 938 939
		    }
		else
		  {
940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958
		    /* See if this whole buffer can be output as 8-bit chars.
		       If so, copy x_2byte_buffer to x_1byte_buffer
		       and do it as 8-bit chars.  */
		    for (i = 0; i < len; i++)
		      {
			if (x_2byte_buffer[i].byte1 != 0)
			  break;
			x_1byte_buffer[i] = x_2byte_buffer[i].byte2;
		      }

		    if (i == len)
		      {
			if (background_filled)
			  XDrawString (FRAME_X_DISPLAY (f), window, gc,
				       left, top + baseline, x_1byte_buffer, len);
			else
			  XDrawImageString (FRAME_X_DISPLAY (f), window, gc,
					    left, top + baseline, x_1byte_buffer, len);
		      }
959
		    else
960 961 962 963 964 965 966 967 968 969 970
		      {
			/* We can't output them as 8-bit chars,
			   so do it as 16-bit chars.  */

			if (background_filled)
			  XDrawString16 (FRAME_X_DISPLAY (f), window, gc,
					 left, top + baseline, x_2byte_buffer, len);
			else
			  XDrawImageString16 (FRAME_X_DISPLAY (f), window, gc,
					      left, top + baseline, x_2byte_buffer, len);
		      }
971 972 973
		  }
	      }
	    else
974
	      {
975
		/* Handle composite characters.  */
976
		XCharStruct *pcm; /* Pointer to per char metric info.  */
977

978 979 980 981 982 983 984 985
		if ((cmpcharp->cmp_rule || relative_compose)
		    && gidx == 0)
		  {
		    /* This is the first character.  Initialize variables.
		       HIGHEST is the highest position of glyphs ever
		       written, LOWEST the lowest position.  */
		    int x_offset = 0;

986 987 988 989 990 991 992 993 994
		    if (default_ascent
			&& CHAR_TABLE_P (Vuse_default_ascent)
			&& !NILP (Faref (Vuse_default_ascent, first_ch)))
		      {
			highest = default_ascent;
			lowest = 0;
		      }
		    else
		      {
995
			pcm = PER_CHAR_METRIC (font, x_2byte_buffer);
996 997 998
			highest = pcm->ascent + 1;
			lowest = - pcm->descent;
		      }
999 1000 1001 1002 1003 1004

		    if (cmpcharp->cmp_rule)
		      x_offset = (cmpcharp->col_offset[0]
				  * FONT_WIDTH (f->output_data.x->font));
		    /* Draw the first character at the normal position.  */
		    XDrawString16 (FRAME_X_DISPLAY (f), window, gc,
1005
				   left + x_offset, top + baseline, x_2byte_buffer, 1);
1006 1007 1008 1009 1010
		    i = 1;
		    gidx++;
		  }
		else
		  i = 0;
1011

1012 1013 1014
		for (; i < len; i++, gidx++)
		  {
		    int x_offset = 0, y_offset = 0;
1015

1016 1017
		    if (relative_compose)
		      {
1018
			pcm = PER_CHAR_METRIC (font, x_2byte_buffer + i);
Kenichi Handa's avatar
Kenichi Handa committed
1019 1020 1021
			if (NILP (Vignore_relative_composition)
			    || NILP (Faref (Vignore_relative_composition,
					    make_number (cmpcharp->glyph[gidx]))))
1022
			  {
Kenichi Handa's avatar
Kenichi Handa committed
1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034
			    if (- pcm->descent >= relative_compose)
			      {
				/* Draw above the current glyphs.  */
				y_offset = highest + pcm->descent;
				highest += pcm->ascent + pcm->descent;
			      }
			    else if (pcm->ascent <= 0)
			      {
				/* Draw beneath the current glyphs.  */
				y_offset = lowest - pcm->ascent;
				lowest -= pcm->ascent + pcm->descent;
			      }
1035
			  }
Kenichi Handa's avatar
Kenichi Handa committed
1036
			else
1037
			  {
Kenichi Handa's avatar
Kenichi Handa committed
1038 1039 1040 1041 1042 1043 1044
			    /* Draw the glyph at normal position.  If
                               it sticks out of HIGHEST or LOWEST,
                               update them appropriately.  */
			    if (pcm->ascent > highest)
			      highest = pcm->ascent;
			    else if (- pcm->descent < lowest)
			      lowest = - pcm->descent;
1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058
			  }
		      }
		    else if (cmpcharp->cmp_rule)
		      {
			int gref = (cmpcharp->cmp_rule[gidx] - 0xA0) / 9;
			int nref = (cmpcharp->cmp_rule[gidx] - 0xA0) % 9;
			int bottom, top;

			/* Re-encode GREF and NREF so that they specify
			   only Y-axis information:
			   0:top, 1:base, 2:bottom, 3:center  */
			gref = gref / 3 + (gref == 4) * 2;
			nref = nref / 3 + (nref == 4) * 2;

1059
			pcm = PER_CHAR_METRIC (font, x_2byte_buffer + i);
1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076
			bottom = ((gref == 0 ? highest : gref == 1 ? 0
				   : gref == 2 ? lowest
				   : (highest + lowest) / 2)
				  - (nref == 0 ? pcm->ascent + pcm->descent
				     : nref == 1 ? pcm->descent : nref == 2 ? 0
				     : (pcm->ascent + pcm->descent) / 2));
			top = bottom + (pcm->ascent + pcm->descent);
			if (top > highest)
			  highest = top;
			if (bottom < lowest)
			  lowest = bottom;
			y_offset = bottom + pcm->descent;
			x_offset = (cmpcharp->col_offset[gidx]
				    * FONT_WIDTH (f->output_data.x->font));
		      }
		    XDrawString16 (FRAME_X_DISPLAY (f), window, gc,
				   left + x_offset, top + baseline - y_offset,
1077
				   x_2byte_buffer + i, 1);
1078
		  }
1079
	      }
1080 1081
	    if (require_clipping)
	      XSetClipMask (FRAME_X_DISPLAY (f), gc, None);
1082 1083 1084

#if 0 /* Doesn't work, because it uses FRAME_CURRENT_GLYPHS,
	 which often is not up to date yet.  */
1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
	    if (!just_foreground)
	      {
		if (left == orig_left)
		  redraw_previous_char (f, PIXEL_TO_CHAR_COL (f, left),
					PIXEL_TO_CHAR_ROW (f, top), hl == 1);
		if (n == 0)
		  redraw_following_char (f, PIXEL_TO_CHAR_COL (f, left + len * FONT_WIDTH (font)),
					 PIXEL_TO_CHAR_ROW (f, top), hl == 1);
	      }
#endif
	  }
1096
	if (!font)
1097
	  {
1098 1099
	    /* Show rectangles to indicate that we found no font.  */
	    int limit = cmpcharp ? 1 : len;
1100

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
	    for (i = 0; i < limit; i++)
	      XDrawRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc,
			      left + glyph_width * i, top,
			      glyph_width - 1, line_height - 1);
	  }
	else if (require_clipping && !NILP (Vhighlight_wrong_size_font))
	  {
	    /* Show ??? to indicate that we found a font of
               inappropriate size.  */
	    int limit = cmpcharp ? 1 : len;

	    for (i = 0; i < limit; i++)
	      {
		XDrawLine (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc,
			   left + glyph_width * i, top + line_height - 1,
			   left + glyph_width * i + 1, top + line_height - 1);
		XDrawLine (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc,
			   left + glyph_width * i, top + line_height - 3,
			   left + glyph_width * i, top + line_height - 1);
	      }
1121
	  }
1122

1123 1124 1125
	/* We should probably check for XA_UNDERLINE_POSITION and
	   XA_UNDERLINE_THICKNESS properties on the font, but let's
	   just get the thing working, and come back to that.  */
Jim Blandy's avatar
Jim Blandy committed
1126
	{
1127 1128 1129 1130 1131
	  /* Setting underline position based on the metric of the
	     current font results in shaky underline if it strides
	     over different fonts.  So, we set the position based only
	     on the default font of this frame.  */
	  int underline_position = f->output_data.x->font_baseline + 1;
1132

1133 1134
	  if (underline_position >= line_height)
	    underline_position = line_height - 1;
1135 1136

	  if (face->underline)
1137
	    XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
1138
			    FACE_GC (face),
1139
			    left, top + underline_position, run_width, 1);
Jim Blandy's avatar
Jim Blandy committed
1140
	}
1141

1142
	if (!cmpcharp)
1143
	  left += run_width;
1144
      }
Jim Blandy's avatar
Jim Blandy committed
1145
    }