ChangeLog 1.1 MB
Newer Older
Paul Eggert's avatar
Paul Eggert committed
1
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
2

3 4 5
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

6 7 8
	* chartab.c (sub_char_table_ref_and_range): Redo to avoid overflow
	concerns.

9 10
	* term.c (produce_glyphless_glyph): Remove unnecessary test.

11 12
	* cm.c (calccost): Turn while-do into do-while, for clarity.

13 14
	Fix more problems found by GCC 4.5.2's static checks.

15 16 17 18
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

19 20 21
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
22
	of objects (Bug#8318).
23

24 25 26
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

27 28 29 30
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
31 32
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
33

34 35 36
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

37 38
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
39 40
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
41

Paul Eggert's avatar
Paul Eggert committed
42 43
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
44

Paul Eggert's avatar
Paul Eggert committed
45
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
46

47 48 49
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
50
	socklen_t is wider than int (Bug#8277).
51 52 53 54
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

55 56 57 58
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
59
	(Fmake_network_process): Define label "retry_connect" only if needed.
60
	(Fnetwork_interface_info): Fix pointer signedness.
61
	(process_send_signal): Add cast to avoid pointer signedness problem.
62
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
63
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
64

65 66 67 68 69 70 71 72 73 74 75 76
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

77
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
78
	(xftfont_open): Rename locals to avoid shadowing.
79

80
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
81 82
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
83
	(ftfont_list): Remove unused local.
84 85 86
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
87

88 89
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
90 91
	* xml.c (make_dom): Now static.

92 93
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
94 95
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
96
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
97 98
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
99

100 101 102 103 104 105 106
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

107 108
	* textprop.c (property_change_between_p): Remove; unused.

109 110
	* intervals.c (interval_start_pos): Now static.

111 112
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

113 114 115
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

116 117
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
118
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
119 120
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
121

122 123
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

124 125
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
126 127
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
128 129
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
130

131 132 133 134
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

135
	* callproc.c (call_process_cleanup): Now static.
136
	(relocate_fd): Rename locals to avoid shadowing.
137

138 139 140 141 142
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

143 144 145 146
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

147 148 149 150 151 152
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

153 154 155 156 157 158
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

159 160 161 162 163
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).

164 165 166 167
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* makefile.w32-in: Update dependencies.

168 169 170 171
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

172 173
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

174 175
	Fix more problems found by GCC 4.5.2's static checks.

176 177 178
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

179 180 181 182 183 184 185
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

186 187 188
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

189
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
190 191 192
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
193

194 195
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
196 197
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
198
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
199

200 201
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
202
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
203
	* unexec.h: New file.
204 205 206 207 208 209
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
210
	Change as necessary to match prototype in unexec.h.
211

212 213
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
214
	(back_comment, skip_chars): Mark vars as initialized.
215

216 217 218
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

219
	* lread.c (read1): Rewrite so as not to use empty "else".
220
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
221

222 223
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

224 225 226
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

227 228
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
229
	(font_sort_entities): Mark var as initialized.
230

231 232
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

233 234
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
235
	(font_parse_fcname): Remove unused vars.
236
	(font_delete_unmatched): Now static.
237
	(font_get_spec): Remove; unused.
238 239 240
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
241

242
	* fns.c (require_nesting_list, require_unwind): Now static.
243
	(Ffillarray): Rename locals to avoid shadowing.
244

245
	* floatfns.c (domain_error2): Define only if needed.
246
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
247

248 249 250
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

251
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
252
	(Fdefvar): Rewrite so as not to use empty "else".
253 254
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
255
	(Fdefvar): Rename locals to avoid shadowing.
256

257
	* callint.c (quotify_arg, quotify_args): Now static.
258
	(Fcall_interactively): Rename locals to avoid shadowing.
259
	Use const pointer when appropriate.
260

261 262 263 264
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
265 266 267
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
268 269 270
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
271
	(Ftranslate_region_internal): Mark var as initialized.
272

273 274 275
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

276 277 278
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

279 280
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
281
	(default_value, arithcompare, arith_driver, arith_error): Now static.
282
	(store_symval_forwarding): Rename local to avoid shadowing.
283 284
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
285
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
286

287
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
288 289
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
290 291
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
292 293 294 295 296
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
297
	(Fmemory_limit): Cast sbrk's returned value to char *.
298

299 300 301
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

302 303
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

304 305 306 307 308 309 310 311
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
312
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
313
	the race-condition problem in the old DOWNCASE.
314

315 316 317
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
318 319
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
320 321
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
322
	(regex_compile, re_match_2_internal): Mark locals as initialized.
323 324 325 326 327 328 329
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
330

331
	* search.c (boyer_moore): Rename locals to avoid shadowing.
332 333
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
334

335 336
	* search.c (simple_search): Remove unused var.

337 338 339 340
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

341 342
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

343 344 345 346
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
347
	(Fvertical_motion): Mark locals as initialized.
348

349
	* casefiddle.c (casify_object, casify_region): Now static.
350
	(casify_region): Mark local as initialized.
351

352 353
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

354 355 356 357 358 359 360 361 362
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
363 364 365
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

387 388
	* dired.c (directory_files_internal_unwind): Now static.

389 390 391
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
392 393 394
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
395
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
396 397
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
398 399
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
400

401
	* minibuf.c (choose_minibuf_frame_1): Now static.
402 403
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
404

405 406
	* marker.c (bytepos_to_charpos): Remove; unused.

407 408 409
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

410 411
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
412
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
413
	(copy_text): Remove unused local var.
414

415
	* filelock.c (within_one_second): Now static.
416
	(lock_file_1): Rename local to avoid shadowing.
417

418 419 420 421
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
422
	(switch_to_buffer_1): Now static.
423 424
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
425

426
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
427
	Fix pointer signedness issue.
428 429
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
430
	(MAXPATHLEN): Define only if needed.
431

432 433 434
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

435 436 437
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

438
	* sysdep.c (reset_io): Now static.
439
	(wait_for_termination_signal): Remove; unused.
440

441 442 443
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
444
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
445
	(DENSE_TABLE_SIZE): Remove; unused.
446 447 448
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
449

450 451 452
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
453 454 455 456 457
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
458
	(read_key_sequence, read_char): Mark locals as initialized.
459
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
460

461
	* keyboard.h (make_ctrl_char): New decl.
462 463
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
464

465 466
	* lisp.h (force_auto_save_soon): New decl.

467
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
468 469 470
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
471 472
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
473

474 475
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

476 477 478 479 480 481 482
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

483 484
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
485
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
486

487 488
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

489 490 491
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

492 493
	* print.c (print_preprocess): Don't forget font objects.

494 495 496 497
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

498 499 500 501 502
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

503 504 505 506 507 508 509 510
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
511
	(run_protected): Add extern declaration for waiting_for_input.
512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

528 529
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
530
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
531

532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

554 555 556 557 558
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

559 560
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
561 562
	Fix more problems found by GCC 4.5.2's static checks.

563 564
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
565 566
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
567 568
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
569 570 571 572 573
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
574 575 576
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
577

578 579
	* xgselect.c (xg_select): Remove unused var.

580 581 582
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
583
	(my_png_error, my_error_exit): Mark with NO_RETURN.
584

585
	* image.c (clear_image_cache): Now static.
586
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
587
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
588 589
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
590
	(gif_load): Fix pointer signedness.
591 592
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
593

Paul Eggert's avatar
Paul Eggert committed
594 595
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

596 597 598 599 600 601
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
602 603 604 605 606 607 608 609 610 611 612 613
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
614 615
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
616

617 618 619 620
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

621 622 623 624 625
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

626
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
627

628 629
	* fringe.c (update_window_fringes): Remove unused variables.

630 631 632
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

633 634
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
635
	* termcap.c [MSDOS]: Include "msdos.h".
636 637 638 639
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

640
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
641

642 643 644 645 646
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

647 648 649 650
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

651 652 653 654 655 656 657 658 659 660 661 662
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

663
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
664

665
	Fix some minor problems found by GCC 4.5.2's static checks.
666

667 668 669
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
670

671 672 673 674 675
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

676
	* fontset.c (free_realized_fontset): Now static.
677
	(Fset_fontset_font): Rename local to avoid shadowing.
678
	(fontset_font): Mark local as initialized.
679
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
680

681 682
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

683
	* xselect.c (x_disown_buffer_selections): Remove; not used.
684
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
685 686 687
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
688

689 690 691
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
692 693 694 695
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
696
	(Fx_create_frame): Add braces to silence GCC warning.
697
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
698 699
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
700 701 702 703
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
704

705 706
	* xterm.h (x_mouse_leave): New decl.

707 708
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
709 710
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
711
	(XTread_socket): Don't define label "out" unless it's used.
712
	Don't declare local "event" unless it's used.
713 714
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
715 716
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
717 718 719 720 721
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
722
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
723
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
724

725 726
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
727
	(tty_defined_color, merge_face_heights): Now static.
728
	(free_realized_faces_for_fontset): Remove; not used.
729 730
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
731 732
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
733

734
	* terminal.c (store_terminal_param): Now static.
735

736
	* xmenu.c (menu_highlight_callback): Now static.
737
	(set_frame_menubar): Remove unused local.
738
	(xmenu_show): Rename parameter to avoid shadowing.
739 740
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
741 742
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
743

744
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
745
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
746 747
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
748
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
749 750
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
751

Paul Eggert's avatar
Paul Eggert committed
752 753
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

754
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
755 756
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
757

758
	* window.c (display_buffer): Now static.
759 760
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
761 762
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
763
	* dispextern.h (bidi_dump_cached_states): Likewise.
764

765 766 767
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
768 769 770
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
771 772
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
773
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
774

775 776 777
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
778 779 780 781 782 783 784 785 786
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
787 788
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
789
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
790
	(decode_coding_object, encode_coding_object, detect_coding_system):
791 792
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
793 794
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
795
	this initialization is needed.  (Bug#8211)
796 797 798 799 800
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
801

802
	* category.c (hash_get_category_set): Remove unused local var.
803
	(copy_category_table): Now static, since it's not used elsewhere.
804
	* character.c (string_count_byte8): Likewise.
805

806 807 808
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

809 810
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
811 812
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
813
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
814

815
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
816
	(BIDI_BOB): Remove unused macro.
817

818 819
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
820
	* term.c (encode_terminal_code): Likewise.
821

822
	* term.c (encode_terminal_code): Now static.  Remove unused local.
823

Paul Eggert's avatar
Paul Eggert committed
824 825 826 827 828 829 830 831 832 833 834
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

835 836 837 838 839 840 841 842 843
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

844 845
	* term.c (term_mouse_position): Rename local to avoid shadowing.

846 847 848
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

849 850 851 852
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

853 854 855 856 857 858
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

911 912 913 914 915
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
916 917 918 919 920 921 922
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
923
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
924

925 926 927 928 929 930
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

931 932 933 934 935
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

936 937
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

938 939 940
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

965 966 967 968 969
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

970
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
971
	* xdisp.c (redisplay_window): Likewise.
972

973 974 975 976 977 978 979 980
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
981
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
982 983
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
984
	(update_window_cursor): Now static, since it's not used elsewhere.
985
	(SKIP_GLYPHS): Removed unused macro.
986

987 988 989 990
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

991 992 993 994
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
995
2011-03-02  Ken Brown  <kbrown@cornell.edu>
996 997 998

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

999 1000 1001 1002 1003