ChangeLog 1.1 MB
Newer Older
1 2 3 4 5 6
2011-03-20  Paul Eggert  <eggert@cs.ucla.edu>

	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
7
	(Fmake_network_process): Define label "retry_connect" only if needed.
8
	(Fnetwork_interface_info): Fix pointer signedness.
9
	(process_send_signal): Add cast to avoid pointer signedness problem.
10

11 12
2011-03-19  Paul Eggert  <eggert@cs.ucla.edu>

13 14 15 16 17 18 19 20 21 22 23 24
	Make tparam.h and terminfo.c consistent.
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.  Include
	tparam.h instead, since it declares them.
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

25
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
26
	(xftfont_open): Rename locals to avoid shadowing.
27

28
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
29 30
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
31
	(ftfont_list): Remove unused local.
32 33 34
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
35

36 37
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
38 39
	* xml.c (make_dom): Now static.

40 41
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
42 43
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
44
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
45 46
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
47

48 49
2011-03-18  Paul Eggert  <eggert@cs.ucla.edu>

50 51 52 53 54 55 56
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

57 58
	* textprop.c (property_change_between_p): Remove; unused.

59 60
	* intervals.c (interval_start_pos): Now static.

61 62
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

63 64 65
	* atimer.c (start_atimer, append_atimer_lists, set_alarm): Rename
	locals to avoid shadowing.

66 67
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
68
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
69 70
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
71

72 73
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

74 75
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

76 77 78
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
79

80 81 82 83
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

84
	* callproc.c (call_process_cleanup): Now static.
85
	(relocate_fd): Rename locals to avoid shadowing.
86

87 88 89 90
2011-03-17  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

91 92
2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

93 94
	Fix more problems found by GCC 4.5.2's static checks.

95 96 97
	* process.c (make_serial_process_unwind, send_process_trap):
	(sigchld_handler): Now static.

98 99 100 101 102 103 104
	* process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
	That way, the code declares only the vars that it needs.
	* s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
	* s/cygwin.h (PTY_ITERATION): Likewise.
	* s/darwin.h (PTY_ITERATION): Likewise.
	* s/gnu-linux.h (PTY_ITERATION): Likewise.

105 106 107
	* s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
	* process.c (allocate_pty): Don't declare stb unless it's needed.

108
	* bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
109 110 111
	(CONSTANTLIM): Remove; unused.
	(METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
	Define only if needed.
112

113 114
	* unexelf.c (unexec): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
115 116
	Use a different way to cause a compilation error if anyone uses
	n rather than nn, a way that does not involve shadowing.
117
	(ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
118

119 120
	* deps.mk (unexalpha.o): Remove; unused.

Paul Eggert's avatar
Paul Eggert committed
121
	New file unexec.h, the (simple) interface for unexec (Bug#8267).
Paul Eggert's avatar
Paul Eggert committed
122
	* unexec.h: New file.
123 124 125 126 127 128
	* deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
	(unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
	Depend on unexec.h.
	* emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
	* unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
	* unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
129
	Change as necessary to match prototype in unexec.h.
130

131 132
	* syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
	shadowing.
133
	(back_comment, skip_chars): Mark vars as initialized.
134

135 136 137
	* character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
	Rename locals to avoid shadowing.

138
	* lread.c (read1): Rewrite so as not to use empty "else".
139
	(Fload, readevalloop, read1): Rename locals to avoid shadowing.
140

141 142
	* print.c (Fredirect_debugging_output): Fix pointer signedess.

143 144 145
	* lisp.h (debug_output_compilation_hack): Add decl here, to avoid
	warning when compiling print.c.

146 147
	* font.c (font_unparse_fcname): Abort in an "impossible" situation
	instead of using an uninitialized var.
148
	(font_sort_entities): Mark var as initialized.
149

150 151
	* character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

152 153
	* font.c (font_unparse_xlfd): Don't mix pointers to variables with
	pointers to constants.
154
	(font_parse_fcname): Remove unused vars.
155
	(font_delete_unmatched): Now static.
156
	(font_get_spec): Remove; unused.
157 158 159
	(font_style_to_value, font_prop_validate_style, font_unparse_fcname):
	(font_update_drivers, Ffont_get_glyphs, font_add_log):
	Rename or move locals to avoid shadowing.
160

161
	* fns.c (require_nesting_list, require_unwind): Now static.
162
	(Ffillarray): Rename locals to avoid shadowing.
163

164
	* floatfns.c (domain_error2): Define only if needed.
165
	(Ffrexp, Fldexp): Rename locals to avoid shadowing.
166

167 168 169
	* alloc.c (mark_backtrace): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.

170
	* eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
171
	(Fdefvar): Rewrite so as not to use empty "else".
172 173
	(lisp_indirect_variable): Name an expression,
	to avoid gcc -Wbad-function-cast warning.
174
	(Fdefvar): Rename locals to avoid shadowing.
175

176
	* callint.c (quotify_arg, quotify_args): Now static.
177
	(Fcall_interactively): Rename locals to avoid shadowing.
178
	Use const pointer when appropriate.
179

180 181 182 183
	* lisp.h (get_system_name, get_operating_system_release):
	Move decls here, to check interfaces.
	* process.c (get_operating_system_release): Move decl to lisp.h.
	* xrdb.c (get_system_name): Likewise.
184 185 186
	* editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
	(Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
	some of which prompt warnings from gcc -Wbad-function-cast.
187 188 189
	(Fformat_time_string, Fencode_time, Finsert_char):
	(Ftranslate_region_internal, Fformat):
	Rename or remove local vars to avoid shadowing.
190
	(Ftranslate_region_internal): Mark var as initialized.
191

192 193 194
	* doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
	avoid shadowing.

195 196 197
	* lisp.h (eassert): Check that the argument compiles, even if
	ENABLE_CHECKING is not defined.

198 199
	* data.c (Findirect_variable): Name an expression, to avoid
	gcc -Wbad-function-cast warning.
200
	(default_value, arithcompare, arith_driver, arith_error): Now static.
201
	(store_symval_forwarding): Rename local to avoid shadowing.
202 203
	(Fmake_variable_buffer_local, Fmake_local_variable): Mark
	variables as initialized.
204
	(do_blv_forwarding, do_symval_forwarding): Remove; unused.
205

206
	* alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
207 208
	(Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
	Rename locals to avoid shadowing.
209 210
	(mark_stack): Move local variables into the #ifdef region where
	they're used.
211 212 213 214 215
	(BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
	! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
	needed otherwise.
	(CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
	(GC_STRING_CHARS): Remove; not used.
216
	(Fmemory_limit): Cast sbrk's returned value to char *.
217

218 219 220
	* lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
	avoids undefined behavior in theory.

221 222
	* regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

223 224 225 226 227 228 229 230
	Use functions, not macros, for up- and down-casing (Bug#8254).
	* buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
	to use the following functions instead of these macros.
	(downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
	EMACS_INT, since callers assume the returned value fits in int.
	(upcase1): Likewise, for UPCASE_TABLE.
	(uppercasep, lowercasep, upcase): New static inline functions.
231
	* editfns.c (Fchar_equal): Remove no-longer-needed workaround for
Paul Eggert's avatar
Paul Eggert committed
232
	the race-condition problem in the old DOWNCASE.
233

234 235 236
	* regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
	Rename locals to avoid shadowing.
	(regex_compile, re_match_2_internal): Move locals to avoid shadowing.
237 238
	(regex_compile, re_search_2, re_match_2_internal):
	Remove unused local vars.
239 240
	(FREE_VAR): Rewrite so as not to use empty "else",
	which gcc can warn about.
241
	(regex_compile, re_match_2_internal): Mark locals as initialized.
242 243 244 245 246 247 248
	(RETALLOC_IF): Define only if needed.
	(WORDCHAR_P): Likewise.  This one is never needed, but is used
	only in a comment talking about a compiler bug, so put inside
	the #if 0 of that comment.
	(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
	(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
	Remove; unused.
249

250
	* search.c (boyer_moore): Rename locals to avoid shadowing.
251 252
	* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
	(PREV_CHAR_BOUNDARY): Likewise.
253

254 255
	* search.c (simple_search): Remove unused var.

256 257 258 259
	* dired.c (compile_pattern): Move decl from here ...
	* lisp.h: ... to here, so that it can be checked.
	(struct re_registers): New forward decl.

260 261
	* character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

262 263 264 265
	* indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
	All uses changed.
	(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
	Rename locals to avoid shadowing.
266
	(Fvertical_motion): Mark locals as initialized.
267

268
	* casefiddle.c (casify_object, casify_region): Now static.
269
	(casify_region): Mark local as initialized.
270

271 272
	* cmds.c (internal_self_insert): Rename local to avoid shadowing.

273 274 275 276 277 278 279 280 281
	* lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
	New macros, so that the caller can use some names other than
	gcpro1, gcpro2, etc.
	(GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
	of the new macros.
	(GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
	argument, for consistency with GCPRO2_VAR, etc: it is now the
	prefix of the variable, not the variable itself.  All uses
	changed.
282 283 284
	* dired.c (directory_files_internal, file_name_completion):
	Rename locals to avoid shadowing.

285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
	Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
	An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
	dired.c's scmp function, had undefined behavior.
	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
	(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
	* buffer.h: ... to here, because these macros use current_buffer,
	and the new implementation with inline functions needs to have
	current_buffer in scope now, rather than later when the macros
	are used.
	(downcase, upcase1): New static inline functions.
	(DOWNCASE, UPCASE1): Reimplement using these functions.
	This avoids undefined behavior in expressions like
	DOWNCASE (x) == DOWNCASE (y), which previously suffered
	from race conditions in accessing the global variables
	case_temp1 and case_temp2.
	* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
	* lisp.h (case_temp1, case_temp2): Remove their decls.
	* character.h (ASCII_CHAR_P): Move from here ...
	* lisp.h: ... to here, so that the inline functions mentioned
	above can use them.

306 307
	* dired.c (directory_files_internal_unwind): Now static.

308 309 310
	* fileio.c (file_name_as_directory, directory_file_name):
	(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
	Now static.
311 312 313
	(file_name_as_directory): Use const pointers when appropriate.
	(Fexpand_file_name): Likewise.  In particular, newdir might
	point at constant storage, so make it a const pointer.
314
	(Fmake_directory_internal, Fread_file_name): Remove unused vars.
315 316
	(Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
	signedness issues.
317 318
	(Fset_file_times, Finsert_file_contents, auto_save_error):
	Rename locals to avoid shadowing.
319

320
	* minibuf.c (choose_minibuf_frame_1): Now static.
321 322
	(Ftry_completion, Fall_completions): Rename or remove locals
	to avoid shadowing.
323

324 325
	* marker.c (bytepos_to_charpos): Remove; unused.

326 327 328
	* lisp.h (verify_bytepos, count_markers): New decls,
	so that gcc does not warn that these functions aren't declared.

329 330
	* insdel.c (check_markers, make_gap_larger, make_gap_smaller):
	(reset_var_on_error, Fcombine_after_change_execute_1): Now static.
331
	(CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
332
	(copy_text): Remove unused local var.
333

334
	* filelock.c (within_one_second): Now static.
335
	(lock_file_1): Rename local to avoid shadowing.
336

337 338 339 340
	* buffer.c (fix_overlays_before): Mark locals as initialized.
	(fix_start_end_in_overlays): Likewise.  This function should be
	simplified by using pointers-to-pointers, but that's a different
	matter.
Paul Eggert's avatar
Paul Eggert committed
341
	(switch_to_buffer_1): Now static.
342 343
	(Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
	(report_overlay_modification): Rename locals to avoid shadowing.
344

345
	* sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
346
	Fix pointer signedness issue.
347 348
	(sys_subshell): Mark local as volatile if checking for lint,
	to suppress a gcc -Wclobbered warning that does not seem to be right.
349
	(MAXPATHLEN): Define only if needed.
350

351 352 353
	* process.c (serial_open, serial_configure): Move decls from here ...
	* systty.h: ... to here, so that they can be checked.

354 355 356
	* fns.c (get_random, seed_random): Move extern decls from here ...
	* lisp.h: ... to here, so that they can be checked.

357
	* sysdep.c (reset_io): Now static.
358
	(wait_for_termination_signal): Remove; unused.
359

360 361 362
	* keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
	(copy_keymap_item, append_key, push_text_char_description):
	Now static.
363
	(Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
364
	(DENSE_TABLE_SIZE): Remove; unused.
365 366 367
	(get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
	(describe_map_tree):
	Rename locals to avoid shadowing.
368

369 370 371
	* keyboard.c: Declare functions static if they are not used elsewhere.
	(echo_char, echo_dash, cmd_error, top_level_2):
	(poll_for_input, handle_async_input): Now static.
372 373 374 375 376
	(read_char, kbd_buffer_get_event, make_lispy_position):
	(make_lispy_event, make_lispy_movement, apply_modifiers):
	(decode_keyboard_code, tty_read_avail_input, menu_bar_items):
	(parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
	(Fread_key_sequence_vector): Rename locals to avoid shadowing.
377
	(read_key_sequence, read_char): Mark locals as initialized.
378
	(Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
379

380
	* keyboard.h (make_ctrl_char): New decl.
381 382
	(mark_kboards): Move decl here ...
	* alloc.c (mark_kboards): ... from here.
383

384 385
	* lisp.h (force_auto_save_soon): New decl.

386
	* emacs.c (init_cmdargs): Rename local to avoid shadowing.
387 388 389
	(DEFINE_DUMMY_FUNCTION): New macro.
	(__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
	Use it.
390 391
	(main): Add casts to avoid warnings
	if GCC considers string literals to be constants.
392

393 394
	* lisp.h (fatal_error_signal): Add decl, since it's exported.

395 396 397 398 399 400 401
	* dbusbind.c: Pointer signedness fixes.
	(xd_signature, xd_append_arg, xd_initialize):
	(Fdbus_call_method, Fdbus_call_method_asynchronously):
	(Fdbus_method_return_internal, Fdbus_method_error_internal):
	(Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
	(Fdbus_register_signal): Use SSDATA when the context wants char *.

402 403
	* dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
	if GCC considers string literals to be constants.
404
	(Fdbus_register_service, Fdbus_register_method): Remove unused vars.
405

406 407
2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

408 409 410
	* print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
	(print_preprocess, print_object): New macro to fix last change.

411 412
	* print.c (print_preprocess): Don't forget font objects.

413 414 415 416
2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

	* emacs.c (USAGE3): Doc fixes.

417 418 419 420 421
2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

	* coding.c (detect_coding_iso_2022): Reorganize code to clarify
	structure.

422 423 424 425 426 427 428 429
2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

	* lisp.h (VWindow_system, Qfile_name_history):
	* keyboard.h (lispy_function_keys) [WINDOWSNT]:
	* w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
	(w32_system_caret_x, w32_system_caret_y): Declare extern.

	* w32select.c: Don't #include "keyboard.h".
Juanma Barranquero's avatar
Juanma Barranquero committed
430
	(run_protected): Add extern declaration for waiting_for_input.
431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446

	* w32.c (Qlocal, noninteractive1, inhibit_window_system):
	* w32console.c (detect_input_pending, read_input_pending)
	(encode_terminal_code):
	* w32fns.c (quit_char, lispy_function_keys, Qtooltip)
	(w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
	(w32_system_caret_y, Qfile_name_history):
	* w32font.c (w32font_driver, QCantialias, QCotf, QClang):
	* w32inevt.c (reinvoke_input_signal, lispy_function_keys):
	* w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
	(Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
	* w32proc.c (Qlocal, report_file_error):
	* w32term.c (Vwindow_system, updating_frame):
	* w32uniscribe.c (initialized, uniscribe_font_driver):
	Remove unneeded extern declarations.

447 448
2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

Juanma Barranquero's avatar
Juanma Barranquero committed
449
	* buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
450

451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472
2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

	* buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
	(BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
	These macros can no longer be used for assignment.

	* buffer.c (Fget_buffer_create, Fmake_indirect_buffer): Assign
	struct members directly, instead of using BUF_BEGV etc.
	(record_buffer_markers, fetch_buffer_markers): New functions for
	recording and fetching special buffer markers.
	(set_buffer_internal_1, set_buffer_temp): Use them.

	* lread.c (unreadchar): Use SET_BUF_PT_BOTH.

	* insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

	* intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
	(get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

	* xdisp.c (hscroll_window_tree):
	(reconsider_clip_changes): Use PT instead of BUF_PT.

473 474 475 476 477
2011-03-13  Eli Zaretskii  <eliz@gnu.org>

	* makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
	$(EMACS_ROOT)/lib/intprops.h.

478 479
2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

Paul Eggert's avatar
Paul Eggert committed
480 481
	Fix more problems found by GCC 4.5.2's static checks.

482 483
	* gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
	to unsigned char * to avoid compiler diagnostic.
484 485
	(xg_free_frame_widgets): Make it clear that a local variable is
	needed only if USE_GTK_TOOLTIP.
486 487
	(gdk_window_get_screen): Make it clear that this macro is needed
	only if USE_GTK_TOOLTIP.
488 489 490 491 492
	(int_gtk_range_get_value): New function, which avoids a diagnostic
	from gcc -Wbad-function-cast.
	(xg_set_toolkit_scroll_bar_thumb): Use it.
	(xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
	diagnostic from gcc -Wbad-function-cast.
493 494 495
	(get_utf8_string, xg_get_file_with_chooser):
	Rename locals to avoid shadowing.
	(create_dialog): Move locals to avoid shadowing.
496

497 498
	* xgselect.c (xg_select): Remove unused var.

499 500 501
	* image.c (four_corners_best): Mark locals as initialized.
	(gif_load): Initialize transparent_p to zero (Bug#8238).
	Mark another local as initialized.
502
	(my_png_error, my_error_exit): Mark with NO_RETURN.
503

504
	* image.c (clear_image_cache): Now static.
505
	(DIM, HAVE_STDLIB_H_1): Remove unused macros.
506
	(xpm_load): Redo to avoid "discards qualifiers" gcc warning.
507 508
	(x_edge_detection): Remove unnecessary cast that
	gcc -Wbad-function-cast diagnoses.
509
	(gif_load): Fix pointer signedness.
510 511
	(clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
	(jpeg_load, gif_load): Rename locals to avoid shadowing.
512

Paul Eggert's avatar
Paul Eggert committed
513 514
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

515 516 517 518 519 520
	Improve quality of tests for time stamp overflow.
	For example, without this patch (encode-time 0 0 0 1 1
	1152921504606846976) returns the obviously-bogus value (-948597
	62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
	reports time overflow.  See
	<http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
521 522 523 524 525 526 527 528 529 530 531 532
	* deps.mk (editfns.o): Depend on ../lib/intprops.h.
	* editfns.c: Include limits.h and intprops.h.
	(TIME_T_MIN, TIME_T_MAX): New macros.
	(time_overflow): Move earlier, to before first use.
	(hi_time, lo_time): New functions, for an accurate test for
	out-of-range times.
	(Fcurrent_time, Fget_internal_run_time, make_time): Use them.
	(Fget_internal_run_time): Don't assume time_t fits in int.
	(make_time): Use list2 instead of Fcons twice.
	(Fdecode_time): More accurate test for out-of-range times.
	(check_tm_member): New function.
	(Fencode_time): Use it, to test for out-of-range times.
533 534
	(lisp_time_argument): Don't rely on undefined left-shift and
	right-shift behavior when checking for time stamp overflow.
535

536 537 538 539
	* editfns.c (time_overflow): New function, refactoring common code.
	(Fformat_time_string, Fdecode_time, Fencode_time):
	(Fcurrent_time_string): Use it.

540 541 542 543 544
	Move 'make_time' to be next to its inverse 'lisp_time_argument'.
	* dired.c (make_time): Move to ...
	* editfns.c (make_time): ... here.
	* systime.h: Note the move.

545
2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
546

547 548
	* fringe.c (update_window_fringes): Remove unused variables.

549 550 551
	* unexmacosx.c (copy_data_segment): Also copy __got section.
	(Bug#8223)

552 553
2011-03-12  Eli Zaretskii  <eliz@gnu.org>

Juanma Barranquero's avatar
Juanma Barranquero committed
554
	* termcap.c [MSDOS]: Include "msdos.h".
555 556 557 558
	(find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
	Constify `char *' arguments and their references according to
	prototypes in tparam.h.

559
	* deps.mk (termcap.o): Depend on tparam.h and msdos.h.
560

561 562 563 564 565
	* msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
	Adapt all references accordingly.

	* msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

566 567 568 569
2011-03-11  Tom Tromey  <tromey@redhat.com>

	* buffer.c (syms_of_buffer): Remove obsolete comment.

570 571 572 573 574 575 576 577 578 579 580 581
2011-03-11  Eli Zaretskii  <eliz@gnu.org>

	* termhooks.h (encode_terminal_code): Declare prototype.

	* msdos.c (encode_terminal_code): Don't declare prototype.

	* term.c (encode_terminal_code): Now external again, used by
	w32console.c and msdos.c.

	* makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): Depend
	on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

582
2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>
583

584
	Fix some minor problems found by GCC 4.5.2's static checks.
585

586 587 588
	* fringe.c (update_window_fringes): Mark locals as initialized
	(Bug#8227).
	(destroy_fringe_bitmap, init_fringe_bitmap): Now static.
589

590 591 592 593 594
	* alloc.c (mark_fringe_data): Move decl from here ...
	* lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
	to check its interface.
	(init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

595
	* fontset.c (free_realized_fontset): Now static.
596
	(Fset_fontset_font): Rename local to avoid shadowing.
597
	(fontset_font): Mark local as initialized.
598
	(FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
599

600 601
	* xrdb.c: Include "xterm.h", to check x_load_resources's interface.

602
	* xselect.c (x_disown_buffer_selections): Remove; not used.
603
	(TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
604 605 606
	(x_own_selection, Fx_disown_selection_internal): Rename locals
	to avoid shadowing.
	(x_handle_dnd_message): Remove local to avoid shadowing.
607

608 609 610
	* lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
	so that the caller can use some name other than gcpro1.
	(GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
611 612 613 614
	* xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p):
	Use them to avoid shadowing, and rename vars to avoid shadowing.
	(x_decode_color, x_set_name, x_window): Now static.
615
	(Fx_create_frame): Add braces to silence GCC warning.
616
	(Fx_file_dialog, Fx_select_font): Fix pointer signedness.
617 618
	(x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
	Remove unused locals.
619 620 621 622
	(Fx_create_frame, x_create_tip_frame, Fx_show_tip):
	(Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
	Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
	macros.
623

624 625
	* xterm.h (x_mouse_leave): New decl.

626 627
	* xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
	Remove unused functions.
628 629
	(x_shift_glyphs_for_insert, XTflash, XTring_bell):
	(x_calc_absolute_position): Now static.
630
	(XTread_socket): Don't define label "out" unless it's used.
631
	Don't declare local "event" unless it's used.
632 633
	(x_iconify_frame, x_free_frame_resources): Don't declare locals
	unless they are used.
634 635
	(XEMBED_VERSION, xembed_set_info): Don't define unless needed.
	(x_fatal_error_signal): Remove; not used.
636 637 638 639 640
	(x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
	(x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
	(x_error_catcher, x_connection_closed, x_error_handler):
	(x_error_quitter, xembed_send_message, x_iconify_frame):
	(my_log_handler): Rename locals to avoid shadowing.
641
	(x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
642
	(x_connection_closed): Tell GCC not to suggest NO_RETURN.
643

644 645
	* xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): Rename
	or move locals to avoid shadowing.
646
	(tty_defined_color, merge_face_heights): Now static.
647
	(free_realized_faces_for_fontset): Remove; not used.
648 649
	(Fx_list_fonts): Mark variable that gcc -Wuninitialized
	does not deduce is never used uninitialized.
650 651
	(STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
	(LFACEP): Define only if XASSERTS, as it's not needed otherwise.
652

653
	* terminal.c (store_terminal_param): Now static.
654

655
	* xmenu.c (menu_highlight_callback): Now static.
656
	(set_frame_menubar): Remove unused local.
657
	(xmenu_show): Rename parameter to avoid shadowing.
658 659
	(xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
	since they might point to immutable storage.
660 661
	(next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
	since it's unused otherwise.
662

663
	* xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
Paul Eggert's avatar
Paul Eggert committed
664
	Add a FIXME, since the code still doesn't look right.  (Bug#8215)
665 666
	(Fcurrent_bidi_paragraph_direction): Simplify slightly; this
	avoids a gcc -Wuninitialized diagnostic.
Paul Eggert's avatar
Paul Eggert committed
667
	(display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
Paul Eggert's avatar
Paul Eggert committed
668 669
	(note_mouse_highlight): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
670

Paul Eggert's avatar
Paul Eggert committed
671 672
	* lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

673
	* xdisp.c (redisplay_window): Rename local to avoid shadowing.
674 675
	* window.c (window_loop, size_window):
	(run_window_configuration_change_hook, enlarge_window): Likewise.
676

677
	* window.c (display_buffer): Now static.
678 679
	(size_window): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
680 681
	* window.h (check_all_windows): New decl, to forestall
	gcc -Wmissing-prototypes diagnostic.
682
	* dispextern.h (bidi_dump_cached_states): Likewise.
683

684 685 686
	* charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
	shadowing.
	* charset.c (map_charset_for_dump, Fchar_charset): Likewise.
Paul Eggert's avatar
Paul Eggert committed
687 688 689
	Include <limits.h>.
	(Fsort_charsets): Redo min/max calculation to shorten the code a bit
	and to avoid gcc -Wuninitialized warning.
690 691
	(load_charset_map): Mark variables that gcc -Wuninitialized
	does not deduce are never used uninitialized.
Paul Eggert's avatar
Paul Eggert committed
692
	(load_charset): Abort instead of using uninitialized var (Bug#8229).
693

694 695 696
	* coding.c (coding_set_source, coding_set_destination):
	Use "else { /* comment */ }" rather than "else /* comment */;"
	for clarity, and to avoid gcc -Wempty-body warning.
697 698 699 700 701 702 703 704 705
	(Fdefine_coding_system_internal): Don't redeclare 'i' inside
	a block, when the outer 'i' will do.
	(decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
	(emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
	(decode_coding_raw_text, decode_coding_charset, get_translation_table):
	(Fdecode_sjis_char, Fdefine_coding_system_internal):
	Rename locals to avoid shadowing.
	* character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
706 707
	* coding.c (emacs_mule_char, encode_invocation_designation):
	Now static, since they're not used elsewhere.
708
	(decode_coding_iso_2022): Add "default: abort ();" as a safety check.
709
	(decode_coding_object, encode_coding_object, detect_coding_system):
710 711
	(decode_coding_emacs_mule): Mark variables that gcc
	-Wuninitialized does not deduce are never used uninitialized.
712 713
	(detect_coding_iso_2022): Initialize a local variable that might
	be used uninitialized.  Leave a FIXME because it's not clear that
Paul Eggert's avatar
Paul Eggert committed
714
	this initialization is needed.  (Bug#8211)
715 716 717 718 719
	(ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
	(ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
	(SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
	(ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
	Remove unused macros.
720

721
	* category.c (hash_get_category_set): Remove unused local var.
722
	(copy_category_table): Now static, since it's not used elsewhere.
723
	* character.c (string_count_byte8): Likewise.
724

725 726 727
	* ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
	(Fregister_code_conversion_map): Rename locals to avoid shadowing.

728 729
	* chartab.c (copy_sub_char_table): Now static, since it's not used
	elsewhere.
730 731
	(sub_char_table_ref_and_range, char_table_ref_and_range):
	Rename locals to avoid shadowing.
732
	(ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
733

734
	* bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
735
	(BIDI_BOB): Remove unused macro.
736

737 738
	* cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
	deduce are never used uninitialized.
739
	* term.c (encode_terminal_code): Likewise.
740

741
	* term.c (encode_terminal_code): Now static.  Remove unused local.
742

Paul Eggert's avatar
Paul Eggert committed
743 744 745 746 747 748 749 750 751 752 753
	* tparam.h: New file.
	* term.c, tparam.h: Include it.
	* deps.mk (term.o, tparam.o): Depend on tparam.h.
	* term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
	Move these decls to tparam.h, and make them agree with what
	is actually in tparam.c.  The previous trick of using incompatible
	decls in different modules does not conform to the C standard.
	All callers of tparam changed to use tparam's actual API.
	* tparam.c (tparam1, tparam, tgoto):
	Use const pointers where appropriate.

754 755 756 757 758 759 760 761 762
	* cm.c (calccost, cmgoto): Use const pointers where appropriate.
	* cm.h (struct cm): Likewise.
	* dispextern.h (do_line_insertion_deletion_costs): Likewise.
	* scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
	* term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
	(term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
	(turn_on_face, init_tty): Likewise.
	* termchar.h (struct tty_display_info): Likewise.

763 764
	* term.c (term_mouse_position): Rename local to avoid shadowing.

765 766 767
	* alloc.c (mark_ttys): Move decl from here ...
	* lisp.h (mark_ttys): ... to here, so that it's checked against defn.

768 769 770 771
2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

	* .gdbinit (pwinx, xbuffer): Fix access to buffer name.

772 773 774 775 776 777
2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

	* search.c (compile_pattern_1): Remove argument regp, unused since
	revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
	(compile_pattern): Don't pass it.

778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829
2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

	* xterm.h (DEFAULT_GDK_DISPLAY): New define.
	(GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
	for ! HAVE_GTK3.
	(GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

	* xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

	* gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
	gdk_window_get_screen, gdk_window_get_geometry,
	gdk_x11_window_lookup_for_display and GDK_KEY_g.
	(xg_set_screen): Use DEFAULT_GDK_DISPLAY.
	(xg_get_pixbuf_from_pixmap): New function.
	(xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
	to Pixmap, take frame as parameter, remove GdkColormap parameter.
	Call xg_get_pixbuf_from_pixmap instead of
	gdk_pixbuf_get_from_drawable.
	(xg_get_image_for_pixmap): Do not make GdkPixmaps, call
	xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
	(xg_check_special_colors): Use GtkStyleContext and its functions
	for HAVE_GTK3.
	(xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
	(xg_prepare_tooltip, create_dialog, menubar_map_cb)
	(xg_update_frame_menubar, xg_tool_bar_detach_callback)
	(xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): Call
	gtk_widget_get_preferred_size.
	(xg_frame_resized): gdk_window_get_geometry only takes 5
	parameters.
	(xg_win_to_widget, xg_event_is_for_menubar): Call
	gdk_x11_window_lookup_for_display.
	(xg_set_widget_bg): New function.
	(delete_cb): New function.
	(xg_create_frame_widgets): connect delete-event to delete_cb.
	Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
	(xg_set_background_color): Call xg_set_widget_bg.
	(xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
	(xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
	Only call gtk_range_set_update_policy if ! HAVE_GTK3.
	(xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
	if ! HAVE_GTK3.
	(update_frame_tool_bar): Call gtk_widget_hide.
	(xg_initialize): Use GDK_KEY_g.

	* xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
	if ! HAVE_GTK3
	(x_session_initialize): Call gdk_x11_set_sm_client_id.

	* xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
	(x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
	Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

830 831 832 833 834
2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

	* w32xfns.c (select_palette): Check success of RealizePalette against
	GDI_ERROR, not zero.

Ben Key's avatar
Ben Key committed
835 836 837 838 839 840 841
2011-03-07  Ben Key  <bkey76@gmail.com>

	* w32fns.c (FILE_NAME_COMBO_BOX, FILE_NAME_LIST): Define.
	(file_dialog_callback): Fix locating the window handle of the File Name
	text field.  After disabling it, set focus on the list control.
	(Fx_file_dialog): If only_dir_p is non-nil, set the text of the File
	Name text field to "Current Directory" if it does not already have
842
	another value.  (Bug#8181)
Ben Key's avatar
Ben Key committed
843

844 845 846 847 848 849
2011-03-07  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (ns_draw_window_cursor): Fix handling of "cursor_width"
	parameter for hbar cursors.  Based on a patch by Ben Key
	<bkey76@gmail.com>.

850 851 852 853 854
2011-03-06  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (redisplay_window): Revert incorrect logic in 2011-03-06
	change.

855 856
2011-03-06  Paul Eggert  <eggert@cs.ucla.edu>

857 858 859
	current_column: Now returns EMACS_INT, fixing some iftc
	that was introduced in the 2002-06-02 change "temporarily"; see
	<http://lists.gnu.org/archive/html/emacs-devel/2002-06/msg00039.html>.
860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
	* bytecode.c (Fbyte_code): Don't cast current_column () to int.
	* cmds.c (internal_self_insert): Likewise.
	* indent.c (Fcurrent_column): Likewise.
	* keymap.c (describe_command): Likewise.
	* minibuf.c (read_minibuf): Likewise.
	* indent.c (Fcurrent_indentation): Don't cast position_indentation ()
	to int.
	* xdisp.c (redisplay_internal, redisplay_window, decode_mode_spec):
	Likewise.
	* cmds.c (internal_self_insert): Declare locals to be EMACS_INT,
	not int or double, if they might contain a column number.
	* indent.c (current_column, Findent_to, indented_beyond_p):
	(compute_motion, vmotion): Likewise.
	* keymap.c (describe_command): Likewise.
	* xdisp.c (pint2str): Likewise.
	* indent.c (last_known_column): Now EMACS_INT, not int.
	* minibuf.c (minibuf_prompt_width): Likewise.
	* indent.c (current_column, current_column_1, position_indentation):
	Return EMACS_INT, not double.
	* lisp.h (current_column): Likewise.
	* indent.c (indented_beyond_p): Last arg is now EMACS_INT, not double.
	All callers changed.
	* lisp.h (indented_beyond_p): Likewise.

884 885 886 887 888
	* minibuf.c (minibuf_prompt, minibuf_prompt_width): Move here
	from xdisp.c, and make static, since these are used only here.
	* window.h, xdisp.c (minibuf_prompt, minibuf_prompt_width):
	Remove decls.

889
	* cmds.c (internal_self_insert): Reindent to match Emacs style.
890
	* xdisp.c (redisplay_window): Likewise.
891

892 893 894 895 896 897 898 899
	* xdisp.c: Rename or move local decls to avoid shadowing.
	(init_iterator, handle_fontified_prop, handle_single_display_spec):
	(message_dolog, message_with_string, redisplay_internal):
	(redisplay_window, try_window_reusing_current_matrix, try_window_id):
	(compute_line_metrics, highlight_trailing_whitespace, cursor_row_p):
	(display_line, display_string, rows_from_pos_range):
	(mouse_face_from_buffer_pos, note_mouse_highlight, expose_frame):
	Rename or move local decls.
900
	* xdisp.c (BUILD_GLYPHLESS_GLYPH_STRING): Omit unused local var.
901 902
	(produce_glyphless_glyph): Make a pointer "const"
	since it might point to immutable storage.
903
	(update_window_cursor): Now static, since it's not used elsewhere.
904
	(SKIP_GLYPHS): Removed unused macro.
905

906 907 908 909
2011-03-06  Michael Shields  <shields@msrl.com>  (tiny change)

	* window.c (Fnext_window): Doc fix.  (Bug#5567)

910 911 912 913
2011-03-05  Chong Yidong  <cyd@stupidchicken.com>

	* nsterm.m (ns_draw_window_cursor): Fix typo in 2011-02-23 commit.

Glenn Morris's avatar
Glenn Morris committed
914
2011-03-02  Ken Brown  <kbrown@cornell.edu>
915 916 917

	* sheap.c (STATIC_HEAP_SIZE): Increase to 13MB.

918 919 920 921 922 923 924 925 926 927 928 929 930
2011-03-02  Paul Eggert  <eggert@cs.ucla.edu>

	Work around some portability problems with symlinks.

	* fileio.c (Fmake_symbolic_link): Treat ENOSYS specially, and
	generate a special message for it.  Suggested by Eli Zaretskii in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg00995.html>.
	(Frename_file, Fmake_symbolic_link, Ffile_symlink_p):
	Simplify the code by assuming that the readlink and symlink calls
	exist, even if they always fail on this host.
	(Ffile_readable_p): Likewise, for fifos.
	* config.in: Regenerate.

931 932 933 934 935 936
2011-02-27  Chong Yidong  <cyd@stupidchicken.com>

	* frame.c (store_frame_param): Don't store value directly in
	buffer_list and buried_buffer_list; copy the list and remove dead
	buffers (Bug#7898).

937 938
2011-02-27  Eli Zaretskii  <eliz@gnu.org>

939 940
	* msdos.c (readlink) [DJGPP < 2.04]: New stub function.

Juanma Barranquero's avatar
Juanma Barranquero committed
941
	* msdos.h (readlink) [DJGPP < 2.04]: Declare prototype.
942

943 944
	* w32.c (symlink, readlink): New stub functions.

945 946
2011-02-27  Paul Eggert  <eggert@cs.ucla.edu>

947 948 949
	* scroll.c (CHECK_BOUNDS): #define only if GLYPH_DEBUG.
	This avoids a gcc warning in some configurations.

950 951
	* frame.c (x_set_screen_gamma): Rename local to avoid shadowing.

952 953 954 955
	* frame.h: Avoid gcc -Wmissing-prototypes diagnostics.
	(set_menu_bar_lines, x_get_resource_string): New decls.
	* msdos.c (set_menu_bar_lines): Omit decl.

956 957 958 959 960
	* dispextern.h (struct glyph): Make u.img_id int, not unsigned.
	It's always given int values and used as an int.  This suppresses
	a gcc "comparison of unsigned expression >= 0" warning in some
	configurations.

961 962 963
	* dispnew.c: Rename locals to avoid shadowing.
	(update_text_area, scrolling_window, update_frame_1): Rename locals.

964 965 966 967 968 969 970 971 972 973
2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>

	* dispnew.c: Fix problems uncovered by gcc -Wstrict-prototypes.
	(copy_glyph_row_contents): Remove; not used.
	(frame_row_to_window, check_current_matrix_flags):
	(window_change_signal): Now static, since they're not used elsewhere.
	(check_current_matrix_flags): Surround with "#if 0", since its
	only use is in a comment.  Maybe both the comment and the "#if 0"
	stuff should be removed?

974 975 976 977
	* dispnew.c: Fix problem uncovered by gcc -Wunused-variable.
	(adjust_frame_glyphs_for_window_redisplay): Make 'w' local to the
	contexts that actually need it.

978 979 980 981 982
2011-02-26  Eli Zaretskii  <eliz@gnu.org>

	* s/msdos.h (HAVE_LSTAT): Define for DJGPP >= 2.04.
	(lstat): Define for DJGPP < 2.04.

983 984 985 986 987 988
2011-02-25  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Increase size of modes from 10 to 12
	as per recent filemodestring API change.  Reported by Jonas Öster in
	<http://lists.gnu.org/archive/html/emacs-devel/2011-02/msg01069.html>.

989
2011-02-23  Ben Key  <bkey76@gmail.com>
990 991 992 993 994 995 996 997 998

	* nsterm.m (ns_draw_window_cursor): Obey the cursor_width argument
	directly, for bar cursors.

2011-02-23  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (set_frame_cursor_types): Don't write an undefined value
	into the frame's cursor_width.

999 1000 1001 1002 1003
2011-02-23  Stefan Monnier  <monnier@iro.umontreal.ca>

	* print.c (print_object): Never print old-style backquotes.
	Obey escapeflag for hash tables as well.

1004
2011-02-23  Kenichi Handa  <handa@m17n.org>
Kenichi Handa's avatar
Kenichi Handa committed
1005 1006

	* font.c (font_open_entity): Be sure to set scaled_pixel_size.
1007
	(font_find_for_lface): Check if attrs[LFACE_HEIGHT_INDEX] is integer.
Kenichi Handa's avatar
Kenichi Handa committed
1008

1009 1010 1011 1012
2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>

	* dired.c (Ffile_attributes): Simplify and avoid #ifdef.

1013 1014 1015 1016
2011-02-22  Wolfgang Jenkner  <wjenkner@inode.at>  (tiny change)

	* lread.c (openp): Correct Boolean typo in last commit.

1017 1018 1019
2011-02-22  Adrian Robert  <Adrian.B.Robert@gmail.com>

	* nsterm.m (EmacsView-keyDown:): Don't pass shift-only-modified
1020
	key to Emacs, treat as unmodified (go to input manager processing).
Adrian Robert's avatar