ChangeLog 82.1 KB
Newer Older
1 2
2011-04-14  Paul Eggert  <eggert@cs.ucla.edu>

3 4
	* lisp.h (verify_bytepos, count_markers): Mark as externally visible.

5 6 7 8 9 10
	* lread.c: Make symbols static if they're not exported.
	(read_objects, initial_obarray, oblookup_last_bucket_number):
	Now static.
	(make_symbol): Remove; unused.
	* lisp.h (initial_obarray, make_symbol): Remove decls.

11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33
	* keyboard.c: Make symbols static if they're not exported.
	(single_kboard, recent_keys_index, total_keys, recent_keys):
	(this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
	(this_single_command_key_start, echoing, last_auto_save):
	(read_key_sequence_cmd, dribble, recursive_edit_unwind):
	(command_loop, echo_now, keyboard_init_hook, help_char_p):
	(quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
	(Vlispy_mouse_stem, double_click_count):
	Now static.
	(force_auto_save_soon): Define only if SIGDANGER.
	(ignore_mouse_drag_p): Now static if
	!defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
	(print_help): Remove; unused.
	(stop_character, last_timer_event): Mark as externally visible.
	* keyboard.h (ignore_mouse_drag_p): Declare only if
	defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
	(echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
	* lisp.h (echoing): Remove decl.
	(force_auto_save_soon): Declare only if SIGDANGER.
	* xdisp.c (redisplay_window): Simplify code, to make it more
	obvious that ignore_mouse_drag_p is not accessed if !defined
	USE_GTK && !defined HAVE_NS.

34 35 36 37 38
	* intervals.c: Make symbols static if they're not exported.
	(merge_properties_sticky, merge_interval_right, delete_interval):
	Now static.
	* intervals.h (merge_interval_right, delete_interval): Remove decls.

39 40
2011-04-13  Paul Eggert  <eggert@cs.ucla.edu>

41 42 43 44
	* insdel.c: Make symbols static if they're not exported.
	However, leave prepare_to_modify_buffer alone.  It's never
	called from outside this function, but that appears to be a bug.
	(combine_after_change_list, combine_after_change_buffer):
45
	(adjust_after_replace, signal_before_change): Now static.
46 47
	(adjust_after_replace_noundo): Remove; unused.
	* lisp.h (adjust_after_replace, adjust_after_replace_noundo):
48
	(signal_before_change): Remove decls.
49

50 51
	* indent.c (val_compute_motion, val_vmotion): Now static.

52 53 54 55 56 57
	* image.c: Make symbols static if they're not exported.
	* dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
	if USE_GTK.
	* image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
	(xpm_color_cache, ct_table, ct_colors_allocated): Now static.

58 59 60
	* fringe.c (standard_bitmaps): Now static.
	(max_used_fringe_bitmap): Now static, unless HAVE_NS.

61 62 63 64 65 66 67 68 69 70
	* frame.c: Make symbols static if they're not exported.
	(x_report_frame_params, make_terminal_frame): Now static.
	(get_frame_param): Now static, unless HAVE_NS.
	(x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
	(x_get_resource_string): Remove; not used.
	* frame.h (make_terminal_frame, x_report_frame_params):
	(x_get_resource_string); Remove decls.
	(x_fullscreen_adjust): Declare only if WINDOWSNT.
	* lisp.h (get_frame_param): Declare only if HAVE_NS.

71 72 73 74 75 76 77 78 79 80 81 82 83
	* font.c, fontset.c: Make symbols static if they're not exported.
	* dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
	(FACE_SUITABLE_FOR_CHAR_P): Use it.
	* font.c (font_close_object): Now static.
	* font.h (font_close_object): Remove.
	* fontset.c (FONTSET_OBJLIST): Remove.
	(free_realized_fontset) #if-0 the body, which does nothing.
	(face_suitable_for_char_p): #if-0, as it's never called.
	* fontset.h (face_suitable_for_char_p): Remove decl.
	* xfaces.c (face_at_string_position): Use
	FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
	since 0 is always ASCII.

84 85
	* fns.c (weak_hash_tables): Now static.

86 87 88 89
	* fileio.c: Make symbols static if they're not exported.
	(auto_saving, auto_save_mode_bits, auto_save_error_occurred):
	(Vwrite_region_annotation_buffers): Now static.

90 91 92 93
	* eval.c: Make symbols static if they're not exported.
	(backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
	* lisp.h (backtrace_list): Remove decl.

94 95 96 97 98 99 100 101 102 103
	* emacs.c: Make symbols static if they're not exported.
	(malloc_state_ptr, malloc_using_checking, syms_of_emacs):
	(fatal_error_code, fatal_error_signal_hook, standard_args):
	Now static.
	(fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
	(DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
	(__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
	* lisp.h (fatal_error_signal_hook): Remove decl.
	(fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.

104 105 106 107 108
	* editfns.c: Move a (normally-unused) function to its only use.
	* editfns.c, lisp.h (get_operating_system_release): Remove.
	* process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
	worth the hassle of breaking this out.

109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124
	* xterm.c: Make symbols static if they're not exported.
	(x_raise_frame, x_lower_frame, x_wm_set_window_state):
	(x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
	(x_destroy_window, x_delete_display):
	Now static.
	(x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
	(x_mouse_leave): Remove; unused.
	* xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
	(x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
	(x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
	Remove decls.
	(x_mouse_leave): Declare only if WINDOWSNT.
	(x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
	(xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
	USE_X_TOOLKIT.

125 126
2011-04-12  Paul Eggert  <eggert@cs.ucla.edu>

127 128 129 130 131
	* ftxfont.c: Make symbols static if they're not exported.
	(ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
	HAVE_FREETYPE.
	* font.h (ftxfont_driver): Likewise.

132 133 134 135 136 137 138 139 140 141 142 143 144
	* xfns.c: Make symbols static if they're not exported.
	(x_last_font_name, x_display_info_for_name):
	(x_set_foreground_color, x_set_background_color, x_set_mouse_color):
	(x_set_cursor_color, x_set_border_pixel, x_set_border_color):
	(x_set_cursor_type, x_set_icon_type, x_set_icon_name):
	(x_set_scroll_bar_foreground, x_set_scroll_bar_background):
	(x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
	(last_show_tip_args): Now static.
	(xic_defaut_fontset, xic_create_fontsetname): Define only if
	defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
	(x_screen_planes): Remove; unused.
	* dispextern.h (x_screen_planes): Remove decl.

145 146 147 148 149 150 151 152
	* dispnew.c: Make symbols static if they're not exported.
	* dispextern.h (redraw_garbaged_frames, scrolling):
	(increment_row_positions): Remove.
	* dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
	(delayed_size_change, glyph_matrix_count, glyph_pool_count):
	Now static.
	(redraw_garbaged_frames): Remove; unused.

153 154 155 156 157 158 159 160 161 162
	* xfaces.c: Make symbols static if they're not exported.
	* dispextern.h (ascii_face_of_lisp_face, free_realized_face):
	Remove decls.
	* xterm.h (defined_color): Remove decls.
	(x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
	* xfaces.c (tty_suppress_bold_inverse_default_colors_p):
	(menu_face_changed_default, defined_color, free_realized_face):
	(x_free_dpy_colors): Define only if USE_X_TOOLKIT.
	(ascii_face_of_lisp_face): Remove; unused.

163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
	* xdisp.c: Make symbols static if they're not exported.
	* dispextern.h (scratch_glyph_row, window_box_edges):
	(glyph_to_pixel_coords, set_cursor_from_row):
	(get_next_display_element, set_iterator_to_next):
	(highlight_trailing_whitespace, frame_to_window_pixel_xy):
	(show_mouse_face): Remove decls
	* frame.h (message_buf_print): Likewise.
	* lisp.h (pop_message, set_message, check_point_in_composition):
	Likewise.
	* xterm.h (set_vertical_scroll_bar): Likewise.
	* xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
	(message_buf_print, scratch_glyph_row, displayed_buffer):
	(set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
	(get_next_display_element, show_mouse_face, window_box_edges):
	(frame_to_window_pixel_xy, check_point_in_composition):
	(set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
	(glyph_to_pixel_coords): Remove; unused.

181 182 183 184
	* dired.c (file_name_completion): Now static.

	* dbusbind.c (xd_in_read_queued_messages): Now static.

185 186 187
	* lisp.h (circular_list_error, FOREACH): Remove; unused.
	* data.c (circular_list_error): Remove.

188 189
2011-04-11  Paul Eggert  <eggert@cs.ucla.edu>

190 191 192 193
	* commands.h (last_point_position, last_point_position_buffer):
	(last_point_position_window): Remove decls.
	* keyboard.c: Make these variables static.

194 195 196 197 198 199
	* coding.h (coding, code_convert_region, encode_coding_gap): Remove
	decls.
	* coding.c (Vsjis_coding_system, Vbig5_coding_system):
	(iso_code_class, detect_coding, code_convert_region): Now static.
	(encode_coding_gap): Remove; unused.

200 201
	* chartab.c (chartab_chars, chartab_bits): Now static.

202 203 204 205
	* charset.h (charset_iso_8859_1): Remove decl.
	* charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
	Now static.

206 207 208 209
	* ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
	* ccl.c (Vccl_program_table): Now static.
	(check_ccl_update): Remove; unused.

210 211 212 213
	* category.c (SET_CATEGORY_SET, set_category_set): Move here.
	* category.h: ... from here.
	* category.c (check_category_table, set_category_set): Now static.

214 215 216
	* casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
	* lisp.h: Remove these decls.

217 218
	* buffer.c (buffer_count): Remove unused var.

219 220 221 222 223 224
	* bidi.c (bidi_dump_cached_states): Mark as externally visible,
	so that it's not optimized away.
	(bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
	* dispextern.h (bidi_dump_cached_states): Remove, since it's
	exported only to the debugger.

225 226 227
	* atimer.c (alarm_signal_handler, run_all_atimers): Now static.
	* atimer.h (run_all_atimers): Removed; not exported.

228 229 230 231 232 233
	font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
	* font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
	was inaccessible from Lisp.
	(merge_font_spec): Likewise, renaming from Fmerge_font_spec.
	* font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.

234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253
	alloc.c: Import and export fewer symbols, and remove unused items.
	* lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
	is defined.
	(suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
	it's not optimized away by whole-program optimization.
	(message_enable_multibyte, free_misc): Remove.
	(catchlist, handlerlist, mark_backtrace):
	Declare only if BYTE_MARK_STACK.
	(mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
	* alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
	(message_enable_multibyte): Remove decl.
	(free_misc, interval_free_list, float_block, float_block_index):
	(n_float_blocks, float_free_list, cons_block, cons_block_index):
	(cons_free_list, last_marked_index):
	Now static.
	(suppress_checking, die): Define only if ENABLE_CHECKING is defined.
	* eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
	(mark_backtrace): Define only if BYTE_MARK_STACK.
	* xdisp.c (message_enable_multibyte): Now static.

254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
	Declare Lisp_Object Q* variables to be 'static' if not exproted.
	This makes it easier for human readers (and static analyzers)
	to see whether these variables are used from other modules.
	* alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
	* ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
	* data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
	* font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
	* lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
	* sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
	* xmenu.c, xselect.c:
	Declare Q* vars static if they are not used in other modules.
	* ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
	* frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
	Remove decls of unexported vars.
	* keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.

270 271
	* lisp.h (DEFINE_FUNC): Make sname 'static'.

272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287
	Make Emacs functions such as Fatom 'static' by default.
	This makes it easier for human readers (and static analyzers)
	to see whether these functions can be called from other modules.
	DEFUN now defines a static function.  To make the function external
	so that it can be used in other C modules, use the new macro DEFUE.
	* lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
	(DEFUN): Rewrite in terms of DEFINE_FUNC.  It now generates a
	static function definition.  Use DEFUE if you want an extern one.
	(DEFUE, INFUN): New macros.
	(Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
	(Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
	(Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
	(Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
	Remove decls, since these functions are now static.
	(Funintern, Fget_internal_run_time): New decls, since these functions
	were already external.
288

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329
	* alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
	* ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
	* doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
	* fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
	* keyboard.c, keymap.c, lread.c:
	* macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
	* syntax.c, term.c, terminal.c, textprop.c, undo.c:
	* window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
	Mark functions with DEFUE instead of DEFUN,
	if they are used in other modules.
	* buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
	decls for now-static functions.
	* buffer.h (Fdelete_overlay): Remove decl.
	* callproc.c (Fgetenv_internal): Mark as internal.
	* composite.c (Fremove_list_of_text_properties): Remove decl.
	(Fcomposition_get_gstring): New forward static decl.
	* composite.h (Fcomposite_get_gstring): Remove decl.
	* dired.c (Ffile_attributes): New forward static decl.
	* doc.c (Fdocumntation_property): New forward static decl.
	* eval.c (Ffetch_bytecode): New forward static decl.
	(Funintern): Remove extern decl; now in .h file where it belongs.
	* fileio.c (Fmake_symbolic_link): New forward static decl.
	* image.c (Finit_image_library): New forward static decl.
	* insdel.c (Fcombine_after_change_execute): Make forward decl static.
	* intervals.h (Fprevious_property_change):
	(Fremove_list_of_text_properties): Remove decls.
	* keyboard.c (Fthis_command_keys): Remove decl.
	(Fcommand_execute): New forward static decl.
	* keymap.c (Flookup_key): New forward static decl.
	(Fcopy_keymap): Now static.
	* keymap.h (Flookup_key): Remove decl.
	* process.c (Fget_process): New forward static decl.
	(Fprocess_datagram_address): Mark as internal.
	* syntax.c (Fsyntax_table_p): New forward static decl.
	(skip_chars): Remove duplicate decl.
	* textprop.c (Fprevious_property_change): New forward static decl.
	* window.c (Fset_window_fringes, Fset_window_scroll_bars):
	Now internal.
	(Fset_window_margins, Fset_window_vscroll): New forward static decls.
	* window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.

330 331 332 333
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>

	* editfns.c (Fformat): Remove unreachable code.

Paul Eggert's avatar
Paul Eggert committed
334
2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>
335

336 337
	Fix more problems found by GCC 4.6.0's static checks.

338 339
	* xdisp.c (vmessage): Use a better test for character truncation.

340 341
	* charset.c (load_charset_map): <, not <=, for optimization,
	and to avoid potential problems with integer overflow.
342
	* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
343
	* casetab.c (set_identity, shuffle): Likewise.
Paul Eggert's avatar
Paul Eggert committed
344
	* editfns.c (Fformat): Likewise.
345
	* syntax.c (skip_chars): Likewise.
346

347 348 349
	* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
	This also lets GCC 4.6.0 generate slightly better loop code.

350 351 352 353 354
	* callint.c (Fcall_interactively): <, not <=, for optimization.
	(Fcall_interactively): Count the number of arguments produced,
	not the number of arguments given.  This is simpler and lets GCC
	4.6.0 generate slightly better code.

355 356 357 358 359 360 361 362
	* ftfont.c: Distingish more carefully between FcChar8 and char.
	The previous code passed unsigned char * to a functions like
	strlen and xstrcasecmp that expect char *, which does not
	conform to the C standard.
	(get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
	arguments to FcPatternGetString, and explicitly cast FcChar8 * to
	char * when the C standard requires it.

363 364
	* keyboard.c (read_char): Remove unused var.

365 366 367 368 369 370 371 372 373
	* eval.c: Port to Windows vsnprintf (Bug#8435).
	Include <limits.h>.
	(SIZE_MAX): Define if the headers do not.
	(verror): Do not give up if vsnprintf returns a negative count.
	Instead, grow the buffer.  This ports to Windows vsnprintf, which
	does not conform to C99.  Problem reported by Eli Zaretskii.
	Also, simplify the allocation scheme, by avoiding the need for
	calling realloc, and removing the ALLOCATED variable.

374 375
	* eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

376 377 378
	Remove invocations of doprnt, as Emacs now uses vsnprintf.
	But keep the doprint source code for now, as we might revamp it
	and use it again (Bug#8435).
379 380 381 382
	* lisp.h (doprnt): Remove.
	* Makefile.in (base_obj): Remove doprnt.o.
	* deps.mk (doprnt.o): Remove.

383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404
	error: Print 32- and 64-bit integers portably (Bug#8435).
	Without this change, on typical 64-bit hosts error ("...%d...", N)
	was used to print both 32- and 64-bit integers N, which relied on
	undefined behavior.
	* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
	New macro.
	* lisp.h (error, verror): Mark as printf-like functions.
	* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
	Report overflow in size calculations when allocating printf buffer.
	Do not truncate output string at its first null byte.
	* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
	Truncate the output at a character boundary, since vsnprintf does not
	do that.
	* charset.c (check_iso_charset_parameter): Convert internal
	character to string before calling 'error', since %c now has the
	printf meaning.
	* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
	overflow when computing char to be passed to 'error'.  Do not
	pass Lisp_Object to 'error'; pass the integer instead.
	* nsfns.m (Fns_do_applescript): Use int, not long, since it's
	formatted with plain %d.

405 406
	* eval.c (internal_lisp_condition_case): Don't pass spurious arg.

407 408
	* keyboard.c (access_keymap_keyremap): Print func name, not garbage.

409 410
	* coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

411 412
	* xterm.c (x_catch_errors): Remove duplicate declaration.

413 414
	* term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

415 416
	* xdisp.c, lisp.h (message_nolog): Remove; unused.

417 418 419 420 421 422 423 424 425 426
2011-04-10  Jim Meyering  <meyering@redhat.com>

	use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
	* gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
	return ssize_t not "int", and use size_t as the buffer length.
	(emacs_gnutls_write): Likewise, and make the buffer pointer "const".
	* gnutls.h: Update declarations.
	* process.c (read_process_output): Use ssize_t, to match.
	(send_process): Likewise.

427 428 429 430
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

	* image.c (Fimagemagick_types): Doc fix, and comment cleanup.

431
2011-04-09  Chong Yidong  <cyd@stupidchicken.com>
432

433 434
	* ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
	unsigned char, to match FcChar8 type definition.
435

436 437 438 439
	* xterm.c (handle_one_xevent):
	* xmenu.c (create_and_show_popup_menu):
	* xselect.c (x_decline_selection_request)
	(x_reply_selection_request): Avoid type-punned deref of X events.
440

441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481
2011-04-09  Eli Zaretskii  <eliz@emacstest.gnu.org>

	Fix some uses of `int' instead of EMACS_INT.
	* search.c (string_match_1, fast_string_match)
	(fast_c_string_match_ignore_case, fast_string_match_ignore_case)
	(scan_buffer, find_next_newline_no_quit)
	(find_before_next_newline, search_command, Freplace_match)
	(Fmatch_data): Make some `int' variables be EMACS_INT.

	* xdisp.c (display_count_lines): 3rd argument and return value now
	EMACS_INT.  All callers changed.
	(pint2hrstr): Last argument is now EMACS_INT.

	* coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
	(detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
	(detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
	(decode_coding_utf_16, decode_coding_emacs_mule)
	(decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
	(decode_coding_ccl, decode_coding_charset)
	<consumed_chars, consumed_chars_base>: Declare EMACS_INT.
	(decode_coding_iso_2022, decode_coding_emacs_mule)
	(decode_coding_sjis, decode_coding_big5, decode_coding_charset)
	<char_offset, last_offset>: Declare EMACS_INT.
	(encode_coding_utf_8, encode_coding_utf_16)
	(encode_coding_emacs_mule, encode_invocation_designation)
	(encode_designation_at_bol, encode_coding_iso_2022)
	(encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
	(encode_coding_raw_text, encode_coding_charset) <produced_chars>:
	Declare EMACS_INT.
	(ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
	(encode_invocation_designation): Last argument P_NCHARS is now
	EMACS_INT.
	(decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
	(produce_chars): from_nchars and to_nchars are now EMACS_INT.

	* coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
	All users changed.

	* ccl.c (Fccl_execute_on_string): Declare some variables
	EMACS_INT.

482
2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)
483 484 485

	* term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

486 487 488 489
2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

	* process.c (Fformat_network_address): Doc fix.

490 491 492 493
2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

	* xml.c (parse_region): Avoid creating spurious whiespace nodes.

494 495 496 497 498
2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

	* keyboard.c (read_char): Call Lisp function help-form-show,
	instead of using internal_with_output_to_temp_buffer.
	(Qhelp_form_show): New var.
499
	(syms_of_keyboard): Use DEFSYM macro.
500 501 502 503 504

	* print.c (internal_with_output_to_temp_buffer): Function deleted.

	* lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

505 506 507 508 509
2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

	* process.c (Flist_processes): Removed to Lisp.
	(list_processes_1): Deleted.

510 511
2011-04-06  Eli Zaretskii  <eliz@gnu.org>

512 513
	* msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

514 515
	* w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

516
2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
517

Paul Eggert's avatar
Paul Eggert committed
518 519
	Fix more problems found by GCC 4.6.0's static checks.

520 521
	* xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

522 523
	* menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

524
	* lisp.h (message, message_nolog, fatal): Mark as printf-like.
525

526 527
	* xdisp.c (vmessage): Mark as a printf-like function.

528 529
	* term.c (vfatal, maybe_fatal): Mark as printf-like functions.

530 531
	* sound.c (sound_warning): Don't crash if arg contains a printf format.

532 533 534 535 536
	* image.c (tiff_error_handler, tiff_warning_handler): Mark as
	printf-like functions.
	(tiff_load): Add casts to remove these marks before passing them
	to system-supplied API.

537 538
	* eval.c (Fsignal): Remove excess argument to 'fatal'.

539 540
	* coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
	This avoids several warnings with gcc -Wstrict-overflow.
541 542 543 544 545 546
	(DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
	directly, rather than having caller test rule sign.  This avoids
	some unnecessary tests.
	* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
	(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
	affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
547

548
	* xfont.c (xfont_text_extents): Remove var that was set but not used.
549
	(xfont_open): Avoid unnecessary tests.
550

551 552
	* composite.c (composition_gstring_put_cache): Use unsigned integer.

553 554 555
	* composite.h, composite.c (composition_gstring_put_cache):
	Use EMACS_INT, not int, for length.

556 557 558 559 560 561
	* composite.h (COMPOSITION_DECODE_REFS): New macro,
	breaking out part of COMPOSITION_DECODE_RULE.
	(COMPOSITION_DECODE_RULE): Use it.
	* composite.c (get_composition_id): Remove unused local vars,
	by using the new macro.

562 563 564
	* textprop.c (set_text_properties_1): Change while to do-while,
	since the condition is always true at first.

565
	* intervals.c (graft_intervals_into_buffer): Mark var as used.
566 567
	(interval_deletion_adjustment): Return unsigned value.
	All uses changed.
568

569 570
	* process.c (list_processes_1, create_pty, read_process_output):
	(exec_sentinel): Remove vars that were set but not used.
571
	(create_pty): Remove unnecessary "volatile"s.
572
	(Fnetwork_interface_info): Avoid possibility of int overflow.
573
	(read_process_output): Do adaptive read buffering even if carryover.
574
	(read_process_output): Simplify nbytes computation if buffered.
575

576 577
	* bytecode.c (exec_byte_code): Rename local to avoid shadowing.

578
	* syntax.c (scan_words): Remove var that was set but not used.
579
	(update_syntax_table): Use unsigned instead of int.
580

581
	* lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
582
	(lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
583
	(safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
584

585 586
	* print.c (print_error_message): Avoid int overflow.

587 588 589
	* font.c (font_list_entities): Redo for clarity,
	so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

590
	* font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
591
	(font_score): Avoid potential overflow in diff calculation.
592

593
	* fns.c (substring_both): Remove var that is set but not used.
594
	(sxhash): Redo loop for clarity and to avoid wraparound warning.
595

596 597
	* eval.c (funcall_lambda): Rename local to avoid shadowing.

598 599 600 601
	* alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
	Otherwise, GCC 4.6.0 optimizes the loop check away since the check
	can always succeed if overflow has undefined behavior.

602
	* search.c (boyer_moore, wordify): Remove vars set but not used.
603
	(wordify): Omit three unnecessary tests.
604

605 606 607
	* indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
	All callers changed.  This avoids the need for an unused var.

608 609
	* casefiddle.c (casify_region): Remove var that is set but not used.

610 611
	* dired.c (file_name_completion): Remove var that is set but not used.

612 613
	* fileio.c (Finsert_file_contents): Make EOF condition clearer.

614
	* fileio.c (Finsert_file_contents): Avoid signed integer overflow.
615
	(Finsert_file_contents): Remove unnecessary code checking fd.
616

617 618 619
	* minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
	Check for integer overflow on size calculations.

620 621 622
	* buffer.c (Fprevious_overlay_change): Remove var that is set
	but not used.

623 624
	* keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
	Remove vars that are set but not used.
625
	(timer_check_2): Don't assume timer-list and idle-timer-list are lists.
626
	(timer_check_2): Mark vars as initialized.
627

628 629
	* gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

630
	* image.c (lookup_image): Remove var that is set but not used.
631
	(xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
632

633 634 635
	* fontset.c (Finternal_char_font, Ffontset_info): Remove vars
	that are set but not used.

636
	* xfns.c (make_invisible_cursor): Don't return garbage
Paul Eggert's avatar
Paul Eggert committed
637
	if XCreateBitmapFromData fails (Bug#8410).
638

639 640 641
	* xselect.c (x_get_local_selection, x_handle_property_notify):
	Remove vars that are set but not used.

642
	* xfns.c (x_create_tip_frame): Remove var that is set but not used.
643
	(make_invisible_cursor): Initialize a possibly-uninitialized variable.
644

645 646
	* xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
	Remove var that is set but not used.
647 648 649
	(scroll_bar_windows_size): Now size_t, not int.
	(x_send_scroll_bar_event): Use size_t, not int, for sizes.
	Check for overflow.
650

651 652 653
	* xfaces.c (realize_named_face): Remove vars that are set but not used.
	(map_tty_color) [!defined MSDOS]: Likewise.

654 655
	* term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

656 657 658 659 660 661 662
	* coding.c: Remove vars that are set but not used.
	(DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
	All callers changed.
	(decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
	(decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
	(decode_coding_charset): Remove vars that are set but not used.

663 664 665
	* bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
	that is set but not used.

666 667
	* print.c (print_object): Remove var that is set but not used.

Paul Eggert's avatar
Paul Eggert committed
668
	Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
669 670 671 672 673 674 675 676
	The gnulib version avoids calling malloc in the usual case,
	and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
	* fileio.c (Ffile_symlink_p): Use emacs_readlink.
	* filelock.c (current_lock_owner): Likewise.
	* lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
	* sysdep.c: Include allocator.h, careadlinkat.h.
	(emacs_no_realloc_allocator): New static constant.
	(emacs_readlink): New function.
Paul Eggert's avatar
Paul Eggert committed
677 678
	* deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
	../lib/careadlinkat.h.
679

680 681 682 683 684
2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
	first non-nil return value).

685 686 687 688 689
2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
	if not defined (Bug#8403).

690 691 692 693 694 695 696 697 698 699 700 701
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (display_count_lines): Remove parameter `start',
	unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(get_char_face_and_encoding): Remove parameter `multibyte_p',
	unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
	(fill_stretch_glyph_string): Remove parameters `row' and `area',
	unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
	and thereabouts.  All callers changed.
	(get_per_char_metric): Remove parameter `f', unused since
	2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

702 703 704 705 706 707
2011-04-02  Jim Meyering  <meyering@redhat.com>

	do not dereference NULL upon failed strdup
	* nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
	(ns_get_family): Likewise.

708 709 710 711
2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

	* eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

712 713 714 715 716
2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
	later (Bug#8403).

717 718
2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

719
	Add lexical binding.
720

721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737
	* window.c (Ftemp_output_buffer_show): New fun.
	(Fsave_window_excursion):
	* print.c (Fwith_output_to_temp_buffer): Move to subr.el.

	* lread.c (lisp_file_lexically_bound_p): New function.
	(Fload): Bind Qlexical_binding.
	(readevalloop): Remove `evalfun' arg.
	Bind Qinternal_interpreter_environment.
	(Feval_buffer): Bind Qlexical_binding.
	(defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
	Mark as dynamic.
	(syms_of_lread): Declare `lexical-binding'.

	* lisp.h (struct Lisp_Symbol): New field `declared_special'.

	* keyboard.c (eval_dyn): New fun.
	(menu_item_eval_property): Use it.
738 739 740

	* image.c (parse_image_spec): Use Ffunctionp.

741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758
	* fns.c (concat, mapcar1): Accept byte-code-functions.

	* eval.c (Fsetq): Handle lexical vars.
	(Fdefun, Fdefmacro, Ffunction): Make closures when needed.
	(Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
	(FletX, Flet): Obey lexical binding.
	(Fcommandp): Handle closures.
	(Feval): New `lexical' arg.
	(eval_sub): New function extracted from Feval.  Use it almost
	everywhere where Feval was used.  Look up vars in lexical env.
	Handle closures.
	(Ffunctionp): Move from subr.el.
	(Ffuncall): Handle closures.
	(apply_lambda): Remove `eval_flags'.
	(funcall_lambda): Handle closures and new byte-code-functions.
	(Fspecial_variable_p): New function.
	(syms_of_eval): Initialize the Vinternal_interpreter_environment var,
	but without exporting it to Lisp.
759 760

	* doc.c (Fdocumentation, store_function_docstring):
761
	* data.c (Finteractive_form): Handle closures.
762

763 764
	* callint.c (Fcall_interactively): Preserve lexical-binding mode for
	interactive spec.
765

766 767 768 769
	* bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
	byte-codes.
	(exec_byte_code): New function extracted from Fbyte_code to handle new
	calling convention for byte-code-functions.  Add new byte-codes.
770

771
	* buffer.c (defvar_per_buffer): Set new `declared_special' field.
772

773
	* alloc.c (Fmake_symbol): Init new `declared_special' field.
774

775 776 777 778
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* xdisp.c (redisplay_internal): Fix prototype.

779
2011-03-31  Eli Zaretskii  <eliz@gnu.org>
780

781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797
	* xdisp.c (SCROLL_LIMIT): New macro.
	(try_scrolling): Use it when setting scroll_limit.  Limit
	scrolling to 100 screen lines.
	(redisplay_window): Even when falling back on "recentering",
	position point in the window according to scroll-conservatively,
	scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

	(try_scrolling): When point is above the window, allow searching
	as far as scroll_max, or one screenful, to compute vertical
	distance from PT to the scroll margin position.  This prevents
	try_scrolling from unnecessarily failing when
	scroll-conservatively is set to a value slightly larger than the
	window height.  Clean up the case of PT below the margin at bottom
	of window: scroll_max can no longer be INT_MAX.  When aggressive
	scrolling is in use, don't let point enter the opposite scroll
	margin as result of the scroll.
	(syms_of_xdisp) <scroll-conservatively>: Document the
798 799
	threshold of 100 lines for never-recentering scrolling.

800 801 802 803 804 805 806 807 808 809 810 811 812 813
2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (move_it_by_lines):
	* xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
	since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
	(message_log_check_duplicate): Remove parameters `prev_bol' and
	`this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
	(redisplay_internal): Remove parameter `preserve_echo_area',
	unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

	* indent.c (Fvertical_motion):
	* window.c (window_scroll_pixel_based, Frecenter):
	Don't pass `need_y_p' to `move_it_by_lines'.

814 815
2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

816 817 818 819 820
	* eval.c (struct backtrace): Don't cheat with negative numbers, but do
	steal a few bits to be more compact.
	(interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
	Remove unneeded casts.

821 822
	* bytecode.c (Fbyte_code): CAR and CDR can GC.

823 824 825 826 827
2011-03-30  Zachary Kanfer  <zkanfer@gmail.com>  (tiny change)

	* keyboard.c (Fexecute_extended_command): Do log the "suggest key
	binding" message (bug#7967).

828 829
2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>

830 831
	Fix more problems found by GCC 4.6.0's static checks.

832 833 834
	* unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
	Remove unused local var.

835 836
	* editfns.c (Fmessage_box): Remove unused local var.

837 838 839
	* xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
	(note_mode_line_or_margin_highlight, note_mouse_highlight):
	Omit unused local vars.
840
	* window.c (shrink_windows): Omit unused local var.
841
	* menu.c (digest_single_submenu): Omit unused local var.
842 843 844
	* dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
	Omit unused local var.

845 846
	* keyboard.c (parse_modifiers_uncached, parse_modifiers):
	Don't assume string length fits in int.
847
	(keyremap_step, read_key_sequence): Use size_t for sizes.
848
	(read_key_sequence): Don't check last_real_key_start redundantly.
849

850 851 852
	* callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
	instead of alloca (Bug#8344).

853
	* eval.c (Fbacktrace): Don't assume nargs fits in int.
854
	(Fbacktrace_frame): Don't assume nframes fits in int.
855

856 857
	* syntax.c (scan_sexps_forward): Avoid pointer wraparound.

Paul Eggert's avatar
Paul Eggert committed
858 859 860 861 862 863
	* xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
	concerns.

	* term.c (produce_glyphless_glyph): Remove unnecessary test.

	* cm.c (calccost): Turn while-do into do-while, for clarity.
864

865 866 867 868
	* keyboard.c (syms_of_keyboard): Use the same style as later
	in this function when indexing through an array.  This also
	works around GCC bug 48267.

869 870
	* image.c (tiff_load): Fix off-by-one image count (Bug#8336).

871 872
	* xselect.c (x_check_property_data): Return correct size (Bug#8335).

873 874 875
	* chartab.c (sub_char_table_ref_and_range): Redo for slight
	efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

876 877 878 879
	* keyboard.c, keyboard.h (num_input_events): Now size_t.
	This avoids undefined behavior on integer overflow, and is a bit
	more convenient anyway since it is compared to a size_t variable.

880 881 882 883 884
	Variadic C functions now count arguments with size_t, not int.
	This avoids an unnecessary limitation on 64-bit machines, which
	caused (substring ...) to crash on large vectors (Bug#8344).
	* lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
	(DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
885
	All variadic functions and their callers changed accordingly.
886 887 888 889 890 891 892 893 894 895 896
	(struct gcpro.nvars): Now size_t, not int.  All uses changed.
	* data.c (arith_driver, float_arith_driver): Likewise.
	* editfns.c (general_insert_function): Likewise.
	* eval.c (struct backtrace.nargs, interactive_p)
	(internal_condition_case_n, run_hook_with_args, apply_lambda)
	(funcall_lambda, mark_backtrace): Likewise.
	* fns.c (concat): Likewise.
	* frame.c (x_set_frame_parameters): Likewise.
	* fns.c (get_key_arg): Now accepts and returns size_t, and returns
	0 if not found, not -1.  All callers changed.

897 898 899 900
	* alloc.c (garbage_collect): Don't assume stack size fits in int.
	(stack_copy_size): Now size_t, not int.
	(stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
	unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	All callers changed.

	* lisp.h (multibyte_char_to_unibyte):
	* character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
	unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
	* character.h (CHAR_TO_BYTE8):
	* cmds.c (internal_self_insert):
	* editfns.c (general_insert_function):
	* keymap.c (push_key_description):
	* search.c (Freplace_match):
	* xdisp.c (message_dolog, set_message_1): All callers changed.

917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933
2011-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (safe_run_hook_funcall): New function.
	(safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
	don't set the hook to nil, but remove the offending function instead.
	(Qcommand_hook_internal): Remove, unused.
	(syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
	Vcommand_hook_internal.

	* eval.c (enum run_hooks_condition): Remove.
	(funcall_nil, funcall_not): New functions.
	(run_hook_with_args): Call each function through a `funcall' argument.
	Remove `cond' argument, now redundant.
	(Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
	(Frun_hook_with_args_until_failure): Adjust accordingly.
	(run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.

934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957
2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (string_buffer_position): Remove declaration.

	* print.c (strout): Remove parameter `multibyte', unused since
	1999-08-21T19:30:21Z!gerd@gnu.org.  All callers changed.

	* search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
	never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
	All callers changed.

	* w32.c (_wsa_errlist): Use braces for struct initializers.

	* xdisp.c (string_buffer_position_lim): Remove parameter `w',
	never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
	All callers changed.
	(string_buffer_position): Likewise.  Also, make static (it's never
	used outside xdisp.c).
	(cursor_row_p): Remove parameter `w', unused since
	2000-10-17T16:08:57Z!gerd@gnu.org.  All callers changed.
	(decode_mode_spec): Remove parameter `precision', introduced during
	Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
	All callers changed.

958 959 960 961
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.

962
2011-03-27  Anders Lindgren  <andlind@gmail.com>
963 964 965 966 967 968 969 970 971 972

	* nsterm.m (ns_menu_bar_is_hidden): New variable.
	(ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
	(ns_update_auto_hide_menu_bar): New functions.
	(ns_update_begin): Call ns_update_auto_hide_menu_bar.
	(applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
	ns_constrain_all_frames.
	(constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
	(syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.

973 974 975 976
2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

	* nsmenu.m (runDialogAt): Remove argument to timer_check.

977 978 979 980 981 982 983 984 985
2011-03-27  Glenn Morris  <rgm@gnu.org>

	* syssignal.h: Replace RETSIGTYPE with void.
	* atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
	* keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
	Replace SIGTYPE with void everywhere.
	* s/usg5-4-common.h (SIGTYPE): Remove definition.
	* s/template.h (SIGTYPE): Remove commented out definition.

986 987 988 989 990
2011-03-26  Eli Zaretskii  <eliz@gnu.org>

	* xdisp.c (redisplay_window): Don't check buffer's clip_changed
	flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

991 992
2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

993 994 995 996 997 998 999
	* w32.c (read_unc_volume): Use parameter `henum', instead of
	global variable `wget_enum_handle'.

	* keymap.c (describe_vector): Remove parameters `indices' and
	`char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
	(describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
	* keyboard.h (timer_check, show_help_echo): Remove unused parameters.

	* keyboard.c (timer_check): Remove parameter `do_it_now',
	unused since 1996-04-12T06:01:29Z!rms@gnu.org.
	(show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
	unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

	* keyboard.c (read_char):
	* w32menu.c (w32_menu_display_help):
	* xmenu.c (show_help_event, menu_help_callback):
	Adjust calls to `show_help_echo'.

	* gtkutil.c (xg_maybe_add_timer):
	* keyboard.c (readable_events):
	* process.c (wait_reading_process_output):
	* xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

	* insdel.c (adjust_markers_gap_motion):
	Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
	(gap_left, gap_right): Don't call it.

1021 1022 1023 1024 1025
2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

	* xdisp.c (handle_fontified_prop): Discard changes to clip_changed
	incurred during fontification.

1026 1027 1028 1029 1030 1031 1032 1033
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
	(DEFVAR_PER_BUFFER): Don't pass it.

	* dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
	(scrolling_window): Don't pass it.

1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064
2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

	* dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

	* fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
	and `suffix'.
	(Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
	of variables specific to SELinux and computation of `encoded_absname'.

	* image.c (XPutPixel): Remove unused variable `height'.

	* keyboard.c (make_lispy_event): Remove unused variable `hpos'.

	* unexw32.c (get_section_info): Remove unused variable `section'.

	* w32.c (stat): Remove unused variables `drive_root' and `devtype'.
	(system_process_attributes): Remove unused variable `sess'.
	(sys_read): Remove unused variable `err'.

	* w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
	(w32_wnd_proc): Remove unused variable `isdead'.
	(unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
	(Fx_server_max_request_size): Remove unused variable `dpyinfo'.
	(x_create_tip_frame): Remove unused variable `tem'.

	* w32inevt.c (w32_console_read_socket):
	Remove unused variable `no_events'.

	* w32term.c (x_draw_composite_glyph_string_foreground):
	Remove unused variable `width'.

1065 1066 1067 1068 1069
2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

	* w32term.c (x_set_glyph_string_clipping):
	Don't pass uninitialized region to CombineRgn.

1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

	* w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
	(w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
	(Fx_close_connection): Remove unused variable `i'.

	* w32font.c (w32font_draw): Return number of glyphs.
	(w32font_open_internal): Remove unused variable `i'.
	(w32font_driver): Add missing initializer.

	* w32menu.c (utf8to16): Remove unused variable `utf16'.
	(fill_in_menu): Remove unused variable `items_added'.

	* w32term.c (last_mouse_press_frame): Remove static global variable.
	(w32_clip_to_row): Remove unused variable `f'.
	(x_delete_terminal): Remove unused variable `i'.

	* w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
	(NOTHING): Remove unused static global variable.
	(uniscribe_check_otf): Remove unused variable `table'.
	(uniscribe_font_driver): Add missing initializers.

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106
2011-03-23  Julien Danjou  <julien@danjou.info>

	* term.c (Fsuspend_tty, Fresume_tty):
	* minibuf.c (read_minibuf, run_exit_minibuf_hook):
	* window.c (temp_output_buffer_show):
	* insdel.c (signal_before_change):
	* frame.c (Fhandle_switch_frame):
	* fileio.c (Fdo_auto_save):
	* emacs.c (Fkill_emacs):
	* editfns.c (save_excursion_restore):
	* cmds.c (internal_self_insert):
	* callint.c (Fcall_interactively):
	* buffer.c (Fkill_all_local_variables):
	* keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
	Use Frun_hooks.
1107
	(command_loop_1): Use Frun_hooks.  Call safe_run_hooks
1108 1109
	unconditionnaly since it does the check itself.

Paul Eggert's avatar
Paul Eggert committed
1110
2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
1111

1112 1113
	Fix more problems found by GCC 4.5.2's static checks.

1114 1115 1116 1117
	* coding.c (encode_coding_raw_text): Avoid unnecessary test
	the first time through the loop, since we know p0 < p1 then.
	This also avoids a gcc -Wstrict-overflow warning.

1118 1119 1120
	* lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
	leading to a memory leak, possible in functions like
	load_charset_map_from_file that can allocate an unbounded number
Paul Eggert's avatar
Paul Eggert committed
1121
	of objects (Bug#8318).
1122

1123 1124 1125
	* xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
	that could (at least in theory) be that large.

1126 1127 1128 1129
	* xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
	This is less likely to overflow, and avoids undefined behavior if
	overflow does occur.  All callers changed.  Use strtoul to scan
	for the unsigned long integer.
1130 1131
	(pint2hrstr): Simplify and tune code slightly.
	This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1132

1133 1134 1135
	* scroll.c (do_scrolling): Work around GCC bug 48228.
	See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

1136 1137
	* frame.c (Fmodify_frame_parameters): Simplify loop counter.
	This also avoids a warning with gcc -Wstrict-overflow.
1138 1139
	(validate_x_resource_name): Simplify count usage.
	This also avoids a warning with gcc -Wstrict-overflow.
1140

Paul Eggert's avatar
Paul Eggert committed
1141 1142
	* fileio.c (Fcopy_file): Report error if fchown or fchmod
	fail (Bug#8306).
1143

Paul Eggert's avatar
Paul Eggert committed
1144
	* emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1145

1146 1147 1148
	* process.c (Fmake_network_process): Use socklen_t, not int,
	where POSIX says socklen_t is required in portable programs.
	This fixes a porting bug on hosts like 64-bit HP-UX, where
Paul Eggert's avatar
Paul Eggert committed
1149
	socklen_t is wider than int (Bug#8277).
1150 1151 1152 1153
	(Fmake_network_process, server_accept_connection):
	(wait_reading_process_output, read_process_output):
	Likewise.

1154 1155 1156 1157
	* process.c: Rename or move locals to avoid shadowing.
	(list_processes_1, Fmake_network_process):
	(read_process_output_error_handler, exec_sentinel_error_handler):
	Rename or move locals.
1158
	(Fmake_network_process): Define label "retry_connect" only if needed.
1159
	(Fnetwork_interface_info): Fix pointer signedness.
1160
	(process_send_signal): Add cast to avoid pointer signedness problem.
1161
	(FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
Paul Eggert's avatar
Paul Eggert committed
1162
	(create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1163

1164
	Make tparam.h and terminfo.c consistent.
1165 1166
	* cm.c (tputs, tgoto, BC, UP): Remove extern decls.
	Include tparam.h instead, since it declares them.
1167 1168 1169 1170 1171 1172 1173 1174 1175
	* cm.h (PC): Remove extern decl; tparam.h now does this.
	* deps.mk (cm.o, terminfo.o): Depend on tparam.h.
	* terminfo.c: Include tparam.h, to check interfaces.
	(tparm): Make 1st arg a const pointer in decl.  Put it at top level.
	(tparam): Adjust signature to match interface in tparam.h;
	this removes some undefined behavior.  Check that outstring and len
	are zero, which they always are with Emacs.
	* tparam.h (PC, BC, UP): New extern decls.

1176
	* xftfont.c (xftfont_shape): Now static, and defined only if needed.
1177
	(xftfont_open): Rename locals to avoid shadowing.
1178

1179
	* ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1180 1181
	(ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
	(OTF_TAG_SYM): Omit macro if not needed.
1182
	(ftfont_list): Remove unused local.
1183 1184 1185
	(get_adstyle_property, ftfont_pattern_entity):
	(ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
	Rename locals to avoid shadowing.
1186

1187 1188
	* xfont.c (xfont_list_family): Mark var as initialized.

Paul Eggert's avatar
Paul Eggert committed
1189 1190
	* xml.c (make_dom): Now static.

1191 1192
	* composite.c (composition_compute_stop_pos): Rename local to
	avoid shadowing.
1193 1194
	(composition_reseat_it): Remove unused locals.
	(find_automatic_composition, composition_adjust_point): Likewise.
1195
	(composition_update_it): Mark var as initialized.
Paul Eggert's avatar
Paul Eggert committed
1196 1197
	(find_automatic_composition): Mark vars as initialized,
	with a FIXME (Bug#8290).
1198

1199 1200 1201 1202 1203 1204 1205
	character.h: Rename locals to avoid shadowing.
	* character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
	(FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
	(FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
	(BUF_DEC_POS): Be more systematic about renaming local temporaries
	to avoid shadowing.

1206 1207
	* textprop.c (property_change_between_p): Remove; unused.

1208 1209
	* intervals.c (interval_start_pos): Now static.

1210 1211
	* intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

1212 1213
	* atimer.c (start_atimer, append_atimer_lists, set_alarm):
	Rename locals to avoid shadowing.
1214

1215 1216
	* sound.c (wav_play, au_play, Fplay_sound_internal):
	Fix pointer signedness.
1217
	(alsa_choose_format): Remove unused local var.
Paul Eggert's avatar
Paul Eggert committed
1218 1219
	(wav_play): Initialize a variable to 0, to prevent undefined
	behavior (Bug#8278).
1220

1221 1222
	* region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

1223 1224
	* region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

Paul Eggert's avatar
Paul Eggert committed
1225 1226
	* callproc.c (Fcall_process): Use 'volatile' to avoid vfork
	clobbering (Bug#8298).
1227 1228
	* sysdep.c (sys_subshell): Likewise.
	Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1229

1230 1231 1232 1233
	* lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
	This should get cleaned up, so that child_setup has the
	same signature on all platforms.

1234
	* callproc.c (call_process_cleanup): Now static.
1235
	(relocate_fd): Rename locals to avoid shadowing.
1236

1237 1238 1239 1240 1241
2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

	* xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
	not to be necessary, and produces flickering.

1242 1243 1244 1245
2011-03-20  Glenn Morris  <rgm@gnu.org>

	* config.in: Remove file.

1246 1247 1248 1249 1250 1251
2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

	* minibuf.c (Vcompleting_read_function): Don't declare, global variables
	are now in src/globals.h.
	(syms_of_minibuf): Remove spurious & from previous change.

1252 1253 1254 1255 1256 1257
2011-03-20  Leo  <sdl.web@gmail.com>

	* minibuf.c (completing-read-function): New variable.
	(completing-read-default): Rename from completing-read.
	(completing-read): Call completing-read-function.

1258 1259 1260 1261 1262
2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

	* xfaces.c (Fx_load_color_file):
	Read color file from absolute filename (bug#8250).