• Eric Abrahamsen's avatar
    Change Gnus hash tables into real hash tables · c1b63af4
    Eric Abrahamsen authored
    Gnus has used obarrays as makeshift hash tables for groups: group
    names are coerced to unibyte and interned in custom obarrays, and
    their symbol-value set to whatever value needs to be stored. This
    patch replaces those obarrays with actual hash tables.
    
    * lisp/gnus/gnus-util.el (gnus-intern-safe, gnus-create-hash-size):
      Remove functions.
      (gnus-make-hashtable): Change to return a real hash table.
      (gnus-text-property-search): Utility similar to `text-property-any',
      but compares on `equal'. Needed because the 'gnus-group text
      property is now a string.
    * lisp/gnus/gnus.el (gnus-gethash, gnus-gethash-safe, gnus-sethash):
      Remove macros.
      (gnus-group-list): New variable holding all group names as an
      ordered list. Used because `gnus-newsrc-hashtb' used to preserve
      `gnus-newsrc-alist' ordering, but now doesn't.
    * lisp/gnus/nnmaildir.el (nnmaildir--servers): Change from obarray to
      alist.
      (nnmaildir--up2-1): Remove function.
    * lisp/thingatpt.el (thing-at-point-newsgroup-p): This was making use
      of Gnus obarrays, replace with a cond that can handle many different
      possibilities.
    * lisp/gnus/gnus-bcklg.el (gnus-backlog-articles): Remove
      gnus-backlog-hashtb, which wasn't doing anything. Just keep a list
      of ident strings in gnus-backlog-articles.
      (gnus-backlog-setup): Delete unnecessary function.
      (gnus-backlog-enter-article, gnus-backlog-remove-oldest-article,
      gnus-backlog-remove-article, gnus-backlog-request-article): Alter
      calls accordingly.
    * lisp/gnus/gnus-dup.el (gnus-duplicate-list-max-length): Rename from
      `gnus-duplicate-list-length', for accuracy.
    * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format,
      gnus-groups-to-gnus-format, gnus-newsrc-to-gnus-format): Read group
      names as strings.
      (gnus-gnus-to-quick-newsrc-format): Write `gnus-newsrc-alist' using
      the ordering in `gnus-group-list'.
    * lisp/gnus/gnus-agent.el:
    * lisp/gnus/gnus-async.el:
    * lisp/gnus/gnus-cache.el:
    * lisp/gnus/gnus-group.el:
    * lisp/gnus/gnus-score.el:
    * lisp/gnus/gnus-sum.el:
    * lisp/gnus/gnus-topic.el:
    * lisp/gnus/message.el:
    * lisp/gnus/mml.el:
    * lisp/gnus/nnagent.el:
    * lisp/gnus/nnbabyl.el:
    * lisp/gnus/nnvirtual.el:
    * lisp/gnus/nnweb.el: In all files, change obarrays to hash-tables,
      and swap `gnus-sethash' for `puthash', `gnus-gethash' for `gethash',
      `mapatoms' for `maphash', etc.
    * test/lisp/gnus/gnus-test-headers.el (gnus-headers-make-dependency-table,
      gnus-headers-loop-dependencies): New tests to make sure we're
      building `gnus-newsgroup-dependencies' correctly.
    c1b63af4
gnus-dup.el 5.18 KB