Commit 03887a19 authored by Stefan Monnier's avatar Stefan Monnier
Browse files

* lisp/textmodes/ispell.el: Compile with lexical-binding

(declare-function): Don't define any more.
(ispell-check-minver, ispell-looking-back): Tweak definition so that
the compiler can obviously know that it's always defined.
(ispell-debug-buffer): Declare var.
(ispell-parse-hunspell-affix-file, ispell-hunspell-add-multi-dic)
(ispell-find-hunspell-dictionaries, ispell-set-spellchecker-params)
(ispell-command-loop): Avoid add-to-list on local variables.
parent 531c9a43
;;; ispell.el --- interface to International Ispell Versions 3.1 and 3.2
;;; ispell.el --- interface to International Ispell Versions 3.1 and 3.2 -*- lexical-binding:t -*-
;; Copyright (C) 1994-1995, 1997-2016 Free Software Foundation, Inc.
......@@ -46,9 +46,9 @@
;; your own dictionaries.
;; Depending on the mail system you use, you may want to include these:
;; (add-hook 'news-inews-hook 'ispell-message)
;; (add-hook 'mail-send-hook 'ispell-message)
;; (add-hook 'mh-before-send-letter-hook 'ispell-message)
;; (add-hook 'news-inews-hook #'ispell-message)
;; (add-hook 'mail-send-hook #'ispell-message)
;; (add-hook 'mh-before-send-letter-hook #'ispell-message)
;; Ispell has a TeX parser and a nroff parser (the default).
;; The parsing is controlled by the variable ispell-parser. Currently
......@@ -196,17 +196,9 @@
;; Fixed bug in returning to nroff mode from tex mode.
;;; Compatibility code for XEmacs and (not too) older emacsen:
(eval-and-compile ;; Protect against declare-function undefined in XEmacs
(unless (fboundp 'declare-function) (defmacro declare-function (&rest r))))
(declare-function ispell-check-minver "ispell" (v1 v2))
(declare-function ispell-looking-back "ispell"
(regexp &optional limit &rest ignored))
(if (fboundp 'version<=)
(defalias 'ispell-check-minver 'version<=)
(defun ispell-check-minver (minver version)
(defalias 'ispell-check-minver
(if (fboundp 'version<=) 'version<=
(lambda (minver version)
"Check if string VERSION is at least string MINVER.
Both must be in [0-9]+.[0-9]+... format. This is a fallback
compatibility function in case `version<=' is not available."
......@@ -237,12 +229,12 @@ compatibility function in case `version<=' is not available."
(setq pending nil
return nil))))
(setq pending nil))))
;; XEmacs does not have looking-back
(if (fboundp 'looking-back)
(defalias 'ispell-looking-back 'looking-back)
(defun ispell-looking-back (regexp &optional limit &rest ignored)
(defalias 'ispell-looking-back
(if (fboundp 'looking-back) 'looking-back
(lambda (regexp &optional limit &rest ignored)
"Return non-nil if text before point matches regular expression REGEXP.
Like `looking-at' except matches before point, and is slower.
LIMIT if non-nil speeds up the search by specifying a minimum
......@@ -252,7 +244,7 @@ before LIMIT.
This is a stripped down compatibility function for use when
full featured `looking-back' function is missing."
(re-search-backward (concat "\\(?:" regexp "\\)\\=") limit t))))
(re-search-backward (concat "\\(?:" regexp "\\)\\=") limit t)))))
;;; XEmacs21 does not have `with-no-warnings'. Taken from org mode.
(defmacro ispell-with-no-warnings (&rest body)
......@@ -260,6 +252,8 @@ full featured `looking-back' function is missing."
;;; Code:
(eval-when-compile (require 'cl-lib))
(defvar mail-yank-prefix)
(defgroup ispell nil
......@@ -942,6 +936,8 @@ Otherwise returns the library directory name, if that is defined."
(setq default-directory (expand-file-name "~/")))
(apply 'call-process-region args)))
(defvar ispell-debug-buffer)
(defun ispell-create-debug-buffer (&optional append)
"Create an ispell debug buffer for debugging output.
If APPEND is non-nil, append the info to previous buffer if exists,
......@@ -1182,15 +1178,15 @@ all uninitialized dicts using that affix file."
(if (cadr (assoc tmp-dict ispell-dictionary-alist))
"ispell-hfde: %s already expanded; skipping.\n" tmp-dict)
(add-to-list 'use-for-dicts tmp-dict))))))
(cl-pushnew tmp-dict use-for-dicts :test #'equal))))))
"ispell-hfde: Filling %s entry. Use for %s.\n" dict use-for-dicts)
;; The final loop.
(dolist (entry ispell-dictionary-alist)
(if (member (car entry) use-for-dicts)
(add-to-list 'newlist
(append (list (car entry)) dict-args-cdr))
(add-to-list 'newlist entry)))
(cl-pushnew (if (member (car entry) use-for-dicts)
(cons (car entry) dict-args-cdr)
newlist :test #'equal))
(setq ispell-dictionary-alist newlist))))
(defun ispell-parse-hunspell-affix-file (dict-key)
......@@ -1235,7 +1231,7 @@ did."
(chars-list (append otherchars-string nil)))
(setq chars-list (delq ?\ chars-list))
(dolist (ch chars-list)
(add-to-list 'otherchars-list ch)))))
(cl-pushnew ch otherchars-list :test #'equal)))))
;; Cons the argument for the -d switch.
(setq dict-arg (concat dict-arg
(if (> (length dict-arg) 0) ",")
......@@ -1246,7 +1242,7 @@ did."
(if otherchars-list
(regexp-opt (mapcar 'char-to-string otherchars-list))
(regexp-opt (mapcar #'char-to-string otherchars-list))
t ; many-otherchars-p: We can't tell, set to t.
(list "-d" dict-arg)
......@@ -1268,7 +1264,7 @@ in the list must have an affix file where Hunspell affix files are kept."
(or (assoc first-dict ispell-local-dictionary-alist)
(assoc first-dict ispell-dictionary-alist)
(error "Unknown dictionary: %s" first-dict)))
(add-to-list 'ispell-dictionary-alist (list dict '()))
(cl-pushnew (list dict '()) ispell-dictionary-alist :test #'equal)
(ispell-hunspell-fill-dictionary-entry dict))
(defun ispell-find-hunspell-dictionaries ()
......@@ -1308,8 +1304,8 @@ entries if a specific dictionary was found."
"++ ispell-fhd: dict-entry:%s name:%s basename:%s affix-file:%s\n"
dict full-name basename affix-file)
(add-to-list 'ispell-hunspell-dict-paths-alist
(list basename affix-file)))
(cl-pushnew (list basename affix-file)
ispell-hunspell-dict-paths-alist :test #'equal))
"-- ispell-fhd: Skipping entry: %s\n" dict)))))
;; Remove entry from aliases alist if explicit dict was found.
......@@ -1319,7 +1315,7 @@ entries if a specific dictionary was found."
"-- ispell-fhd: Excluding %s alias. Standalone dict found.\n"
(car dict))
(add-to-list 'newlist dict)))
(cl-pushnew dict newlist :test #'equal)))
(setq ispell-dicts-name2locale-equivs-alist newlist))
;; Add known hunspell aliases
(dolist (dict-equiv ispell-dicts-name2locale-equivs-alist)
......@@ -1337,22 +1333,20 @@ entries if a specific dictionary was found."
(ispell-print-if-debug "++ ispell-fhd: Adding alias %s -> %s.\n"
dict-equiv-key affix-file)
(list dict-equiv-key affix-file))))))
(cl-pushnew (list dict-equiv-key affix-file)
ispell-hunspell-dict-paths-alist :test #'equal)))))
;; Parse and set values for default dictionary.
(setq hunspell-default-dict (car hunspell-default-dict))
(setq hunspell-default-dict-entry
(ispell-parse-hunspell-affix-file hunspell-default-dict))
;; Create an alist of found dicts with only names, except for default dict.
(setq ispell-hunspell-dictionary-alist
(list (append (list nil) (cdr hunspell-default-dict-entry))))
(dolist (dict (mapcar 'car ispell-hunspell-dict-paths-alist))
(if (string= dict hunspell-default-dict)
(add-to-list 'ispell-hunspell-dictionary-alist
(add-to-list 'ispell-hunspell-dictionary-alist
(list dict))))))
(list (cons nil (cdr hunspell-default-dict-entry))))
(dolist (dict (mapcar #'car ispell-hunspell-dict-paths-alist))
(cl-pushnew (if (string= dict hunspell-default-dict)
(list dict))
ispell-hunspell-dictionary-alist :test #'equal))))
;; Set params according to the selected spellchecker
......@@ -1443,8 +1437,7 @@ aspell is used along with Emacs).")
(setq skip-dict t)))
(unless skip-dict
(add-to-list 'tmp-dicts-alist
(cl-pushnew (list
dict-name ; dict name
(nth 1 adict) ; casechars
(nth 2 adict) ; not-casechars
......@@ -1453,7 +1446,8 @@ aspell is used along with Emacs).")
ispell-args ; ispell-args
(nth 6 adict) ; extended-character-mode
(nth 7 adict) ; dict encoding
tmp-dicts-alist :test #'equal)))
(setq ispell-dictionary-base-alist tmp-dicts-alist))))
(run-hooks 'ispell-initialize-spellchecker-hook)
......@@ -1463,7 +1457,7 @@ aspell is used along with Emacs).")
(unless (assoc (car dict) all-dicts-alist)
(add-to-list 'all-dicts-alist dict)))
(push dict all-dicts-alist)))
(setq ispell-dictionary-alist all-dicts-alist))
;; If Emacs flavor supports [:alpha:] use it for global dicts. If
......@@ -1473,8 +1467,7 @@ aspell is used along with Emacs).")
(if ispell-emacs-alpha-regexp
(let (tmp-dicts-alist)
(dolist (adict ispell-dictionary-alist)
(if (cadr adict) ;; Do not touch hunspell uninitialized entries
(add-to-list 'tmp-dicts-alist
(cl-pushnew (if (cadr adict) ;; Do not touch hunspell uninitialized entries
(nth 0 adict) ; dict name
"[[:alpha:]]" ; casechars
......@@ -1485,8 +1478,9 @@ aspell is used along with Emacs).")
(nth 6 adict) ; extended-character-mode
(if ispell-encoding8-command
(nth 7 adict))))
(add-to-list 'tmp-dicts-alist adict)))
(nth 7 adict)))
tmp-dicts-alist :test #'equal))
(setq ispell-dictionary-alist tmp-dicts-alist)))))
(defun ispell-valid-dictionary-list ()
......@@ -2428,7 +2422,8 @@ Global `ispell-quit' set to start location to continue spell session."
((or (= char ?a) (= char ?A)) ; accept word without insert
(ispell-send-string (concat "@" word "\n"))
(add-to-list 'ispell-buffer-session-localwords word)
(cl-pushnew word ispell-buffer-session-localwords
:test #'equal)
(and (fboundp 'flyspell-unhighlight-at)
(flyspell-unhighlight-at start))
(or ispell-buffer-local-name ; session localwords might conflict
......@@ -2761,7 +2756,7 @@ if defined."
;; This is the case when a process dies or fails. The default behavior
;; in this case treats the next input received as fresh input.
(defun ispell-filter (process output)
(defun ispell-filter (_process output)
"Output filter function for ispell, grep, and look."
(let ((start 0)
(continue t)
......@@ -3041,14 +3036,13 @@ Keeps argument list for future Ispell invocations for no async support."
(ispell-send-string "\032\n") ; so Ispell prints version and exits
(defun ispell-init-process ()
"Check status of Ispell process and start if necessary."
(let* (;; Basename of dictionary used by the spell-checker
(dict-bname (or (car (cdr (member "-d" (ispell-get-ispell-args))))
;; The directory where process was started.
(current-ispell-directory default-directory)
(current-ispell-directory default-directory) ;FIXME: Unused?
;; The default directory for the process.
;; Use "~/" as default-directory unless using Ispell with per-dir
;; personal dictionaries and not in a minibuffer under XEmacs
......@@ -3151,7 +3145,7 @@ Keeps argument list for future Ispell invocations for no async support."
;; Otherwise we get cool errors like "Can't open ".
(sleep-for 1)
(ispell-accept-output 3)
(error "%s" (mapconcat 'identity ispell-filter "\n"))))
(error "%s" (mapconcat #'identity ispell-filter "\n"))))
(setq ispell-filter nil) ; Discard version ID line
(let ((extended-char-mode (ispell-get-extended-character-mode)))
(if extended-char-mode ; ~ extended character mode
......@@ -3207,7 +3201,7 @@ By just answering RET you can find out what the current dictionary is."
(list (completing-read
"Use new dictionary (RET for current, SPC to complete): "
(and (fboundp 'ispell-valid-dictionary-list)
(mapcar 'list (ispell-valid-dictionary-list)))
(mapcar #'list (ispell-valid-dictionary-list)))
nil t)
(ispell-set-spellchecker-params) ; Initialize variables and dicts alists
......@@ -3413,7 +3407,7 @@ ispell-region: Search for first region to skip after (ispell-begin-skip-region-r
Includes `ispell-skip-region-alist' plus tex, tib, html, and comment keys.
Must be called after `ispell-buffer-local-parsing' due to dependence on mode."
(delq nil
;; messages
......@@ -3870,7 +3864,7 @@ Standard ispell choices are then available."
(setq case-fold-search nil) ; Try and respect case of word.
((string-equal (upcase word) word)
(setq possibilities (mapcar 'upcase possibilities)))
(setq possibilities (mapcar #'upcase possibilities)))
((eq (upcase (aref word 0)) (aref word 0))
(setq possibilities (mapcar (function
(lambda (pos)
......@@ -4104,10 +4098,10 @@ The `X' command aborts sending the message so that you can edit the buffer.
To spell-check whenever a message is sent, include the appropriate lines
in your init file:
(add-hook \\='message-send-hook \\='ispell-message) ;; GNUS 5
(add-hook \\='news-inews-hook \\='ispell-message) ;; GNUS 4
(add-hook \\='mail-send-hook \\='ispell-message)
(add-hook \\='mh-before-send-letter-hook \\='ispell-message)
(add-hook \\='message-send-hook #\\='ispell-message) ;; GNUS 5
(add-hook \\='news-inews-hook #\\='ispell-message) ;; GNUS 4
(add-hook \\='mail-send-hook #\\='ispell-message)
(add-hook \\='mh-before-send-letter-hook #\\='ispell-message)
You can bind this to the key C-c i in GNUS or mail by adding to
`news-reply-mode-hook' or `mail-mode-hook' the following lambda expression:
......@@ -4429,6 +4423,7 @@ Both should not be used to define a buffer-local dictionary."
(insert comment-end)))))
(insert (concat " " word))))))))
;;FIXME: Use `user-error' instead!
(add-to-list 'debug-ignored-errors "^No word found to check!$")
(provide 'ispell)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment