Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
emacs
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
4
Issues
4
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
emacs
emacs
Commits
0fb3cb7c
Commit
0fb3cb7c
authored
Sep 14, 2012
by
Stefan Monnier
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
* lisp/emacs-lisp/advice.el (ad-prognify): Remove, use macroexp-progn.
parent
33bd7ff0
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
10 deletions
+8
-10
lisp/ChangeLog
lisp/ChangeLog
+2
-0
lisp/emacs-lisp/advice.el
lisp/emacs-lisp/advice.el
+6
-10
No files found.
lisp/ChangeLog
View file @
0fb3cb7c
2012-09-14 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/advice.el (ad-prognify): Remove, use macroexp-progn.
* emacs-lisp/edebug.el: Miscellaneous cleanup.
Remove obsolete byte-compiler hack that tried to silence some warnings.
(edebug-submit-bug-report): Remove.
...
...
lisp/emacs-lisp/advice.el
View file @
0fb3cb7c
...
...
@@ -1746,6 +1746,7 @@
(
provide
'advice-preload
)
;; During a normal load this is a noop:
(
require
'advice-preload
"advice.el"
)
(
require
'macroexp
)
(
eval-when-compile
(
require
'cl-lib
))
;; @@ Variable definitions:
...
...
@@ -2538,11 +2539,6 @@ For that it has to be fbound with a non-autoload definition."
(
byte-compile
symbol
)
(
fset
function
(
symbol-function
symbol
))))))
(
defun
ad-prognify
(
forms
)
(
cond
((
<=
(
length
forms
)
1
)
(
car
forms
))
(
t
(
cons
'progn
forms
))))
;; @@@ Accessing argument lists:
;; =============================
...
...
@@ -2954,7 +2950,7 @@ should be modified. The assembled function will be returned."
before-forms
)
(
setq
before-forms
`
((
unwind-protect
,
(
ad-prognify
before-forms
)
,
(
macroexp-progn
before-forms
)
,@
(
ad-body-forms
(
ad-advice-definition
advice
))))))
(
t
(
setq
before-forms
...
...
@@ -2971,12 +2967,12 @@ should be modified. The assembled function will be returned."
(
ad-substitute-tree
(
function
(
lambda
(
form
)
(
eq
form
'ad-do-it
)))
(
function
(
lambda
(
form
)
around-form
))
(
ad-prognify
(
ad-body-forms
(
ad-advice-definition
advice
))))))
(
macroexp-progn
(
ad-body-forms
(
ad-advice-definition
advice
))))))
(
setq
after-forms
(
if
(
and
around-form-protected
before-forms
)
`
((
unwind-protect
,
(
ad-prognify
before-forms
)
,
(
macroexp-progn
before-forms
)
,
around-form
))
(
append
before-forms
(
list
around-form
))))
(
dolist
(
advice
afters
)
...
...
@@ -2984,7 +2980,7 @@ should be modified. The assembled function will be returned."
after-forms
)
(
setq
after-forms
`
((
unwind-protect
,
(
ad-prognify
after-forms
)
,
(
macroexp-progn
after-forms
)
,@
(
ad-body-forms
(
ad-advice-definition
advice
))))))
(
t
(
setq
after-forms
...
...
@@ -3013,7 +3009,7 @@ should be modified. The assembled function will be returned."
(
ad-body-forms
(
ad-advice-definition
advice
))))
(
ad-get-enabled-advices
function
hook-name
))))
(
if
hook-forms
(
ad-prognify
(
apply
'append
hook-forms
)))))
(
macroexp-progn
(
apply
'append
hook-forms
)))))
;; @@ Caching:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment