* subr.el (add-to-history): Fix delete usage.

Fixes: debbugs:12314

* subr.el (add-to-history): Fix delete usage.
Fixes: debbugs:12314
1715f2db · Drew Adams · Chong Yidong · 6dcef6ec · 1715f2db · 1715f2db
Commit 1715f2db authored Sep 08, 2012 by Drew Adams Committed by Chong Yidong Sep 08, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

lisp/ChangeLog lisp/ChangeLog +4 -0

lisp/subr.el lisp/subr.el +1 -1

No files found.
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
+2012-09-08  Drew Adams  <drew.adams@oracle.com>
+
+	* subr.el (add-to-history): Fix delete usage (Bug#12314).
+
 2012-09-08  Chong Yidong  <cyd@gnu.org>
  
 	* subr.el (syntax-after, syntax-class): Doc fix.

--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1548,7 +1548,7 @@ if it is empty or a duplicate."
 	       (or keep-all
 		   (not (equal (car history) newelt))))
      (if history-delete-duplicates
-	  (delete newelt history))
+	  (setq history (delete newelt history)))
      (setq history (cons newelt history))
      (when (integerp maxelt)
 	(if (= 0 maxelt)