Commit 1b7259fc authored by Eli Zaretskii's avatar Eli Zaretskii
Browse files

Fix bug #16299 with assertion violation in set-default-file-modes on Windows.

 src/w32.c (sys_umask): New function.

 nt/inc/ms-w32.h (umask) [emacs]: Redirect to sys_umask.
parent 63442595
2013-12-30 Eli Zaretskii <>
* inc/ms-w32.h (umask) [emacs]: Redirect to sys_umask. (Bug#16299)
2013-12-23 Eli Zaretskii <>
......@@ -235,6 +235,9 @@ extern struct tm * sys_localtime (const time_t *);
extern int sys_unlink (const char *);
#undef write
#define write sys_write
#undef umask
#define umask sys_umask
extern int sys_umask (int);
/* Subprocess calls that are emulated. */
#define spawnve sys_spawnve
......@@ -276,7 +279,6 @@ typedef int pid_t;
#define lseek _lseek
#define popen _popen
#define pclose _pclose
#define umask _umask
#define strdup _strdup
#define strupr _strupr
#define strnicmp _strnicmp
2013-12-30 Eli Zaretskii <>
* w32.c (sys_umask): New function. (Bug#16299)
2013-12-30 Martin Rudalics <>
* dispnew.c (change_frame_size_1): Take old width of root window
......@@ -5265,6 +5265,35 @@ utime (const char *name, struct utimbuf *times)
return 0;
/* Emacs expects us to support the traditional octal form of the mode
bits, which is not what msvcrt.dll wants. */
#define WRITE_USER 00200
sys_umask (int mode)
static int current_mask;
int retval, arg = 0;
/* The only bit we really support is the write bit. Files are
always readable on MS-Windows, and the execute bit does not exist
at all. */
/* FIXME: if the GROUP and OTHER bits are reset, we should use ACLs
to prevent access by other users on NTFS. */
if ((mode & WRITE_USER) != 0)
arg |= S_IWRITE;
retval = _umask (arg);
/* Merge into the return value the bits they've set the last time,
which msvcrt.dll ignores and never returns. Emacs insists on its
notion of mask being identical to what we return. */
retval |= (current_mask & ~WRITE_USER);
current_mask = mode;
return retval;
/* Symlink-related functions. */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment