Commit 1f1f4de2 authored by Nick Roberts's avatar Nick Roberts
Browse files


Throw error when count <= 0 to ensure input is a number.
(gdb-read-memory-custom): Pick up address from buffer.
(gdb-memory-mode): Allow user to increment and decrement
memory address from header line.
parent 8c6fb9d0
......@@ -1766,7 +1766,11 @@ static char *magick[] = {
(defun gdb-read-memory-custom ())
(defun gdb-read-memory-custom ()
(goto-char (point-min))
(if (looking-at "0x[[:xdigit:]]+")
(setq gdb-memory-address (match-string 0)))))
(defvar gdb-memory-mode-map
(let ((map (make-sparse-keymap)))
......@@ -1790,8 +1794,8 @@ static char *magick[] = {
(select-window (posn-window (event-start event)))
(let* ((arg (read-from-minibuffer "Repeat count: "))
(count (string-to-number arg)))
(if (< count 0)
(error "Non-negative numbers only")
(if (<= count 0)
(error "Positive numbers only")
(customize-set-variable 'gdb-memory-repeat-count count)
......@@ -1944,7 +1948,38 @@ corresponding to the mode line clicked."
(setq header-line-format
"Read address: "
"Read address["
'face font-lock-warning-face
'help-echo "mouse-1: Decrement address"
'mouse-face 'mode-line-highlight
#'(lambda () (interactive)
(let ((gdb-memory-address
;; let GDB do the arithmetic
gdb-memory-address " - "
(* gdb-memory-repeat-count
(cond ((string= gdb-memory-unit "b") 1)
((string= gdb-memory-unit "h") 2)
((string= gdb-memory-unit "w") 4)
((string= gdb-memory-unit "g") 8)))))))
(propertize "+"
'face font-lock-warning-face
'help-echo "mouse-1: Increment address"
'mouse-face 'mode-line-highlight
'local-map (gdb-make-header-line-mouse-map
#'(lambda () (interactive)
(let ((gdb-memory-address nil))
"]: "
(propertize gdb-memory-address
'face font-lock-warning-face
'help-echo "mouse-1: Set memory address"
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment