Commit 2abb4e65 authored by Stefan Monnier's avatar Stefan Monnier
Browse files

* lisp/electric.el (electric-indent-inhibit): New var.

(electric-indent-post-self-insert-function): Use it.
* lisp/progmodes/python.el (python-mode): Set it.
parent d2e0e795
2013-10-07 Stefan Monnier <>
* electric.el (electric-indent-inhibit): New var.
(electric-indent-post-self-insert-function): Use it.
* progmodes/python.el (python-mode): Set it.
* progmodes/ruby-mode.el (ruby-smie-rules): Tweak handling of
open braces.
......@@ -187,7 +187,7 @@ Returns nil when we can't find this char."
(eq (char-before) last-command-event)))))
;; Electric indentation.
;;; Electric indentation.
;; Autoloading variables is generally undesirable, but major modes
;; should usually set this variable by adding elements to the default
......@@ -202,6 +202,11 @@ Each function is called with one argument (the inserted char), with
point right after that char, and it should return t to cause indentation,
`no-indent' to prevent indentation or nil to let other functions decide.")
(defvar-local electric-indent-inhibit nil
"If non-nil, reindentation is not appropriate for this buffer.
This should be set by major modes such as `python-mode' since
Python does not lend itself to fully automatic indentation.")
(defun electric-indent-post-self-insert-function ()
;; FIXME: This reindents the current line, but what we really want instead is
;; to reindent the whole affected text. That's the current line for simple
......@@ -229,12 +234,13 @@ point right after that char, and it should return t to cause indentation,
(unless (eq act 'do-indent) (nth 8 (syntax-ppss))))))))
;; For newline, we want to reindent both lines and basically behave like
;; reindent-then-newline-and-indent (whose code we hence copied).
(when (< (1- pos) (line-beginning-position))
(when (<= pos (line-beginning-position))
(let ((before (copy-marker (1- pos) t)))
(unless (memq indent-line-function
'(indent-relative indent-to-left-margin
(unless (or (memq indent-line-function
'(indent-relative indent-to-left-margin
;; Don't reindent the previous line if the indentation function
;; is not a real one.
(goto-char before)
......@@ -248,7 +254,9 @@ point right after that char, and it should return t to cause indentation,
;; Remove the trailing whitespace after indentation because
;; indentation may (re)introduce the whitespace.
(delete-horizontal-space t))))
(unless (memq indent-line-function '(indent-to-left-margin))
(unless (or (memq indent-line-function '(indent-to-left-margin))
(and electric-indent-inhibit
(> pos (line-beginning-position))))
......@@ -281,7 +289,7 @@ insert a character from `electric-indent-chars'."
(delq #'electric-indent-post-self-insert-function
(cdr bp))))))))
;; Electric pairing.
;;; Electric pairing.
(defcustom electric-pair-pairs
'((?\" . ?\"))
......@@ -414,7 +422,7 @@ See options `electric-pair-pairs' and `electric-pair-skip-self'."
(remove-hook 'self-insert-uses-region-functions
;; Automatically add newlines after/before/around some chars.
;;; Electric newlines after/before/around some chars.
(defvar electric-layout-rules '()
"List of rules saying where to automatically insert newlines.
......@@ -3544,6 +3544,8 @@ list is returned as is."
(reverse acc))))
(defvar electric-indent-inhibit)
(define-derived-mode python-mode prog-mode "Python"
"Major mode for editing Python files.
......@@ -3572,7 +3574,9 @@ if that value is non-nil."
(set (make-local-variable 'indent-line-function)
(set (make-local-variable 'indent-region-function) #'python-indent-region)
;; Because indentation is not redundant, we cannot safely reindent code.
(setq-local electric-indent-inhibit t)
(set (make-local-variable 'paragraph-start) "\\s-*$")
(set (make-local-variable 'fill-paragraph-function)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment