Commit 2c541d84 authored by Juri Linkov's avatar Juri Linkov
Browse files

* lisp/frame.el (make-frame-on-monitor): Don't set height and width.

Don't use x-parse-geometry.  Delete nil from completions (Bug#34516)
parent 53914a10
Pipeline #1022 failed with stage
in 60 minutes and 1 second
......@@ -678,28 +678,20 @@ The optional argument DISPLAY can be a display name, and the optional
argument PARAMETERS specifies additional frame parameters."
(interactive (list (completing-read
(format "Make frame on monitor: ")
(mapcar (lambda (a)
(cdr (assq 'name a)))
(let* ((monitor-geometry
(car (delq nil (mapcar (lambda (a)
(when (equal (cdr (assq 'name a)) monitor)
(cdr (assq 'workarea a))))
(display-monitor-attributes-list display)))))
(when monitor-geometry
(x-parse-geometry (format "%dx%d+%d+%d"
(nth 2 monitor-geometry)
(nth 3 monitor-geometry)
(nth 0 monitor-geometry)
(nth 1 monitor-geometry)))))
(when frame-geometry
`((top . ,(cdr (assq 'top frame-geometry)))
(left . ,(cdr (assq 'left frame-geometry)))
(height . (text-pixels . ,(cdr (assq 'height frame-geometry))))
(width . (text-pixels . ,(cdr (assq 'width frame-geometry))))))))
(make-frame (append frame-geometry-in-pixels parameters))))
(or (delq nil (mapcar (lambda (a)
(cdr (assq 'name a)))
(let* ((monitor-workarea
(catch 'done
(dolist (a (display-monitor-attributes-list display))
(when (equal (cdr (assq 'name a)) monitor)
(throw 'done (cdr (assq 'workarea a)))))))
(when monitor-workarea
`((top . ,(nth 1 monitor-workarea))
(left . ,(nth 0 monitor-workarea))))))
(make-frame (append geometry-parameters parameters))))
(declare-function x-close-connection "xfns.c" (terminal))
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment