* xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment.

335e9627 · Jan Djärv · e2e773b9 · 335e9627 · 335e9627
Commit 335e9627 authored Oct 01, 2014 by Jan Djärv
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

src/ChangeLog src/ChangeLog +1 -0

src/xfaces.c src/xfaces.c +7 -0

No files found.
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -2,6 +2,7 @@

 	* xfaces.c (Finternal_set_lisp_face_attribute): Don't try to
 	make a font_object from a tty frame (Bug#18573).
+	(Finternal_set_lisp_face_attribute): Added FIXME comment.

 2014-09-30  Eli Zaretskii  <eliz@gnu.org>


--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -3119,6 +3119,13 @@ FRAME 0 means change the face on all frames, and change the default
 		f = XFRAME (selected_frame);
 	      else
 		f = XFRAME (frame);
+
+              /* FIXME:
+                 If frame is t, and selected frame is a tty frame, the font
+                 can't be realized.  An improvement wuld be to loop over frames
+                 for a non-tty frame and use that.  See discussion in
+                 bug#18573.
+              */
              if (f->terminal->type != output_termcap)
                {
                  if (! FONT_OBJECT_P (value))