Commit 5745cae6 authored by Dmitry Gutov's avatar Dmitry Gutov
Browse files

* lisp/progmodes/ruby-mode.el (ruby-add-log-current-method): Print the

period before class method names, not after.  Remove handling of
one impossible case.  Add comments.

* test/automated/ruby-mode-tests.el 
(ruby-add-log-current-method-examples): New test.
(ruby-test-string): Extract from ruby-should-indent-buffer.
parent 2a14f83b
2012-11-13 Dmitry Gutov <>
* progmodes/ruby-mode.el (ruby-add-log-current-method): Print the
period before class method names, not after. Remove handling of
one impossible case. Add comments.
2012-11-13 Stefan Monnier <>
* emacs-lisp/advice.el: Remove support for freezing.
......@@ -1033,21 +1033,19 @@ For example:
See `add-log-current-defun-function'."
;; TODO: Document body
;; Why does this append a period to class methods?
(condition-case nil
(let (mname mlist (indent 0))
;; get current method (or class/module)
;; Get the current method definition (or class/module).
(if (re-search-backward
(concat "^[ \t]*" ruby-defun-beg-re "[ \t]+"
;; \\. and :: for class method
"\\([A-Za-z_]" ruby-symbol-re "*\\|\\.\\|::" "\\)"
;; \\. and :: for class methods
"\\([A-Za-z_]" ruby-symbol-re "*\\|\\.\\|::" "\\)"
nil t)
(setq mname (match-string 2))
......@@ -1056,7 +1054,7 @@ See `add-log-current-defun-function'."
(goto-char (match-beginning 1))
(setq indent (current-column))
;; nest class/module
;; Walk up the class/module nesting.
(while (and (> indent 0)
......@@ -1069,28 +1067,26 @@ See `add-log-current-defun-function'."
(setq mlist (cons (match-string 2) mlist))
(setq indent (current-column))
;; Process the method name.
(when mname
(let ((mn (split-string mname "\\.\\|::")))
(if (cdr mn)
((string-equal "" (car mn))
(setq mn (cdr mn) mlist nil))
((string-equal "self" (car mn))
(setq mn (cdr mn)))
((let ((ml (nreverse mlist)))
(unless (string-equal "self" (car mn)) ; def
;; def
(let ((ml (nreverse mlist)))
;; If the method name references one of the
;; containing modules, drop the more nested ones.
(while ml
(if (string-equal (car ml) (car mn))
(setq mlist (nreverse (cdr ml)) ml nil))
(or (setq ml (cdr ml)) (nreverse mlist))))))
(if mlist
(setcdr (last mlist) mn)
(setq mlist mn))
(setq mn (last mn 2))
(setq mname (concat "." (cadr mn)))
(setcdr mn nil))
(or (setq ml (cdr ml)) (nreverse mlist))))
(if mlist
(setcdr (last mlist) (butlast mn))
(setq mlist (butlast mn))))
(setq mname (concat "." (car (last mn)))))
(setq mname (concat "#" mname)))))
;; generate string
;; Generate the string.
(if (consp mlist)
(setq mlist (mapconcat (function identity) mlist "::")))
(if mname
2012-11-13 Dmitry Gutov <>
* automated/ruby-mode-tests.el (ruby-heredoc-font-lock)
(ruby-singleton-class-no-heredoc-font-lock): New tests.
(ruby-add-log-current-method-examples): New tests.
(ruby-test-string): Extract from ruby-should-indent-buffer.
2012-11-12 Stefan Monnier <>
......@@ -36,11 +36,13 @@
The whitespace before and including \"|\" on each line is removed."
(cl-flet ((fix-indent (s) (replace-regexp-in-string "^[ \t]*|" "" s)))
(insert (fix-indent content))
(indent-region (point-min) (point-max))
(should (string= (fix-indent expected) (buffer-string))))))
(insert (ruby-test-string content))
(indent-region (point-min) (point-max))
(should (string= (ruby-test-string expected) (buffer-string)))))
(defun ruby-test-string (s &rest args)
(apply 'format (replace-regexp-in-string "^[ \t]*|" "" s) args))
(defun ruby-assert-state (content &rest values-plist)
"Assert syntax state values at the end of CONTENT.
......@@ -261,6 +263,26 @@ VALUES-PLIST is a list with alternating index and value elements."
(ruby-assert-face "# #{comment}\n \"#{interpolation}\"" 16
(ert-deftest ruby-add-log-current-method-examples ()
(let ((pairs '(("foo" . "#foo")
("" . ".foo")
("" . ".foo"))))
(loop for (name . value) in pairs
do (with-temp-buffer
(insert (ruby-test-string
"module M
| class C
| def %s
| end
| end
(search-backward "def")
(should (string= (ruby-add-log-current-method)
(format "M::C%s" value)))))))
(provide 'ruby-mode-tests)
;;; ruby-mode-tests.el ends here
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment