Commit 63a71535 authored by Ivan Shmakov's avatar Ivan Shmakov Committed by Noam Postavsky
Browse files

Improve user convenience of the rcirc debug buffer

* lisp/net/rcirc.el (rcirc-debug): Ignore rcirc-debug-buffer read-only
status.  Restore point after insertion unless it was at the end.
Ensure a newline before each [lead].  Replace %Y-%m-%d with the
equivalent %F in format-time-string; remove useless concat.  (Bug#32470)
parent 04e99383
Pipeline #1679 failed with stage
in 52 minutes and 7 seconds
......@@ -679,16 +679,24 @@ last ping."
"If non-nil, write information to `rcirc-debug-buffer'.")
(defun rcirc-debug (process text)
"Add an entry to the debug log including PROCESS and TEXT.
Debug text is written to `rcirc-debug-buffer' if `rcirc-debug-flag'
is non-nil."
Debug text is appended to `rcirc-debug-buffer' if `rcirc-debug-flag'
is non-nil.
For convenience, the read-only state of the debug buffer is ignored.
When the point is at the end of the visible portion of the buffer, it
is moved to after the text inserted. Otherwise the point is not moved."
(when rcirc-debug-flag
(with-current-buffer (get-buffer-create rcirc-debug-buffer)
(let ((old (point-marker)))
(set-marker-insertion-type old t)
(goto-char (point-max))
(insert (concat
(format-time-string "%Y-%m-%dT%T ") (process-name process)
(let ((inhibit-read-only t))
(terpri (current-buffer) t)
(insert "["
(format-time-string "%FT%T ") (process-name process)
"] "
(goto-char old)))))
(define-obsolete-variable-alias 'rcirc-sentinel-hooks
'rcirc-sentinel-functions "24.3")
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment