Commit 656f99be authored by Fabián Ezequiel Gallina's avatar Fabián Ezequiel Gallina
Browse files

Fix completion retrieval parsing.

* progmodes/python.el (python-mode):
(python-util-strip-string): New function.
(python-shell-completion-get-completions): Use it.

* automated/python-tests.el (python-util-strip-string-1): New test.

Fixes: debbugs:17209
parent edd112b7
2014-06-21 Fabián Ezequiel Gallina <>
Fix completion retrieval parsing (bug#17209).
* progmodes/python.el (python-mode):
(python-util-strip-string): New function.
(python-shell-completion-get-completions): Use it.
2014-06-21 Eli Zaretskii <>
* skeleton.el (skeleton-insert): Fix last change.
......@@ -2463,8 +2463,10 @@ LINE is used to detect the context on how to complete given INPUT."
(and completion-code
(> (length input) 0)
(with-current-buffer (process-buffer process)
(let ((completions (python-shell-send-string-no-output
(format completion-code input) process)))
(let ((completions
(format completion-code input) process))))
(and (> (length completions) 2)
(split-string completions
"^'\\|^\"\\|;\\|'$\\|\"$" t)))))))
......@@ -3644,6 +3646,14 @@ returned as is."
n (1- n)))
(reverse acc))))
(defun python-util-strip-string (string)
"Strip STRING whitespace and newlines from end and beginning."
(rx (or (: string-start (* (any whitespace ?\r ?\n)))
(: (* (any whitespace ?\r ?\n)) string-end)))
(defun python-electric-pair-string-delimiter ()
(when (and electric-pair-mode
2014-06-21 Fabián Ezequiel Gallina <>
* automated/python-tests.el (python-util-strip-string-1): New test.
2014-05-08 Glenn Morris <>
* automated/vc-bzr.el (vc-bzr-test-bug9726, vc-bzr-test-bug9781)
......@@ -2706,6 +2706,15 @@ def foo(a, b, c):
(equal (symbol-value (car ccons)) (cdr ccons)))))
(kill-buffer buffer)))
(ert-deftest python-util-strip-string-1 ()
(should (string= (python-util-strip-string "\t\r\n str") "str"))
(should (string= (python-util-strip-string "str \n\r") "str"))
(should (string= (python-util-strip-string "\t\r\n str \n\r ") "str"))
(string= (python-util-strip-string "\n str \nin \tg \n\r") "str \nin \tg"))
(should (string= (python-util-strip-string "\n \t \n\r ") ""))
(should (string= (python-util-strip-string "") "")))
;;; Electricity
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment