Commit 65ac2778 authored by Paul Eggert's avatar Paul Eggert

Port --enable-gcc-warnings to GCC 8

Backport from master.
* lib-src/emacsclient.c (fail):
Do not dereference a null pointer.
* src/frame.c (delete_frame):
Add a decl with UNINIT to work around GCC bug 85563.
* src/menu.h (finish_menu_items):
Do not use attribute const.
* src/regex.c (analyze_first): Use FALLTHROUGH, not a comment.
parent 4b10800b
...@@ -700,7 +700,7 @@ fail (void) ...@@ -700,7 +700,7 @@ fail (void)
{ {
size_t extra_args_size = (main_argc - optind + 1) * sizeof (char *); size_t extra_args_size = (main_argc - optind + 1) * sizeof (char *);
size_t new_argv_size = extra_args_size; size_t new_argv_size = extra_args_size;
char **new_argv = NULL; char **new_argv = xmalloc (new_argv_size);
char *s = xstrdup (alternate_editor); char *s = xstrdup (alternate_editor);
unsigned toks = 0; unsigned toks = 0;
......
...@@ -1933,6 +1933,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force) ...@@ -1933,6 +1933,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
if (f == sf) if (f == sf)
{ {
Lisp_Object tail; Lisp_Object tail;
Lisp_Object frame1 UNINIT; /* This line works around GCC bug 85563. */
eassume (CONSP (Vframe_list)); eassume (CONSP (Vframe_list));
/* Look for another visible frame on the same terminal. /* Look for another visible frame on the same terminal.
......
...@@ -30,7 +30,7 @@ enum { ...@@ -30,7 +30,7 @@ enum {
}; };
extern void init_menu_items (void); extern void init_menu_items (void);
extern void finish_menu_items (void) ATTRIBUTE_CONST; extern void finish_menu_items (void);
extern void discard_menu_items (void); extern void discard_menu_items (void);
extern void save_menu_items (void); extern void save_menu_items (void);
extern bool parse_single_submenu (Lisp_Object, Lisp_Object, Lisp_Object); extern bool parse_single_submenu (Lisp_Object, Lisp_Object, Lisp_Object);
......
...@@ -4038,8 +4038,7 @@ analyze_first (const_re_char *p, const_re_char *pend, char *fastmap, ...@@ -4038,8 +4038,7 @@ analyze_first (const_re_char *p, const_re_char *pend, char *fastmap,
}; };
/* Keep `p1' to allow the `on_failure_jump' we are jumping to /* Keep `p1' to allow the `on_failure_jump' we are jumping to
to jump back to "just after here". */ to jump back to "just after here". */
/* Fallthrough */ FALLTHROUGH;
case on_failure_jump: case on_failure_jump:
case on_failure_keep_string_jump: case on_failure_keep_string_jump:
case on_failure_jump_nastyloop: case on_failure_jump_nastyloop:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment