Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
emacs
emacs
Commits
6fb5f7da
Commit
6fb5f7da
authored
Jul 17, 2008
by
Adrian Robert
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
change most cases of PENDING to TODO, some to FIXME or XXX
parent
32cc3925
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
33 additions
and
17 deletions
+33
-17
src/ChangeLog
src/ChangeLog
+16
-0
src/config.in
src/config.in
+1
-1
src/dispextern.h
src/dispextern.h
+1
-1
src/frame.c
src/frame.c
+1
-1
src/image.c
src/image.c
+1
-1
src/nsfns.m
src/nsfns.m
+8
-8
src/nsterm.h
src/nsterm.h
+2
-2
src/s/darwin.h
src/s/darwin.h
+2
-2
src/xdisp.c
src/xdisp.c
+1
-1
No files found.
src/ChangeLog
View file @
6fb5f7da
2008-07-16 Adrian Robert <Adrian.B.Robert@gmail.com>
* config.in
* dispextern.h
* frame.c
* image.c
* nsfns.m
* nsfont.m
* nsgui.h
* nsmenu.m
* nsterm.h
* nsterm.m
* s/darwin.h
* xdisp.c: Change most cases of PENDING to TODO, some to FIXME or
XXX.
2008-07-17 Andreas Schwab <schwab@suse.de>
* s/cygwin.h (LIB_STANDARD_LIBSRC): Don't define.
...
...
src/config.in
View file @
6fb5f7da
...
...
@@ -997,7 +997,7 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
#define CANNOT_DUMP
#endif
/*
PENDING
: These are used for the Carbon port only. */
/*
TODO
: These are used for the Carbon port only. */
#undef MAC_OS
#undef MAC_OSX
...
...
src/dispextern.h
View file @
6fb5f7da
...
...
@@ -2946,7 +2946,7 @@ struct atimer; /* Defined in atimer.h. */
an hourglass cursor on all frames. */
extern
struct
atimer
*
hourglass_atimer
;
/* Each GUI implements these.
PENDING
: move into RIF. */
/* Each GUI implements these.
FIXME
: move into RIF. */
extern
void
show_hourglass
P_
((
struct
atimer
*
));
extern
void
hide_hourglass
P_
((
void
));
...
...
src/frame.c
View file @
6fb5f7da
...
...
@@ -2986,7 +2986,7 @@ x_set_frame_parameters (f, alist)
old_value
=
get_frame_param
(
f
,
prop
);
fullscreen_is_being_set
|=
EQ
(
prop
,
Qfullscreen
);
#ifndef HAVE_NS
/*
PENDING
: ensure font attrs change goes through */
#ifndef HAVE_NS
/*
XXX
: ensure font attrs change goes through */
if
(
NILP
(
Fequal
(
val
,
old_value
)))
#endif
{
...
...
src/image.c
View file @
6fb5f7da
...
...
@@ -435,7 +435,7 @@ XGetImage (Display *display, Pixmap pixmap, int x, int y,
unsigned int width, unsigned int height,
unsigned long plane_mask, int format)
{
/*
PENDING
: not sure what this function is supposed to do.. */
/*
TODO
: not sure what this function is supposed to do.. */
ns_retain_object(pixmap);
return pixmap;
}
...
...
src/nsfns.m
View file @
6fb5f7da
...
...
@@ -742,7 +742,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
}
/* 23:
PENDING
: there is an erroneous direct call in window.c to this fn */
/* 23:
XXX
: there is an erroneous direct call in window.c to this fn */
void
x_set_menu_bar_lines
(
struct
frame
*
f
,
Lisp_Object
value
,
Lisp_Object
oldval
)
{
...
...
@@ -783,7 +783,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
}
/* 23:
PENDING
: there is an erroneous direct call in window.c to this fn */
/* 23:
XXX
: there is an erroneous direct call in window.c to this fn */
void
x_set_tool_bar_lines
(
struct
frame
*
f
,
Lisp_Object
value
,
Lisp_Object
oldval
)
{
...
...
@@ -912,7 +912,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
}
/*
PENDING
: move to nsterm? */
/*
TODO
: move to nsterm? */
int
ns_lisp_to_cursor_type
(
Lisp_Object
arg
)
{
...
...
@@ -1213,7 +1213,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
"background"
,
"Background"
,
RES_TYPE_STRING
);
x_default_parameter
(
f
,
parms
,
Qcursor_color
,
build_string
(
"grey"
),
"cursorColor"
,
"CursorColor"
,
RES_TYPE_STRING
);
/*
PENDING
: not suppported yet in NS */
/*
FIXME
: not suppported yet in NS */
x_default_parameter
(
f
,
parms
,
Qline_spacing
,
Qnil
,
"lineSpacing"
,
"LineSpacing"
,
RES_TYPE_NUMBER
);
x_default_parameter
(
f
,
parms
,
Qleft_fringe
,
Qnil
,
...
...
@@ -1233,7 +1233,7 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side
x_default_parameter
(
f
,
parms
,
Qtitle
,
Qnil
,
"title"
,
"Title"
,
RES_TYPE_STRING
);
/*
PENDING
: other terms seem to get away w/o this complexity.. */
/*
TODO
: other terms seem to get away w/o this complexity.. */
if
(
NILP
(
Fassq
(
Qwidth
,
parms
)))
{
Lisp_Object
value
...
...
@@ -1610,7 +1610,7 @@ DISPLAY should be either a frame or a display name (a string).\n\
(
display
)
Lisp_Object
display
;
{
/*
PENDING
: return GUI version on GNUSTEP, ?? on OS X */
/*
FIXME
: return GUI version on GNUSTEP, ?? on OS X */
return
build_string
(
"1.0"
);
}
...
...
@@ -2108,7 +2108,7 @@ DISPLAY should be either a frame or a display name (a string).\n\
const
char
*
x_get_string_resource
(
XrmDatabase
rdb
,
char
*
name
,
char
*
class
)
{
/* remove appname prefix;
PENDING
: allow for !="Emacs" */
/* remove appname prefix;
TODO
: allow for !="Emacs" */
char
*
toCheck
=
class
+
(
!
strncmp
(
class
,
"Emacs."
,
6
)
?
6
:
0
);
const
char
*
res
;
check_ns
();
...
...
@@ -2359,7 +2359,7 @@ DISPLAY should be either a frame or a display name (a string).\n\
/* Unused dummy def needed for compatibility. */
Lisp_Object
tip_frame
;
/*
PENDING
: move to xdisp or similar */
/*
TODO
: move to xdisp or similar */
static
void
compute_tip_xy
(
f
,
parms
,
dx
,
dy
,
width
,
height
,
root_x
,
root_y
)
struct
frame
*
f
;
...
...
src/nsterm.h
View file @
6fb5f7da
...
...
@@ -542,7 +542,7 @@ extern struct ns_display_info *ns_display_list;
extern
Lisp_Object
ns_display_name_list
;
extern
struct
ns_display_info
*
ns_display_info_for_name
();
/* 23:
PENDING
: these functions (we defined in nsfns) are used in various
/* 23:
FIXME
: these functions (we defined in nsfns) are used in various
places, but no prototypes are provided */
struct
ns_display_info
*
check_x_display_info
(
Lisp_Object
frame
);
FRAME_PTR
check_x_frame
(
Lisp_Object
frame
);
...
...
@@ -679,7 +679,7 @@ struct x_output
(FRAME_SCROLL_BAR_COLS (f) * FRAME_COLUMN_WIDTH (f) \
- NS_SCROLL_BAR_WIDTH (f)) : 0)
/*
PENDING
: fix for GNUstep inconsistent accounting for titlebar */
/*
XXX
: fix for GNUstep inconsistent accounting for titlebar */
#ifdef NS_IMPL_GNUSTEP
#define NS_TOP_POS(f) ((f)->top_pos + 18)
#else
...
...
src/s/darwin.h
View file @
6fb5f7da
...
...
@@ -206,8 +206,8 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
/* Link in the Carbon or AppKit lib. */
#ifdef HAVE_NS
/*
PENDING
: lresolv is here because configure when testing #undefs res_init,
a macro in /usr/include/resolv.h for res_9_init, not in stdc lib. */
/*
XXX
: lresolv is here because configure when testing #undefs res_init,
a macro in /usr/include/resolv.h for res_9_init, not in stdc lib. */
#define LIBS_MACGUI -framework AppKit -lresolv
#define SYSTEM_PURESIZE_EXTRA 200000
#define HEADERPAD_EXTRA 6C8
...
...
src/xdisp.c
View file @
6fb5f7da
...
...
@@ -11547,7 +11547,7 @@ redisplay_internal (preserve_echo_area)
/* Resized active mini-window to fit the size of what it is
showing if its contents might have changed. */
must_finish = 1;
/*
PENDING
: this causes all frames to be updated, which seems unnecessary
/*
FIXME
: this causes all frames to be updated, which seems unnecessary
since only the current frame needs to be considered. This function needs
to be rewritten with two variables, consider_all_windows and
consider_all_frames. */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment