Commit 975c500d authored by Glenn Morris's avatar Glenn Morris
Browse files

(eshell-gather-process-output): Revert previous change. (re-opens Bug#1388)

parent 7efa8076
2008-11-25 Glenn Morris <rgm@gnu.org>
* eshell/esh-proc.el (eshell-gather-process-output):
Revert previous change. (re-opens Bug#1388)
* select.el (x-set-cut-buffer): Fix signal arguments.
* speedbar.el (speedbar-restricted-move): Fix signal arguments.
2008-11-25 Juanma Barranquero <lekktu@gmail.com>
 
* play/bubbles.el (bubbles-mode): Define with `define-derived-mode'.
......@@ -143,7 +152,7 @@
 
2008-11-24 Dan Nicolaescu <dann@ics.uci.edu>
 
* vc-hg.el (vc-hg-global-switches): Remove.
* vc-hg.el (vc-hg-program): Remove.
(vc-hg-state, vc-hg-working-revision, vc-hg-command):
Undo previous change.
 
......
......@@ -250,27 +250,11 @@ Used only on systems which do not support async subprocesses.")
(cond
((fboundp 'start-process)
(setq proc
;; Bug#1388. Some commands (eg bc) check isatty to decide
;; whether they are being called interactively.
;; A normal shell pipeline has:
;; first: stdin tty , stdout pipe
;; rest : stdin pipe, stdout pipe
;; last : stdin pipe, stdout tty
;; We have:
;; first: stdin tty , stdout tty
;; last : stdin pipe, stdout pipe
;; In other words, the first and last elements have the
;; wrong kind of stdout. (Perhaps this does not matter much...)
;; FIXME which is better for the first element:
;; tty/tty (as now), or pipe/pipe?
(let ((process-connection-type
(unless (and eshell-in-pipeline-p
(not (eq eshell-in-pipeline-p 'first)))
process-connection-type)))
(apply 'start-process
(file-name-nondirectory command) nil
;; `start-process' can't deal with relative filenames
(append (list (expand-file-name command)) args))))
(apply 'start-process
(file-name-nondirectory command) nil
;; `start-process' can't deal with relative
;; filenames
(append (list (expand-file-name command)) args)))
(eshell-record-process-object proc)
(set-process-buffer proc (current-buffer))
(if (eshell-interactive-output-p)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment