Commit 9769d49f authored by Glenn Morris's avatar Glenn Morris
Browse files

(check-declare-scan): Expand .c files relative to src/ directory.

(check-declare-verify): Handle .c files (without arg checking).
parent 3ab75cae
2007-11-22 Glenn Morris <rgm@gnu.org>
* dos-fns.el (int86):
* term/mac-win.el (mac-font-panel-mode): Fix declarations.
* calendar/cal-menu.el (cal-menu-holidays-menu): Fix holiday-list call.
* calendar/holidays.el (holiday-list): Add autoload cookie.
* emacs-lisp/check-declare.el (check-declare-scan): Expand .c
files relative to src/ directory.
(check-declare-verify): Handle .c files (without arg checking).
* emacs-lisp/byte-run.el (declare-function): Doc fix.
2007-11-22 Dan Nicolaescu <dann@ics.uci.edu> 2007-11-22 Dan Nicolaescu <dann@ics.uci.edu>
* replace.el (occur-mode-map): Add a major mode menu with entries * replace.el (occur-mode-map): Add a major mode menu with entries
......
...@@ -34,7 +34,7 @@ ...@@ -34,7 +34,7 @@
;; 1. Handle defstructs (eg uniquify-item-base in desktop.el). ;; 1. Handle defstructs (eg uniquify-item-base in desktop.el).
;; 2. Check C files (look in src/)? ;; 2. Argument checking for functions defined in C.
;;; Code: ;;; Code:
...@@ -56,7 +56,15 @@ ARGLIST may be absent. This claims that FNFILE defines FN, with ARGLIST." ...@@ -56,7 +56,15 @@ ARGLIST may be absent. This claims that FNFILE defines FN, with ARGLIST."
(setq fn (match-string 1) (setq fn (match-string 1)
fnfile (match-string 2)) fnfile (match-string 2))
(or (file-name-absolute-p fnfile) (or (file-name-absolute-p fnfile)
(setq fnfile (expand-file-name fnfile (file-name-directory file)))) (setq fnfile
(expand-file-name fnfile
;; .c files are assumed to be
;; relative to the Emacs src/ directory.
(if (string-equal
"c" (file-name-extension fnfile))
(expand-file-name "src"
source-directory)
(file-name-directory file)))))
(setq alist (cons (setq alist (cons
(list fnfile fn (list fnfile fn
(progn (progn
...@@ -80,25 +88,28 @@ FNFILE with the specified ARGLIST. Returns nil if all claims are ...@@ -80,25 +88,28 @@ FNFILE with the specified ARGLIST. Returns nil if all claims are
found to be true, otherwise a list of errors with elements of the form found to be true, otherwise a list of errors with elements of the form
\(FILE FN TYPE), where TYPE is a string giving details of the error." \(FILE FN TYPE), where TYPE is a string giving details of the error."
(let ((m (format "Checking %s..." fnfile)) (let ((m (format "Checking %s..." fnfile))
(cflag (string-equal "c" (file-name-extension fnfile)))
re fn sig siglist arglist type errlist) re fn sig siglist arglist type errlist)
(message "%s" m) (message "%s" m)
(if (string-equal (file-name-extension fnfile) "c") (or cflag
(progn (file-exists-p fnfile)
(message "%sskipping C file" m)
nil)
(or (file-exists-p fnfile)
(setq fnfile (concat fnfile ".el"))) (setq fnfile (concat fnfile ".el")))
(if (file-exists-p fnfile) (if (file-exists-p fnfile)
(with-temp-buffer (with-temp-buffer
(insert-file-contents fnfile) (insert-file-contents fnfile)
;; defsubst's don't _have_ to be known at compile time. ;; defsubst's don't _have_ to be known at compile time.
(setq re (format "^[ \t]*(\\(def\\(?:un\\|subst\\|\ (setq re (format (if cflag
"^[ \t]*\\(DEFUN\\)[ \t]*([ \t]*\"%s\""
"^[ \t]*(\\(def\\(?:un\\|subst\\|\
ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\ ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\
\[ \t]*%s\\([ \t;]+\\|$\\)" \[ \t]*%s\\([ \t;]+\\|$\\)")
(regexp-opt (mapcar 'cadr fnlist) t))) (regexp-opt (mapcar 'cadr fnlist) t)))
(while (re-search-forward re nil t) (while (re-search-forward re nil t)
(skip-chars-forward " \t\n") (skip-chars-forward " \t\n")
(setq fn (match-string 2) (setq fn (match-string 2)
;; (min . max) for a fixed number of arguments, or
;; arglists with optional elements.
;; (min) for arglists with &rest.
sig (cond ((string-equal (match-string 1) sig (cond ((string-equal (match-string 1)
"define-derived-mode") "define-derived-mode")
'(0 . 0)) '(0 . 0))
...@@ -122,7 +133,9 @@ ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\ ...@@ -122,7 +133,9 @@ ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\
(if (setq sig (assoc (cadr e) siglist)) (if (setq sig (assoc (cadr e) siglist))
;; Recall we use t to mean no arglist specified, ;; Recall we use t to mean no arglist specified,
;; to distinguish from an empty arglist. ;; to distinguish from an empty arglist.
(unless (or (eq arglist t) ;; FIXME c arg checking not yet implemented.
(unless (or cflag
(eq arglist t)
(eq sig t)) (eq sig t))
(unless (equal (byte-compile-arglist-signature arglist) (unless (equal (byte-compile-arglist-signature arglist)
(cdr sig)) (cdr sig))
...@@ -132,7 +145,7 @@ ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\ ...@@ -132,7 +145,7 @@ ine-derived-mode\\|ine-minor-mode\\|alias[ \t]+'\\)\\)\
(when type (when type
(setq errlist (cons (list (car e) (cadr e) type) errlist)))) (setq errlist (cons (list (car e) (cadr e) type) errlist))))
(message "%s%s" m (if errlist "problems found" "OK")) (message "%s%s" m (if errlist "problems found" "OK"))
errlist))) errlist))
(defun check-declare-sort (alist) (defun check-declare-sort (alist)
"Sort a list with elements FILE (FNFILE ...). "Sort a list with elements FILE (FNFILE ...).
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment