Commit a867ead0 authored by Deepak Goel's avatar Deepak Goel
Browse files

Improves calls to `error', per mail from RMS.

parent 3d587afd
2007-12-07 D. Goel <>
* progmodes/idlw-shell.el (idlwave-shell-display-line)
* progmodes/ada-xref.el (ada-find-file, ada-get-all-references)
(ada-xref-find-in-modified-ali, ada-find-in-src-path)
* mail/uce.el (uce-reply-to-uce)
* progmodes/vhdl-mode.el (vhdl-template-modify)
* mail/feedmail.el (feedmail-dump-message-to-queue): Improve calls
to `error' (as suggested by RMS.)
2007-12-07 Glenn Morris <>
* allout.el (allout-write-file-hook-handler):
......@@ -1922,7 +1922,7 @@ mapped to mostly alphanumerics for safety."
;; progn to get nil result no matter what
(progn (make-directory queue-directory t) nil)
(file-accessible-directory-p queue-directory)
(error "%s" (concat "FQM: Message not queued; trouble with directory " queue-directory)))
(error "FQM: Message not queued; trouble with directory %s" queue-directory))
(let ((filename)
......@@ -239,7 +239,7 @@ address, and postmaster of the mail relay used."
(full-header-p (and (eq uce-mail-reader 'rmail)
(not (rmail-msg-is-pruned)))))
(or (get-buffer message-buffer)
(error "%s" (concat "No buffer " message-buffer ", cannot find UCE")))
(error "No buffer %s, cannot find UCE" message-buffer))
(switch-to-buffer message-buffer)
;; We need the message with headers pruned.
(if full-header-p
......@@ -564,7 +564,7 @@ Completion is available."
(let ((file (ada-find-src-file-in-dir filename)))
(if file
(find-file file)
(error "%s" (concat filename " not found in src_dir")))))
(error "%s not found in src_dir" filename))))
;; ----- Utilities -------------------------------------------------
......@@ -1722,8 +1722,8 @@ Information is extracted from the ali file."
;; No more idea to find the declaration. Give up
(kill-buffer ali-buffer)
(error "%s" (concat "No declaration of " (ada-name-of identlist)
" found."))
(error "No declaration of %s found." (ada-name-of identlist))
......@@ -1808,10 +1808,8 @@ This function is disabled for operators, and only works for identifiers."
;; none => error
((= len 0)
(kill-buffer (current-buffer))
(error "%s" (concat "No declaration of "
(ada-name-of identlist)
" recorded in .ali file")))
(error "No declaration of %s recorded in .ali file"
(ada-name-of identlist)))
;; one => should be the right one
((= len 1)
(goto-line (caar declist)))
......@@ -2011,7 +2009,7 @@ the declaration and documentation of the subprograms one is using."
(string-to-number (nth 2 (car list)))
(error "%s" (concat (caar list) " not found in src_dir")))
(error "%s not found in src_dir" (caar list)))
(message "This is only a (good) guess at the cross-reference.")
......@@ -2375,7 +2375,7 @@ matter what the settings of that variable."
(if (not (idlwave-shell-valid-frame frame))
;; fixme: errors are dangerous in shell filters. but i think i
;; have never encountered this one.
(error "%s" (concat "invalid frame - unable to access file: " (car frame)))
(error "invalid frame - unable to access file: %s" (car frame))
;;; buffer : the buffer to display a line in.
;;; select-shell: current buffer is the shell.
......@@ -9095,8 +9095,9 @@ otherwise."
(progn (delete-region (point) (progn (end-of-line) (point)))
(unless noerror
(error "%s" (concat "ERROR: Modification date prefix string \""
vhdl-modify-date-prefix-string "\" not found")))))))
(error "ERROR: Modification date prefix string \"%s\" not found"
(defun vhdl-template-modify-noerror ()
"Call `vhdl-template-modify' with NOERROR non-nil."
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment