Commit aa0214da authored by Dmitry Gutov's avatar Dmitry Gutov
Browse files

Revert 2013-10-05T02:26:39Z!

`last-coding-system-used' is unreliable: it can be modified by other functions
in `after-save-hook'.
parent 544a2a80
......@@ -3,14 +3,6 @@
* progmodes/octave.el (octave-send-region): Call
2013-10-05 Dmitry Gutov <>
* progmodes/ruby-mode.el (ruby-mode): Add `ruby-mode-set-encoding'
to `after-save-hook' instead of `before-save-hook', because then
we know exactly what encoding was used to write the file.
(ruby-mode-set-encoding): Use `last-coding-system-used' instead of
guessing. Call `basic-save-buffer-1' after modifying the buffer.
2013-10-04 Xue Fuqiao <>
* vc/vc-svn.el (vc-svn-find-admin-dir):
......@@ -450,13 +450,19 @@ Also ignores spaces after parenthesis when 'space."
(when (re-search-forward "[^\0-\177]" nil t)
(goto-char (point-min))
(let ((coding-system
(or (coding-system-get last-coding-system-used 'mime-charset)
(coding-system-change-eol-conversion ast-coding-system-used
(or coding-system-for-write
(if coding-system
(setq coding-system
(or (coding-system-get coding-system 'mime-charset)
(coding-system-change-eol-conversion coding-system nil))))
(setq coding-system
(symbol-name (or (and ruby-use-encoding-map
(cdr (assq coding-system ruby-encoding-map)))
(if coding-system
(or (and ruby-use-encoding-map
(cdr (assq coding-system ruby-encoding-map)))
(if (looking-at "^#!") (beginning-of-line 2))
(cond ((looking-at "\\s *#.*-\*-\\s *\\(en\\)?coding\\s *:\\s *\\([-a-z0-9_]*\\)\\s *\\(;\\|-\*-\\)")
(unless (string= (match-string 2) coding-system)
......@@ -470,9 +476,7 @@ Also ignores spaces after parenthesis when 'space."
(insert coding-system)))
((looking-at "\\s *#.*coding\\s *[:=]"))
(t (when ruby-insert-encoding-magic-comment
(insert "# -*- coding: " coding-system " -*-\n"))))
(when (buffer-modified-p)
(insert "# -*- coding: " coding-system " -*-\n"))))))))
(defun ruby-current-indentation ()
"Return the indentation level of current line."
......@@ -1930,7 +1934,11 @@ The variable `ruby-indent-level' controls the amount of indentation.
(set (make-local-variable 'end-of-defun-function)
(add-hook 'after-save-hook 'ruby-mode-set-encoding nil 'local)
(cond ((boundp 'before-save-hook) 'before-save-hook)
((boundp 'write-contents-functions) 'write-contents-functions)
((boundp 'write-contents-hooks) 'write-contents-hooks))
'ruby-mode-set-encoding nil 'local)
(set (make-local-variable 'electric-indent-chars)
(append '(?\{ ?\}) electric-indent-chars))
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment