Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
emacs
emacs
Commits
da03ef8a
Commit
da03ef8a
authored
Nov 09, 2012
by
Stefan Monnier
Browse files
* lisp/subr.el (dolist): Don't bind VAR in RESULT.
parent
6858633a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
3 deletions
+8
-3
etc/NEWS
etc/NEWS
+5
-0
lisp/ChangeLog
lisp/ChangeLog
+2
-0
lisp/subr.el
lisp/subr.el
+1
-3
No files found.
etc/NEWS
View file @
da03ef8a
...
...
@@ -28,6 +28,11 @@ so we will look at it and add it to the manual.
*
Changes in Specialized Modes and Packages in Emacs 24.4
*
New Modes and Packages in Emacs 24.4
*
Incompatible Lisp Changes in Emacs 24.4
** `dolist' in lexical-binding mode does not bind VAR in RESULT any more.
VAR was bound to nil which was not tremendously useful and just lead to
spurious warnings about an unused var.
* Lisp changes in Emacs 24.4
** Docstrings can be made dynamic by adding a `dynamic-docstring-function'
...
...
lisp/ChangeLog
View file @
da03ef8a
2012-11-09 Stefan Monnier <monnier@iro.umontreal.ca>
* subr.el (dolist): Don't bind VAR in RESULT.
* emacs-lisp/advice.el: Miscellaneous cleanup. Use lexical-binding.
(fset, documentation): Don't save real def since we don't advise.
(ad-do-advised-functions): Remove problematic `result-form'.
...
...
lisp/subr.el
View file @
da03ef8a
...
...
@@ -222,9 +222,7 @@ Then evaluate RESULT to get return value, default nil.
(
let
((
,
(
car
spec
)
(
car
,
temp
)))
,@
body
(
setq
,
temp
(
cdr
,
temp
))))
,@
(
if
(
cdr
(
cdr
spec
))
;; FIXME: This let often leads to "unused var" warnings.
`
((
let
((
,
(
car
spec
)
nil
))
,@
(
cdr
(
cdr
spec
))))))
,@
(
cdr
(
cdr
spec
)))
`
(
let
((
,
temp
,
(
nth
1
spec
))
,
(
car
spec
))
(
while
,
temp
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment