Commit de3a1fe9 authored by Chong Yidong's avatar Chong Yidong
Browse files

Fix more save-excursion warnings.

* textmodes/reftex-toc.el (reftex-toc-promote-prepare):
* emacs-lisp/elint.el (elint-add-required-env):
* cedet/semantic/db-find.el (semanticdb-find-translate-path-brutish-default):
* cedet/ede/make.el (ede-make-check-version):
* calendar/icalendar.el (icalendar--add-diary-entry):
* calc/calcalg2.el (math-tracing-integral): Use with-current-buffer instead of save-excursion.
parent 8c3e96d2
2010-02-28 Chong Yidong <cyd@stupidchicken.com>
* textmodes/reftex-toc.el (reftex-toc-promote-prepare):
* emacs-lisp/elint.el (elint-add-required-env):
* cedet/semantic/db-find.el
(semanticdb-find-translate-path-brutish-default):
* cedet/ede/make.el (ede-make-check-version):
* calendar/icalendar.el (icalendar--add-diary-entry):
* calc/calcalg2.el (math-tracing-integral):
* files.el (recover-session-finish): Use with-current-buffer
instead of save-excursion.
......
......@@ -670,8 +670,8 @@
(defmacro math-tracing-integral (&rest parts)
(list 'and
'trace-buffer
(list 'save-excursion
'(set-buffer trace-buffer)
(list 'with-current-buffer
'trace-buffer
'(goto-char (point-max))
(list 'and
'(bolp)
......
......@@ -2246,8 +2246,7 @@ the entry."
'make-diary-entry)
string non-marking diary-file)))
;; Würgaround to remove the trailing blank char
(save-excursion
(set-buffer (find-file diary-file))
(with-current-buffer (find-file diary-file)
(goto-char (point-max))
(if (= (char-before) ? )
(delete-char -1)))
......
......@@ -76,9 +76,8 @@ If NOERROR is nil, then throw an error on failure. Return t otherwise."
(rev nil)
(ans nil)
)
(save-excursion
(with-current-buffer b
;; Setup, and execute make.
(set-buffer b)
(setq default-directory cd)
(erase-buffer)
(call-process ede-make-command nil b nil
......
......@@ -326,9 +326,8 @@ Default action as described in `semanticdb-find-translate-path'."
(cond ((null path) semanticdb-current-database)
((semanticdb-table-p path) (oref path parent-db))
(t (let ((tt (semantic-something-to-tag-table path)))
(save-excursion
;; @todo - What does this DO ??!?!
(set-buffer (semantic-tag-buffer (car tt)))
;; @todo - What does this DO ??!?!
(with-current-buffer (semantic-tag-buffer (car tt))
semanticdb-current-database))))))
(apply
#'nconc
......
......@@ -505,11 +505,10 @@ Return nil if there are no more forms, t otherwise."
;; (Messes up the "Initializing elint..." message.)
;;; (message nil)
(if lib
(save-excursion
(with-current-buffer (find-file-noselect lib)
;; FIXME this doesn't use a temp buffer, because it
;; stores the result in buffer-local variables so that
;; it can be reused.
(set-buffer (find-file-noselect lib))
(elint-update-env)
(setq env (elint-env-add-env env elint-buffer-env)))
;;; (with-temp-buffer
......
......@@ -665,9 +665,8 @@ promotion/demotion later."
(if (and (markerp marker) (marker-buffer marker))
;; Buffer is still live and we have the marker.
(progn
(save-excursion
(with-current-buffer (marker-buffer marker)
;; Goto the buffer and check of section is unchanged
(set-buffer (marker-buffer marker))
(goto-char (marker-position marker))
(if (looking-at (regexp-quote literal))
;; OK, get the makro name
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment