Skip to content

GitLab

Commit e276b428 authored by Artur Malabarba's avatar Artur Malabarba
Browse files
Options

* lisp/emacs-lisp/package.el (package--with-work-buffer-async): 

Fix error handling.
parent 0592cefd
Hide whitespace changes
Inline Side-by-side
Showing with 17 additions and 17 deletions
lisp/emacs-lisp/package.el
View file @ e276b428
...@@ -1136,26 +1136,26 @@ For a description of the other arguments see ...@@ -1136,26 +1136,26 @@ For a description of the other arguments see
;; This `condition-case' is to catch connection errors. ;; This `condition-case' is to catch connection errors.
(condition-case error-signal (condition-case error-signal
(url-retrieve (concat ,location-1 ,file-1) (url-retrieve (concat ,location-1 ,file-1)
;; This is to catch execution errors.
(lambda (status) (lambda (status)
(if-let ((er (plist-get status :error))) (condition-case error-signal
(when (if (functionp ,async-1) (progn
(funcall ,async-1) (when-let ((er (plist-get status :error)))
t) (error "Error retrieving: %s %S" (concat ,location-1 ,file-1) er))
(message "Error contacting: %s" (concat ,location-1 ,file-1)) (goto-char (point-min))
(signal (car er) (cdr er))) (unless (search-forward "\n\n" nil 'noerror)
(goto-char (point-min)) (error "Invalid url response in buffer %s"
(unless (search-forward "\n\n" nil 'noerror) (current-buffer)))
(error "Invalid url response in buffer %s" (delete-region (point-min) (point))
(current-buffer))) ,@body
(delete-region (point-min) (point)) (kill-buffer (current-buffer)))
,@body) (error (when (if (functionp ,async-1) (funcall ,async-1) t)
(kill-buffer (current-buffer))) (signal (car error-signal) (cdr error-signal))))))
nil nil
'silent) 'silent)
(error (when (functionp ,async-1) (error (when (if (functionp ,async-1) (funcall ,async-1) t)
(funcall ,async-1)) (message "Error contacting: %s" (concat ,location-1 ,file-1))
(message "Error contacting: %s" (concat ,location-1 ,file-1)) (signal (car error-signal) (cdr error-signal))))))))
(signal (car error-signal) (cdr error-signal)))))))
(defun package--check-signature-content (content string &optional sig-file) (defun package--check-signature-content (content string &optional sig-file)
"Check signature CONTENT against STRING. "Check signature CONTENT against STRING.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment